Merge pull request #2703 from ace20022/cores_revised

[Cores] Revised with cppcheck

diff --cc xbmc/cores/AudioEngine/AEFactory.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Interfaces/AESink.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkALSA.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkALSA.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkAUDIOTRACK.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkAUDIOTRACK.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkDirectSound.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkDirectSound.h
index a6f2912,630e7c9..baddaea
--- 1/xbmc/cores/AudioEngine/Sinks/AESinkDirectSound.h
--- 2/xbmc/cores/AudioEngine/Sinks/AESinkDirectSound.h
+++ b/xbmc/cores/AudioEngine/Sinks/AESinkDirectSound.h
@@@ -36,10 -36,9 +36,10 @@@ public
  
    virtual bool Initialize  (AEAudioFormat &format, std::string &device);
    virtual void Deinitialize();
-   virtual bool IsCompatible(const AEAudioFormat format, const std::string &device);
+   virtual bool IsCompatible(const AEAudioFormat &format, const std::string &device);
  
    virtual void         Stop               ();
 +  virtual void         Drain              ();
    virtual double       GetDelay           ();
    virtual double       GetCacheTime       ();
    virtual double       GetCacheTotal      ();

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkNULL.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkNULL.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkOSS.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkOSS.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkProfiler.cpp
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkProfiler.h
Simple merge

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkWASAPI.cpp
index 38065cd,e06bbde..ef43428
--- 1/xbmc/cores/AudioEngine/Sinks/AESinkWASAPI.cpp
--- 2/xbmc/cores/AudioEngine/Sinks/AESinkWASAPI.cpp
+++ b/xbmc/cores/AudioEngine/Sinks/AESinkWASAPI.cpp
@@@ -370,12 -351,9 +370,12 @@@ void CAESinkWASAPI::Deinitialize(
    SAFE_RELEASE(m_pDevice);
  
    m_initialized = false;
 +
 +  delete [] m_pBuffer;
 +  m_bufferPtr = 0;
  }
  
- bool CAESinkWASAPI::IsCompatible(const AEAudioFormat format, const std::string &device)
+ bool CAESinkWASAPI::IsCompatible(const AEAudioFormat &format, const std::string &device)
  {
    if (!m_initialized || m_isDirty)
      return false;

diff --cc xbmc/cores/AudioEngine/Sinks/AESinkWASAPI.h
Simple merge

diff --cc xbmc/cores/DllLoader/coff.cpp
Simple merge

diff --cc xbmc/cores/DllLoader/dll_tracker_file.cpp
Simple merge

diff --cc xbmc/cores/VideoRenderers/LinuxRendererGL.cpp
Simple merge

diff --cc xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDAudio.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/DVDCodecUtils.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayText.h
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/Video/CrystalHD.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/Video/CrystalHD.h
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/Video/DXVA.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDCodecs/Video/OpenMax.h
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDDemuxSPU.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxHTSP.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxVobsub.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDFileInfo.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamBluray.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamFile.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamHttp.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamNavigator.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamNavigator.h
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamPVRManager.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDInputStreams/DVDInputStreamTV.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDOverlayContainer.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDPlayer.cpp
Simple merge

diff --cc xbmc/cores/dvdplayer/DVDPlayerAudio.cpp
Simple merge

diff --cc xbmc/cores/omxplayer/OMXPlayer.cpp
Simple merge