1 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
3 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
4 https://bugs.webkit.org/show_bug.cgi?id=67569
6 Reviewed by Antonio Gomes.
11 2011-08-29 Alexey Proskuryakov <ap@apple.com>
13 DumpRenderTree should begin each test with an empty cookie store
14 https://bugs.webkit.org/show_bug.cgi?id=63545
15 <rdar://problem/5666907>
17 Reviewed by Darin Adler.
19 * WebCookieManagerCFNet.cpp:
20 (WebCookieManager::cookieStorage):
21 (WebCookieManager::setCookieStorage):
22 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
23 returns an unretained reference, which we cannot provide any more, but it should not be a
26 * WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated to use currentCFHTTPCookieStorage()
27 instead of currentCookieStorage().
29 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
31 The unused ScrollView* argument can and should be removed from
33 https://bugs.webkit.org/show_bug.cgi?id=67117
35 Reviewed by Darin Adler.
37 * WebCoreSupport/WebChromeClient.h:
38 (WebChromeClient::scrollRectIntoView):
40 2011-08-29 Ryosuke Niwa <rniwa@webkit.org>
42 Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
43 https://bugs.webkit.org/show_bug.cgi?id=67152
45 Reviewed by Darin Adler.
47 Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
48 to HTMLTextFormControlElement.
51 (DOMHTMLInputElement::isUserEdited):
52 (DOMHTMLTextAreaElement::isUserEdited):
54 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
56 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
58 http://trac.webkit.org/changeset/93987
59 http://trac.webkit.org/changeset/93992
60 http://trac.webkit.org/changeset/93995
61 http://trac.webkit.org/changeset/93998
62 http://trac.webkit.org/changeset/93999
63 https://bugs.webkit.org/show_bug.cgi?id=67147
65 Many failing tests (Requested by ap on #webkit).
67 * WebCookieManagerCFNet.cpp:
68 (WebCookieManager::cookieStorage):
69 (WebCookieManager::setCookieStorage):
71 (updateSharedSettingsFromPreferencesIfNeeded):
73 2011-08-29 Alexey Proskuryakov <ap@apple.com>
78 (updateSharedSettingsFromPreferencesIfNeeded):
79 Updated for new function name and signature: currentCFHTTPCookieStorage().
81 2011-08-26 Alexey Proskuryakov <ap@apple.com>
83 DumpRenderTree should begin each test with an empty cookie store
84 https://bugs.webkit.org/show_bug.cgi?id=63545
85 <rdar://problem/5666907>
87 Reviewed by Darin Adler.
89 * WebCookieManagerCFNet.cpp:
90 (WebCookieManager::cookieStorage):
91 (WebCookieManager::setCookieStorage):
92 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
93 returns an unretained reference, which we cannot provide any more, but it should not be a
96 2011-08-17 Adam Roben <aroben@apple.com>
98 Make WebCore keep track of the current device scale factor
100 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
103 Reviewed by Darin Adler.
105 * WebCoreSupport/WebChromeClient.cpp:
106 * WebCoreSupport/WebChromeClient.h:
107 Removed deviceScaleFactor.
109 2011-08-15 Dmitry Titov <dimich@chromium.org>
111 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
112 https://bugs.webkit.org/show_bug.cgi?id=66165
114 Reviewed by Darin Fisher.
116 * WebCoreSupport/WebFrameLoaderClient.cpp:
117 (WebFrameLoaderClient::transferLoadingResourceFromPage):
118 * WebCoreSupport/WebFrameLoaderClient.h:
120 2011-08-15 Adam Roben <aroben@apple.com>
122 Touch a file to trigger a Windows build
124 I'm trying to ferret out some issues with our Debug builder.
126 * WebView.cpp: Sorted #includes.
128 2011-08-10 Adam Roben <aroben@apple.com>
130 Clear up scale factor terminology
132 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
133 software is running, and one that is per-Page and can be controlled via API calls. This
134 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
135 code use those names. It should introduce no behavior changes.
137 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
140 Reviewed by Simon Fraser.
142 * WebCoreSupport/WebChromeClient.cpp:
143 * WebCoreSupport/WebChromeClient.h:
145 2011-08-13 Dan Bernstein <mitz@apple.com>
147 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
149 Reviewed by Joseph Pecoraro.
151 * WebPreferenceKeysPrivate.h:
153 2011-08-13 Dan Bernstein <mitz@apple.com>
158 (WebView::notifyPreferencesChanged):
160 2011-08-12 Dan Bernstein <mitz@apple.com>
162 Add an option to automatically show tooltips (with the full text) over truncated text
163 https://bugs.webkit.org/show_bug.cgi?id=66178
165 Reviewed by Simon Fraser.
167 * Interfaces/IWebPreferencesPrivate.idl: Added accessors.
168 * WebPreferenceKeysPrivate.h: Defined a preference key.
169 * WebPreferences.cpp:
170 (WebPreferences::initializeDefaultSettings): Added a default value of
171 false for the ShowsToolTipOverTruncatedText preference.
172 (WebPreferences::showsToolTipOverTruncatedText): Added this getter.
173 (WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.
176 (WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().
178 2011-08-05 Brent Fulgham <bfulgham@webkit.org>
180 WebView::performLayeredWindowUpdate() crashes with
181 NULL pointer when using layered window updates.
182 https://bugs.webkit.org/show_bug.cgi?id=60618
184 Reviewed by Adam Roben.
186 During resize operations, the backing store will be destroyed if
187 the window's size (either height or width) is set to zero. The
188 bug was identified when a user first resized a WebView to zero
189 dimensions, then attempted to perform a MoveWindow. The paint
190 message triggered by the MoveWindow attempted to use the layered
191 window update logic, which encountered the nulled backing store.
194 (WebView::performLayeredWindowUpdate): Add an early
195 return when there is no backing store to blend with.
197 2011-08-05 Anders Carlsson <andersca@apple.com>
200 https://bugs.webkit.org/show_bug.cgi?id=65729
202 Reviewed by Darin Adler.
204 Remove plug-in halter and associated classes.
206 * Interfaces/IWebPluginHalterDelegate.idl: Removed.
207 * Interfaces/IWebPreferencesPrivate.idl:
208 * Interfaces/IWebViewPrivate.idl:
209 * Interfaces/WebKit.idl:
210 * WebCoreSupport/WebPluginHalterClient.cpp: Removed.
211 * WebCoreSupport/WebPluginHalterClient.h: Removed.
212 * WebKit.vcproj/Interfaces.vcproj:
213 * WebKit.vcproj/WebKit.vcproj:
214 * WebPreferenceKeysPrivate.h:
215 * WebPreferences.cpp:
216 (WebPreferences::initializeDefaultSettings):
220 (WebView::initWithFrame):
221 (WebView::notifyPreferencesChanged):
229 2011-08-04 Jeff Miller <jeffm@apple.com>
231 Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
232 https://bugs.webkit.org/show_bug.cgi?id=65718
234 Reviewed by Adam Roben.
236 * Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
238 * WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
240 * WebPreferences.cpp:
241 (WebPreferences::avFoundationEnabled): Added.
242 (WebPreferences::setAVFoundationEnabled): Added.
244 * WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
247 (WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
249 2011-08-03 Kent Tamura <tkent@chromium.org>
251 [Windows] Fix build without ENABLE_VIDEO.
254 (WebView::enterFullscreenForNode):
256 2011-08-03 Kent Tamura <tkent@chromium.org>
258 Fix incorrect checks for HTMLMediaElement
259 https://bugs.webkit.org/show_bug.cgi?id=65590
261 Reviewed by Dimitri Glazkov.
263 <video> and <audio> can be an HTMLElement instance instead of
264 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
265 the media feature is disabled at runtime.
268 (WebView::enterFullscreenForNode):
270 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
272 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
273 https://bugs.webkit.org/show_bug.cgi?id=65582
275 Reviewed by Pavel Feldman.
277 * WebCoreSupport/WebInspectorClient.cpp:
278 * WebCoreSupport/WebInspectorClient.h:
280 2011-08-03 Adam Roben <aroben@apple.com>
282 Windows nightly build fix after r91777
284 * Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
285 interface to maintain binary compatibility with Safari 5.1.
287 2011-08-03 Pavel Feldman <pfeldman@google.com>
289 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
290 https://bugs.webkit.org/show_bug.cgi?id=65510
292 Reviewed by Yury Semikhatsky.
294 * WebNodeHighlight.cpp:
295 (WebNodeHighlight::update):
297 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
299 Web Inspector: remove Node parameter from the InspectorClient::highlight
300 https://bugs.webkit.org/show_bug.cgi?id=65549
302 Reviewed by Yury Semikhatsky.
304 * WebCoreSupport/WebInspectorClient.cpp:
305 (WebInspectorClient::highlight):
306 * WebCoreSupport/WebInspectorClient.h:
308 2011-07-31 Daniel Bates <dbates@webkit.org>
310 Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
312 * WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
313 * WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
315 2011-07-30 Patrick Gansterer <paroga@webkit.org>
317 Remove inclusion of MainThread.h from Threading.h
318 https://bugs.webkit.org/show_bug.cgi?id=65081
320 Reviewed by Darin Adler.
322 Add missing include statements for MainThread.
324 * WebKitClassFactory.cpp:
327 2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
329 Add support for download='filename' attribute in anchors.
330 https://bugs.webkit.org/show_bug.cgi?id=64580
332 Reviewed by Adam Barth.
335 (WebFrame::startDownload):
338 2011-07-26 Dan Bernstein <mitz@apple.com>
340 <rdar://problem/9842889> Add a generic pictograph font family
341 https://bugs.webkit.org/show_bug.cgi?id=65197
343 Reviewed by Anders Carlsson.
345 * Interfaces/IWebPreferences.idl: Added pictographFontFamily() and
346 setPictographFontFamily().
347 * WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
348 * WebPreferences.cpp:
349 (WebPreferences::initializeDefaultSettings): Initialize the pictograph font
350 preference to "Times New Roman".
351 (WebPreferences::pictographFontFamily): Added this getter.
352 (WebPreferences::setPictographFontFamily): Added this setter.
355 (WebView::notifyPreferencesChanged): Pass the preference value through to
358 2011-07-18 Dean Jackson <dino@apple.com>
360 https://bugs.webkit.org/show_bug.cgi?id=64742
361 Expose WebPreferences for media playback requiring user gestures and inline playback
363 Reviewed by Simon Fraser.
365 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
366 MediaPlaybackAllowsInline.
368 * Interfaces/IWebPreferencesPrivate.idl:
369 * WebPreferenceKeysPrivate.h:
370 * WebPreferences.cpp:
371 (WebPreferences::initializeDefaultSettings):
372 (WebPreferences::setMediaPlaybackRequiresUserGesture):
373 (WebPreferences::mediaPlaybackRequiresUserGesture):
374 (WebPreferences::setMediaPlaybackAllowsInline):
375 (WebPreferences::mediaPlaybackAllowsInline):
378 (WebView::notifyPreferencesChanged):
380 2011-07-16 Simon Fraser <simon.fraser@apple.com>
382 Add code to attempt to align compositing layers to pixel boundaries when page scale changes
383 https://bugs.webkit.org/show_bug.cgi?id=64658
385 Reviewed by Dan Bernstein.
387 Removed implementations of backingScaleFactor() and pageScaleFactor() now
388 that GraphicsLayerClient has default implementations.
392 2011-07-15 Simon Fraser <simon.fraser@apple.com>
397 (WebView::backingScaleFactor):
398 (WebView::pageScaleFactor):
400 2011-07-15 Dan Bernstein <mitz@apple.com>
402 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
403 https://bugs.webkit.org/show_bug.cgi?id=64615
405 Reviewed by Anders Carlsson.
407 * WebCoreSupport/WebChromeClient.cpp:
408 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
409 * WebCoreSupport/WebChromeClient.h:
411 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
413 ApplicationCache update should not immediately fail when reaching per-origin quota
414 https://bugs.webkit.org/show_bug.cgi?id=64177
416 Reviewed by Alexey Proskuryakov.
418 * WebCoreSupport/WebChromeClient.cpp:
419 (WebChromeClient::reachedApplicationCacheOriginQuota):
420 * WebCoreSupport/WebChromeClient.h:
422 2011-07-11 Hironori Bono <hbono@chromium.org>
424 Reviewed by Adam Roben.
426 Implement layoutTestController.setTextDirection for WebKit2 and Windows.
427 https://bugs.webkit.org/show_bug.cgi?id=61931
429 This change implements layoutTextController.setTextDirection for WebKit2
430 and Windows so we can run a layout test added by r87770 on them. Each
431 implementation adds a wrapper function for Editor::setBaseWritingDirection()
432 so LayoutTestController can call it.
434 * Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow
435 LayoutTestController to change the text direction.
436 * WebFrame.cpp: ditto.
437 (WebFrame::setTextDirection):
440 2011-07-08 Chang Shu <cshu@webkit.org>
442 Update calling sites after function renamed.
443 https://bugs.webkit.org/show_bug.cgi?id=59114
445 Reviewed by Alexey Proskuryakov.
447 * WebKitGraphics.cpp:
450 2011-06-30 Anders Carlsson <andersca@apple.com>
452 Reviewed by Dan Bernstein.
454 More ScrollableArea scaffolding
455 https://bugs.webkit.org/show_bug.cgi?id=63678
458 (WebScrollBar::enclosingScrollableArea):
459 Always return 0, WebScrollbar has no concept of an enclosing scrollable area.
461 2011-06-28 Ilya Sherman <isherman@chromium.org>
463 Reviewed by Adam Barth.
465 form.autocomplete="off" does not work
466 https://bugs.webkit.org/show_bug.cgi?id=35823
469 (WebFrame::elementDoesAutoComplete): Updated callsite.
471 2011-06-27 Brent Fulgham <bfulgham@webkit.org>
473 Reviewed by Adam Roben.
475 Avoid attempt to create a zero-size DIB.
476 https://bugs.webkit.org/show_bug.cgi?id=63484.
478 * WebNodeHighlight.cpp:
479 (WebNodeHighlight::update): Check for zero-height (or zero-width)
480 region for DIB, and exit early if attempting to create a zero-size
483 2011-06-24 Dan Bernstein <mitz@apple.com>
485 Reviewed by Anders Carlsson.
487 Add an option to enable legacy rounding hacks
488 https://bugs.webkit.org/show_bug.cgi?id=63363
490 * WebKitGraphics.cpp:
491 (CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
492 (RightTruncateStringToWidth): Ditto.
494 2011-06-24 Yuta Kitamura <yutak@chromium.org>
496 Reviewed by Adam Barth.
498 WebSocket: Add run-time flag for new HyBi protocol
499 https://bugs.webkit.org/show_bug.cgi?id=60348
501 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
502 switchable from WebView and WebPreferences.
504 * Interfaces/IWebPreferencesPrivate.idl:
505 * WebPreferenceKeysPrivate.h:
506 * WebPreferences.cpp:
507 (WebPreferences::initializeDefaultSettings):
508 (WebPreferences::setHixie76WebSocketProtocolEnabled):
509 (WebPreferences::hixie76WebSocketProtocolEnabled):
512 (WebView::notifyPreferencesChanged):
514 2011-06-22 Dominic Cooney <dominicc@chromium.org>
516 Reviewed by Mark Rowe.
518 Add window.internals to WebKit2's WebKitTestRunner.
519 https://bugs.webkit.org/show_bug.cgi?id=61073
521 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
523 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
525 Reviewed by Kent Tamura.
527 FileChooser should be only created when we need to choose files.
528 https://bugs.webkit.org/show_bug.cgi?id=63039
530 * WebCoreSupport/WebChromeClient.cpp:
531 (WebChromeClient::runOpenPanel): Changed to use settings.
533 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
535 Unreviewed, rolling out r89354.
536 http://trac.webkit.org/changeset/89354
537 https://bugs.webkit.org/show_bug.cgi?id=63099
539 Broke tests on Mac (Requested by rniwa on #webkit).
541 * WebCoreSupport/WebInspectorClient.cpp:
542 (WebInspectorClient::WebInspectorClient):
543 (WebInspectorClient::openInspectorFrontend):
544 (WebInspectorFrontendClient::destroyInspectorView):
545 * WebCoreSupport/WebInspectorClient.h:
547 (WebInspector::createInstance):
548 (WebInspector::WebInspector):
549 (WebInspector::webViewClosed):
550 (WebInspector::showConsole):
551 (WebInspector::isDebuggingJavaScript):
552 (WebInspector::toggleDebuggingJavaScript):
553 (WebInspector::isProfilingJavaScript):
554 (WebInspector::toggleProfilingJavaScript):
555 (WebInspector::isJavaScriptProfilingEnabled):
556 (WebInspector::setJavaScriptProfilingEnabled):
557 (WebInspector::isTimelineProfilingEnabled):
558 (WebInspector::setTimelineProfilingEnabled):
563 (WebView::initWithFrame):
564 (WebView::inspector):
567 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
569 Reviewed by Yury Semikhatsky.
571 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
572 https://bugs.webkit.org/show_bug.cgi?id=62985
574 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
575 methods for plumbing the menu action handlers through the WebKit and WebCore.
576 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
577 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
578 WebKit/win and WebKit2 to follow.
581 (WebInspector::createInstance):
582 (WebInspector::WebInspector):
583 (WebInspector::webViewClosed):
584 (WebInspector::showConsole):
585 (WebInspector::isDebuggingJavaScript):
586 (WebInspector::toggleDebuggingJavaScript):
587 (WebInspector::isProfilingJavaScript):
588 (WebInspector::toggleProfilingJavaScript):
589 (WebInspector::isJavaScriptProfilingEnabled):
590 (WebInspector::setJavaScriptProfilingEnabled):
591 (WebInspector::isTimelineProfilingEnabled):
592 (WebInspector::setTimelineProfilingEnabled):
597 (WebView::initWithFrame):
598 (WebView::inspector):
601 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
603 Reviewed by Darin Adler.
605 Separate concerns of loading file icons and choosing files.
606 https://bugs.webkit.org/show_bug.cgi?id=62931
608 * WebCoreSupport/WebChromeClient.cpp:
609 (WebChromeClient::loadIconForFiles): Renamed.
610 * WebCoreSupport/WebChromeClient.h:
612 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
614 Unreviewed, rolling out r89026.
615 http://trac.webkit.org/changeset/89026
616 https://bugs.webkit.org/show_bug.cgi?id=62804
618 These patches were likely correct. I'll investigate the
619 browser_test failures. (Requested by abarth on #webkit).
621 * FullscreenVideoController.cpp:
622 (FullscreenVideoController::play):
623 (FullscreenVideoController::pause):
625 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
629 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
630 https://bugs.webkit.org/show_bug.cgi?id=62796
632 The patches broke chromium browser tests.
634 * FullscreenVideoController.cpp:
635 (FullscreenVideoController::play):
636 (FullscreenVideoController::pause):
638 2011-06-16 Adam Barth <abarth@webkit.org>
640 Reviewed by Eric Seidel.
642 Remove HTMLVideoElement::processingUserGesture
643 https://bugs.webkit.org/show_bug.cgi?id=62784
645 * FullscreenVideoController.cpp:
646 (FullscreenVideoController::play):
647 (FullscreenVideoController::pause):
649 2011-06-13 Kentaro Hara <haraken@google.com>
651 Reviewed by Alexey Proskuryakov.
653 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
654 https://bugs.webkit.org/show_bug.cgi?id=61256
656 In order to prevent rounding error caused by expanding/shrinking a page
657 using different calculation here and there, I added a common calculation
658 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
659 keeping the ratio of width and height of the original page.
660 WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
661 expand/shrink a page.
663 Test: printing/page-count-with-one-word.html
666 (WebFrame::setPrinting):
667 (WebFrame::setInPrintingMode):
670 2011-06-12 MORITA Hajime <morrita@google.com>
672 Unreviewed, rolling out r88625.
673 http://trac.webkit.org/changeset/88625
674 https://bugs.webkit.org/show_bug.cgi?id=61073
676 Breaks SL Webkit2 Tests
678 * WebKit.vcproj/WebKit.sln:
680 2011-06-12 Adam Barth <abarth@webkit.org>
682 Reviewed by Alexey Proskuryakov.
684 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
685 https://bugs.webkit.org/show_bug.cgi?id=62516
688 (WebFrame::interruptedForPolicyChangeError):
691 2011-06-12 Dominic Cooney <dominicc@chromium.org>
693 Reviewed by Hajime Morita.
695 Add window.internals to WebKit2's WebKitTestRunner.
696 https://bugs.webkit.org/show_bug.cgi?id=61073
698 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
700 2011-06-12 Adam Barth <abarth@webkit.org>
702 Reviewed by Alexey Proskuryakov.
704 Remove trival "forward-to-client" member functions from FrameLoader
705 https://bugs.webkit.org/show_bug.cgi?id=62510
707 * WebCoreSupport/WebFrameNetworkingContext.cpp:
708 (WebFrameNetworkingContext::blockedError):
710 2011-06-06 Michael Saboff <msaboff@apple.com>
712 Reviewed by Geoffrey Garen.
714 Fonts returned by FontCache::getFontDataForCharacters() are never released
715 https://bugs.webkit.org/show_bug.cgi?id=61875
717 This change allows fonts allocated as system fallback fonts to be
718 released. Previously, the reference counts for these fonts grew
719 without bound. This is implemented as an auto release class that wraps
720 accesses to the cache for system fallback fonts. All such accesses are
721 via the method FontCache::getFontDataForCharacters. The new class is
722 called FontCachePurgePreventer. When such an object exists, it protects
723 these fonts from deletion.
725 See more comments for this defect in Source/WebCore/ChangeLog.
727 * WebKitGraphics.cpp:
728 (CenterTruncateStringToWidth):
729 (RightTruncateStringToWidth):
730 Wrapped code accessing fallback fonts with local
731 FontCachePurgePreventer in these methods.
733 2011-06-04 Dominic Cooney <dominicc@chromium.org>
735 Reviewed by Dimitri Glazkov.
737 Add WebCoreTestSupport project containing window.internals.
738 https://bugs.webkit.org/show_bug.cgi?id=61076
740 * WebKit.vcproj/WebKit.sln:
742 2011-05-18 Anthony Johnson <anthony.johnson@flexsim.com>
744 Reviewed by Brent Fulgham.
746 Implement the ability to add C++ event listeners to html dom
747 elements and dom window.
748 https://bugs.webkit.org/show_bug.cgi?id=60269
750 * DOMCoreClasses.cpp: Add new DOMWindow class and implementations.
751 (DOMNode::QueryInterface): Report that the DOMNode implements
752 the IDomEventTarget interface.
753 (DOMNode::addEventListener): Add implementation of a COM-based
755 (DOMNode::removeEventListener):
756 (DOMNode::dispatchEvent):
757 (DOMDocument::createInstance):
758 (DOMWindow::QueryInterface): New implementation.
759 (DOMWindow::document): New implementation.
760 (DOMWindow::getComputedStyle): Stub.
761 (DOMWindow::getMatchedCSSRules): Stub.
762 (DOMWindow::devicePixelRatio): Stub.
763 (DOMWindow::addEventListener): New implementation.
764 (DOMWindow::removeEventListener): New implementation.
765 (DOMWindow::dispatchEvent): New implementation.
766 (DOMWindow::DOMWindow): New implementation.
767 (DOMWindow::~DOMWindow): New implementation.
768 (DOMWindow::createInstance): New implementation.
769 * DOMCoreClasses.h: Add new DOMWindow class and declarations.
770 (DOMWindow::AddRef): New declaration.
771 (DOMWindow::Release): New declaration.
772 (DOMWindow::throwException): New declaration.
773 (DOMWindow::callWebScriptMethod): New declaration.
774 (DOMWindow::evaluateWebScript): New declaration.
775 (DOMWindow::removeWebScriptKey): New declaration.
776 (DOMWindow::stringRepresentation): New declaration.
777 (DOMWindow::webScriptValueAtIndex): New declaration.
778 (DOMWindow::setWebScriptValueAtIndex): New declaration.
779 (DOMWindow::setException): New declaration.
780 (DOMWindow::window): New declaration.
781 * DOMEventsClasses.cpp: Add new WebEventListener and implementation.
782 (DOMEventListener::handleEvent): New implementation.
783 (WebEventListener::WebEventListener): New implementation.
784 (WebEventListener::~WebEventListener): New implementation.
785 (WebEventListener::operator==): New implementation.
786 (WebEventListener::handleEvent): New implementation.
787 (WebEventListener::create): New implementation.
788 * DOMEventsClasses.h: Add new WebEventListener class declaration.
789 * Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the
790 main Web Frame interface.
791 * WebFrame.cpp: Add implementation of new DOMWindow creation method.
792 (WebFrame::DOMWindow):
793 * WebFrame.h: Add DOMWindow declaration.
795 2011-05-20 Simon Fraser <simon.fraser@apple.com>
797 Reviewed by Sam Weinig.
799 numberOfActiveAnimations() can include animations from documents in the page cache
800 https://bugs.webkit.org/show_bug.cgi?id=53641
802 Pass the Frame's document as the one to count animations on.
805 (WebFrame::numberOfActiveAnimations):
807 2011-05-20 Jer Noble <jer.noble@apple.com>
809 Reviewed by Maciej Stachowiak.
811 Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
812 https://bugs.webkit.org/show_bug.cgi?id=61108
815 (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the
816 full screen controller.
819 2011-05-13 Jon Lee <jonlee@apple.com>
821 Reviewed by Simon Fraser.
823 Can't horizontally scroll iframes and overflow because wheel events are always accepted
824 https://bugs.webkit.org/show_bug.cgi?id=60779
826 * WebCoreSupport/WebChromeClient.h:
827 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
828 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
830 2011-05-13 Sam Weinig <sam@webkit.org>
832 Reviewed by Anders Carlsson.
834 Prune #includes from FrameView.h (Part 2)
835 https://bugs.webkit.org/show_bug.cgi?id=60748
837 - Update files that were depending on FrameView.h #including Frame.h or
840 * WebCoreSupport/WebChromeClient.cpp:
841 * WebCoreSupport/WebDragClient.cpp:
842 * WebCoreSupport/WebFrameLoaderClient.cpp:
844 (WebFrame::setPrinting):
847 2011-05-12 Patrick Gansterer <paroga@webkit.org>
849 Reviewed by Adam Barth.
851 Enable OwnPtr strict mode in PluginHalter
852 https://bugs.webkit.org/show_bug.cgi?id=60681
855 (WebView::initWithFrame):
857 2011-05-12 Adam Roben <aroben@apple.com>
859 A little gtest cleanup after r86287
861 * WebKit.vcproj/WebKit.sln:
862 - Move gtest into the Tools folder
863 - Make gtest build just before TestWebKitAPIGenerated
864 - Use gtest's new Debug_All and Production configurations as appropriate
866 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
868 Reviewed by Darin Adler.
870 String operator+ reallocates unnecessarily when concatting > 2 strings
871 https://bugs.webkit.org/show_bug.cgi?id=58420
873 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
875 * AccessibleBase.cpp:
876 (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
878 2011-05-11 Dmitry Lomov <dslomov@google.com>
880 Reviewed by David Levin.
882 https://bugs.webkit.org/show_bug.cgi?id=59561
883 Switch TestWebKitAPI to GTest
885 Fixes Makefiles and WinCairo build as well
887 * WebKit.vcproj/WebKit.sln:
889 2011-05-11 Jessie Berlin <jberlin@apple.com>
891 Reviewed by Steve Falkenburg.
893 [Windows WebKit2] Use cookies set in WebKit1
894 https://bugs.webkit.org/show_bug.cgi?id=60274
897 (WebView::setCacheModel):
898 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
900 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
902 Unreviewed, rolling out r86255.
903 http://trac.webkit.org/changeset/86255
904 https://bugs.webkit.org/show_bug.cgi?id=60660
906 REGRESSION (r86255): Lots of tests crashing in
907 CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
908 (WebKit2 Tests) (Requested by aroben on #webkit).
911 (WebView::setCacheModel):
913 2011-05-11 Jessie Berlin <jberlin@apple.com>
915 Reviewed by Steve Falkenburg.
917 [Windows WebKit2] Use cookies set in WebKit1
918 https://bugs.webkit.org/show_bug.cgi?id=60274
921 (WebView::setCacheModel):
922 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
924 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
926 Unreviewed, rolling out r86108.
927 http://trac.webkit.org/changeset/86108
928 https://bugs.webkit.org/show_bug.cgi?id=60533
930 Broke makefile based builds and Cairo (Requested by weinig on
933 * WebKit.vcproj/WebKit.sln:
935 2011-05-09 Dmitry Lomov <dslomov@google.com>
937 Reviewed by Sam Weinig.
939 Switch TestWebKitAPI to GTest
940 https://bugs.webkit.org/show_bug.cgi?id=59561
942 * WebKit.vcproj/WebKit.sln:
944 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
946 Unreviewed, rolling out r86016.
947 http://trac.webkit.org/changeset/86016
948 https://bugs.webkit.org/show_bug.cgi?id=60445
950 caused crashes on the WK2 Windows bots (Requested by
951 jessieberlin on #webkit).
954 (WebView::setCacheModel):
956 2011-05-07 Jessie Berlin <jberlin@apple.com>
958 Reviewed by Steve Falkenburg.
960 [Windows WebKit2] Use cookies set in WebKit1
961 https://bugs.webkit.org/show_bug.cgi?id=60274
964 (WebView::setCacheModel):
965 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
967 2011-05-06 Adam Roben <aroben@apple.com>
969 Touch WebKit.idl to fix the build
971 I needed this on my own machine. Maybe others will need it, too.
973 * Interfaces/WebKit.idl:
975 2011-05-04 Philippe Normand <pnormand@igalia.com>
977 Reviewed by Dimitri Glazkov.
979 Implement LayoutTestController::pseudoShadowId()
980 https://bugs.webkit.org/show_bug.cgi?id=60034
982 * DOMCoreClasses.cpp:
983 (DOMElement::shadowPseudoId):
986 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
988 Reviewed by Eric Seidel.
990 Rename SelectionController to FrameSelection
991 https://bugs.webkit.org/show_bug.cgi?id=60234
995 2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
997 Windows build fix attempt after r85823
999 * WebCoreSupport/WebChromeClient.h:
1000 (WebChromeClient::webView):
1004 2011-05-04 Cris Neckar <cdn@chromium.org>
1006 Reviewed by Adam Barth.
1008 Expose WebView directly through ChromeClient.
1009 https://bugs.webkit.org/show_bug.cgi?id=49902
1011 * WebCoreSupport/WebChromeClient.h:
1012 (WebChromeClient::webView):
1014 2011-05-04 Tao Bai <michaelbai@chromium.org>
1016 Reviewed by David Kilzer.
1018 Populate touch-icon url to FrameLoaderClient
1019 https://bugs.webkit.org/show_bug.cgi?id=59143
1021 Respect the interface change in FrameLoaderClient.
1023 * WebCoreSupport/WebFrameLoaderClient.cpp:
1024 (WebFrameLoaderClient::dispatchDidChangeIcons):
1025 * WebCoreSupport/WebFrameLoaderClient.h:
1027 2011-05-02 Jer Noble <jer.noble@apple.com>
1029 Reviewed by Adam Roben.
1031 Implement FULLSCREEN_API on Windows, Part 3: WebKit2
1032 https://bugs.webkit.org/show_bug.cgi?id=59845
1034 Implementation of WebFullScreenController has been moved into WebCore, and
1035 required virutal functions of WebFullScreenControllerClient have been added to
1036 WebView. These functions are mostly simple accessors of existing ivars, but
1037 m_fullScreenElement and its accessors have also been added to WebView.
1039 * WebCoreSupport/WebChromeClient.cpp:
1040 (WebChromeClient::enterFullScreenForElement):
1041 * WebFullScreenController.cpp: Removed.
1042 * WebKit.vcproj/WebKit.vcproj:
1044 (WebView::setFullScreenElement): Added accessor.
1045 (WebVIew::fullScreenElement): Ditto.
1046 (WebView::fullScreenClientWindow): Ditto.
1047 (WebView::fullScreenClientParentWindow): Ditto.
1048 (WebView::fullScreenClientSetParentWindow): Ditto.
1049 (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
1050 (WebView::fullScreenClientDidEnterFullScreen): Ditto.
1051 (WebView::fullScreenClientWillExitFullScreen): Ditto.
1052 (WebView::fullScreenClientDidExitFullScreen): Ditto.
1055 2011-05-03 Brian Weinstein <bweinstein@apple.com>
1057 Reviewed by Steve Falkenburg.
1059 REGRESSION(r84990): Nightly builds don't launch on Windows
1060 https://bugs.webkit.org/show_bug.cgi?id=60081
1061 <rdar://problem/9358635>
1063 Fix nightlies on Window by moving the layered window functions to the bottom
1064 of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.
1066 * Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
1067 * Interfaces/WebKit.idl: Touch to force a rebuild.
1069 2011-05-03 David Kilzer <ddkilzer@apple.com>
1071 <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
1073 Reviewed by Antti Koivisto.
1075 * Interfaces/IWebViewPrivate.idl:
1076 (IWebViewPrivate::httpPipeliningEnabled): Added declaration.
1077 (IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
1079 (WebView::httpPipeliningEnabled): Added.
1080 (WebView::setHTTPPipeliningEnabled): Added.
1082 (WebView::httpPipeliningEnabled): Added declaration.
1083 (WebView::setHTTPPipeliningEnabled): Added declaration.
1085 2011-05-03 Adam Roben <aroben@apple.com>
1087 Add some missing virtual keywords on derived-class destructors
1089 Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
1090 just matches our style of explicitly marking overrides "virtual".
1092 * WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
1093 WebInspectorFrontendClient destructors explicitly virtual.
1095 2011-05-03 Adam Roben <aroben@apple.com>
1097 Fix most strict PassOwnPtr violations on Windows
1099 Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
1102 Reviewed by Anders Carlsson.
1104 * WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
1105 that this type is put into a PassOwnPtr. (Previously, only
1106 WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)
1108 * FullscreenVideoController.cpp:
1109 * WebCoreSupport/WebFrameLoaderClient.cpp:
1110 * WebCoreSupport/WebInspectorClient.cpp:
1112 * WebHistoryItem.cpp:
1115 2011-05-01 Sam Weinig <sam@webkit.org>
1121 2011-05-01 Patrick Gansterer <paroga@webkit.org>
1123 Reviewed by Adam Barth.
1125 Fix OwnPtr strict issues in windows build
1126 https://bugs.webkit.org/show_bug.cgi?id=59878
1128 * FullscreenVideoController.cpp:
1129 (FullscreenVideoController::FullscreenVideoController):
1130 (FullscreenVideoController::createHUDWindow):
1131 * WebCoreSupport/WebInspectorClient.cpp:
1132 (WebInspectorClient::highlight):
1133 * WebElementPropertyBag.cpp:
1134 (WebElementPropertyBag::WebElementPropertyBag):
1135 * WebNodeHighlight.cpp:
1136 (WebNodeHighlight::update):
1137 * WebNotificationCenter.cpp:
1138 (WebNotificationCenter::WebNotificationCenter):
1142 (WebView::handleMouseEvent):
1143 (WebView::registerEmbeddedViewMIMEType):
1145 2011-04-29 Jer Noble <jer.noble@apple.com>
1147 Reviewed by Adam Roben.
1149 Implement FULLSCREEN_API on Windows, Part 2: WebKit
1150 https://bugs.webkit.org/show_bug.cgi?id=59785
1152 Initial implementation of full screen API on windows. No animation
1153 occurs when entering or exiting full screen. Re-use existing window
1154 classes (MediaPlayerPrivateFullscreenWindow) to host the webView.
1156 * WebCoreSupport/WebChromeClient.cpp:
1157 (WebChromeClient::supportsFullScreenForElement): Call into WebView.
1158 (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController.
1159 (WebChromeClient::exitFullScreenForElement): Ditto.
1160 * WebFullScreenController.cpp: Added.
1161 (WebFullScreenController::Private::Private): Private data storage class.
1162 (WebFullScreenController::Private::~Private):
1163 (WebFullScreenController::Private::fullscreenClientWndProc): Handle window
1164 message for full screen window.
1165 (WebFullScreenController::WebFullScreenController):
1166 (WebFullScreenController::~WebFullScreenController):
1167 (WebFullScreenController::setElement): Added.
1168 (WebFullScreenController::element): Added.
1169 (WebFullScreenController::isFullScreen): Added.
1170 (WebFullScreenController::enterFullScreen): Create and display full screen
1171 window, moving webView as child window.
1172 (WebFullScreenController::exitFullScreen): Destroy full screen window and
1173 move webView back where we found it.
1174 * WebFullScreenController.h: Added.
1175 * WebKit.vcproj/WebKit.vcproj:
1177 (WebView::keyDown): Handle the ESC key.
1178 (WebView::notifyPreferencesChanged):
1179 (WebView::supportsFullScreenForElement): Do not support full screen if
1180 full screen preference is disabled, or if keyboard access is requested.
1181 (WebView::isFullScreen): Added.
1182 (WebView::fullScreenController): Added.
1185 2011-04-28 Jer Noble <jer.noble@apple.com>
1187 Reviewed by Jon Honeycutt.
1189 Implement FULLSCREEN_API on Windows, Part 1: Stubs
1190 https://bugs.webkit.org/show_bug.cgi?id=59778
1192 Create all the stubs necessary to for enabling FULLSCREEN_API
1193 on Windows. This includes the COM interfaces for preferences and
1194 for overriding full screen behavior in a UI Delegate.
1196 * Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling
1197 full screen preference.
1198 * Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding
1199 full screen behavior.
1200 * WebCoreSupport/WebChromeClient.cpp:
1201 (WebChromeClient::supportsFullScreenForElement): Added.
1202 (WebChromeClient::enterFullScreenForElement): Added.
1203 (WebChromeClient::exitFullScreenForElement): Added.
1204 * WebCoreSupport/WebChromeClient.h:
1205 * WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
1206 * WebPreferences.cpp:
1207 (WebPreferences::isFullScreenEnabled): Added. Implements function
1208 defined in IWebUIDelegatePrivate.
1209 (WebPreferences::setFullScreenEnabled): Ditto.
1212 2011-04-28 Adam Barth <abarth@webkit.org>
1214 Reviewed by Eric Seidel.
1217 https://bugs.webkit.org/show_bug.cgi?id=59678
1219 Remove WML-related enumeration.
1221 * Interfaces/IWebFramePrivate.idl:
1223 2011-04-26 Brent Fulgham <bfulgham@webkit.org>
1225 Reviewed by Adam Roben.
1227 Implement a transparent WebView under Windows. This feature
1228 allows the user to create small web-based applications, similar
1229 to the dashboard on Mac OS X.
1230 https://bugs.webkit.org/show_bug.cgi?id=58300
1232 * Interfaces/IWebViewPrivate.idl: Add new set/get accessors to
1233 change the state of a WebView into a Layered Window, or back
1234 into a standard window.
1235 * Interfaces/WebKit.idl: touch to force clean build
1237 (WebView::WebView): Set layered window state in constructor.
1238 (WebView::updateBackingStore): Cleanup old bitmap when finished.
1239 (WebView::performLayeredWindowUpdate): New method to do the work
1240 of calling ::UpdateLayeredWindow for the WebView with proper
1242 (WebView::paint): Small change to prevent accelerated compositing
1243 when using a layered window. DirectX is not compatible with
1244 ::UpdateLayeredWindow (at least currently).
1245 (WebView::WebViewWndProc): Adjust main window procedure to avoid
1246 painting a default background on a layered window (this is handled
1247 by Windows during compositing), and to deal with paint messages
1248 properly in the layered window case.
1249 (WebView::active): The layered window is not a child window,
1250 so the active state logic is slightly different.
1251 (WebView::setUsesLayeredWindow): New set method for layered stated.
1252 When called, it will convert a WebView into a Layered Window.
1253 (WebView::usesLayeredWindow): Accessor
1255 (WebView::setUsesLayeredWindow): Declare new accessor
1256 (WebView::usesLayeredWindow): Declare new accessor
1258 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1262 * WebCoreSupport/WebEditorClient.h:
1264 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1266 Reviewed by Sam Weinig.
1268 Add Frame* to the argument lists of canCopyCut and canPaste
1269 https://bugs.webkit.org/show_bug.cgi?id=59153
1271 * WebCoreSupport/WebEditorClient.cpp:
1272 (WebEditorClient::canCopyCut):
1273 (WebEditorClient::canPaste):
1274 * WebCoreSupport/WebEditorClient.h:
1276 2011-04-20 Brent Fulgham <bfulgham@webkit.org>
1278 Reviewed by Martin Robinson.
1280 Provide missing implementation of WebMutableURLRequest::mutableCopy.
1281 This was preventing DumpRenderTree from working properly under
1283 https://bugs.webkit.org/show_bug.cgi?id=59034
1285 * WebMutableURLRequest.cpp:
1286 (WebMutableURLRequest::mutableCopy): Implement cURL version of the
1289 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
1291 Reviewed by Pavel Feldman.
1293 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1294 https://bugs.webkit.org/show_bug.cgi?id=58883
1296 * WebCoreSupport/WebFrameLoaderClient.h:
1298 2011-04-18 Timothy Hatcher <timothy@apple.com>
1300 Remove the two commands that make en.lproj and copy Localizable.strings.
1302 Rubber-stamped by Adam Roben.
1304 * WebKit.vcproj/WebKitLibPostBuild.cmd:
1306 2011-04-18 Patrick Gansterer <paroga@webkit.org>
1308 Reviewed by Adam Roben.
1310 Include <WebCore/COMPtr.h> instead of "COMPtr.h"
1311 https://bugs.webkit.org/show_bug.cgi?id=58744
1313 * DOMCoreClasses.cpp:
1314 * DOMHTMLClasses.cpp:
1315 * WebActionPropertyBag.cpp:
1316 * WebBackForwardList.cpp:
1317 * WebCoreSupport/WebGeolocationClient.h:
1321 * WebHistoryItem.cpp:
1322 * WebIconDatabase.cpp:
1323 * WebNavigationData.h:
1324 * WebPreferences.cpp:
1326 * WebURLAuthenticationChallenge.cpp:
1327 * WebURLAuthenticationChallengeSender.cpp:
1328 * WebURLAuthenticationChallengeSenderCFNet.cpp:
1329 * WebURLAuthenticationChallengeSenderCurl.cpp:
1332 2011-04-17 Patrick Gansterer <paroga@webkit.org>
1334 Reviewed by Adam Barth.
1336 Rename PLATFORM(CG) to USE(CG)
1337 https://bugs.webkit.org/show_bug.cgi?id=58729
1340 (WebFrame::spoolPages):
1342 * WebPreferences.cpp:
1343 (WebPreferences::setFontSmoothing):
1344 (WebPreferences::setFontSmoothingContrast):
1346 (systemParameterChanged):
1348 2011-04-16 Sam Weinig <sam@webkit.org>
1350 Reviewed by Simon Fraser.
1352 Windows should use WebCore localized strings
1353 <rdar://problem/9119405>
1354 https://bugs.webkit.org/show_bug.cgi?id=58733
1356 * WebCoreSupport/WebEditorClient.cpp:
1357 (undoNameForEditAction):
1358 (WebEditorClient::registerCommandForUndo):
1359 * WebPreferences.cpp:
1360 (WebPreferences::initializeDefaultSettings):
1361 * WebURLResponse.cpp:
1362 (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
1363 (WebURLResponse::localizedStringForStatusCode):
1364 Change to use WEB_UI_STRING.
1366 * WebCoreSupport/WebPlatformStrategies.cpp:
1367 * WebCoreSupport/WebPlatformStrategies.h:
1368 Remove the localization strategy in favor of using the default one.
1370 2011-04-16 Patrick Gansterer <paroga@webkit.org>
1372 Reviewed by Eric Seidel.
1374 Rename PLATFORM(CAIRO) to USE(CAIRO)
1375 https://bugs.webkit.org/show_bug.cgi?id=55192
1378 (WebFrame::spoolPages):
1381 2011-04-14 Adam Roben <aroben@apple.com>
1383 Replace some known-to-fail assertions with FIXMEs
1385 These assertions get hit during various layout tests. They indicate that we're sometimes
1386 doing some extra work when a page goes into accelerated compositing mode, but otherwise
1387 there's no bad effect.
1389 See <http://webkit.org/b/58539> for more details.
1391 Rubber-stamped by John Sullivan.
1394 (WebView::paintIntoBackingStore):
1395 (WebView::paintIntoWindow):
1396 Replaced assertions with FIXMEs.
1398 2011-04-13 James Robinson <jamesr@chromium.org>
1400 Reviewed by Simon Fraser.
1402 Allow setting composited backing stores for scrollbars and scroll corners
1403 https://bugs.webkit.org/show_bug.cgi?id=57202
1405 Update WebScrollBar to reflect ScrollableArea interface changes.
1408 (WebScrollBar::invalidateScrollCornerRect):
1409 (WebScrollBar::scrollCornerPresent):
1410 (WebScrollBar::scrollCornerRect):
1412 2011-04-12 Alice Liu <alice.liu@apple.com>
1414 Reviewed by Sam Weinig.
1416 https://bugs.webkit.org/show_bug.cgi?id=58292
1417 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1419 * Interfaces/IWebPreferencesPrivate.idl: Added prefs.
1420 * Interfaces/WebKit.idl: Touch file to force autogeneration
1421 * WebPreferenceKeysPrivate.h: Add preference key.
1422 * WebPreferences.cpp:
1423 (WebPreferences::initializeDefaultSettings): Initialize setting to false.
1424 (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
1425 (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
1428 (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
1430 2011-04-11 Alexey Proskuryakov <ap@apple.com>
1432 Reviewed by Maciej Stachowiak.
1434 WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
1435 https://bugs.webkit.org/show_bug.cgi?id=58265
1436 <rdar://problem/9221468>
1438 * WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary
1439 now that WebCore implements it.
1441 2011-04-06 Brian Weinstein <bweinstein@apple.com>
1443 Reviewed by Adam Roben.
1445 WebKit2: Support Windows 7 Gestures
1446 https://bugs.webkit.org/show_bug.cgi?id=49824
1447 <rdar://problem/8689728>
1449 Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
1450 used in both WebKit and WebKit2.
1452 * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
1453 * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
1454 * WindowsTouch.h: Removed.
1456 2011-04-05 Martin Robinson <mrobinson@igalia.com>
1458 Reviewed by Eric Seidel.
1460 [Cairo] Better separate the concerns of GraphicsContextCairo
1461 https://bugs.webkit.org/show_bug.cgi?id=55150
1464 (hdcFromContext): Modify this method to take PlatformContextCairo
1465 instead of a cairo_t.
1466 (WebFrame::spoolPage): Update to reflect new platform context.
1467 (WebFrame::spoolPages): Ditto.
1468 * WebFrame.h: Ditto.
1470 2011-04-04 MORITA Hajime <morrita@google.com>
1472 Reviewed by Ryosuke Niwa.
1474 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1475 https://bugs.webkit.org/show_bug.cgi?id=56085
1477 * WebCoreSupport/WebEditorClient.h:
1478 (WebEditorClient::requestCheckingOfString):
1480 2011-04-04 Alexey Proskuryakov <ap@apple.com>
1482 Reviewed by Dan Bernstein.
1484 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1485 https://bugs.webkit.org/show_bug.cgi?id=51230
1486 <rdar://problem/8780989>
1488 * WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore,
1489 because WebKit shouldn't be smart.
1491 2011-04-04 Steve Falkenburg <sfalken@apple.com>
1493 Reviewed by Adam Roben.
1495 Remove unused AnalyzeWithLargeStack code from Windows build files
1496 https://bugs.webkit.org/show_bug.cgi?id=57771
1498 This was used for us to build with prefast automatically,
1499 but it is out-of-date and hasn't been used for some time.
1500 Removing completely for now.
1502 * WebKit.vcproj/WebKitLibPreBuild.cmd:
1504 2011-04-01 Adam Roben <aroben@apple.com>
1506 Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
1508 This will ensure we don't try to process any window messages after the window has been
1511 Covered by existing tests.
1513 Fixes <http://webkit.org/b/55054>.
1515 Reviewed by Steve Falkenburg and John Sullivan.
1518 (WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
1519 out the this pointer from the HWND.
1520 (WebView::WebViewWndProc): Changed a runtime check into an assertion.
1522 * WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
1524 2011-03-31 Evan Martin <evan@chromium.org>
1526 Reviewed by Eric Seidel.
1528 <title> should support dir attribute
1529 https://bugs.webkit.org/show_bug.cgi?id=50961
1531 Update to new FrameLoaderClient interface.
1533 * WebCoreSupport/WebFrameLoaderClient.cpp:
1534 (WebFrameLoaderClient::dispatchDidReceiveTitle):
1535 * WebCoreSupport/WebFrameLoaderClient.h:
1537 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1539 Reviewed by Adam Roben.
1541 Share most vsprops between Release and Production builds in releaseproduction.vsprops
1542 https://bugs.webkit.org/show_bug.cgi?id=57508
1544 * WebKit.vcproj/InterfacesProduction.vsprops:
1545 * WebKit.vcproj/InterfacesRelease.vsprops:
1546 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
1547 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
1548 * WebKit.vcproj/WebKitGUIDRelease.vsprops:
1549 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
1550 * WebKit.vcproj/WebKitLibProduction.vsprops:
1551 * WebKit.vcproj/WebKitLibRelease.vsprops:
1552 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
1554 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1556 Reviewed by Adam Roben.
1558 Update Windows production build logic for new production configurations
1559 https://bugs.webkit.org/show_bug.cgi?id=57494
1561 * WebKit.vcproj/InterfacesProduction.vsprops:
1562 * WebKit.vcproj/WebKit.make:
1563 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
1564 * WebKit.vcproj/WebKitLibProduction.vsprops:
1566 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1568 Reviewed by Adam Roben.
1570 Rename Windows configuration Release_LTCG to Production for clarity
1571 https://bugs.webkit.org/show_bug.cgi?id=57465
1573 * WebKit.vcproj/Interfaces.vcproj:
1574 * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
1575 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
1576 * WebKit.vcproj/WebKit.sln:
1577 * WebKit.vcproj/WebKit.submit.sln:
1578 * WebKit.vcproj/WebKit.vcproj:
1579 * WebKit.vcproj/WebKitGUID.vcproj:
1580 * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
1581 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
1582 * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
1583 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
1585 2011-03-29 Patrick Gansterer <paroga@webkit.org>
1587 Reviewed by Adam Roben.
1589 [WIN] Remove unused GEN_DOMObject files
1590 https://bugs.webkit.org/show_bug.cgi?id=57370
1592 * GEN_DOMObject.cpp: Removed.
1593 * GEN_DOMObject.h: Removed.
1595 2011-03-29 Steve Falkenburg <sfalken@apple.com>
1599 * WebCoreSupport/WebPlatformStrategies.h:
1601 2011-03-29 Steve Falkenburg <sfalken@apple.com>
1605 * WebCoreSupport/WebPlatformStrategies.cpp:
1606 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
1608 2011-03-29 Patrick Gansterer <paroga@webkit.org>
1610 Unreviewed. Try to fix Windows build.
1612 * DOMEventsClasses.cpp: Added initguid.h again.
1614 2011-03-29 Patrick Gansterer <paroga@webkit.org>
1616 Reviewed by Adam Roben.
1618 [WIN] Cleanup includes in WebKit files
1619 https://bugs.webkit.org/show_bug.cgi?id=57381
1621 Add missing includes to fix build without precompiled header.
1622 Also fix paths in #include statements (e.g. WTF -> wtf).
1625 * AccessibleDocument.h: Replace using statement with a qualified name.
1626 * CFDictionaryPropertyBag.h:
1627 * DOMEventsClasses.cpp:
1629 * DefaultDownloadDelegate.cpp:
1630 * DefaultDownloadDelegate.h:
1631 * DefaultPolicyDelegate.cpp:
1632 * DefaultPolicyDelegate.h:
1633 * WebCoreSupport/EmbeddedWidget.h:
1634 * WebCoreSupport/WebInspectorDelegate.h:
1636 * WebDatabaseManager.h:
1637 * WebElementPropertyBag.h:
1638 * WebFramePolicyListener.h:
1639 * WebGeolocationPolicyListener.h:
1641 * WebKitClassFactory.h:
1643 * WebSerializedJSValue.h:
1644 * WebUserContentURLPattern.h:
1646 2011-03-29 Steve Falkenburg <sfalken@apple.com>
1648 Reviewed by Darin Adler.
1650 Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1651 https://bugs.webkit.org/show_bug.cgi?id=57383
1653 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1654 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1655 the IDE. To avoid this, add a separate vsprops file for each project configuration that
1656 contains the required inherited property sheets.
1658 * WebKit.vcproj/Interfaces.vcproj:
1659 * WebKit.vcproj/InterfacesDebug.vsprops: Added.
1660 * WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
1661 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
1662 * WebKit.vcproj/InterfacesRelease.vsprops: Added.
1663 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
1664 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
1665 * WebKit.vcproj/WebKit.vcproj:
1666 * WebKit.vcproj/WebKitGUID.vcproj:
1667 * WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
1668 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
1669 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
1670 * WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
1671 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
1672 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
1673 * WebKit.vcproj/WebKitLibDebug.vsprops: Added.
1674 * WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
1675 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
1676 * WebKit.vcproj/WebKitLibRelease.vsprops: Added.
1677 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
1678 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
1680 2011-03-29 Patrick Gansterer <paroga@webkit.org>
1682 Reviewed by Adam Roben.
1684 Remove #pragma warning push and pop statements
1685 https://bugs.webkit.org/show_bug.cgi?id=57198
1687 We do not need to disable warnings via #pragma since we started
1688 compiling WebCore with the same compiler warnings flags as WebKit.
1690 * DOMCSSClasses.cpp:
1691 * DOMCoreClasses.cpp:
1692 * DOMEventsClasses.cpp:
1693 * DOMHTMLClasses.cpp:
1694 * DefaultDownloadDelegate.cpp:
1695 * DefaultPolicyDelegate.cpp:
1696 * MarshallingHelpers.cpp:
1697 * WebActionPropertyBag.cpp:
1698 * WebActionPropertyBag.h:
1700 * WebCoreSupport/WebDragClient.cpp:
1701 * WebCoreSupport/WebEditorClient.cpp:
1702 * WebCoreSupport/WebEditorClient.h:
1703 * WebCoreSupport/WebFrameLoaderClient.cpp:
1704 * WebCoreSupport/WebFrameLoaderClient.h:
1705 * WebCoreSupport/WebInspectorClient.cpp:
1706 * WebDocumentLoader.h:
1708 * WebDownloadCFNet.cpp:
1709 * WebDownloadCurl.cpp:
1710 * WebElementPropertyBag.cpp:
1715 * WebFramePolicyListener.cpp:
1716 * WebFramePolicyListener.h:
1718 * WebHistoryItem.cpp:
1719 * WebIconDatabase.cpp:
1720 * WebIconDatabase.h:
1722 * WebJavaScriptCollector.cpp:
1723 * WebKitGraphics.cpp:
1724 * WebKitSystemBits.cpp:
1725 * WebLocalizableStrings.cpp:
1726 * WebMutableURLRequest.cpp:
1727 * WebMutableURLRequest.h:
1728 * WebNodeHighlight.cpp:
1729 * WebNodeHighlight.h:
1730 * WebNotificationCenter.cpp:
1735 * WebURLAuthenticationChallenge.cpp:
1736 * WebURLAuthenticationChallenge.h:
1737 * WebURLAuthenticationChallengeSender.cpp:
1738 * WebURLAuthenticationChallengeSenderCFNet.cpp:
1739 * WebURLAuthenticationChallengeSenderCurl.cpp:
1740 * WebURLCredential.cpp:
1741 * WebURLCredential.h:
1742 * WebURLProtectionSpace.cpp:
1743 * WebURLProtectionSpace.h:
1744 * WebURLResponse.cpp:
1747 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
1749 Unreviewed build fix after r82247.
1751 * WebMutableURLRequest.cpp: The new CertificateCFWin routines
1752 are not CFNetwork-specific. All CF-based ports can use them.
1754 2011-03-29 Patrick Gansterer <paroga@webkit.org>
1756 Reviewed by Adam Roben.
1758 [WIN] Use WCHAR instead of TCHAR
1759 https://bugs.webkit.org/show_bug.cgi?id=57191
1761 We always use the UNICODE versions of windows functions, so
1762 the usage of TCHAR makes no sense and mixing them is bad style.
1764 * DefaultDownloadDelegate.cpp:
1765 * WebCoreSupport/WebChromeClient.cpp:
1766 * WebCoreSupport/WebContextMenuClient.cpp:
1767 * WebCoreSupport/WebInspectorClient.cpp:
1769 * WebNotificationCenter.cpp:
1770 * WebPreferences.cpp:
1771 * WebURLResponse.cpp:
1774 2011-03-29 Jeff Miller <jeffm@apple.com>
1776 Reviewed by Jon Honeycutt.
1778 Add WebCore::copyCertificateToData() on Windows
1779 https://bugs.webkit.org/show_bug.cgi?id=57296
1781 Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.
1783 * WebMutableURLRequest.cpp:
1784 (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().
1786 2011-03-28 Patrick Gansterer <paroga@webkit.org>
1788 Reviewed by Adam Roben.
1790 [WIN] Remove unused DOMCreateInstance files
1791 https://bugs.webkit.org/show_bug.cgi?id=57193
1793 * DOMCreateInstance.cpp: Removed.
1794 * DOMCreateInstance.h: Removed.
1796 2011-03-28 Adele Peterson <adele@apple.com>
1800 * WebFrame.cpp: (WebFrame::hasSpellingMarker):
1801 Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
1803 2011-03-28 Jeff Miller <jeffm@apple.com>
1805 Reviewed by Adam Roben.
1807 Include certificate when sending a WebCore::ResourceError to UI process on Windows
1808 https://bugs.webkit.org/show_bug.cgi?id=57195
1810 Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.
1813 (WebError::sslPeerCertificate):
1814 * WebURLResponse.cpp:
1815 (WebURLResponse::sslPeerCertificate):
1817 2011-03-28 Darin Adler <darin@apple.com>
1819 Set eol-style to native on more files. I noticed the last check-in had an entire file
1820 changing because of an EOL style change, and setting this property prevents that from
1821 happening in future. We may want to do this systematically for more of WebKit later.
1823 * AccessibleBase.cpp: Added property svn:eol-style.
1824 * AccessibleBase.h: Added property svn:eol-style.
1825 * AccessibleDocument.cpp: Added property svn:eol-style.
1826 * AccessibleDocument.h: Added property svn:eol-style.
1827 * AccessibleImage.cpp: Added property svn:eol-style.
1828 * AccessibleImage.h: Added property svn:eol-style.
1829 * COMVariantSetter.h: Added property svn:eol-style.
1830 * FullscreenVideoController.cpp: Added property svn:eol-style.
1831 * FullscreenVideoController.h: Added property svn:eol-style.
1832 * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
1833 * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
1834 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
1835 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
1836 * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
1837 * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
1838 * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
1839 * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
1840 * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
1841 * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
1842 * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
1844 2011-03-28 Patrick Gansterer <paroga@webkit.org>
1846 Unreviewed build fix.
1848 * COMPropertyBag.h: Added missing include.
1849 * WebKitCOMAPI.h: Ditto.
1850 * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
1852 2011-03-25 Sam Weinig <sam@webkit.org>
1854 Reviewed by Jon Honeycutt.
1856 WebScrollBar not updating when calling WebScrollBar::setValue.
1857 <rdar://problem/9143871>
1860 (WebScrollBar::setValue):
1861 Call scrollToOffsetWithoutAnimation to actually update the scroll position.
1863 2011-03-25 Andy Estes <aestes@apple.com>
1865 Reviewed by Adele Peterson.
1867 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1868 https://bugs.webkit.org/show_bug.cgi?id=49016
1870 Update objectContentType() implementation to handle the
1871 shouldPreferPlugInsForImages flag.
1874 (WebFrame::objectContentType):
1877 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
1879 Unreviewed, rolling out r81916 and r81917.
1880 http://trac.webkit.org/changeset/81916
1881 http://trac.webkit.org/changeset/81917
1882 https://bugs.webkit.org/show_bug.cgi?id=57071
1884 broke a test on platforms that do not have QuickTime installed
1885 (Requested by estes on #webkit).
1888 (WebFrame::objectContentType):
1891 2011-03-24 Andy Estes <aestes@apple.com>
1893 Reviewed by Darin Adler.
1895 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1896 https://bugs.webkit.org/show_bug.cgi?id=49016
1898 Update objectContentType() implementation to handle the
1899 shouldPreferPlugInsForImages flag.
1902 (WebFrame::objectContentType):
1905 2011-03-23 Brady Eidson <beidson@apple.com>
1907 Reviewed by Sam Weinig.
1909 Change IconDatabase opening to allow for arbitrary filenames
1910 https://bugs.webkit.org/show_bug.cgi?id=56977
1912 * WebIconDatabase.cpp:
1913 (WebIconDatabase::startUpIconDatabase):
1915 2011-03-22 Brady Eidson <beidson@apple.com>
1917 Reviewed by Sam Weinig.
1919 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
1920 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
1922 Note that while the new client calls always come through on the main thread, our mechanisms to
1923 route dispatches to the main thread are still valid and will still work.
1925 Update to the new IconDatabaseClient interface:
1926 * WebIconDatabase.cpp:
1927 (WebIconDatabase::performImport):
1928 (WebIconDatabase::didRemoveAllIcons):
1929 (WebIconDatabase::didImportIconURLForPageURL):
1930 (WebIconDatabase::didImportIconDataForPageURL):
1931 (WebIconDatabase::didChangeIconForPageURL):
1932 (WebIconDatabase::didFinishURLImport):
1933 * WebIconDatabase.h:
1935 2011-03-17 Brady Eidson <beidson@apple.com>
1937 Reviewed by Sam Weinig.
1939 https://bugs.webkit.org/show_bug.cgi?id=56425
1940 More groundwork for WebKit2 IconDatabase
1942 Update already-used function names:
1943 * WebIconDatabase.cpp:
1944 (WebIconDatabase::iconForURL):
1945 (WebIconDatabase::iconURLForURL):
1946 (WebIconDatabase::hasIconForURL):
1948 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
1950 Reviewed by Yury Semikhatsky.
1952 Web Inspector: implement inspector session storage.
1953 https://bugs.webkit.org/show_bug.cgi?id=56643
1955 * WebCoreSupport/WebInspectorClient.cpp:
1956 (WebInspectorClient::saveSessionSetting):
1957 (WebInspectorClient::loadSessionSetting):
1958 (WebInspectorFrontendClient::saveSessionSetting):
1959 (WebInspectorFrontendClient::loadSessionSetting):
1960 * WebCoreSupport/WebInspectorClient.h:
1962 2011-03-11 Brady Eidson <beidson@apple.com>
1964 More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
1966 * WebCoreStatistics.cpp:
1967 * WebIconDatabase.cpp:
1969 2011-03-09 Peter Kasting <pkasting@google.com>
1971 Reviewed by Mihai Parparita.
1973 Unify Windows version checks.
1974 https://bugs.webkit.org/show_bug.cgi?id=55979
1977 (WebView::standardUserAgentWithApplicationName):
1978 (webKitVersionString):
1980 2011-03-07 Sam Weinig <sam@webkit.org>
1982 Reviewed by Anders Carlsson.
1984 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1985 https://bugs.webkit.org/show_bug.cgi?id=55827
1987 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1988 and pass the entire response, instead of just the MIMEType.
1991 (WebFrame::dispatchDecidePolicyForResponse):
1994 2011-03-04 Steve Falkenburg <sfalken@apple.com>
1996 Reviewed by Darin Adler.
1998 Adopt VersionStamper tool for Windows WebKit DLLs
1999 https://bugs.webkit.org/show_bug.cgi?id=55784
2001 Calculate the WebKit version for the useragent via autoversion.h
2002 instead of reading it back from the DLL.
2004 We now use a tool to stamp the version number onto the Apple WebKit DLLs
2005 during the post-build step.
2007 * WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
2008 * WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
2010 (WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version.
2011 (osVersion): Removed
2013 2011-03-03 Anders Carlsson <andersca@apple.com>
2015 Reviewed by Sam Weinig.
2017 Get rid of Page::globalHistoryItem
2018 https://bugs.webkit.org/show_bug.cgi?id=55738
2020 * WebCoreSupport/WebFrameLoaderClient.cpp:
2021 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
2022 Get the current history item and update it using WebView::setGlobalHistoryItem.
2024 * WebCoreSupport/WebFrameLoaderClient.h:
2026 (WebView::globalHistoryItem):
2027 (WebView::setGlobalHistoryItem):
2030 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
2032 Unreviewed build correction.
2035 (scaleFactor): Update after 77286 to replace right/bottom
2036 with new maxX/maxY terminology.
2038 2011-03-03 Brady Eidson <beidson@apple.com>
2040 Reviewed by Darin Adler.
2042 https://bugs.webkit.org/show_bug.cgi?id=55721
2043 Global IconDatabase should be returned by reference, not as a pointer
2045 * WebCoreStatistics.cpp:
2046 (WebCoreStatistics::iconPageURLMappingCount):
2047 (WebCoreStatistics::iconRetainedPageURLCount):
2048 (WebCoreStatistics::iconRecordCount):
2049 (WebCoreStatistics::iconsWithDataCount):
2050 * WebIconDatabase.cpp:
2051 (WebIconDatabase::init):
2052 (WebIconDatabase::startUpIconDatabase):
2053 (WebIconDatabase::iconForURL):
2054 (WebIconDatabase::retainIconForURL):
2055 (WebIconDatabase::releaseIconForURL):
2056 (WebIconDatabase::removeAllIcons):
2057 (WebIconDatabase::iconURLForURL):
2058 (WebIconDatabase::isEnabled):
2059 (WebIconDatabase::setEnabled):
2060 (WebIconDatabase::hasIconForURL):
2061 (WebIconDatabase::getOrCreateDefaultIconBitmap):
2065 2011-03-03 Alexey Proskuryakov <ap@apple.com>
2067 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2070 * WebCoreSupport/WebChromeClient.h:
2072 2011-03-02 Alexey Proskuryakov <ap@apple.com>
2074 Reviewed by Darin Adler.
2076 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2077 https://bugs.webkit.org/show_bug.cgi?id=55633
2078 <rdar://problem/8963023>
2080 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode):
2081 * WebCoreSupport/WebChromeClient.h:
2082 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2083 this platform doesn't observe or have full keyboard access state.
2085 2011-03-03 Peter Kasting <pkasting@google.com>
2087 Reviewed by James Robinson.
2089 Drop redundant "Windows; " from the Windows-specific User Agent string.
2090 https://bugs.webkit.org/show_bug.cgi?id=54567
2093 (WebView::standardUserAgentWithApplicationName):
2095 2011-03-01 Brian Weinstein <bweinstein@apple.com>
2097 Reviewed by Adam Roben.
2099 Part of WebKit2: Need a way to send notifications to client when cookies change
2100 https://bugs.webkit.org/show_bug.cgi?id=55427
2101 <rdar://problem/9056027>
2103 Add stubs for CookiesStrategy on Windows WebKit1.
2105 * WebCoreSupport/WebPlatformStrategies.cpp:
2106 (WebPlatformStrategies::createCookiesStrategy):
2107 (WebPlatformStrategies::notifyCookiesChanged):
2108 * WebCoreSupport/WebPlatformStrategies.h:
2110 2011-02-28 Chang Shu <cshu@webkit.org>
2112 Reviewed by Ryosuke Niwa.
2114 Remove the support of Frame::isContentEditable and its dependencies.
2115 https://bugs.webkit.org/show_bug.cgi?id=54292
2117 Remove the WebKit side implementation.
2119 * WebCoreSupport/WebEditorClient.cpp:
2120 * WebCoreSupport/WebEditorClient.h:
2122 2011-02-28 Adam Roben <aroben@apple.com>
2124 Build TestWebKitAPIInjectedBundle on Windows
2126 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
2128 Reviewed by Darin Adler.
2130 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
2133 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2135 Unreviewed, rolling out r78789.
2136 http://trac.webkit.org/changeset/78789
2137 https://bugs.webkit.org/show_bug.cgi?id=55409
2139 Incorrect canvas fallback implementation (Requested by
2140 inferno-sec on #webkit).
2142 * AccessibleBase.cpp:
2145 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2147 Reviewed by Pavel Feldman.
2149 DumpRenderTree should reset frame opener between tests.
2150 https://bugs.webkit.org/show_bug.cgi?id=54874
2152 Added clearOpener method to IWebFramePrivate.
2153 Touched WebKit.idl to trigger build scripts.
2155 * Interfaces/IWebFramePrivate.idl:
2156 * Interfaces/WebKit.idl:
2158 (WebFrame::clearOpener):
2161 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
2163 Unreviewed, rolling out r79764.
2164 http://trac.webkit.org/changeset/79764
2165 https://bugs.webkit.org/show_bug.cgi?id=55295
2167 "broke Chromium builds" (Requested by rniwa on #webkit).
2169 * Interfaces/IWebFramePrivate.idl:
2170 * Interfaces/WebKit.idl:
2174 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2176 Reviewed by Pavel Feldman.
2178 DumpRenderTree should reset frame opener between tests.
2179 https://bugs.webkit.org/show_bug.cgi?id=54874
2181 Added clearOpener method to IWebFramePrivate.
2182 Touched WebKit.idl to trigger build scripts.
2184 * Interfaces/IWebFramePrivate.idl:
2185 * Interfaces/WebKit.idl:
2187 (WebFrame::clearOpener):
2190 2011-02-24 Peter Kasting <pkasting@google.com>
2192 Reviewed by Eric Seidel.
2194 Drop the "U; " encryption level from the User Agent string.
2195 https://bugs.webkit.org/show_bug.cgi?id=54566
2198 (WebView::standardUserAgentWithApplicationName):
2200 2011-02-24 Andrew Wilson <atwilson@chromium.org>
2202 Unreviewed, rolling out r79570.
2203 http://trac.webkit.org/changeset/79570
2204 https://bugs.webkit.org/show_bug.cgi?id=54874
2206 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2209 * Interfaces/IWebFramePrivate.idl:
2210 * Interfaces/WebKit.idl:
2214 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
2216 Reviewed by Alexey Proskuryakov.
2218 DumpRenderTree should reset frame opener between tests.
2219 https://bugs.webkit.org/show_bug.cgi?id=54874
2221 Added clearOpener method to IWebFramePrivate.
2222 Touched WebKit.idl to trigger build scripts.
2224 * Interfaces/IWebFramePrivate.idl:
2225 * Interfaces/WebKit.idl:
2227 (WebFrame::clearOpener):
2230 2011-02-23 Patrick Gansterer <paroga@webkit.org>
2232 Reviewed by Darin Adler.
2234 Rename PLATFORM(CF) to USE(CF)
2235 https://bugs.webkit.org/show_bug.cgi?id=53540
2239 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2241 Reviewed by Alexey Proskuryakov.
2243 Drop the language tag part from the User Agent string
2244 https://bugs.webkit.org/show_bug.cgi?id=54560
2247 (WebView::standardUserAgentWithApplicationName):
2249 2011-02-19 Charlie Reis <creis@chromium.org>
2251 Reviewed by Mihai Parparita.
2253 Ensure loading has stopped in HistoryController::goToItem
2254 https://bugs.webkit.org/show_bug.cgi?id=54517
2256 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2258 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2260 * WebCoreSupport/WebFrameLoaderClient.cpp:
2261 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2262 * WebCoreSupport/WebFrameLoaderClient.h:
2264 2011-02-16 David Hyatt <hyatt@apple.com>
2266 Reviewed by Dan Bernstein.
2268 https://bugs.webkit.org/show_bug.cgi?id=54244
2270 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
2271 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2273 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2274 been changed as well.
2276 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2278 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2280 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2281 still have a precise floating point position.
2283 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
2284 be rounding justification spacing in their font code.
2286 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2288 * WebKitGraphics.cpp:
2289 (CenterTruncateStringToWidth):
2290 (RightTruncateStringToWidth):
2292 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
2294 Reviewed by Adam Roben.
2296 HTML5 <details> and <summary>: localized text
2297 https://bugs.webkit.org/show_bug.cgi?id=54260
2299 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2300 provide the default label to be used by a <details> tag that has no <summary> child.
2302 * WebCoreSupport/WebPlatformStrategies.cpp:
2303 (WebPlatformStrategies::defaultDetailsSummaryText):
2304 * WebCoreSupport/WebPlatformStrategies.h:
2306 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
2308 Reviewed by Chris Fleizach.
2310 Add new role for canvas elements.
2312 https://bugs.webkit.org/show_bug.cgi?id=50126
2314 Test: accessibility/canvas-fallback-content.html
2316 * AccessibleBase.cpp:
2319 2011-02-15 Kenneth Russell <kbr@google.com>
2321 Unreviewed. Remove whitespace-only change from
2322 http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
2323 now that the patch has passed the Windows build bots.
2325 * Interfaces/WebKit.idl:
2327 2011-02-15 Kenneth Russell <kbr@google.com>
2329 Reviewed by Darin Fisher.
2331 Allow controlling minimum DOMTimer interval on a per-page basis
2332 https://bugs.webkit.org/show_bug.cgi?id=54312
2334 Added needed methods to implement LayoutTestController's new
2335 setMinimumTimerInterval method. Includes whitespace-only change to
2336 WebKit.idl to trigger proper rebuild on bots; will be removed in
2339 * Interfaces/IWebViewPrivate.idl:
2340 * Interfaces/WebKit.idl:
2342 (WebView::initWithFrame):
2343 (WebView::defaultMinimumTimerInterval):
2344 (WebView::setMinimumTimerInterval):
2347 2011-01-26 MORITA Hajime <morrita@google.com>
2349 Reviewed by Ryosuke Niwa.
2351 Refactoring: Extract TextCheckerClient from EditorClient
2352 https://bugs.webkit.org/show_bug.cgi?id=53213
2354 * WebCoreSupport/WebEditorClient.h:
2355 (WebEditorClient::textChecker):
2357 2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
2359 Reviewed by Adam Barth.
2361 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
2362 https://bugs.webkit.org/show_bug.cgi?id=52417
2364 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
2367 * WebCoreSupport/WebEditorClient.cpp:
2368 (WebEditorClient::canCopyCut): Added.
2369 (WebEditorClient::canPaste): Added.
2370 * WebCoreSupport/WebEditorClient.h:
2372 2011-02-14 Brian Weinstein <bweinstein@apple.com>
2374 Reviewed by Brady Eidson.
2376 Need WebKit API to determine whether we have a site icon for a given URL
2377 https://bugs.webkit.org/show_bug.cgi?id=54400
2379 This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
2380 we have a site icon for the given URL.
2382 * Interfaces/IWebIconDatabase.idl: Added new function.
2383 * Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
2384 * WebIconDatabase.cpp:
2385 (WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
2386 load the icon from disk, and call iconURLForPageURL to determine whether or not
2387 we actually have an icon.
2388 * WebIconDatabase.h:
2390 2011-02-11 Geoffrey Garen <ggaren@apple.com>
2392 Reviewed by Oliver Hunt.
2394 A little more encapsulation for the heap: Removed CollectorHeapIterator
2395 https://bugs.webkit.org/show_bug.cgi?id=54298
2397 * WebCoreStatistics.cpp:
2398 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2400 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
2402 Reviewed by Yury Semikhatsky.
2404 Web Inspector: follow up on InspectorAgent split -
2405 removing unnecessary methods from InspectorController.
2406 https://bugs.webkit.org/show_bug.cgi?id=54093
2409 (WebInspector::showConsole):
2410 (WebInspector::toggleProfilingJavaScript):
2412 2011-02-08 Adam Barth <abarth@webkit.org>
2414 Reviewed by Eric Seidel.
2416 Remove orphan code from old parser
2417 https://bugs.webkit.org/show_bug.cgi?id=53984
2419 * WebCoreSupport/WebChromeClient.h:
2421 2011-02-08 David Hyatt <hyatt@apple.com>
2423 Reviewed by Adam Roben.
2425 <rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
2427 Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
2428 value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
2432 (WebFrame::setPrinting):
2433 (WebFrame::setInPrintingMode):
2436 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
2438 Reviewed by Yury Semikhatsky.
2440 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2442 https://bugs.webkit.org/show_bug.cgi?id=53169
2444 Minor change enforced by major changes in WebCore/inspector/InspectorController.
2447 (WebInspector::isTimelineProfilingEnabled):
2449 2011-02-07 Enrica Casucci <enrica@apple.com>
2451 Reviewed Adam Roben and Darin Adler.
2453 WebKit2: drag and drop support on Windows.
2454 https://bugs.webkit.org/show_bug.cgi?id=52775
2456 Removed createDragImageForLink from DragClient.
2458 * WebCoreSupport/WebDragClient.cpp:
2459 (WebDragClient::startDrag):
2460 * WebCoreSupport/WebDragClient.h:
2462 2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
2464 Reviewed by Darin Adler.
2466 OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
2467 https://bugs.webkit.org/show_bug.cgi?id=52867
2470 (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
2471 * WebPreferences.cpp:
2472 (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2474 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
2476 Reviewed by Pavel Feldman.
2478 Web Inspector: remove settings related methods from InspectorClient
2479 https://bugs.webkit.org/show_bug.cgi?id=53686
2481 * WebCoreSupport/WebInspectorClient.cpp:
2482 (WebInspectorClient::openInspectorFrontend):
2483 (WebInspectorFrontendClient::WebInspectorFrontendClient):
2484 * WebCoreSupport/WebInspectorClient.h:
2486 2011-02-03 Adam Langley <agl@chromium.org>
2488 Reviewed by Adam Barth.
2490 Plumb mixed script URL to FrameLoaderClient
2491 https://bugs.webkit.org/show_bug.cgi?id=52384
2493 Regressions covered by http/tests/security/mixedContent/*
2495 * WebCoreSupport/WebFrameLoaderClient.cpp:
2496 (WebFrameLoaderClient::didRunInsecureContent):
2497 * WebCoreSupport/WebFrameLoaderClient.h:
2499 2011-02-02 David Hyatt <hyatt@apple.com>
2501 Reviewed by Darin Adler.
2503 Removal of right()/bottom(), converting to maxX()/maxY().
2505 * DOMHTMLClasses.cpp:
2506 (DOMHTMLInputElement::rectOnScreen):
2507 * WebCoreSupport/EmbeddedWidget.cpp:
2508 (EmbeddedWidget::frameRectsChanged):
2510 (WebFrame::computePageRects):
2512 (WebScrollBar::frameRect):
2514 (WebView::addToDirtyRegion):
2515 (WebView::visibleContentRect):
2516 (WebView::prepareCandidateWindow):
2518 2011-01-31 Brady Eidson <beidson@apple.com>
2520 Reviewed by Adam Roben.
2522 Fix the clean Windows build.
2524 * WebKitGraphics.cpp:
2527 2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
2529 Downloads in WK2 on Windows should write resume data to bundle
2530 https://bugs.webkit.org/show_bug.cgi?id=53282
2531 <rdar://problem/8753077>
2533 Reviewed by Alice Liu.
2536 (WebDownload::bundlePathForTargetPath):
2537 Use the new WebCore::DownloadBundle function.
2538 (WebDownload::request):
2541 Removed declarations for functions that were moved to a new location.
2543 * WebDownloadCFNet.cpp:
2544 (WebDownload::initToResumeWithBundle):
2545 Use the new WebCore::DownloadBundle function.
2546 (WebDownload::cancelForResume):
2547 Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
2548 WebCore::DownloadBundle function.
2550 2011-01-28 Dan Bernstein <mitz@apple.com>
2552 Reviewed by Sam Weinig.
2554 <select> can't display right-to-left (rtl) languages
2555 https://bugs.webkit.org/show_bug.cgi?id=19785
2557 * WebCoreSupport/WebChromeClient.cpp:
2558 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
2559 * WebCoreSupport/WebChromeClient.h:
2561 2011-01-27 Nate Chapin <japhet@chromium.org>
2563 Reviewed by Adam Barth.
2565 Use Document::url() instead of FrameLoader::url().
2566 https://bugs.webkit.org/show_bug.cgi?id=41165
2571 2011-01-27 Sam Weinig <sam@webkit.org>
2573 Reviewed by Adam Roben.
2575 Fix scrollbars in Safari's Downloads window and Bookmarks view by
2576 implementing two needed functions from ScrollableArea.
2579 (WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
2580 we are a horizontal scrollbar.
2581 (WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
2582 are a vertical scrollbar.
2585 2011-01-27 Adam Roben <aroben@apple.com>
2587 Trim down #includes in WebView.h
2589 Rubber-stamped by Steve Falkenburg.
2591 * WebView.cpp: Moved some #includes here from the header file.
2593 * WebView.h: Replaced some broader #includes with more specific ones, plus a
2594 forward-declaration.
2596 2011-01-25 Steve Falkenburg <sfalken@apple.com>
2598 Windows production build fix.
2599 Build correct configuration of Interfaces for Debug_All.
2601 * WebKit.vcproj/WebKit.submit.sln:
2603 2011-01-25 Steve Falkenburg <sfalken@apple.com>
2605 Rubber-stamped by Adam Roben.
2607 Windows production build fix.
2608 Use correct environment variable escaping
2610 * WebKit.vcproj/WebKit.make:
2612 2011-01-24 Chris Marrin <cmarrin@apple.com>
2614 Reviewed by Eric Seidel.
2616 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
2617 https://bugs.webkit.org/show_bug.cgi?id=53041
2620 (WebView::notifyPreferencesChanged):
2622 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
2624 Reviewed by Pavel Feldman.
2626 Web Inspector: remove "attached" state related methods from InspectorAgent
2627 https://bugs.webkit.org/show_bug.cgi?id=53086
2629 * WebCoreSupport/WebInspectorClient.cpp:
2630 (WebInspectorFrontendClient::attachWindow):
2631 (WebInspectorFrontendClient::detachWindow):
2632 (WebInspectorFrontendClient::showWindowWithoutNotifications):
2633 * WebCoreSupport/WebInspectorClient.h:
2635 2011-01-24 Adam Roben <aroben@apple.com>
2637 Windows Production build fix
2639 * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
2641 2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
2643 Reviewed by Dirk Schulze.
2645 Introduce FontMetrics abstraction
2646 https://bugs.webkit.org/show_bug.cgi?id=51456
2648 * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
2649 (FullscreenVideoController::draw):
2650 * WebCoreSupport/WebDragClient.cpp: Ditto.
2651 (WebDragClient::createDragImageForLink):
2652 * WebKitGraphics.cpp: Ditto.
2655 2011-01-21 Chris Rogers <crogers@google.com>
2657 Reviewed by Darin Fisher.
2659 Add run-time enable support for the web audio API
2660 https://bugs.webkit.org/show_bug.cgi?id=52741
2662 * WebPreferenceKeysPrivate.h:
2664 (WebView::notifyPreferencesChanged):
2666 2011-01-21 Sam Weinig <sam@webkit.org>
2672 2011-01-21 Sam Weinig <sam@webkit.org>
2674 Reviewed by Anders Carlsson.
2676 Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
2677 https://bugs.webkit.org/show_bug.cgi?id=52779
2679 Rename ScrollbarClient -> ScrollableArea.
2682 (WebScrollBar::scroll):
2685 2011-01-20 Adam Roben <aroben@apple.com>
2687 Update for CACFLayerTreeHost changes
2689 Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
2690 CACFLayerTreeHost, but shouldn't be
2692 Reviewed by Simon Fraser.
2695 (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
2696 to our own flushing function if needed.
2698 * WebView.h: Removed shouldRender, which is no longer used or needed.
2700 2011-01-21 Adam Roben <aroben@apple.com>
2702 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
2704 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
2706 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
2708 Reviewed by Simon Fraser.
2710 * WebPreferences.cpp:
2712 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
2713 host before we get rid of the layer tree host itself.
2716 2011-01-21 Adam Roben <aroben@apple.com>
2718 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
2720 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
2721 opposed to just "layer" because there are cases where we flush changes to CACFLayers that
2722 don't have a corresponding GraphicsLayer.
2724 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
2725 WKCACFLayerRenderer and friends is confusing
2727 Reviewed by Simon Fraser.
2729 * WebCoreSupport/WebChromeClient.cpp:
2730 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
2733 (WebView::paint): Updated for rename.
2734 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
2735 (WebView::notifySyncRequired): Updated for rename.
2736 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
2738 * WebView.h: Did the renames.
2740 2011-01-20 Sam Weinig <sam@webkit.org>
2742 Reviewed by Dave Hyatt.
2744 Cleanup Scrollbar/ScrollbarClient relationship
2745 https://bugs.webkit.org/show_bug.cgi?id=52779
2748 (WebScrollBar::WebScrollBar):
2749 (WebScrollBar::setValue):
2750 (WebScrollBar::value):
2751 (WebScrollBar::scroll):
2752 (WebScrollBar::scrollPosition):
2753 (WebScrollBar::setScrollOffset):
2756 2011-01-19 Adam Roben <aroben@apple.com>
2758 Update for WKCACFLayerRenderer changes
2760 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
2763 Reviewed by Simon Fraser.
2766 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
2767 compositing-related members. My biggest concern was making sure that m_layerRenderer was
2768 gone, which would also mean we had nulled out its client pointer.
2769 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
2770 of passing the client into create(), and to clear out the client before nulling out
2773 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
2775 2011-01-19 Adam Roben <aroben@apple.com>
2777 Teach WebView::scrollBackingStore about compositing mode
2780 compositing/scroll-painted-composited-content.html
2782 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
2783 WebView::scrollBackingStore when scrolling page with composited content
2785 Reviewed by Anders Carlsson.
2788 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
2789 mode, rather than incorrectly asserting that this function is never called in that case. For
2790 now we just repaint the entire scrolled region; someday hopefully we can avoid having to
2791 repaint the areas that have just been moved.
2793 2011-01-19 Simon Fraser <simon.fraser@apple.com>
2795 Reviewed by Sam Weinig.
2797 GraphicsLayers in subframes can get sync'd multiple times
2798 https://bugs.webkit.org/show_bug.cgi?id=52489
2801 (WebView::syncCompositingState): syncCompositingStateRecursive()
2802 was renamed to syncCompositingStateIncludingSubframes().
2804 2011-01-17 Adam Roben <aroben@apple.com>
2806 Update for WKCACFLayerRenderer changes
2808 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
2810 Reviewed by Chris Marrin.
2813 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
2814 when handling WM_SHOWWINDOW. All this did was try to create the
2815 renderer, but it had already been created in setAcceleratedCompositing,
2817 (WebView::setAcceleratedCompositing): Removed call to createRenderer;
2818 setHostWindow does this for us now.
2820 * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
2822 2011-01-17 Adam Roben <aroben@apple.com>
2824 Paint directly into a GraphicsLayer when using accelerated compositing
2826 Before this patch, we were painting into our normal backing store
2827 HBITMAP, wrapping it in a CGImage, and handing it off to Core
2828 Animation. This had at least two disadvantages:
2829 1) The bitmap could be modified while Core Animation was using it.
2830 2) It introduced extra complexity.
2832 When entering accelerated compositing mode, WebView now creates a
2833 GraphicsLayer to draw into. This GraphicsLayer sits between the root
2834 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
2835 WebView invalidates, it just calls setNeedsDisplayInRect on its
2836 GraphicsLayer. When WebView paints, it just tells its
2837 WKCACFLayerRenderer to paint, which will call back to WebView to draw
2838 into the GraphicsLayer if it has a dirty region. This is very similar
2839 to the current implementation of LayerBackedDrawingArea in WebKit2.
2841 Fixes <http://webkit.org/b/52582> WebView should paint directly into a
2842 GraphicsLayer when in accelerated compositing mode
2844 Reviewed by Simon Fraser and Chris Marrin.
2846 * WebCoreSupport/WebChromeClient.cpp:
2847 (WebChromeClient::attachRootGraphicsLayer):
2848 (WebChromeClient::scheduleCompositingLayerSync):
2849 Updated for WebView changes.
2852 (WebView::repaint): When using accelerated compositing, just invalidate
2853 our backing layer. This matches the behavior of LayerBackedDrawingArea.
2854 (WebView::deleteBackingStore): Removed accelerated compositing code.
2855 The WKCACFLayerRenderer doesn't need to know about our backing store
2856 anymore; we don't use it at all when in accelerated compositing mode.
2857 (WebView::addToDirtyRegion): When using accelerated compositing, just
2858 invalidate our backing layer.
2859 (WebView::scrollBackingStore): Added an assertion that this isn't
2860 called in accelerated compositing mode.
2861 (WebView::sizeChanged): Update our backing layer's size, too, and
2863 (WebView::updateBackingStore): Added an assertion that this isn't
2864 called in accelerated compositing mode.
2865 (WebView::paint): If we're in accelerated compositing mode, sync our
2866 compositing state. If we're *still* in accelerated compositing mode,
2867 just tell our WKCACFLayerRenderer to paint and clear our dirty region.
2868 (The later changes in this function are just un-indenting code that
2869 used to be inside an if.)
2871 (WebView::paintIntoBackingStore):
2872 (WebView::paintIntoWindow):
2873 Added assertions that these aren't called in accelerated compositing
2876 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
2877 removal of setRootLayerNeedsDisplay.
2878 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
2879 set the layer as a child of our own backing layer.
2880 (WebView::scheduleCompositingLayerSync): Just call through to
2881 WKCACFLayerRenderer.
2882 (WebView::setAcceleratedCompositing): Create our backing layer and set
2883 it as the child of WKCACFLayerRenderer's root layer.
2884 (WebView::notifyAnimationStarted): Added. We never expect this
2885 GraphicsLayerClient override to be called, as we don't use animations
2886 on our backing layer.
2887 (WebView::notifySyncRequired): Added. Just schedule a sync.
2888 (WebView::paintContents): Added. Just clip and paint!
2890 (WebView::showDebugBorders):
2891 (WebView::showRepaintCounter):
2892 Added. These just call through to Settings.
2894 (WebView::syncCompositingState): Changed to first update layout, then
2895 sync state for our backing layer, then sync WebCore's state. This
2896 matches LayerBackedDrawingArea.
2898 * WebView.h: WebView now implements the GraphicsLayerClient interface.
2899 Removed setRootLayerNeedsDisplay; it's been replaced by calling
2900 setNeedsDisplay on our backing layer and calling
2901 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
2902 updateRootLayerContents; that function was used to pass our backing
2903 store to Core Animation, which we no longer do. Added m_backingLayer.
2905 2011-01-17 Tony Gentilcore <tonyg@chromium.org>
2907 Reviewed by Alexey Proskuryakov.
2909 Fix some headers with missing or misspelled #ifndef guards
2910 https://bugs.webkit.org/show_bug.cgi?id=52545
2912 * WebKitStatistics.h:
2914 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
2916 Reviewed by Yury Semikhatsky.
2918 Web Inspector: simplify debugger enabling routine.
2919 https://bugs.webkit.org/show_bug.cgi?id=52472
2922 (WebInspector::toggleDebuggingJavaScript):
2924 2011-01-16 Adam Barth <abarth@webkit.org>
2926 Rubber-stamped by Eric Seidel.
2928 Move WebKit into Source
2929 https://bugs.webkit.org/show_bug.cgi?id=52530
2931 * WebKit.vcproj/Interfaces.vcproj:
2932 * WebKit.vcproj/WebKit.sln:
2933 * WebKit.vcproj/WebKit.vcproj:
2934 * WebKit.vcproj/WebKitGUID.vcproj:
2936 2011-01-15 Adam Barth <abarth@webkit.org>
2938 Rubber-stamped by Eric Seidel.
2940 Move WebKit2 into Source
2941 https://bugs.webkit.org/show_bug.cgi?id=52438
2943 Update reference to WebKit2.
2945 * WebKit.vcproj/WebKit.sln:
2947 2011-01-14 Yuzo Fujishima <yuzo@google.com>
2949 Reviewed by Antti Koivisto.
2951 Rename cache() to memoryCache()
2952 https://bugs.webkit.org/show_bug.cgi?id=52433
2955 (WebCache::statistics):
2957 (WebCache::setDisabled):
2958 (WebCache::disabled):
2960 (WebView::setCacheModel):
2962 2011-01-10 Geoffrey Garen <ggaren@apple.com>
2964 Try to fix Windows build.
2966 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
2967 this one before because it was miscapitalized.)
2969 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
2971 Reviewed by Darin Fisher.
2973 https://bugs.webkit.org/show_bug.cgi?id=41441
2974 createWindow method should only do window-creating without URL navigation
2976 * WebCoreSupport/WebChromeClient.cpp:
2977 (WebChromeClient::createWindow):
2979 2011-01-07 Adam Barth <abarth@webkit.org>
2981 Rubber-stamped by Eric Seidel.
2983 Move WebCore to Source
2984 https://bugs.webkit.org/show_bug.cgi?id=52050
2986 * WebKit.vcproj/WebKit.sln:
2988 2011-01-06 Gavin Barraclough <barraclough@apple.com>
2990 Reviewed by Geoff Garen.
2992 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
2994 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
2995 destructor early, in order to release wrappers once we know we no longer intend to use them.
2996 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
2997 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
2998 A sequence of events that triggers the bug would look like this:
3000 (1) Create a DOMWrapperWorld.
3001 (2) Register a timer in the world.
3002 (3) Call unregisterWorld() on the world.
3003 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3004 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3005 called forgetWorld() none exists.
3006 (6) Attempt to add a wrapper to a NULL map.
3008 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3010 * WebScriptWorld.cpp:
3011 (WebScriptWorld::unregisterWorld):
3013 2011-01-07 Chris Marrin <cmarrin@apple.com>
3015 Rubber-stamped by Simon Fraser.
3017 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
3018 https://bugs.webkit.org/show_bug.cgi?id=49388
3020 Change client API for the fullscreen video controller. It now uses a
3021 PlatformCALayerClient so it can use a PlaformCALayer directly. Also
3022 updated how to connect the layer tree to the view to reflect the updated
3023 hardware compositing logic.
3025 * FullscreenVideoController.cpp:
3026 (FullscreenVideoController::LayerClient::LayerClient):
3027 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
3028 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
3029 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
3030 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3031 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
3032 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
3033 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
3034 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
3035 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
3036 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
3037 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
3038 (FullscreenVideoController::FullscreenVideoController):
3039 (FullscreenVideoController::~FullscreenVideoController):
3040 (FullscreenVideoController::enterFullscreen):
3041 * FullscreenVideoController.h:
3042 * WebCoreSupport/WebChromeClient.cpp:
3043 (WebChromeClient::attachRootGraphicsLayer):
3044 (WebChromeClient::scheduleCompositingLayerSync):
3046 (WebView::setRootChildLayer):
3047 (WebView::animationsStarted):
3048 (WebView::syncCompositingState):
3050 (WebView::setRootLayerNeedsDisplay):
3052 2011-01-05 Steve Falkenburg <sfalken@apple.com>
3054 Reviewed by Darin Adler.
3056 Debug and Release builds on Windows clobber each other
3057 https://bugs.webkit.org/show_bug.cgi?id=49185
3059 Changes the structure of WebKitBuild build products directory so we
3060 completely separate each build configuration into independent directories.
3062 Although we previously had per-configuration directories for obj, this change adds
3063 per-configuration directories for bin, lib, obj, and include. Each configuration's
3064 build products are stored within a directory inside of WebKitBuild.
3066 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3067 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3069 * WebKit.vcproj/InterfacesCommon.vsprops:
3070 * WebKit.vcproj/InterfacesPostBuild.cmd:
3071 * WebKit.vcproj/InterfacesPreBuild.cmd:
3072 * WebKit.vcproj/WebKit.make:
3073 * WebKit.vcproj/WebKitGUID.vcproj:
3074 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
3075 * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
3076 * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
3077 * WebKit.vcproj/WebKitLibCommon.vsprops:
3078 * WebKit.vcproj/WebKitLibPostBuild.cmd:
3079 * WebKit.vcproj/WebKitLibPreBuild.cmd:
3081 2011-01-04 Chris Fleizach <cfleizach@apple.com>
3083 Reviewed by Sam Weinig.
3085 WK2: Support Accessibility
3086 https://bugs.webkit.org/show_bug.cgi?id=51859
3088 Use rootObject() method to get the top of the AX tree.
3090 * AccessibleDocument.cpp:
3091 (AccessibleDocument::AccessibleDocument):
3093 2011-01-01 Adam Barth <abarth@webkit.org>
3095 Reviewed by Eric Seidel.
3097 Move JavaScriptCore to Source
3098 https://bugs.webkit.org/show_bug.cgi?id=51604
3100 * WebKit.vcproj/WebKit.sln:
3101 - Point to JavaScriptCore in its new location.
3103 2010-12-22 Sam Weinig <sam@webkit.org>
3105 Reviewed by Darin Adler.
3107 WebKit2 needs to mirror the frame tree in the UIProcess
3108 https://bugs.webkit.org/show_bug.cgi?id=51546
3110 - Add client functions to notify that a frame has been added or
3111 removed from the page cache.
3113 * WebCoreSupport/WebFrameLoaderClient.cpp:
3114 (WebFrameLoaderClient::didSaveToPageCache):
3115 (WebFrameLoaderClient::didRestoreFromPageCache):
3116 * WebCoreSupport/WebFrameLoaderClient.h:
3118 2010-12-22 Dan Bernstein <mitz@apple.com>
3120 Changed WebKitTools to Tools.
3122 * WebKit.vcproj/WebKit.sln:
3124 2010-12-14 Adam Roben <aroben@apple.com>
3126 Always record the last-set cursor, even when the UI delegate is
3127 setting the cursor for us
3129 Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
3130 r63339 moved that code up to WebChromeClient, but failed to call it
3131 when the UI delegate was the one setting the cursor.
3133 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
3134 (r63339): Mouse cursor disappears when holding mouse button down on
3137 Reviewed by Ada Chan.
3139 * WebCoreSupport/WebChromeClient.cpp:
3140 (WebChromeClient::setCursor): After the cursor is set, regardless of
3141 whether the UI delegate sets it or we set it, record the cursor that
3142 was just set. That way we'll be able to use the cursor later when
3143 responding to the WM_SETCURSOR message.
3145 2010-12-13 Alexey Proskuryakov <ap@apple.com>
3147 Reviewed by Adam Barth.
3149 https://bugs.webkit.org/show_bug.cgi?id=50953
3150 DNS Prefetch should be an opt-in feature
3152 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
3154 2010-10-28 MORITA Hajime <morrita@google.com>
3156 Reviewed by Ojan Vafai.
3158 spellcheck does not check pasted text
3159 https://bugs.webkit.org/show_bug.cgi?id=40092
3161 Added a stub implememntation.
3163 * WebCoreSupport/WebEditorClient.h:
3164 (WebEditorClient::requestCheckingOfString):
3166 2010-12-10 Chris Fleizach <cfleizach@apple.com>
3168 Reviewed by Darin Adler.
3170 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
3171 https://bugs.webkit.org/show_bug.cgi?id=50574
3173 * AccessibleBase.cpp:
3174 (AccessibleBase::accHitTest):
3176 2010-12-09 Brian Weinstein <bweinstein@apple.com>
3178 Reviewed by Adam Roben.
3180 Prep for WebKit2: Context menu support on Windows
3181 https://bugs.webkit.org/show_bug.cgi?id=50514
3183 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
3184 instead of getCustomMenuFromDefaultItems.
3186 * WebCoreSupport/WebContextMenuClient.cpp:
3187 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
3188 this function, with refactoring using nativeMenu instead of platformDescription.
3189 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
3190 * WebCoreSupport/WebContextMenuClient.h:
3192 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
3193 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
3196 2010-12-07 Brian Weinstein <bweinstein@apple.com>
3198 Reviewed by John Sullivan.
3200 Layering Violation in ContextMenu - member variable of type HitTestResult
3201 https://bugs.webkit.org/show_bug.cgi?id=50586
3203 Update users of ContextMenu and ContextMenuController to match where the new functions
3206 * WebCoreSupport/WebContextMenuClient.cpp:
3207 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
3208 ContextMenuController (from the page).
3209 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
3211 (WebView::handleContextMenuEvent): Ditto.
3213 2010-12-07 Jessie Berlin <jberlin@apple.com>
3215 Build fix. Unreviewed.
3217 * WebCoreSupport/WebContextMenuClient.cpp:
3218 (WebContextMenuClient::searchWithGoogle):
3219 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
3221 2010-12-06 Darin Adler <darin@apple.com>
3223 Reviewed by Sam Weinig.
3225 Pass security origin to make local file decision correctly
3226 https://bugs.webkit.org/show_bug.cgi?id=48603
3228 * WebCoreSupport/WebContextMenuClient.cpp:
3229 (WebContextMenuClient::searchWithGoogle): Pass security origin.
3231 2010-12-07 Kenichi Ishibashi <bashi@google.com>
3233 Reviewed by Kent Tamura.
3235 Let HTMLObjectElement be a form associated element
3236 https://bugs.webkit.org/show_bug.cgi?id=48821
3238 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
3241 (WebFrame::elementWithName): Modified to use FormAssociatedElement
3242 instead of HTMLFormControlElement.
3243 (WebFrame::controlsInForm): Ditto.
3245 2010-12-05 Adam Roben <aroben@apple.com>
3247 Windows production build fix
3249 Put spaces after trailing backslashes when setting
3250 %WebKitVSPropsRedirectionDir%. According to MSDN
3251 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
3253 A backslash ( \ ) followed by a newline character is interpreted as
3254 a space in the command; use a backslash at the end of a line to
3255 continue a command onto the next line. NMAKE interprets the
3256 backslash literally if any other character, including a space or
3257 tab, follows the backslash.
3259 * WebKit.vcproj/WebKit.make:
3261 2010-12-03 Sam Weinig <sam@webkit.org>
3263 Reviewed by Maciej Stachowiak.
3265 Enable <a ping> for Mac/Windows/WebKit2 builds
3266 <rdar://problem/8504473>
3267 https://bugs.webkit.org/show_bug.cgi?id=50488
3269 * WebPreferences.cpp:
3270 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
3272 2010-12-03 Brian Weinstein <bweinstein@apple.com>
3274 Reviewed by Brady Eidson.
3276 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
3277 https://bugs.webkit.org/show_bug.cgi?id=50486
3279 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
3280 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
3281 item, but Safari didn't support it. We don't support that old Safari, so that code can go.
3283 * WebCoreSupport/WebContextMenuClient.cpp:
3284 (WebContextMenuClient::getCustomMenuFromDefaultItems):
3286 2010-12-02 John Knottenbelt <jknotten@chromium.org>
3288 Reviewed by Steve Block.
3290 Move requestGeolocationPermissionForFrame to GeolocationClient
3291 https://bugs.webkit.org/show_bug.cgi?id=50061
3293 This change facilitates client-based geolocation implementation by
3294 bringing together permission control into the geolocation client
3297 Move method ChromeClient::requestGeolocationPermissionForFrame to
3298 GeolocationClient::requestPermission. The moved code is unchanged
3299 except that requestPermission now takes only one argument (Geolocation*),
3300 the Frame parameter is retrieved from the Geolocation object and we need to
3301 call m_webView.get() as it is a COMPtr in GeolocationClient.
3303 * WebCoreSupport/WebChromeClient.cpp:
3304 * WebCoreSupport/WebChromeClient.h:
3305 * WebCoreSupport/WebGeolocationClient.cpp:
3306 (WebGeolocationClient::requestPermission):
3307 * WebCoreSupport/WebGeolocationClient.h:
3308 (WebGeolocationClient::cancelPermissionRequest):
3310 2010-12-01 Jia Pu <jpu@apple.com>
3312 Reviewed by Darin Adler.
3314 Support multiple correction candidates panel for misspelled word on Mac OS X.
3315 https://bugs.webkit.org/show_bug.cgi?id=50137
3316 <rdar://problem/8568059>
3318 Adopted new function signature defined in base class.
3320 * WebCoreSupport/WebEditorClient.cpp:
3321 (WebEditorClient::getGuessesForWord):
3322 * WebCoreSupport/WebEditorClient.h:
3324 2010-12-01 Steve Falkenburg <sfalken@apple.com>
3326 Reviewed by Adam Roben.
3328 WinCairo build should not use link-time code generation (LTCG)
3329 https://bugs.webkit.org/show_bug.cgi?id=50353
3331 * WebKit.vcproj/Interfaces.vcproj:
3332 * WebKit.vcproj/WebKit.vcproj:
3333 * WebKit.vcproj/WebKitGUID.vcproj:
3335 2010-12-01 Steve Falkenburg <sfalken@apple.com>
3337 Reviewed by Adam Roben.
3339 vcproj changes can't be applied cleanly by the Windows EWS bot
3340 https://bugs.webkit.org/show_bug.cgi?id=50328
3342 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
3343 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
3344 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
3345 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
3346 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
3347 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
3348 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
3349 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
3351 2010-11-30 Steve Falkenburg <sfalken@apple.com>
3353 Reviewed by Adam Roben.
3355 All projects on Windows should use cmd files for build events
3356 https://bugs.webkit.org/show_bug.cgi?id=50213
3358 * WebKit.vcproj/InterfacesCommon.vsprops:
3359 * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
3360 * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
3361 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
3362 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
3363 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
3364 * WebKit.vcproj/WebKitLibCommon.vsprops:
3365 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
3366 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
3368 2010-11-29 Brent Fulgham <bfulgham@webkit.org>
3370 Unreviewed build correction.
3372 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to
3373 use WinCairo.vsprops definition for appropriate build targets.
3375 2010-11-22 Adam Roben <aroben@apple.com>
3377 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3379 Apple's Windows build allows placing header files and import libraries for WebKit's
3380 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3381 $WebKitLibrariesDir environment variable. This is both required for production builds and
3382 convenient for Apple-internal developer builds. Apple's production builds also require that
3383 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3384 builds, the files are copied into that directory tree by the
3385 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3387 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3389 This .vsprops copying is problematic in one very important case: when a developer updates
3390 their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3391 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3392 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3393 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3394 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
3395 will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3397 To fix this, we now use normal relative paths to access the .vsprops files in the source
3398 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3399 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3400 unset, so the normal relative paths are used to read the .vsprops files out of the source
3401 tree directly. In production builds, this environment variable is set to a fake directory
3402 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3405 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3407 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3409 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3410 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3411 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3412 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3413 FeatureDefines.vsprops becomes:
3415 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3419 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3421 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3422 actually exist since they are matched by an equal number of ".." path components.)
3424 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3425 Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3427 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3430 Reviewed by Dave Hyatt.
3432 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
3433 find the .vsprops files.
3435 * WebKit.vcproj/WebKit.vcproj:
3436 * WebKit.vcproj/Interfaces.vcproj:
3437 * WebKit.vcproj/WebKitGUID.vcproj:
3438 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3441 2010-11-19 Steve Falkenburg <sfalken@apple.com>
3443 Reviewed by Adam Roben.
3445 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3446 https://bugs.webkit.org/show_bug.cgi?id=49819
3448 * WebKit.vcproj/Interfaces.vcproj:
3449 * WebKit.vcproj/WebKit.sln:
3450 * WebKit.vcproj/WebKit.vcproj:
3451 * WebKit.vcproj/WebKitGUID.vcproj:
3453 2010-11-19 Steve Falkenburg <sfalken@apple.com>
3455 Reviewed by Darin Adler.
3457 Normalize Cairo/CFLite project/solution configuration names
3458 https://bugs.webkit.org/show_bug.cgi?id=49818
3460 * WebKit.vcproj/WebKit.sln:
3461 * WebKit.vcproj/WebKit.vcproj:
3463 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3465 Reviewed by Adam Roben.
3467 Windows vcproj configuration names should be normalized across projects
3468 https://bugs.webkit.org/show_bug.cgi?id=49776
3470 * WebKit.vcproj/Interfaces.vcproj:
3471 * WebKit.vcproj/WebKit.sln:
3473 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3475 Reviewed by Adam Roben.
3477 Remove leftover Windows Debug_Internal configurations
3478 https://bugs.webkit.org/show_bug.cgi?id=49758
3480 * WebKit.vcproj/WebKit.vcproj:
3481 * WebKit.vcproj/WebKitGUID.vcproj:
3483 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3485 Reviewed by Adam Roben.
3487 Debug_Internal Windows configuration is unnecessary, should be removed
3488 https://bugs.webkit.org/show_bug.cgi?id=49753
3492 2010-11-17 Steve Falkenburg <sfalken@apple.com>
3494 Reviewed by Adam Roben.
3496 WebKit Interfaces project should use vsprops file for common build settings
3497 https://bugs.webkit.org/show_bug.cgi?id=49713
3499 * WebKit.vcproj/Interfaces.vcproj:
3500 * WebKit.vcproj/InterfacesCommon.vsprops: Added.
3502 2010-11-16 Steve Falkenburg <sfalken@apple.com>
3504 Reviewed by Adam Roben.
3506 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
3507 https://bugs.webkit.org/show_bug.cgi?id=49632
3509 * WebKit.vcproj/Interfaces.vcproj:
3510 * WebKit.vcproj/WebKit.make:
3511 * WebKit.vcproj/WebKit.sln:
3512 * WebKit.vcproj/WebKit.submit.sln:
3513 * WebKit.vcproj/WebKit.vcproj:
3514 * WebKit.vcproj/WebKitGUID.vcproj:
3516 2010-11-16 Dave Hyatt <hyatt@apple.com>
3518 Reviewed by Dan Bernstein.
3520 https://bugs.webkit.org/show_bug.cgi?id=11004
3522 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
3523 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
3524 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
3525 of the constructor rather than using [NSFont pointSize].
3527 https://bugs.webkit.org/show_bug.cgi?id=49582
3529 Negative leading is not handled correctly. There are two bugs here. The first is that
3530 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
3531 set them before so that we can allow them to be < 0.
3533 The second issue is that we should understand where fonts will end up relative to
3534 our baseline (excluding line height), and only allow those boxes to impact ascent and
3535 descent if the actual font box (without factoring in line height) is above or below the
3536 root line box baseline.
3538 Added fast/css/negative-leading.html
3540 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
3542 * WebPreferences.cpp:
3543 (WebPreferences::initializeDefaultSettings):
3545 2010-11-16 Steve Falkenburg <sfalken@apple.com>
3547 Reviewed by Adam Roben.
3549 Use vsprops files for common settings in Windows WebKit
3550 https://bugs.webkit.org/show_bug.cgi?id=49622
3552 * WebKit.vcproj/WebKit.vcproj:
3553 * WebKit.vcproj/WebKitCommon.vsprops: Added.
3555 2010-11-16 Steve Falkenburg <sfalken@apple.com>
3557 Rubber stamped by Adam Roben.
3559 Remove unnecessary def file, remove outdated def files from vcproj.
3561 * WebKit.vcproj/WebKit.vcproj:
3562 * WebKit.vcproj/WebKit_debug.def: Removed.
3564 2010-11-12 John Knottenbelt <jknotten@chromium.org>
3566 Reviewed by Steve Block.
3568 Rename GeolocationControllerClient to GeolocationClient.
3569 https://bugs.webkit.org/show_bug.cgi?id=49259
3571 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
3572 (WebGeolocationClient::WebGeolocationClient):
3573 (WebGeolocationClient::geolocationDestroyed):
3574 (WebGeolocationClient::startUpdating):
3575 (WebGeolocationClient::stopUpdating):
3576 (WebGeolocationClient::lastPosition):
3577 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
3578 (WebGeolocationClient::setEnableHighAccuracy):
3579 * WebKit.vcproj/WebKit.vcproj:
3581 (WebView::initWithFrame):
3583 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
3585 Reviewed by David Hyatt.
3587 HTML5 Ruby support should be mandatory feature
3588 https://bugs.webkit.org/show_bug.cgi?id=49272
3590 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
3592 2010-11-08 Alexey Proskuryakov <ap@apple.com>
3596 * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
3598 2010-11-08 Alexey Proskuryakov <ap@apple.com>
3600 Reviewed by Darin Adler.
3602 https://bugs.webkit.org/show_bug.cgi?id=48685
3603 Notify UI process about focused frame
3605 Added an empty implementation of the new ChromeClient method.
3607 * WebCoreSupport/WebChromeClient.cpp:
3608 (WebChromeClient::focusedFrameChanged):
3609 * WebCoreSupport/WebChromeClient.h:
3611 2010-11-07 Adam Barth <abarth@webkit.org>
3613 Reviewed by Eric Seidel.
3615 Rename Cache to MemoryCache
3616 https://bugs.webkit.org/show_bug.cgi?id=49159
3619 (WebCache::statistics):
3623 2010-11-05 Chris Marrin <cmarrin@apple.com>
3625 Reviewed by Simon Fraser.
3627 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
3628 https://bugs.webkit.org/show_bug.cgi?id=49073
3631 (WebFrame::suspendAnimations):
3632 (WebFrame::resumeAnimations):
3634 2010-11-05 Brian Weinstein <bweinstein@apple.com>
3636 Reviewed by Anders Carlsson.
3638 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
3639 https://bugs.webkit.org/show_bug.cgi?id=48751
3640 <rdar://problem/8615536>
3642 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
3643 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
3644 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
3645 an assert in the PluginStream destructor.
3647 * WebCoreSupport/WebFrameLoaderClient.cpp:
3648 (WebFrameLoaderClient::finishedLoading):
3650 2010-11-05 Chris Marrin <cmarrin@apple.com>
3652 Reviewed by Simon Fraser.
3654 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
3655 https://bugs.webkit.org/show_bug.cgi?id=46945
3658 (WebFrame::suspendAnimations):
3659 (WebFrame::resumeAnimations):
3661 2010-11-05 Patrick Gansterer <paroga@webkit.org>
3663 Reviewed by David Kilzer.
3665 Replace ARRAYSIZE with WTF_ARRAY_LENGTH
3666 https://bugs.webkit.org/show_bug.cgi?id=48903
3668 * WebCoreSupport/WebChromeClient.cpp:
3669 (WebChromeClient::exceededDatabaseQuota):
3671 (DllGetClassObject):
3673 (WebView::mouseWheel):
3675 2010-11-02 Daniel Bates <dbates@rim.com>
3677 Reviewed by Adam Barth.
3679 For unnamed frames, window.name returns a generated name
3680 https://bugs.webkit.org/show_bug.cgi?id=6751
3684 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
3689 2010-11-02 Brady Eidson <beidson@apple.com>
3691 Reviewed by Anders Carlsson.
3693 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
3694 Implement IMutableWebRequest::setTimeoutInterval
3696 * WebMutableURLRequest.cpp:
3697 (WebMutableURLRequest::setTimeoutInterval):
3699 2010-11-02 Daniel Bates <dbates@rim.com>
3701 Reviewed by Martin Robinson.
3703 Set frame name before appending it to the frame tree in the Apple Windows,
3705 https://bugs.webkit.org/show_bug.cgi?id=48806
3707 Make the frame creation process in the Apple Windows-port consistent
3708 with the Mac, Qt, and Haiku ports. In particular, set the name of
3709 the new frame before it's appended to the frame tree.
3711 At this time we cannot test this change since it is being masked by
3712 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
3713 We'll be able to test this once we fix bug #6751.
3715 * WebCoreSupport/WebFrameLoaderClient.cpp:
3716 (WebFrameLoaderClient::createFrame):
3718 2010-11-01 Jenn Braithwaite <jennb@chromium.org>
3720 Reviewed by Adam Roben.
3722 Windows: Update resource tracking when moving a frame between documents
3723 https://bugs.webkit.org/show_bug.cgi?id=48364
3725 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
3726 Added removeIdentifierForRequest.
3727 * Interfaces/WebKit.idl:
3728 Added IWebResourceLoadDelegatePrivate2.idl.
3729 * WebCoreSupport/WebFrameLoaderClient.cpp:
3730 (WebFrameLoaderClient::transferLoadingResourceFromPage):
3732 2010-11-01 Brady Eidson <beidson@apple.com>
3734 Reviewed by Anders Carlsson.
3736 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
3737 Context menu support for WebKit 2.
3739 * WebCoreSupport/WebChromeClient.h:
3740 (WebChromeClient::showContextMenu):
3742 2010-11-01 Adam Roben <aroben@apple.com>
3744 Cancel main resource loads after we hand them off to the media engine
3746 This is the Windows equivalent of r51104. Clearly this code should be
3747 moved to a cross-platform location someday.
3749 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
3750 failure in DocumentLoader::commitData when loading a media document in
3753 Reviewed by Dan Bernstein.
3755 * WebCoreSupport/WebFrameLoaderClient.cpp:
3756 (WebFrameLoaderClient::committedLoad): Cancel the main resource load
3757 after handing off the load to the media engine. This code originally
3758 came from -[WebHTMLRepresentation receivedData:withDataSource:].
3761 (WebFrame::shouldFallBack): Don't fall back when handing the resource
3762 load off to the media engine or a plugin. Added error domain checking
3763 so that we don't rely on error codes being unique.
3765 2010-10-29 Daniel Bates <dbates@rim.com>
3767 No review, rolling out 70971.
3768 http://trac.webkit.org/changeset/70971
3769 https://bugs.webkit.org/show_bug.cgi?id=6751
3771 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
3772 it caused layout test failures on all bots. In particular, the
3773 child count in a generated frame name differs after this patch. We need
3774 to look into this further.
3779 2010-10-28 Antonio Gomes <agomes@rim.com>
3781 Reviewed by Ojan Vafai.
3783 Needs a "LinuxEditingBehavior", perhaps with a better name
3784 https://bugs.webkit.org/show_bug.cgi?id=36627
3786 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
3788 * Interfaces/IWebPreferences.idl:
3790 2010-10-29 Daniel Bates <dbates@rim.com>
3792 Reviewed by Adam Barth.
3794 For unnamed frames, window.name returns a generated name
3795 https://bugs.webkit.org/show_bug.cgi?id=6751
3797 Modified Apple Windows-port to use FrameTree::uniqueName().
3802 2010-10-29 Darin Adler <darin@apple.com>
3804 Reviewed by Sam Weinig.
3806 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
3807 https://bugs.webkit.org/show_bug.cgi?id=48574
3809 * WebBackForwardList.cpp:
3810 (backForwardListWrappers):
3811 (WebBackForwardList::WebBackForwardList):
3812 (WebBackForwardList::createInstance):
3813 * WebBackForwardList.h:
3815 (WebView::backForwardList):
3816 Use BackForwardListImpl.
3818 2010-10-29 Adam Roben <aroben@apple.com>
3822 * WebKitPrefix.h: Touched to force a rebuild.
3824 2010-10-29 Alexey Proskuryakov <ap@apple.com>
3826 Reviewed by Darin Adler.
3828 https://bugs.webkit.org/show_bug.cgi?id=48576
3829 Let WebKit2 client know when a frame is a frameset
3831 Added a blank implementation of the new FrameLoaderClient method.
3833 * WebCoreSupport/WebFrameLoaderClient.h:
3834 * WebCoreSupport/WebFrameLoaderClient.cpp:
3835 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
3837 2010-10-26 Brent Fulgham <bfulgham@webkit.org>
3839 Unreviewed build fix.
3841 * WebView.cpp: Conditionalize includes for CFNetwork-specific
3842 Cookie implementation.
3843 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
3844 WinCairo doesn't use CoreAnimation.
3846 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
3848 Reviewed by Dmitry Titov.
3850 Resource tracking failure when trying to move a frame between documents
3851 https://bugs.webkit.org/show_bug.cgi?id=44713
3853 * WebCoreSupport/WebFrameLoaderClient.cpp:
3854 (WebFrameLoaderClient::transferLoadingResourceFromPage):
3856 * WebCoreSupport/WebFrameLoaderClient.h:
3858 2010-10-25 Patrick Gansterer <paroga@webkit.org>
3860 Reviewed by David Kilzer.
3862 Replace _countof with WTF_ARRAY_LENGTH
3863 https://bugs.webkit.org/show_bug.cgi?id=48229
3865 * WebCoreSupport/WebContextMenuClient.cpp:
3866 (isPreInspectElementTagSafari):
3868 (WebView::interpretKeyEvent):
3870 2010-10-24 Dan Bernstein <mitz@apple.com>
3874 * Interfaces/WebKit.idl: Touched.
3876 2010-10-24 Dan Bernstein <mitz@apple.com>
3878 Reviewed by Anders Carlsson.
3880 Expose HitTestResult::absoluteMediaURL() via WebKit API
3881 https://bugs.webkit.org/show_bug.cgi?id=48219
3883 * Interfaces/IWebView.idl: Added WebElementMediaURLKey.
3884 * WebElementPropertyBag.cpp:
3885 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
3887 2010-10-22 Andy Estes <aestes@apple.com>
3889 Fix the Windows build.
3891 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
3892 * WebView.cpp: Ditto.
3894 2010-10-22 Jenn Braithwaite <jennb@chromium.org>
3896 Reviewed by Adam Roben.
3898 Windows client needs updating when live iframe element is moved between pages
3899 https://bugs.webkit.org/show_bug.cgi?id=46915
3901 * WebCoreSupport/WebFrameLoaderClient.cpp:
3902 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
3903 Update WebView in WebFrame to match that of the current page.
3905 (WebFrame::setWebView):
3909 2010-10-22 Sam Weinig <sam@webkit.org>
3913 * WebCoreSupport/WebChromeClient.h:
3915 2010-10-22 Sam Weinig <sam@webkit.org>
3917 Reviewed by Anders Carlsson.
3919 WebKit2 needs to pass the current event modifier flags when requesting a new window
3920 https://bugs.webkit.org/show_bug.cgi?id=48140
3922 * WebCoreSupport/WebChromeClient.cpp:
3923 (WebChromeClient::createWindow):
3924 * WebCoreSupport/WebFrameLoaderClient.cpp:
3925 (WebFrameLoaderClient::dispatchCreatePage):
3926 * WebCoreSupport/WebFrameLoaderClient.h:
3927 Add NavigationAction parameter.
3929 2010-10-21 MORITA Hajime <morrita@google.com>
3931 Unreviewed, touched it to fix the build.
3933 * Interfaces/WebKit.idl:
3935 2010-10-21 MORITA Hajime <morrita@google.com>
3937 Reviewed by Kent Tamura.
3939 [Win][DRT] should have LayoutTestController.hasSpellingMarker()
3940 https://bugs.webkit.org/show_bug.cgi?id=47885
3942 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
3943 LayoutTestController.
3945 * Interfaces/IWebFramePrivate.idl:
3947 (WebFrame::hasSpellingMarker):
3950 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
3952 Reviewed by David Levin.
3954 Repost the DatabaseTracker notifications to the main thread, if needed.
3955 https://bugs.webkit.org/show_bug.cgi?id=40655
3957 * WebDatabaseManager.cpp:
3958 (DidModifyOriginData::dispatchToMainThread):
3959 (DidModifyOriginData::DidModifyOriginData):
3960 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
3961 (WebDatabaseManager::dispatchDidModifyOrigin):
3962 (WebDatabaseManager::dispatchDidModifyDatabase):
3964 2010-10-20 Dirk Schulze <krit@webkit.org>
3966 Reviewed by Nikolas Zimmermann.
3968 Merge ColorSpace and ImageColorSpace enums
3969 https://bugs.webkit.org/show_bug.cgi?id=47922
3971 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
3972 to follow webkit style rules.
3974 * FullscreenVideoController.cpp:
3977 (FullscreenVideoController::draw):
3978 * WebCoreSupport/WebDragClient.cpp:
3979 (WebDragClient::createDragImageForLink):
3980 * WebKitGraphics.cpp:
3983 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
3985 Reviewed by Timothy Hatcher.
3987 Web Inspector: disable private browsing for inspector
3988 https://bugs.webkit.org/show_bug.cgi?id=47827
3990 * WebCoreSupport/WebInspectorClient.cpp:
3991 (WebInspectorClient::openInspectorFrontend):
3993 2010-10-17 Adam Barth <abarth@webkit.org>
3995 Reviewed by Dimitri Glazkov.
3997 FrameLoader doesn't need an explicit userGesture parameter
3998 https://bugs.webkit.org/show_bug.cgi?id=47777
4000 Update for the new API.
4002 * WebCoreSupport/WebContextMenuClient.cpp:
4003 (WebContextMenuClient::searchWithGoogle):
4005 2010-10-15 Brian Weinstein <bweinstein@apple.com>
4007 Reviewed by Sam Weinig.
4009 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
4010 https://bugs.webkit.org/show_bug.cgi?id=47753
4011 <rdar://problem/8558242>
4013 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
4014 when we turn it into a WebCore string, or else concatenation using this string will break.
4018 2010-10-15 Jessie Berlin <jberlin@apple.com>
4020 Windows build fix. Unreviewed.
4022 * WebCoreSupport/WebInspectorClient.cpp:
4023 Add a missing include.
4025 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
4027 Reviewed by Dirk Schulze.
4029 Replace some String::format() usages by StringConcatenate in WebKit
4030 https://bugs.webkit.org/show_bug.cgi?id=47714
4032 * WebCoreSupport/WebInspectorClient.cpp:
4033 (WebInspectorFrontendClient::updateWindowTitle):
4035 (WebView::standardUserAgentWithApplicationName):
4038 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
4040 Reviewed by Pavel Feldman.
4042 Web Inspector: inspector settings/properties/states management
4043 should be extracted into separate class.
4045 We have a lot of flags/values in InspectorController.
4046 Some flags are persisting into profile.
4047 Others are part of inspector state for frontend.
4048 All these flags should keep their values after navigation.
4049 It'd be better to extract these flags/values into separate
4050 class which will care about theirs lifetime.
4052 https://bugs.webkit.org/show_bug.cgi?id=47275
4054 * WebCoreSupport/WebInspectorClient.cpp:
4055 (WebInspectorFrontendClient::attachWindow):
4056 (WebInspectorFrontendClient::detachWindow):
4057 (WebInspectorFrontendClient::showWindowWithoutNotifications):
4059 2010-10-13 Gavin Barraclough <barraclough@apple.com>
4061 Reviewed by Oliver Hunt.
4063 https://bugs.webkit.org/show_bug.cgi?id=43987
4064 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
4065 to construct their internal result string. Remove ScriptString (this is now
4068 * WebCoreSupport/WebFrameLoaderClient.cpp:
4070 2010-10-12 Adam Roben <aroben@apple.com>
4072 Build TestWebKitAPI on Windows
4074 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
4075 TestWebKitAPI work on Windows
4077 Reviewed by Sam Weinig.
4079 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
4080 TestWebKitAPIGenerated and made them build just after
4083 2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
4085 Attempt to fix windows build failure.
4087 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
4088 https://bugs.webkit.org/show_bug.cgi?id=47523
4090 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
4091 * Interfaces/WebKit.idl: Touched.
4092 * WebFrame.cpp: s/unused1/unused2/
4093 (WebFrame::unused2):
4094 * WebFrame.h: s/unused1/unused2/
4096 2010-10-11 Anders Carlsson <andersca@apple.com>
4098 Reviewed by Darin Adler.
4100 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
4101 https://bugs.webkit.org/show_bug.cgi?id=47523
4103 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
4105 * Interfaces/IWebFramePrivate.idl:
4106 * Interfaces/IWebIconFetcher.idl: Removed.
4107 * Interfaces/WebKit.idl:
4109 (WebFrame::unused1):
4111 * WebIconFetcher.cpp: Removed.
4112 * WebIconFetcher.h: Removed.
4113 * WebKit.vcproj/Interfaces.vcproj:
4114 * WebKit.vcproj/WebKit.vcproj:
4116 2010-10-11 Jessie Berlin <jberlin@apple.com>
4118 Reviewed by Darin Adler.
4120 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
4121 representation of a WebKit1 WebSerializedJSValue.
4122 https://bugs.webkit.org/show_bug.cgi?id=47439
4124 * Interfaces/IWebSerializedJSValuePrivate.idl:
4125 Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
4127 * WebSerializedJSValue.cpp:
4128 (WebSerializedJSValue::getInternalRepresentation):
4129 * WebSerializedJSValue.h:
4131 2010-10-07 Jessie Berlin <jberlin@apple.com>
4133 Reviewed by Sam Weinig.
4135 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
4136 representation of a WebKit2 WebSerializedScriptValue.
4137 https://bugs.webkit.org/show_bug.cgi?id=47390
4139 * Interfaces/WebKit.idl:
4140 Generate IWebSerializedJSValuePrivate.
4142 * Interfaces/IWebSerializedJSValuePrivate.idl: Added.
4143 Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
4145 * WebKit.vcproj/Interfaces.vcproj:
4146 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
4148 * WebSerializedJSValue.cpp:
4149 (WebSerializedJSValue::QueryInterface):
4150 Since there are now two interfaces that inherit from IUnknown, do not try to cast to
4151 IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
4152 (WebSerializedJSValue::setInternalRepresentation):
4153 Only set the internal representation if it hasn't already been set.
4154 * WebSerializedJSValue.h:
4156 2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
4158 Prevent an assertion failure when trying to create a protection space
4161 Reviewed by Sam Weinig.
4163 * WebURLProtectionSpace.cpp:
4164 (WebURLProtectionSpace::initWithHost):
4165 Remove the ASSERT_NOT_REACHED().
4167 2010-10-05 Brent Fulgham <bfulgham@webkit.org>
4169 Unreviewed build correction.
4171 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
4172 off for WinCairo release builds. Somehow this was
4173 incorrectly turned on.
4175 2010-10-01 Mark Rowe <mrowe@apple.com>
4179 Clear the executable bit from a number of source files.
4184 2010-09-30 Darin Adler <darin@apple.com>
4186 Reviewed by Sam Weinig.
4188 Remove remaining calls to deprecatedParseURL
4189 https://bugs.webkit.org/show_bug.cgi?id=26599
4191 * WebCoreSupport/WebFrameLoaderClient.cpp:
4192 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
4193 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
4195 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
4197 Reviewed by Dmitry Titov.
4199 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
4200 https://bugs.webkit.org/show_bug.cgi?id=46663
4202 * WebCoreSupport/WebFrameLoaderClient.cpp:
4203 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
4204 * WebCoreSupport/WebFrameLoaderClient.h:
4206 2010-09-27 Andrey Kosyakov <caseq@chromium.org>
4208 Unreviewed build fix (win; broken in r68371)
4210 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
4212 2010-09-23 Matthew Delaney <mdelaney@apple.com>
4214 Reviewed by Simon Fraser.
4216 Reduce minimum DOMTimer interval
4217 https://bugs.webkit.org/show_bug.cgi?id=45362
4220 Updating set interval call to use Settings' static version inside
4221 one time init block.
4223 2010-09-23 Nate Chapin <japhet@chromium.org>
4225 Unreviewed, build fix.
4227 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
4228 and touch WebKit.idl
4230 * Interfaces/IWebPreferences.idl:
4231 * Interfaces/IWebPreferencesPrivate.idl:
4232 * Interfaces/WebKit.idl:
4234 (WebView::notifyPreferencesChanged):
4236 2010-09-23 Nate Chapin <japhet@chromium.org>
4238 Unreviewed, build fix.
4240 Look for hyperlinkAuditingEnabled in the right set of preferences.
4243 (WebView::notifyPreferencesChanged):
4245 2010-09-23 Nate Chapin <japhet@chromium.org>
4247 Reviewed by Darin Fisher.
4249 Add hyperlink auditing settings (i.e., <a ping>).
4250 https://bugs.webkit.org/show_bug.cgi?id=30458
4252 * Interfaces/IWebPreferences.idl:
4253 * WebPreferenceKeysPrivate.h:
4254 * WebPreferences.cpp:
4255 (WebPreferences::initializeDefaultSettings):
4256 (WebPreferences::hyperlinkAuditingEnabled):
4257 (WebPreferences::setHyperlinkAuditingEnabled):
4260 (WebView::notifyPreferencesChanged):
4262 2010-09-23 Matthew Delaney <mdelaney@apple.com>
4264 Reviewed by Adam Roben.
4266 Create one time initialization block for WebView's initWithFrame
4267 https://bugs.webkit.org/show_bug.cgi?id=46307
4269 * WebView.cpp: Added one time initialization block for webview code
4270 that needs only be run once and not for each webview. This is just as
4271 the mac version WebView.mm does.
4273 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
4275 Reviewed by Martin Robinson.
4277 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
4278 https://bugs.webkit.org/show_bug.cgi?id=46303.
4280 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
4281 Release_Cairo configurations to select appropriate build
4282 targets for WebKitTestRunner and MiniBrowser.
4284 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
4286 Reviewed by Martin Robinson.
4288 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
4289 https://bugs.webkit.org/show_bug.cgi?id=46303.
4291 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
4292 Release_Cairo configurations to select appropriate build
4293 targets for InjectionBundle.
4295 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
4297 Reviewed by Kenneth Rohde Christiansen.
4299 PluginStrategy should satisfy the needs of Qt
4300 https://bugs.webkit.org/show_bug.cgi?id=45857
4301 No new functionality so no new tests.
4303 * WebCoreSupport/WebPlatformStrategies.cpp:
4304 (WebPlatformStrategies::getPluginInfo):
4305 * WebCoreSupport/WebPlatformStrategies.h:
4307 2010-09-20 Philippe Normand <pnormand@igalia.com>
4309 Reviewed by Eric Carlson.
4311 [GTK] enhanced context menu for media elements
4312 https://bugs.webkit.org/show_bug.cgi?id=45021
4314 New localized strings for the media element context-menu.
4316 * WebCoreSupport/WebPlatformStrategies.cpp:
4317 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
4318 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
4319 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
4320 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
4321 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
4322 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
4323 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
4324 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
4325 (WebPlatformStrategies::contextMenuItemTagMediaPause):
4326 (WebPlatformStrategies::contextMenuItemTagMediaMute):
4327 * WebCoreSupport/WebPlatformStrategies.h:
4329 2010-09-17 Darin Adler <darin@apple.com>
4331 Reviewed by Sam Weinig.
4333 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
4334 https://bugs.webkit.org/show_bug.cgi?id=42863
4337 (WebView::setZoomMultiplier):
4338 Call functions on Frame instead of FrameView.
4340 2010-09-17 Matthew Delaney <mdelaney@apple.com>
4342 Reviewed by Simon Fraser.
4344 Reduce minimum DOMTimer interval
4345 https://bugs.webkit.org/show_bug.cgi?id=45362
4347 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
4349 2010-09-17 Simon Fraser <simon.fraser@apple.com>
4351 Reviewed by Chris Marrin.
4353 Remove scroll and clip layers for WKCACFLayerRenderer
4354 https://bugs.webkit.org/show_bug.cgi?id=45922
4356 WKCACFLayerRenderer no longer needs its own layers for managing scrolling
4357 and clipping, because RenderLayerCompositor provides this functionality.
4360 (WebView::sizeChanged): Moved code that handles the WM_SIZE message
4361 into this method. Use it to resize the layer renderer.
4362 (WebView::WebViewWndProc): Call sizeChanged().
4363 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
4364 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
4367 2010-09-16 Darin Adler <darin@apple.com>
4369 Reviewed by Andreas Kling.
4371 Reduce use of HTMLInputElement::inputType so we can remove it later
4372 https://bugs.webkit.org/show_bug.cgi?id=45903
4375 (WebFrame::elementDoesAutoComplete): Use isPasswordField.
4376 (WebFrame::elementIsPassword): Use isPasswordField.
4378 2010-09-14 Ada Chan <adachan@apple.com>
4380 Reviewed by Adam Roben.
4382 Add an IWebFramePrivate API to load string as plain text into the WebFrame.
4383 https://bugs.webkit.org/show_bug.cgi?id=45782
4385 * Interfaces/IWebFramePrivate.idl:
4386 * Interfaces/WebKit.idl: Touch the file.
4388 (WebFrame::loadPlainTextString):
4391 2010-09-13 Enrica Casucci <enrica@apple.com>
4393 Reviewed by Sam Weinig.
4395 Paste should be implemented in WebCore like Copy and Cut for Mac also.
4396 https://bugs.webkit.org/show_bug.cgi?id=45494
4397 <rdar://problem/7660537>
4399 On the Mac platform, the implementation of the paste operation is all done
4400 at the WebKit level. In order to support it on WebKit2 it is necessary to
4401 refactor the code and move this functionality at the level of WebCore like
4402 we already have on Windows.
4403 The original code relies on some in AppKit functions that call back into
4404 WebKit causing problems in WebKit2. All this functionality has been moved
4405 at the level of the editor client where it can be dealt with appropriately.
4408 (WebFrame::canShowMIMETypeASHTML): Added.
4410 2010-09-11 Adam Barth <abarth@webkit.org>
4412 Reviewed by Sam Weinig.
4414 Make SecurityOrigin::canDisplay an instance function
4415 https://bugs.webkit.org/show_bug.cgi?id=45219
4418 (WebFrame::allowsFollowingLink):
4420 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
4422 Reviewed by Darin Adler.
4424 Add NetworkingContext to avoid layer violations
4425 https://bugs.webkit.org/show_bug.cgi?id=42292
4427 * WebCoreSupport/WebFrameNetworkingContext.cpp:
4428 (WebFrameNetworkingContext::blockedError):
4429 * WebCoreSupport/WebFrameNetworkingContext.h:
4431 2010-09-10 Jer Noble <jer.noble@apple.com>
4433 Reviewed by Simon Fraser.
4435 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
4436 https://bugs.webkit.org/show_bug.cgi?id=45333
4438 The rootChild layer must be set as flipped, otherwise transformed movies will appear
4439 incorrectly rotated.
4441 * FullscreenVideoController.cpp:
4442 (FullscreenVideoController::enterFullscreen):
4444 2010-09-10 Sam Weinig <sam@webkit.org>
4446 Reviewed by Darin Adler.
4448 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
4449 Precursor to <rdar://problem/7660657>
4450 https://bugs.webkit.org/show_bug.cgi?id=45522
4458 (WebView::setZoomMultiplier):
4459 (WebView::zoomMultiplier):
4460 (WebView::canMakeTextLarger):
4461 (WebView::makeTextLarger):
4462 (WebView::canMakeTextSmaller):
4463 (WebView::makeTextSmaller):
4464 (WebView::notifyPreferencesChanged):
4466 Move tracking of text only zoom here from WebCore.
4468 2010-09-10 Brian Weinstein <bweinstein@apple.com>
4470 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
4471 SelectionController instead of frame. Also fix a style issue.
4474 (WebFrame::currentForm):
4476 2010-09-10 Adam Barth <abarth@webkit.org>
4478 Reviewed by Darin Fisher.
4480 Move code from WebKit-layer to DocumentLoader
4481 https://bugs.webkit.org/show_bug.cgi?id=45569
4483 * WebCoreSupport/WebFrameLoaderClient.cpp:
4484 (WebFrameLoaderClient::committedLoad):
4485 * WebCoreSupport/WebFrameLoaderClient.h:
4487 2010-09-09 Darin Adler <darin@apple.com>
4489 Reviewed by Adam Barth.
4491 Move functions from Frame to SelectionController as planned
4492 https://bugs.webkit.org/show_bug.cgi?id=45508
4495 (WebView::selectionRect):
4496 (WebView::centerSelectionInVisibleArea):
4497 Call functions on selection().
4499 2010-09-10 Adam Barth <abarth@webkit.org>
4501 Reviewed by Eric Seidel.
4503 Main resource bytes shouldn't bounce through FrameLoader
4504 https://bugs.webkit.org/show_bug.cgi?id=45496
4506 Now return the bytes to the DocumentLoader.
4508 * WebCoreSupport/WebFrameLoaderClient.cpp:
4509 (WebFrameLoaderClient::receivedData):
4511 2010-09-09 Simon Fraser <simon.fraser@apple.com>
4513 Reviewed by Adam Roben.
4515 Scrollbars fail to render in composited iframes.
4516 https://bugs.webkit.org/show_bug.cgi?id=45335
4518 Use LocalWindowsContext when painting scrollbars.
4520 * WebCoreSupport/WebChromeClient.cpp:
4521 (WebChromeClient::paintCustomScrollbar):
4522 (WebChromeClient::paintCustomScrollCorner):
4524 2010-09-08 Darin Adler <darin@apple.com>
4526 Reviewed by Adam Barth.
4528 Move functions from Frame to Editor as planned
4529 https://bugs.webkit.org/show_bug.cgi?id=45218
4531 * WebCoreSupport/WebContextMenuClient.cpp:
4532 (WebContextMenuClient::searchWithGoogle):
4534 (WebFrame::selectedString):
4536 (WebView::selectedText):
4537 (WebView::prepareCandidateWindow):
4538 (WebView::onIMERequestCharPosition):
4539 Changed call sites to use editor().
4541 2010-09-08 Peter Kasting <pkasting@google.com>
4543 Not reviewed, build fix.
4546 (WebScrollBar::setScrollOffsetFromAnimation):
4548 2010-09-08 Peter Kasting <pkasting@google.com>
4550 Not reviewed, build fix.
4553 (WebScrollBar::scrollSize):
4554 (WebScrollBar::setScrollOffsetFromAnimation):
4556 2010-09-08 Peter Kasting <pkasting@google.com>
4558 Not reviewed, build fix.
4561 (WebScrollBar::setValue):
4562 (WebScrollBar::scrollSize):
4563 (WebScrollBar::setScrollOffsetFromAnimation):
4566 2010-09-08 Adam Barth <abarth@webkit.org>
4568 Attempted Window build fix.
4570 * WebDataSource.cpp:
4571 (WebDataSource::subresourceForURL):
4573 2010-09-08 Adam Barth <abarth@webkit.org>
4575 Rubber-stamped by Eric Seidel.
4577 Rename DocLoader to CachedResourceLoader because that's what it does.
4579 * WebDataSource.cpp:
4581 2010-09-07 Brent Fulgham <bfulgham@webkit.org>
4583 Reviewed by Adam Roben.
4585 Clean up a potential resource leak.
4586 https://bugs.webkit.org/show_bug.cgi?id=45198
4588 Several bitmap device context were being created and used,
4589 and destroyed without returning the context to its original
4590 state. This showed up as bitmap leaks in BoundsChecker.
4592 * FullscreenVideoController.cpp:
4594 (WebView::scrollBackingStore):
4597 2010-09-06 Adam Barth <abarth@webkit.org>
4599 Reviewed by Darin Adler.
4601 Rename SecurityOrigin::canLoad to canDisplay
4602 https://bugs.webkit.org/show_bug.cgi?id=45214
4604 Propagate name change.
4607 (WebFrame::allowsFollowingLink):
4609 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
4611 Reviewed by Darin Adler.
4613 Add NetworkingContext to avoid layer violations
4614 https://bugs.webkit.org/show_bug.cgi?id=42292
4616 Add Win's specific implementation of NetworkingContext.
4618 * WebCoreSupport/WebFrameNetworkingContext.cpp:
4619 (WebFrameNetworkingContext::create):
4620 (WebFrameNetworkingContext::userAgent):
4621 (WebFrameNetworkingContext::referrer):
4623 (WebFrame::createNetworkingContext):
4626 2010-09-03 Adam Roben <aroben@apple.com>
4628 Attempt to fixing Windows nightlies again
4630 The fix in r66438 should be sufficient, but we have to touch
4631 WebKit.idl to force that change to be picked up by the build.
4633 * Interfaces/WebKit.idl: Touched this file to force a build.
4635 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
4637 Reviewed by PavelFeldman.
4639 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
4640 https://bugs.webkit.org/show_bug.cgi?id=44230
4642 * WebCoreSupport/WebInspectorClient.cpp:
4643 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4644 (WebInspectorFrontendClient::closeWindow):
4645 (WebInspectorFrontendClient::disconnectFromBackend):
4646 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4647 (WebInspectorFrontendClient::destroyInspectorView):
4648 * WebCoreSupport/WebInspectorClient.h:
4650 2010-09-01 Jessie Berlin <jberlin@apple.com>
4652 Reviewed by Adam Roben.
4654 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
4655 https://bugs.webkit.org/show_bug.cgi?id=45047
4658 (WebView::WebViewWndProc):
4660 2010-08-31 Dave Hyatt <hyatt@apple.com>
4662 Reviewed by Sam Weinig.
4664 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
4665 the former can occur in more places without having to do the latter.
4668 (WebFrame::paintDocumentRectToContext):
4670 (WebView::updateBackingStore):
4672 2010-08-30 Adam Roben <aroben@apple.com>
4674 Fix crash on launch on Windows due to changing IWebFramePrivate's
4677 This regressed in r65107.
4679 Fixes <http://webkit.org/b/44755>.
4681 Rubber-stamped by Jon Honeycutt.
4683 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
4684 resumeAnimations to the end of the interface so that the vtable will
4685 match what Safari expects.
4687 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
4689 Unreviewed, rolling out r66198.
4690 http://trac.webkit.org/changeset/66198
4691 https://bugs.webkit.org/show_bug.cgi?id=44856
4693 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
4695 * WebCoreSupport/WebInspectorClient.cpp:
4696 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4697 (WebInspectorFrontendClient::closeWindow):
4698 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4699 (WebInspectorFrontendClient::destroyInspectorView):
4700 * WebCoreSupport/WebInspectorClient.h:
4702 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
4704 Reviewed by Pavel Feldman.
4706 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
4707 https://bugs.webkit.org/show_bug.cgi?id=44230
4709 * WebCoreSupport/WebInspectorClient.cpp:
4710 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4711 (WebInspectorFrontendClient::closeWindow):
4712 (WebInspectorFrontendClient::disconnectFromBackend):
4713 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4714 (WebInspectorFrontendClient::destroyInspectorView):
4715 * WebCoreSupport/WebInspectorClient.h:
4717 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
4719 Unreviewed. Revert r66103 since Qt tests are failing.
4721 * WebCoreSupport/WebInspectorClient.cpp:
4722 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4723 (WebInspectorFrontendClient::closeWindow):
4724 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4725 (WebInspectorFrontendClient::destroyInspectorView):
4726 * WebCoreSupport/WebInspectorClient.h:
4728 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
4730 Reviewed by Pavel Feldman.
4732 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
4733 https://bugs.webkit.org/show_bug.cgi?id=44230
4735 * WebCoreSupport/WebInspectorClient.cpp:
4736 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4737 (WebInspectorFrontendClient::closeWindow):
4738 (WebInspectorFrontendClient::disconnectFromBackend):
4739 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4740 (WebInspectorFrontendClient::destroyInspectorView):
4741 * WebCoreSupport/WebInspectorClient.h:
4743 2010-08-24 Ada Chan <adachan@apple.com>
4745 Reviewed by Steve Falkenburg.
4747 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
4748 https://bugs.webkit.org/show_bug.cgi?id=44564
4751 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
4752 if plugins are disabled.
4754 2010-08-22 Daniel Bates <dbates@rim.com>
4756 Reviewed by Eric Seidel.
4758 Encapsulate document marker management into DocumentMarkerController
4759 https://bugs.webkit.org/show_bug.cgi?id=44383
4761 Modify call sites in the Apple Windows port to use DocumentMarkerController.
4763 No functionality was changed, so no new tests.
4766 (WebFrame::unmarkAllMisspellings):
4767 (WebFrame::unmarkAllBadGrammar):
4769 (WebView::rectsForTextMatches):
4771 2010-08-18 Jessie Berlin <jberlin@apple.com>
4773 Reviewed by Adam Roben.
4775 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
4776 https://bugs.webkit.org/show_bug.cgi?id=44180
4778 Decide to end painting if the m_backingStoreBitmap is null after the call to
4779 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
4780 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
4781 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
4787 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
4789 Reviewed by Darin Adler.
4791 Add NetworkingContext to avoid layer violations
4792 https://bugs.webkit.org/show_bug.cgi?id=42292
4794 Preparation: Just add the files to the build system.
4796 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
4797 Empty placeholder for now.
4798 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
4799 Placeholder with tentative code that might be changed when landing
4801 * WebKit.vcproj/WebKit.vcproj: Added new files.
4803 2010-08-17 Brady Eidson <beidson@apple.com>
4805 Reviewed by Sam Weinig.
4807 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
4808 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
4811 (WebView::canGoBack): Return false if loads are deferred.
4812 (WebView::canGoForward): Ditto.
4814 2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
4816 Unreviewed; build fix attempt for Windows.
4818 * DefaultDownloadDelegate.cpp:
4820 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
4823 https://bugs.webkit.org/show_bug.cgi?id=43794
4826 (WebView::initWithFrame):
4828 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
4830 Build fix. Matches solutions in qt and mac ports for
4831 https://bugs.webkit.org/show_bug.cgi?id=43794
4834 (WebView::initWithFrame):
4836 2010-08-10 Gavin Barraclough <barraclough@apple.com>
4838 Build fix (update more includes)
4841 * WebLocalizableStrings.cpp:
4842 * WebNotificationCenter.cpp:
4843 * WebPreferences.cpp:
4845 2010-08-10 Chris Marrin <cmarrin@apple.com>
4847 Reviewed by Oliver Hunt.
4849 Add suspendAnimations/resumeAnimation API to DRT
4850 https://bugs.webkit.org/show_bug.cgi?id=43733
4854 * Interfaces/IWebFramePrivate.idl:
4856 (WebFrame::suspendAnimations):
4857 (WebFrame::resumeAnimations):
4860 2010-08-06 Gavin Barraclough <barraclough@apple.com>
4862 Rubber stamped by Sam Weinig
4864 Bug 43594 - Add string forwards to Forward.h
4865 This allows us to remove forward declarations for these classes from
4866 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
4868 * COMVariantSetter.h:
4869 * MarshallingHelpers.h:
4870 * WebCoreSupport/WebContextMenuClient.h:
4871 * WebCoreSupport/WebPluginHalterClient.h:
4874 2010-08-06 Jessie Berlin <jberlin@apple.com>
4876 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
4879 * COMVariantSetter.h:
4880 * MarshallingHelpers.h:
4881 * WebCoreSupport/WebContextMenuClient.h:
4882 * WebCoreSupport/WebPluginHalterClient.h:
4885 2010-08-05 Jessie Berlin <jberlin@apple.com>
4887 Reviewed by Jon Honeycutt.
4889 Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
4890 https://bugs.webkit.org/show_bug.cgi?id=43593
4893 (WebView::backingStore):
4894 If m_backingStoreBitmap is NULL, return E_FAIL.
4896 2010-08-05 Gavin Barraclough <barraclough@apple.com>
4898 Rubber stamped by Sam Weinig
4900 Bug 43594 - Add string forwards to Forward.h
4901 This allows us to remove forward declarations for these classes from
4902 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
4904 * COMVariantSetter.h:
4905 * MarshallingHelpers.h:
4906 * WebCoreSupport/WebContextMenuClient.h:
4907 * WebCoreSupport/WebPluginHalterClient.h:
4910 2010-08-03 Adam Roben <aroben@apple.com>
4912 Turn on PLATFORM_STRATEGIES on Windows
4914 Fixes <http://webkit.org/b/43431>.
4916 Reviewed by Anders Carlsson.
4918 * WebCoreLocalizedStrings.cpp: Removed.
4919 * WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
4921 (WebPlatformStrategies::initialize): Creates the singleton instance.
4922 (WebPlatformStrategies::WebPlatformStrategies): Registers the
4923 singleton instance as the PlatformStrategies instance for WebCore.
4925 (WebPlatformStrategies::createPluginStrategy):
4926 (WebPlatformStrategies::createLocalizationStrategy):
4927 (WebPlatformStrategies::createVisitedLinkStrategy):
4928 Return ourselves as the strategy.
4930 (WebPlatformStrategies::refreshPlugins):
4931 (WebPlatformStrategies::getPluginInfo):
4932 Moved code here from WebCore's PluginDataWin.cpp file.
4934 (WebPlatformStrategies::searchableIndexIntroduction):
4935 (WebPlatformStrategies::submitButtonDefaultLabel):
4936 (WebPlatformStrategies::inputElementAltText):
4937 (WebPlatformStrategies::resetButtonDefaultLabel):
4938 (WebPlatformStrategies::fileButtonChooseFileLabel):
4939 (WebPlatformStrategies::fileButtonNoFileSelectedLabel):
4940 (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
4941 (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
4942 (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
4943 (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
4944 (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
4945 (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
4946 (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
4947 (WebPlatformStrategies::contextMenuItemTagCopy):
4948 (WebPlatformStrategies::contextMenuItemTagGoBack):
4949 (WebPlatformStrategies::contextMenuItemTagGoForward):
4950 (WebPlatformStrategies::contextMenuItemTagStop):
4951 (WebPlatformStrategies::contextMenuItemTagReload):
4952 (WebPlatformStrategies::contextMenuItemTagCut):
4953 (WebPlatformStrategies::contextMenuItemTagPaste):
4954 (WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
4955 (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
4956 (WebPlatformStrategies::contextMenuItemTagLearnSpelling):
4957 (WebPlatformStrategies::contextMenuItemTagSearchWeb):
4958 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
4959 (WebPlatformStrategies::contextMenuItemTagOpenLink):
4960 (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
4961 (WebPlatformStrategies::contextMenuItemTagSpellingMenu):
4962 (WebPlatformStrategies::contextMenuItemTagCheckSpelling):
4963 (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
4964 (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
4965 (WebPlatformStrategies::contextMenuItemTagFontMenu):
4966 (WebPlatformStrategies::contextMenuItemTagBold):
4967 (WebPlatformStrategies::contextMenuItemTagItalic):
4968 (WebPlatformStrategies::contextMenuItemTagUnderline):
4969 (WebPlatformStrategies::contextMenuItemTagOutline):
4970 (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
4971 (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
4972 (WebPlatformStrategies::contextMenuItemTagDefaultDirection):
4973 (WebPlatformStrategies::contextMenuItemTagLeftToRight):
4974 (WebPlatformStrategies::contextMenuItemTagRightToLeft):
4975 (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
4976 (WebPlatformStrategies::contextMenuItemTagInspectElement):
4977 (WebPlatformStrategies::searchMenuNoRecentSearchesText):
4978 (WebPlatformStrategies::searchMenuRecentSearchesText):
4979 (WebPlatformStrategies::searchMenuClearRecentSearchesText):
4980 (WebPlatformStrategies::AXWebAreaText):
4981 (WebPlatformStrategies::AXLinkText):
4982 (WebPlatformStrategies::AXListMarkerText):
4983 (WebPlatformStrategies::AXImageMapText):
4984 (WebPlatformStrategies::AXHeadingText):
4985 (WebPlatformStrategies::AXDefinitionListTermText):
4986 (WebPlatformStrategies::AXDefinitionListDefinitionText):
4987 (WebPlatformStrategies::AXButtonActionVerb):
4988 (WebPlatformStrategies::AXRadioButtonActionVerb):
4989 (WebPlatformStrategies::AXTextFieldActionVerb):
4990 (WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
4991 (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
4992 (WebPlatformStrategies::AXLinkActionVerb):
4993 (WebPlatformStrategies::AXMenuListActionVerb):
4994 (WebPlatformStrategies::AXMenuListPopupActionVerb):
4995 (WebPlatformStrategies::unknownFileSizeText):
4996 (WebPlatformStrategies::uploadFileText):
4997 (WebPlatformStrategies::allFilesText):
4998 (WebPlatformStrategies::missingPluginText):
4999 (WebPlatformStrategies::crashedPluginText):
5000 (WebPlatformStrategies::imageTitle):
5001 (WebPlatformStrategies::multipleFileUploadText):
5002 (WebPlatformStrategies::mediaElementLoadingStateText):
5003 (WebPlatformStrategies::mediaElementLiveBroadcastStateText):
5004 (WebPlatformStrategies::localizedMediaControlElementString):
5005 (WebPlatformStrategies::localizedMediaControlElementHelpText):
5006 (WebPlatformStrategies::localizedMediaTimeDescription):
5007 (WebPlatformStrategies::validationMessageValueMissingText):
5008 (WebPlatformStrategies::validationMessageTypeMismatchText):
5009 (WebPlatformStrategies::validationMessagePatternMismatchText):
5010 (WebPlatformStrategies::validationMessageTooLongText):
5011 (WebPlatformStrategies::validationMessageRangeUnderflowText):
5012 (WebPlatformStrategies::validationMessageRangeOverflowText):
5013 (WebPlatformStrategies::validationMessageStepMismatchText):
5014 Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
5017 (WebPlatformStrategies::isLinkVisited):
5018 (WebPlatformStrategies::addVisitedLink):
5019 Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
5021 * WebCoreSupport/WebPlatformStrategies.h: Added.
5023 * WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
5024 WebPlatformStrategies.
5027 (WebView::initWithFrame): Initialize WebPlatformStrategies.
5029 2010-08-03 Alexey Proskuryakov <ap@apple.com>
5031 Reviewed by Sam Weinig.
5033 https://bugs.webkit.org/show_bug.cgi?id=42939
5034 WebEditorClient::didBeginEditing is never called in WebKit2
5036 * WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will
5037 now set it to main frame, and besides, this call should have been before setFocused(), not
5038 after it. My understanding is that we weren't getting all the same editing delegates on Windows,
5039 so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it.
5041 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5043 Reviewed by Darin Fisher.
5045 PopupMenu refactoring in preparation to WebKit2
5046 https://bugs.webkit.org/show_bug.cgi?id=42592
5048 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5049 instances, concrete classes that inherit from ChromeClient needed to be changed to
5050 implement the new methods.
5052 * WebCoreSupport/WebChromeClient.cpp:
5053 (WebChromeClient::selectItemWritingDirectionIsNatural):
5054 (WebChromeClient::createPopupMenu):
5055 (WebChromeClient::createSearchPopupMenu):
5056 * WebCoreSupport/WebChromeClient.h:
5058 2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
5060 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
5062 Reviewed by Sam Weinig.
5064 * WebKit.vcproj/WebKit.sln:
5066 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
5068 Speculative revert of 64425 due to Chromium instability
5069 https://bugs.webkit.org/show_bug.cgi?id=43347
5071 * WebCoreSupport/WebChromeClient.cpp:
5072 * WebCoreSupport/WebChromeClient.h:
5074 (WebView::mouseWheel):
5076 2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
5081 (WebView::mouseWheel):
5083 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5085 Reviewed by Darin Fisher.
5087 PopupMenu refactoring in preparation to WebKit2
5088 https://bugs.webkit.org/show_bug.cgi?id=42592
5090 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5091 instances, concrete classes that inherit from ChromeClient needed to be changed to
5092 implement the new methods.
5094 * WebCoreSupport/WebChromeClient.cpp:
5095 (WebChromeClient::selectItemWritingDirectionIsNatural):
5096 (WebChromeClient::createPopupMenu):
5097 (WebChromeClient::createSearchPopupMenu):
5098 * WebCoreSupport/WebChromeClient.h:
5100 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
5102 Unreviewed, rolling out r64422.
5103 http://trac.webkit.org/changeset/64422
5104 https://bugs.webkit.org/show_bug.cgi?id=43304
5106 Build fixes are needed for Snow Leopard and Windows.
5107 (Requested by lca on #webkit).
5109 * WebCoreSupport/WebChromeClient.cpp:
5110 * WebCoreSupport/WebChromeClient.h:
5112 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5114 Reviewed by Darin Fisher.
5116 PopupMenu refactoring in preparation to WebKit2
5117 https://bugs.webkit.org/show_bug.cgi?id=42592
5119 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5120 instances, concrete classes that inherit from ChromeClient needed to be changed to
5121 implement the new methods.
5123 * WebCoreSupport/WebChromeClient.cpp:
5124 (WebChromeClient::selectItemWritingDirectionIsNatural):
5125 (WebChromeClient::createPopupMenu):
5126 (WebChromeClient::createSearchPopupMenu):
5127 * WebCoreSupport/WebChromeClient.h:
5129 2010-07-31 Daniel Bates <dbates@rim.com>
5131 Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
5134 (WebFrame::setPrinting):
5136 2010-07-30 Dan Bernstein <mitz@apple.com>
5138 Reviewed by Darin Adler.
5140 <rdar://problem/8257783> Short documents may print a second blank page
5141 https://bugs.webkit.org/show_bug.cgi?id=43271
5144 (WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
5145 page height, which maintains existing behavior.
5147 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
5149 Reviewed by David Kilzer.
5151 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
5152 https://bugs.webkit.org/show_bug.cgi?id=40627
5154 * WebCoreSupport/WebChromeClient.cpp:
5155 (WebChromeClient::reachedApplicationCacheOriginQuota):
5156 * WebCoreSupport/WebChromeClient.h:
5158 2010-07-26 Steve Block <steveblock@google.com>
5160 Reviewed by Jeremy Orlow.
5162 Page clients should be passed to Page constructor via structure of pointers
5163 https://bugs.webkit.org/show_bug.cgi?id=42834
5166 (WebView::initWithFrame):
5168 2010-07-27 Steve Block <steveblock@google.com>
5170 Reviewed by Alexey Proskuryakov.
5172 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
5173 https://bugs.webkit.org/show_bug.cgi?id=40374
5175 Stub out setEnableHighAccuracy method for the Win port.
5177 * WebCoreSupport/WebGeolocationControllerClient.h:
5178 (WebGeolocationControllerClient::setEnableHighAccuracy):
5180 2010-07-22 Sam Weinig <sam@webkit.org>
5182 Reviewed by Maciej Stachowiak.
5184 Fix for <rdar://problem/8222626>
5185 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
5187 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
5188 should migrate to a new function name eventually
5190 * WebCoreSupport/WebEditorClient.cpp:
5191 (WebEditorClient::textDidChangeInTextField):
5193 2010-07-21 Brady Eidson <beidson@apple.com>
5195 Reviewed by Geoffrey Garen.
5197 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
5198 https://bugs.webkit.org/show_bug.cgi?id=42783
5201 (WebView::registerURLSchemeAsLocal):
5202 (WebView::registerURLSchemeAsSecure):
5204 2010-07-20 Steve Falkenburg <sfalken@apple.com>
5206 Reviewed by Adam Roben.
5208 WebKit on Windows should build optionally with an unversioned ICU DLL
5209 https://bugs.webkit.org/show_bug.cgi?id=42722
5210 <rdar://problem/8211767> WebKit needs to link against unversioned ICU
5212 To get the proper value for U_DISABLE_RENAMING into all source files, we force
5213 the include of ICUVersion.h (our generated header) via the compiler options.
5215 * WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
5217 2010-07-21 Adam Roben <aroben@apple.com>
5219 Update WebKit.sln for InjectedBundle's Debug_Internal configuration
5221 Fixes <http://webkit.org/b/42749> InjectedBundle's build
5222 configurations are screwy
5224 Reviewed by Darin Adler.
5226 * WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
5227 InjectedBundle when we're using the Debug_Internal solution
5230 2010-07-21 Adam Roben <aroben@apple.com>
5232 Add MiniBrowser to WebKit.sln
5234 It is the last project to build.
5236 Fixes <http://webkit.org/b/42747> build-webkit should build
5239 Reviewed by Darin Adler.
5241 * WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
5244 2010-07-20 Adam Roben <aroben@apple.com>
5246 Add WebKitTestRunner and friends to WebKit.sln
5248 We added these projects to WebKit2.sln in r63585, but removed them
5249 again in r63600 because WebKitTestRunner required getopt, which
5250 doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
5251 use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
5252 (which has replaced WebKit2.sln).
5254 Fixes <http://webkit.org/b/42711> WebKit.sln should build
5257 Reviewed by Steve Falkenburg.
5259 * WebKit.vcproj/WebKit.sln: Added the following projects to the end of
5260 the build order (in first-built to last-built order):
5261 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
5262 removed an unnecessary dependency from testapi on WebKit2WebProcess.
5264 2010-07-19 Daniel Bates <dbates@rim.com>
5266 Reviewed by Adam Roben.
5268 [Win] Implement LayoutTestController::markerTextForListItem()
5269 https://bugs.webkit.org/show_bug.cgi?id=37930
5271 Implements support for markerTextForListItem in the Windows port.
5273 * DOMCoreClasses.cpp:
5274 (DOMElement::markerTextForListItem): Added.
5276 * Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
5277 * Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
5278 * Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
5280 (WebView::elementFromJS): Added.
5283 2010-07-16 Zhe Su <suzhe@chromium.org>
5285 Reviewed by Darin Adler.
5287 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
5288 https://bugs.webkit.org/show_bug.cgi?id=42253
5290 Dummy implementation of EditorClient::willSetInputMethodState.
5292 * WebCoreSupport/WebEditorClient.cpp:
5293 (WebEditorClient::willSetInputMethodState):
5294 * WebCoreSupport/WebEditorClient.h:
5296 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
5298 Reviewed by Pavel Feldman.
5300 Make JS memory stats available via 'Performance' object (Web Timing).
5301 This statistics is populated only if 'WebKitMemoryInfoEnabled'
5304 'console.memory' is kept until Web Timing object becomes visible by
5305 default (currently it is hidden under compile-time flag). These stats
5306 are guarded with the same preference.
5308 https://bugs.webkit.org/show_bug.cgi?id=41617
5310 * Interfaces/IWebPreferencesPrivate.idl:
5311 * WebPreferenceKeysPrivate.h:
5312 * WebPreferences.cpp:
5313 (WebPreferences::initializeDefaultSettings):
5314 (WebPreferences::memoryInfoEnabled):
5315 (WebPreferences::setMemoryInfoEnabled):
5318 (WebView::notifyPreferencesChanged):
5320 2010-07-14 Brent Fulgham <bfulgham@webkit.org>
5322 Reviewed by Steve Falkenburg.
5324 Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
5325 Correct WinCairo build for new WebKit2 project structure.
5327 * WebKit.vcproj/WebKit.sln:
5329 2010-07-14 Sam Weinig <sam@webkit.org>
5331 Reviewed by Darin Adler.
5333 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
5334 Make changing Cursors work in WebKit2.
5336 * WebCoreSupport/WebChromeClient.cpp:
5337 (WebChromeClient::setCursor):
5338 We now need to grab the native cursor out of the WebCore cursor.
5340 (WebChromeClient::setLastSetCursorToCurrentCursor):
5341 Sets the WebView's "last set cursor" to be the current cursor so that
5342 the cursor is set correctly for plugins.
5343 * WebCoreSupport/WebChromeClient.h:
5346 (WebView::WebViewWndProc):
5348 (WebView::setLastCursor):
5349 Change the "last set cursor" to be stored as a member instead of a global.
5351 2010-07-13 Steve Falkenburg <sfalken@apple.com>
5354 Make WebKit.sln build WebKit.dll as it used to in the past.
5355 (sln is updated to include necessary projects)
5357 * WebKit.vcproj/WebKit.sln:
5359 2010-07-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5363 * Interfaces/WebKit.idl: Touched to force a build
5365 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5367 Reviewed by Darin Adler.
5369 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
5371 https://bugs.webkit.org/show_bug.cgi?id=30879
5373 MainResourceLoader uses the member m_initialRequest to store requests for future
5374 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
5375 have to clear this request so that subsequent entries into the loader will not
5376 start yet another load.
5378 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
5379 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
5380 but only in the case of using both substitute-data and non-deferred main resource
5381 load together. That's why two new DRT functions were added:
5383 * queueLoadHTMLString()
5384 * setDeferMainResourceLoad()
5386 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
5387 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
5388 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
5390 * Interfaces/IWebDataSource.idl:
5391 * WebDataSource.cpp:
5392 (WebDataSource::setDeferMainResourceDataLoad):
5395 2010-07-12 Steve Falkenburg <sfalken@apple.com>
5397 Reviewed by Alice Liu.
5399 <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
5400 https://bugs.webkit.org/show_bug.cgi?id=40921
5402 Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
5403 WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
5405 This is a first step. We'll likely want to migrate the remainder of
5406 the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
5408 * WebKit.vcproj/WebKit.def: Removed.
5409 * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
5410 * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
5411 Renamed project name to WebKitLib to avoid confusion and naming conflicts.
5412 Generate intermediate pdb file for debuggability of static lib.
5413 Removed DLL-related options.
5414 * WebKit.vcproj/deleteButton.png: Removed.
5415 * WebKit.vcproj/deleteButtonPressed.png: Removed.
5416 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
5417 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
5418 * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
5419 * WebKit.vcproj/fsVideoPause.png: Removed.
5420 * WebKit.vcproj/fsVideoPlay.png: Removed.
5421 * WebKit.vcproj/missingImage.png: Removed.
5422 * WebKit.vcproj/nullplugin.png: Removed.
5423 * WebKit.vcproj/panEastCursor.png: Removed.
5424 * WebKit.vcproj/panIcon.png: Removed.
5425 * WebKit.vcproj/panNorthCursor.png: Removed.
5426 * WebKit.vcproj/panNorthEastCursor.png: Removed.
5427 * WebKit.vcproj/panNorthWestCursor.png: Removed.
5428 * WebKit.vcproj/panSouthCursor.png: Removed.
5429 * WebKit.vcproj/panSouthEastCursor.png: Removed.
5430 * WebKit.vcproj/panSouthWestCursor.png: Removed.
5431 * WebKit.vcproj/panWestCursor.png: Removed.
5432 * WebKit.vcproj/searchCancel.png: Removed.
5433 * WebKit.vcproj/searchCancelPressed.png: Removed.
5434 * WebKit.vcproj/searchMagnifier.png: Removed.
5435 * WebKit.vcproj/searchMagnifierResults.png: Removed.
5436 * WebKit.vcproj/textAreaResizeCorner.png: Removed.
5437 * WebKit.vcproj/verticalTextCursor.png: Removed.
5438 * WebKit.vcproj/zoomInCursor.png: Removed.
5439 * WebKit.vcproj/zoomOutCursor.png: Removed.
5441 2010-07-08 Aaron Boodman <aa@chromium.org>
5443 Reviewed by Timothy Hatcher.
5445 Add the ability for user scripts and user styles to affect just the top frame.
5447 https://bugs.webkit.org/show_bug.cgi?id=41529
5450 (WebView::addUserScriptToGroup):
5451 (WebView::addUserStyleSheetToGroup):
5453 2010-07-08 Adele Peterson <adele@apple.com>
5455 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
5457 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
5458 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
5460 Implement shouldMissingPluginMessageBeButton.
5462 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton):
5463 * WebCoreSupport/WebChromeClient.h:
5465 2010-07-07 Anders Carlsson <andersca@apple.com>
5467 Reviewed by Simon Fraser.
5469 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
5470 https://bugs.webkit.org/show_bug.cgi?id=41781
5472 * WebKit.vcproj/WebKit.sln:
5474 2010-07-07 Sam Weinig <sam@webkit.org>
5476 Reviewed by Anders Carlsson.
5478 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
5479 Add basic piping for BackForwardControllerClient.
5482 (WebView::initWithFrame):
5484 2010-07-07 Adam Roben <aroben@apple.com>
5488 * Interfaces/WebKit.idl: Touched to force a build.
5490 2010-07-06 Steve Falkenburg <sfalken@apple.com>
5492 Reviewed by Simon Fraser.
5494 Expose URL matching from WebUserContentURLPattern
5495 https://bugs.webkit.org/show_bug.cgi?id=41726
5496 <rdar://problem/7910144>
5498 We previously had a way to construct WebUserContentURLPattern
5499 instances via WebKit, but no way for callers to perform matching.
5500 This patch adds the matchesURL functionality to allow for this.
5502 * Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
5503 * Interfaces/IWebView.idl: Touch to force a build.
5504 * WebUserContentURLPattern.cpp:
5505 (WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.
5506 * WebUserContentURLPattern.h: Added matchesURL.
5508 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
5510 The missing plug-in indicator should be clickable
5512 https://bugs.webkit.org/show_bug.cgi?id=41550
5513 <rdar://problem/8132162>
5515 From an original patch by Kevin Decker.
5517 Reviewed by Darin Adler.
5519 * Interfaces/IWebUIDelegatePrivate.idl:
5520 Added a new delegate interface, and declare a function
5521 didPressMissingPluginButton().
5523 * Interfaces/WebKit.idl:
5524 Touch this file to force interfaces to be rebuilt.
5526 * WebCoreSupport/WebChromeClient.cpp:
5527 (WebChromeClient::missingPluginButtonClicked):
5528 Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
5529 didPressMissingPluginButton() function.
5531 * WebCoreSupport/WebChromeClient.h:
5532 Declare an override of missingPluginButtonClicked().
5534 2010-07-03 Erik Arvidsson <arv@chromium.org>
5536 Reviewed by Ojan Vafai.
5538 Fix issue where a contextmenu event was reporting the wrong target
5539 if the context menu was shown due to pressing the context menu key
5543 (WebView::handleContextMenuEvent):
5545 2010-07-01 Steve Falkenburg <sfalken@apple.com>
5547 Reviewed by Adele Peterson.
5549 Provide a WebView preference to disable DNS prefetching on Windows
5550 https://bugs.webkit.org/show_bug.cgi?id=41504
5551 <rdar://problem/8151939>
5553 * Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
5554 * Interfaces/WebKit.idl: Touched to force IDL build.
5555 * WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
5556 * WebPreferences.cpp:
5557 (WebPreferences::initializeDefaultSettings): Default prefetch to true.
5558 (WebPreferences::setDNSPrefetchingEnabled): Added.
5559 (WebPreferences::isDNSPrefetchingEnabled): Added.
5560 * WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
5562 (WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.
5564 2010-06-21 Nate Chapin <japhet@chromium.org>
5566 Unreviewed, Windows build fix.
5568 Update WebFrame to use FrameLoaderStateMachine in
5572 (WebFrame::firstLayoutDone):
5574 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
5576 Reviewed by Adam Barth.
5578 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
5579 https://bugs.webkit.org/show_bug.cgi?id=39041
5582 (WebView::notifyPreferencesChanged):
5584 2010-06-16 Adam Roben <aroben@apple.com>
5586 Add a "forPrinting" boolean parameter to
5587 IWebFramePrivate::renderTreeAsExternalRepresentation
5589 Fixes <http://webkit.org/b/40727> Respect
5590 LayoutTestController::isPrinting on Windows.
5592 Reviewed by Dan Bernstein.
5594 * Interfaces/IWebFramePrivate.idl: Renamed the current
5595 renderTreeAsExternalRepresentation to unused1, and added a new version
5596 that takes a boolean "forPrinting" parameter.
5598 * Interfaces/WebKit.idl: Touched to force a build.
5601 (WebFrame::renderTreeAsExternalRepresentation): Added a boolean
5602 "forPrinting" parameter, and used it to tell externalRepresentation
5603 what kind of behavior to use.
5605 * WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
5608 2010-06-15 Darin Adler <darin@apple.com>
5610 Reviewed by Adam Barth.
5612 Move functions out of Frame class that were marked "move to Chrome"
5613 https://bugs.webkit.org/show_bug.cgi?id=39636
5616 (WebView::shouldClose): Call shouldClose on FrameLoader instead of
5617 going through Frame.
5619 2010-06-14 Adam Roben <aroben@apple.com>
5621 Add WebKitLauncherWin to WebKit.sln
5623 Fixes <http://webkit.org/b/40583>.
5625 Reviewed by Darin Adler.
5627 * WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends
5628 on WebKitAPITest, so is the last project to build. (Also removed
5629 QTMovieWin's direct dependency on JavaScriptCore, since it already has
5630 an indirect dependency on it.)
5632 2010-06-14 Chang Shu <chang.shu@nokia.com>
5634 Reviewed by Kenneth Rohde Christiansen.
5636 [win] Make windows compile after API changes.
5638 https://bugs.webkit.org/show_bug.cgi?id=40434
5640 * WebKitGraphics.cpp:
5643 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
5645 Reviewed by Pavel Feldman.
5647 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
5648 data from inspected page to WebInspector as JSON string via http. The native
5649 serialization to JSON string is supported by InspectorValue's classes. This patch
5650 has the implementation of sendMessageToFrontend function. WebKit version of it still
5651 uses ScriptFunctionCall and will be switched to another transport a little bit later.
5652 https://bugs.webkit.org/show_bug.cgi?id=40134
5654 * WebCoreSupport/WebInspectorClient.cpp:
5655 (WebInspectorClient::WebInspectorClient):
5656 (WebInspectorClient::~WebInspectorClient):
5657 (WebInspectorClient::openInspectorFrontend):
5658 * WebCoreSupport/WebInspectorClient.h:
5660 2010-06-10 Eric Seidel <eric@webkit.org>
5662 Reviewed by Adam Barth.
5664 Reduce FrameView.h includes to speed up build times
5665 https://bugs.webkit.org/show_bug.cgi?id=40408
5667 Another fix for Windows.
5671 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
5673 Unreviewed, rolling out r60889.
5674 http://trac.webkit.org/changeset/60889
5675 https://bugs.webkit.org/show_bug.cgi?id=40365
5677 gtk bot has some kind of memory corruption (Requested by
5680 * WebCoreSupport/WebInspectorClient.cpp:
5681 (WebInspectorClient::WebInspectorClient):
5682 (WebInspectorClient::~WebInspectorClient):
5683 (WebInspectorClient::openInspectorFrontend):
5684 * WebCoreSupport/WebInspectorClient.h:
5685 (WebInspectorClient::frontendClosing):
5687 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
5689 Reviewed by Pavel Feldman.
5691 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
5692 data from inspected page to WebInspector as JSON string via http. The native
5693 serialization to JSON string is supported by InspectorValue's classes. This patch
5694 has the implementation of sendMessageToFrontend function. WebKit version of it still
5695 uses ScriptFunctionCall and will be switched to another transport a little bit later.
5696 https://bugs.webkit.org/show_bug.cgi?id=40134
5698 * WebCoreSupport/WebInspectorClient.cpp:
5699 (WebInspectorClient::WebInspectorClient):
5700 (WebInspectorClient::~WebInspectorClient):
5701 (WebInspectorClient::openInspectorFrontend):
5702 * WebCoreSupport/WebInspectorClient.h:
5704 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
5706 Reviewed by Ojan Vafai and Darin Adler.
5708 Refactor platform dependent editing behavior code out of Settings
5709 https://bugs.webkit.org/show_bug.cgi?id=39854
5711 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
5712 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
5715 (WebView::notifyPreferencesChanged):
5717 2010-06-04 Alice Liu <alice.liu@apple.com>
5719 Reviewed by Jon Honeycutt.
5721 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
5722 https://bugs.webkit.org/show_bug.cgi?id=40034
5723 <rdar://problem/7799848>
5726 (WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
5727 Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
5729 Just renaming changes:
5730 * Interfaces/IWebFramePrivate.idl:
5731 * Interfaces/IWebViewPrivate.idl:
5734 (WebView::paintScrollViewRectToContextAtPoint):
5737 * Interfaces/WebKit.idl: Touched for rebuild.
5739 2010-05-30 Daniel Bates <dbates@rim.com>
5741 Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
5744 (WebFrame::elementWithName):
5745 (WebFrame::controlsInForm):
5747 2010-05-22 Jer Noble <jer.noble@apple.com>
5749 Reviewed by Adam Roben.
5751 Full screen doesn't work for video elements
5752 https://bugs.webkit.org/show_bug.cgi?id=39557
5753 rdar://problem/8011813
5755 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController
5756 is now MediaPlayerPrivate agnostic..
5758 * FullscreenVideoController.cpp:
5759 (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient.
5760 (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer):
5761 (FullscreenVideoController::FullscreenVideoController):
5762 (FullscreenVideoController::~FullscreenVideoController):
5763 (FullscreenVideoController::enterFullscreen):
5764 (FullscreenVideoController::exitFullscreen):
5765 (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN.
5766 (FullscreenVideoController::createHUDWindow):
5767 (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN.
5768 (FullscreenVideoController::onChar):
5769 (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR.
5770 * FullscreenVideoController.h:
5772 (WebView::viewWindow): Added a simple viewWindow() accessor.
5774 2010-05-25 Brady Eidson <beidson@apple.com>
5776 Reviewed by Darin Adler.
5778 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
5779 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
5781 * WebDatabaseManager.cpp:
5782 (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
5783 an already created tracker that already has its origins populated.
5784 * WebDatabaseManager.h:
5787 (WebView::initWithFrame): Call a renamed method instead.
5789 2010-05-25 Ada Chan <adachan@apple.com>
5791 Reviewed by Steve Falkenburg.
5793 https://bugs.webkit.org/show_bug.cgi?id=39651
5795 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended
5796 when page loading is deferred.
5799 (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer.
5800 (WindowCloseTimer::create):
5801 (WindowCloseTimer::WindowCloseTimer):
5802 (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end.
5803 (WindowCloseTimer::fired):
5804 (WebView::closeWindowSoon):
5805 (WebView::closeWindowTimerFired):
5806 (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since
5807 we only create it when we need to start the timer.
5810 2010-05-24 Darin Adler <darin@apple.com>
5812 Reviewed by Eric Seidel.
5814 Move view-related functions from Frame to FrameView
5815 https://bugs.webkit.org/show_bug.cgi?id=39366
5818 (WebFrame::setTextSizeMultiplier): Call function on FrameView.
5820 (WebView::setZoomMultiplier): Ditto.
5822 2010-05-24 Anders Carlsson <andersca@apple.com>
5824 Yet another Windows build fix.
5827 (WebView::canShowMIMEType):
5828 Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines).
5830 2010-05-24 Anders Carlsson <andersca@apple.com>
5832 Another Windows build fix.
5835 Don't include PlugInInfoStore.h, instead include PluginData.h
5837 2010-05-24 Anders Carlsson <andersca@apple.com>
5842 (WebView::canShowMIMEType):
5844 2010-05-21 Steve Block <steveblock@google.com>
5846 Reviewed by Jeremy Orlow.
5848 Add DeviceOrientation and DeviceOrientationClient
5849 https://bugs.webkit.org/show_bug.cgi?id=39479
5852 (WebView::initWithFrame):
5854 2010-05-20 Simon Fraser <simon.fraser@apple.com>
5856 Build fix, no review.
5858 Fix the non-accelerated-compositing Windows build with some
5859 #if USE(ACCELERATED_COMPOSITING) loving.
5864 2010-05-20 Simon Fraser <simon.fraser@apple.com>
5866 Reviewed by Adam Roben.
5868 Avoid flushing CA layers when a layout is pending
5869 https://bugs.webkit.org/show_bug.cgi?id=39463
5871 <rdar://problem/7999463>
5873 Avoid rendering the compositing layers to the screen if there's a layout pending,
5874 since the layer tree not in a state that should be presented to the user.
5876 This fixes flashes in some types of content that dynamically add and remove layers.
5878 Have the WebView implement WKCACFLayerRendererClient so that the
5879 WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView
5880 has a layout pending, say no.
5884 (WebView::setAcceleratedCompositing):
5885 (WebView::shouldRender):
5887 2010-05-18 Brent Fulgham <bfulgham@webkit.org>
5889 Reviewed by Adam Roben.
5891 [WinCairo] Correct scaling for print preview
5892 https://bugs.webkit.org/show_bug.cgi?id=39329
5894 Cairo does not properly deal with Windows HDCs that have been
5895 scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
5896 ViewportExt setting.
5897 (see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
5899 Instead, reset the HDC's WorldTransform to be unscaled, then
5900 scale the cairo context to the desired scaling, and perform
5901 the drawing operation.
5904 (WebFrame::drawHeader): Use pre-positioned context to simplify
5906 (WebFrame::drawFooter): Use pre-positioned context to simplify
5908 (WebFrame::spoolPage): Revise scaling logic to turn off HDC
5909 scaling, and scale using only Cairo. Revert scaling at end
5910 so that user-defined GDI-based routines (e.g., header/footer)
5911 will draw in the right position.
5912 (WebFrame::spoolPages): Identify print preview case, and
5913 retrieve scaling factors from preview context. Set the
5914 Cairo context to use these factors during the spoolPage
5917 2010-05-20 Martin Robinson <mrobinson@igalia.com>
5921 Touch WebKit.idl to ensure that interfaces rebuild.
5923 * Interfaces/WebKit.idl: Touched.
5925 2010-05-20 Martin Robinson <mrobinson@igalia.com>
5927 Reviewed by Adam Roben.
5929 Fix the Windows build and move new IDL declarations to the bottom of the file.
5931 * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
5932 * WebPreferences.cpp:
5933 (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
5935 2010-05-20 Martin Robinson <mrobinson@igalia.com>
5939 Fix the Windows build.
5942 (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
5944 2010-05-20 Martin Robinson <mrobinson@webkit.org>
5946 Reviewed by Ojan Vafai.
5948 Expose the editing behavior setting in DRT to test all editing code paths
5949 https://bugs.webkit.org/show_bug.cgi?id=38603
5951 Expose the EditingBehavior setting in the Windows API.
5953 * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
5954 * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
5955 * WebPreferences.cpp:
5956 (WebPreferences::editingBehavior): Added.
5957 (WebPreferences::setEditingBehavior): Added.
5958 * WebPreferences.h: Add method declarations.
5960 (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
5962 2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
5964 Reviewed by Eric Seidel.
5966 Modified FrameLoader::urlSelected() to accept a KURL instead of a
5969 https://bugs.webkit.org/show_bug.cgi?id=39320
5971 Since ResourceRequest has non-explicit single-parameter constructors for
5972 String and KURL, urlSelected() previously accepted any of String, KURL,
5973 and ResourceRequest. This revision changes urlSelected() to accept only
5974 a KURL to make the API tighter and easier to refactor.
5976 * WebCoreSupport/WebContextMenuClient.cpp:
5977 (WebContextMenuClient::searchWithGoogle):
5978 - Updated the call to urlSelected().
5980 2010-05-13 Brian Weinstein <bweinstein@apple.com>
5982 Reviewed by Tim Hatcher.
5984 <rdar://problem/7982652>
5986 Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
5988 * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
5989 * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
5991 (WebView::reportException): Make sure the function was called with a context from a WebView, and call
5992 WebCore::reportException.
5995 2010-05-12 Jer Noble <jer.noble@apple.com>
5997 Reviewed by Darin Adler.
5999 Bug 38689: #34005 will break fullscreen video playback
6000 https://bugs.webkit.org/show_bug.cgi?id=38689
6002 Use the new definition of PlatformMedia to check the actual type
6003 returned by MediaPlayer.
6005 * FullscreenVideoController.cpp:
6006 (FullscreenVideoController::movie):
6008 2010-05-11 Jer Noble <jer.noble@apple.com>
6012 Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
6014 * WebKit.vcproj/WebKit.sln:
6016 2010-05-11 Alice Liu <alice.liu@apple.com>
6018 Rubber-stamped by Gavin Barraclough.
6020 Fix build error when enabling debugging block in WebKit win painting code
6023 (WebView::paintIntoBackingStore):
6025 2010-05-11 Alice Liu <alice.liu@apple.com>
6027 Reviewed by Steve Falkenburg.
6029 https://bugs.webkit.org/show_bug.cgi?id=38937
6030 W7 window preview paints content at the wrong location
6033 (WebFrame::paintDocumentRectToContext): Revert r58895
6034 (WebFrame::paintDocumentRectToContextAtPoint): Added
6036 * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
6037 * Interfaces/IWebViewPrivate.idl: ditto
6038 * Interfaces/WebKit.idl: touch to rebuild
6040 * WebView.cpp: ditto
6041 (WebView::paintDocumentRectToContextAtPoint): ditto
6044 2010-05-07 Jer Noble <jer.noble@apple.com>
6046 Reviewed by Adele Peterson.
6048 Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
6049 https://bugs.webkit.org/show_bug.cgi?id=34005
6051 QTMovieWin is now QTMovieGWorld.
6052 * FullscreenVideoController.cpp:
6053 (FullscreenVideoController::movie):
6054 * FullscreenVideoController.h:
6056 2010-05-06 Adam Roben <aroben@apple.com>
6058 Bail out of WebView::paint when there's nothing to paint
6060 Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
6061 (r58067): Crash in WebView::paint when Web Inspector is docked and
6062 window is resized so small that WebView disappears
6064 When the WebView is 0-sized, ensureBackingStore() bails out without
6065 creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
6066 m_backingStoreBitmap was an HBITMAP, so we were happily passing along
6067 a null HBITMAP to various Windows APIs. These calls would fail but not
6068 crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
6069 dereferencing a null RefCountedHBITMAP* of course crashes.
6071 Reviewed by Steve Falkenburg.
6074 (WebView::paint): Bail if the rect to paint is empty.
6076 2010-05-06 Steve Falkenburg <sfalken@apple.com>
6078 Reviewed by Adam Roben.
6080 WebFrame::paintDocumentRectToContext paints content at the wrong location
6081 https://bugs.webkit.org/show_bug.cgi?id=38651
6084 (WebFrame::paintDocumentRectToContext):
6086 2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
6088 Reviewed by Darin Fisher.
6090 Update setFocus for the new boolean argument; no behavioral change.
6092 https://bugs.webkit.org/show_bug.cgi?id=37961
6094 * WebCoreSupport/EmbeddedWidget.cpp:
6095 (EmbeddedWidget::setFocus):
6096 * WebCoreSupport/EmbeddedWidget.h:
6098 2010-05-03 Abhishek Arya <inferno@chromium.org>
6100 Reviewed by Adam Barth.
6102 Add support for controlling clipboard access from javascript.
6103 Clipboard access from javascript is disabled by default.
6104 https://bugs.webkit.org/show_bug.cgi?id=27751
6106 * Interfaces/IWebPreferencesPrivate.idl:
6107 * WebPreferenceKeysPrivate.h:
6108 * WebPreferences.cpp:
6109 (WebPreferences::initializeDefaultSettings):
6110 (WebPreferences::javaScriptCanAccessClipboard):
6111 (WebPreferences::setJavaScriptCanAccessClipboard):
6114 (WebView::notifyPreferencesChanged):
6116 2010-05-03 Jens Alfke <snej@chromium.org>
6118 Reviewed by Darin Fisher.
6120 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
6121 https://bugs.webkit.org/show_bug.cgi?id=38397
6123 No tests (functionality is exposed only through native WebKit API.)
6127 2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
6129 Caret may fail to blink if a focus handler brings up a modal dialog
6130 https://bugs.webkit.org/show_bug.cgi?id=38372
6132 Reviewed by Darin Adler.
6135 (WebView::handleMouseEvent):
6136 If the message is WM_CANCELMODE, which indicates that we our capturing
6137 of mouse events has been cancelled, tell the EventHandler.
6138 It's possible to re-enter this function if handling a mouse event allows
6139 the message loop to run; moved up the call to setMouseActivated(), so
6140 that if we do re-enter this function, the later mouse event will not be
6141 considered as activating the window.
6142 (WebView::WebViewWndProc):
6143 Handle WM_CANCELMODE by calling handleMouseEvent().
6145 2010-04-29 Anders Carlsson <andersca@apple.com>
6147 Reviewed by Dan Bernstein.
6150 https://bugs.webkit.org/show_bug.cgi?id=20784
6151 move npapi.h to C99 integer types.
6153 * WebKit.vcproj/WebKit.vcproj:
6155 2010-04-28 Beth Dakin <bdakin@apple.com>
6157 Reviewed by Darin Adler.
6159 Fix for <rdar://problem/7474349>
6161 Add a synchronous display mechanism for WKCACFLayerRenderer.
6163 * Interfaces/IWebViewPrivate.idl:
6164 * Interfaces/WebKit.idl:
6167 (WebView::updateRootLayerContents):
6168 (WebView::nextDisplayIsSynchronous):
6171 2010-04-28 Steve Falkenburg <sfalken@apple.com>
6173 Reviewed by Maciej Stachowiak.
6175 WebView drawing code may access null backing store dirty region
6176 https://bugs.webkit.org/show_bug.cgi?id=38245
6177 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
6180 (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
6182 2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
6184 <rdar://problem/7911140> Hitting the "delete" key goes back twice
6186 Reviewed by Maciej Stachowiak.
6190 Return true if we navigated back or forward from the key event to
6191 prevent the event from being propagated further.
6193 2010-04-25 Sam Weinig <sam@webkit.org>
6195 Reviewed by Maciej Stachowiak.
6197 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
6198 Disentangle initializing the main thread from initializing threading
6200 * WebKitClassFactory.cpp:
6201 (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
6203 (WebView::WebView): Ditto.
6205 2010-04-25 Yury Semikhatsky <yurys@chromium.org>
6207 Reviewed by Pavel Feldman.
6209 Web Inspector: inspector client shouldn't check if it can be opened
6210 docked if it is already in that state.
6212 https://bugs.webkit.org/show_bug.cgi?id=37946
6214 * WebCoreSupport/WebInspectorClient.cpp:
6215 (WebInspectorFrontendClient::WebInspectorFrontendClient):
6216 (WebInspectorFrontendClient::showWindowWithoutNotifications):
6217 * WebCoreSupport/WebInspectorClient.h:
6219 2010-04-24 Steve Falkenburg <sfalken@apple.com>
6221 Reviewed by Sam Weinig.
6223 Typo in Geolocation code causes crashes when updates are stopped
6224 https://bugs.webkit.org/show_bug.cgi?id=38089
6225 <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation
6227 * WebCoreSupport/WebGeolocationControllerClient.cpp:
6228 (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
6230 2010-04-23 Andy Estes <aestes@apple.com>
6232 Rubber stamped by Steve Falkenburg.
6234 Roll out http://trac.webkit.org/changeset/55385.
6236 <rdar://problem/7884444>
6238 * Interfaces/IWebUIDelegatePrivate.idl:
6239 * Interfaces/WebKit.idl:
6240 * WebCoreSupport/WebFrameLoaderClient.cpp:
6241 (WebFrameLoaderClient::createPlugin):
6243 2010-04-22 Dave Moore <davemoore@chromium.org>
6245 Reviewed by Dimitri Glazkov.
6247 Added notification when the favicons for a page are changed
6249 The Document object will notify the frame loader, which will
6250 notify the client. Implementations of FrameLoaderClient will
6251 have to add one method; dispatchDidChangeIcons().
6253 https://bugs.webkit.org/show_bug.cgi?id=33812
6255 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
6256 * WebCoreSupport/WebFrameLoaderClient.cpp:
6257 (WebFrameLoaderClient::dispatchDidChangeIcons):
6258 * WebCoreSupport/WebFrameLoaderClient.h:
6260 (WebFrame::didChangeIcons):
6263 2010-04-22 Adam Barth <abarth@webkit.org>
6265 Unreviewed, rolling out r58069.
6266 http://trac.webkit.org/changeset/58069
6267 https://bugs.webkit.org/show_bug.cgi?id=27751
6269 Broke compile on Windows.
6271 * Interfaces/IWebPreferencesPrivate.idl:
6272 * WebPreferenceKeysPrivate.h:
6273 * WebPreferences.cpp:
6274 (WebPreferences::initializeDefaultSettings):
6277 (WebView::notifyPreferencesChanged):
6279 2010-04-22 Abhishek Arya <inferno@chromium.org>
6281 Reviewed by Adam Barth.
6283 Add support for controlling clipboard access from javascript.
6284 Clipboard access from javascript is disabled by default.
6285 https://bugs.webkit.org/show_bug.cgi?id=27751
6287 * Interfaces/IWebPreferencesPrivate.idl:
6288 * WebPreferenceKeysPrivate.h:
6289 * WebPreferences.cpp:
6290 (WebPreferences::initializeDefaultSettings):
6291 (WebPreferences::javaScriptCanAccessClipboard):
6292 (WebPreferences::setJavaScriptCanAccessClipboard):
6295 (WebView::notifyPreferencesChanged):
6297 2010-04-21 Andy Estes <aestes@apple.com>
6299 Reviewed by Maciej Stachowiak.
6301 Reference count WebView's backing store bitmap to prevent
6302 deleteBackingStore() from freeing the bitmap while it is still being
6303 referenced by Core Animation.
6305 https://bugs.webkit.org/show_bug.cgi?id=37954
6308 (WebView::ensureBackingStore):
6309 (WebView::addToDirtyRegion):
6310 (WebView::scrollBackingStore):
6311 (WebView::updateBackingStore):
6313 (WebView::backingStore):
6314 (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
6315 Animation has dropeed its reference to the memory.
6316 (WebView::updateRootLayerContents): ref m_backingStoreBitmap before
6317 passing the memory to Core Animation to prevent deleteBackingStore()
6318 from freeing it while it is still referenced by CA.
6319 * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
6320 and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
6322 2010-04-20 Adam Barth <abarth@webkit.org>
6324 Reviewed by Eric Seidel.
6326 Factor DocumentWriter out of FrameLoader
6327 https://bugs.webkit.org/show_bug.cgi?id=37175
6329 Update these callsites because the method moved to DocumentWriter.
6331 * WebCoreSupport/WebFrameLoaderClient.cpp:
6332 (WebFrameLoaderClient::receivedData):
6334 2010-04-20 Kent Tamura <tkent@chromium.org>
6336 Reviewed by Darin Adler.
6338 Change a parameter type of chooseIconForFiles()
6339 https://bugs.webkit.org/show_bug.cgi?id=37504
6341 * WebCoreSupport/WebChromeClient.cpp:
6342 (WebChromeClient::chooseIconForFiles):
6343 * WebCoreSupport/WebChromeClient.h:
6345 2010-04-16 Gavin Barraclough <barraclough@apple.com>
6347 Reviewed by NOBODY (Windows build fix).
6350 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
6352 (WebView::stringByEvaluatingJavaScriptFromString):
6354 2010-04-16 Adam Roben <aroben@apple.com>
6356 Make it possible for clients to instantiate a WebUserContentURLPattern
6358 Reviewed by Tim Hatcher.
6360 * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
6361 lists all our instantiatable classes.
6363 * WebKitClassFactory.cpp: Added a now-required #include.
6365 2010-04-15 Adam Roben <aroben@apple.com>
6367 Expose UserContentURLPattern as WebKit SPI
6369 Fixes <http://webkit.org/b/37354>.
6371 Reviewed by Tim Hatcher.
6373 * Interfaces/IWebUserContentURLPattern.idl: Added.
6375 * Interfaces/WebKit.idl: Added WebUserContentURLPattern.
6377 * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
6379 * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
6381 * WebUserContentURLPattern.cpp: Added.
6382 (WebUserContentURLPattern::WebUserContentURLPattern):
6383 (WebUserContentURLPattern::~WebUserContentURLPattern):
6384 (WebUserContentURLPattern::createInstance):
6385 (WebUserContentURLPattern::AddRef):
6386 (WebUserContentURLPattern::Release):
6387 (WebUserContentURLPattern::QueryInterface):
6388 Standard COM implementations.
6390 (WebUserContentURLPattern::parse): Parse the string into a
6391 UserContentURLPattern and store it.
6393 (WebUserContentURLPattern::isValid):
6394 (WebUserContentURLPattern::scheme):
6395 (WebUserContentURLPattern::host):
6396 (WebUserContentURLPattern::matchesSubdomains):
6397 Call through to UserContentURLPattern.
6399 * WebUserContentURLPattern.h: Added.
6401 2010-04-14 Adam Roben <aroben@apple.com>
6403 Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
6405 Fixes <http://webkit.org/b/37619>.
6407 Reviewed by Steve Falkenburg.
6409 * Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
6411 * Interfaces/WebKit.idl: Touched to force a build.
6413 * WebScriptWorld.cpp:
6414 (WebScriptWorld::unregisterWorld):
6416 Added. Just calls through to DOMWrapperWorld::unregisterWorld.
6418 2010-04-12 Timothy Hatcher <timothy@apple.com>
6420 SecurityOrigin needs a way to remove individual OriginAccessEntries
6421 https://bugs.webkit.org/show_bug.cgi?id=37449
6423 Reviewed by Dave Hyatt.
6425 * Interfaces/IWebViewPrivate.idl:
6427 (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
6428 * WebView.h: Added removeOriginAccessWhitelistEntry.
6430 2010-04-13 Timothy Hatcher <timothy@apple.com>
6432 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
6433 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
6435 SecurityOrigin needs a way to remove individual OriginAccessEntries
6436 https://bugs.webkit.org/show_bug.cgi?id=37449
6438 Reviewed by Dave Hyatt.
6440 * Interfaces/IWebViewPrivate.idl:
6442 (WebView::addOriginAccessWhitelistEntry):
6443 (WebView::resetOriginAccessWhitelists):
6446 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
6448 Unreviewed, rolling out r57468.
6449 http://trac.webkit.org/changeset/57468
6450 https://bugs.webkit.org/show_bug.cgi?id=37433
6452 Broke the world... Must have applied the patch wrong
6453 (Requested by abarth on #webkit).
6455 * WebCoreSupport/WebFrameLoaderClient.cpp:
6456 (WebFrameLoaderClient::receivedData):
6458 2010-04-11 Adam Barth <abarth@webkit.org>
6460 Reviewed by Eric Seidel.
6462 Factor DocumentWriter out of FrameLoader
6463 https://bugs.webkit.org/show_bug.cgi?id=37175
6465 Update these callsites because the method moved to DocumentWriter.
6467 * WebCoreSupport/WebFrameLoaderClient.cpp:
6468 (WebFrameLoaderClient::receivedData):
6470 2010-04-09 Adam Roben <aroben@apple.com>
6472 Windows Debug/Release build fix after r57244
6474 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
6475 QuartzCoreInterface.dll in any configurations. r57244 made this change
6476 only for Debug_Internal.
6478 2010-04-08 Steve Falkenburg <sfalken@apple.com>
6480 Reviewed by Darin Adler.
6482 WebView::isLoading should null check m_mainFrame
6483 https://bugs.webkit.org/show_bug.cgi?id=37294
6486 (WebView::isLoading):
6488 2010-04-07 Chris Marrin <cmarrin@apple.com>
6490 Reviewed by Steve Falkenburg.
6492 Remove QuartzCoreInterface from the build
6494 No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
6496 * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface
6498 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
6500 Reviewed by Yury Semikhatsky.
6502 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
6503 https://bugs.webkit.org/show_bug.cgi?id=36949
6505 * WebCoreSupport/WebFrameLoaderClient.cpp:
6506 * WebCoreSupport/WebFrameLoaderClient.h:
6508 2010-04-05 Peter Nelson <charn.opcode@gmail.com>
6510 Reviewed by Eric Seidel.
6512 Fixed style errors in DOMCoreClasses.h to bring it up to scratch
6513 for https://bugs.webkit.org/show_bug.cgi?id=34979.
6516 (DOMObject::throwException):
6517 (DOMObject::callWebScriptMethod):
6518 (DOMObject::evaluateWebScript):
6519 (DOMObject::removeWebScriptKey):
6520 (DOMObject::stringRepresentation):
6521 (DOMObject::webScriptValueAtIndex):
6522 (DOMObject::setWebScriptValueAtIndex):
6523 (DOMObject::setException):
6524 (DOMNodeList::throwException):
6525 (DOMNodeList::callWebScriptMethod):
6526 (DOMNodeList::evaluateWebScript):
6527 (DOMNodeList::removeWebScriptKey):
6528 (DOMNodeList::stringRepresentation):
6529 (DOMNodeList::webScriptValueAtIndex):
6530 (DOMNodeList::setWebScriptValueAtIndex):
6531 (DOMNodeList::setException):
6532 (DOMDocument::throwException):
6533 (DOMDocument::callWebScriptMethod):
6534 (DOMDocument::evaluateWebScript):
6535 (DOMDocument::removeWebScriptKey):
6536 (DOMDocument::stringRepresentation):
6537 (DOMDocument::webScriptValueAtIndex):
6538 (DOMDocument::setWebScriptValueAtIndex):
6539 (DOMDocument::setException):
6540 (DOMDocument::nodeName):
6541 (DOMDocument::nodeValue):
6542 (DOMDocument::setNodeValue):
6543 (DOMDocument::nodeType):
6544 (DOMDocument::parentNode):
6545 (DOMDocument::childNodes):
6546 (DOMDocument::firstChild):
6547 (DOMDocument::lastChild):
6548 (DOMDocument::previousSibling):
6549 (DOMDocument::nextSibling):
6550 (DOMDocument::attributes):
6551 (DOMDocument::ownerDocument):
6552 (DOMDocument::insertBefore):
6553 (DOMDocument::replaceChild):
6554 (DOMDocument::removeChild):
6555 (DOMDocument::appendChild):
6556 (DOMDocument::hasChildNodes):
6557 (DOMDocument::cloneNode):
6558 (DOMDocument::isSupported):
6559 (DOMDocument::namespaceURI):
6560 (DOMDocument::prefix):
6561 (DOMDocument::setPrefix):
6562 (DOMDocument::localName):
6563 (DOMDocument::hasAttributes):
6564 (DOMDocument::isSameNode):
6565 (DOMDocument::isEqualNode):
6566 (DOMDocument::textContent):
6567 (DOMDocument::setTextContent):
6568 (DOMElement::throwException):
6569 (DOMElement::callWebScriptMethod):
6570 (DOMElement::evaluateWebScript):
6571 (DOMElement::removeWebScriptKey):
6572 (DOMElement::stringRepresentation):
6573 (DOMElement::webScriptValueAtIndex):
6574 (DOMElement::setWebScriptValueAtIndex):
6575 (DOMElement::setException):
6576 (DOMElement::nodeName):
6577 (DOMElement::nodeValue):
6578 (DOMElement::setNodeValue):
6579 (DOMElement::nodeType):
6580 (DOMElement::parentNode):
6581 (DOMElement::childNodes):
6582 (DOMElement::firstChild):
6583 (DOMElement::lastChild):
6584 (DOMElement::previousSibling):
6585 (DOMElement::nextSibling):
6586 (DOMElement::attributes):
6587 (DOMElement::ownerDocument):
6588 (DOMElement::insertBefore):
6589 (DOMElement::replaceChild):
6590 (DOMElement::removeChild):
6591 (DOMElement::appendChild):
6592 (DOMElement::hasChildNodes):
6593 (DOMElement::cloneNode):
6594 (DOMElement::isSupported):
6595 (DOMElement::namespaceURI):
6596 (DOMElement::prefix):
6597 (DOMElement::setPrefix):
6598 (DOMElement::localName):
6599 (DOMElement::hasAttributes):
6600 (DOMElement::isSameNode):
6601 (DOMElement::isEqualNode):
6602 (DOMElement::textContent):
6603 (DOMElement::setTextContent):
6605 2010-04-05 Alexey Proskuryakov <ap@apple.com>
6607 Reviewed by Darin Adler.
6609 https://bugs.webkit.org/show_bug.cgi?id=37111
6610 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
6612 * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
6615 2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
6617 Reviewed by Adam Barth.
6619 Clean up unused calls after changes to checkPermission and requestPermission argument lists.
6621 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
6622 (WebDesktopNotificationsDelegate::requestPermission):
6623 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
6625 2010-04-01 Chris Marrin <cmarrin@apple.com>
6627 Reviewed by Simon Fraser.
6629 Added layerTreeAsText function to DRT (for Mac)
6630 https://bugs.webkit.org/show_bug.cgi?id=36782
6632 This is the WebKit side for Windows. It plumbs the
6633 call from WebCore to DRT.
6635 * Interfaces/IWebFramePrivate.idl:
6636 * WebFrame.cpp:WebKit (Windows) side of plumbing
6637 (WebFrame::layerTreeAsText):
6640 2010-03-31 Marcus Bulach <bulach@chromium.org>
6642 Reviewed by Jeremy Orlow.
6644 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
6645 https://bugs.webkit.org/show_bug.cgi?id=35031
6647 * WebCoreSupport/WebChromeClient.h:
6648 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
6650 2010-03-30 Gavin Barraclough <barraclough@apple.com>
6652 Rubber stamped by Sam Weinig.
6654 https://bugs.webkit.org/show_bug.cgi?id=36866
6658 * WebDownloadCFNet.cpp:
6659 * WebDownloadCurl.cpp:
6660 * WebHistoryItem.cpp:
6661 * WebLocalizableStrings.cpp:
6662 * WebMutableURLRequest.cpp:
6663 * WebPreferences.cpp:
6664 (WebPreferences::migrateWebKitPreferencesToCFPreferences):
6667 2010-03-30 Adam Roben <aroben@apple.com>
6671 * Interfaces/WebKit.idl: Touched this to force a build.
6673 2010-03-29 Steve Falkenburg <sfalken@apple.com>
6675 Reviewed by Adele Peterson.
6677 Default value of accelerated compositing should be false for Windows
6678 https://bugs.webkit.org/show_bug.cgi?id=36805
6680 * WebPreferences.cpp:
6681 (WebPreferences::initializeDefaultSettings):
6683 2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
6685 Reviewed by Adam Barth.
6687 Change NotificationPresenter::checkPermission() to take the source frames full KURL,
6688 rather than its SecurityOrigin. This will aid chromium in having more fine grained
6689 permissions to control notification spam.
6691 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
6692 (WebDesktopNotificationsDelegate::checkPermission):
6693 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
6695 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
6697 Reviewed by Antti Koivisto.
6699 Change method name due to it dealing with both flattening
6700 of frame sets and inner frames.
6702 * Interfaces/IWebPreferencesPrivate.idl:
6703 * WebPreferenceKeysPrivate.h:
6704 * WebPreferences.cpp:
6705 (WebPreferences::initializeDefaultSettings):
6706 (WebPreferences::isFrameFlatteningEnabled):
6707 (WebPreferences::setFrameFlatteningEnabled):
6710 (WebView::notifyPreferencesChanged):
6712 2010-03-24 Jon Honeycutt <jhoneycutt@apple.com>
6714 <rdar://problem/7780798> Missing plug-ins should be represented by text
6715 only, instead of lego block
6717 https://bugs.webkit.org/show_bug.cgi?id=36583
6719 Reviewed by Dan Bernstein.
6721 * WebCoreSupport/WebFrameLoaderClient.cpp:
6722 (WebFrameLoaderClient::createPlugin):
6723 Return 0 if we failed to initialize the plug-in, which causes the new
6724 "missing plug-in" text to draw.
6726 2010-03-24 Kent Tamura <tkent@chromium.org>
6728 Reviewed by Darin Adler.
6730 Make Icon::createIconForFiles() optional.
6731 https://bugs.webkit.org/show_bug.cgi?id=35072
6733 - Rename iconForFiles() to chooseIconForFiles().
6734 - Call Icon::createIconForFiles() from chooseIconForFiles().
6736 * WebCoreSupport/WebChromeClient.cpp:
6737 (WebChromeClient::chooseIconForFiles):
6738 * WebCoreSupport/WebChromeClient.h:
6740 2010-03-22 Darin Adler <darin@apple.com>
6742 * WebCoreLocalizedStrings.cpp:
6743 (WebCore::missingPluginText): Fixed localization helper text to match the same
6744 string from Mac WebKit.
6746 2010-03-22 Kevin Decker <kdecker@apple.com>
6748 Reviewed by John Sullivan.
6750 https://bugs.webkit.org/show_bug.cgi?id=36328
6752 * WebCoreLocalizedStrings.cpp:
6753 (WebCore::missingPluginText): Added.
6755 2010-03-17 Enrica Casucci <enrica@apple.com>
6757 Reviewed by Darin Adler.
6759 Missing support for showing compositing layers borders and repaint count on Windows.
6760 <rdar://problem/7760736>
6761 <https://bugs.webkit.org/show_bug.cgi?id=36197>
6763 * Interfaces/IWebPreferencesPrivate.idl:
6764 * WebPreferenceKeysPrivate.h:
6765 * WebPreferences.cpp:
6766 (WebPreferences::initializeDefaultSettings):
6767 (WebPreferences::showDebugBorders):
6768 (WebPreferences::setShowDebugBorders):
6769 (WebPreferences::showRepaintCounter):
6770 (WebPreferences::setShowRepaintCounter):
6773 (WebView::notifyPreferencesChanged):
6775 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
6777 Reviewed by Pavel Feldman.
6779 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
6781 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
6782 https://bugs.webkit.org/show_bug.cgi?id=35036
6784 * WebCoreSupport/WebInspectorClient.cpp:
6785 (WebInspectorClient::WebInspectorClient):
6786 (WebInspectorClient::~WebInspectorClient):
6787 (WebInspectorClient::openInspectorFrontend):
6788 (WebInspectorClient::highlight):
6789 (WebInspectorClient::hideHighlight):
6790 (WebInspectorClient::updateHighlight):
6791 (WebInspectorFrontendClient::WebInspectorFrontendClient):
6792 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6793 (WebInspectorFrontendClient::frontendLoaded):
6794 (WebInspectorFrontendClient::localizedStringsURL):
6795 (WebInspectorFrontendClient::hiddenPanels):
6796 (WebInspectorFrontendClient::bringToFront):
6797 (WebInspectorFrontendClient::closeWindow):
6798 (WebInspectorFrontendClient::attachWindow):
6799 (WebInspectorFrontendClient::detachWindow):
6800 (WebInspectorFrontendClient::setAttachedWindowHeight):
6801 (WebInspectorFrontendClient::inspectedURLChanged):
6802 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6803 (WebInspectorFrontendClient::showWindowWithoutNotifications):
6804 (WebInspectorFrontendClient::destroyInspectorView):
6805 (WebInspectorFrontendClient::updateWindowTitle):
6806 (WebInspectorFrontendClient::onGetMinMaxInfo):
6807 (WebInspectorFrontendClient::onSize):
6808 (WebInspectorFrontendClient::onClose):
6809 (WebInspectorFrontendClient::onSetFocus):
6810 (WebInspectorFrontendClient::onWebViewWindowPosChanging):
6811 (WebInspectorWndProc):
6812 (WebInspectorFrontendClient::windowReceivedMessage):
6813 * WebCoreSupport/WebInspectorClient.h:
6814 (WebInspectorClient::frontendClosing):
6816 (WebInspector::attach):
6817 (WebInspector::detach):
6819 2010-03-14 Dan Bernstein <mitz@apple.com>
6821 Reviewed by Darin Adler.
6823 WebKit part of removing support for legacy versions of Core Graphics
6825 * WebKitClassFactory.cpp:
6826 (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
6827 * WebKitGraphics.cpp:
6829 * WebTextRenderer.cpp:
6830 (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
6832 2010-03-12 Enrica Casucci <enrica@apple.com>
6834 Fixed broken build on Windows.
6835 Added contditional compilation for accelerated compositing.
6838 (WebView::deleteBackingStore):
6839 (WebView::addToDirtyRegion):
6840 (WebView::updateBackingStore):
6842 2010-03-12 Beth Dakin <bdakin@apple.com>
6844 Reviewed by Simon Fraser.
6846 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
6847 API naming is inconsistent
6849 <rdar://problem/7729165>
6851 This patch changes all occurrences of "fullScreen" to the more
6852 popular "fullscreen."
6854 * FullscreenVideoController.cpp:
6855 (FullscreenVideoController::onMouseDown):
6856 (FullscreenVideoController::onMouseMove):
6857 (FullscreenVideoController::onMouseUp):
6858 * FullscreenVideoController.h:
6859 (FullscreenVideoController::fullscreenToHUDCoordinates):
6861 2010-03-12 Beth Dakin <bdakin@apple.com>
6863 Reviewed by Adam Roben.
6865 Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
6866 video HUD stays on top when switching to another window (e.g. via
6869 <rdar://problem/7547574>
6871 The HUD was always on top because it had the WS_EX_TOPMOST style.
6872 So I removed the style and made m_videoWindow the owner of
6873 m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
6874 is the focused window.
6876 * FullscreenVideoController.cpp:
6877 (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
6878 (FullscreenVideoController::createHUDWindow):
6880 2010-03-12 Enrica Casucci <enrica@apple.com>
6882 Reviewed by Simon Fraser.
6884 Content of 3D tests appears at the bottom right corner sometimes.
6885 <rdar://problem/7556244>
6886 <https://bugs.webkit.org/show_bug.cgi?id=36027>
6888 See detailed comments in WebCore/ChangeLog.
6891 (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
6892 (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
6893 backing store dirty region.
6894 (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
6895 (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
6896 (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
6897 We are passing width and height of the view content together with the offset for the scrolling.
6898 It was confusing to pass it all as a rectangle, when it is not a rectangle.
6900 2010-03-11 Aaron Boodman <aa@chromium.org>
6902 Kill WebDocument::applicationID() (part 1).
6904 Modify interface to WebCore::NotificationPresenter::checkPermission()
6905 and remove implementation of WebDocument::applicationID(). Breaking
6906 API changes will be in a subsequent change.
6907 https://bugs.webkit.org/show_bug.cgi?id=35846
6909 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
6910 (WebDesktopNotificationsDelegate::checkPermission):
6911 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
6913 2010-03-11 Anders Carlsson <andersca@apple.com>
6915 Reviewed by David Hyatt.
6917 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
6919 * WebCoreSupport/WebChromeClient.cpp:
6920 * WebCoreSupport/WebChromeClient.h:
6922 2010-03-10 Eric Uhrhane <ericu@chromium.org>
6924 Reviewed by David Levin.
6926 The build fix for my patch on bug #35763 wasn't quite right--it removed
6927 the call entirely, instead of replacing it with the new API. This adds
6928 the call to Database::setIsAvailable.
6930 https://bugs.webkit.org/show_bug.cgi?id=35763
6932 * WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>.
6933 (WebView::notifyPreferencesChanged):
6935 2010-03-10 John Sullivan <sullivan@apple.com>
6937 Reviewed by Tim Hatcher.
6939 <rdar://problem/7735387> input type other than text won't work with autofill
6940 <https://bugs.webkit.org/show_bug.cgi?id=35963>
6943 (WebFrame::elementDoesAutoComplete):
6944 Return true for any text field that's not a password, rather than only
6947 2010-03-09 Brady Eidson <beidson@apple.com>
6949 Reviewed by Tim Hatcher.
6951 REGRESSION: WebInspector docking busted on Windows
6952 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
6954 * WebCoreSupport/WebInspectorClient.cpp:
6955 (WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
6956 (WebInspectorClient::detachWindow): Ditto.
6957 (WebInspectorClient::showWindowWithoutNotifications): Ditto.
6959 2010-03-09 John Sullivan <sullivan@apple.com>
6961 Fixed localized string key collision. update-webkit-localized-strings now
6962 runs without errors.
6964 Reviewed by Adam Roben.
6966 * WebCoreLocalizedStrings.cpp:
6967 (WebCore::AXMenuListPopupActionVerb):
6968 Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".
6970 2010-03-08 Adam Treat <atreat@rim.com>
6972 Unreviewed build fix for Windows.
6974 * WebCoreSupport/WebChromeClient.cpp:
6975 (WebChromeClient::invalidateContents):
6977 2010-03-02 Adam Treat <atreat@rim.com>
6979 Reviewed by Dave Hyatt.
6981 Adapt the win port to the refactoring of repaint methods.
6983 https://bugs.webkit.org/show_bug.cgi?id=34214
6985 * WebCoreSupport/WebChromeClient.cpp:
6986 (WebChromeClient::invalidateContents):
6987 (WebChromeClient::invalidateWindow):
6988 (WebChromeClient::invalidateContentsAndWindow):
6989 (WebChromeClient::invalidateContentsForSlowScroll):
6990 * WebCoreSupport/WebChromeClient.h:
6992 2010-03-08 Daniel Bates <dbates@rim.com>
6994 Unreviewed, build fix.
6996 Attempt to fix the Windows builds by applying the corresponding change
6997 made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.
6999 * WebView.cpp: Removed call to settings->setDatabasesEnabled since this
7000 setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>.
7001 (WebView::notifyPreferencesChanged):
7003 2010-03-07 Mark Rowe <mrowe@apple.com>
7007 * WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header
7008 since some WebCore headers rely on the types declared within being available via the prefix
7011 2010-03-05 Chris Marrin <cmarrin@apple.com>
7013 Reviewed by Simon Fraser.
7015 Got rid of platformLayer use in WebView.
7016 https://bugs.webkit.org/show_bug.cgi?id=35798
7018 WKCACFLayer no longer depends on GraphicsLayer, so I got rid of
7019 that dependency on WebView. Now WebChromeClient casts platformLayer
7020 to WKCACFLayer which will always be the case on Windows.
7022 * WebCoreSupport/WebChromeClient.cpp:
7023 (WebChromeClient::attachRootGraphicsLayer):
7025 (WebView::setRootChildLayer):
7028 2010-03-04 Beth Dakin <bdakin@apple.com>
7030 Reviewed by Anders Carlsson.
7032 WebCore::Page::setInstanceHandle() is now just
7033 WebCore::setInstanceHandle()
7038 2010-03-03 Alice Liu <alice.liu@apple.com>
7040 Reviewed by Jon Honeycutt.
7042 Add a way to get an iframe's content frame
7044 * DOMCoreClasses.cpp:
7045 (DOMElement::createInstance):
7046 Added case for DOMHTMLIFrameElement
7047 * DOMHTMLClasses.cpp:
7048 Adding the few DOMHTMLIFrameElement functions definitions that have
7049 distinct implementations (all others just call parent implementation)
7050 (DOMHTMLIFrameElement::QueryInterface):
7051 (DOMHTMLIFrameElement::contentFrame):
7053 Most of these function declarations have definitions that just call the parent implementation
7054 (DOMHTMLIFrameElement::DOMHTMLIFrameElement):
7055 (DOMHTMLIFrameElement::AddRef):
7056 (DOMHTMLIFrameElement::Release):
7057 (DOMHTMLIFrameElement::throwException):
7058 (DOMHTMLIFrameElement::callWebScriptMethod):
7059 (DOMHTMLIFrameElement::evaluateWebScript):
7060 (DOMHTMLIFrameElement::removeWebScriptKey):
7061 (DOMHTMLIFrameElement::stringRepresentation):
7062 (DOMHTMLIFrameElement::webScriptValueAtIndex):
7063 (DOMHTMLIFrameElement::setWebScriptValueAtIndex):
7064 (DOMHTMLIFrameElement::setException):
7065 (DOMHTMLIFrameElement::nodeName):
7066 (DOMHTMLIFrameElement::nodeValue):
7067 (DOMHTMLIFrameElement::setNodeValue):
7068 (DOMHTMLIFrameElement::nodeType):
7069 (DOMHTMLIFrameElement::parentNode):
7070 (DOMHTMLIFrameElement::childNodes):
7071 (DOMHTMLIFrameElement::firstChild):
7072 (DOMHTMLIFrameElement::lastChild):
7073 (DOMHTMLIFrameElement::previousSibling):
7074 (DOMHTMLIFrameElement::nextSibling):
7075 (DOMHTMLIFrameElement::attributes):
7076 (DOMHTMLIFrameElement::ownerDocument):
7077 (DOMHTMLIFrameElement::insertBefore):
7078 (DOMHTMLIFrameElement::replaceChild):
7079 (DOMHTMLIFrameElement::removeChild):
7080 (DOMHTMLIFrameElement::appendChild):
7081 (DOMHTMLIFrameElement::hasChildNodes):
7082 (DOMHTMLIFrameElement::cloneNode):
7083 (DOMHTMLIFrameElement::normalize):
7084 (DOMHTMLIFrameElement::isSupported):
7085 (DOMHTMLIFrameElement::namespaceURI):
7086 (DOMHTMLIFrameElement::prefix):
7087 (DOMHTMLIFrameElement::setPrefix):
7088 (DOMHTMLIFrameElement::localName):
7089 (DOMHTMLIFrameElement::hasAttributes):
7090 (DOMHTMLIFrameElement::isSameNode):
7091 (DOMHTMLIFrameElement::isEqualNode):
7092 (DOMHTMLIFrameElement::textContent):
7093 (DOMHTMLIFrameElement::setTextContent):
7094 (DOMHTMLIFrameElement::tagName):
7095 (DOMHTMLIFrameElement::getAttribute):
7096 (DOMHTMLIFrameElement::setAttribute):
7097 (DOMHTMLIFrameElement::removeAttribute):
7098 (DOMHTMLIFrameElement::getAttributeNode):
7099 (DOMHTMLIFrameElement::setAttributeNode):
7100 (DOMHTMLIFrameElement::removeAttributeNode):
7101 (DOMHTMLIFrameElement::getElementsByTagName):
7102 (DOMHTMLIFrameElement::getAttributeNS):
7103 (DOMHTMLIFrameElement::setAttributeNS):
7104 (DOMHTMLIFrameElement::removeAttributeNS):
7105 (DOMHTMLIFrameElement::getAttributeNodeNS):
7106 (DOMHTMLIFrameElement::setAttributeNodeNS):
7107 (DOMHTMLIFrameElement::getElementsByTagNameNS):
7108 (DOMHTMLIFrameElement::hasAttribute):
7109 (DOMHTMLIFrameElement::hasAttributeNS):
7110 (DOMHTMLIFrameElement::focus):
7111 (DOMHTMLIFrameElement::blur):
7112 (DOMHTMLIFrameElement::idName):
7113 (DOMHTMLIFrameElement::setIdName):
7114 (DOMHTMLIFrameElement::title):
7115 (DOMHTMLIFrameElement::setTitle):
7116 (DOMHTMLIFrameElement::lang):
7117 (DOMHTMLIFrameElement::setLang):
7118 (DOMHTMLIFrameElement::dir):
7119 (DOMHTMLIFrameElement::setDir):
7120 (DOMHTMLIFrameElement::className):
7121 (DOMHTMLIFrameElement::setClassName):
7122 (DOMHTMLIFrameElement::innerHTML):
7123 (DOMHTMLIFrameElement::setInnerHTML):
7124 (DOMHTMLIFrameElement::innerText):
7125 (DOMHTMLIFrameElement::setInnerText):
7126 * Interfaces/DOMHTML.idl:
7127 Added IDOMHTMLIFrameElement interface
7129 2010-03-03 Chris Marrin <cmarrin@apple.com>
7131 Reviewed by Simon Fraser.
7133 Export acceleratedCompositing flag in IWebPreferences.
7134 https://bugs.webkit.org/show_bug.cgi?id=35610
7136 * Interfaces/IWebPreferences.idl:
7138 2010-03-02 Beth Dakin <bdakin@apple.com>
7140 Reviewed by Darin Adler and Adam Roben.
7142 Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
7143 crashes on systems that don't support CoreAnimation
7145 setHostWindow() no longer calls createRenderer(), so now that has
7146 to be called manually.
7149 (WebView::setAcceleratedCompositing):
7151 2010-03-02 Adam Roben <aroben@apple.com>
7153 Add IWebViewPrivate::registerURLSchemeAsSecure
7155 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
7156 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
7158 Reviewed by Tim Hatcher.
7160 * Interfaces/WebKit.idl: Touched to force a build.
7162 * Interfaces/IWebViewPrivate.idl:
7164 (WebView::registerURLSchemeAsSecure):
7166 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
7168 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
7170 Remove Windows line endings from some files.
7172 Rubber-stamped by Alice Liu.
7174 * Interfaces/IWebEmbeddedView.idl:
7176 * WebCoreSupport/EmbeddedWidget.cpp:
7177 (EmbeddedWidget::create):
7178 (EmbeddedWidget::~EmbeddedWidget):
7179 (EmbeddedWidget::createWindow):
7180 (EmbeddedWidget::invalidateRect):
7181 (EmbeddedWidget::setFrameRect):
7182 (EmbeddedWidget::frameRectsChanged):
7183 (EmbeddedWidget::setFocus):
7184 (EmbeddedWidget::show):
7185 (EmbeddedWidget::hide):
7186 (EmbeddedWidget::windowClipRect):
7187 (EmbeddedWidget::setParent):
7188 (EmbeddedWidget::attachToWindow):
7189 (EmbeddedWidget::detachFromWindow):
7190 (EmbeddedWidget::didReceiveResponse):
7191 (EmbeddedWidget::didReceiveData):
7192 (EmbeddedWidget::didFinishLoading):
7193 (EmbeddedWidget::didFail):
7195 * WebCoreSupport/EmbeddedWidget.h:
7196 (EmbeddedWidget::EmbeddedWidget):
7198 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
7200 Some WebKit DOMNode API is unimplemented.
7201 https://bugs.webkit.org/show_bug.cgi?id=35554
7203 Reviewed by Alice Liu.
7205 * DOMCoreClasses.cpp:
7206 (DOMNode::nextSibling):
7207 Create a DOMNode to wrap m_node's next sibling, and assign it to the
7209 (DOMNode::insertBefore):
7210 Query for the DOMNode for newChild, and return early if we fail. Query
7211 refChild for DOMNode. Call insertBefore(), passing the newChild's
7212 WebCore node and refChild's WebCore node (if refChild is non-null). If
7213 we successfully insert the child, fill the result out param with
7214 newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
7215 (DOMNode::removeChild):
7216 Query oldChild for DOMNode. If we fail, return E_FAIL. Call
7217 removeChild(), passing the node's WebCore node. If this fails, return
7218 E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
7221 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
7223 Reviewed by Adam Barth.
7225 Adapt to the new ZoomMode enum.
7226 https://bugs.webkit.org/show_bug.cgi?id=35347
7229 (WebFrame::setTextSizeMultiplier):
7231 (WebView::setZoomMultiplier):
7232 (WebView::zoomMultiplier):
7233 (WebView::canMakeTextLarger):
7234 (WebView::makeTextLarger):
7235 (WebView::canMakeTextSmaller):
7236 (WebView::makeTextSmaller):
7237 (WebView::notifyPreferencesChanged):
7239 2010-02-26 Jon Honeycutt <jhoneycutt@apple.com>
7241 <rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
7242 is passed wrong arguments
7244 Reviewed by Adam Roben.
7246 * Interfaces/IWebUIDelegatePrivate.idl:
7247 Update copyright strings. Added a new key for the plug-in source URL.
7249 * Interfaces/WebKit.idl:
7250 Update copyright strings.
7252 * WebCoreSupport/WebFrameLoaderClient.cpp:
7253 (WebFrameLoaderClient::createPlugin):
7254 Pass the URL of the plug-in as the source URL. Pass the document's
7255 base URI for the base URL.
7257 2010-02-23 Brady Eidson <beidson@apple.com>
7259 Reviewed by Tim Hatcher and Pavel Feldman.
7261 Regression (r55107) - WebInspector docking is busted.
7262 https://bugs.webkit.org/show_bug.cgi?id=35274
7264 * WebCoreSupport/WebInspectorClient.cpp:
7265 (WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
7266 to get the expected behavior.
7268 2010-02-23 Steve Block <steveblock@google.com>
7270 Reviewed by Darin Adler.
7272 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
7273 https://bugs.webkit.org/show_bug.cgi?id=34962
7275 This method is required so that a Geolocation object can cancel an
7276 asynchronous permission request. This allows the chrome client to cancel
7277 any UI it is showing for the permission request.
7279 * WebCoreSupport/WebChromeClient.h:
7280 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
7282 2010-02-22 Steve Falkenburg <sfalken@apple.com>
7284 Reviewed by Darin Adler.
7286 WebKit on Windows should pick up system setting changes without requiring explicit API calls
7287 https://bugs.webkit.org/show_bug.cgi?id=35269
7289 * WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
7290 * WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
7291 * WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
7292 * WebKitGraphics.h: Removed WebKitSystemParameterChanged.
7294 (systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
7295 (WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
7297 2010-02-22 Brady Eidson <beidson@apple.com>
7299 Reviewed by Tim Hatcher.
7301 Disable WebView docking to views that are too small.
7302 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
7304 * WebCoreSupport/WebInspectorClient.cpp:
7305 (WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
7306 window attached if WebCore says it shouldn't be attached.
7308 2010-02-17 Steve Falkenburg <sfalken@apple.com>
7310 Reviewed by Dan Bernstein.
7312 WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
7313 https://bugs.webkit.org/show_bug.cgi?id=35076
7315 * WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
7316 * WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
7317 * WebKitGraphics.cpp:
7318 (WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
7319 * WebKitGraphics.h: Added WebKitSystemParameterChanged.
7321 2010-02-17 Dmitry Titov <dimich@chromium.org>
7323 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
7325 When a live iframe element is moved between pages, it still depends on the old page.
7326 https://bugs.webkit.org/show_bug.cgi?id=34382
7328 * WebCoreSupport/WebFrameLoaderClient.cpp:
7329 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
7330 Added empty implementation of a new virtual method.
7332 * WebCoreSupport/WebFrameLoaderClient.h:
7334 2010-02-17 Kent Tamura <tkent@chromium.org>
7336 Reviewed by Eric Seidel.
7338 Introduces new Icon loading interface in order to support
7339 asynchronous loading.
7340 https://bugs.webkit.org/show_bug.cgi?id=32054
7342 Add an empty implementation of ChromeClient::iconForFiles().
7344 * WebCoreSupport/WebChromeClient.cpp:
7345 (WebChromeClient::iconForFiles):
7346 * WebCoreSupport/WebChromeClient.h:
7348 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
7350 Unreviewed. Touch WebKit.idl to fix the build.
7352 [Win] Implement test functions for printing
7353 https://bugs.webkit.org/show_bug.cgi?id=34570
7355 * Interfaces/WebKit.idl:
7357 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
7359 Reviewed by Eric Seidel.
7361 [Win] Implement test functions for printing
7362 https://bugs.webkit.org/show_bug.cgi?id=34570
7364 * Interfaces/IWebFramePrivate.idl:
7366 (WebFrame::pageNumberForElementById):
7367 (WebFrame::numberOfPages):
7370 2010-02-16 Darin Adler <darin@apple.com>
7372 Reviewed by Sam Weinig.
7374 Generalize delayed plug-in start for background tabs for use for other media
7375 https://bugs.webkit.org/show_bug.cgi?id=34981
7378 (WebView::setCanStartPlugins): Change to call setCanStartMedia.
7379 In a later patch we can change the of the public function in the IDL file too,
7380 but for now this should be enough.
7382 2010-02-15 Adam Roben <aroben@apple.com>
7384 Add IWebFramePrivate::visibleContentRect
7386 Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
7389 Reviewed by Jon Honeycutt.
7391 * Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
7393 * Interfaces/WebKit.idl: Touched to force a build.
7396 (WebFrame::visibleContentRect):
7398 Added. Calls through to FrameView::visibleContentRect.
7400 2010-02-12 Brian Weinstein <bweinstein@apple.com>
7402 Reviewed by Adam Roben.
7404 onmouseout fired when moving over tooltip on Windows
7405 https://bugs.webkit.org/show_bug.cgi?id=16794
7408 Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
7409 you mouse over the tooltip, it doesn't send a mouseout to the web content.
7412 (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
7414 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
7416 Reviewed by Kenneth Rohde Christiansen.
7418 Support frameset flattening
7419 https://bugs.webkit.org/show_bug.cgi?id=32717
7421 Add support for enabling/disabling FrameSet Flattening on the Windows port.
7423 * Interfaces/IWebPreferencesPrivate.idl:
7424 * WebPreferenceKeysPrivate.h:
7425 * WebPreferences.cpp:
7426 (WebPreferences::initializeDefaultSettings):
7427 (WebPreferences::isFrameSetFlatteningEnabled):
7428 (WebPreferences::setFrameSetFlatteningEnabled):
7431 (WebView::notifyPreferencesChanged):
7433 2010-02-10 Adam Roben <aroben@apple.com>
7435 Remove unnecessary #include of shfolder.h
7437 shfolder.h has been deprecated in newer versions of the Windows SDK.
7439 Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
7440 under VS2010 RC due to #include of shfolder.h.
7442 Reviewed by Darin Adler.
7444 * WebPreferences.cpp: Removed #include.
7446 2010-02-08 Charlie Reis <creis@chromium.org>
7448 Reviewed by Darin Adler.
7450 onbeforeunload not called at window close + frame or iframe focused
7451 https://bugs.webkit.org/show_bug.cgi?id=27481
7453 Chromium and WebKit on Windows will now fire beforeunload handlers
7454 even if an inner frame is focused.
7456 Layout tests aren't able to test this bug, since it requires closing
7457 the actual browser window, not calling window.close(). Instead,
7458 test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
7461 (WebView::shouldClose):
7463 2010-02-08 Brent Fulgham <bfulgham@webkit.org>
7465 Reviewed by Adam Roben.
7467 Include header position in World Transform used for plugin positioning.
7468 https://bugs.webkit.org/show_bug.cgi?id=34709
7471 (WebFrame::spoolPage): Correct WinCairo plugin print positioning to
7472 account for header size. Existing code ignored this, causing
7473 plugins to overlay other elements.
7475 2010-02-04 Alice Liu <alice.liu@apple.com>
7477 Reviewed by Jon Honeycutt.
7479 https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
7480 codes for most elements that arent listbox or menupopup related"
7481 <rdar://problem/7436861>
7483 * AccessibleBase.cpp:
7484 (AccessibleBase::accSelect):
7485 - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
7486 aren't beneath listboxes or menupopups. This was too restrictive since
7487 any element can be selectable.
7488 - Correct the misinterpretation of MSDN's stipulation of situations involving
7489 adding, removing, and extending selection on single-select elements
7491 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
7493 Reviewed by Adam Roben.
7495 Properly handle margin settings when printing Plugins in WinCairo.
7496 https://bugs.webkit.org/show_bug.cgi?id=34613
7499 (WebFrame::spoolPage): Adjust the GraphicsContext passed to the
7500 paintContents method so that the World Transform is properly
7501 positioned to account for margin settings at the time that
7502 PluginViewWin.cpp processes the drawing operations.
7504 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
7506 Reviewed by Adam Roben.
7508 Properly handle margin settings in WinCairo.
7509 https://bugs.webkit.org/show_bug.cgi?id=34545
7512 (scaleFactor): Require the margin information as an input
7513 parameter, and use them when computing the scaling factor.
7514 (WebFrame::drawHeader): Pass margin size to scaleFactor.
7515 (WebFrame::drawFooter): Pass margin size to scaleFactor.
7516 (WebFrame::spoolPage):
7517 1. Pass margin size to scaleFactor.
7518 2. Recognize that the return value of printerMarginRect is
7519 already in device units, and therefore scale it so that
7520 the Cairo drawing is correct.
7521 3. Remove scaling call for margins in GDI code, as it is
7522 already in scaled units.
7524 2010-02-03 Brian Weinstein <bweinstein@apple.com>
7526 Reviewed by Steve Falkenburg.
7528 Scroll does not work with IBM Thinkpad.
7529 <https://bugs.webkit.org/show_bug.cgi?id=14227>
7532 When initializing the WebView, add two scrollbar Windows inside of
7533 our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
7534 (similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
7536 Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
7537 like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
7539 Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
7543 (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
7545 (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
7547 (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
7548 (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
7549 vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
7550 (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
7551 the some kind of IBM Trackpoint driver.
7554 2010-02-02 Steve Falkenburg <sfalken@apple.com>
7556 Reviewed by Darin Adler.
7558 Copyright year updating for Windows version resources should be automatic
7559 https://bugs.webkit.org/show_bug.cgi?id=34503
7561 * WebKit.vcproj/WebKit.rc:
7563 2010-02-02 Adam Roben <aroben@apple.com>
7565 Stop copying WebCore's IDL files from SRCROOT to OBJROOT
7567 WebKit doesn't use these anymore (as of r52921).
7569 Part of Bug 34496: Clean up WebCore's IDL/script copying
7570 <https://bugs.webkit.org/show_bug.cgi?id=34496>
7572 Reviewed by Steve Falkenburg.
7574 * WebKit.vcproj/WebKit.make:
7576 2010-01-29 Gavin Barraclough <barraclough@apple.com>
7578 Reviewed by Sam Weinig + Oliver Hunt.
7580 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
7582 Pass processeing user gensture flag to media play/pause methods.
7584 * FullscreenVideoController.cpp:
7585 (FullscreenVideoController::play):
7586 (FullscreenVideoController::pause):
7588 2010-01-29 Brian Weinstein <bweinstein@apple.com>
7590 Reviewed by Adam Roben.
7592 Drag and Drop: Windows uses "stop" sign as cursor when dragging
7593 https://bugs.webkit.org/show_bug.cgi?id=34305
7594 <rdar://problem/7589672>
7596 Add a preference in WebKit (that defaults to false), for whether or not
7597 we should show the custom cursors during drag and drop. However, this is
7598 currently only used on Windows, and only used to hide the "drop not allowed"
7599 icon inside the WebView is the preference is set to true.
7601 This will be off by default, so no change in behavior.
7603 * Interfaces/IWebPreferencesPrivate.idl: Added new functions.
7604 * Interfaces/WebKit.idl: Touched to force Interfaces build.
7605 * WebDropSource.cpp:
7606 (WebDropSource::GiveFeedback): Implementation of conditional showing cursor
7608 * WebPreferenceKeysPrivate.h: Added new preference key.
7609 * WebPreferences.cpp: Added new functions.
7610 (WebPreferences::setCustomDragCursorsEnabled):
7611 (WebPreferences::customDragCursorsEnabled):
7612 * WebPreferences.h: Added new functions.
7614 2010-01-28 Jon Honeycutt <jhoneycutt@apple.com>
7616 MSAA: Crash when posting a notification for a detached object
7618 https://bugs.webkit.org/show_bug.cgi?id=34309
7619 <rdar://problem/7409759>
7621 Reviewed by Darin Adler.
7623 * AccessibleBase.cpp:
7624 (AccessibleBase::QueryService):
7625 If an unrecognized service ID is passed, return early. Otherwise, return
7626 the result of QueryInterface.
7627 (AccessibleBase::QueryInterface):
7628 Add static_casts. Check for new UUIDs.
7629 (AccessibleBase::isSameObject):
7630 Query the object for AccessibleBase. Return whether the pointers or the
7631 wrapped objects match.
7634 Give the class a UUID so we can query for it in isSameObject(). Inherit
7635 from IAccessibleComparable; inherit from IServiceProvider so clients can
7636 use QueryService to query for a custom interface.
7638 * Interfaces/AccessibleComparable.idl: Added. Declares a function that
7639 can be called to compare to accessible objects.
7641 * Interfaces/WebKit.idl:
7642 Include the new IDL.
7644 * WebKit.vcproj/Interfaces.vcproj:
7645 Add the new IDL to the project.
7647 2010-01-27 Aaron Boodman <aa@chromium.org>
7649 Expand NotificationCenter::checkPermission() interface.
7650 It now passes the full URL instead of just the origin.
7652 https://bugs.webkit.org/show_bug.cgi?id=34238
7654 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
7655 (WebDesktopNotificationsDelegate::checkPermission):
7656 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
7658 2010-01-27 Adam Roben <aroben@apple.com>
7660 Make it possible to instantiate WebSerializedJSValue using
7661 WebKitCreateInstance
7663 Reviewed by Dave Hyatt.
7666 * WebKitClassFactory.cpp:
7667 Added WebSerializedJSValue.
7669 2010-01-26 Steve Falkenburg <sfalken@apple.com>
7671 Reviewed by Oliver Hunt.
7673 Windows build references non-existent include paths
7674 https://bugs.webkit.org/show_bug.cgi?id=34175
7676 * WebKit.vcproj/WebKit.vcproj:
7678 2010-01-25 Steve Falkenburg <sfalken@apple.com>
7680 Reviewed by Simon Fraser.
7682 A WebGeolocationControllerClient is leaked for every WebView
7683 https://bugs.webkit.org/show_bug.cgi?id=34145
7685 * WebCoreSupport/WebGeolocationControllerClient.cpp:
7686 (WebGeolocationControllerClient::geolocationDestroyed): Added.
7687 * WebCoreSupport/WebGeolocationControllerClient.h:
7689 2010-01-23 Dan Bernstein <mitz@apple.com>
7691 Reviewed by Maciej Stachowiak.
7693 <rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
7694 https://bugs.webkit.org/show_bug.cgi?id=34006
7696 * WebPreferences.cpp:
7697 (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
7698 with a default value of true.
7700 2010-01-20 Steve Falkenburg <sfalken@apple.com>
7702 Reviewed by Sam Weinig.
7704 Add missing implementation for WebGeolocationPosition::initWithTimestamp.
7706 * WebGeolocationPosition.cpp:
7707 (WebGeolocationPosition::initWithTimestamp): Implemented.
7709 2010-01-20 Jon Honeycutt <jhoneycutt@apple.com>
7711 MSAA: accSelect() is not implemented
7713 https://bugs.webkit.org/show_bug.cgi?id=33918
7714 <rdar://problem/7436861>
7716 Reviewed by Darin Adler.
7718 * AccessibleBase.cpp:
7719 (AccessibleBase::accSelect):
7720 If there is an invalid combination of state flags, return early. If the
7721 caller passed the "take focus" flag, focus the object. If the "take
7722 selection" flag was passed, check whether the parent object is an
7723 AccessibilityListBox; if so, call the object's setSelectedChildren()
7724 function. If the parent is an AccessibilityMenuListPopup, call the
7725 child object's setSelected() function. Otherwise, if the parent is some
7726 other, unsupported object, return early.
7727 If the selection flags include "add", "remove", or "extend" selection,
7728 and the parent object is not multi-selectable, return early. Otherwise,
7729 set or unset the child's selected flag based on the passed flag.
7731 2010-01-20 Steve Falkenburg <sfalken@apple.com>
7733 Reviewed by Darin Adler and Adam Roben.
7735 Feature defines are difficult to maintain on Windows builds
7736 https://bugs.webkit.org/show_bug.cgi?id=33883
7738 FeatureDefines.vsprops are now maintained in a way similar to
7739 Configurations/FeatureDefines.xcconfig, with the added advantage
7740 of having a single FeatureDefines file across all projects.
7742 * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet.
7743 * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated.
7744 * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions.
7745 Add FeatureDefines.vsprops inherited property sheet.
7746 * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet.
7748 2010-01-17 Jon Honeycutt <jhoneycutt@apple.com>
7750 MSAA: The child <option> elements of a non-multiple <select> are not
7753 https://bugs.webkit.org/show_bug.cgi?id=33773
7754 <rdar://problem/7550556>
7756 Reviewed by Alice Liu.
7758 * AccessibleBase.cpp:
7759 (AccessibleBase::get_accState):
7760 If the object is invisible, set the invisible state flag. If the object
7761 is collapsed, set the collapsed state. If the object is a combo box,
7762 set the has popup flag, and if it's not collapsed, set the expanded
7765 Add new WebCore to MSAA role mappings.
7767 * WebCoreLocalizedStrings.cpp:
7768 (WebCore::AXMenuListActionVerb):
7769 Return the action verb that Firefox uses for <select> elements with
7771 (WebCore::AXMenuListPopupActionVerb):
7772 Return the verb that Firefox uses for a popup list.
7774 2010-01-19 John Sullivan <sullivan@apple.com>
7776 https://bugs.webkit.org/show_bug.cgi?id=33854
7777 Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns
7778 more info about where the result was found
7780 Reviewed by Darin Adler
7782 * Interfaces/IWebHTMLRepresentation.idl:
7783 Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
7785 * Interfaces/WebKit.idl:
7786 Touched in order to get other idl change to propagate correctly.
7788 * WebHTMLRepresentation.cpp:
7789 (WebHTMLRepresentation::deprecatedSearchForLabels):
7790 Renamed since iDL doesn't support two functions with the same name but different signatures.
7791 (WebHTMLRepresentation::searchForLabels):
7792 Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
7794 * WebHTMLRepresentation.h:
7795 Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
7797 2010-01-19 Adam Roben <aroben@apple.com>
7801 * WebScriptWorld.cpp: Added missing #include.
7803 2010-01-19 Dave Hyatt <hyatt@apple.com>
7805 Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.
7807 * Interfaces/IWebScriptWorld.idl:
7809 2010-01-19 Dave Hyatt <hyatt@apple.com>
7811 Reviewed by Adam Roben.
7813 Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.
7815 * Interfaces/IWebScriptWorld.idl:
7816 * WebScriptWorld.cpp:
7817 (WebScriptWorld::scriptWorldForGlobalContext):
7820 2010-01-18 Adam Roben <aroben@apple.com>
7822 Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme
7824 WebKit/win part of fixing <http://webkit.org/b/33806>
7825 <rdar://problem/7552837> Would like API to disallow setting of
7826 document.domain for pages with certain URL schemes
7828 Reviewed by Sam Weinig.
7830 * Interfaces/IWebViewPrivate.idl: Added
7831 setDomainRelaxationForbiddenForURLScheme.
7833 * Interfaces/WebKit.idl: Touched to force a build.
7836 (WebView::setDomainRelaxationForbiddenForURLScheme):
7838 Added. Calls through to SecurityOrigin.
7840 2010-01-18 Chris Marrin <cmarrin@apple.com>
7842 Reviewed by Darin Adler.
7844 Use new setScrollFrame API
7845 https://bugs.webkit.org/show_bug.cgi?id=32279
7848 (WebView::updateRootLayerContents):
7850 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
7852 MSAA: Screen rect for <option> elements is always the zero rect
7854 https://bugs.webkit.org/show_bug.cgi?id=33758
7856 Reviewed by Oliver Hunt.
7858 * AccessibleBase.cpp:
7859 (AccessibleBase::accLocation):
7860 Use elementRect() rather than boundingBoxRect(), which
7861 AccessibilityListBoxOption overrides.
7863 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
7865 get_accParent should try to retrieve parent AccessibilityObject, before
7868 https://bugs.webkit.org/show_bug.cgi?id=22893
7870 Reviewed by Darin Adler.
7872 * AccessibleBase.cpp:
7873 (AccessibleBase::get_accParent):
7874 If the object has a parent object, return it. If not, return the
7875 accessible for the WebView window.
7877 2010-01-12 Jon Honeycutt <jhoneycutt@apple.com>
7879 MSAA: selected, selectable, extended selectable, and multiple
7880 selectable states are not reported
7882 https://bugs.webkit.org/show_bug.cgi?id=33574
7883 <rdar://problem/7536826>
7885 Reviewed by Darin Adler.
7887 * AccessibleBase.cpp:
7888 (AccessibleBase::get_accState):
7889 Remove the call to isMultiSelect(). Call the correctly-named
7890 isMultiSelectable(), and if it returns true, set both the "extended
7891 selectable" and "multiple selectable" states. Check whether the object
7892 is selected or selectable, and report those states.
7894 2010-01-13 Steve Falkenburg <sfalken@apple.com>
7896 Reviewed by Adam Roben.
7898 Add additional Geolocation interfaces in WebKit for Windows.
7900 * Interfaces/IWebGeolocationPolicyListener.idl: Added.
7901 * Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
7902 Append since this version hasn't shipped.
7903 * Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
7904 * WebCoreSupport/WebChromeClient.cpp:
7905 (WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
7906 * WebCoreSupport/WebGeolocationControllerClient.cpp:
7907 (WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
7908 * WebGeolocationPolicyListener.cpp: Added.
7909 * WebGeolocationPolicyListener.h: Added.
7910 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
7911 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
7913 (WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
7914 (WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
7915 (WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
7916 (WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.
7918 2010-01-12 Steve Falkenburg <sfalken@apple.com>
7920 Reviewed by Adam Roben, Sam Weinig.
7922 Add Geolocation interfaces in WebKit for Windows.
7924 * ForEachCoClass.h: Added WebGeolocationPosition.
7925 * Interfaces/IWebError.idl:
7926 * Interfaces/IWebGeolocationPosition.idl: Added.
7927 * Interfaces/IWebGeolocationProvider.idl: Added.
7928 * Interfaces/IWebViewPrivate.idl:
7929 * Interfaces/WebKit.idl:
7930 * WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
7931 (WebGeolocationControllerClient::WebGeolocationControllerClient):
7932 (WebGeolocationControllerClient::startUpdating):
7933 (WebGeolocationControllerClient::stopUpdating):
7934 (WebGeolocationControllerClient::lastPosition):
7935 * WebCoreSupport/WebGeolocationControllerClient.h: Added.
7936 * WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
7937 * WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
7938 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
7939 relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
7940 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
7941 * WebKitClassFactory.cpp: Add WebGeolocationPosition include.
7943 (WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
7944 (WebView::setGeolocationProvider): Added Geolocation-specific method.
7945 (WebView::geolocationProvider): Added Geolocation-specific method.
7946 (WebView::geolocationDidChangePosition): Added Geolocation-specific method.
7947 (WebView::geolocationDidFailWithError): Added Geolocation-specific method.
7948 * WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
7950 2010-01-11 Jon Honeycutt <jhoneycutt@apple.com>
7952 MSAA: Accessibility role of <select multiple> elements is wrong
7954 https://bugs.webkit.org/show_bug.cgi?id=33522
7956 Reviewed by Darin Adler.
7958 * AccessibleBase.cpp:
7960 Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
7961 "list" and "list item" roles.
7963 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
7965 Build fix, no review.
7967 Protect video control logic inside ENABLE(VIDEO).
7970 (WebView::enterFullscreenForNode):
7971 (WebView::exitFullscreen):
7974 2010-01-08 Chris Marrin <cmarrin@apple.com>
7976 Reviewed by Adam Roben.
7978 Implement full-screen video for Windows
7979 https://bugs.webkit.org/show_bug.cgi?id=31318
7981 This adds a full-screen controller, FullscreenVideoController,
7982 which manages going in and out of full-screen. The actual
7983 full-screen window is created and managed by logic added
7984 to QTMovieWin. FullscreenVideoController also creates and
7985 manages a HUD. The HUD renders and manages events to
7986 control the playing video. Movie controller events go to
7987 FullscreenVideoController which then sends them to HTMLMediaElement,
7988 which is passed to the controller by WebView, which gets the call
7989 to go into full-screen mode from HTMLMediaElement via
7992 I've also updated the icons so the related sets (Play/Pause and
7993 volume high/volume low/exit fullscreen) are the same size. This
7994 allows me to position them using common code.
7996 * WebCoreSupport/WebChromeClient.cpp:
7997 (WebChromeClient::supportsFullscreenForNode):
7998 (WebChromeClient::enterFullscreenForNode):
7999 (WebChromeClient::exitFullscreenForNode):
8000 * WebCoreSupport/WebChromeClient.h:
8001 * WebKit.vcproj/WebKit.vcproj:
8002 * WebKit.vcproj/fsVideoAudioVolumeHigh.png:
8003 * WebKit.vcproj/fsVideoAudioVolumeLow.png:
8004 * WebKit.vcproj/fsVideoExitFullscreen.png:
8005 * WebKit.vcproj/fsVideoPause.png:
8006 * WebKit.vcproj/fsVideoPlay.png:
8008 (loadResourceIntoBuffer):
8009 * FullscreenVideoController.cpp: Added.
8010 * FullscreenVideoController.h: Added.
8012 (WebView::enterFullscreenForNode):
8013 (WebView::exitFullscreen):
8016 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
8018 Unreviewed correction.
8020 Accidentally left unnecessary modification to hdcFromContext
8021 in when landing r52995.
8024 (hdcFromContext): Back out unneeded modification.
8026 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
8028 Reviewed by Adam Roben.
8030 Use correct cairo surface data type for handling print operations.
8031 https://bugs.webkit.org/show_bug.cgi?id=33022.
8034 (scaleFactor): Handle 'scale = 0' case.
8035 (WebFrame::spoolPage): Use scaleFactor helper function. Account for
8036 margin size in region passed to header/footer routines.
8037 (WebFrame::spoolPages): Properly clean up Cairo surface.
8039 2010-01-07 Kent Tamura <tkent@chromium.org>
8041 Reviewed by Maciej Stachowiak.
8043 Remove COM code generation files.
8044 https://bugs.webkit.org/show_bug.cgi?id=32854
8046 * WebKit.vcproj/DerivedSources.make: Removed.
8047 * WebKit.vcproj/build-generated-files.sh: Removed.
8049 2010-01-05 Adam Roben <aroben@apple.com>
8051 Make IWebView::close and destroying a WebView's HWND optional for
8054 WebView will now take care of these operations itself when its last
8055 reference is released, if they haven't already been done.
8057 IWebView::close now also destroys the WebView's HWND. All WebKit
8058 clients were already performing these operations in succession anyway,
8059 or were attempting to by calling IWebView::close then destroying the
8060 WebView's host window (which actually resulted in the WebView's HWND
8061 leaking, and the crash in the below bug).
8063 Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when
8064 calling IWebView::close, then releasing the WebView, without calling
8067 Fixes a few WebViewDestruction tests, too.
8069 Reviewed by Steve Falkenburg.
8072 (WebView::~WebView): Don't try to destroy m_viewWindow here. That
8073 should already have happened. Assert that this is the case.
8074 (WebView::close): If m_viewWindow isn't already being destroyed,
8075 destroy it now. Moved the call to revokeDragDrop() here from our
8076 WM_DESTROY handler because it needs to be done before m_viewWindow is
8078 (WebView::WebViewWndProc): Removed call to revokeDragDrop() that
8079 close() now performs.
8080 (WebView::Release): If our last reference is being released, call
8081 close() so that clients don't have to. (It's harmless to call close()
8082 multiple times.) We do this here instead of in the destructor because
8083 close() can cause AddRef() and Release() to be called, and calling
8084 those from within the destructor leads to double-destruction.
8085 (WebView::setHostWindow): Removed an unnecessary (and now harmful)
8087 (WebView::revokeDragDrop): Changed an assertion into a run-time check,
8088 since this will now sometimes be called when m_viewWindow hasn't been
8089 created yet. Changed the IsWindow call to a null-check because we
8090 never hold onto a destroyed m_viewWindow.
8091 (WebView::windowAncestryDidChange): If we don't have a view window,
8092 stop tracking changes to our parent's active state.
8094 2010-01-05 Adam Roben <aroben@apple.com>
8096 Make it safe to call IWebView::close when IWebView::initWithFrame
8099 Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash
8100 when IWebView::close, then releasing the WebView, without calling
8103 Reviewed by Steve Falkenburg.
8106 (WebView::close): Null-check m_page and m_preferences before using
8107 them. They will be null if initWithFrame was never called.
8109 2010-01-05 Adam Roben <aroben@apple.com>
8111 Add assertions to catch double-destruction of WebViews earlier
8113 I basically copied the m_deletionHasBegun logic from WTF::RefCounted.
8115 Fixes <http://webkit.org/b/33219>.
8117 Reviewed by Darin Adler.
8120 (WebView::WebView): Initialize m_deletionHasBegun
8121 (WebView::AddRef): Assert that deletion hasn't already begun.
8122 (WebView::Release): Assert that deletion hasn't already begun, then
8123 record when deletion *does* begin.
8125 * WebView.h: Added m_deletionHasBegun.
8127 2010-01-05 Adam Roben <aroben@apple.com>
8129 Remove dead code in WebViewWndProc
8131 Fixes <http://webkit.org/b/33218>.
8133 Reviewed by Darin Adler.
8136 (WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
8137 We bail out much earlier in this function if isBeingDestroyed is true.
8139 2010-01-04 Jon Honeycutt <jhoneycutt@apple.com>
8141 MSAA: Accessibility role of <select> elements is wrong
8143 https://bugs.webkit.org/show_bug.cgi?id=33192
8145 Reviewed by Sam Weinig.
8147 * AccessibleBase.cpp:
8149 Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.
8151 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8153 Reviewed by Darin Adler.
8155 https://bugs.webkit.org/show_bug.cgi?id=33181
8156 The first letter is not removed properly from inline input hole
8158 * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was
8159 confirmed, cancel it.
8161 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8163 Reviewed by Darin Adler.
8165 https://bugs.webkit.org/show_bug.cgi?id=33161
8166 Assertion failure in WebView when using Chinese Simplified IME
8168 * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode
8169 check. We can't make assertions about arguments passed from outside WebKit.
8171 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8173 Reviewed by Darin Adler.
8175 https://bugs.webkit.org/show_bug.cgi?id=33157
8176 Implement TextInput logging channel on Windows
8178 * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
8180 Added a TextInput channel in place of unused Network one.
8183 (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward
8184 it to DefWindowProc, so there is no need to return an unused boolean result for "handled".
8185 (WebView::onIMEStartComposition): Added logging.
8186 (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition.
8187 (imeNotificationName): A helper function for detailed logging in onIMENotify.
8188 (imeRequestName): A helper function for detailed logging in onIMERequest.
8189 (WebView::onIMEComposition): Added logging.
8190 (WebView::onIMEEndComposition): Ditto.
8191 (WebView::onIMEChar): Ditto.
8192 (WebView::onIMENotify): Ditto.
8193 (WebView::onIMERequestCharPosition): Changed to return result directly.
8194 (WebView::onIMERequestReconvertString): Ditto.
8195 (WebView::onIMERequest): Changed to return result directly. Added logging.
8196 (WebView::onIMESelect): Added logging.
8197 (WebView::onIMESetContext): Added logging.
8199 * WebView.h: onIMERequest functions now return result directly.
8202 2010-01-04 Adam Roben <aroben@apple.com>
8206 Fixes <http://webkit.org/b/33167>.
8208 Reviewed by Sam Weinig.
8210 * WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
8211 after DumpRenderTree.vcproj.
8213 2010-01-04 Dan Bernstein <mitz@apple.com>
8215 Reviewed by Ada Chan and Mark Rowe.
8217 Updated copyright string
8219 * WebKit.vcproj/WebKit.rc:
8221 2009-12-22 Darin Adler <darin@apple.com>
8223 Another try at fixing Windows build.
8225 * WebKitPrefix.cpp: Touch it.
8227 2009-12-22 Darin Adler <darin@apple.com>
8229 Reviewed by Mark Rowe.
8231 Turn off datagrid by default, at least for all platforms Apple ships.
8232 The datagrid implementation isn't ready for general web use yet.
8234 * WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
8236 2009-12-21 Adam Roben <aroben@apple.com>
8238 Fix non-ACCELERATED_COMPOSITING builds
8240 * WebPreferences.cpp:
8241 (WebPreferences::acceleratedCompositingEnabled): Guard use of
8242 WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
8244 2009-12-18 Adam Roben <aroben@apple.com>
8246 Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
8248 Fixes <http://webkit.org/b/32745>.
8250 Reviewed by Ada Chan.
8252 * Interfaces/IWebPreferencesPrivate.idl: Added
8253 [set]AcceleratedCompositingEnabled.
8255 * Interfaces/WebKit.idl: Touched to force a build.
8257 * WebPreferenceKeysPrivate.h: Added
8258 WebKitAcceleratedCompositingEnabledPreferenceKey.
8260 * WebPreferences.cpp:
8261 (WebPreferences::initializeDefaultSettings): Make accelerated
8262 compositing be on by default.
8263 (WebPreferences::setAcceleratedCompositingEnabled): Store the new
8265 (WebPreferences::acceleratedCompositingEnabled): If accelerated
8266 compositing isn't available, return false. Otherwise, return the value
8267 stored in preferences.
8269 * WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
8272 (WebView::notifyPreferencesChanged): Just pass the value from
8273 WebPreferences on down.
8275 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
8277 MSAA: Accessibility role of list items is wrong
8279 https://bugs.webkit.org/show_bug.cgi?id=32688
8281 Reviewed by Adam Roben.
8283 * AccessibleBase.cpp:
8285 Make the WebCore list item role map to the MSAA list item role.
8287 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
8289 MSAA: Accessibility role of list markers is wrong
8291 https://bugs.webkit.org/show_bug.cgi?id=32687
8293 Reviewed by Adam Roben.
8295 * AccessibleBase.cpp:
8297 Make the WebCore list marker role map to the MSAA static text role.
8299 2009-12-18 Adam Roben <aroben@apple.com>
8301 Add #includes needed after WebCore clean-up
8303 Rubber-stamped by Anders Carlsson.
8305 Fixes <http://webkit.org/b/32718>.
8307 * WebCoreSupport/WebContextMenuClient.cpp:
8308 * WebDataSource.cpp:
8309 * WebHTMLRepresentation.cpp:
8313 2009-12-17 Benjamin Otte <otte@gnome.org>
8315 Reviewed by Adam Roben.
8317 Don't include all JSC headers everywhere
8318 https://bugs.webkit.org/show_bug.cgi?id=32663
8320 * WebCoreLocalizedStrings.cpp: Added now-needed #include of
8323 2009-12-17 Adam Roben <aroben@apple.com>
8325 Remove WebKit.sln's Debug_All and Debug_Internal configurations
8327 These configurations aren't buildable by people outside of Apple, and
8328 Apple doesn't use this solution file.
8330 Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
8331 should default to Debug instead of Debug_all.
8333 Rubber-stamped by Dan Bernstein.
8335 * WebKit.vcproj/WebKit.sln:
8337 2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
8339 MSAA: Accessibility role of text nodes is wrong
8341 https://bugs.webkit.org/show_bug.cgi?id=32631
8342 <rdar://problem/7369084>
8344 Reviewed by Alice Liu.
8346 * AccessibleBase.cpp:
8348 If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
8349 (AccessibleBase::role):
8350 Call roleValueForMSAA().
8352 2009-12-14 Brent Fulgham <bfulgham@webkit.org>
8354 Reviewed by Adam Roben.
8356 Provide working printing support for WinCairo port.
8359 (WebFrame::spoolPage): Conditionalize initialization of
8360 PlatformGraphicsContext handling for CG vs. Cairo.
8361 (scaleFactor): Add helper function.
8362 (hdcFromContext): Add helper function.
8363 (WebFrame::drawHeader): Correct Cairo variation.
8364 (WebFrame::drawFooter): Correct Cairo variation.
8365 (WebFrame::spoolPages): Correct Cairo variation.
8367 2009-12-13 Sam Weinig <sam@webkit.org>
8369 Reviewed by Dan Bernstein.
8371 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
8372 Add client based Geolocation provider
8374 Add first cut of a client based Geolocation provider. This is guarded by
8375 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
8376 GeolocationControllerClient interface that no-one currently implements,
8377 but will in a subsequent patch.
8380 (WebView::initWithFrame):
8382 2009-12-14 Adam Roben <aroben@apple.com>
8384 Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
8386 Reviewed by Steve Falkenburg.
8388 Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
8389 a link element crashes WebKit nightly
8391 * Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
8392 of the interface so the vtable that Safari 4.0.4 sees is unchanged.
8394 2009-12-14 Adam Roben <aroben@apple.com>
8398 * WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
8399 libpath for all non-Cairo configurations (it was missing from most of
8402 2009-12-11 Chris Marrin <cmarrin@apple.com>
8404 Reviewed by Jon Honeycutt.
8406 Added icons for full-screen video on Windows
8407 https://bugs.webkit.org/show_bug.cgi?id=31318
8409 * WebKit.vcproj/WebKit.rc:
8410 * WebKit.vcproj/WebKit.vcproj:
8411 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added.
8412 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Added.
8413 * WebKit.vcproj/fsVideoExitFullscreen.png: Added.
8414 * WebKit.vcproj/fsVideoPause.png: Added.
8415 * WebKit.vcproj/fsVideoPlay.png: Added.
8416 * WebKit.vcproj/resource.h:
8418 2009-12-11 Chris Marrin <cmarrin@apple.com>
8420 Reviewed by Adam Roben.
8422 Delay load DLLs for accelerated compositing
8423 https://bugs.webkit.org/show_bug.cgi?id=31856
8425 If the DLLs (d3d9 and QuartzCore). are not present it
8426 turns off accelerated compositing and avoids calling
8427 any of the functions in the DLLs.
8430 (WebView::notifyPreferencesChanged):
8432 2009-12-10 Jon Honeycutt <jhoneycutt@apple.com>
8434 Pass more information about a plug-in to the PluginHalterDelegate
8436 Reviewed by Adam Roben.
8438 * Interfaces/IWebPluginHalterDelegate.idl:
8441 * WebCoreSupport/WebPluginHalterClient.cpp:
8442 (WebPluginHalterClient::shouldHaltPlugin):
8443 Update for new parameters. Pass them when making the delegate call.
8445 * WebCoreSupport/WebPluginHalterClient.h:
8446 Update for new parameters.
8448 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8450 Revert incorrect commit-box update r51911.
8451 It mistakenly set the selectAll implementation in the
8455 (WebFrame::deselectAll):
8457 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8459 Reviewed by Darin Adler.
8461 Provide an implementation for 'selectAll'
8462 https://bugs.webkit.org/show_bug.cgi?id=32296
8465 (WebFrame::selectAll): Implement "SelectAll" command.
8467 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8469 Reviewed by Darin Adler.
8471 Provide an implementation for 'selectAll'
8472 https://bugs.webkit.org/show_bug.cgi?id=32296
8475 (WebFrame::selectAll): Implement "SelectAll" command.
8477 2009-12-08 Chris Marrin <cmarrin@apple.com>
8479 Reviewed by Adam Roben.
8481 Delay load DLLs for accelerated compositing
8482 https://bugs.webkit.org/show_bug.cgi?id=31856
8484 If the DLLs (d3d9 and QuartzCore). are not present it
8485 turns off accelerated compositing and avoids calling
8486 any of the functions in the DLLs.
8491 2009-12-08 Adam Roben <aroben@apple.com>
8495 * Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
8497 2009-12-08 John Sullivan <sullivan@apple.com>
8499 Reviewed by Dan Bernstein
8501 Split two-clause assertions into two separate assertions.
8503 * DOMHTMLClasses.cpp:
8504 (DOMHTMLInputElement::isTextField):
8505 Split a two-clause assertion into two separate assertions.
8506 (DOMHTMLInputElement::rectOnScreen):
8507 Added the two assertions here that all other functions in this group shared.
8508 (DOMHTMLInputElement::selectedRange):
8509 Split a two-clause assertion into two separate assertions.
8510 (DOMHTMLInputElement::setAutofilled):
8511 Split a two-clause assertion into two separate assertions.
8512 (DOMHTMLInputElement::isAutofilled):
8513 Split a two-clause assertion into two separate assertions.
8515 2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
8517 Rubber-stamped by Maciej Stachowiak.
8519 Turn on (SVG) Filters for Win.
8520 https://bugs.webkit.org/show_bug.cgi?id=32224
8522 * WebKit.vcproj/WebKit.vcproj:
8524 2009-12-08 John Sullivan <sullivan@apple.com>
8526 Add isAutofilled getter to match existing setter.
8528 Reviewed by Ada Chan.
8530 * DOMHTMLClasses.cpp:
8531 (DOMHTMLInputElement::isAutofilled):
8532 Implemented new cover function.
8535 Declared new cover function.
8537 * Interfaces/DOMPrivate.idl:
8538 Declared new interface.
8540 2009-12-07 Gavin Barraclough <barraclough@apple.com>
8542 Reviewed by NOBODY (Windows build fix part III).
8545 (WebView::stringByEvaluatingJavaScriptFromString):
8547 2009-12-07 Gavin Barraclough <barraclough@apple.com>
8549 Reviewed by NOBODY (Windows build fix part II).
8552 (WebView::stringByEvaluatingJavaScriptFromString):
8554 2009-12-03 Brady Eidson <beidson@apple.com>
8556 Reviewed by Sam Weinig.
8558 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
8560 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
8561 * WebCoreSupport/WebFrameLoaderClient.cpp:
8562 (WebFrameLoaderClient::dispatchDidPushStateWithinPage):
8563 (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
8564 (WebFrameLoaderClient::dispatchDidPopStateWithinPage):
8565 * WebCoreSupport/WebFrameLoaderClient.h:
8567 2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
8569 Reviewed by Timothy Hatcher.
8571 Web Inspector: Simplify the settings support in inspector controller.
8573 https://bugs.webkit.org/show_bug.cgi?id=32076
8575 * WebCoreSupport/WebInspectorClient.cpp:
8576 (WebInspectorClient::attachWindow):
8577 (WebInspectorClient::detachWindow):
8578 (WebInspectorClient::showWindowWithoutNotifications):
8579 * WebCoreSupport/WebInspectorClient.h:
8581 2009-12-03 Ben Murdoch <benm@google.com>
8583 Reviewed by Brady Eidson.
8585 [Android] The FrameLoaderClient is unaware of BackForwardList changes.
8586 https://bugs.webkit.org/show_bug.cgi?id=31914
8588 * WebCoreSupport/WebFrameLoaderClient.cpp:
8589 (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
8590 (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
8591 (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
8592 * WebCoreSupport/WebFrameLoaderClient.h:
8594 2009-12-02 Timothy Hatcher <timothy@apple.com>
8596 Move setValueForUser to the end of the DOMHTMLInputElement interface
8597 so it is fine for binary compatibility.
8599 Directed by Steve Falkenburg.
8601 * Interfaces/DOMHTML.idl:
8603 2009-12-02 Timothy Hatcher <timothy@apple.com>
8605 Expose setValueForUser for the COM DOMHTMLInputElement.
8607 <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
8609 Reviewed by Dan Bernstein.
8611 * DOMHTMLClasses.cpp:
8612 (DOMHTMLInputElement::setValueForUser):
8613 * Interfaces/DOMHTML.idl:
8615 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
8617 Not reviewed. Try to fix windows build.
8621 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
8623 Reviewed by Simon Fraser.
8625 Add SVG animation test framework with 'snapshot' functionality
8626 https://bugs.webkit.org/show_bug.cgi?id=31897
8628 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
8629 forwarding the call to SVGDocumentExtensions, if SVG is enabled.
8631 Implemented just like the existing pauseAnimation* methods for CSS animations.
8633 * Interfaces/IWebFramePrivate.idl:
8635 (WebFrame::pauseSVGAnimation):
8638 2009-11-30 Adam Roben <aroben@apple.com>
8640 Fix double-free of BSTRs passed to WebNavigationData::createInstance
8642 WebFrameLoaderClient::updateGlobalHistory was converting
8643 WebCore::Strings to WebCore::BStrings, then passing them to
8644 WebNavigationData::createInstance. But the latter function takes BSTR
8645 parameters and adopts them into WebCore::BStrings. So the end result
8646 was that two WebCore::BStrings would end up freeing each underlying
8649 The fix is to only convert to WebCore::BString inside
8652 Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
8653 (r49564): Crash in updateGlobalHistory when running Javascript iBench
8656 I couldn't find a way to reproduce this in DumpRenderTree.
8658 Reviewed by Steve Falkenburg.
8660 * WebCoreSupport/WebFrameLoaderClient.cpp:
8661 (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
8662 WebNavigationData::createInstance.
8664 * WebNavigationData.cpp:
8665 (WebNavigationData::WebNavigationData):
8666 (WebNavigationData::createInstance):
8667 * WebNavigationData.h:
8668 Changed to take const WebCore::String&s instead of BSTRs and to
8669 convert the Strings to BStrings at this level.
8671 2009-11-30 Steve Falkenburg <sfalken@apple.com>
8673 Reviewed by Adam Roben.
8675 WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
8676 https://bugs.webkit.org/show_bug.cgi?id=31986
8679 (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
8681 2009-11-24 Chris Marrin <cmarrin@apple.com>
8683 Another Windows build fix
8685 Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
8686 we turn on ACCELERATED_COMPOSITING
8688 * WebKit.vcproj/WebKit.vcproj:
8690 2009-11-24 Chris Marrin <cmarrin@apple.com>
8694 Got rid of QuartzCore.lib dependency. Not needed until
8695 we turn on ACCELERATED_COMPOSITING
8697 * WebKit.vcproj/WebKit.vcproj:
8699 2009-11-24 Chris Marrin <cmarrin@apple.com>
8701 Reviewed by Simon Fraser.
8703 Implement accelerated compositing
8704 https://bugs.webkit.org/show_bug.cgi?id=27314
8706 This is the WebKit side of the implementation. It plumbs the root layer
8707 from WebCore. It also makes changes to WebView which places the
8708 backing store of the page into the root compositing layer so it is
8709 properly composited with all the other layers. This deals with resizing,
8710 scrolling, and incremental repaint of the page.
8712 * WebCoreSupport/WebChromeClient.cpp:
8713 (WebChromeClient::attachRootGraphicsLayer):
8714 (WebChromeClient::scheduleCompositingLayerSync):
8715 * WebCoreSupport/WebChromeClient.h:
8716 (WebChromeClient::setNeedsOneShotDrawingSynchronization):
8717 * WebKit.vcproj/WebKit.vcproj:
8722 (WebView::scrollBackingStore):
8725 (WebView::setRootChildLayer):
8726 (WebView::setAcceleratedCompositing):
8727 (WebView::setRootLayerContents):
8729 (WebView::isAcceleratedCompositing):
8730 (WebView::resizeLayerWindow):
8731 (WebView::layerWindowBecameVisible):
8732 (WebView::setRootLayerNeedsDisplay):
8734 2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
8736 Reviewed by Kenneth Rohde Christiansen.
8738 Include "config.h" to meet Coding Style Guidelines
8739 https://bugs.webkit.org/show_bug.cgi?id=31792
8741 * GEN_DOMObject.cpp:
8742 * WebScriptObject.cpp:
8744 2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
8746 Windows build fix. Unreviewed.
8748 * Interfaces/IWebSerializedJSValue.idl:
8750 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
8752 DOMElement::tagName() is unimplemented
8754 https://bugs.webkit.org/show_bug.cgi?id=31746
8756 Reviewed by Darin Adler.
8758 * DOMCoreClasses.cpp:
8759 (DOMElement::tagName):
8760 Create a BString from the element's tag name, and release its BSTR
8763 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
8765 DOMNode::childNodes() is unimplemented
8767 https://bugs.webkit.org/show_bug.cgi?id=31745
8769 Reviewed by Darin Adler.
8771 * DOMCoreClasses.cpp:
8772 (DOMNode::childNodes):
8773 Create a DOMNodeList from the node's child nodes.
8775 2009-11-20 Dave Hyatt <hyatt@apple.com>
8777 Reviewed by Jon Honeycutt.
8779 Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
8780 serialization into a separate serialize() function that can be called after the object has been
8783 Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
8785 * Interfaces/IWebSerializedJSValue.idl:
8786 * WebSerializedJSValue.cpp:
8787 (WebSerializedJSValue::WebSerializedJSValue):
8788 (WebSerializedJSValue::createInstance):
8789 (WebSerializedJSValue::serialize):
8790 (WebSerializedJSValue::deserialize):
8791 * WebSerializedJSValue.h:
8793 2009-11-20 Brian Weinstein <bweinstein@apple.com>
8795 Reviewed by Dave Hyatt.
8797 Another go at the Windows Build Fix - this is a couple steps of it,
8798 so a little more involved than most build fixes.
8800 * Interfaces/IWebSerializedJSValue.idl:
8801 * Interfaces/JavaScriptCoreAPITypes.idl:
8802 * WebKit.vcproj/Interfaces.vcproj:
8803 * WebSerializedJSValue.cpp:
8804 (WebSerializedJSValue::deserialize):
8805 * WebSerializedJSValue.h:
8807 2009-11-20 Brian Weinstein <bweinstein@apple.com>
8809 Reviewed by Dave Hyatt.
8811 Build fix for Windows - only declare JSContextRef once, instead
8812 of in two different idl files. Create a new file to hold the
8813 definition of JSContextRef.
8815 * Interfaces/IWebFrameLoadDelegate.idl:
8816 * Interfaces/IWebSerializedJSValue.idl:
8817 * Interfaces/JavaScriptCoreAPITypes.idl: Added.
8818 * Interfaces/WebKit.idl:
8819 * WebKit.vcproj/Interfaces.vcproj:
8821 2009-11-20 Dave Hyatt <hyatt@apple.com>
8823 Reviewed by Oliver Hunt and Jon Honeycutt.
8825 Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
8826 and exposes the ability to do JS value serialization/deserialization to WebKit clients.
8828 * Interfaces/IWebSerializedJSValue.idl: Added.
8829 * Interfaces/WebKit.idl:
8830 * WebKit.vcproj/WebKit.vcproj:
8831 * WebSerializedJSValue.cpp: Added.
8832 (WebSerializedJSValue::WebSerializedJSValue):
8833 (WebSerializedJSValue::~WebSerializedJSValue):
8834 (WebSerializedJSValue::createInstance):
8835 (WebSerializedJSValue::AddRef):
8836 (WebSerializedJSValue::Release):
8837 (WebSerializedJSValue::QueryInterface):
8838 (WebSerializedJSValue::deserialize):
8839 * WebSerializedJSValue.h: Added.
8841 2009-11-19 Alexey Proskuryakov <ap@apple.com>
8843 Reviewed by Darin Adler.
8845 https://bugs.webkit.org/show_bug.cgi?id=31690
8846 Make SocketStreamHandleCFNet work on Windows
8848 * WebDownloadCFNet.cpp:
8849 (WebDownload::init):
8850 (WebDownload::initWithRequest):
8851 (WebDownload::initToResumeWithBundle):
8852 Update for loaderRunLoop() now being in its own header.
8854 2009-11-19 Eric Carlson <eric.carlson@apple.com>
8856 Reviewed by Dan Bernstein.
8858 <rdar://problem/7035231>
8859 Support closed caption in <video> element
8861 * WebCoreLocalizedStrings.cpp:
8862 (WebCore::localizedMediaControlElementString):
8863 (WebCore::localizedMediaControlElementHelpText):
8864 Add accessibility help strings for media controller closed caption button.
8866 2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
8868 Reviewed by Darin Adler.
8870 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
8871 Support for validationMessage attribute, as per HTML5 specs.
8873 * WebCoreLocalizedStrings.cpp:
8874 (WebCore::validationMessageValueMissingText):
8875 (WebCore::validationMessageTypeMismatchText):
8876 (WebCore::validationMessagePatternMismatchText):
8877 (WebCore::validationMessageTooLongText):
8878 (WebCore::validationMessageRangeUnderflowText):
8879 (WebCore::validationMessageRangeOverflowText):
8880 (WebCore::validationMessageStepMismatchText):
8882 2009-11-18 Daniel Bates <dbates@webkit.org>
8884 Reviewed by Darin Adler.
8886 https://bugs.webkit.org/show_bug.cgi?id=31186
8888 Changes associated with renaming RenderTextControl::isUserEdited.
8890 * DOMHTMLClasses.cpp:
8891 (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited.
8892 (DOMHTMLTextAreaElement::isUserEdited): Ditto.
8894 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
8896 Implement DOMHTMLInputElement::replaceCharactersInRange().
8898 https://bugs.webkit.org/show_bug.cgi?id=31492
8900 Reviewed by Dan Bernstein.
8902 * DOMHTMLClasses.cpp:
8903 (DOMHTMLInputElement::replaceCharactersInRange):
8904 Get the text of the input field. Replace the given range with the
8905 replacement text, and set this new string as the input element's value.
8906 Select from index to the end of the field. This matches the
8907 implementation in the Obj-C bindings.
8909 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
8911 DOMHTMLOptionElement is missing some functionality.
8913 https://bugs.webkit.org/show_bug.cgi?id=31491
8915 Reviewed by Dan Bernstein.
8917 * DOMHTMLClasses.cpp:
8918 (DOMHTMLOptionElement::text):
8919 Cast m_element to an HTMLOptionElement, and call its text() function.
8920 (DOMHTMLOptionElement::label):
8923 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
8925 DOMHTMLSelectElement is missing some implementation.
8927 https://bugs.webkit.org/show_bug.cgi?id=31489
8929 Reviewed by Dan Bernstein.
8931 * DOMHTMLClasses.cpp:
8932 (DOMHTMLSelectElement::options):
8933 Cast m_element to an HTMLSelectElement. If it has no options, return
8934 E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
8935 options, and return it.
8936 (DOMHTMLSelectElement::activateItemAtIndex):
8937 If the index is out of bounds, return E_FAIL. Otherwise, select the
8940 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
8942 DOMHTMLOptionsCollection is missing some implementation.
8944 https://bugs.webkit.org/show_bug.cgi?id=31488
8946 Reviewed by Dan Bernstein.
8948 * DOMHTMLClasses.cpp:
8949 (DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
8950 Initialize m_collection.
8951 (DOMHTMLOptionsCollection::createInstance):
8952 Create a DOMHTMLOptionsCollection. If we fail to query for
8953 IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
8955 (DOMHTMLOptionsCollection::length):
8956 (DOMHTMLOptionsCollection::item):
8957 Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
8958 (DOMHTMLOptionsCollection::namedItem):
8959 Correct the signature of this function.
8962 Declare DOMHTMLOptionsCollection::createInstance(). Correct the
8963 signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
8964 member to DOMHTMLOptionsCollection to hold the WebCore object.
8966 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
8968 DOMHTMLInputElement::rectOnScreen() returns the wrong rect
8970 https://bugs.webkit.org/show_bug.cgi?id=31487
8972 Reviewed by Darin Adler.
8974 * DOMHTMLClasses.cpp:
8975 (DOMHTMLInputElement::rectOnScreen):
8976 Return the rect on screen, not the rect in the window.
8978 2009-11-17 Brent Fulgham <bfulgham@webkit.org>
8980 Reviewed by NOBODY - Build Fix.
8982 Correct build error in Debug_Cairo target after @49705.
8984 * WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib
8985 dependency to have proper "_debug" suffix needed by
8986 the Debug_Cairo target.
8988 2009-11-17 Brian Weinstein <bweinstein@apple.com>
8990 Reviewed by NOBODY - Build Fix.
8992 Touch files to try to fix the build.
8994 * Interfaces/IWebInspector.idl:
8995 * Interfaces/WebKit.idl:
8996 * WebKit.vcproj/Interfaces.vcproj:
8998 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
9000 Reviewed by Timothy Hatcher.
9002 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
9003 - Updated DRT to show/close inspector for all tests under /inspector
9004 - Introduced LayoutTestController::setTimelineProfilingEnabled and
9005 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
9006 - Removed reload on each inspector test
9007 - Renamed fast/inspector to fast/inspector-support in order not to trigger
9008 inspector for those.
9009 - Reimplemented timeline tests in order to get rid of reload there.
9010 - Moved tests that don't require harness into the fast group.
9012 https://bugs.webkit.org/show_bug.cgi?id=31472
9014 * Interfaces/IWebInspector.idl:
9016 (WebInspector::isTimelineProfilingEnabled):
9017 (WebInspector::setTimelineProfilingEnabled):
9020 2009-11-13 Adam Roben <aroben@apple.com>
9024 * Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
9026 2009-11-13 Adam Roben <aroben@apple.com>
9028 Tell the WebFrameLoadDelegate when window objects in isolated worlds
9031 Fixes <http://webkit.org/b/31124>.
9033 Reviewed by Dave Hyatt.
9035 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
9036 didClearWindowObjectForFrameInScriptWorld.
9039 (WebFrame::dispatchDidClearWindowObjectInWorld):
9041 Replaced windowObjectCleared with this function. If the delegate
9042 implements IWebFrameLoadDelegatePrivate2, call
9043 didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
9044 world is the mainThreadNormalWorld(), call
9045 didClearWindowObjectForFrame.
9047 * WebScriptWorld.cpp:
9048 (allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
9050 (WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
9051 (WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
9052 (WebScriptWorld::standardWorld): Added this non-COM getter for the
9053 standard world, which the COM getter now calls through to.
9054 (WebScriptWorld::findOrCreateWorld): Added. Returns the existing
9055 WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
9058 * WebScriptWorld.h: Added new standardWorld overload, made one
9059 overload of createInstance private, and added findOrCreateWorld.
9061 2009-11-13 Adam Roben <aroben@apple.com>
9065 * Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
9066 are order-dependent!
9068 2009-11-13 Adam Roben <aroben@apple.com>
9070 Touch WebKit.idl to fix the Windows build
9072 * Interfaces/WebKit.idl: Sorted #includes.
9074 2009-11-13 Adam Roben <aroben@apple.com>
9076 Finish replacing worldIDs with world objects
9078 The only remaining use of worldIDs was in a method only used by DRT
9079 for the isolated worlds tests.
9081 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
9083 Reviewed by Mark Rowe.
9085 * Interfaces/IWebFramePrivate.idl:
9087 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
9089 Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
9090 IWebScriptWorld instead of a worldID, so we don't need to maintain a
9091 map of worldID -> world anymore.
9093 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
9095 Reviewed by Darin Adler.
9097 externalRepresentation should take Frame as the argument
9098 https://bugs.webkit.org/show_bug.cgi?id=31393
9100 No new tests as this is just a refactoring.
9103 (WebFrame::renderTreeAsExternalRepresentation):
9105 2009-11-12 Adam Roben <aroben@apple.com>
9107 Replace worldIDs with world objects
9109 WebScriptWorld is the new object that represents a world. The only
9110 place worldID is still used is in
9111 IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
9112 that will change soon.
9114 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
9115 user scripts/stylesheets and isolated worlds
9117 Reviewed by Sam Weinig.
9119 * ForEachCoClass.h: Added WebScriptWorld.
9121 * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
9124 * Interfaces/IWebScriptWorld.idl: Added.
9126 * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
9127 functions to take an IWebScriptWorld instead of a worldID.
9129 * Interfaces/WebKit.idl: Added WebScriptWorld.
9132 (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
9134 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
9135 bizarre world caching/creation logic that DRT depends on here from the
9136 findWorld function in ScriptController.cpp. Updated to use
9137 ScriptController::executeScriptInWorld instead of
9138 ScriptController::executeScriptInIsolatedWorld.
9140 * WebFrame.h: Replaced contextForWorldID with contextForWorld.
9142 * WebScriptWorld.cpp: Added.
9143 (WebScriptWorld::WebScriptWorld):
9144 (WebScriptWorld::~WebScriptWorld):
9145 (WebScriptWorld::createInstance):
9146 (WebScriptWorld::AddRef):
9147 (WebScriptWorld::Release):
9148 (WebScriptWorld::QueryInterface):
9149 Standard COM class implementations.
9151 (WebScriptWorld::standardWorld): Returns a shared instance that represents
9152 WebCore's mainThreadNormalWorld().
9154 * WebScriptWorld.h: Added.
9155 (WebScriptWorld::world): Simple getter.
9157 * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
9159 * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
9161 * WebKitClassFactory.cpp: Added WebScriptWorld.
9164 (WebView::addUserScriptToGroup):
9165 (WebView::addUserStyleSheetToGroup):
9166 (WebView::removeUserScriptFromGroup):
9167 (WebView::removeUserStyleSheetFromGroup):
9168 (WebView::removeUserScriptsFromGroup):
9169 (WebView::removeUserStyleSheetsFromGroup):
9171 Changed these functions to take an IWebScriptWorld instead of a worldID.
9173 2009-11-12 Adam Roben <aroben@apple.com>
9175 Small clean-up in WebView's user content functions
9177 Preparation for <http://webkit.org/b/31414> Implement new SPI for
9178 dealing with user scripts/stylesheets and isolated worlds
9180 Reviewed by Dave Hyatt.
9185 Added these helper functions to convert BSTRs to WebCore types.
9188 (WebView::addUserScriptToGroup):
9189 (WebView::addUserStyleSheetToGroup):
9190 (WebView::removeUserScriptFromGroup):
9191 (WebView::removeUserStyleSheetFromGroup):
9192 (WebView::removeUserScriptsFromGroup):
9193 (WebView::removeUserStyleSheetsFromGroup):
9194 (WebView::removeAllUserContentFromGroup):
9195 Use the new helper functions.
9197 2009-11-11 Beth Dakin <bdakin@apple.com>
9199 Build fix. No review needed.
9201 * WebKitGraphics.cpp:
9204 2009-11-10 Daniel Bates <dbates@webkit.org>
9206 Reviewed by Oliver Hunt.
9208 https://bugs.webkit.org/show_bug.cgi?id=30754
9210 Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.
9212 * WebDropSource.cpp:
9213 (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.
9215 2009-11-10 Alexey Proskuryakov <ap@apple.com>
9217 Reviewed by Dan Bernstein.
9219 https://bugs.webkit.org/show_bug.cgi?id=31312
9220 Decouple authentication panel callbacks from ResourceHandle
9222 * WebCoreSupport/WebFrameLoaderClient.cpp:
9223 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
9224 * WebURLAuthenticationChallenge.cpp:
9225 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
9226 (WebURLAuthenticationChallenge::sender):
9227 * WebURLAuthenticationChallengeSender.cpp:
9228 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
9229 (WebURLAuthenticationChallengeSender::createInstance):
9230 (WebURLAuthenticationChallengeSender::authenticationClient):
9231 * WebURLAuthenticationChallengeSender.h:
9232 * WebURLAuthenticationChallengeSenderCFNet.cpp:
9233 (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
9234 (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
9235 (WebURLAuthenticationChallengeSender::useCredential):
9236 Adjusted for WebCore changes.
9238 2009-11-10 Brian Weinstein <bweinstein@apple.com>
9240 Reviewed by NOBODY - Build Fix.
9242 Updated fillRoundedRect to take a ColorSpace argument.
9244 * WebCoreSupport/WebDragClient.cpp:
9245 (WebDragClient::createDragImageForLink):
9247 2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
9249 Reviewed by Holger Freyther.
9251 ResourceRequest to be class instead of struct
9252 https://bugs.webkit.org/show_bug.cgi?id=30670
9254 Started as a compilation fix for Symbian where the compiler makes a distinction between
9255 class and struct in function argument signatures.
9256 Changed forward declaration of ResourceRequest to have class in the forward
9257 declaration instead of struct.
9261 2009-11-05 Adam Roben <aroben@apple.com>
9263 Make CFDictionaryPropertyBag::createInstance return a COMPtr
9265 I also cleaned up CFDictionaryPropertyBag's class declaration a little
9268 Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
9269 WebKit/win classes should return COMPtrs from their static constructor
9272 Reviewed by Steve Falkenburg.
9274 * CFDictionaryPropertyBag.cpp:
9275 (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
9276 initialize m_refCount to 0. m_refCount gets increased to 1 by
9278 (CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.
9280 * CFDictionaryPropertyBag.h:
9281 - Updated copyright years
9282 - Fixed header guard to match current style
9283 - Replaced #include of CoreFoundation.h with forward-declaration of
9284 CFMutableDictionaryRef
9285 - Added #include of COMPtr.h
9286 - Fixed opening brace placement in class declaration
9287 - Made createInstance return a COMPtr
9288 - Made constructor/destructor private
9289 - Made QueryInterface and IPropertyBag functions private
9290 - Removed unnecessary parameter names and MIDL comments
9293 (WebCache::statistics): Updated for change to
9294 CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
9295 the IPropertyBag pointers into the s array.
9297 * WebCoreSupport/WebFrameLoaderClient.cpp:
9298 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
9299 * WebDatabaseManager.cpp:
9300 (WebDatabaseManager::dispatchDidModifyDatabase):
9302 (WebFrame::createJavaAppletWidget):
9303 Updated for change to CFDictionaryPropertyBag::createInstance.
9305 * WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
9306 That function was also doing an unnecessary call to setDictionary(0).
9307 (createUserInfoFromArray):
9308 (createUserInfoFromHistoryItem):
9309 Changed to return COMPtr.
9311 (WebHistory::loadFromURL): Updated for change to
9312 CFDictionaryPropertyBag::createInstance.
9314 (WebHistory::removeAllItems): Updated for change to
9315 CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
9316 forgotten to call releaseUserInfo here.
9318 (WebHistory::removeItem):
9319 (WebHistory::addItem):
9320 (WebHistory::visitedURL):
9321 * WebIconDatabase.cpp:
9322 (postDidAddIconNotification):
9323 Updated for change to CFDictionaryPropertyBag::createInstance.
9325 * WebKitClassFactory.cpp:
9326 (releaseRefFromCreateInstance): Added this overloaded function
9327 template to abstract away the difference between createInstance
9328 functions that return a ref'd pointer and createInstance functions
9329 that return a COMPtr.
9330 (WebKitClassFactory::CreateInstance): Changed to use
9331 releaseRefFromCreateInstance.
9333 2009-11-03 Brian Weinstein <bweinstein@apple.com>
9335 Reviewed by Steve Falkenburg.
9337 WebActionModifierFlagsKey should return an unsigned, because
9338 flags imply a bitmask, and that is what other classes expect from
9341 * WebActionPropertyBag.cpp:
9342 (WebActionPropertyBag::Read):
9344 2009-11-02 Eric Carlson <eric.carlson@apple.com>
9346 Reviewed by John Sullivan and Mark Rowe.
9348 <rdar://problem/7356733> Voiceover does not read correct media controller time values
9350 * WebCoreLocalizedStrings.cpp:
9351 (WebCore::localizedMediaTimeDescription):
9353 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
9355 MSAA: Accessibility of headings is not correct
9357 https://bugs.webkit.org/show_bug.cgi?id=30937
9359 Reviewed by Alice Liu.
9361 * AccessibleBase.cpp:
9362 (AccessibleBase::get_accDescription):
9363 Call the object's descriptionForMSAA(). Moved the comment to the
9365 (AccessibleBase::get_accRole):
9366 If the object has a string role, return that. Otherwise, return the
9370 Removed description(), as this was moved to WebCore.
9372 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
9374 MSAA: Accessibility of links is wrong
9376 https://bugs.webkit.org/show_bug.cgi?id=30928
9378 Reviewed by Darin Adler.
9380 * AccessibleBase.cpp:
9381 (AccessibleBase::get_accState):
9382 Check whether the element is linked, instead of whether the node is an
9383 anchor, so the child "linkable" elements of anchor elements will also
9385 (AccessibleBase::name):
9386 Return the name for MSAA.
9387 (AccessibleBase::value):
9388 Return the string value for MSAA.
9390 2009-10-30 Evan Stade <estade@chromium.org>
9392 Reviewed by David Levin.
9394 Notify the chrome when the focused node has changed.
9395 https://bugs.webkit.org/show_bug.cgi?id=30832
9397 Added stub implementation for new ChromeClient function.
9399 * WebCoreSupport/WebChromeClient.cpp:
9400 (WebChromeClient::focusedNodeChanged):
9401 * WebCoreSupport/WebChromeClient.h:
9403 2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
9405 Reviewed by Eric Seidel.
9407 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
9409 Bug 28420 - Implement HTML5 <ruby> rendering
9410 (https://bugs.webkit.org/show_bug.cgi?id=28420)
9412 No new tests (no functional change).
9414 * WebKit.vcproj/WebKit.vcproj:
9416 2009-10-29 Mark Rowe <mrowe@apple.com>
9418 Rubber-stamped by Dan Bernstein.
9420 <http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
9421 to IWebFramePrivate vtable ordering
9423 * Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
9424 it doesn't affect the ordering of the vtable.
9426 2009-10-28 Steve Falkenburg <sfalken@apple.com>
9428 Reviewed by Sam "Horatio" Weinig.
9430 Should not generate/build COM DOM bindings
9431 https://bugs.webkit.org/show_bug.cgi?id=30880
9433 * Interfaces/WebKit.idl: Remove generated interfaces.
9434 * WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
9435 * WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
9436 * WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
9437 * WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
9439 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
9441 Reviewed by Darin Adler.
9443 Provide a way to get counter values with layoutTestContoller
9444 https://bugs.webkit.org/show_bug.cgi?id=30555
9446 * Interfaces/IWebFramePrivate.idl:
9448 (WebFrame::counterValueForElementById):
9451 2009-10-28 Joe Mason <jmason@rim.com>
9453 Reviewed by Adam Treat.
9455 Call the shared FrameLoader::defaultObjectContentType instead of
9456 copying code into FrameLoaderClient::objectContentType. This causes no
9460 (WebFrame::objectContentType):
9462 2009-10-28 Holger Hans Peter Freyther <zecke@selfish.org>
9464 Speculative build-fix for WebElementPropertyBag.cpp
9466 * WebElementPropertyBag.cpp: Include RenderObject.h
9468 2009-10-27 Holger Hans Peter Freyther <zecke@selfish.org>
9470 Reviewed by Simon Fraser.
9472 Change HitTestResult methods to use (3d) transformation aware methods
9473 https://bugs.webkit.org/show_bug.cgi?id=27347
9475 The HitTestResult::boundingBox method was removed. The
9476 RenderObject must be used directly. In contrast to the
9477 old HitTestResult::boundingBox method this code must use
9478 a (3d) transformation aware method to not run into an
9479 assert in SVGRenderBase::mapLocalToContainer.
9481 * WebElementPropertyBag.cpp:
9482 (WebElementPropertyBag::Read): Replace HitTestResult::boundingBox()
9484 2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
9486 Reviewed by Darin Adler.
9488 Make .rc files compile on Windows without depending on MFC headers
9489 https://bugs.webkit.org/show_bug.cgi?id=30750
9491 * WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even
9492 when MFC is not installed, and is all that's needed here.
9494 2009-10-26 Sam Weinig <sam@webkit.org>
9496 Rubber-stamped by Darin Adler.
9498 Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
9499 inherit from HTMLCollection.
9501 * DOMCreateInstance.cpp:
9503 2009-10-25 Dan Bernstein <mitz@apple.com>
9505 Reviewed by John Sullivan.
9507 Add contextForWorldID to the IWebFramePrivate interface.
9509 * Interfaces/IWebFramePrivate.idl:
9512 2009-10-25 Sam Weinig <sam@webkit.org>
9514 Another try at fixing windows.
9516 * DOMCreateInstance.cpp:
9518 2009-10-25 Sam Weinig <sam@webkit.org>
9520 Touch WebKit.idl in an effort to try and regenerate the COM bindings.
9522 * Interfaces/WebKit.idl:
9524 2009-10-23 Mark Rowe <mrowe@apple.com>
9526 Build fix. Include config.h before including other files.
9528 * AccessibleImage.cpp:
9530 2009-10-23 Gavin Barraclough <barraclough@apple.com>
9532 Reviewed by Geoff Garen.
9534 https://bugs.webkit.org/show_bug.cgi?id=30729
9535 Provide private API to request the global context for a specific world.
9536 Used to initialize parameters on the global object.
9539 (WebFrame::contextForWorldID):
9542 2009-10-23 Brian Weinstein <bweinstein@apple.com>
9544 Reviewed by John Sullivan.
9546 Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
9547 <http://webkit.org/b/30732> and <rdar://7332018>.
9549 Turns off pan-scrolling on a WebView when it is about to lose focus.
9554 2009-10-23 Jon Honeycutt <jhoneycutt@apple.com>
9556 MSAA: Name for image elements should use alt attribute text
9558 https://bugs.webkit.org/show_bug.cgi?id=30727
9559 <rdar://problem/7328291>
9561 Reviewed by Alice Liu.
9563 * AccessibleBase.cpp:
9564 (AccessibleBase::createInstance):
9565 If the AccessibilityObject is an image, return an AccessibleImage.
9567 * AccessibleImage.cpp: Added.
9568 (AccessibleImage::AccessibleImage):
9569 Call the base constructor.
9570 (AccessibleImage::name):
9571 If the object is not an AccessibilityRenderObject, return the base's
9572 name(). Look first for an ARIA "labeled-by" attribute, then look for an
9573 alternate text attribute. Fall back to the base's name().
9575 * AccessibleImage.h: Added.
9576 (AccessibleImage::~AccessibleImage):
9578 * WebKit.vcproj/WebKit.vcproj:
9579 Add AccessibleImage to the project.
9581 2009-10-23 Sam Weinig <sam@webkit.org>
9583 Try and fix the windows build.
9585 * Interfaces/WebKit.idl:
9587 2009-10-22 Gavin Barraclough <barraclough@apple.com>
9589 Reviewed by Sam Weinig & Geoff Garen.
9591 https://bugs.webkit.org/show_bug.cgi?id=30696
9592 Update to incorporate support for IsolatedWorlds in JSC bindings.
9594 * Interfaces/IWebFramePrivate.idl:
9596 (WebFrame::globalContext):
9597 (WebFrame::windowObjectCleared):
9598 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
9601 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
9603 Reviewed by David Levin.
9605 Removed WebSocket runtime settings.
9606 https://bugs.webkit.org/show_bug.cgi?id=29896
9608 WebSocket runtime configuration is supported by chromium/v8 only.
9610 * Interfaces/IWebPreferencesPrivate.idl:
9611 * WebPreferenceKeysPrivate.h:
9612 * WebPreferences.cpp:
9613 (WebPreferences::initializeDefaultSettings):
9614 (WebPreferences::experimentalNotificationsEnabled):
9617 (WebView::notifyPreferencesChanged):
9619 2009-10-19 Adam Roben <aroben@apple.com>
9621 Fix crashes/assertions when calling WebLocalizedString from multiple
9622 threads concurrently
9624 Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
9625 from multiple threads concurrently
9627 Reviewed by John Sullivan.
9629 * WebLocalizableStrings.cpp:
9630 (mainBundleLocStringsMutex):
9631 (frameworkLocStringsMutex):
9632 Added these new getters.
9636 Lock the relevant mutex before accessing each string map. Otherwise
9637 bad things could happen if two threads end up here at the same time.
9639 2009-10-19 Adam Roben <aroben@apple.com>
9641 Get rid of a few static initializers/exit-time destructors in
9642 WebLocalizableStrings
9644 Reviewed by Dan Bernstein.
9646 * WebLocalizableStrings.cpp:
9647 (mainBundleLocStrings):
9648 (frameworkLocStrings):
9649 Added these functions instead of file-scope variables.
9653 Updated to use the new functions.
9655 2009-10-19 Nate Chapin <japhet@chromium.org>
9657 Unreviewed, build fix.
9659 Update call to FrameLoader::urlSelected().
9661 * WebCoreSupport/WebContextMenuClient.cpp:
9662 (WebContextMenuClient::searchWithGoogle):
9664 2009-10-16 Steve Falkenburg <sfalken@apple.com>
9666 Reviewed by Dan Bernstein.
9668 https://bugs.webkit.org/show_bug.cgi?id=30456
9669 Fixes for new Debug_All Windows build configuration.
9671 * WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
9673 2009-10-16 Jon Honeycutt <jhoneycutt@apple.com>
9675 Add SPI to determine whether a plug-in has ever been halted.
9677 Part of <rdar://problem/7312158>.
9679 Reviewed by Dan Bernstein.
9681 * Interfaces/IWebViewPrivate.idl:
9682 Add hasPluginForNodeBeenHalted().
9685 (pluginViewForNode):
9686 Code factored out of isNodeHaltedPlugin().
9687 (WebView::isNodeHaltedPlugin):
9688 Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
9689 pluginViewForNode().
9690 (WebView::restartHaltedPluginForNode):
9692 (WebView::hasPluginForNodeBeenHalted):
9693 Get the PluginView for the given node. Return the result of
9694 PluginView::hasBeenHalted().
9697 Declare hasPluginForNodeBeenHalted().
9699 2009-10-16 Steve Falkenburg <sfalken@apple.com>
9701 Reviewed by Adam Roben.
9703 Add a Debug_All configuration to build entire stack as debug.
9704 Change Debug_Internal to:
9705 - stop using _debug suffix for all WebKit/Safari binaries
9706 - not use _debug as a DLL naming suffix
9707 - use non-debug C runtime lib.
9709 * WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
9710 * WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
9711 * WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
9712 * WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
9713 * WebKit.vcproj/WebKit.vcproj:
9714 Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
9715 Add Debug_All configuration.
9716 * WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
9718 2009-10-15 Jon Honeycutt <jhoneycutt@apple.com>
9720 Add SPI to restart a halted plug-in.
9722 Part of <rdar://problem/7273354> Halted plug-ins should restart on
9725 https://bugs.webkit.org/show_bug.cgi?id=30151
9727 Reviewed by Kevin Decker.
9729 * Interfaces/IWebViewPrivate.idl:
9730 Add restartHaltedPluginForNode().
9733 (WebView::restartHaltedPluginForNode):
9734 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
9735 WebCore::Node. Get the node's renderer, and check whether it is a
9736 RenderWidget. If so, get its Widget, and check whether it's a
9737 PluginView. If so, call PluginView::restart().
9740 Declare restartHaltedPluginForNode().
9742 2009-10-14 Jon Honeycutt <jhoneycutt@apple.com>
9744 Add SPI to determine whether a node is a halted plug-in.
9746 Part of <rdar://problem/7273354> Halted plug-ins should restart on
9749 https://bugs.webkit.org/show_bug.cgi?id=30151
9751 Reviewed by Darin Adler.
9753 * Interfaces/IWebViewPrivate.idl:
9754 Add isNodehaltedPlugin().
9757 (WebView::isNodeHaltedPlugin):
9758 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
9759 WebCore::Node. Get the node's renderer, and check whether it is a
9760 RenderWidget. If so, get its Widget, and check whether it's a
9761 PluginView. If so, return the result of PluginView::isHalted().
9764 Declare isNodeHaltedPlugin().
9766 2009-10-15 Daniel Bates <dbates@webkit.org>
9768 Reviewed by Adam Roben.
9770 https://bugs.webkit.org/show_bug.cgi?id=24731
9772 rdar://problem/5015961
9774 Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
9775 in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
9778 The WebView and WebDropSource drag-and-drop functions, as called by function
9779 DoDragDrop in its event loop, neither used the drop effect as specified by
9780 event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
9781 Instead, these functions defaulted to some hardcoded drop effect and set of
9782 allowed drop effects, respectively.
9784 Tests: fast/events/drag-and-drop.html
9786 * WebCoreSupport/WebDragClient.cpp:
9787 (WebDragClient::startDrag):
9788 * WebDropSource.cpp:
9789 (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
9790 into method WebDragClient::startDrag.
9793 (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
9794 appropriate drop effect from state of keyboard and allowed effects
9795 m_page->dragController()->sourceDragOperation().
9796 (WebView::DragEnter):
9797 (WebView::DragOver):
9801 2009-10-14 Adam Roben <aroben@apple.com>
9805 * WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
9806 IWebNavigationData from the build (they get #imported via WebKit.idl).
9808 2009-10-14 Brady Eidson <beidson@apple.com>
9810 Reviewed by Sam Weinig.
9812 WebKit Win API should provide a delegate interface for global history.
9813 https://bugs.webkit.org/show_bug.cgi?id=29905
9815 -Add IWebHistoryDelegate for clients to implement.
9816 -Add (I)WebNavigationData for the history delegate's use.
9817 -When it exists, call the history delegate instead of using WebHistory.
9819 * Interfaces/IWebHistoryDelegate.idl: Added.
9820 * Interfaces/IWebHistoryPrivate.idl:
9821 * Interfaces/IWebNavigationData.idl: Added.
9822 * Interfaces/IWebViewPrivate.idl:
9823 * Interfaces/WebKit.idl:
9825 * WebKit.vcproj/Interfaces.vcproj:
9826 * WebKit.vcproj/WebKit.vcproj:
9828 * WebCoreSupport/WebChromeClient.cpp:
9829 (WebChromeClient::populateVisitedLinks):
9830 * WebCoreSupport/WebFrameLoaderClient.cpp:
9831 (WebFrameLoaderClient::updateGlobalHistory):
9832 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
9833 (WebFrameLoaderClient::setTitle):
9837 (WebView::mainFrameURL):
9838 (WebView::setHistoryDelegate):
9839 (WebView::historyDelegate):
9840 (WebView::addVisitedLinks):
9844 (WebHistory::setVisitedLinkTrackingEnabled):
9845 (WebHistory::removeAllVisitedLinks):
9848 * WebNavigationData.cpp: Added.
9849 (WebNavigationData::QueryInterface):
9850 (WebNavigationData::AddRef):
9851 (WebNavigationData::Release):
9852 (WebNavigationData::WebNavigationData):
9853 (WebNavigationData::~WebNavigationData):
9854 (WebNavigationData::createInstance):
9855 (WebNavigationData::url):
9856 (WebNavigationData::title):
9857 (WebNavigationData::originalRequest):
9858 (WebNavigationData::response):
9859 (WebNavigationData::hasSubstituteData):
9860 (WebNavigationData::clientRedirectSource):
9861 * WebNavigationData.h: Added.
9863 2009-10-13 Dave Hyatt <hyatt@apple.com>
9865 Fix more WebView bustage.
9868 (WebView::addUserScriptToGroup):
9869 (WebView::addUserStyleSheetToGroup):
9870 (WebView::removeUserScriptsFromGroup):
9871 (WebView::removeUserStyleSheetsFromGroup):
9873 2009-10-13 Dave Hyatt <hyatt@apple.com>
9875 Fix build bustage on Windows.
9878 (WebView::addUserScriptToGroup):
9879 (WebView::addUserStyleSheetToGroup):
9880 (WebView::removeUserScriptsFromGroup):
9881 (WebView::removeUserStyleSheetsFromGroup):
9883 2009-10-13 Dave Hyatt <hyatt@apple.com>
9885 Reviewed by Adam Roben..
9887 Split removal functions for user scripts and stylehseets based on type.
9889 * Interfaces/IWebViewPrivate.idl:
9891 (WebView::removeUserScriptFromGroup):
9892 (WebView::removeUserStyleSheetFromGroup):
9895 2009-10-09 Adam Barth <abarth@webkit.org>
9897 Reviewed by Darin Adler.
9899 Factor HistoryController out of FrameLoader
9900 https://bugs.webkit.org/show_bug.cgi?id=30246
9905 (WebView::loadBackForwardListFromOtherView):
9907 2009-10-08 Jon Honeycutt <jhoneycutt@apple.com>
9909 Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
9910 for the existence of a PluginHalterDelegate.
9912 Reviewed by Dan Bernstein.
9914 * Interfaces/IWebPreferencesPrivate.idl:
9915 Remove the getter and setter.
9917 * WebCoreSupport/WebPluginHalterClient.cpp:
9918 (WebPluginHalterClient::enabled):
9919 Return true if the delegate exists.
9921 * WebCoreSupport/WebPluginHalterClient.h:
9922 Declare implementation of enabled().
9924 * WebPreferenceKeysPrivate.h:
9925 Removed the pref key.
9927 * WebPreferences.cpp:
9928 (WebPreferences::initializeDefaultSettings):
9929 Removed initialization of the pref.
9932 Removed declaration of the getter/setter.
9935 (WebView::notifyPreferencesChanged):
9936 Don't propagate the pref.
9938 2009-10-08 Adam Barth <abarth@webkit.org>
9940 Reviewed by Eric Seidel.
9942 Move executeScript from FrameLoader to ScriptController
9943 https://bugs.webkit.org/show_bug.cgi?id=30200
9948 (WebView::stringByEvaluatingJavaScriptFromString):
9950 2009-10-08 Anders Carlsson <andersca@apple.com>
9952 Reviewed by Sam Weinig.
9954 Remove the shouldLoadMediaElementURL implementation.
9956 * Interfaces/IWebPolicyDelegatePrivate.idl:
9957 * WebCoreSupport/WebFrameLoaderClient.cpp:
9958 (WebFrameLoaderClient::shouldUsePluginDocument):
9959 * WebCoreSupport/WebFrameLoaderClient.h:
9961 2009-10-08 Adam Roben <aroben@apple.com>
9963 Make IWebInspectorPrivate be accessed in a more standard way
9965 IWebViewPrivate::inspectorPrivate has been removed. Callers should
9966 instead use IWebViewPrivate::inspector and then use QueryInterface to
9967 get the IWebInspectorPrivate interface. This matches how our other COM
9970 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
9971 accessed in a more standard way
9973 Reviewed by John Sullivan and Tim Hatcher.
9975 * Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.
9978 (WebInspector::QueryInterface): Support querying to
9979 IWebInspectorPrivate.
9983 Removed inspectorPrivate.
9985 2009-10-08 Adam Roben <aroben@apple.com>
9987 Move the new IWebViewPrivate::inspectorPrivate function after all
9988 functions that existed when Safari 4.0.3 was released
9990 Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
9991 crashes in Safari.dll
9993 Reviewed by John Sullivan.
9995 * Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of
9996 the interface, so it won't modify the vtable that Safari 4.0.3 sees.
9998 2009-10-07 Adam Roben <aroben@apple.com>
10000 Expose origin whitelisting in the WebKit API on Windows
10002 Fixes <http://webkit.org/b/30185>.
10004 Reviewed by Eric Seidel.
10006 * Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and
10007 resetOriginAccessWhiteLists, to match the Mac SPI.
10010 (WebView::whiteListAccessFromOrigin):
10011 (WebView::resetOriginAccessWhiteLists):
10013 Added. These just call through to SecurityOrigin.
10015 2009-10-07 Adam Barth <abarth@webkit.org>
10017 Reviewed by Darin Adler.
10019 Factor PolicyChecker out of FrameLoader
10020 https://bugs.webkit.org/show_bug.cgi?id=30155
10022 Move the policy callback to the policy object.
10025 (WebFrame::dispatchWillSubmitForm):
10026 (WebFrame::receivedPolicyDecision):
10027 (WebFrame::dispatchDecidePolicyForMIMEType):
10028 (WebFrame::dispatchDecidePolicyForNewWindowAction):
10029 (WebFrame::dispatchDecidePolicyForNavigationAction):
10031 2009-10-07 Daniel Bates <dbates@webkit.org>
10033 Reviewed by Darin Adler.
10035 https://bugs.webkit.org/show_bug.cgi?id=30102
10037 <rdar://problem/5015957>
10039 Fixes an issue (in the Windows build) where the cursor does not change to the
10040 not-allowed cursor when the drag-and-drop operation is not allowed.
10042 The allowed effects in WebDragClient::startDrag are hard-coded to be
10043 DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
10044 allowed drop effects should be determined by the allowed operations of the
10047 We cannot test this using DRT because DRT looks at the programmatic drop
10048 cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
10049 That is, there is a discrepancy in the Windows build between the Windows API-based
10050 drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
10051 to determine the cursor, a manual test is needed.
10053 * WebCoreSupport/WebDragClient.cpp:
10054 (draggingSourceOperationMaskToDragCursors): Added method.
10055 (WebDragClient::startDrag):
10057 2009-10-07 Steve Falkenburg <sfalken@apple.com>
10059 Reviewed by Darin Adler.
10061 https://bugs.webkit.org/show_bug.cgi?id=30176
10062 <rdar://problem/7281553> Extra information in UA causes problems with gmail
10064 * WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
10066 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
10068 Reviewed by Timothy Hatcher.
10070 Web Inspector: default to an attached inspector window on Windows (as on Mac).
10072 https://bugs.webkit.org/show_bug.cgi?id=30134
10074 * WebCoreSupport/WebInspectorClient.cpp:
10075 (WebInspectorClient::showWindowWithoutNotifications):
10077 2009-10-06 Adam Barth <abarth@webkit.org>
10079 Reviewed by Eric Seidel.
10081 Move FrameLoader::canLoad to SecurityOrigin
10082 https://bugs.webkit.org/show_bug.cgi?id=30111
10085 (WebFrame::allowsFollowingLink):
10087 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
10089 Reviewed by Timothy Hatcher.
10091 Web Inspector: close inspector client view on
10092 InspectorController::close API call.
10094 In order to run batch web inspector layout tests (and not affect
10095 subsequent tests) we should close inspector client's view upon
10096 InspectorController::close API call.
10098 https://bugs.webkit.org/show_bug.cgi?id=30009
10100 * WebCoreSupport/WebInspectorClient.cpp:
10101 (WebInspectorClient::createPage):
10103 2009-10-06 David Levin <levin@chromium.org>
10105 Reviewed by NOBODY (windows build fix).
10107 Speculative build fix for windows (due to r49160).
10109 * WebDownloadCFNet.cpp:
10110 (WebDownload::initToResumeWithBundle):
10111 * WebIconDatabase.cpp:
10112 (WebIconDatabase::dispatchDidAddIconForPageURL):
10114 2009-10-05 Pavel Feldman <pfeldman@chromium.org>
10116 Reviewed by Timothy Hatcher.
10118 Web Inspector: add testing harness for Web Inspector.
10120 https://bugs.webkit.org/show_bug.cgi?id=30010
10122 * Interfaces/IWebInspectorPrivate.idl: Added.
10123 * Interfaces/IWebViewPrivate.idl:
10124 * Interfaces/WebKit.idl:
10125 * WebInspector.cpp:
10126 (WebInspector::evaluateInFrontend):
10129 (WebView::inspectorPrivate):
10132 2009-10-02 Dave Hyatt <hyatt@apple.com>
10134 Reviewed by Adam Roben.
10136 Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
10138 * Interfaces/IWebViewPrivate.idl:
10141 (WebView::addUserScriptToGroup):
10142 (WebView::addUserStyleSheetToGroup):
10145 2009-10-02 Steve Falkenburg <sfalken@apple.com>
10147 Reviewed by Mark Rowe.
10149 <https://bugs.webkit.org/show_bug.cgi?id=29989>
10150 Safari version number shouldn't be exposed in WebKit code
10152 For a WebKit version of 532.3.4:
10153 Product version is: 5.32.3.4 (was 4.0.3.0)
10154 File version is: 5.32.3.4 (was 4.532.3.4)
10156 * WebKit.vcproj/WebKit.rc:
10158 2009-09-30 Sam Weinig <sam@webkit.org>
10160 Reviewed by Dan Bernstein.
10162 Fix for <rdar://problem/7259706>
10163 Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
10165 * Interfaces/IWebFramePrivate.idl:
10167 (WebFrame::allowsFollowingLink):
10170 2009-09-30 Dave Hyatt <hyatt@apple.com>
10172 Reviewed by Adam Roben.
10174 Add the ability to remove user stylesheets and scripts by URL.
10176 * Interfaces/IWebViewPrivate.idl:
10178 (WebView::removeUserContentWithURLFromGroup):
10181 2009-09-29 Kenneth Russell <kbr@google.com>
10183 Reviewed by Dimitri Glazkov.
10185 Add support for run-time flag for 3D canvas
10186 https://bugs.webkit.org/show_bug.cgi?id=29826
10189 (WebView::notifyPreferencesChanged): Enable experimental WebGL
10190 flag when 3D_CANVAS is enabled in the build.
10192 2009-09-28 Alexey Proskuryakov <ap@apple.com>
10194 Reviewed by Darin Adler and Sam Weinig.
10196 Onclick not fired for an element copied with cloneContents() or cloneNode()
10197 https://bugs.webkit.org/show_bug.cgi?id=25130
10199 * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
10201 * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
10203 2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
10205 Reviewed by Eric Seidel.
10207 Add experimentalWebSocketsEnabled in WebPreferences.
10208 https://bugs.webkit.org/show_bug.cgi?id=28941
10210 * Interfaces/IWebPreferencesPrivate.idl:
10211 * WebPreferenceKeysPrivate.h:
10212 * WebPreferences.cpp:
10213 (WebPreferences::initializeDefaultSettings):
10214 (WebPreferences::setExperimentalWebSocketsEnabled):
10215 (WebPreferences::experimentalWebSocketsEnabled):
10216 * WebPreferences.h:
10218 (WebView::notifyPreferencesChanged):
10221 2009-09-25 Darin Adler <darin@apple.com>
10223 Reviewed by Steve Falkenburg.
10225 Speed up access to history items by caching date computation.
10227 * History/WebHistory.mm:
10228 (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
10229 Returns the beginning of the day that the passed time is within and
10230 the beginning of the next day.
10231 (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
10232 multiple dates within the same day, which is the common case.
10233 (dateKey): Added. Calls beginningOfDay and converts to an integer.
10234 (WebHistory::findKey): Changed to call dateKey instead of
10235 timeIntervalForBeginningOfDay.
10237 2009-09-25 Adam Roben <aroben@apple.com>
10239 Add SPI to invalidate a WebView's backing store
10241 This is useful in conjunction with
10242 IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
10243 delegate to force WebView to get its background redrawn.
10245 Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
10248 Reviewed by Anders Carlsson.
10250 * Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
10252 (WebView::invalidateBackingStore): If rect is 0, invalidate our whole
10253 client rect. Otherwise invalidate the intersection of rect with our
10257 2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
10259 Add a mechanism for automatically halting plug-ins.
10261 Reviewed by Oliver Hunt.
10263 * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
10264 for a delegate that determines whether plug-ins should be halted.
10266 * Interfaces/IWebPreferencesPrivate.idl:
10267 Declare functions to get and set the enabled state of the plug-in
10268 halter and the plug-in allowed run time.
10270 * Interfaces/IWebViewPrivate.idl:
10271 Declare functions to get and set the IWebPluginHalterDelegate.
10273 * Interfaces/WebKit.idl:
10275 * WebCoreSupport/WebPluginHalterClient.cpp: Added.
10276 (WebPluginHalterClient::WebPluginHalterClient):
10277 (WebPluginHalterClient::shouldHaltPlugin):
10278 Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
10279 DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
10280 If the call fails, return false. Otherwise, return the result of the
10283 * WebCoreSupport/WebPluginHalterClient.h: Added.
10285 * WebKit.vcproj/Interfaces.vcproj:
10286 Add IWebPluginHalterDelegate.idl.
10288 * WebKit.vcproj/WebKit.vcproj:
10289 Add WebPluginHalterClient.{h,cpp}.
10291 * WebPreferenceKeysPrivate.h:
10292 Define WebKitPluginHalterEnabledPreferenceKey and
10293 WebKitPluginAllowedRunTimePreferenceKey.
10295 * WebPreferences.cpp:
10296 (WebPreferences::initializeDefaultSettings):
10297 Leave plug-in halting disabled by default. Set the default value for
10298 the plug-in allowed run time to the max value of an unsigned int.
10299 (WebPreferences::setPluginHalterEnabled):
10300 (WebPreferences::pluginHalterEnabled):
10301 (WebPreferences::setPluginAllowedRunTime):
10302 (WebPreferences::pluginAllowedRunTime):
10304 * WebPreferences.h:
10308 Clear the IWebPluginHalterDelegate.
10309 (WebView::initWithFrame):
10310 Pass a WebPluginHalterClient when creating the Page.
10311 (WebView::notifyPreferencesChanged):
10312 Set the new settings when the preferences changed notification is
10314 (WebView::setPluginHalterDelegate):
10315 (WebView::pluginHalterDelegate):
10318 Declare overrides of setPluginHalterDelegate() and
10319 pluginHalterDelegate(). Added a member to track the
10320 IWebPluginHalterDelegate.
10322 2009-09-14 John Gregg <johnnyg@google.com>
10324 Reviewed by Eric Seidel.
10326 Enable switch for notifications (experimental) in Page Settings
10327 https://bugs.webkit.org/show_bug.cgi?id=28930
10329 Adds support for the experimentalNotificationsEnabled flag in Settings through
10330 WebPreferencesPrivate interface. Also cleans up some issues accessing the
10331 notification delegate through DumpRenderTree.
10333 * Interfaces/IWebPreferencesPrivate.idl:
10334 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
10335 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
10336 (WebDesktopNotificationsDelegate::notificationDelegate):
10337 * WebPreferenceKeysPrivate.h:
10338 * WebPreferences.cpp:
10339 (WebPreferences::initializeDefaultSettings):
10340 (WebPreferences::setExperimentalNotificationsEnabled):
10341 (WebPreferences::experimentalNotificationsEnabled):
10342 * WebPreferences.h:
10344 (WebView::notifyPreferencesChanged):
10346 2009-09-23 Anders Carlsson <andersca@apple.com>
10348 Reviewed by Adam Roben.
10350 <rdar://problem/7243354>
10351 REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers
10353 Check for a null IWebPolicyDelegatePrivate.
10355 * WebCoreSupport/WebFrameLoaderClient.cpp:
10356 (WebFrameLoaderClient::shouldLoadMediaElementURL):
10358 2009-09-22 Sam Weinig <sam@webkit.org>
10360 Rubber-stamped by Adam Roben.
10362 Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl
10364 * Interfaces/IWebFramePrivate.idl:
10366 2009-09-22 Sam Weinig <sam@webkit.org>
10368 Reviewed by Steve Falkenburg.
10370 Fix for <rdar://problem/6451745>
10371 Windows WebKit needs to implement reloadFromOrigin()
10373 * Interfaces/IWebFrame.idl:
10374 * Interfaces/IWebFramePrivate.idl:
10375 * Interfaces/IWebView.idl:
10377 (WebFrame::reloadFromOrigin):
10380 (WebView::reloadFromOrigin):
10383 2009-09-22 Adam Roben <aroben@apple.com>
10385 Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
10387 Fixes <http://webkit.org/b/29650> Crash in
10388 WebDownload::willSendRequest when using DefaultDownloadDelegate
10390 Reviewed by Brady Eidson.
10392 * DefaultDownloadDelegate.cpp:
10393 (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
10394 object we're returning via the finalRequest out-parameter.
10396 2009-09-21 Anders Carlsson <andersca@apple.com>
10398 Reviewed by Adam Roben.
10400 <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
10402 Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
10405 * Interfaces/IWebPolicyDelegatePrivate.idl: Added.
10406 * Interfaces/WebKit.idl:
10407 * WebCoreSupport/WebFrameLoaderClient.cpp:
10408 (WebFrameLoaderClient::shouldLoadMediaElementURL):
10409 * WebCoreSupport/WebFrameLoaderClient.h:
10410 * WebKit.vcproj/Interfaces.vcproj:
10412 2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
10414 Reviewed by Simon Hausmann.
10416 Make PlatformWindow return something else than PlatformWidget
10417 https://bugs.webkit.org/show_bug.cgi?id=29085
10419 Reflect the rename of platformWindow and it's return type.
10421 * AccessibleBase.cpp:
10422 (AccessibleBase::get_accParent):
10423 * WebCoreSupport/WebChromeClient.cpp:
10424 (WebChromeClient::platformPageClient):
10425 * WebCoreSupport/WebChromeClient.h:
10427 2009-09-17 Brian Weinstein <bweinstein@apple.com>
10429 Reviewed by Adam Roben.
10431 Remove assertions that were being hit by calls to
10432 m_verticalScrollbar->invalidate(). These assertions were valid,
10433 but they were causing tests to fail, so replacing with a FIXME
10434 until we can find out the real cause/solution that is being tracked
10435 by http://webkit.org/b/29350.
10438 (WebView::addToDirtyRegion):
10439 (WebView::paintIntoBackingStore):
10441 2009-09-17 Ada Chan <adachan@apple.com>
10443 Post WebViewDidChangeSelectionNotification when the text selection changes.
10445 Fixes <http://webkit.org/b/29321>
10447 Reviewed by Adam Roben.
10449 * Interfaces/IWebView.idl:
10450 * WebCoreSupport/WebEditorClient.cpp:
10451 (WebEditorClient::respondToChangedSelection):
10453 2009-09-17 Adam Roben <aroben@apple.com>
10455 Fix a crash when a WebView's HWND is destroyed before IWebView::close
10458 WebView's HWND was being sent a WM_TIMER message after the WebView was
10459 destroyed. This normally isn't possible (we call DestroyWindow inside
10460 WebView's destructor to ensure the HWND doesn't outlive the WebView),
10461 but r48060 changed WebView to call SetParent(m_viewWindow,
10462 HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
10463 HWND into some weird half-destroyed state where it can still receive
10466 Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
10467 (r48060): unrepro but frequent crash in WebViewWndProc
10469 Reviewed by Steve Falkenburg.
10472 (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
10473 before calling close(). This allows setHostWindow to detect that we're
10474 handling WM_DESTROY. No other code in close() cared whether
10475 isBeingDestroyed() was true or not.
10476 (WebView::setHostWindow): If our host window is being set to 0 and
10477 we're being destroyed, don't become a message-only window. Doing this
10478 while handling WM_DESTROY seems to lead to crashes.
10480 2009-09-16 Adam Roben <aroben@apple.com>
10482 Add a UI delegate callback to let the delegate draw a WebView's
10485 Fixes <http://webkit.org/b/29315>.
10487 Reviewed by Dave Hyatt.
10489 * Interfaces/IWebUIDelegatePrivate.idl: Added
10490 IWebUIDelegatePrivate2::drawBackground.
10493 (WebView::paintIntoBackingStore): After clearing or filling with
10494 white, let the delegate draw whatever background it wants. Also added
10495 an assertion that the dirty rect is within our bounds.
10497 2009-09-16 Adam Roben <aroben@apple.com>
10499 Prevent WebView from painting over sibling windows
10501 Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
10502 paint over sibling windows
10504 Reviewed by Darin Adler.
10507 (WebView::initWithFrame): Create the WebView's HWND with the
10508 WS_CLIPSIBLINGS style.
10510 2009-09-14 Brady Eidson <beidson@apple.com>
10512 Reviewed by Alexey Proskuryakov.
10514 Safari 4 cannot be used to update firmware on Linksys routers.
10515 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
10517 Adopt the new WebCore::CredentialStorage in WebKit/Win.
10519 * WebDownloadCFNet.cpp:
10520 (WebDownload::didReceiveAuthenticationChallenge):
10522 2009-09-11 Steve Falkenburg <sfalken@apple.com>
10524 Reviewed by Dan Bernstein.
10526 Properly propagate preference from WebPreferences to WebCore::Settings.
10527 https://bugs.webkit.org/show_bug.cgi?id=29192
10530 (WebView::initWithFrame): Apply setting when creating a new WebView.
10531 (WebView::notifyPreferencesChanged): Apply setting when preferences change.
10533 2009-09-11 Steve Falkenburg <sfalken@apple.com>
10535 Reviewed by Darin Adler.
10537 Allow WebKit clients to opt out of high resolution timers on Windows.
10538 https://bugs.webkit.org/show_bug.cgi?id=29192
10540 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
10541 Put this just after last 4.0.3 method for future merging.
10542 * Interfaces/WebKit.idl: Touched to force a rebuild.
10543 * WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
10544 * WebPreferences.cpp:
10545 (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
10546 (WebPreferences::setShouldUseHighResolutionTimers): Added.
10547 (WebPreferences::shouldUseHighResolutionTimers): Added.
10548 * WebPreferences.h: Added getter/setter.
10550 2009-09-11 Adam Roben <aroben@apple.com>
10552 Get user script/stylesheet tests running on Windows
10554 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
10557 Reviewed by John Sullivan.
10559 * Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
10560 addUserStyleSheetToGroup, removeUserContentFromGroup,
10561 removeAllUserContentFromGropu to match the Mac SPI.
10564 (WebView::addUserScriptToGroup):
10565 (WebView::addUserStyleSheetToGroup):
10566 (WebView::removeUserContentFromGroup):
10567 (WebView::removeAllUserContentFromGroup):
10569 Added. Implementation was based on similar methods in WebView.mm.
10571 2009-09-11 Jon Honeycutt <jhoneycutt@apple.com>
10573 Fix crash on launch on Windows.
10575 Rubber-stamped by Mark Rowe.
10577 * WebKit.vcproj/WebKit.vcproj:
10578 Define ENABLE_WEB_SOCKETS for all configurations.
10580 2009-09-07 Drew Wilson <atwilson@google.com>
10582 Reviewed by David Levin.
10584 Enable SHARED_WORKERS by default.
10585 https://bugs.webkit.org/show_bug.cgi?id=28959
10587 * WebKit.vcproj/WebKit.vcproj:
10589 2009-09-04 Adam Roben <aroben@apple.com>
10591 Make WebView function without a parent window
10593 When WebView has no parent window, it becomes a message-only window,
10594 which hides it from the screen and prevents it from appearing on the
10597 Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
10598 WebView::initWithFrame fails if there's no host window
10600 Reviewed by Dave Hyatt.
10603 (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
10604 our parent window, which will make us a message-only window.
10605 (WebView::setHostWindow): If he new host window is null, use
10606 HWND_MESSAGE as our parent window, which will make us a message-only
10609 2009-09-04 Adam Barth <abarth@webkit.org>
10611 Unreviewed attempt at a build fix.
10613 Added missing include.
10615 * WebCoreSupport/WebFrameLoaderClient.cpp:
10617 2009-09-04 Adam Barth <abarth@webkit.org>
10619 Unreviewed attempt at a build fix.
10621 Fix typo of IWebFrameLoadDelegatePrivate2 and make
10622 IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
10623 as requestd by Adam Roben.
10625 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
10626 * WebCoreSupport/WebFrameLoaderClient.cpp:
10627 (WebFrameLoaderClient::didDisplayInsecureContent):
10628 (WebFrameLoaderClient::didRunInsecureContent):
10630 2009-09-04 Adam Barth <abarth@webkit.org>
10632 Reviewed by Eric Seidel.
10634 https://bugs.webkit.org/show_bug.cgi?id=24696
10636 Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
10638 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
10639 * Interfaces/WebKit.idl:
10640 * WebCoreSupport/WebFrameLoaderClient.cpp:
10641 (WebFrameLoaderClient::didDisplayInsecureContent):
10642 (WebFrameLoaderClient::didRunInsecureContent):
10643 * WebKit.vcproj/Interfaces.vcproj:
10645 2009-09-03 Adam Barth <abarth@webkit.org>
10647 Reviewed by eric@webkit.org.
10649 https://bugs.webkit.org/show_bug.cgi?id=24696
10651 Stub implementations of mixed content methods of FrameLoaderClient.
10653 * WebCoreSupport/WebFrameLoaderClient.cpp:
10654 (WebFrameLoaderClient::didDisplayInsecureContent):
10655 (WebFrameLoaderClient::didRunInsecureContent):
10656 * WebCoreSupport/WebFrameLoaderClient.h:
10658 2009-09-01 Adam Roben <aroben@apple.com>
10660 Post a notification when a WebView is closing
10662 This is useful for situations where some code wants to react to the
10663 WebView closing but isn't in charge of the WebView and can't otherwise
10664 be notified. This notification could replace
10665 IWebUIDelegatePrivate::webViewClosing if we decide that the
10666 notification system isn't too burdensome.
10668 <http://webkit.org/b/28875>
10670 Reviewed by John Sullivan.
10672 * Interfaces/IWebViewPrivate.idl: Added the
10673 WebViewWillCloseNotification string constant.
10674 * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all
10675 configurations so that we can use _bstr_t.
10677 (WebView::close): Post the WebViewWillCloseNotification.
10679 2009-08-31 Alexey Proskuryakov <ap@webkit.org>
10681 Reviewed by Darin Adler.
10683 https://bugs.webkit.org/show_bug.cgi?id=28852
10684 Rename KURL single argument constructor to avoid confusion
10686 * WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change.
10688 2009-08-20 Adam Roben <aroben@apple.com>
10690 Give WebKit clients access to the window features specified in
10693 Reviewed by Steve Falkenburg.
10695 * COMVariantSetter.h: Added COMVariantSetters for bool and float.
10697 * Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,
10698 which contains a new version of createWebViewWithRequest that also
10699 passes the window features as an IPropertyBag. This is analagous to
10700 the -createWebViewWithRequest:windowFeatures: method added to
10701 WebUIDelegate on Mac in r27452. Also added key strings for use with
10702 the window features property bag.
10704 * WebCoreSupport/WebChromeClient.cpp:
10705 (createWindowFeaturesPropertyBag): Added this helper function to turn
10706 a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
10708 (WebChromeClient::createWindow): If the UI delegate implements
10709 IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
10710 that takes a window features property bag. If the delegate doesn't
10711 implement the new function, fall back to the old functions.
10713 2009-08-20 Adam Roben <aroben@apple.com>
10715 A little clean-up in WebChromeClient::createWindow
10717 Reviewed by Steve Falkenburg.
10719 * WebCoreSupport/WebChromeClient.cpp:
10720 (WebChromeClient::createWindow): Refactored to share more code between
10721 the dialog and non-dialog cases.
10723 2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
10725 Reviewed by Holger Freyther.
10727 https://bugs.webkit.org/show_bug.cgi?id=25889
10728 [GTK] scrollbar policy for main frame is not implementable
10730 Add empty implementation for new ChromeClient method.
10732 * WebCoreSupport/WebChromeClient.h:
10733 (WebChromeClient::scrollbarsModeDidChange):
10735 2009-08-27 Brent Fulgham <bfulgham@webkit.org>
10737 Reviewed by Adam Roben.
10739 Modify Release_Cairo target to build testapi using the
10740 Release_CFLite target so that the correct CoreFoundation
10741 (in this case, CFLite.dll) is linked.
10743 * WebKit.vcproj/WebKit.sln:
10745 2009-08-26 Adam Barth <abarth@webkit.org>
10747 Reviewed by Oliver Hunt.
10749 Don't let local files access web URLs
10750 https://bugs.webkit.org/show_bug.cgi?id=28480
10752 * WebPreferences.cpp:
10753 (WebPreferences::initializeDefaultSettings):
10755 2009-08-26 David Levin <levin@chromium.org>
10757 Reviewed by Darin Fisher.
10759 ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
10760 https://bugs.webkit.org/show_bug.cgi?id=28735
10762 * WebMutableURLRequest.cpp:
10763 (WebMutableURLRequest::setHTTPShouldHandleCookies):
10765 2009-08-25 Eric Carlson <eric.carlson@apple.com>
10767 Reviewed by Oliver Hunt.
10769 <video> and <audio> controller should be accessible
10770 https://bugs.webkit.org/show_bug.cgi?id=28081
10772 * WebCoreLocalizedStrings.cpp:
10773 (WebCore::localizedMediaControlElementString):
10774 (WebCore::localizedMediaControlElementHelpText):
10775 (WebCore::localizedMediaTimeDescription):
10778 2009-08-25 Brent Fulgham <bfulgham@webkit.org>
10780 Build fix for Windows.
10782 Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
10783 DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
10784 settings so they link against the proper libraries.
10786 * WebKit.vcproj/WebKit.sln:
10788 2009-08-25 David Levin <levin@chromium.org>
10790 Reviewed by Adam Roben.
10792 PLATFORM(CFNETWORK) should be USE(CFNETWORK).
10793 https://bugs.webkit.org/show_bug.cgi?id=28713
10795 Also, moved the #if header section after the other #includes.
10798 (WebError::localizedDescription):
10800 2009-08-24 Brent Fulgham <bfulgham@webkit.org>
10802 Reviewed by Steve Falkenburg.
10804 Revise CFLite Debug build to emit DLL's with _debug label.
10805 https://bugs.webkit.org/show_bug.cgi?id=28695.
10807 * WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to
10808 inherit from new debug_wincairo property sheet, instead of
10809 the current debug sheet.
10811 2009-08-22 Adam Barth <abarth@webkit.org>
10813 Revert 47684. We're going to do this later once clients have had a
10814 chance to opt into the setting they like.
10816 * WebPreferences.cpp:
10817 (WebPreferences::initializeDefaultSettings):
10819 2009-08-22 Adam Barth <abarth@webkit.org>
10821 Reviewed by Eric Seidel.
10823 Don't let local files access web URLs
10824 https://bugs.webkit.org/show_bug.cgi?id=28480
10826 * WebPreferences.cpp:
10827 (WebPreferences::initializeDefaultSettings):
10829 2009-08-20 Brian Weinstein <bweinstein@apple.com>
10831 Reviewed by Adam Roben.
10833 Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps.
10835 Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel,
10836 and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event.
10837 One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but
10838 this is tracked in <http://webkit.org/b/28237>.
10841 (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on.
10842 (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively.
10845 2009-08-18 Brian Weinstein <bweinstein@apple.com>
10847 Reviewed by Oliver Hunt.
10849 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
10850 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
10852 Added a setQuota interface method to IWebDatabaseManager and implemented it.
10854 * Interfaces/IWebDatabaseManager.idl:
10855 * WebDatabaseManager.cpp:
10856 (WebDatabaseManager::setQuota):
10857 * WebDatabaseManager.h:
10859 2009-08-18 Drew Wilson <atwilson@google.com>
10861 Unreviewed (build break).
10863 Added missing include for WebWorkersPrivate.h.
10865 * WebKitClassFactory.cpp:
10867 2009-08-18 Peter Kasting <pkasting@google.com>
10869 Reviewed by Eric Seidel.
10871 https://bugs.webkit.org/show_bug.cgi?id=28415
10872 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
10875 * WebKit.vcproj/InterfacesGenerated.vcproj:
10877 2009-08-18 Drew Wilson <atwilson@google.com>
10879 Reviewed by Eric Seidel.
10881 Need to extend DumpRenderTree to expose number of worker threads
10882 https://bugs.webkit.org/show_bug.cgi?id=28292
10884 Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
10886 * ForEachCoClass.h:
10887 Added WebWorkersPrivate.
10888 * Interfaces/IWebWorkersPrivate.idl: Added.
10889 * Interfaces/WebKit.idl:
10890 Added WebWorkersPrivate.
10891 * WebKit.vcproj/Interfaces.vcproj:
10892 * WebKit.vcproj/WebKit.vcproj:
10893 * WebWorkersPrivate.cpp: Added.
10894 Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
10895 (WebWorkersPrivate::QueryInterface):
10896 (WebWorkersPrivate::AddRef):
10897 (WebWorkersPrivate::Release):
10898 (WebWorkersPrivate::workerThreadCount):
10899 (WebWorkersPrivate::createInstance):
10900 (WebWorkersPrivate::WebWorkersPrivate):
10901 (WebWorkersPrivate::~WebWorkersPrivate):
10902 * WebWorkersPrivate.h: Added.
10904 2009-08-17 Peter Kasting <pkasting@google.com>
10906 Reviewed by Steve Falkenburg.
10908 https://bugs.webkit.org/show_bug.cgi?id=27323
10909 Only add Cygwin to the path when it isn't already there. This avoids
10910 causing problems for people who purposefully have non-Cygwin versions of
10911 executables like svn in front of the Cygwin ones in their paths.
10913 * WebKit.vcproj/Interfaces.vcproj:
10914 * WebKit.vcproj/InterfacesGenerated.vcproj:
10915 * WebKit.vcproj/WebKit.vcproj:
10916 * WebKit.vcproj/WebKitGUID.vcproj:
10918 2009-08-17 Simon Fraser <simon.fraser@apple.com>
10920 Speculative fix for Windows build bustage.
10922 * DOMHTMLClasses.cpp:
10923 (DOMHTMLElement::idName):
10925 2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
10927 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
10930 https://bugs.webkit.org/show_bug.cgi?id=20866
10932 Reviewed by Oliver Hunt.
10934 * AccessibleBase.cpp:
10935 (AccessibleBase::getAccessibilityObjectForChild):
10936 If the child ID is negative, negate it and treat it as an AXID.
10938 2009-08-12 Brian Weinstein <bweinstein@apple.com>
10940 Reviewed by Adam Roben.
10942 Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
10943 list detaches drop down.
10945 Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
10946 the popup (matches other browser behavior).
10949 (WebView::mouseWheel):
10951 2009-08-12 Adam Roben <aroben@apple.com>
10953 Make WebPreferenceKeysPrivate.h available for client use
10955 Reviewed by Dave Hyatt.
10957 Fixes <http://webkit.org/b/28227>.
10959 * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
10960 $WebKitOutputDir, just like we do for a few other headers. Also let VS
10961 reorder some XML attributes.
10963 * WebPreferenceKeysPrivate.h: Touched this file to force a build.
10965 2009-08-11 Adam Roben <aroben@apple.com>
10967 Remove support for a window resizer within the WebView
10969 Starting with Safari 4, there is never a window resizer inside the
10970 WebView, so we no longer need to support that functionality.
10972 Fixes <http://webkit.org/b/28190> Remove support for a window resizer
10975 Reviewed by Dave Hyatt.
10977 * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
10978 functions related to the window resizer with unused*() functions. We
10979 can't remove them entirely because we need to keep the vtable
10980 unchanged so new versions of WebKit will work with old versions of
10981 Safari (e.g., for nightlies and WebKit development).
10983 * WebCoreSupport/WebChromeClient.cpp:
10984 (WebChromeClient::windowResizerRect): Now always returns an empty
10989 (WebView::handleMouseEvent):
10991 Removed window-resizer-related code.
10993 2009-08-11 John Gregg <johnnyg@google.com>
10995 Reviewed by Maciej Stachowiak.
10997 Move the accessor for notifications presenter from WebUIDelegate
10998 to WebUIDelegate2 which extends it. When making this call from
10999 WebCoreSupport, check using QueryInterface before calling.
11001 https://bugs.webkit.org/show_bug.cgi?id=28198
11003 * Interfaces/IWebUIDelegate.idl:
11004 * Interfaces/IWebUIDelegate2.idl: Added.
11005 * Interfaces/WebKit.idl:
11006 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
11007 (WebDesktopNotificationsDelegate::show):
11008 (WebDesktopNotificationsDelegate::cancel):
11009 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
11010 (WebDesktopNotificationsDelegate::requestPermission):
11011 (WebDesktopNotificationsDelegate::checkPermission):
11012 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
11013 (WebDesktopNotificationsDelegate::notificationDelegate):
11014 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
11016 2009-08-11 Drew Wilson <atwilson@google.com>
11018 Reviewed by NOBODY (build break).
11020 Speculative Windows build fix - undo previous unnecessary change.
11022 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
11024 2009-08-11 Brian Weinstein <bweinstein@apple.com>
11026 Reviewed by Steve Falkenburg.
11028 Refactored MIMETypeforExtension to be a member of IWebViewPrivate
11029 instead of IWebView.
11031 * Interfaces/IWebView.idl:
11032 * Interfaces/IWebViewPrivate.idl:
11034 (WebView::MIMETypeForExtension):
11037 2009-08-11 Drew Wilson <atwilson@google.com>
11039 Reviewed by NOBODY (build break)
11041 Speculative fix for windows build break.
11043 * WebKitSupport/WebDesktopNotificationsDelegate.h:
11044 WebCore/Notification*.h => WebCore/notifications/Notification*.h
11046 2009-08-11 John Gregg <johnnyg@google.com>
11048 Reviewed by Maciej Stachowiak.
11050 Desktop Notifications API
11051 https://bugs.webkit.org/show_bug.cgi?id=25643
11053 Adds test hooks for notification features to WebCoreSupport for
11054 use in DumpRenderTree.
11056 * Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
11057 * Interfaces/IWebUIDelegate.idl:
11058 * Interfaces/WebKit.idl:
11059 * WebCoreSupport/WebChromeClient.cpp:
11060 (WebChromeClient::WebChromeClient):
11061 * WebCoreSupport/WebChromeClient.h:
11062 (WebChromeClient::notificationPresenter):
11063 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
11064 (NotificationCOMWrapper::create):
11065 (NotificationCOMWrapper::NotificationCOMWrapper):
11066 (NotificationCOMWrapper::QueryInterface):
11067 (NotificationCOMWrapper::AddRef):
11068 (NotificationCOMWrapper::Release):
11069 (NotificationCOMWrapper::isHTML):
11070 (NotificationCOMWrapper::contentsURL):
11071 (NotificationCOMWrapper::iconURL):
11072 (NotificationCOMWrapper::title):
11073 (NotificationCOMWrapper::text):
11074 (NotificationCOMWrapper::notifyDisplay):
11075 (NotificationCOMWrapper::notifyError):
11076 (NotificationCOMWrapper::notifyClose):
11077 (WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
11078 (WebDesktopNotificationsDelegate::show):
11079 (WebDesktopNotificationsDelegate::cancel):
11080 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
11081 (WebDesktopNotificationsDelegate::requestPermission):
11082 (WebDesktopNotificationsDelegate::checkPermission):
11083 (WebDesktopNotificationsDelegate::notificationDelegate):
11084 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
11085 * WebCoreSupport/WebInspectorDelegate.h:
11086 (WebInspectorDelegate::desktopNotificationsDelegate):
11087 * WebKit.vcproj/Interfaces.vcproj:
11088 * WebKit.vcproj/WebKit.vcproj:
11090 2009-08-11 Brian Weinstein <bweinstein@apple.com>
11092 Reviewed by Adam Roben.
11094 Fix of <rdar://5016504> SVG file cannot be dragged to webview,
11095 but can be opened via Open File.
11097 Added a new function to IWebView that gets the MIME type for a given
11098 extension from the MIMETypeRegistry.
11100 * Interfaces/IWebView.idl:
11102 (WebView::MIMETypeForExtension):
11105 2009-08-11 Dmitry Titov <dimich@chromium.org>
11107 Reviewed by Adam Roben.
11109 Originally implemented by Glenn Wilson <gwilson@chromium.org>.
11111 Added support for overriding default preferences per-test.
11112 See https://bugs.webkit.org/show_bug.cgi?id=20534
11114 * Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
11115 * WebPreferences.cpp: same.
11116 * WebPreferences.h: same.
11118 2009-08-10 Dan Bernstein <mitz@apple.com>
11120 Reviewed by Darin Adler.
11122 Link drag images specify Lucida Grande on Windows and end up using Times
11124 <rdar://problem/7117835>
11126 * WebCoreSupport/WebDragClient.cpp:
11127 (dragLabelFont): Added a RenderingMode parameter and changed to use the
11128 same typeface as the Windows small caption font.
11129 (WebDragClient::createDragImageForLink): Changed to respect the
11130 page’s rendering mode.
11132 2009-08-10 Brent Fulgham <bfulgham@webkit.org>
11134 Reviewed by Adam Roben.
11136 https://bugs.webkit.org/show_bug.cgi?id=28048.
11137 Move various WinCairo build settings into *.vsprops file.
11139 * WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet
11140 (which contains link settings for cURL and its dependencies), and
11141 remove the corresponding entries from the vcproj file. Remove
11142 png, jpeg, cairo library linking flags from vcproj, now that they
11143 are in the WinCairo.vsprops file.
11145 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
11147 Reviewed by George Staikos.
11149 [WML] Deck access control is completly broken
11150 https://bugs.webkit.org/show_bug.cgi?id=27721
11152 Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
11154 * Interfaces/IWebFramePrivate.idl:
11156 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
11158 Reviewed by Maciej Stachowiak.
11160 FrameLoadType / WebFrameLoadType enums are out of sync
11161 https://bugs.webkit.org/show_bug.cgi?id=28132
11163 Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value)
11165 * Interfaces/IWebFramePrivate.idl:
11167 2009-08-06 Adam Barth <abarth@webkit.org>
11171 http://bugs.webkit.org/show_bug.cgi?id=27879
11173 Revert 46877 because it broke GTK.
11175 * COMPropertyBag.h:
11177 2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
11179 Reviewed by Adam Barth.
11181 Change Noncopyable inheriting to public
11182 http://bugs.webkit.org/show_bug.cgi?id=27879
11184 Since Noncopyable is inherited from FastAllocBase,
11185 Noncopyable's inheriting has been changed to public.
11187 * COMPropertyBag.h:
11189 2009-08-04 Alice Liu <alice.liu@apple.com>
11191 "Shift + Enter" should behave like "Enter" in editable fields.
11192 Affects backward search in find-in-page in Safari for Windows
11194 Reviewed by Jon Honeycutt.
11197 Register shift+enter as InsertNewline command, similar to other
11198 modifier+Enter combinations.
11200 2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
11202 Part of <rdar://problem/5698113> Safari shouldn't auto-activate
11203 plug-ins in background tabs (make Win consistent with Mac)
11205 https://bugs.webkit.org/show_bug.cgi?id=27855
11207 Reviewed by Adam Roben and Anders Carlsson.
11209 * Interfaces/IWebViewPrivate.idl:
11210 Add setCanStartPlugins().
11212 * WebCoreSupport/WebFrameLoaderClient.cpp:
11213 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
11214 Added; code moved from createPlugin(). Modified to obtain the plug-in's
11215 page URL, the plug-ins "plug-ins page" parameter value, and the
11216 plug-in's MIME type by calling getter functions on the passed
11218 (WebFrameLoaderClient::createPlugin):
11219 If the plug-in status is not "success," call
11220 dispatchDidFailToStartPlugin().
11222 * WebCoreSupport/WebFrameLoaderClient.h:
11223 Declare an override of dispatchDidFailToStartPlugin().
11227 Add a missing ) to a comment.
11228 (WebView::setCanStartPlugins):
11229 Call the Page's setCanStartPlugins() function.
11233 2009-07-30 Darin Adler <darin@apple.com>
11235 Reviewed by David Levin.
11237 Use checked casts for render tree
11238 https://bugs.webkit.org/show_bug.cgi?id=23522
11240 * DOMHTMLClasses.cpp:
11241 (DOMHTMLInputElement::isUserEdited):
11242 (DOMHTMLTextAreaElement::isUserEdited):
11245 2009-07-31 Anders Carlsson <andersca@apple.com>
11247 Reviewed by Dan Bernstein.
11249 -Fix <rdar://problem/7104097>
11251 Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
11253 * WebCoreSupport/EmbeddedWidget.cpp:
11254 (EmbeddedWidget::create):
11255 * WebCoreSupport/EmbeddedWidget.h:
11257 2009-07-29 Brian Weinstein <bweinstein@apple.com>
11259 Was doing the build fix wrong, NotImplemented.h is in WebCore.
11261 * WebCoreSupport/WebInspectorClient.cpp:
11263 2009-07-29 Brian Weinstein <bweinstein@apple.com>
11267 * WebCoreSupport/WebInspectorClient.cpp:
11269 2009-07-29 Kevin McCullough <kmccullough@apple.com>
11271 Reviewed by Darin Adler.
11273 Added foundation work to allow a testing infrastructure for the Web
11276 * WebCoreSupport/WebInspectorClient.cpp:
11277 (WebInspectorClient::inspectorWindowObjectCleared): Empty definition
11278 to let Windows compile but we should implement this at some point so
11279 that the tests can be run on Windows too.
11280 * WebCoreSupport/WebInspectorClient.h:
11282 2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
11284 Reviewed by Steve Falkenburg.
11286 Add output directory for VS pre-build steps to enable out-of-tree builds
11288 https://bugs.webkit.org/show_bug.cgi?id=27700
11290 The tmp.obj file is now placed in the intermediate build directory.
11292 * WebKit.vcproj/WebKit.vcproj:
11294 2009-07-27 Brian Weinstein <bweinstein@apple.com>
11296 Build fix for Windows.
11299 (WebView::stringByEvaluatingJavaScriptFromString):
11301 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
11303 Reviewed by Darin Adler.
11305 https://bugs.webkit.org/show_bug.cgi?id=27735
11306 Give a helpful name to JSLock constructor argument
11308 * WebCoreStatistics.cpp:
11309 (WebCoreStatistics::javaScriptObjectsCount):
11310 (WebCoreStatistics::javaScriptGlobalObjectsCount):
11311 (WebCoreStatistics::javaScriptProtectedObjectsCount):
11312 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
11313 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
11314 * WebJavaScriptCollector.cpp:
11315 (WebJavaScriptCollector::objectCount):
11317 (WebView::stringByEvaluatingJavaScriptFromString):
11319 2009-07-25 Kwang Yul Seo <skyul@company100.net>
11321 Reviewed by Darin Adler.
11323 Windows build break due to warning C4819
11324 https://bugs.webkit.org/show_bug.cgi?id=27416
11326 Disable C4819 warning to fix build.
11328 * WebKit.vcproj/WebKit.vcproj:
11330 2009-07-24 Brent Fulgham <bfulgham@webkit.org>
11332 Reviewed by Dave Hyatt.
11334 Clean up dependencies on Apple support libraries for non-Apple build.
11335 http://bugs.webkit.org/show_bug.cgi?id=27532.
11337 * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
11338 * WebDownload.h: Conditionalize include of CFNetwork.h
11339 * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
11341 2009-07-24 Andrei Popescu <andreip@google.com>
11343 Reviewed by Anders Carlsson.
11345 ApplicationCache should have size limit
11346 https://bugs.webkit.org/show_bug.cgi?id=22700
11348 * WebCoreSupport/WebChromeClient.cpp:
11349 (WebChromeClient::reachedMaxAppCacheSize):
11350 Adds empty implementation of the reachedMaxAppCacheSize callback.
11351 * WebCoreSupport/WebChromeClient.h:
11353 2009-07-23 Brady Eidson <beidson@apple.com>
11355 Reviewed by Geoff Garen.
11357 WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
11358 https://bugs.webkit.org/show_bug.cgi?id=27595
11360 * WebCoreSupport/WebFrameLoaderClient.cpp:
11361 (WebFrameLoaderClient::dispatchWillSendRequest):
11363 2009-07-22 Takeshi Yoshino <tyoshino@google.com>
11365 Reviewed by Darin Adler.
11367 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
11368 https://bugs.webkit.org/show_bug.cgi?id=26375
11370 Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
11371 with hex escape sequences.
11373 VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
11374 treated as an error and stopped build).
11376 WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
11377 represented in the current code page (932). Save the file in Unicode format to prevent data loss
11379 A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
11380 localized string generation process.
11382 * WebCoreLocalizedStrings.cpp:
11383 (WebCore::imageTitle):
11385 2009-07-21 Roland Steiner <rolandsteiner@google.com>
11387 Reviewed by David Levin.
11389 Add ENABLE_RUBY to list of build options
11390 https://bugs.webkit.org/show_bug.cgi?id=27324
11392 * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.
11394 2009-07-20 Peter Kasting <pkasting@google.com>
11396 Reviewed by Mark Rowe.
11398 https://bugs.webkit.org/show_bug.cgi?id=27468
11399 Back out r46060, which caused problems for some Apple developers.
11401 * WebKit.vcproj/Interfaces.vcproj:
11402 * WebKit.vcproj/InterfacesGenerated.vcproj:
11403 * WebKit.vcproj/WebKit.vcproj:
11404 * WebKit.vcproj/WebKitGUID.vcproj:
11406 2009-07-17 Brian Weinstein <bweinstein@apple.com>
11408 Reviewed by Adam Roben.
11410 Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
11411 https://bugs.webkit.org/show_bug.cgi?id=14272
11413 Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
11414 to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
11415 in InspectorController.cpp to remember user's preferred height.
11417 * WebCoreSupport/WebInspectorClient.cpp:
11419 2009-07-17 Peter Kasting <pkasting@google.com>
11421 Reviewed by Steve Falkenburg.
11423 https://bugs.webkit.org/show_bug.cgi?id=27323
11424 Only add Cygwin to the path when it isn't already there. This avoids
11425 causing problems for people who purposefully have non-Cygwin versions of
11426 executables like svn in front of the Cygwin ones in their paths.
11428 * WebKit.vcproj/Interfaces.vcproj:
11429 * WebKit.vcproj/InterfacesGenerated.vcproj:
11430 * WebKit.vcproj/WebKit.vcproj:
11431 * WebKit.vcproj/WebKitGUID.vcproj:
11433 2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
11435 Reviewed by David Levin.
11437 Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
11438 https://bugs.webkit.org/show_bug.cgi?id=27206
11440 Add ENABLE_WEB_SOCKETS
11442 * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS
11444 2009-07-16 Xiaomei Ji <xji@chromium.org>
11446 Reviewed by Darin Adler.
11448 Fix tooltip does not get its directionality from its element's directionality.
11449 https://bugs.webkit.org/show_bug.cgi?id=24187
11451 Per mitz's suggestion in comment #6, while getting the plain-text
11452 title, we also get the directionality of the title. How to handle
11453 the directionality is up to clients. Clients could ignore it,
11454 or use attribute or unicode control characters to display the title
11457 * WebCoreSupport/WebChromeClient.cpp:
11458 (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
11459 * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
11460 * WebElementPropertyBag.cpp:
11461 (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
11463 2009-07-15 Darin Adler <darin@apple.com>
11465 Reviewed by Sam Weinig.
11467 Renamed parseURL to deprecatedParseURL.
11469 * WebCoreSupport/WebFrameLoaderClient.cpp:
11470 (WebFrameLoaderClient::createPlugin): Renamed.
11472 2009-07-14 Steve Falkenburg <sfalken@apple.com>
11474 Reorganize JavaScriptCore headers into:
11475 API: include/JavaScriptCore/
11476 Private: include/private/JavaScriptCore/
11478 Reviewed by Darin Adler.
11480 * WebKit.vcproj/WebKit.vcproj:
11482 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
11484 Reviewed by Darin Adler.
11486 Change all Noncopyable inheriting visibility to public.
11487 https://bugs.webkit.org/show_bug.cgi?id=27225
11489 Change all Noncopyable inheriting visibility to public because
11490 it is needed to the custom allocation framework (bug #20422).
11492 * COMEnumVariant.h:
11493 * WebDatabaseManager.cpp:
11495 * WebLocalizableStrings.cpp:
11497 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
11499 Reviewed by Adam Roben.
11501 Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
11502 https://bugs.webkit.org/show_bug.cgi?id=27240.
11505 (WebFrame::printHeader): New shared method to print the header.
11506 (WebFrame::printFooter): New shared method to print the footer.
11507 (WebFrame::spoolPage): New conditionally-compiled method to print
11509 (WebFrame::spoolPages): Revised to call the platform-specific spoolPage
11511 * WebFrame.h: Add new method prototypes.
11513 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
11515 Reviewed by Adam Roben.
11517 Add new configuration flag for redistributable Windows build.
11518 https://bugs.webkit.org/show_bug.cgi=27087
11520 * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
11521 Debug_Cairo and Release_Cairo targets.
11523 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
11525 Speculative Windows build fix after http://trac.webkit.org/changeset/45786.
11527 * WebCoreSupport/WebChromeClient.cpp:
11528 (WebChromeClient::addMessageToConsole):
11530 2009-07-10 Adam Barth <abarth@webkit.org>
11532 Reviewed by Sam Weinig with the power of Grayskull.
11534 Enable XSSAuditor by default.
11536 * WebPreferences.cpp:
11537 (WebPreferences::initializeDefaultSettings):
11539 2009-07-09 Drew Wilson <atwilson@google.com>
11541 Reviewed by Alexey Proskuryakov.
11543 https://bugs.webkit.org/show_bug.cgi?id=26903
11545 Turned on CHANNEL_MESSAGING by default because the MessageChannel API
11546 can now be implemented for Web Workers and is reasonably stable.
11548 * WebKit.vcproj/WebKit.vcproj:
11550 2009-07-09 Brian Weinstein <bweinstein@apple.com>
11552 Reviewed by Alice Liu.
11554 Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
11555 https://bugs.webkit.org/show_bug.cgi?id=27140
11557 Added a preference key to remember whether the user prefers the inspector detached or attached.
11559 * WebCoreSupport/WebInspectorClient.cpp:
11560 (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible
11561 (WebInspectorClient::closeWindow): Ditto
11562 (WebInspectorClient::attachWindow): Set preference to attached windows here
11563 (WebInspectorClient::detachWindow): Set preference to detached windows here
11564 (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached
11565 (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
11567 2009-07-09 Alexey Proskuryakov <ap@webkit.org>
11569 Reviewed by Oliver Hunt.
11571 <rdar://problem/6921671> Visit count shouldn't be incremented by redirects.
11573 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
11574 Do not increase visit count if there is a redirect source. As a result, only pages that were
11575 explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking
11576 a link) will be counted.
11578 * Interfaces/IWebHistoryItemPrivate.idl:
11580 (WebHistory::visitedURL):
11582 * WebHistoryItem.cpp:
11583 (WebHistoryItem::visitedWithTitle):
11584 * WebHistoryItem.h:
11585 Marshal this new argument all the way down to WebCore.
11587 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
11589 Reviewed by Dave Hyatt.
11591 Make Widget RefCounted to fix:
11593 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
11594 at WebCore::Widget::afterMouseDown() after clicking To Do's close
11596 <rdar://problem/6978804> WER #16: Repro Access Violation in
11597 WebCore::PluginView::bindingInstance (1310178023)
11599 <rdar://problem/6991251> WER #13: Crash in WebKit!
11600 WebCore::PluginView::performRequest+203 (1311461169)
11602 * WebCoreSupport/WebFrameLoaderClient.cpp:
11603 (WebFrameLoaderClient::createPlugin):
11604 * WebCoreSupport/WebFrameLoaderClient.h:
11606 (WebFrame::createJavaAppletWidget):
11609 2009-07-09 Sam Weinig <sam@webkit.org>
11611 Reviewed by Steve Falkenburg.
11613 Roll out r43848. The quirk is no longer necessary.
11616 (WebView::userAgentForKURL):
11618 2009-07-07 Ada Chan <adachan@apple.com>
11620 Reviewed by Dave Hyatt.
11622 Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
11623 https://bugs.webkit.org/show_bug.cgi?id=27057
11628 2009-07-02 Erik Arvidsson <arv@chromium.org>
11630 Reviewed by Adam Roben.
11632 [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
11633 https://bugs.webkit.org/show_bug.cgi?id=26699
11635 * WebDropSource.cpp:
11636 (WebDropSource::QueryContinueDrag):
11638 2009-07-02 Oliver Hunt <oliver@apple.com>
11640 Reviewed by Anders Carlsson.
11642 <rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
11643 <https://bugs.webkit.org/show_bug.cgi?id=26670>
11645 Make windows loader client match mac behaviour more closely.
11647 * WebCoreSupport/WebFrameLoaderClient.cpp:
11648 (WebFrameLoaderClient::forceLayout):
11650 2009-06-30 Brent Fulgham <bfulgham@gmail.com>
11652 Reviewed by Adam Roben.
11654 Build DumpRenderTree under Cairo.
11655 https://bugs.webkit.org/show_bug.cgi?id=26457
11657 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the
11658 DumpRenderTree build, and use the in the Debug_Cairo
11659 and Release_Cairo targets.
11661 2009-07-02 Eric Carlson <eric.carlson@apple.com>
11663 Fix Windows build by including missing localized string methods.
11665 * WebCoreLocalizedStrings.cpp:
11666 (WebCore::mediaElementLoadingStateText):
11667 (WebCore::mediaElementLiveBroadcastStateText):
11669 2009-07-01 David Hyatt <hyatt@apple.com>
11671 Reviewed by Tim Hatcher.
11673 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
11674 even though the field is not actually focused for keyboard input
11676 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
11677 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
11683 2009-06-29 David Hyatt <hyatt@apple.com>
11685 Fix Windows bustage. Missed two configurations for enabling DATAGRID.
11687 * WebKit.vcproj/WebKit.vcproj:
11689 2009-06-29 Jessie Berlin <jberlin@apple.com>
11691 Reviewed by Adam Roben.
11693 Fix the windows build.
11695 * WebCoreSupport/WebContextMenuClient.cpp:
11696 (WebContextMenuClient::isSpeaking):
11697 * WebCoreSupport/WebContextMenuClient.h:
11699 2009-06-29 David Hyatt <hyatt@apple.com>
11701 Reviewed by Adam Roben.
11703 Make sure to patch all configurations to have datagrid enabled.
11705 * WebKit.vcproj/WebKit.vcproj:
11707 2009-06-29 David Hyatt <hyatt@apple.com>
11709 Reviewed by Adam Roben.
11711 Put <datagrid> behind an ifdef.
11713 * WebKit.vcproj/WebKit.vcproj:
11715 2009-06-26 Brian Weinstein <bweinstein@apple.com>
11717 Reviewed by Simon Fraser.
11719 https://bugs.webkit.org/show_bug.cgi?id=26695
11721 Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
11722 it isn't counted, and lets the user drag the scrollbar itself instead of a
11723 panning gesture. Also cleaned up code in gesture.
11726 (WebView::gestureNotify):
11727 (WebView::gesture):
11729 2009-06-26 Jeremy Orlow <jorlow@chromium.org>
11731 Reviewed by Adam Barth.
11733 https://bugs.webkit.org/show_bug.cgi?id=26767
11735 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
11736 despite it being deleted from the repo by the following patch/commit:
11737 https://bugs.webkit.org/show_bug.cgi?id=26732
11738 http://trac.webkit.org/changeset/45290
11742 2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
11744 Reviewed by Eric Seidel.
11746 Bug 20303: [Qt] Key events are not working in frames.
11748 Move the scroll handling code to EventHandler so that other
11749 ports can share the functionality.
11752 (WebView::keyDown):
11753 (EnumTextMatches::QueryInterface):
11755 2009-06-23 Anders Carlsson <andersca@apple.com>
11757 Reviewed by Darin Adler.
11759 WebKit side of <rdar://problem/6946094>.
11761 * Interfaces/IWebUIDelegate.idl:
11762 Add a newPasteboard out parameter to willPerformDragSourceAction.
11764 * WebCoreSupport/WebDragClient.cpp:
11765 (WebDragClient::willPerformDragSourceAction):
11766 Implement this. If the client returns a new pasteboard, use it for the drag.
11768 * WebCoreSupport/WebInspectorDelegate.h:
11769 (WebInspectorDelegate::willPerformDragSourceAction):
11770 Add the new parameter.
11772 2009-06-20 Darin Adler <darin@apple.com>
11774 Reviewed by Sam Weinig.
11776 <rdar://problem/6964221> Need more processing of pluginspage.
11778 * WebCoreSupport/WebFrameLoaderClient.cpp:
11779 (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
11781 2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
11783 Reviewed by Steve Falkenburg.
11785 https://bugs.webkit.org/show_bug.cgi?id=26494
11786 Bug 26494: RenderTheme::themeForPage reads from Settings before it has
11787 been initialized by WebKit
11789 Get the shouldPaintNativeControls preference and update the settings
11790 before initializing the page, as the page depends on it after the
11791 themeForPage change.
11794 (WebView::initWithFrame):
11796 2009-06-19 Brian Weinstein <bweinstein@apple.com>
11798 Reviewed by Steve Falkenburg.
11800 https://bugs.webkit.org/show_bug.cgi?id=26488
11801 No Support for Single Finger or Two Finger Panning in Windows 7
11803 Added the code necessary for single finger and two-finger panning with
11804 window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages,
11805 and interpret the panning command. Also, added WindowsTouch.h which contains
11806 structs and #defines from the Windows 7 SDK.
11808 * WebKit.vcproj/WebKit.vcproj:
11810 (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar
11811 (WebView::gesture): Handles the Panning gesture, creating the WheelEvent
11812 (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY
11814 * WindowsTouch.h: Added.
11816 2009-06-18 Adam Barth <abarth@webkit.org>
11818 Reviewed by Sam Weinig.
11820 https://bugs.webkit.org/show_bug.cgi?id=26199
11822 Added preference to enable the XSSAuditor.
11824 * Interfaces/IWebPreferencesPrivate.idl:
11825 * WebPreferenceKeysPrivate.h:
11826 * WebPreferences.cpp:
11827 (WebPreferences::initializeDefaultSettings):
11828 (WebPreferences::isXSSAuditorEnabled):
11829 (WebPreferences::setXSSAuditorEnabled):
11830 * WebPreferences.h:
11832 (WebView::notifyPreferencesChanged):
11834 2009-06-18 Brent Fulgham <bfulgham@gmail.com>
11836 Reviewed by Dave Levin.
11838 Remove some boilerplate using the BitmapInfo struct.
11839 https://bugs.webkit.org/show_bug.cgi?id=26425
11842 (WebFrame::spoolPages):
11843 * WebIconDatabase.cpp:
11845 * WebKit.vcproj/WebKit.sln:
11846 * WebNodeHighlight.cpp:
11847 (WebNodeHighlight::update):
11849 (WebView::ensureBackingStore):
11851 2009-06-17 Steve Falkenburg <sfalken@apple.com>
11853 Consolidate WebKit COM interfaces.
11854 Moved IID from the highest numbered COM interface to the first interface and combined all methods.
11856 Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
11858 Reviewed by Adam Roben.
11860 * Interfaces/IWebFrameLoadDelegate.idl:
11861 * Interfaces/IWebFrameLoadDelegatePrivate.idl:
11862 * Interfaces/IWebResourceLoadDelegatePrivate.idl:
11863 * Interfaces/IWebUIDelegate.idl:
11864 * Interfaces/IWebUIDelegatePrivate.idl:
11865 * Interfaces/WebKit.idl:
11866 * WebCoreSupport/WebChromeClient.cpp:
11867 * WebCoreSupport/WebChromeClient.h:
11868 * WebCoreSupport/WebContextMenuClient.cpp:
11869 * WebCoreSupport/WebFrameLoaderClient.cpp:
11870 * WebCoreSupport/WebInspectorDelegate.h:
11874 2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
11876 Reviewed by Adam Roben.
11878 Create a different RenderTheme per page, so that RenderTheme has
11879 access to page specific theming. This is needed for the Qt port, as Qt
11880 supports setting the theme (style) per widget.
11882 This change was suggested and discussed with Dave Hyatt.
11886 1) Create a theme per page or one global one, depending on the needs
11888 2) Add an accesser to the theme from RenderObject.
11889 3) Change all uses of the theming to access the theme through
11890 RenderObject, using the global default theme as fallback, when the
11891 document of RenderObject has no page.
11892 When we don't have access to a RenderObject, use the default theme.
11893 4) Modify all RenderTheme platform implementations to work with the
11894 above changes, still creating only one global theme.
11897 (WebViewWndProc): Get the theme from the associated page.
11899 2009-06-16 Brian Weinstein <bweinstein@apple.com>
11901 Reviewed by Adam Roben.
11903 Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
11904 Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
11905 https://bugs.webkit.org/show_bug.cgi?id=25875.
11906 <rdar://problem/6903976>
11909 (WebView::mouseWheel):
11911 2009-06-16 Brent Fulgham <bfulgham@gmail.com>
11913 Reviewed by Darin Adler.
11915 Use consistent Windows GUID Comparison Functions.
11916 https://bugs.webkit.org/show_bug.cgi?id=26427.
11919 (EnumTextMatches::QueryInterface):
11921 == Rolled over to ChangeLog-2009-06-16 ==