From: Felix Domke <tmbinc@elitedvb.net>
Date: Wed, 11 Mar 2009 07:06:04 +0000 (+0100)
Subject: Patch by Moritz Venn:
X-Git-Url: http://code.vuplus.com/gitweb/?p=vuplus_dvbapp;a=commitdiff_plain;h=c5e9c66d00e481493bbc3f63f98e57ac68962ce0;hp=-c

Patch by Moritz Venn:

The current implementation of ConfigNumber.isChanged (the one inherited from ConfigElement) does not work properly as it will - at least for unsaved values - always returns True.
This is obvious if you just take a look at the datatypes since value is an int and default is a string (because ConfigNumber is a modified ConfigText).

To resolve this issue one can either compare self.tostring(self.value) or self.text to self.default but the former seems to be the more logical approach.
The attached patch does override the method in ConfigNumber with the proposed fix.
---

c5e9c66d00e481493bbc3f63f98e57ac68962ce0
diff --git a/lib/python/Components/config.py b/lib/python/Components/config.py
index 4cc4063..24d39cb 100755
--- a/lib/python/Components/config.py
+++ b/lib/python/Components/config.py
@@ -1029,6 +1029,13 @@ class ConfigNumber(ConfigText):
 	value = property(getValue, setValue)
 	_value = property(getValue, setValue)
 
+	def isChanged(self):
+		sv = self.saved_value
+		strv = self.tostring(self.value)
+		if sv is None and strv == self.default:
+			return False
+		return strv != sv
+
 	def conform(self):
 		pos = len(self.text) - self.marked_pos
 		self.text = self.text.lstrip("0")