From: ghost <andreas.monzner@multimedia-labs.de>
Date: Sun, 9 Aug 2009 18:27:43 +0000 (+0200)
Subject: servicedvb.cpp: fix segfault caused by yesterday subtitle re-enable patch on timeshif... 
X-Git-Url: http://code.vuplus.com/gitweb/?p=vuplus_dvbapp;a=commitdiff_plain;h=b15e769c8b4a63847c9ebe53eb4b5c1435bae778

servicedvb.cpp: fix segfault caused by yesterday subtitle re-enable patch on timeshift/live transition
---

diff --git a/lib/service/servicedvb.cpp b/lib/service/servicedvb.cpp
index 5166414..a75c6ca 100644
--- a/lib/service/servicedvb.cpp
+++ b/lib/service/servicedvb.cpp
@@ -2329,23 +2329,24 @@ void eDVBServicePlay::updateDecoder()
 				m_decoder->connectVideoEvent(slot(*this, &eDVBServicePlay::video_event), m_video_event_connection);
 			if (m_is_primary)
 			{
-				ePyObject subs;
-				if (m_timeshift_changed)
-					subs = getCachedSubtitle();
 				m_teletext_parser = new eDVBTeletextParser(m_decode_demux);
 				m_teletext_parser->connectNewPage(slot(*this, &eDVBServicePlay::newSubtitlePage), m_new_subtitle_page_connection);
 				m_subtitle_parser = new eDVBSubtitleParser(m_decode_demux);
 				m_subtitle_parser->connectNewPage(slot(*this, &eDVBServicePlay::newDVBSubtitlePage), m_new_dvb_subtitle_page_connection);
-				if (subs)
+				if (m_timeshift_changed)
 				{
-					int type = PyInt_AsLong(PyTuple_GET_ITEM(subs, 0)),
-					    pid = PyInt_AsLong(PyTuple_GET_ITEM(subs, 1)),
-					    comp_page = PyInt_AsLong(PyTuple_GET_ITEM(subs, 2)), // ttx page
-					    anc_page = PyInt_AsLong(PyTuple_GET_ITEM(subs, 3)); // ttx magazine
-					if (type == 0) // dvb
-						m_subtitle_parser->start(pid, comp_page, anc_page);
-					else if (type == 1) // ttx
-						m_teletext_parser->setPageAndMagazine(comp_page, anc_page);
+					ePyObject subs = getCachedSubtitle();
+					if (subs != Py_None)
+					{
+						int type = PyInt_AsLong(PyTuple_GET_ITEM(subs, 0)),
+						    pid = PyInt_AsLong(PyTuple_GET_ITEM(subs, 1)),
+						    comp_page = PyInt_AsLong(PyTuple_GET_ITEM(subs, 2)), // ttx page
+						    anc_page = PyInt_AsLong(PyTuple_GET_ITEM(subs, 3)); // ttx magazine
+						if (type == 0) // dvb
+							m_subtitle_parser->start(pid, comp_page, anc_page);
+						else if (type == 1) // ttx
+							m_teletext_parser->setPageAndMagazine(comp_page, anc_page);
+					}
 					Py_DECREF(subs);
 				}
 			}