[3d] simplify some code by moving error check
authorJoakim Plate <elupus@ecce.se>
Sat, 8 Jun 2013 17:56:58 +0000 (19:56 +0200)
committerJoakim Plate <elupus@ecce.se>
Thu, 1 Aug 2013 14:59:03 +0000 (16:59 +0200)
xbmc/guilib/StereoscopicsManager.cpp

index c616f6b..e9a181d 100644 (file)
@@ -81,7 +81,7 @@ RENDER_STEREO_MODE CStereoscopicsManager::GetStereoMode(void)
 void CStereoscopicsManager::SetStereoMode(const RENDER_STEREO_MODE &mode)
 {
   RENDER_STEREO_MODE currentMode = GetStereoMode();
-  if (mode != currentMode)
+  if (mode != currentMode && mode >= RENDER_STEREO_MODE_OFF)
   {
     m_lastStereoMode = currentMode;
     CSettings::Get().SetInt("videoscreen.stereoscopicmode", mode);
@@ -313,9 +313,7 @@ bool CStereoscopicsManager::OnAction(const CAction &action)
   }
   else if (action.GetID() == ACTION_STEREOMODE_SELECT)
   {
-    RENDER_STEREO_MODE selectedMode = GetStereoModeByUserChoice();
-    if (selectedMode > -1 && selectedMode != mode)
-      SetStereoMode(selectedMode);
+    SetStereoMode(GetStereoModeByUserChoice());
     return true;
   }
   else if (action.GetID() == ACTION_STEREOMODE_TOMONO)