[DVDStreamInfo] Discuss: 'CDVDStreamInfo::operator=' should return 'CDVDStreamInfo...
authorace20022 <ace20022@ymail.com>
Fri, 15 Mar 2013 07:45:13 +0000 (08:45 +0100)
committerace20022 <ace20022@ymail.com>
Fri, 5 Apr 2013 08:33:04 +0000 (10:33 +0200)
xbmc/cores/dvdplayer/DVDStreamInfo.h

index 3070094..0b33d94 100644 (file)
@@ -96,6 +96,9 @@ public:
 
   bool operator==(const CDVDStreamInfo& right)      { return Equal(right, true);}
   bool operator!=(const CDVDStreamInfo& right)      { return !Equal(right, true);}
+
+  //'CDVDStreamInfo::operator=' should return 'CDVDStreamInfo &'.
+  // Is this intended? It looks more like a copy,cf. extradata, what happens if info = info?
   void operator=(const CDVDStreamInfo& right)       { Assign(right, true); }
 
   bool operator==(const CDemuxStream& right)      { return Equal( CDVDStreamInfo(right, true), true);}