1 2011-09-14 Anders Carlsson <andersca@apple.com>
3 Get rid of WebCoreViewFactory and its WebViewFactory subclass
4 https://bugs.webkit.org/show_bug.cgi?id=68124
6 Reviewed by Sam Weinig.
8 * WebCoreSupport/WebContextMenuClient.mm:
9 * WebCoreSupport/WebViewFactory.h: Removed.
10 * WebCoreSupport/WebViewFactory.mm: Removed.
11 * WebView/WebFrameView.mm:
12 (-[WebFrameView initWithFrame:]):
14 2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
16 Unzip initialization lists and constructors in JSCell hierarchy (6/7)
17 https://bugs.webkit.org/show_bug.cgi?id=67692
19 Reviewed by Geoffrey Garen.
21 Completed the sixth level of the refactoring to add finishCreation()
22 methods to all classes within the JSCell hierarchy with non-trivial
25 This primarily consists of pushing the calls to finishCreation() down
26 into the constructors of the subclasses of the fifth level of the hierarchy
27 as well as pulling the finishCreation() calls out into the class's corresponding
28 create() method if it has one. Doing both simultaneously allows us to
29 maintain the invariant that the finishCreation() method chain is called exactly
30 once during the creation of an object, since calling it any other number of
31 times (0, 2, or more) will cause an assertion failure.
33 * Plugins/Hosted/ProxyInstance.mm:
34 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
35 (WebKit::ProxyRuntimeMethod::finishCreation):
37 2011-09-13 Eric Seidel <eric@webkit.org>
39 Remove ENABLE_SVG_USE as <use> is required by HTML5
40 https://bugs.webkit.org/show_bug.cgi?id=68019
42 Reviewed by Ryosuke Niwa.
44 * Configurations/FeatureDefines.xcconfig:
46 2011-09-13 Anders Carlsson <andersca@apple.com>
48 Disable C++ exceptions when building with clang
49 https://bugs.webkit.org/show_bug.cgi?id=68031
50 <rdar://problem/9556880>
52 Reviewed by Mark Rowe.
54 * Configurations/Base.xcconfig:
56 2011-09-13 Eric Seidel <eric@webkit.org>
58 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
59 https://bugs.webkit.org/show_bug.cgi?id=68018
61 Reviewed by Ryosuke Niwa.
63 * Configurations/FeatureDefines.xcconfig:
65 2011-09-09 Oliver Hunt <oliver@apple.com>
67 Remove support for anonymous storage from jsobjects
68 https://bugs.webkit.org/show_bug.cgi?id=67881
70 Reviewed by Sam Weinig.
72 Remove the use of AnonymousSlotCount
74 * Plugins/Hosted/ProxyInstance.mm:
75 (WebKit::ProxyRuntimeMethod::createStructure):
76 * Plugins/Hosted/ProxyRuntimeObject.h:
77 (WebKit::ProxyRuntimeObject::createStructure):
79 2011-09-09 Chris Marrin <cmarrin@apple.com>
81 requestAnimationFrame doesn't throttle on Mac
82 https://bugs.webkit.org/show_bug.cgi?id=67171
84 Reviewed by Simon Fraser.
86 Removed runLoopObserver for requestAnimationFrame. It's now
87 done by a Timer in ScriptedAnimationController in WebCore.
89 * WebCoreSupport/WebChromeClient.h:
90 * WebCoreSupport/WebChromeClient.mm:
93 * WebView/WebViewData.h:
94 * WebView/WebViewInternal.h:
96 2011-09-09 Fady Samuel <fsamuel@chromium.org>
98 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
99 https://bugs.webkit.org/show_bug.cgi?id=67250
101 Reviewed by Simon Fraser.
103 * WebView/WebView.mm:
104 (-[WebView _scaleWebView:atOrigin:]):
105 (-[WebView _viewScaleFactor]):
107 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
109 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
110 https://bugs.webkit.org/show_bug.cgi?id=67420
112 Reviewed by Geoffrey Garen.
114 Completed the fifth level of the refactoring to add finishCreation()
115 methods to all classes within the JSCell hierarchy with non-trivial
118 This primarily consists of pushing the calls to finishCreation() down
119 into the constructors of the subclasses of the second level of the hierarchy
120 as well as pulling the finishCreation() calls out into the class's corresponding
121 create() method if it has one. Doing both simultaneously allows us to
122 maintain the invariant that the finishCreation() method chain is called exactly
123 once during the creation of an object, since calling it any other number of
124 times (0, 2, or more) will cause an assertion failure.
126 * Plugins/Hosted/ProxyRuntimeObject.h:
127 * Plugins/Hosted/ProxyRuntimeObject.mm:
128 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
129 (WebKit::ProxyRuntimeObject::finishCreation):
131 2011-09-08 Sam Weinig <sam@webkit.org>
133 Remove the Completion object from JSC, I have never liked it
134 https://bugs.webkit.org/show_bug.cgi?id=67755
136 Reviewed by Gavin Barraclough.
138 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
139 (WebKit::NetscapePluginInstanceProxy::evaluate):
141 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
143 Unreviewed, rolling out r94627 and r94632.
144 http://trac.webkit.org/changeset/94627
145 http://trac.webkit.org/changeset/94632
146 https://bugs.webkit.org/show_bug.cgi?id=67698
148 It broke tests on GTK and Qt (Requested by Ossy on #webkit).
150 * Plugins/Hosted/ProxyRuntimeObject.h:
151 * Plugins/Hosted/ProxyRuntimeObject.mm:
152 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
154 2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
156 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
157 https://bugs.webkit.org/show_bug.cgi?id=67420
159 Reviewed by Geoffrey Garen.
161 Completed the fifth level of the refactoring to add finishCreation()
162 methods to all classes within the JSCell hierarchy with non-trivial
165 This primarily consists of pushing the calls to finishCreation() down
166 into the constructors of the subclasses of the second level of the hierarchy
167 as well as pulling the finishCreation() calls out into the class's corresponding
168 create() method if it has one. Doing both simultaneously allows us to
169 maintain the invariant that the finishCreation() method chain is called exactly
170 once during the creation of an object, since calling it any other number of
171 times (0, 2, or more) will cause an assertion failure.
173 * Plugins/Hosted/ProxyRuntimeObject.h:
174 * Plugins/Hosted/ProxyRuntimeObject.mm:
175 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
176 (WebKit::ProxyRuntimeObject::finishCreation):
178 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
180 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
181 https://bugs.webkit.org/show_bug.cgi?id=67569
183 Reviewed by Antonio Gomes.
185 * WebView/WebHTMLView.mm:
186 (-[WebHTMLView _updateSelectionForInputManager]):
188 2011-09-05 Oliver Hunt <oliver@apple.com>
190 An object's structure should reference the global object responsible for its creation
191 https://bugs.webkit.org/show_bug.cgi?id=67624
193 Reviewed by Gavin Barraclough.
195 Update for new Structure::create() globalObject parameter.
197 * Plugins/Hosted/ProxyInstance.mm:
198 (WebKit::ProxyRuntimeMethod::createStructure):
199 * Plugins/Hosted/ProxyRuntimeObject.h:
200 (WebKit::ProxyRuntimeObject::createStructure):
202 2011-09-01 Mark Rowe <mrowe@apple.com>
204 Fix the build by adding some more missing return types.
206 * WebView/WebDashboardRegion.h:
207 * WebView/WebDashboardRegion.mm:
208 (-[WebDashboardRegion initWithRect:clip:type:]):
210 2011-09-01 Tim Horton <timothy_horton@apple.com>
212 REGRESSION: Rendering artifacts on a rotated, pattern filled shape
213 https://bugs.webkit.org/show_bug.cgi?id=53055
214 <rdar://problem/8910917>
216 Reviewed by Simon Fraser.
218 Introduce wkCGPatternCreateWithImageAndTransform.
220 * WebCoreSupport/WebSystemInterface.mm:
221 (InitWebCoreSystemInterface):
223 2011-08-31 Beth Dakin <bdakin@apple.com>
225 https://bugs.webkit.org/show_bug.cgi?id=67322
226 Re-name overrideBackingScaleFactor
228 Reviewed by John Sullivan.
230 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor
231 * WebView/WebView.mm:
232 (-[WebView _setCustomBackingScaleFactor:]):
233 (-[WebView _deviceScaleFactor]):
234 * WebView/WebViewData.h:
235 * WebView/WebViewPrivate.h:
237 2011-08-30 Dan Bernstein <mitz@apple.com>
239 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
240 https://bugs.webkit.org/show_bug.cgi?id=67230
242 Reviewed by Darin Adler.
244 * WebView/WebHTMLView.mm:
245 * WebView/WebView.mm:
246 (coreOptions): Moved this function from WebHTMLView.mm to here and made
247 it accessible from both this file and WebHTMLView.mm.
248 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
249 * WebView/WebViewInternal.h:
250 * WebView/WebViewPrivate.h:
252 2011-08-30 Beth Dakin <bdakin@apple.com>
254 https://bugs.webkit.org/show_bug.cgi?id=67150
255 Would like API to use a custom device scale factor for a particular WebView/WKView
257 <rdar://problem/10041016>
259 Reviewed by Darin Adler.
261 New API is _setOverrideBackingScaleFactor:(CGFloat)
262 * WebView/WebView.mm:
263 (-[WebView _setOverrideBackingScaleFactor:]):
264 (-[WebView _deviceScaleFactor]):
265 * WebView/WebViewData.h:
266 * WebView/WebViewPrivate.h:
268 2011-08-30 Aaron Colwell <acolwell@chromium.org>
270 Add MediaSource API to HTMLMediaElement
271 https://bugs.webkit.org/show_bug.cgi?id=64731
273 Reviewed by Eric Carlson.
275 * Configurations/FeatureDefines.xcconfig:
277 2011-08-29 Alexey Proskuryakov <ap@apple.com>
279 DumpRenderTree should begin each test with an empty cookie store
280 https://bugs.webkit.org/show_bug.cgi?id=63545
281 <rdar://problem/5666907>
283 Reviewed by Darin Adler.
285 * WebView/WebPreferences.mm:
286 (+[WebPreferences initialize]):
287 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
288 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
289 * WebView/WebPreferencesPrivate.h:
290 Exposed an SPI to use a private default session. It's separate from private browsing,
291 because some tests enable the latter, and we don't want to mix them up.
292 Also exposed an SPI to set cookie accept policy regardless of what session we are currently
295 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession()
296 instead of privateBrowsingStorageSession().
298 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
300 The unused ScrollView* argument can and should be removed from
302 https://bugs.webkit.org/show_bug.cgi?id=67117
304 Reviewed by Darin Adler.
306 * WebCoreSupport/WebChromeClient.h:
307 * WebCoreSupport/WebChromeClient.mm:
308 (WebChromeClient::scrollRectIntoView):
310 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
312 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
314 http://trac.webkit.org/changeset/93987
315 http://trac.webkit.org/changeset/93992
316 http://trac.webkit.org/changeset/93995
317 http://trac.webkit.org/changeset/93998
318 http://trac.webkit.org/changeset/93999
319 https://bugs.webkit.org/show_bug.cgi?id=67147
321 Many failing tests (Requested by ap on #webkit).
323 * WebView/WebPreferences.mm:
324 (+[WebPreferences initialize]):
325 * WebView/WebPreferencesPrivate.h:
327 2011-08-26 Alexey Proskuryakov <ap@apple.com>
329 DumpRenderTree should begin each test with an empty cookie store
330 https://bugs.webkit.org/show_bug.cgi?id=63545
331 <rdar://problem/5666907>
333 Reviewed by Darin Adler.
335 * WebView/WebPreferences.mm:
336 (+[WebPreferences initialize]):
337 (+[WebPreferences _usePrivateSessionForNetworkLoading]):
338 * WebView/WebPreferencesPrivate.h:
339 Exposed an SPI to use a private default session. It's separate from private browsing,
340 because some tests enable the latter, and we don't want to mix them up.
342 2011-08-23 Chris Marrin <cmarrin@apple.com>
344 [mac] requestAnimationFrame support for mac port
345 https://bugs.webkit.org/show_bug.cgi?id=59146
347 Reviewed by Simon Fraser.
349 Implement requestAnimationFrame for WebKit. Add a
350 CFRunLoopObserver to WebView, which runs just before
351 the syncCompositingState RLO and calls into the
352 ScriptedAnimationController if scheduleAnimation() has
355 * Configurations/FeatureDefines.xcconfig:
356 * WebCoreSupport/WebChromeClient.h:
357 * WebCoreSupport/WebChromeClient.mm:
358 (WebChromeClient::scheduleAnimation):
359 * WebView/WebView.mm:
361 (-[WebView _unscheduleAnimation]):
362 (-[WebView _scheduleCompositingLayerSync]):
363 (requestAnimationFrameRunLoopObserverCallback):
364 (-[WebView _scheduleAnimation]):
365 * WebView/WebViewData.h:
366 * WebView/WebViewInternal.h:
368 2011-08-24 Alexey Proskuryakov <ap@apple.com>
370 Plug-in tests are flaky on Mac
371 https://bugs.webkit.org/show_bug.cgi?id=66822
373 Reviewed by Anders Carlsson.
375 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
376 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
377 Protect objects that can be removed by a script.
379 * WebView/WebFrame.mm:
380 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
381 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto.
382 Also fixed some nonsense code.
384 2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
386 Add checks to ensure allocation does not take place during initialization of GC-managed objects
387 https://bugs.webkit.org/show_bug.cgi?id=65288
389 Reviewed by Darin Adler.
391 Adding the new validation functionality. In its current state, it will performs checks,
392 but they don't fail unless you do allocation in the arguments to the parent constructor in the
393 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
394 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
395 allowed in constructor bodies while other refactoring efforts continue.
397 * Plugins/Hosted/ProxyRuntimeObject.h:
398 (WebKit::ProxyRuntimeObject::create):
399 * Plugins/Hosted/ProxyRuntimeObject.mm:
400 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
402 2011-08-18 Beth Dakin <bdakin@apple.com>
404 Reviewed by Sam Weinig.
406 https://bugs.webkit.org/show_bug.cgi?id=66495
407 Lion-specific scroller SPIs can use forward declaration instead of
408 WebKitSystemInterface
410 * WebCoreSupport/WebSystemInterface.mm:
411 (InitWebCoreSystemInterface):
413 2011-08-18 Anders Carlsson <andersca@apple.com>
415 More C++0x libc++ build fixes
416 https://bugs.webkit.org/show_bug.cgi?id=66476
418 Reviewed by Adam Roben.
420 * Plugins/Hosted/NetscapePluginHostProxy.mm:
422 Use a WTF String here instead of an STL string.
424 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
425 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
426 std::make_pair now takes rvalue references, so get rid of the template arguments and let
427 the compiler deduce them instead.
429 2011-08-18 Adam Roben <aroben@apple.com>
431 Update the device scale factor when the WebView's window changes
433 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
434 WebView is moved between windows with different backing scale factors
436 Reviewed by Anders Carlsson.
438 * WebView/WebView.mm:
439 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
440 window at all) might have a different backing scale factor than the previous one.
441 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
443 2011-08-17 Adam Roben <aroben@apple.com>
445 Make WebCore keep track of the current device scale factor
447 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
450 Reviewed by Darin Adler.
452 * WebCoreSupport/WebChromeClient.h:
453 * WebCoreSupport/WebChromeClient.mm:
454 Moved code to calculate the device scale factor from here...
456 * WebView/WebView.mm:
457 (-[WebView _deviceScaleFactor]):
460 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
462 2011-08-17 Dan Bernstein <mitz@apple.com>
464 Removed some code that is not needed when building for Leopard or later.
466 Reviewed by Anders Carlsson.
468 * WebCoreSupport/WebContextMenuClient.mm:
469 (fixMenusToSendToOldClients): Removed check for Tiger Mail.
470 * WebCoreSupport/WebFrameLoaderClient.mm:
471 (WebFrameLoaderClient::objectContentType):
472 * WebView/WebView.mm:
473 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
474 (-[WebView _preferencesChanged:]):
476 2011-08-17 Dan Bernstein <mitz@apple.com>
478 Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
480 Rubber-stamped by Anders Carlsson.
482 * WebView/WebHTMLViewPrivate.h:
484 2011-08-17 Dan Bernstein <mitz@apple.com>
486 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
489 Reviewed by Darin Adler.
491 * History/WebBackForwardList.h:
492 * WebView/WebDocumentInternal.h:
493 * WebView/WebHTMLRepresentation.h:
494 * WebView/WebPreferences.h:
495 * WebView/WebResourceLoadDelegate.h:
496 * WebView/WebResourceLoadDelegatePrivate.h:
497 * WebView/WebScriptDebugDelegate.h:
498 * WebView/WebTextIterator.h:
499 * WebView/WebUIDelegate.h:
501 * WebView/WebViewPrivate.h:
503 2011-08-15 Dmitry Titov <dimich@chromium.org>
505 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
506 https://bugs.webkit.org/show_bug.cgi?id=66165
508 Reviewed by Darin Fisher.
510 * WebCoreSupport/WebFrameLoaderClient.h:
511 * WebCoreSupport/WebFrameLoaderClient.mm:
512 (WebFrameLoaderClient::transferLoadingResourceFromPage):
514 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
516 Refactor JS objects to allocate in static create methods rather than constructors
517 https://bugs.webkit.org/show_bug.cgi?id=65347
519 Reviewed by Geoffrey Garen.
521 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
522 larger refactoring to get rid of all allocation during initialization.
524 * Plugins/Hosted/ProxyInstance.mm:
525 (WebKit::ProxyRuntimeMethod::create):
526 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
528 2011-08-15 Adam Roben <aroben@apple.com>
530 Update pages' style and content scale when the window's backing scale factor changes
532 Unfortunately, I couldn't think of a way to test this in an automated fashion.
534 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
537 Reviewed by Simon Fraser.
539 * WebView/WebView.mm:
540 (-[WebView addWindowObserversForWindow:]):
541 (-[WebView removeWindowObservers]):
542 Listen for the notification that tells us the window's backing scale has changed.
544 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
545 factor so that, e.g., scale-factor-dependent media queries will be reevaluated.
547 2011-08-10 Adam Roben <aroben@apple.com>
549 Clear up scale factor terminology
551 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
552 software is running, and one that is per-Page and can be controlled via API calls. This
553 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
554 code use those names. It should introduce no behavior changes.
556 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
559 Reviewed by Simon Fraser.
561 * Misc/WebNSControlExtras.m:
562 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
563 AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
565 * WebCoreSupport/WebChromeClient.h:
566 * WebCoreSupport/WebChromeClient.mm:
568 2011-08-13 Dan Bernstein <mitz@apple.com>
570 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
572 Reviewed by Joseph Pecoraro.
574 * WebView/WebPreferenceKeysPrivate.h:
576 2011-08-13 Sam Weinig <sam@webkit.org>
578 Remove unused variables from WebView/WebFullScreenController.h
579 https://bugs.webkit.org/show_bug.cgi?id=66194
581 Reviewed by Dan Bernstein.
583 * WebView/WebFullScreenController.h:
584 Remove a few variables which were not used.
586 2011-08-12 Dan Bernstein <mitz@apple.com>
588 Add an option to automatically show tooltips (with the full text) over truncated text
589 https://bugs.webkit.org/show_bug.cgi?id=66178
591 Reviewed by Simon Fraser.
593 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
594 * WebView/WebPreferences.mm:
595 (+[WebPreferences initialize]): Added a default value of NO for the
596 ShowsToolTipOverTruncatedText preference.
597 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
598 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
599 * WebView/WebPreferencesPrivate.h:
600 * WebView/WebView.mm:
601 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().
603 2011-08-12 Sam Weinig <sam@webkit.org>
605 Use __builtin_trap() for CRASH when building with clang
606 https://bugs.webkit.org/show_bug.cgi?id=66152
608 Reviewed by Anders Carlsson.
610 * Plugins/WebBaseNetscapePluginView.mm:
611 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
612 (-[WebBaseNetscapePluginView handleMouseMoved:]):
613 (-[WebBaseNetscapePluginView handleMouseEntered:]):
614 (-[WebBaseNetscapePluginView handleMouseExited:]):
615 (-[WebBaseNetscapePluginView focusChanged]):
616 (-[WebBaseNetscapePluginView windowFocusChanged:]):
617 (-[WebBaseNetscapePluginView createPlugin]):
618 (-[WebBaseNetscapePluginView loadStream]):
619 (-[WebBaseNetscapePluginView shouldStop]):
620 (-[WebBaseNetscapePluginView destroyPlugin]):
621 (-[WebBaseNetscapePluginView updateAndSetWindow]):
622 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
623 (-[WebBaseNetscapePluginView pluginLayer]):
624 (-[WebBaseNetscapePluginView getFormValue:]):
625 Remove the ASSERT_NOT_REACHED from the base class methods. They were not
626 adding much value and were getting in the way of making the static analyzer
627 work. A better way to do this would be to use a formal protocol.
629 2011-08-12 Mark Rowe <mrowe@apple.com>
631 Be more forward-looking in the choice of compiler.
633 Rubber-stamped by Jon Honeycutt.
635 * Configurations/CompilerVersion.xcconfig:
637 2011-08-10 David Hyatt <hyatt@apple.com>
639 https://bugs.webkit.org/show_bug.cgi?id=66004
641 Removing the CSS Regions and Exclusions ifdefs.
643 Reviewed by Adam Roben.
645 * Configurations/FeatureDefines.xcconfig:
647 2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
649 Add ParentClass typedef in all JSC classes
650 https://bugs.webkit.org/show_bug.cgi?id=65731
652 Reviewed by Oliver Hunt.
654 Just added the Base typedefs in all the classes that are a subclass of JSCell
655 to point at their parent classes. This is a change to support future changes to the way
656 constructors and destructors are implemented in JS objects, among other things.
658 * Plugins/Hosted/ProxyInstance.mm:
659 * Plugins/Hosted/ProxyRuntimeObject.h:
661 2011-08-08 Chris Marrin <cmarrin@apple.com>
663 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
664 https://bugs.webkit.org/show_bug.cgi?id=65708
666 Supply initial display rects for the full-screen case
668 Reviewed by Simon Fraser.
670 * WebView/WebFullScreenController.mm:
671 (-[WebFullScreenController enterFullscreen:]):
672 (-[WebFullScreenController exitFullscreen]):
674 2011-08-06 Joseph Pecoraro <joepeck@webkit.org>
676 Potential Leaks - RetainPtr<> over retaining Create'd objects
677 https://bugs.webkit.org/show_bug.cgi?id=65806
679 Reviewed by Darin Adler.
681 Fix a possible leak by adopting an allocation instead of retaining it.
683 * WebView/WebView.mm:
684 (-[WebView previousValidKeyView]):
686 2011-08-05 Anders Carlsson <andersca@apple.com>
689 https://bugs.webkit.org/show_bug.cgi?id=65729
691 Reviewed by Darin Adler.
693 Remove plug-in halter and associated classes.
695 * Plugins/WebBaseNetscapePluginView.h:
696 * Plugins/WebBaseNetscapePluginView.mm:
697 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
698 (-[WebBaseNetscapePluginView start]):
699 (-[WebBaseNetscapePluginView stop]):
700 * WebCoreSupport/WebPluginHalterClient.h: Removed.
701 * WebCoreSupport/WebPluginHalterClient.mm: Removed.
702 * WebView/WebPreferenceKeysPrivate.h:
703 * WebView/WebPreferences.mm:
704 (+[WebPreferences initialize]):
705 * WebView/WebPreferencesPrivate.h:
706 * WebView/WebView.mm:
707 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
708 (-[WebView _preferencesChanged:]):
709 * WebView/WebViewPrivate.h:
711 2011-08-04 Mark Rowe <mrowe@apple.com>
713 Future-proof Xcode configuration settings.
715 * Configurations/Base.xcconfig:
716 * Configurations/DebugRelease.xcconfig:
717 * Configurations/Version.xcconfig:
718 * Configurations/WebKit.xcconfig:
720 2011-08-03 Kent Tamura <tkent@chromium.org>
722 Fix incorrect checks for HTMLMediaElement
723 https://bugs.webkit.org/show_bug.cgi?id=65590
725 Reviewed by Dimitri Glazkov.
727 <video> and <audio> can be an HTMLElement instance instead of
728 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
729 the media feature is disabled at runtime.
731 * WebView/WebFullScreenController.mm:
732 (-[WebFullScreenController _isAnyMoviePlaying]):
734 2011-08-03 Mark Rowe <mrowe@apple.com>
736 Bring some order to FeatureDefines.xcconfig to make it easier to follow.
738 Reviewed by Sam Weinig.
740 * Configurations/FeatureDefines.xcconfig:
742 2011-08-03 Mark Rowe <mrowe@apple.com>
744 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
746 Reviewed by Dave Kilzer.
748 * Configurations/FeatureDefines.xcconfig:
750 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
752 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
753 https://bugs.webkit.org/show_bug.cgi?id=65582
755 Reviewed by Pavel Feldman.
757 * WebCoreSupport/WebInspectorClient.h:
758 * WebCoreSupport/WebInspectorClient.mm:
760 2011-08-03 Pavel Feldman <pfeldman@google.com>
762 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
763 https://bugs.webkit.org/show_bug.cgi?id=65510
765 Reviewed by Yury Semikhatsky.
767 * WebInspector/WebNodeHighlightView.mm:
768 (-[WebNodeHighlightView drawRect:]):
770 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
772 Web Inspector: remove Node parameter from the InspectorClient::highlight
773 https://bugs.webkit.org/show_bug.cgi?id=65549
775 Reviewed by Yury Semikhatsky.
777 * WebCoreSupport/WebInspectorClient.h:
778 * WebCoreSupport/WebInspectorClient.mm:
779 (WebInspectorClient::highlight):
780 * WebInspector/WebNodeHighlighter.h:
781 * WebInspector/WebNodeHighlighter.mm:
782 (-[WebNodeHighlighter highlight]):
784 2011-07-30 Patrick Gansterer <paroga@webkit.org>
786 Remove inclusion of MainThread.h from Threading.h
787 https://bugs.webkit.org/show_bug.cgi?id=65081
789 Reviewed by Darin Adler.
791 Add missing include statements for MainThread.
793 * Carbon/CarbonWindowAdapter.mm:
794 * History/WebBackForwardList.mm:
795 * History/WebHistoryItem.mm:
796 * Misc/WebElementDictionary.mm:
797 * Misc/WebIconDatabase.mm:
798 * Misc/WebLocalizableStrings.mm:
799 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
800 * Plugins/WebBaseNetscapePluginView.mm:
801 * Plugins/WebBasePluginPackage.mm:
802 * Plugins/WebNetscapePluginView.mm:
803 * WebCoreSupport/WebEditorClient.mm:
804 * WebCoreSupport/WebFrameLoaderClient.mm:
805 * WebView/WebArchive.mm:
806 * WebView/WebDataSource.mm:
807 * WebView/WebHTMLView.mm:
808 * WebView/WebResource.mm:
809 * WebView/WebTextIterator.mm:
810 * WebView/WebView.mm:
811 * WebView/WebViewData.mm:
813 2011-07-28 Dan Bernstein <mitz@apple.com>
815 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds
817 Reviewed by Darin Adler.
819 * WebCoreSupport/WebSystemInterface.mm:
820 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.
822 2011-07-28 Brady Eidson <beidson@apple.com>
824 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
825 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView
827 Reviewed by Maciej Stachowiak.
829 * Storage/WebStorageManager.mm:
830 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().
832 2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
834 Remove operator new from JSCell
835 https://bugs.webkit.org/show_bug.cgi?id=64999
837 Reviewed by Oliver Hunt.
839 Removed the implementation of operator new in JSCell, so any further uses
840 will not successfully link. Also removed any remaining uses of operator new.
842 * Plugins/Hosted/ProxyInstance.mm:
843 (WebKit::ProxyInstance::newRuntimeObject):
844 (WebKit::ProxyRuntimeMethod::create):
845 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
846 (WebKit::ProxyInstance::getMethod):
847 * Plugins/Hosted/ProxyRuntimeObject.h:
848 (WebKit::ProxyRuntimeObject::create):
849 * WebView/WebScriptDebugDelegate.mm:
850 (-[WebScriptCallFrame scopeChain]):
852 2011-07-26 Dan Bernstein <mitz@apple.com>
854 <rdar://problem/9842889> Add a generic pictograph font family
855 https://bugs.webkit.org/show_bug.cgi?id=65197
857 Reviewed by Anders Carlsson.
859 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
860 * WebView/WebPreferences.mm:
861 (+[WebPreferences initialize]): Set the default pictograph font family to
863 (-[WebPreferences pictographFontFamily]): Added this getter.
864 (-[WebPreferences setPictographFontFamily:]): Added this setter.
865 * WebView/WebPreferencesPrivate.h:
866 * WebView/WebView.mm:
867 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore.
869 2011-07-25 Ian Henderson <ianh@apple.com>
871 WebFrame should have a method to determine its visual emptiness
872 https://bugs.webkit.org/show_bug.cgi?id=64223
874 Reviewed by Dan Bernstein.
876 * WebView/WebFrame.mm:
877 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
879 * WebView/WebFramePrivate.h:
881 2011-07-19 Leo Yang <leoyang.webkit@gmail.com>
883 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
884 https://bugs.webkit.org/show_bug.cgi?id=60850
886 Reviewed by Nikolas Zimmermann.
888 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
889 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
890 elements for alternative glyph features.
892 * MigrateHeaders.make:
894 2011-07-18 Andy Estes <aestes@apple.com>
896 Solar Walk app-specific hack accidentally strips stylesheets from the document.
897 https://bugs.webkit.org/show_bug.cgi?id=64777
899 Reviewed by Adam Barth.
901 Solar Walk uses a self-closed title tag in its documents ("<title />").
902 The HTML5 parser does not recognize this as a valid self-closing tag,
903 so it treats the remainder of the document as title text.
905 We work around this in WebKit by injecting a script that calls
906 document.write() on the contents of document.title, thereby restoring
907 the contents of the document. Unfortunately this overwrote several
908 <style> tags that existed before the <title>, thereby causing the
909 document to not have the intended styling.
911 Fix this by having the injected script concatenate document.title to
912 the document instead of overwriting it during document.write(). We can
913 also take the opportunity to remove document.title since it does not
914 contain useful information.
916 * Misc/SolarWalkQuirksUserScript.js:
918 2011-07-18 Dean Jackson <dino@apple.com>
920 https://bugs.webkit.org/show_bug.cgi?id=64742
921 Expose WebPreferences for media playback requiring user gestures and inline playback
923 Reviewed by Simon Fraser.
925 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
926 MediaPlaybackAllowsInline.
928 * WebView/WebPreferenceKeysPrivate.h:
929 * WebView/WebPreferences.mm:
930 (+[WebPreferences initialize]):
931 (-[WebPreferences mediaPlaybackRequiresUserGesture]):
932 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
933 (-[WebPreferences mediaPlaybackAllowsInline]):
934 (-[WebPreferences setMediaPlaybackAllowsInline:]):
935 * WebView/WebPreferencesPrivate.h:
936 * WebView/WebView.mm:
937 (-[WebView _preferencesChanged:]):
939 2011-07-18 Pratik Solanki <psolanki@apple.com>
941 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
942 Get webkit to compile with USE(CFNETWORK) enabled on Mac
944 Reviewed by David Kilzer.
946 Create an NSURLDownload from the CF objects that we have.
948 * Misc/WebDownload.mm:
949 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
950 * Misc/WebDownloadInternal.h:
951 * WebCoreSupport/WebFrameLoaderClient.mm:
952 (WebFrameLoaderClient::download):
954 2011-07-15 Pratik Solanki <psolanki@apple.com>
956 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
957 Get webkit to compile with USE(CFNETWORK) enabled on Mac
959 Reviewed by David Kilzer.
961 New WebKitSystemInterface functions for CFNetwork-based loader.
963 * WebCoreSupport/WebSystemInterface.mm:
964 (InitWebCoreSystemInterface):
966 2011-07-15 Tim Horton <timothy_horton@apple.com>
968 Overlay scrollbars in overflow areas no longer pulse when revealed
969 https://bugs.webkit.org/show_bug.cgi?id=64606
970 <rdar://problem/9390674>
972 Reviewed by Simon Fraser.
974 Ensure that the state of the scrollbar implementation is kept in sync
975 with WebCore's internal representation. Previously, we synchronized them
976 at paint time, causing pulsing to be skipped due to the scrollbars being
979 * WebCoreSupport/WebSystemInterface.mm:
980 (InitWebCoreSystemInterface):
982 2011-07-15 Andy Estes <aestes@apple.com>
984 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
985 https://bugs.webkit.org/show_bug.cgi?id=64641
987 Reviewed by Brian Weinstein.
989 * WebView/WebView.mm:
990 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().
992 2011-07-15 Dan Bernstein <mitz@apple.com>
994 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
995 https://bugs.webkit.org/show_bug.cgi?id=64615
997 Reviewed by Anders Carlsson.
999 * WebCoreSupport/WebChromeClient.h:
1000 * WebCoreSupport/WebChromeClient.mm:
1001 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
1002 +[NSCursor setHiddenUntilMouseMoves:].
1004 2011-07-14 Gavin Barraclough <barraclough@apple.com>
1006 https://bugs.webkit.org/show_bug.cgi?id=64250
1007 Global strict mode function leaking global object as "this".
1009 Reviewed by Oliver Hunt.
1011 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1012 (WebKit::NetscapePluginInstanceProxy::invoke):
1013 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1014 - Change call to pass DOM Window shell, instead of the global varaible object.
1016 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
1018 Improve names of some ApplicationCacheStorage accessor methods
1019 https://bugs.webkit.org/show_bug.cgi?id=64433
1021 Reviewed by Alexey Proskuryakov.
1023 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1024 (-[WebApplicationCacheQuotaManager usage]):
1025 (-[WebApplicationCacheQuotaManager quota]):
1028 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
1030 ApplicationCache update should not immediately fail when reaching per-origin quota
1031 https://bugs.webkit.org/show_bug.cgi?id=64177
1033 Reviewed by Alexey Proskuryakov.
1035 * WebView/WebUIDelegatePrivate.h:
1036 * DefaultDelegates/WebDefaultUIDelegate.m:
1037 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
1038 Update the delegate to include a space needed parameter.
1040 * WebCoreSupport/WebChromeClient.h:
1041 * WebCoreSupport/WebChromeClient.mm:
1042 (WebChromeClient::reachedApplicationCacheOriginQuota):
1043 Call the delegate with the new space needed information.
1045 2011-07-12 Adam Roben <aroben@apple.com>
1047 Delete some redundant code in WebHTMLView
1049 This code had no user-visible effect, as we were just duplicating work that AppKit would do
1050 for us at a slightly different time.
1052 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily
1054 Reviewed by Simon Fraser.
1056 * WebView/WebHTMLView.mm:
1057 (-[WebHTMLView viewDidMoveToWindow]):
1058 (-[WebHTMLView attachRootLayer:]):
1059 Don't bother setting the root layer's transform to account for the scale factor. AppKit
1060 takes care of this for us nowadays.
1062 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
1064 Let plugins participate in form submission
1065 https://bugs.webkit.org/show_bug.cgi?id=13061
1067 Adds methods to get form value from NPAPI plugins.
1069 Reviewed by Anders Carlsson.
1071 * Plugins/Hosted/WebHostedNetscapePluginView.h:
1072 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1073 (-[WebHostedNetscapePluginView getFormValue:]): Added.
1074 * Plugins/WebBaseNetscapePluginView.h:
1075 * Plugins/WebBaseNetscapePluginView.mm:
1076 (-[WebBaseNetscapePluginView getFormValue:]): Added.
1077 * Plugins/WebNetscapePluginPackage.h:
1078 * Plugins/WebNetscapePluginPackage.mm:
1079 (-[WebNetscapePluginPackage browserFuncs]): Added.
1080 * Plugins/WebNetscapePluginView.h:
1081 * Plugins/WebNetscapePluginView.mm:
1082 (-[WebNetscapePluginView getFormValue:]): Added.
1083 * WebCoreSupport/WebFrameLoaderClient.mm:
1084 (NetscapePluginWidget::getFormValue): Added.
1086 2011-07-04 Dan Bernstein <mitz@apple.com>
1088 Moved handling of frame size changes into its own method.
1090 Reviewed by Oliver Hunt.
1092 * WebView/WebFrameView.mm:
1093 (-[WebFrameView _frameSizeChanged]): Added. Moved code here...
1094 (-[WebFrameView setFrameSize:]): ...from here.
1095 * WebView/WebFrameViewInternal.h:
1097 2011-07-01 Adele Peterson <adele@apple.com>
1099 Reviewed by Darin Adler.
1101 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
1102 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
1104 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1105 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
1106 space, and after-white-space properties to subframes in the editable document.
1108 2011-07-01 Andy Estes <aestes@apple.com>
1110 Reviewed by Mark Rowe.
1112 Simplify MailQuirksUserScript.js
1113 https://bugs.webkit.org/show_bug.cgi?id=63800
1115 MailQuirksUserScript.js is injected into WebViews in Mail.app on
1116 Leopard to resolve an incompatibility between it and the HTML5 parser.
1117 It did so by taking all nodes in the document between <html> and <body>
1118 and moving them to be children of <body>. This maintains Mail.app's
1119 assumption that document.firstChild.firstChild == document.body.
1121 While this script fixed a specific issue with the Signature panel in
1122 Mail.app, it caused regressions in other WebViews. Since the issue with
1123 the Signature panel is with the empty <head> node implicitly created by
1124 the parser, we can simplify this script by removing this implicit
1125 <head> in the case it has no attributes and no children. This fixes the
1126 Signature panel without affecting other WebViews that have non-trivial
1129 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
1130 and no children, remove it.
1132 2011-06-30 Dan Bernstein <mitz@apple.com>
1134 Reviewed by Adele Peterson.
1136 Add +[WebView _allowsRoundingHacks]
1137 https://bugs.webkit.org/show_bug.cgi?id=63734
1139 * WebView/WebView.mm:
1140 (+[WebView _allowsRoundingHacks]): Added this accessor.
1141 * WebView/WebViewPrivate.h:
1143 2011-06-29 Darin Adler <darin@apple.com>
1145 Reviewed by Dan Bernstein.
1147 [Mac] Use system cursors instead of custom bitmaps where possible
1148 https://bugs.webkit.org/show_bug.cgi?id=63679
1150 * WebCoreSupport/WebSystemInterface.mm:
1151 (InitWebCoreSystemInterface): Added WKCursor.
1153 2011-06-28 Ilya Sherman <isherman@chromium.org>
1155 Reviewed by Adam Barth.
1157 form.autocomplete="off" does not work
1158 https://bugs.webkit.org/show_bug.cgi?id=35823
1160 * WebView/WebHTMLRepresentation.mm:
1161 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
1163 2011-06-26 Mark Rowe <mrowe@apple.com>
1165 Reviewed by Dan Bernstein.
1167 Use a separate file name for Lion's WebKitSystemInterface.
1169 * Configurations/DebugRelease.xcconfig:
1171 2011-06-24 Dan Bernstein <mitz@apple.com>
1173 Reviewed by Anders Carlsson.
1175 Add an option to enable legacy rounding hacks
1176 https://bugs.webkit.org/show_bug.cgi?id=63363
1178 * Misc/WebKitNSStringExtras.mm:
1179 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1180 Disabled rounding hacks.
1181 (-[NSString _web_widthWithFont:]): Ditto.
1182 * WebView/WebView.mm:
1183 (+[WebView _setAllowsRoundingHacks:]): Added this setter.
1184 * WebView/WebViewPrivate.h:
1186 2011-06-24 Dominic Cooney <dominicc@chromium.org>
1188 Reviewed by Dimitri Glazkov.
1190 Convert shadow DOM-related tests to use window.internals
1191 https://bugs.webkit.org/show_bug.cgi?id=61671
1193 Remove shadow DOM-related methods from Mac API. These are not
1196 * DOM/WebDOMOperations.mm:
1197 * DOM/WebDOMOperationsPrivate.h:
1199 2011-06-24 Yuta Kitamura <yutak@chromium.org>
1201 Reviewed by Adam Barth.
1203 WebSocket: Add run-time flag for new HyBi protocol
1204 https://bugs.webkit.org/show_bug.cgi?id=60348
1206 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
1207 switchable from WebView and WebPreferences.
1209 * WebView/WebPreferenceKeysPrivate.h:
1210 * WebView/WebPreferences.mm:
1211 (+[WebPreferences initialize]):
1212 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
1213 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
1214 * WebView/WebPreferencesPrivate.h:
1215 * WebView/WebView.mm:
1216 (-[WebView _preferencesChanged:]):
1218 2011-06-22 Sam Weinig <sam@webkit.org>
1220 Roll out r89469 (Add preference for setting the html parser depth limit)
1222 The preference is not needed at this time, so there is no reason to expose it.
1224 * WebView/WebPreferenceKeysPrivate.h:
1225 * WebView/WebPreferences.mm:
1226 (+[WebPreferences initialize]):
1227 * WebView/WebPreferencesPrivate.h:
1228 * WebView/WebView.mm:
1229 (-[WebView _preferencesChanged:]):
1231 2011-06-22 Sam Weinig <sam@webkit.org>
1233 Reviewed by Adam Barth.
1235 Add preference for setting the html parser depth limit
1236 https://bugs.webkit.org/show_bug.cgi?id=63163
1238 * WebView/WebPreferenceKeysPrivate.h:
1239 * WebView/WebPreferences.mm:
1240 (+[WebPreferences initialize]):
1241 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
1242 (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
1243 * WebView/WebPreferencesPrivate.h:
1244 * WebView/WebView.mm:
1245 (-[WebView _preferencesChanged:]):
1246 Add private preference for setting the parser depth limit.
1248 2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
1250 Reviewed by Darin Adler.
1252 Make instantiation of legacy editing position more explicit
1253 https://bugs.webkit.org/show_bug.cgi?id=63037
1255 Create new positions since we can't create a legacy editing position outside of WebCore anymore.
1257 * WebView/WebFrame.mm:
1258 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
1259 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1261 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
1263 Reviewed by Kent Tamura.
1265 FileChooser should be only created when we need to choose files.
1266 https://bugs.webkit.org/show_bug.cgi?id=63039
1268 * WebCoreSupport/WebChromeClient.mm:
1269 (WebChromeClient::runOpenPanel): Changed to use settings.
1271 2011-06-21 MORITA Hajime <morrita@google.com>
1273 Unreviewed, rolling out r89401 and r89403.
1274 http://trac.webkit.org/changeset/89401
1275 http://trac.webkit.org/changeset/89403
1276 https://bugs.webkit.org/show_bug.cgi?id=62970
1278 Breaks mac build and mistakenly enables the spellcheck API
1280 * Configurations/FeatureDefines.xcconfig:
1282 2011-06-20 MORITA Hajime <morrita@google.com>
1284 Reviewed by Kent Tamura.
1286 Spellcheck API should be build-able.
1287 https://bugs.webkit.org/show_bug.cgi?id=62970
1289 No new tests, changing only build related files
1291 * Configurations/FeatureDefines.xcconfig:
1293 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
1295 Unreviewed, rolling out r89354.
1296 http://trac.webkit.org/changeset/89354
1297 https://bugs.webkit.org/show_bug.cgi?id=63099
1299 Broke tests on Mac (Requested by rniwa on #webkit).
1301 * WebCoreSupport/WebInspectorClient.mm:
1302 (-[WebInspectorWindowController destroyInspectorView:]):
1303 * WebInspector/WebInspector.mm:
1304 (-[WebInspector show:]):
1305 (-[WebInspector showConsole:]):
1306 (-[WebInspector isDebuggingJavaScript]):
1307 (-[WebInspector toggleDebuggingJavaScript:]):
1308 (-[WebInspector startDebuggingJavaScript:]):
1309 (-[WebInspector stopDebuggingJavaScript:]):
1310 (-[WebInspector isProfilingJavaScript]):
1311 (-[WebInspector toggleProfilingJavaScript:]):
1312 (-[WebInspector startProfilingJavaScript:]):
1313 (-[WebInspector stopProfilingJavaScript:]):
1314 (-[WebInspector isJavaScriptProfilingEnabled]):
1315 (-[WebInspector setJavaScriptProfilingEnabled:]):
1316 (-[WebInspector isTimelineProfilingEnabled]):
1317 (-[WebInspector setTimelineProfilingEnabled:]):
1318 (-[WebInspector setFrontend:]):
1319 (-[WebInspector showWindow:]):
1320 * WebInspector/WebInspectorFrontend.h:
1321 * WebInspector/WebInspectorFrontend.mm:
1322 * WebInspector/WebInspectorPrivate.h:
1324 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
1326 Reviewed by Yury Semikhatsky.
1328 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
1329 https://bugs.webkit.org/show_bug.cgi?id=62985
1331 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
1332 methods for plumbing the menu action handlers through the WebKit and WebCore.
1333 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
1334 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
1335 WebKit/win and WebKit2 to follow.
1337 * WebCoreSupport/WebInspectorClient.mm:
1338 (-[WebInspectorWindowController destroyInspectorView:]):
1339 * WebInspector/WebInspector.mm:
1340 (-[WebInspector showWindow]):
1341 (-[WebInspector show:]):
1342 (-[WebInspector showConsole:]):
1343 (-[WebInspector isDebuggingJavaScript]):
1344 (-[WebInspector toggleDebuggingJavaScript:]):
1345 (-[WebInspector startDebuggingJavaScript:]):
1346 (-[WebInspector stopDebuggingJavaScript:]):
1347 (-[WebInspector isProfilingJavaScript]):
1348 (-[WebInspector toggleProfilingJavaScript:]):
1349 (-[WebInspector startProfilingJavaScript:]):
1350 (-[WebInspector stopProfilingJavaScript:]):
1351 (-[WebInspector isJavaScriptProfilingEnabled]):
1352 (-[WebInspector setJavaScriptProfilingEnabled:]):
1353 (-[WebInspector isTimelineProfilingEnabled]):
1354 (-[WebInspector setTimelineProfilingEnabled:]):
1355 (-[WebInspector setFrontend:]):
1356 (-[WebInspector releaseFrontend]):
1357 (-[WebInspector showWindow:]):
1358 * WebInspector/WebInspectorFrontend.h:
1359 * WebInspector/WebInspectorFrontend.mm:
1360 (-[WebInspectorFrontend isDebuggingEnabled]):
1361 (-[WebInspectorFrontend setDebuggingEnabled:]):
1362 (-[WebInspectorFrontend isProfilingJavaScript]):
1363 (-[WebInspectorFrontend startProfilingJavaScript]):
1364 (-[WebInspectorFrontend stopProfilingJavaScript]):
1365 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
1366 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
1367 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
1368 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
1369 * WebInspector/WebInspectorPrivate.h:
1371 2011-06-01 Jer Noble <jer.noble@apple.com>
1373 Reviewed by Eric Carlson.
1375 Move Full Screen Controllers into WebCore.
1377 Remove dependency on QTKit from wekitExitFullscreen()
1378 https://bugs.webkit.org/show_bug.cgi?id=61843
1380 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
1381 have been moved into WebCore.
1383 * WebCoreSupport/WebSystemInterface.mm:
1384 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
1385 * WebView/WebFullScreenController.mm: Remove unused #include.
1386 * WebView/WebView.mm: Change the include location of
1387 WebVideoFullscreenController.h
1389 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
1391 Reviewed by Darin Adler.
1393 Separate concerns of loading file icons and choosing files.
1394 https://bugs.webkit.org/show_bug.cgi?id=62931
1396 * WebCoreSupport/WebChromeClient.h:
1397 * WebCoreSupport/WebChromeClient.mm:
1398 (WebChromeClient::loadIconForFiles): Renamed.
1400 2011-06-18 Andrew Wellington <andrew@webkit.org>
1402 Reviewed by Alexey Proskuryakov.
1404 https://bugs.webkit.org/show_bug.cgi?id=62843
1405 WebKit Mac API calls didReceiveAuthenticationChallenge instead of
1406 didCancelAuthenticationChallenge
1408 * WebView/WebView.mm:
1409 (-[WebView _cacheResourceLoadDelegateImplementations]):
1411 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
1413 Unreviewed, rolling out r89026.
1414 http://trac.webkit.org/changeset/89026
1415 https://bugs.webkit.org/show_bug.cgi?id=62804
1417 These patches were likely correct. I'll investigate the
1418 browser_test failures. (Requested by abarth on #webkit).
1420 * WebView/WebVideoFullscreenHUDWindowController.mm:
1421 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1423 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
1427 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
1428 https://bugs.webkit.org/show_bug.cgi?id=62796
1430 The patches broke chromium browser tests.
1432 * WebView/WebVideoFullscreenHUDWindowController.mm:
1433 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1435 2011-06-16 Adam Barth <abarth@webkit.org>
1437 Reviewed by Eric Seidel.
1439 Remove HTMLVideoElement::processingUserGesture
1440 https://bugs.webkit.org/show_bug.cgi?id=62784
1442 * WebView/WebVideoFullscreenHUDWindowController.mm:
1443 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1445 2011-06-15 Adam Barth <abarth@webkit.org>
1447 Reviewed by Eric Seidel.
1449 Remove ScriptController::setAllowPopupsFromPlugin
1450 https://bugs.webkit.org/show_bug.cgi?id=62706
1452 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1453 (WebKit::NetscapePluginInstanceProxy::evaluate):
1454 * Plugins/WebNetscapePluginView.mm:
1455 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
1457 2011-06-15 David Kilzer <ddkilzer@apple.com>
1459 <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
1461 Reviewed by Joseph Pecoraro.
1463 * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
1464 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1465 Added static_cast<MetaDataInfo *>.
1467 2011-06-14 Stephanie Lewis <slewis@apple.com>
1469 Rubber stamped by Oliver Hunt.
1471 <rdar://problem/9511169>
1476 2011-06-13 Kentaro Hara <haraken@google.com>
1478 Reviewed by Alexey Proskuryakov.
1480 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
1481 https://bugs.webkit.org/show_bug.cgi?id=61256
1483 In order to prevent rounding error caused by expanding/shrinking a page
1484 using different calculation here and there, I added a common calculation
1485 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
1486 keeping the ratio of width and height of the original page.
1487 [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
1488 and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
1489 use resizePageRectsKeepingRatio() to expand/shrink a page.
1491 Test: printing/page-count-with-one-word.html
1493 * WebView/WebHTMLView.mm:
1494 (-[WebHTMLView _web_setPrintingModeRecursive]):
1495 (-[WebHTMLView _web_clearPrintingModeRecursive]):
1496 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
1497 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
1498 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
1499 (-[WebHTMLView _endPrintMode]):
1500 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
1501 (-[WebHTMLView _endScreenPaginationMode]):
1502 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
1503 (-[WebHTMLView layout]):
1504 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1505 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
1506 (-[WebHTMLView setPageWidthForPrinting:]):
1508 2011-06-13 Tony Chang <tony@chromium.org>
1510 Reviewed by Dimitri Glazkov.
1512 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1513 https://bugs.webkit.org/show_bug.cgi?id=62578
1515 * Configurations/FeatureDefines.xcconfig:
1517 2011-06-13 Tony Chang <tony@chromium.org>
1519 Reviewed by Adam Barth.
1521 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1522 https://bugs.webkit.org/show_bug.cgi?id=62545
1524 * Configurations/FeatureDefines.xcconfig:
1526 2011-06-12 Adam Barth <abarth@webkit.org>
1528 Reviewed by Alexey Proskuryakov.
1530 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
1531 https://bugs.webkit.org/show_bug.cgi?id=62516
1533 * WebCoreSupport/WebFrameLoaderClient.h:
1534 * WebCoreSupport/WebFrameLoaderClient.mm:
1535 (WebFrameLoaderClient::interruptedForPolicyChangeError):
1537 2011-06-12 Adam Barth <abarth@webkit.org>
1539 Reviewed by Eric Seidel.
1541 Remove FrameLoader::isProcessingUserGesture
1542 https://bugs.webkit.org/show_bug.cgi?id=62519
1544 * WebView/WebView.mm:
1545 (-[WebView _isProcessingUserGesture]):
1547 2011-06-12 Adam Barth <abarth@webkit.org>
1549 Reviewed by Alexey Proskuryakov.
1551 Remove trival "forward-to-client" member functions from FrameLoader
1552 https://bugs.webkit.org/show_bug.cgi?id=62510
1554 * WebCoreSupport/WebFrameNetworkingContext.mm:
1555 (WebFrameNetworkingContext::blockedError):
1557 2011-06-10 Tony Chang <tony@chromium.org>
1559 Reviewed by Ojan Vafai.
1561 add a compile guard ENABLE(FLEXBOX)
1562 https://bugs.webkit.org/show_bug.cgi?id=62049
1564 * Configurations/FeatureDefines.xcconfig:
1566 2011-06-06 Michael Saboff <msaboff@apple.com>
1568 Reviewed by Geoffrey Garen.
1570 Fonts returned by FontCache::getFontDataForCharacters() are never released
1571 https://bugs.webkit.org/show_bug.cgi?id=61875
1573 This change allows fonts allocated as system fallback fonts to be
1574 released. Previously, the reference counts for these fonts grew
1575 without bound. This is implemented as an auto release class that wraps
1576 accesses to the cache for system fallback fonts. All such accesses are
1577 via the method FontCache::getFontDataForCharacters. The new class is
1578 called FontCachePurgePreventer. When such an object exists, it protects
1579 these fonts from deletion.
1581 See more comments for this defect in Source/WebCore/ChangeLog.
1583 * Misc/WebKitNSStringExtras.mm:
1584 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1585 (-[NSString _web_widthWithFont:]):
1586 Wrapped code accessing fallback fonts with local
1587 FontCachePurgePreventer in these methods.
1589 * Misc/WebStringTruncator.mm:
1590 (+[WebStringTruncator centerTruncateString:toWidth:]):
1591 (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
1592 (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
1593 (+[WebStringTruncator widthOfString:font:]):
1594 Wrapped code accessing fallback fonts with local
1595 FontCachePurgePreventer in these methods.
1597 2011-06-06 Peter Kasting <pkasting@google.com>
1599 Reviewed by Antonio Gomes.
1601 Remove unnecessary args from scroll functions.
1602 https://bugs.webkit.org/show_bug.cgi?id=61648
1604 * WebView/WebFrame.mm:
1605 (-[WebFrame _scrollDOMRangeToVisible:]):
1607 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
1609 Reviewed by Kent Tamura.
1611 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
1612 https://bugs.webkit.org/show_bug.cgi?id=61628
1614 * Configurations/FeatureDefines.xcconfig:
1616 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
1618 Reviewed by Kent Tamura.
1620 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
1621 https://bugs.webkit.org/show_bug.cgi?id=61631
1623 * Configurations/FeatureDefines.xcconfig:
1625 2011-06-02 Anders Carlsson <andersca@apple.com>
1627 Reviewed by Sam Weinig.
1629 Need a way to install the memory pressure handler without initializing WebKit1
1630 https://bugs.webkit.org/show_bug.cgi?id=61975
1632 Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
1633 -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
1634 but we'd like to be able to install a memory pressure handler without creating a WebView or even
1635 calling any WebView method since that will call +[WebView initialize].
1638 * WebView/WebView.mm:
1639 (WebInstallMemoryPressureHandler):
1640 * WebView/WebViewPrivate.h:
1642 2011-05-27 Stephanie Lewis <slewis@apple.com>
1646 Fix a typo in the order_file flag.
1648 * Configurations/Base.xcconfig:
1650 2011-05-27 Stephanie Lewis <slewis@apple.com>
1652 Rubber Stamped by Adam Roben.
1654 Update Order Files. Use -order_file flag since it can order more of the binary.
1656 * Configurations/Base.xcconfig:
1659 2011-05-25 Stephanie Lewis <slewis@apple.com>
1661 Reviewed by Brady Eidson.
1663 https://bugs.webkit.org/show_bug.cgi?id=61407
1664 part of <rdar://problem/8675177>
1665 Remove Quicklook pref. Moving it enirely down into WebCore so it can
1666 be calculated only on reloads.
1668 * WebView/WebPreferenceKeysPrivate.h:
1669 * WebView/WebPreferences.mm:
1670 (+[WebPreferences initialize]):
1671 * WebView/WebPreferencesPrivate.h:
1672 * WebView/WebView.mm:
1673 (-[WebView _preferencesChanged:]):
1675 2011-05-24 Jer Noble <jer.noble@apple.com>
1677 Reviewed by Darin Adler.
1679 Video fails to play on Vimeo
1680 https://bugs.webkit.org/show_bug.cgi?id=61403
1682 * WebCoreSupport/WebSystemInterface.mm:
1683 (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
1684 wkQTMovieResolvedURL.
1686 2011-05-24 Keishi Hattori <keishi@webkit.org>
1688 Reviewed by Kent Tamura.
1690 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
1691 https://bugs.webkit.org/show_bug.cgi?id=61273
1693 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
1695 2011-05-24 Adam Barth <abarth@webkit.org>
1697 Reviewed by Eric Seidel.
1699 Add FIXME comments about removing FrameLoader::isProcessingUserGesture
1700 https://bugs.webkit.org/show_bug.cgi?id=61395
1702 * WebView/WebView.mm:
1703 (-[WebView _isProcessingUserGesture]):
1705 2011-05-24 Michael Saboff <msaboff@apple.com>
1707 Reviewed by Geoffrey Garen.
1709 Improve handling in WebCore of low memory situations
1710 https://bugs.webkit.org/show_bug.cgi?id=61222
1712 Added call to enable memory pressure handling.
1714 * WebView/WebView.mm:
1715 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1716 * WebView/WebViewInternal.h:
1718 2011-05-24 Jay Civelli <jcivelli@chromium.org>
1720 Rubberstamped by David Kilzer.
1722 Updated some files that I forgot in my previous MHTML CL.
1724 * Configurations/FeatureDefines.xcconfig:
1726 2011-05-20 Jeremy Noble <jer.noble@apple.com>
1728 Reviewed by Simon Fraser.
1730 Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
1731 https://bugs.webkit.org/show_bug.cgi?id=61224
1733 Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
1736 * WebView/WebFullScreenController.mm:
1737 (-[WebFullScreenController windowDidEnterFullscreen:]):
1738 (-[WebFullScreenController enterFullscreen:]):
1739 (-[WebFullScreenController exitFullscreen]):
1740 (-[WebFullscreenWindow setRendererLayer:]):
1742 2011-05-20 Andy Estes <aestes@apple.com>
1744 Reviewed by Darin Adler.
1746 WebView loses firstResponder status when entering full-screen mode.
1747 https://bugs.webkit.org/show_bug.cgi?id=61153
1749 * Misc/WebNSWindowExtras.h:
1750 * Misc/WebNSWindowExtras.m:
1751 (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
1752 convenience method to NSWindow that makes the given NSResponder first
1753 responder only if it is a descendant of the given view.
1754 * WebView/WebFullScreenController.mm:
1755 (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
1756 was a descendant of the browser window's first responder when entering
1757 full-screen mode, set the full-screen window's first responder to that
1759 (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
1760 done in windowDidEnterFullscreen:.
1762 2011-05-20 Enrica Casucci <enrica@apple.com>
1764 Reviewed by David Kilzer.
1766 Add delegate methods about focus and blur to all elements.
1767 https://bugs.webkit.org/show_bug.cgi?id=61218
1769 We want to have delegates for these events for all the elements, not only the form elements.
1770 The patch changes the name of the methods in a way that is not form element specific.
1772 * WebCoreSupport/WebChromeClient.h:
1773 * WebCoreSupport/WebChromeClient.mm:
1774 (WebChromeClient::elementDidFocus):
1775 (WebChromeClient::elementDidBlur):
1776 * WebView/WebUIDelegatePrivate.h:
1778 2011-05-20 Simon Fraser <simon.fraser@apple.com>
1780 Reviewed by Sam Weinig.
1782 numberOfActiveAnimations() can include animations from documents in the page cache
1783 https://bugs.webkit.org/show_bug.cgi?id=53641
1785 Pass the Frame's document as the one to count animations on.
1787 * WebView/WebFrame.mm:
1788 (-[WebFrame _numberOfActiveAnimations]):
1790 2011-05-17 Timothy Hatcher <timothy@apple.com>
1792 Update the the context menu to reflect the system search provider on Mac.
1794 <rdar://problem/9198419>
1796 Reviewed by Sam Weinig.
1798 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1799 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
1800 create the web search context menu title.
1801 * WebCoreSupport/WebSystemInterface.mm:
1802 (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
1804 2011-05-16 Emil A Eklund <eae@chromium.org>
1806 Reviewed by Eric Seidel.
1808 Replace docTop/Right/Bottom/Left/Width/Height with documentRect
1809 https://bugs.webkit.org/show_bug.cgi?id=60743
1811 Replace uses of docWidth/Height with documentRect.
1813 * WebView/WebFrame.mm:
1814 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
1816 2011-05-16 Yuzo Fujishima <yuzo@google.com>
1818 Reviewed by Antti Koivisto.
1820 Fix for Bug 43704 - Web font is printed as blank if it is not cached
1821 https://bugs.webkit.org/show_bug.cgi?id=43704
1823 * WebView/WebHTMLView.mm:
1824 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
1826 2011-05-16 David Kilzer <ddkilzer@apple.com>
1828 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1829 <rdar://problem/9446430>
1831 Reviewed by Mark Rowe.
1833 * Configurations/Base.xcconfig: Fixed typo.
1835 2011-05-13 Jon Lee <jonlee@apple.com>
1837 Reviewed by Simon Fraser.
1839 Can't horizontally scroll iframes and overflow because wheel events are always accepted
1840 https://bugs.webkit.org/show_bug.cgi?id=60779
1842 * WebCoreSupport/WebChromeClient.h:
1843 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1844 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
1846 2011-05-13 Sam Weinig <sam@webkit.org>
1848 Reviewed by Anders Carlsson.
1850 Prune #includes from FrameView.h (Part 2)
1851 https://bugs.webkit.org/show_bug.cgi?id=60748
1853 - Update files that were depending on FrameView.h #including Frame.h or
1856 * WebView/WebClipView.mm:
1857 * WebView/WebHTMLView.mm:
1858 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
1860 2011-05-12 Pratik Solanki <psolanki@apple.com>
1862 Reviewed by Antti Koivisto.
1864 Part of WebCore should use CFNetwork-based loader on Mac
1865 https://bugs.webkit.org/show_bug.cgi?id=51836
1867 Use CFRunLoop when using CFNetwork.
1869 * WebView/WebView.mm:
1870 (-[WebView scheduleInRunLoop:forMode:]):
1871 (-[WebView unscheduleFromRunLoop:forMode:]):
1873 2011-05-12 Pratik Solanki <psolanki@apple.com>
1875 Reviewed by Antti Koivisto.
1877 Part of WebCore should use CFNetwork-based loader on Mac
1878 https://bugs.webkit.org/show_bug.cgi?id=51836
1880 Include AuthenticationCF.h header file.
1882 * Misc/WebDownload.mm:
1883 * Plugins/WebBaseNetscapePluginView.mm:
1884 * WebCoreSupport/WebFrameLoaderClient.mm:
1886 2011-05-12 Adele Peterson <adele@apple.com>
1888 Reviewed by Darin Adler and Adam Barth.
1890 Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
1891 https://bugs.webkit.org/show_bug.cgi?id=60685
1893 Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
1894 we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
1896 * Misc/SolarWalkQuirksUserScript.js: Added.
1897 * WebView/WebView.mm:
1898 (needsSolarWalkQuirksScript):
1899 (leakSolarWalkQuirksUserScriptContents):
1900 (-[WebView _injectSolarWalkQuirksScript]):
1901 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1903 2011-05-12 Jia Pu <jpu@apple.com>
1905 Reviewed by Darin Adler.
1907 Regression caused by changeset 86281
1908 https://bugs.webkit.org/show_bug.cgi?id=60712
1909 <rdar://problem/9427970>
1911 Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
1912 So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
1913 returns. So we don't need to use the condition to coordinate between these two function. In fact,
1914 all callbacks are delivered on main thread. We don't really need any locking here.
1916 Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
1919 * WebCoreSupport/CorrectionPanel.h:
1920 * WebCoreSupport/CorrectionPanel.mm:
1921 (CorrectionPanel::CorrectionPanel):
1922 (CorrectionPanel::show):
1923 (CorrectionPanel::dismiss):
1924 (CorrectionPanel::dismissInternal):
1925 (CorrectionPanel::handleAcceptedReplacement):
1926 * WebCoreSupport/WebEditorClient.mm:
1927 (WebEditorClient::dismissCorrectionPanelSoon):
1929 2011-05-12 Patrick Gansterer <paroga@webkit.org>
1931 Reviewed by Adam Barth.
1933 Enable OwnPtr strict mode in PluginHalter
1934 https://bugs.webkit.org/show_bug.cgi?id=60681
1936 * WebView/WebView.mm:
1937 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1939 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
1941 Reviewed by Darin Adler.
1943 String operator+ reallocates unnecessarily when concatting > 2 strings
1944 https://bugs.webkit.org/show_bug.cgi?id=58420
1946 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
1948 * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
1949 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
1951 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
1953 Reviewed by Darin Adler.
1955 Perform some forward declarations suggested by include-what-you-use
1956 https://bugs.webkit.org/show_bug.cgi?id=60545
1958 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1959 * WebView/WebFrame.mm:
1961 2011-05-11 Jia Pu <jpu@apple.com>
1963 Reviewed by Darin Adler.
1965 CorrectionPanel sometimes hangs in dismissSoon().
1966 https://bugs.webkit.org/show_bug.cgi?id=60599
1967 <rdar://problem/9313628>
1969 Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
1970 to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
1971 for condition checking.
1973 * WebCoreSupport/CorrectionPanel.h:
1974 * WebCoreSupport/CorrectionPanel.mm:
1975 (CorrectionPanel::CorrectionPanel):
1976 (CorrectionPanel::show):
1977 (CorrectionPanel::dismissSoon):
1978 (CorrectionPanel::dismissInternal):
1979 (CorrectionPanel::handleAcceptedReplacement):
1981 2011-05-10 Anton D'Auria <adauria@apple.com>
1983 Reviewed by David Levin.
1985 Add ApplicationCache API to get disk usage per origin
1986 https://bugs.webkit.org/show_bug.cgi?id=57127
1990 * WebCoreSupport/WebApplicationCache.h:
1991 * WebCoreSupport/WebApplicationCache.mm:
1992 (+[WebApplicationCache diskUsageForOrigin:]):
1994 2011-05-10 Anton D'Auria <adauria@apple.com>
1996 Reviewed by Alexey Proskuryakov.
1998 Add ApplicationCache API to get disk usage per origin
1999 https://bugs.webkit.org/show_bug.cgi?id=57127
2003 * WebCoreSupport/WebApplicationCache.h:
2004 * WebCoreSupport/WebApplicationCache.mm:
2005 (+[WebApplicationCache diskUsageForOrigin:]):
2007 2011-05-10 Beth Dakin <bdakin@apple.com>
2009 Reviewed by Darin Adler.
2011 https://bugs.webkit.org/show_bug.cgi?id=60582
2012 Crash switching overlay/non-overlay scrollbar preference still possible
2014 <rdar://problem/9323983>
2016 * WebCoreSupport/WebSystemInterface.mm:
2017 (InitWebCoreSystemInterface):
2019 2011-05-09 Jeremy Noble <jer.noble@apple.com>
2021 Reviewed by Darin Adler.
2023 Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
2024 https://bugs.webkit.org/show_bug.cgi?id=60496
2026 When animating into and out of full screen, order out and back in the original webView window,
2027 disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
2028 as the webView is hosted in the full screen window when we ask for it's parent window.
2030 * WebView/WebFullScreenController.mm:
2031 (-[WebFullScreenController windowDidEnterFullscreen:]):
2032 (-[WebFullScreenController exitFullscreen]):
2034 2011-05-04 Philippe Normand <pnormand@igalia.com>
2036 Reviewed by Dimitri Glazkov.
2038 Implement LayoutTestController::pseudoShadowId()
2039 https://bugs.webkit.org/show_bug.cgi?id=60034
2041 * DOM/WebDOMOperations.mm:
2042 (-[DOMElement _shadowPseudoId]):
2043 * DOM/WebDOMOperationsPrivate.h:
2045 2011-05-05 Dan Bernstein <mitz@apple.com>
2047 Reviewed by Simon Fraser.
2049 WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
2051 * WebCoreSupport/WebSystemInterface.mm:
2052 (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
2054 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
2056 Reviewed by Eric Seidel.
2058 Rename SelectionController to FrameSelection
2059 https://bugs.webkit.org/show_bug.cgi?id=60234
2061 * WebView/WebFrame.mm:
2062 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
2063 * WebView/WebFrameInternal.h:
2064 * WebView/WebHTMLView.mm:
2065 * WebView/WebTextCompletionController.mm:
2066 (-[WebTextCompletionController doCompletion]):
2067 * WebView/WebView.mm:
2069 2011-05-04 Cris Neckar <cdn@chromium.org>
2071 Reviewed by Adam Barth.
2073 Expose WebView directly through ChromeClient.
2074 https://bugs.webkit.org/show_bug.cgi?id=49902
2076 * WebCoreSupport/WebChromeClient.h:
2077 (WebChromeClient::webView):
2078 * WebView/WebFrame.mm:
2081 2011-05-04 Tao Bai <michaelbai@chromium.org>
2083 Reviewed by David Kilzer.
2085 Populate touch-icon url to FrameLoaderClient
2086 https://bugs.webkit.org/show_bug.cgi?id=59143
2088 Respect the interface change in FrameLoaderClient.
2090 * Configurations/FeatureDefines.xcconfig:
2091 * WebCoreSupport/WebFrameLoaderClient.h:
2092 * WebCoreSupport/WebFrameLoaderClient.mm:
2093 (WebFrameLoaderClient::dispatchDidChangeIcons):
2095 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
2097 Reviewed by Dimitri Glazkov.
2099 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
2100 https://bugs.webkit.org/show_bug.cgi?id=58703
2102 * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
2104 2011-05-02 Adam Roben <aroben@apple.com>
2106 Take advantage of implicit conversion from nullptr_t to PassOwnPtr
2108 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2109 doesn't work, but should
2111 Reviewed by Adam Barth.
2113 * History/WebHistory.mm:
2114 * Plugins/WebNetscapePluginEventHandler.mm:
2115 * WebView/WebView.mm:
2117 2011-05-02 Brady Eidson <beidson@apple.com>
2119 Reviewed by Anders Carlsson.
2121 <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
2122 In Aperture, a WebView might be dealloc'ed before it finishes loading.
2124 * WebView/WebView.mm:
2125 (needsSelfRetainWhileLoadingQuirk):
2126 (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
2127 (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
2128 (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
2129 (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
2131 2011-05-02 Adam Barth <abarth@webkit.org>
2133 Reviewed by David Levin.
2135 PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
2136 https://bugs.webkit.org/show_bug.cgi?id=59924
2138 * History/WebHistory.mm:
2139 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
2140 * Plugins/WebBaseNetscapePluginView.mm:
2141 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
2142 * WebCoreSupport/WebFrameLoaderClient.mm:
2143 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2144 * WebView/WebView.mm:
2145 (-[WebView _injectMailQuirksScript]):
2146 (-[WebView _injectOutlookQuirksScript]):
2149 2011-05-02 Sam Weinig <sam@webkit.org>
2151 Reviewed by Adam Barth.
2153 Prune some #includes from DOMWindow.h
2154 https://bugs.webkit.org/show_bug.cgi?id=59907
2156 * Plugins/WebBaseNetscapePluginView.mm:
2157 * WebView/WebFrame.mm:
2158 Add now missing SecurityOrigin.h #includes.
2160 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
2162 Reviewed by Eric Seidel.
2164 Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
2165 https://bugs.webkit.org/show_bug.cgi?id=59837
2167 Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
2169 * WebView/WebHTMLView.mm:
2170 (-[WebHTMLView menuForEvent:]):
2171 (-[WebHTMLView acceptsFirstMouse:]):
2172 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
2174 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
2176 Reviewed by Eric Seidel.
2178 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
2179 https://bugs.webkit.org/show_bug.cgi?id=59835
2181 Moved currentKeyboardEvent.
2183 * WebView/WebHTMLView.mm:
2184 (currentKeyboardEvent):
2185 (-[WebHTMLView becomeFirstResponder]):
2187 2011-04-29 Dean Jackson <dino@apple.com>
2189 Reviewed by Simon Fraser.
2191 Add ENABLE macro for WebKitAnimation
2192 https://bugs.webkit.org/show_bug.cgi?id=59729
2194 Add new feature to toggle WebKit Animation API.
2196 * Configurations/FeatureDefines.xcconfig:
2198 2011-04-28 David Kilzer <ddkilzer@apple.com>
2200 <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
2202 Reviewed by Anders Carlsson.
2204 * History/WebHistory.mm:
2205 (-[WebHistoryPrivate init]):
2206 * Misc/WebElementDictionary.mm:
2207 (-[WebElementDictionary initWithHitTestResult:]):
2208 * Misc/WebIconDatabase.mm:
2209 (-[WebIconDatabase init]):
2210 * Plugins/WebPluginController.mm:
2211 (-[WebPluginController initWithDocumentView:]):
2212 * Plugins/WebPluginRequest.m:
2213 (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
2214 * WebCoreSupport/WebEditorClient.mm:
2215 (-[WebEditCommand initWithEditCommand:]):
2216 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2217 (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
2218 * WebView/WebNavigationData.mm:
2219 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
2221 2011-04-28 David Levin <levin@chromium.org>
2223 Reviewed by Adam Barth.
2225 Remove IMAGE_RESIZER related code.
2226 https://bugs.webkit.org/show_bug.cgi?id=59735
2228 * Configurations/FeatureDefines.xcconfig:
2230 2011-04-28 Adam Barth <abarth@webkit.org>
2232 Reviewed by Eric Seidel.
2235 https://bugs.webkit.org/show_bug.cgi?id=59678
2237 Remove WML-related configuration options and private APIs.
2239 * Configurations/FeatureDefines.xcconfig:
2240 * WebCoreSupport/WebChromeClient.mm:
2241 (stringForMessageSource):
2242 * WebView/WebFramePrivate.h:
2243 * WebView/WebUIDelegatePrivate.h:
2245 2011-04-28 Brian Weinstein <bweinstein@apple.com>
2247 Reviewed by Timothy Hatcher.
2249 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
2250 https://bugs.webkit.org/show_bug.cgi?id=59747
2252 Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
2253 Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
2255 * WebCoreSupport/WebInspectorClient.mm:
2256 (-[WebInspectorWindowController showWebInspector:]):
2257 (-[WebInspectorWindowController showErrorConsole:]):
2258 (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
2259 (-[WebInspectorWindowController toggleProfilingJavaScript:]):
2260 (-[WebInspectorWindowController validateUserInterfaceItem:]):
2262 2011-04-28 David Kilzer <ddkilzer@apple.com>
2264 <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
2266 Reviewed by Dan Bernstein.
2268 * WebView/WebFullScreenController.mm:
2269 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
2270 Use a RetainPtr to hold the CALayer and to fix the leak.
2272 2011-04-28 David Kilzer <ddkilzer@apple.com>
2274 Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
2276 Addresses review comment from Darin Adler.
2278 * WebView/WebPDFView.mm:
2279 (-[WebPDFView menuForEvent:]): Use a local variable and -release
2280 instead of -autorelease.
2282 2011-04-28 Anders Carlsson <andersca@apple.com>
2284 Fix a thinko - separateRealmLabel is not an NSImageView.
2286 * Panels/WebAuthenticationPanel.h:
2288 2011-04-28 David Kilzer <ddkilzer@apple.com>
2290 <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
2292 Reviewed by Dan Bernstein.
2294 * WebView/WebPDFView.mm:
2295 (-[WebPDFView menuForEvent:]): Call -autorelease after copying
2296 each NSMenuItem. Regressed in r9566 for Bug 3711.
2298 2011-04-28 Enrica Casucci <enrica@apple.com>
2300 Reviewed by Beth Dakin.
2302 Momentum scroll tweak for WebKit.
2303 https://bugs.webkit.org/show_bug.cgi?id=59723
2304 <rdar://problem/9259933>
2306 * WebView/WebDynamicScrollBarsView.mm:
2307 (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
2309 2011-04-27 Anders Carlsson <andersca@apple.com>
2311 Follow-up Leopard build fix.
2313 * Carbon/HIViewAdapter.m:
2314 (_webkit_NSView_setNeedsDisplayInRect):
2316 2011-04-27 Anders Carlsson <andersca@apple.com>
2318 More clang++ 32-bit build fixes.
2320 * Carbon/CarbonWindowAdapter.mm:
2321 (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2322 (-[CarbonWindowAdapter setContentView:]):
2323 (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2324 * Carbon/HIViewAdapter.m:
2325 (_webkit_NSView_setNeedsDisplayInRect):
2326 * Panels/WebAuthenticationPanel.h:
2327 * Plugins/WebBaseNetscapePluginView.mm:
2328 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2329 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2331 * WebCoreSupport/WebChromeClient.mm:
2332 (WebChromeClient::scrollRectIntoView):
2333 * WebCoreSupport/WebViewFactory.mm:
2334 (-[WebViewFactory accessibilityConvertScreenRect:]):
2335 * WebView/WebFrameView.mm:
2336 (-[WebFrameView _scrollToBeginningOfDocument]):
2337 (-[WebFrameView _scrollToEndOfDocument]):
2338 * WebView/WebFullScreenController.mm:
2339 (-[WebFullScreenController windowDidEnterFullscreen:]):
2340 * WebView/WebHTMLView.mm:
2341 (-[WebHTMLView _hitViewForEvent:]):
2342 (coreGraphicsScreenPointForAppKitScreenPoint):
2343 * WebView/WebPDFView.mm:
2344 (-[WebPDFView setScrollPoint:]):
2346 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
2348 Reviewed by Pavel Feldman.
2350 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
2351 https://bugs.webkit.org/show_bug.cgi?id=44230
2353 Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
2354 inspector is closed.
2356 * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
2357 comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
2358 pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
2359 There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
2362 Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
2363 (-[WebInspectorWindowController initWithInspectedWebView:]):
2364 (-[WebInspectorWindowController close]):
2365 (-[WebInspectorWindowController showWindow:]):
2366 (-[WebInspectorWindowController setAttachedWindowHeight:]):
2367 (-[WebInspectorWindowController destroyInspectorView:]):
2369 2011-04-26 Sam Weinig <sam@webkit.org>
2371 Reviewed by David Hyatt.
2373 Remove Datagrid from the tree
2374 https://bugs.webkit.org/show_bug.cgi?id=59543
2376 * Configurations/FeatureDefines.xcconfig:
2379 2011-04-26 Dan Bernstein <mitz@apple.com>
2381 Reviewed by Mark Rowe.
2383 Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2385 * Configurations/Base.xcconfig:
2386 * Configurations/CompilerVersion.xcconfig: Added.
2388 2011-04-25 Adam Barth <abarth@webkit.org>
2390 Reviewed by David Levin.
2392 WebKit2 should play nice with strict OwnPtrs
2393 https://bugs.webkit.org/show_bug.cgi?id=59426
2395 Fix include ordering.
2397 * WebView/WebDeviceOrientationProviderMock.mm:
2399 2011-04-25 Adam Barth <abarth@webkit.org>
2401 Reviewed by David Levin.
2403 WebKit1 should build cleanly with strict OwnPtrs
2404 https://bugs.webkit.org/show_bug.cgi?id=59424
2406 * History/WebHistoryItem.mm:
2407 (-[WebHistoryItem initFromDictionaryRepresentation:]):
2408 * Plugins/WebNetscapePluginEventHandler.h:
2409 * Plugins/WebNetscapePluginEventHandler.mm:
2410 (WebNetscapePluginEventHandler::create):
2411 * Plugins/WebNetscapePluginView.mm:
2412 (-[WebNetscapePluginView createPlugin]):
2413 * WebView/WebDeviceOrientationProviderMock.mm:
2414 * WebView/WebTextIterator.mm:
2415 (-[WebTextIterator initWithRange:]):
2417 2011-04-25 Jon Lee <jonlee@apple.com>
2419 Reviewed by Maciej Stachowiak.
2421 Overlay scroller hard to see on pages with dark background (59183)
2422 https://bugs.webkit.org/show_bug.cgi?id=59183
2423 <rdar://problem/8975367>
2425 * WebCoreSupport/WebSystemInterface.mm:
2426 (InitWebCoreSystemInterface): adding method to allow changing style
2428 2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
2430 Unreviewed, rolling out r84740.
2431 http://trac.webkit.org/changeset/84740
2432 https://bugs.webkit.org/show_bug.cgi?id=59290
2434 change breaks apple internal builds and is incorrect
2435 (Requested by smfr on #webkit).
2437 * WebCoreSupport/WebSystemInterface.mm:
2438 (InitWebCoreSystemInterface):
2440 2011-04-22 Jon Lee <jonlee@apple.com>
2442 Reviewed by Beth Dakin.
2444 Overlay scroller hard to see on pages with dark background (59183)
2445 https://bugs.webkit.org/show_bug.cgi?id=59183
2446 <rdar://problem/8975367>
2448 * WebCoreSupport/WebSystemInterface.mm:
2449 (InitWebCoreSystemInterface): adding method to allow changing style
2451 2011-04-19 Jer Noble <jer.noble@apple.com>
2453 Reviewed by Daniel Bates.
2455 Full Screen from within an <iframe> does not cause <iframe> to resize.
2456 https://bugs.webkit.org/show_bug.cgi?id=58638
2458 Tests: fullscreen/full-screen-frameset-allowed.html
2459 fullscreen/full-screen-frameset-not-allowed.html
2461 Return the _element's document instead of the WKView's document, which
2462 will be different in the case of elements within <iframe>s.
2464 * WebView/WebFullScreenController.mm:
2465 (-[WebFullScreenController _document]):
2467 2011-04-22 Jer Noble <jer.noble@apple.com>
2469 Reviewed by Maciej Stachowiak.
2471 Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
2472 https://bugs.webkit.org/show_bug.cgi?id=59147
2474 Add a new user default preference, and plumb that preference down to WebCore
2475 Settings. Allow the fullScreenEnabled preference to override the new
2476 isAVFoundationEnabled preference, so that clients of the legacy full screen
2477 mode will continue to use that mode normally.
2479 * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
2480 * WebView/WebPreferences.mm:
2481 (+[WebPreferences initialize]): Set the default value of new
2483 (-[WebPreferences setAVFoundationEnabled:]): Added.
2484 (-[WebPreferences isAVFoundationEnabled]): Added.
2485 * WebView/WebPreferencesPrivate.h:
2486 * WebView/WebView.mm:
2487 (-[WebView _preferencesChanged:]): Update the WebCore settings with the
2488 new values from WebPreferences.
2490 2011-04-22 Sam Weinig <sam@webkit.org>
2492 Reviewed by Gavin Barraclough.
2494 Remove remaining uses of deprecated version of toJS
2495 https://bugs.webkit.org/show_bug.cgi?id=59170
2497 * DOM/WebDOMOperations.mm:
2498 (-[DOMElement _shadowRoot:]):
2499 (-[DOMElement _ensureShadowRoot:]):
2500 Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2502 2011-04-21 Maciej Stachowiak <mjs@apple.com>
2504 Reviewed by Adam Roben.
2506 Add a feature define to allow <details> and <summary> to be disabled
2507 https://bugs.webkit.org/show_bug.cgi?id=59118
2508 <rdar://problem/9257045>
2510 * Configurations/FeatureDefines.xcconfig:
2512 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
2514 Reviewed by Sam Weinig.
2516 Add Frame* to the argument lists of canCopyCut and canPaste
2517 https://bugs.webkit.org/show_bug.cgi?id=59153
2519 * WebCoreSupport/WebEditorClient.h:
2520 * WebCoreSupport/WebEditorClient.mm:
2521 (WebEditorClient::canCopyCut):
2522 (WebEditorClient::canPaste):
2524 2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
2526 Unreviewed, rolling out r82052.
2527 http://trac.webkit.org/changeset/82052
2528 https://bugs.webkit.org/show_bug.cgi?id=59135
2530 New full screen api should be opt-in, not opt-out. (Requested
2531 by jernoble on #webkit).
2533 * WebView/WebPreferences.mm:
2534 (+[WebPreferences initialize]):
2536 2011-04-21 Beth Dakin <bdakin@apple.com>
2538 Reviewed by Dan Bernstein.
2540 https://bugs.webkit.org/show_bug.cgi?id=59048
2541 Need to track whether overlay scrollbar is currently visible and in lower-
2544 <rdar://problem/9211232>
2546 A new WebSystemInterface is needed for this.
2547 * WebCoreSupport/WebSystemInterface.mm:
2548 (InitWebCoreSystemInterface):
2550 2011-04-21 Dirk Schulze <krit@webkit.org>
2552 Reviewed by Nikolas Zimmermann.
2554 SVG feDropShadow implementation of SVG Filters 1.2
2555 https://bugs.webkit.org/show_bug.cgi?id=52513
2557 * MigrateHeaders.make:
2559 2011-04-20 Dominic Cooney <dominicc@chromium.org>
2561 Reviewed by Dimitri Glazkov.
2563 layoutTestController can create and destroy shadow DOM
2564 https://bugs.webkit.org/show_bug.cgi?id=59058
2566 Support for new methods in Mac DRT.
2568 * DOM/WebDOMOperations.mm:
2569 (-[DOMElement _ensureShadowRoot:]):
2570 (-[DOMElement _removeShadowRoot]):
2571 * DOM/WebDOMOperationsPrivate.h:
2573 2011-04-20 Eric Carlson <eric.carlson@apple.com>
2575 Reviewed by Dan Bernstein.
2577 Adopt QTKit API for listing and deleting file in its media cache.
2578 <rdar://problem/9130029>
2580 * WebCoreSupport/WebSystemInterface.mm:
2581 (InitWebCoreSystemInterface): Initialize new functions.
2583 2011-04-19 Matthew Delaney <mdelaney@apple.com>
2585 Reviewed by Simon Fraser.
2587 WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
2588 https://bugs.webkit.org/show_bug.cgi?id=58936
2590 * WebView/WebPreferences.mm:
2591 (+[WebPreferences initialize]):
2593 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
2595 Reviewed by Pavel Feldman.
2597 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
2598 https://bugs.webkit.org/show_bug.cgi?id=58883
2600 * WebCoreSupport/WebFrameLoaderClient.h:
2601 * WebCoreSupport/WebFrameLoaderClient.mm:
2602 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2604 2011-04-18 Jia Pu <jpu@apple.com>
2606 Reviewed by Mark Rowe.
2608 WebKit needs to stop importing <AppKit/NSTextChecker.h>
2609 https://bugs.webkit.org/show_bug.cgi?id=58798
2610 <rdar://problem/9294938>
2612 Use public header <AppKit/NSSpellChecker.h> instead.
2614 * WebCoreSupport/CorrectionPanel.h:
2615 * WebCoreSupport/CorrectionPanel.mm:
2616 (correctionIndicatorType):
2617 (CorrectionPanel::show):
2618 (CorrectionPanel::dismissInternal):
2619 (CorrectionPanel::handleAcceptedReplacement):
2620 * WebCoreSupport/WebEditorClient.mm:
2621 * WebView/WebView.mm:
2623 2011-04-17 Cameron Zwarich <zwarich@apple.com>
2625 Reviewed by Timothy Hatcher.
2627 Stop using -[NSString initWithContentsOfFile:]
2628 https://bugs.webkit.org/show_bug.cgi?id=58763
2630 -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
2632 * WebView/WebView.mm:
2633 (leakMailQuirksUserScriptContents):
2634 (leakOutlookQuirksUserScriptContents):
2636 2011-04-17 David Kilzer <ddkilzer@apple.com>
2638 <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
2639 <rdar://problem/9268729>
2641 Reviewed by Dan Bernstein.
2643 This replaces support for the WebKitEnableHTTPPipelining user
2644 default with methods on the WebCore::ResourceRequest class in
2645 WebCore, the WebView class in WebKit1, and the WebContext class
2646 in WebKit2. It also removes support for the
2647 WebKitForceHTTPPipeliningPriorityHigh user default which was not
2650 * WebView/WebView.mm:
2651 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
2652 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
2653 * WebView/WebViewPrivate.h:
2654 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
2655 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
2657 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
2659 Reviewed by Dan Bernstein.
2661 Assign to self in WebInspectorWindowController constructors
2662 https://bugs.webkit.org/show_bug.cgi?id=58749
2664 * WebCoreSupport/WebInspectorClient.mm:
2665 (-[WebInspectorWindowController init]):
2666 (-[WebInspectorWindowController initWithInspectedWebView:]):
2668 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
2670 Reviewed by Timothy Hatcher.
2672 Move WebNodeHighlighter into its own file
2673 https://bugs.webkit.org/show_bug.cgi?id=58746
2675 Extract this class into its own file alongside the
2676 other WebNodeHighlight files. In doing so do some
2677 cleanup on WebInspectorClient removing some methods
2678 that were never called.
2680 * WebCoreSupport/WebInspectorClient.mm:
2681 (WebInspectorClient::WebInspectorClient): style fix.
2682 * WebInspector/WebNodeHighlighter.h: Added.
2683 * WebInspector/WebNodeHighlighter.mm: Added.
2684 (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
2685 (-[WebNodeHighlighter dealloc]):
2686 (-[WebNodeHighlighter highlightNode:]):
2687 (-[WebNodeHighlighter hideHighlight]):
2688 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
2689 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
2691 2011-04-15 Jia Pu <jpu@apple.com>
2693 Reviewed by Dan Bernstein.
2695 [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
2696 https://bugs.webkit.org/show_bug.cgi?id=58717
2698 Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
2700 * WebCoreSupport/CorrectionPanel.mm:
2701 (CorrectionPanel::show):
2703 2011-04-15 Shishir Agrawal <shishir@chromium.org>
2705 Reviewed by James Robinson.
2707 Add a flag to guard Page Visibility API changes.
2708 https://bugs.webkit.org/show_bug.cgi?id=58464
2710 * Configurations/FeatureDefines.xcconfig:
2712 2011-04-15 Oliver Hunt <oliver@apple.com>
2714 GC allocate Structure
2715 https://bugs.webkit.org/show_bug.cgi?id=58483
2717 Rolling r83894 r83827 r83810 r83809 r83808 back in with
2718 a workaround for the gcc bug seen by the gtk bots
2720 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2721 * Plugins/Hosted/ProxyInstance.mm:
2722 (WebKit::ProxyRuntimeMethod::createStructure):
2723 * Plugins/Hosted/ProxyRuntimeObject.h:
2724 (WebKit::ProxyRuntimeObject::createStructure):
2726 2011-04-14 Alexey Proskuryakov <ap@apple.com>
2728 Reviewed by Dan Bernstein.
2730 WebKit2: Password field input does not switch to ASCII-compatible source
2731 https://bugs.webkit.org/show_bug.cgi?id=58583
2732 <rdar://problem/9059651>
2734 Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
2735 necessary logic, needed to return a nil text input context when in password fields.
2737 * WebView/WebHTMLView.mm:
2738 (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
2739 (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
2740 (-[WebHTMLView windowDidResignKey:]): Ditto.
2741 (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
2742 because the first responder is still different an this point, so set a boolean variable to
2743 let _updateSecureInputState know what's going on.
2744 (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
2745 (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
2746 allowed input sources accorsing to current selection.
2747 (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
2749 2011-04-15 Sam Weinig <sam@webkit.org>
2751 Reviewed by Maciej Stachowiak.
2753 Make mac WebKit1 use the default localization strategy
2754 https://bugs.webkit.org/show_bug.cgi?id=58628
2756 * WebCoreSupport/WebPlatformStrategies.h:
2757 * WebCoreSupport/WebPlatformStrategies.mm:
2758 Remove the localization strategy code. The equivalent is now
2759 in WebCore/platform/DefaultLocalizationStrategy.cpp.
2761 2011-04-15 Anna Cavender <annacc@chromium.org>
2763 Reviewed by Eric Carlson.
2765 Renaming TRACK feature define to VIDEO_TRACK
2766 https://bugs.webkit.org/show_bug.cgi?id=53556
2768 * Configurations/FeatureDefines.xcconfig:
2770 2011-04-14 Pratik Solanki <psolanki@apple.com>
2772 Reviewed by David Kilzer.
2774 Set minimum priority for fast lane connections
2775 https://bugs.webkit.org/show_bug.cgi?id=58353
2777 * WebCoreSupport/WebSystemInterface.mm:
2778 (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
2780 2011-04-13 Sam Weinig <sam@webkit.org>
2782 Reviewed by Gavin Barraclough.
2784 WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
2785 <rdar://problem/9260518>
2787 * WebCoreSupport/WebSystemInterface.mm:
2788 (InitWebCoreSystemInterface):
2789 Initialize new WKSI functions.
2791 2011-04-13 David Kilzer <ddkilzer@apple.com>
2793 <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
2795 Reviewed by Anders Carlsson.
2797 Fixes the following warning with -Wcast-align enabled:
2799 Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
2800 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
2801 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2803 * Plugins/WebBasePluginPackage.mm:
2804 (-[WebBasePluginPackage isNativeLibraryData:]): Added
2805 COMPILE_ASSERT() to make sure our pointer math is valid.
2806 Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
2807 by sizeof(uint32_t) to fix the pointer math. Replaced C-style
2808 casts with reinterpret_cast.
2810 2011-04-12 Enrica Casucci <enrica@apple.com>
2812 Reviewed by Alexey Proskuryakov.
2814 Infinite recursion in WebHTMLView executeSavedKeypressCommands.
2815 https://bugs.webkit.org/show_bug.cgi?id=58382
2816 <rdar://problem/9239370>
2818 Execution of some editing commands could trigger a call to selectedRange that
2819 internally calls executeSavedKeypressCommands creating an infinite recursion.
2821 * WebView/WebHTMLView.mm:
2822 (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
2823 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
2825 2011-04-12 Alice Liu <alice.liu@apple.com>
2827 Reviewed by Sam Weinig.
2829 https://bugs.webkit.org/show_bug.cgi?id=58292
2830 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
2832 * WebView/WebPreferenceKeysPrivate.h: Add preference key.
2833 * WebView/WebPreferences.mm:
2834 (+[WebPreferences initialize]): Initialize to false.
2835 (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
2836 (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
2837 * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
2838 * WebView/WebView.mm:
2839 (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.
2841 2011-04-11 Alexey Proskuryakov <ap@apple.com>
2843 Reviewed by Maciej Stachowiak.
2845 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
2846 https://bugs.webkit.org/show_bug.cgi?id=58175
2847 <rdar://problem/9060555>
2849 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
2850 should be changed to match WebKit2.
2852 2011-04-06 Timothy Hatcher <timothy@apple.com>
2854 Fix a bug where the context menu does not show in PDF documents if there is no
2855 UI delegate or the UI delegate does not respond to the context menu selector.
2857 https://webkit.org/b/57958
2859 Reviewed by Darin Adler.
2861 * WebView/WebView.mm:
2862 (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
2863 if UIDelegate is nil or doesn't respond to the selector. So check that
2864 here to distinguish between using defaultMenuItems or the delegate
2865 really returning nil to say "no context menu".
2867 2011-04-11 Jer Noble <jer.noble@apple.com>
2869 Unreviewed; roll out unintentional change to WebFullScreenController.mm.
2871 * WebView/WebFullScreenController.mm:
2872 (-[WebFullScreenController enterFullscreen:]):
2874 2011-04-08 Geoffrey Garen <ggaren@apple.com>
2876 Reviewed by Oliver Hunt.
2878 A few heap-related renames and file moves.
2880 WeakGCPtr<T> => Weak<T>
2881 Global<T> => Strong<T>
2883 collector/* => heap/*
2884 runtime/WeakGCPtr.h => heap/Weak.h
2886 (Eventually, even more files should move into the heap directory. Like
2887 Heap.h and Heap.cpp, for example.)
2889 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2890 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2891 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2892 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
2893 (WebKit::NetscapePluginInstanceProxy::evaluate):
2894 * WebView/WebScriptDebugger.h:
2896 2011-04-08 Alexey Proskuryakov <ap@apple.com>
2898 Reviewed by Darin Adler.
2900 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
2901 https://bugs.webkit.org/show_bug.cgi?id=58175
2902 <rdar://problem/9060555>
2904 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
2905 should be changed to match WebKit2.
2907 2011-04-08 Alpha Lam <hclam@chromium.org>
2909 Unreviewed, rolling out r83335.
2910 http://trac.webkit.org/changeset/83335
2911 https://bugs.webkit.org/show_bug.cgi?id=53556
2913 GTK and QT bots are broken
2915 * Configurations/FeatureDefines.xcconfig:
2917 2011-04-07 Anna Cavender <annacc@chromium.org>
2919 Reviewed by Eric Carlson.
2921 Setup ENABLE(TRACK) feature define
2922 https://bugs.webkit.org/show_bug.cgi?id=53556
2924 * Configurations/FeatureDefines.xcconfig:
2926 2011-04-08 Maciej Stachowiak <mjs@apple.com>
2928 Reviewed by Darin Adler.
2930 -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
2931 https://bugs.webkit.org/show_bug.cgi?id=58128
2932 <rdar://problem/9244553>
2934 The root of the problem here was an O(N^2) issue - each WebView,
2935 upon having its preferences initialized, would broadcast a
2936 notification that was listened to by all other WebViews sharing
2939 To maintain the API contract, I split the notification into two,
2940 one that is for public API consumption, and the other which is for
2941 internal use only. Changes that don't need to be picked up by
2942 other WebViews broadcast the public notification only. And we
2943 avoid WebView broadcasting a notification just to get itself to
2946 * Misc/WebIconDatabase.mm:
2947 (-[WebIconDatabase _startUpIconDatabase]):
2948 (-[WebIconDatabase _shutDownIconDatabase]):
2949 * Plugins/WebBaseNetscapePluginView.mm:
2950 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2951 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
2952 (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
2953 (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
2954 * WebView/WebPreferences.mm:
2955 (-[WebPreferences initWithIdentifier:]):
2956 (-[WebPreferences _setStringValue:forKey:]):
2957 (-[WebPreferences _setIntegerValue:forKey:]):
2958 (-[WebPreferences _setFloatValue:forKey:]):
2959 (-[WebPreferences _setBoolValue:forKey:]):
2960 (-[WebPreferences _setLongLongValue:forKey:]):
2961 (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2962 (-[WebPreferences _postPreferencesChangedNotification]):
2963 (-[WebPreferences _postPreferencesChangedAPINotification]):
2964 * WebView/WebPreferencesPrivate.h:
2965 * WebView/WebView.mm:
2966 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2967 (-[WebView _preferencesChangedNotification:]):
2968 (-[WebView _preferencesChanged:]):
2969 (-[WebView setUsesPageCache:]):
2970 (+[WebView initialize]):
2971 (-[WebView setPreferences:]):
2972 (-[WebView _keyboardUIMode]):
2973 * WebView/WebViewInternal.h:
2975 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
2977 Revert ENABLE_TRACK patch due to compile failures.
2979 * Configurations/FeatureDefines.xcconfig:
2981 2011-04-07 Alexey Proskuryakov <ap@apple.com>
2983 Reviewed by Anders Carlsson.
2985 REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
2986 https://bugs.webkit.org/show_bug.cgi?id=58066
2987 <rdar://problem/8965302>
2989 * WebView/WebHTMLRepresentation.mm:
2990 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2991 * WebView/WebHTMLView.mm:
2992 (-[WebHTMLView attributedSubstringFromRange:]):
2993 (-[WebHTMLView attributedString]):
2994 (-[WebHTMLView selectedAttributedString]):
2995 Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
2997 2011-04-07 Andy Estes <aestes@apple.com>
2999 Reviewed by Darin Adler.
3001 REGRESSION (r64712): Microsoft Outlook 2011: original message contents
3002 not included when replying to an email.
3003 https://bugs.webkit.org/show_bug.cgi?id=57794
3005 Outlook populates a reply message by creating an empty WebView and
3006 using DOM API to populate the WebView's empty document with content
3007 from the original message. It expects the initial empty document to
3008 simply be "<html></html>", and it proceeds to dynamically create and
3009 append a BODY node and add the original message content as a child of
3010 that node. Outlook then takes the innerHTML of the frame's first body
3011 element and copies it into a *new* document that is displayed and
3012 edited in the reply message window.
3014 Due to implementing the HTML5 tree building algorithm in r64712,
3015 initial empty documents went from being "<html></html>" to being
3016 "<html><head></head><body></body></html>". Outlook still dynamically
3017 creates a BODY node to parent the original message content, but this
3018 BODY node duplicates the one created by the tree builder. When Outlook
3019 then takes the innerHTML of the first body element to populate the
3020 reply message window it gets the empty body element created by the
3021 parser, not the one it created with the original message content.
3023 Fix this by injecting a user script into the initial empty document
3024 that removes the HEAD and BODY nodes created by the parser. This
3025 ensures that the BODY created by Outlook is the only BODY in the
3028 * Misc/OutlookQuirksUserScript.js: Added.
3029 * WebView/WebView.mm:
3030 (leakMailQuirksUserScriptContents):
3031 (-[WebView _injectMailQuirksScript]):
3032 (needsOutlookQuirksScript):
3033 (leakOutlookQuirksUserScriptContents):
3034 (-[WebView _injectOutlookQuirksScript]):
3035 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3037 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
3039 Reviewed by David Levin.
3041 Add QUOTA build flag for unified quota API
3042 https://bugs.webkit.org/show_bug.cgi?id=57918
3044 * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
3046 2011-04-06 Robert Sesek <rsesek@chromium.org>
3048 Reviewed by Alexey Proskuryakov.
3050 Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
3051 https://bugs.webkit.org/show_bug.cgi?id=54969
3053 * WebView/WebFrame.mm:
3054 (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
3055 (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
3057 2011-04-05 Alexey Proskuryakov <ap@apple.com>
3059 Reviewed by Darin Adler.
3061 Move attributedStringFromRange down to WebCore
3062 https://bugs.webkit.org/show_bug.cgi?id=57905
3064 * Misc/WebNSAttributedStringExtras.h: Removed.
3065 * Misc/WebNSAttributedStringExtras.mm: Removed.
3066 * WebView/WebHTMLRepresentation.mm:
3067 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3068 * WebView/WebHTMLView.mm:
3069 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3070 (-[WebHTMLView attributedSubstringFromRange:]):
3071 (-[WebHTMLView attributedString]):
3072 (-[WebHTMLView selectedAttributedString]):
3073 * WebView/WebPDFView.mm:
3074 (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
3076 2011-04-04 MORITA Hajime <morrita@google.com>
3078 Reviewed by Ryosuke Niwa.
3080 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
3081 https://bugs.webkit.org/show_bug.cgi?id=56085
3083 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
3084 NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
3085 for requestCheckingOfString method.
3087 * WebCoreSupport/WebEditorClient.h:
3088 * WebCoreSupport/WebEditorClient.mm:
3089 (toCoreTextCheckingResults):
3090 (WebEditorClient::checkTextOfParagraph):
3091 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
3092 (-[WebEditorSpellCheckResponder perform]):
3093 (WebEditorClient::requestCheckingOfString):
3094 * WebView/WebFrame.mm:
3095 (-[WebFrame markersForSelectionStartAsText]):
3096 * WebView/WebFramePrivate.h:
3098 2011-04-05 Anders Carlsson <andersca@apple.com>
3100 Didn't mean to land this.
3102 * Plugins/WebNetscapePluginView.mm:
3103 (-[WebNetscapePluginView getVariable:value:]):
3105 2011-04-04 David Kilzer <ddkilzer@apple.com>
3107 <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
3109 Reviewed by Alexey Proskuryakov.
3111 * WebCoreSupport/WebSystemInterface.mm:
3112 (InitWebCoreSystemInterface): Added initialization for
3113 wkSetHTTPPipeliningMaximumPriority().
3115 2011-04-04 Alexey Proskuryakov <ap@apple.com>
3117 Reviewed by Dan Bernstein.
3119 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
3120 https://bugs.webkit.org/show_bug.cgi?id=51230
3121 <rdar://problem/8780989>
3123 * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
3124 WebKits to WebCore, because WebKit shouldn't be smart.
3126 2011-04-01 Alexey Proskuryakov <ap@apple.com>
3128 Reviewed by Darin Adler.
3130 REGRESSION: Assertion failure when executing a complex custom key binding
3131 https://bugs.webkit.org/show_bug.cgi?id=57681
3133 * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
3134 commands when they can't possibly change the result.
3136 2011-04-01 Anders Carlsson <andersca@apple.com>
3138 Reviewed by Sam Weinig.
3140 Shockwave plug-in doesn't accept mouse events
3141 https://bugs.webkit.org/show_bug.cgi?id=57653
3142 <rdar://problem/8483273>
3144 Fix an unrelated bug found by the added test.
3146 * Plugins/WebBaseNetscapePluginView.mm:
3147 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3148 Make sure to always set destX and destY.
3150 2011-04-01 Alexey Proskuryakov <ap@apple.com>
3152 Reviewed by Darin Adler.
3154 Make WebKit2 text input handling more like WebKit1
3155 https://bugs.webkit.org/show_bug.cgi?id=57649
3157 * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
3158 * WebView/WebHTMLView.mm:
3159 (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
3160 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
3161 (-[WebHTMLView characterIndexForPoint:]): Ditto.
3162 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3163 (-[WebHTMLView selectedRange]): Ditto.
3164 (-[WebHTMLView markedRange]): Ditto.
3165 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3166 (-[WebHTMLView hasMarkedText]): Ditto.
3167 (-[WebHTMLView unmarkText]): Ditto.
3168 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
3169 type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
3170 be able to call text input protocol methods from here (and we didn't even reset it back on
3171 return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
3172 (-[WebHTMLView insertText:]): Ditto.
3174 2011-04-01 Timothy Hatcher <timothy@apple.com>
3176 Make momentum scroll event latching work in WebKit2 on Mac.
3178 <rdar://problem/8751861>
3180 Reviewed by Darin Adler.
3182 * WebCoreSupport/WebSystemInterface.mm:
3183 (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
3184 * WebView/WebDynamicScrollBarsView.mm:
3185 (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
3187 2011-03-31 Darin Adler <darin@apple.com>
3189 Reviewed by Anders Carlsson.
3191 Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
3192 https://bugs.webkit.org/show_bug.cgi?id=26667
3194 * WebView/WebHTMLView.mm:
3195 (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
3196 nil rather than asserting that it is non-nil. One case where WebView will be nil
3197 is when the frame is closed, but in any case where it is nil, the correct thing
3198 to do is to not try to handle the style key.
3200 2011-03-31 Alexey Proskuryakov <ap@apple.com>
3202 Patch by John Harvey, reviewed and tweaked by me.
3204 <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
3206 * Plugins/Hosted/WebTextInputWindowController.m:
3207 (-[WebTextInputPanel _interpretKeyEvent:string:]):
3209 2011-03-31 Evan Martin <evan@chromium.org>
3211 Reviewed by Eric Seidel.
3213 <title> should support dir attribute
3214 https://bugs.webkit.org/show_bug.cgi?id=50961
3216 Update to new FrameLoaderClient interface.
3218 * WebCoreSupport/WebFrameLoaderClient.h:
3219 * WebCoreSupport/WebFrameLoaderClient.mm:
3220 (WebFrameLoaderClient::dispatchDidReceiveTitle):
3221 (WebFrameLoaderClient::setTitle):
3223 2011-03-30 Dominic Cooney <dominicc@google.com>
3225 Reviewed by Dimitri Glazkov.
3227 Adds layoutTestController.shadowRoot accessor to Mac DRT.
3228 https://bugs.webkit.org/show_bug.cgi?id=57415
3230 * DOM/WebDOMOperations.mm:
3231 (-[DOMElement _shadowRoot:]):
3232 * DOM/WebDOMOperationsPrivate.h:
3234 2011-03-30 Alexey Proskuryakov <ap@apple.com>
3236 Reviewed by Darin Adler.
3238 WebHTMLView shouldn't resend noop: commands
3239 https://bugs.webkit.org/show_bug.cgi?id=57504
3240 <rdar://problem/9209390>
3242 * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
3243 which we get e.g. when handling Cmd-key combos.
3245 2011-03-30 Alexey Proskuryakov <ap@apple.com>
3247 Reviewed by Darin Adler.
3249 REGRESSION (r82320): Spacebar no longer pages down
3250 https://bugs.webkit.org/show_bug.cgi?id=57423
3251 <rdar://problem/9207702>
3253 Also includes some unrelated cleanup that I had in my tree.
3255 * WebView/WebHTMLView.mm:
3256 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
3257 being dispatched to the right frame.
3258 (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
3259 (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
3260 Even if this specific command hasn't been handled, that doesn't nullify side effects from
3262 (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
3263 bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
3264 another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
3265 going to look at it.
3267 2011-03-30 Sam Weinig <sam@webkit.org>
3269 Reviewed by Brady Eidson.
3271 WebKit2: Attempting to view css file from url causes it to download
3272 <rdar://problem/9102611>
3273 https://bugs.webkit.org/show_bug.cgi?id=57501
3275 * WebView/WebHTMLRepresentation.h:
3276 * WebView/WebHTMLRepresentation.mm:
3277 (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
3278 * WebView/WebHTMLView.mm:
3279 (+[WebHTMLView unsupportedTextMIMETypes]):
3280 Re-factor unsupportedTextMIMETypes to pull from WebCore's
3281 MIMETypeRegistry, so that the list can be shared with WebKit2.
3283 2011-03-29 Beth Dakin <bdakin@apple.com>
3285 Reviewed by Maciej Stachowiak.
3287 Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
3288 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
3290 <rdar://problem/8665411>
3292 * Misc/WebNSControlExtras.m:
3293 (-[NSControl sizeToFitAndAdjustWindowHeight]):
3294 * WebCoreSupport/WebChromeClient.mm:
3295 (WebChromeClient::scaleFactor):
3296 * WebView/WebHTMLView.mm:
3297 (-[WebHTMLView viewDidMoveToWindow]):
3298 (-[WebHTMLView attachRootLayer:]):
3300 2011-03-29 Kent Tamura <tkent@chromium.org>
3302 Reviewed by Dimitri Glazkov.
3304 Make validation message bubble testable
3305 https://bugs.webkit.org/show_bug.cgi?id=57290
3307 * WebView/WebView.mm:
3308 (-[WebView _preferencesChangedNotification:]): Copy the private value of
3309 the timer magnification to WebCore::Settings.
3310 (-[WebView validationMessageTimerMagnification]): Added.
3311 (-[WebView setValidationMessageTimerMagnification:]): Added.
3312 * WebView/WebViewData.h: Declare a member for the timer magnification.
3313 * WebView/WebViewData.mm:
3314 (-[WebViewPrivate init]): Initialize the timer magnification.
3315 * WebView/WebViewPrivate.h:
3316 Declare a setter and a getter for the timer magnification.
3318 2011-03-29 Kent Tamura <tkent@chromium.org>
3320 Reviewed by Dimitri Glazkov.
3322 [Mac] Enable interactive-validation tests on Mac DRT
3323 https://bugs.webkit.org/show_bug.cgi?id=57308
3325 * WebView/WebView.mm:
3326 (-[WebView _preferencesChangedNotification:]):
3327 Convey a WebView flag for interactive validation to WebCore::Settings.
3328 (-[WebView interactiveFormValidationEnabled]): Added.
3329 (-[WebView setInteractiveFormValidationEnabled:]): Added.
3330 * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
3331 * WebView/WebViewData.mm:
3332 (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
3333 * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
3335 2011-03-29 Timothy Hatcher <timothy@apple.com>
3337 Update the order of the context menu to better match AppKit on Mac.
3339 <rdar://problem/9054893>
3341 Reviewed by John Sullivan.
3343 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3344 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
3345 * WebCoreSupport/WebPlatformStrategies.h:
3346 * WebCoreSupport/WebPlatformStrategies.mm:
3347 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
3349 2011-03-29 Alexey Proskuryakov <ap@apple.com>
3351 Reviewed by Darin Adler.
3353 https://bugs.webkit.org/show_bug.cgi?id=57379
3354 Clean up WK1 key event handling logic
3356 No bugs knowingly fixed, but this makes the code more consistent.
3358 * WebView/WebHTMLView.mm:
3359 (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
3360 eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
3361 (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
3362 from other functions. We need to execute saved commands when an input method asks for current
3363 state, because providing stale state could confuse it.
3364 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
3366 (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
3367 the answer would be stale.
3368 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3369 (-[WebHTMLView selectedRange]): Ditto.
3370 (-[WebHTMLView markedRange]): Ditto.
3371 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3372 (-[WebHTMLView hasMarkedText]): Ditto.
3373 (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
3374 operating on stale data. Also, updated for eventWasHandled renaming.
3375 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3376 (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
3377 it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
3378 fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
3379 could have a noop: as one of its commands, although that's hardly practical).
3380 Added the same "from input method" logic that we have in insertText: - I don't know of any
3381 IMs that call this method, but we clearly need to execute it as part of IM processing when
3382 there is marked text.
3383 (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
3384 eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
3385 if current selection isn't editable. This is different from doCommandBySelector:, where we
3386 need to give super class a chance to handle the event if our processing fails.
3387 Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
3388 return value of _interpretKeyEvent is computed differently.
3390 2011-03-28 Adele Peterson <adele@apple.com>
3392 Reviewed by Eric Seidel.
3394 Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
3395 https://bugs.webkit.org/show_bug.cgi?id=57173
3397 * WebView/WebFrame.mm:
3398 (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
3399 (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
3400 * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
3402 2011-03-28 Alexey Proskuryakov <ap@apple.com>
3404 Reviewed by Darin Adler.
3406 https://bugs.webkit.org/show_bug.cgi?id=57260
3407 Clean up text input code a little
3409 * WebCoreSupport/WebEditorClient.mm:
3410 (WebEditorClient::handleKeyboardEvent):
3411 (WebEditorClient::handleInputMethodKeydown):
3412 * WebView/WebHTMLViewInternal.h:
3413 Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
3414 anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
3415 and also possibly saves resulting commands for later execution.
3417 * WebView/WebHTMLView.mm:
3418 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
3419 return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
3420 WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
3421 handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
3422 because the first call resulted in no saved commands, becasue it's confusing and apparently
3423 useless (I couldn't find any broken behavior).
3424 (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
3425 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3426 (-[WebHTMLView doCommandBySelector:]): Ditto.
3427 (-[WebHTMLView insertText:]): Ditto.
3429 * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
3432 2011-03-27 Jer Noble <jer.noble@apple.com>
3434 Reviewed by Maciej Stachowiak.
3436 Full Screen: disable keyboard access by default
3437 https://bugs.webkit.org/show_bug.cgi?id=56684
3439 Take into account whether keyboard access was requested when deciding whether full
3440 screen mode is supported.
3442 * WebCoreSupport/WebChromeClient.h:
3443 * WebCoreSupport/WebChromeClient.mm:
3444 (WebChromeClient::supportsFullScreenForElement):
3445 * WebView/WebView.mm:
3446 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
3447 * WebView/WebViewInternal.h:
3449 2011-03-26 Jer Noble <jer.noble@apple.com>
3451 Reviewed by Eric Carlson.
3453 Enable the Full Screen API by default in WebKit/mac and WebKit2
3454 https://bugs.webkit.org/show_bug.cgi?id=56956
3456 * WebView/WebPreferences.mm:
3457 (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
3459 2011-03-25 Andy Estes <aestes@apple.com>
3461 Reviewed by Adele Peterson.
3463 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3464 https://bugs.webkit.org/show_bug.cgi?id=49016
3466 Update objectContentType() implementation to handle the
3467 shouldPreferPlugInsForImages flag.
3469 * WebCoreSupport/WebFrameLoaderClient.h:
3470 * WebCoreSupport/WebFrameLoaderClient.mm:
3471 (WebFrameLoaderClient::objectContentType):
3473 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
3475 Unreviewed, rolling out r81939.
3476 http://trac.webkit.org/changeset/81939
3477 https://bugs.webkit.org/show_bug.cgi?id=57084
3479 Rolling out 81939, as it's causing a number of app cache test
3480 failures. (Requested by jernoble on #webkit).
3482 * WebView/WebView.mm:
3483 (-[WebView _preferencesChangedNotification:]):
3485 2011-03-23 Jer Noble <jer.noble@apple.com>
3487 Reviewed by Maciej Stachowiak.
3489 Application Cache should save audio/ and video/ mime types as flat files
3490 https://bugs.webkit.org/show_bug.cgi?id=53784
3491 <rdar://problem/8932473>
3495 Initialize the AppCache Total size quotas with the values for WebKitPreferences
3498 * WebView/WebView.mm:
3499 (-[WebView _preferencesChangedNotification:]):
3501 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
3503 Unreviewed, rolling out r81916 and r81917.
3504 http://trac.webkit.org/changeset/81916
3505 http://trac.webkit.org/changeset/81917
3506 https://bugs.webkit.org/show_bug.cgi?id=57071
3508 broke a test on platforms that do not have QuickTime installed
3509 (Requested by estes on #webkit).
3511 * WebCoreSupport/WebFrameLoaderClient.h:
3512 * WebCoreSupport/WebFrameLoaderClient.mm:
3513 (WebFrameLoaderClient::objectContentType):
3515 2011-03-24 Andy Estes <aestes@apple.com>
3517 Reviewed by Darin Adler.
3519 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3520 https://bugs.webkit.org/show_bug.cgi?id=49016
3522 Update objectContentType() implementation to handle the
3523 shouldPreferPlugInsForImages flag.
3525 * WebCoreSupport/WebFrameLoaderClient.h:
3526 * WebCoreSupport/WebFrameLoaderClient.mm:
3527 (WebFrameLoaderClient::objectContentType):
3529 2011-03-24 Geoffrey Garen <ggaren@apple.com>
3531 Reviewed by Oliver Hunt.
3533 Ensure that all compilation takes place within a dynamic global object scope
3534 https://bugs.webkit.org/show_bug.cgi?id=57054
3536 * WebView/WebScriptDebugDelegate.mm:
3537 (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
3539 2011-03-24 Jia Pu <jpu@apple.com>
3541 Reviewed by Darin Adler.
3543 Dismissed reversion suggestion is incorrectly learned.
3544 https://bugs.webkit.org/show_bug.cgi?id=57039
3546 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
3547 [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
3548 is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
3549 incorrect automatic learning.
3551 * WebCoreSupport/CorrectionPanel.mm:
3552 (CorrectionPanel::dismissInternal):
3554 2011-03-24 David Kilzer <ddkilzer@apple.com>
3556 <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
3558 Reviewed by Joseph Pecoraro.
3560 * Plugins/WebPluginContainerPrivate.h: Changed value of
3561 ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
3563 2011-03-23 Jia Pu <jpu@apple.com>
3565 Reviewed by Darin Adler.
3567 Hook up new AppKit autocorrection UI with WK2.
3568 https://bugs.webkit.org/show_bug.cgi?id=56055
3569 <rdar://problem/8947463>
3571 Please see WebCore/ChangeLog for detail.
3573 * WebCoreSupport/CorrectionPanel.h: Added.
3574 (CorrectionPanel::isShowing):
3575 * WebCoreSupport/CorrectionPanel.mm: Added.
3576 (correctionBubbleType):
3577 (CorrectionPanel::CorrectionPanel):
3578 (CorrectionPanel::~CorrectionPanel):
3579 (CorrectionPanel::show):
3580 (CorrectionPanel::dismiss):
3581 (CorrectionPanel::dismissSoon):
3582 (CorrectionPanel::dismissInternal):
3583 (CorrectionPanel::recordAutocorrectionResponse):
3584 * WebCoreSupport/WebEditorClient.h:
3585 * WebCoreSupport/WebEditorClient.mm:
3586 (WebEditorClient::WebEditorClient):
3587 (WebEditorClient::showCorrectionPanel):
3588 (WebEditorClient::dismissCorrectionPanel):
3589 (WebEditorClient::dismissCorrectionPanelSoon):
3590 (WebEditorClient::recordAutocorrectionResponse):
3591 * WebView/WebView.mm:
3592 (-[WebView handleCorrectionPanelResult:]):
3593 * WebView/WebViewPrivate.h:
3595 2011-03-23 Enrica Casucci <enrica@apple.com>
3597 Reviewed by Alexey Proskuryakov.
3599 Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
3600 https://bugs.webkit.org/show_bug.cgi?id=56974
3601 <rdar://problem/8284642>
3603 This fixes a regression introduced by http://trac.webkit.org/changeset/61794
3604 where readSelectionFromPasteboard was accidentally removed.
3605 This method and writeSelectionToPasteboard are needed to support Mac OS X
3608 * WebView/WebHTMLView.mm:
3609 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
3610 (-[WebHTMLView readSelectionFromPasteboard:]): Added.
3612 2011-03-23 Brady Eidson <beidson@apple.com>
3614 Reviewed by Sam Weinig.
3616 Change IconDatabase opening to allow for arbitrary filenames
3617 https://bugs.webkit.org/show_bug.cgi?id=56977
3619 * Misc/WebIconDatabase.mm:
3620 (-[WebIconDatabase _startUpIconDatabase]):
3622 2011-03-22 Anton D'Auria <adauria@apple.com>
3624 Reviewed by Alexey Proskuryakov.
3626 Add +[WebApplicationCache getOriginsWithCache]
3627 https://bugs.webkit.org/show_bug.cgi?id=56722
3629 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
3631 * WebCoreSupport/WebApplicationCache.h:
3632 * WebCoreSupport/WebApplicationCache.mm:
3633 (+[WebApplicationCache originsWithCache]):
3635 2011-03-22 Anders Carlsson <andersca@apple.com>
3637 Reviewed by Sam Weinig.
3639 OBJECT element with DivX source is always downloaded
3640 https://bugs.webkit.org/show_bug.cgi?id=56879
3642 * Plugins/WebBasePluginPackage.mm:
3643 (-[WebBasePluginPackage getPluginInfoFromPLists]):
3644 Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
3645 specifies multiple file extensions in a single element.
3647 2011-03-22 Brady Eidson <beidson@apple.com>
3649 Reviewed by Sam Weinig.
3651 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
3652 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
3654 Note that while the new client calls always come through on the main thread, our mechanisms to
3655 route dispatches to the main thread are still valid and will still work.
3657 Update to the new IconDatabaseClient interface:
3658 * WebCoreSupport/WebIconDatabaseClient.h:
3659 * WebCoreSupport/WebIconDatabaseClient.mm:
3660 (WebIconDatabaseClient::didRemoveAllIcons):
3661 (WebIconDatabaseClient::didImportIconURLForPageURL):
3662 (WebIconDatabaseClient::didImportIconDataForPageURL):
3663 (WebIconDatabaseClient::didChangeIconForPageURL):
3664 (WebIconDatabaseClient::didFinishURLImport):
3666 2011-03-22 Matthew Delaney <mdelaney@apple.com>
3668 Reviewed by Simon Fraser.
3670 Have WebKit push acceleratedDrawing preferences to settings
3671 https://bugs.webkit.org/show_bug.cgi?id=56792
3673 * WebView/WebView.mm:
3675 2011-03-21 Nate Chapin <japhet@chromium.org>
3677 Reviewed by Brady Eidson.
3679 Expose a preference to use caching quirks for QuickLook,
3680 and use it if the QuickLook framework is loaded.
3682 https://bugs.webkit.org/show_bug.cgi?id=38690
3684 * WebView/WebPreferenceKeysPrivate.h:
3685 * WebView/WebPreferences.mm:
3686 (useQuickLookQuirks):
3687 (+[WebPreferences initialize]):
3688 (-[WebPreferences useQuickLookResourceCachingQuirks]):
3689 * WebView/WebPreferencesPrivate.h:
3690 * WebView/WebView.mm:
3691 (-[WebView _preferencesChangedNotification:]):
3693 2011-03-21 Chris Fleizach <cfleizach@apple.com>
3695 Reviewed by Darin Adler.
3697 AX: showContextMenu not working in WK2
3698 https://bugs.webkit.org/show_bug.cgi?id=56734
3700 Implement showContextMenu() so accessibility related code can call this
3701 independent of whether WK1 or WK2 is running.
3703 * WebCoreSupport/WebChromeClient.h:
3704 * WebCoreSupport/WebChromeClient.mm:
3705 (WebChromeClient::showContextMenu):
3707 2011-03-21 Chang Shu <cshu@webkit.org>
3709 Reviewed by Alexey Proskuryakov.
3711 REGRESSION (r79953): Can't type in MS Outlook 2011
3712 https://bugs.webkit.org/show_bug.cgi?id=56665
3714 r79953 removed the WebView level editablity which is persistent no matter whether
3715 underlying document itself is changed and editability gets lost. The resolution is to
3716 set this WebView editable value to WebCore. This avoids the callback from WebCore to
3717 WebKit which was the main goal in r79953 to improve performance.
3719 * WebView/WebView.mm:
3720 (-[WebView setEditable:]):
3721 (-[WebView isEditable]):
3723 2011-03-19 Anton D'Auria <adauria@apple.com>
3725 Reviewed by Alexey Proskuryakov.
3727 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3728 https://bugs.webkit.org/show_bug.cgi?id=56415
3730 Use new ApplicationCache API to delete all cache for an origin.
3732 * WebCoreSupport/WebApplicationCache.h:
3733 * WebCoreSupport/WebApplicationCache.mm:
3734 (+[WebApplicationCache deleteOrigin:]):
3736 2011-03-17 Brady Eidson <beidson@apple.com>
3738 Reviewed by Sam Weinig.
3740 https://bugs.webkit.org/show_bug.cgi?id=56425
3741 More groundwork for WebKit2 IconDatabase
3743 Update already-used function names:
3744 * Misc/WebIconDatabase.mm:
3745 (-[WebIconDatabase iconForURL:withSize:cache:]):
3746 (-[WebIconDatabase iconURLForURL:]):
3747 * WebView/WebView.mm:
3748 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3750 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
3752 Reviewed by Yury Semikhatsky.
3754 Web Inspector: implement inspector session storage.
3755 https://bugs.webkit.org/show_bug.cgi?id=56643
3757 * WebCoreSupport/WebInspectorClient.h:
3758 * WebCoreSupport/WebInspectorClient.mm:
3759 (WebInspectorClient::saveSessionSetting):
3760 (WebInspectorClient::loadSessionSetting):
3761 (WebInspectorFrontendClient::saveSessionSetting):
3762 (WebInspectorFrontendClient::loadSessionSetting):
3763 (-[WebInspectorWindowController inspectorClient]):
3765 2011-03-17 Geoffrey Garen <ggaren@apple.com>
3767 Reviewed by Oliver Hunt.
3769 Fixed a leak seen on the buildbot.
3771 * WebCoreSupport/WebInspectorClient.mm:
3772 (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
3774 2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
3776 Reviewed by Alexey Proskuryakov.
3778 Logic error in -[WebHTMLView close]
3779 https://bugs.webkit.org/show_bug.cgi?id=56445
3781 Page is always nil at this point, because [self _webView] is nil,
3782 so the conditional code is never run.
3784 * WebView/WebHTMLView.mm:
3785 (-[WebHTMLView close]):
3787 2011-03-16 Chris Fleizach <cfleizach@apple.com>
3789 Reviewed by Darin Adler.
3791 WK2: Need to propagate enhanced accessibility flag from UI -> web process
3792 https://bugs.webkit.org/show_bug.cgi?id=56379
3794 * WebView/WebFrame.mm:
3795 (-[WebFrame accessibilityRoot]):
3797 2011-03-15 Oliver Hunt <oliver@apple.com>
3799 Reviewed by Geoffrey Garen.
3801 Make Structure creation require a JSGlobalData
3802 https://bugs.webkit.org/show_bug.cgi?id=56438
3804 Mechanical change to make all Structure creation use a JSGlobalData&
3806 * Plugins/Hosted/ProxyInstance.mm:
3807 (WebKit::ProxyRuntimeMethod::createStructure):
3808 * Plugins/Hosted/ProxyRuntimeObject.h:
3809 (WebKit::ProxyRuntimeObject::createStructure):
3811 2011-03-15 Alexey Proskuryakov <ap@apple.com>
3813 Forgot to save a modification to this file when committing.
3815 * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
3817 2011-03-15 Alexey Proskuryakov <ap@apple.com>
3819 Reviewed by Darin Adler.
3821 REGRESSION (WebKit2): keygen element doesn't work
3822 https://bugs.webkit.org/show_bug.cgi?id=56402
3823 <rdar://problem/9006545>
3825 * WebCoreSupport/WebKeyGenerator.h:
3826 * WebCoreSupport/WebKeyGenerator.m: Removed.
3827 * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
3828 (+[WebKeyGenerator sharedGenerator]):
3829 (toWebCertificateParseResult):
3830 WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
3831 this misnamed and misplaced code for now.
3833 * WebCoreSupport/WebPlatformStrategies.h:
3834 * WebCoreSupport/WebPlatformStrategies.mm:
3835 (WebPlatformStrategies::keygenMenuItem512):
3836 (WebPlatformStrategies::keygenMenuItem1024):
3837 (WebPlatformStrategies::keygenMenuItem2048):
3838 (WebPlatformStrategies::keygenKeychainItemName):
3839 Added strings used by keygen.
3841 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
3842 pointer to a function used by keygen.
3844 * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
3847 2011-03-15 Beth Dakin <bdakin@apple.com>
3849 Reviewed by Simon Fraser.
3851 WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
3853 New WebKitystemInterface function to force the scrollbars to flash
3854 * WebCoreSupport/WebSystemInterface.mm:
3855 (InitWebCoreSystemInterface):
3857 2011-03-15 Ilya Sherman <isherman@chromium.org>
3859 Reviewed by Tony Chang.
3861 Autofilled form elements are assigned fixed background color but not text color
3862 https://bugs.webkit.org/show_bug.cgi?id=48382
3864 * DOM/WebDOMOperations.mm:
3865 (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
3866 * DOM/WebDOMOperationsPrivate.h:
3868 2011-03-15 Adam Roben <aroben@apple.com>
3870 Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
3872 Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
3873 WebStorageTrackerClient::dispatchDidModifyOrigin
3875 Reviewed by Antti Koivisto.
3877 * Storage/WebStorageTrackerClient.mm:
3878 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
3879 to us by dispatchDidModifyOrigin.
3880 (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
3883 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
3885 Reviewed by Darin Adler.
3887 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3888 info into the headers rather than in export symbol definition files, but disable it on
3889 all platforms initially so we can deal with port build issues one port at a time.
3891 https://bugs.webkit.org/show_bug.cgi?id=27551
3895 2011-03-14 Brady Eidson <beidson@apple.com>
3897 Reviewed by Anders Carlsson.
3899 https://bugs.webkit.org/show_bug.cgi?id=56320
3900 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
3902 * History/WebHistoryItem.mm:
3903 (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
3905 2011-03-13 Pratik Solanki <psolanki@apple.com>
3907 Reviewed by Brady Eidson.
3909 Make adjustMIMETypeIfNecessary use CFNetwork directly
3910 https://bugs.webkit.org/show_bug.cgi?id=55912
3912 * WebCoreSupport/WebSystemInterface.mm:
3913 (InitWebCoreSystemInterface): Support for new WKSI functions.
3915 2011-03-12 Mark Rowe <mrowe@apple.com>
3917 Fix the 32-bit build.
3919 * Carbon/CarbonWindowAdapter.mm:
3920 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
3921 (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
3923 2011-03-11 Brady Eidson <beidson@apple.com>
3925 Reviewed by Anders Carlsson
3927 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
3928 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
3930 * Misc/WebIconDatabase.mm:
3931 (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
3932 (-[WebIconDatabase _startUpIconDatabase]): Ditto.
3933 (importToWebCoreFormat):
3935 2011-03-11 Anton D'Auria <adauria@apple.com>
3937 Reviewed and landed by Brady Eidson.
3939 https://bugs.webkit.org/show_bug.cgi?id=51878
3940 Add WebKit1 API to view and delete local storage
3942 * Storage/WebStorageManager.mm: Added.
3943 (+[WebStorageManager sharedWebStorageManager]):
3944 (-[WebStorageManager origins]):
3945 (-[WebStorageManager deleteAllOrigins]):
3946 (-[WebStorageManager deleteOrigin:]):
3947 (-[WebStorageManager syncLocalStorage]):
3948 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
3949 (storageDirectoryPath):
3950 (WebKitInitializeStorageIfNecessary):
3951 * Storage/WebStorageManagerInternal.h: Added.
3952 * Storage/WebStorageManagerPrivate.h: Added.
3953 * Storage/WebStorageTrackerClient.h: Added.
3954 * Storage/WebStorageTrackerClient.mm: Added.
3955 (WebStorageTrackerClient::sharedWebStorageTrackerClient):
3956 (WebStorageTrackerClient::WebStorageTrackerClient):
3957 (WebStorageTrackerClient::~WebStorageTrackerClient):
3958 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
3959 (WebStorageTrackerClient::dispatchDidModifyOrigin):
3960 * WebCoreSupport/WebSecurityOrigin.mm:
3961 (-[WebSecurityOrigin protocol]):
3962 (-[WebSecurityOrigin host]):
3963 (-[WebSecurityOrigin databaseIdentifier]):
3964 (-[WebSecurityOrigin domain]):
3965 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
3966 * WebCoreSupport/WebSecurityOriginPrivate.h:
3968 * WebView/WebView.mm:
3969 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3971 2011-03-10 Anders Carlsson <andersca@apple.com>
3973 Reviewed by Sam Weinig.
3975 <rdar://problem/9117047>
3976 Don't paint more than 60 times per second even when scrolling
3978 * WebView/WebClipView.mm:
3979 (-[WebClipView _immediateScrollToPoint:]):
3981 2011-03-09 Matthew Delaney <mdelaney@apple.com>
3983 Reviewed by Simon Fraser.
3985 Plumb through settings for accelerated drawing for canvas
3986 https://bugs.webkit.org/show_bug.cgi?id=56039
3988 * WebView/WebPreferenceKeysPrivate.h:
3989 * WebView/WebPreferences.mm:
3990 * WebView/WebPreferencesPrivate.h:
3992 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
3994 Reviewed by Tony Chang.
3996 VisiblePosition's next and previous should take an enum instead of a boolean
3997 https://bugs.webkit.org/show_bug.cgi?id=56135
3999 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
4000 StayInEditableContent.
4002 * WebView/WebView.mm:
4003 (-[WebView _selectionIsAll]):
4005 2011-03-09 Jessie Berlin <jberlin@apple.com>
4007 Reviewed by Adam Roben.
4009 Use the Cookie Storage from the Private Browsing Storage Session directly
4010 https://bugs.webkit.org/show_bug.cgi?id=55986
4012 * WebCoreSupport/WebSystemInterface.mm:
4013 (InitWebCoreSystemInterface):
4015 2011-03-08 Darin Adler <darin@apple.com>
4017 Reviewed by Timothy Hatcher.
4019 Promote a method used outside WebKit from internal to private
4020 https://bugs.webkit.org/show_bug.cgi?id=55949
4022 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
4023 Minor tweak, not directly related to the rest of this patch.
4025 * WebView/WebFrame.mm:
4026 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
4027 this method from the internal category into the private category.
4028 Streamlined the code a bit.
4030 * WebView/WebFrameInternal.h: Removed _computePageRects method.
4031 * WebView/WebFramePrivate.h: Added _computePageRects method.
4033 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
4035 Reviewed by Darin Adler.
4037 selectionHasStyle and selectionStartHasStyle should use EditingStyle
4038 https://bugs.webkit.org/show_bug.cgi?id=55902
4040 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
4042 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
4043 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
4045 2011-03-07 Dan Bernstein <mitz@apple.com>
4047 LLVM Compiler build fix.
4049 * WebCoreSupport/WebEditorClient.mm:
4050 (WebEditorClient::checkGrammarOfString):
4052 2011-03-07 Chris Fleizach <cfleizach@apple.com>
4054 Reviewed by Beth Dakin.
4056 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
4057 https://bugs.webkit.org/show_bug.cgi?id=55706
4059 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
4060 returns the scroll bar objects).
4061 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
4062 will expect that as its child, instead of the WebCore ScrollView object.
4064 * WebView/WebDynamicScrollBarsView.mm:
4065 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
4066 * WebView/WebFrame.mm:
4067 (-[WebFrame accessibilityRoot]):
4069 2011-03-07 Sam Weinig <sam@webkit.org>
4071 Reviewed by Anders Carlsson.
4073 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
4074 https://bugs.webkit.org/show_bug.cgi?id=55827
4076 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
4077 and pass the entire response, instead of just the MIMEType.
4079 * WebCoreSupport/WebFrameLoaderClient.h:
4080 * WebCoreSupport/WebFrameLoaderClient.mm:
4081 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
4083 2011-03-06 Dan Bernstein <mitz@apple.com>
4085 LLVM Compiler build fix.
4087 * DOM/WebDOMOperations.mm:
4088 (-[DOMHTMLInputElement _setValueForUser:]):
4090 2011-03-06 Jessie Berlin <jberlin@apple.com>
4092 Reviewed by Sam Weinig.
4094 WebKit2: Use CFNetwork Sessions API.
4095 https://bugs.webkit.org/show_bug.cgi?id=55435.
4097 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
4098 Private Browsing Storage Session.
4100 * WebCoreSupport/WebSystemInterface.mm:
4101 (InitWebCoreSystemInterface):
4102 Add support for using the new WKSI functions in WebCore.
4104 2011-03-05 Ilya Sherman <isherman@chromium.org>
4106 Reviewed by Darin Adler.
4108 HTMLInputElement::setValue() should schedule change event when the element is focused
4109 In service of https://code.google.com/p/chromium/issues/detail?id=42716
4110 https://bugs.webkit.org/show_bug.cgi?id=53160
4112 * DOM/WebDOMOperations.mm:
4113 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
4114 * DOM/WebDOMOperationsPrivate.h:
4115 * WebView/WebViewInternal.h:
4117 2011-03-04 Jia Pu <jpu@apple.com>
4119 Reviewed by Darin Adler.
4121 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
4122 https://bugs.webkit.org/show_bug.cgi?id=55717
4123 <rdar://problem/9018127>
4125 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
4126 is already in window coordinate. We don't need to do further conversion anymore.
4128 * WebCoreSupport/WebEditorClient.mm:
4129 (WebEditorClient::showCorrectionPanel):
4131 2011-03-04 Jessie Berlin <jberlin@apple.com>
4133 Reviewed by Maciej Stachowiak.
4135 WebKit2: Use CFNetwork Sessions API.
4136 https://bugs.webkit.org/show_bug.cgi?id=55435.
4138 When Private Browsing is enabled, get the cached url response from the cache associated with
4139 the Private Browsing Storage Session.
4141 * WebView/WebView.mm:
4142 (-[WebView _cachedResponseForURL:]):
4144 2011-03-03 Anders Carlsson <andersca@apple.com>
4146 Reviewed by Sam Weinig.
4148 Get rid of Page::globalHistoryItem
4149 https://bugs.webkit.org/show_bug.cgi?id=55738
4151 * WebCoreSupport/WebFrameLoaderClient.h:
4152 * WebCoreSupport/WebFrameLoaderClient.mm:
4153 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
4154 Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
4156 * WebView/WebView.mm:
4157 (-[WebView _globalHistoryItem]):
4158 (-[WebView _setGlobalHistoryItem:]):
4159 Set _globalHistoryItem ivar.
4161 * WebView/WebViewData.h:
4162 * WebView/WebViewData.mm:
4163 Add _globalHistoryItem ivar.
4165 2011-03-03 Brady Eidson <beidson@apple.com>
4167 Reviewed by Darin Adler.
4169 https://bugs.webkit.org/show_bug.cgi?id=55721
4170 Global IconDatabase should be returned by reference, not as a pointer
4172 * Misc/WebCoreStatistics.mm:
4173 (+[WebCoreStatistics iconPageURLMappingCount]):
4174 (+[WebCoreStatistics iconRetainedPageURLCount]):
4175 (+[WebCoreStatistics iconRecordCount]):
4176 (+[WebCoreStatistics iconsWithDataCount]):
4177 * Misc/WebIconDatabase.mm:
4178 (-[WebIconDatabase init]):
4179 (-[WebIconDatabase iconForURL:withSize:cache:]):
4180 (-[WebIconDatabase iconURLForURL:]):
4181 (-[WebIconDatabase defaultIconWithSize:]):
4182 (-[WebIconDatabase retainIconForURL:]):
4183 (-[WebIconDatabase releaseIconForURL:]):
4184 (-[WebIconDatabase isEnabled]):
4185 (-[WebIconDatabase setEnabled:]):
4186 (-[WebIconDatabase removeAllIcons]):
4187 (+[WebIconDatabase _checkIntegrityBeforeOpening]):
4188 (-[WebIconDatabase _startUpIconDatabase]):
4189 (-[WebIconDatabase _applicationWillTerminate:]):
4190 (-[WebIconDatabase _resetCachedWebPreferences:]):
4191 (importToWebCoreFormat):
4192 * WebView/WebView.mm:
4193 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
4195 2011-03-03 Jessie Berlin <jberlin@apple.com>
4197 Reviewed by Adam Roben.
4199 WebKit2: Use CFNetwork Sessions API.
4200 https://bugs.webkit.org/show_bug.cgi?id=55435.
4202 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
4204 * WebCoreSupport/WebSystemInterface.mm:
4205 (InitWebCoreSystemInterface):
4206 Support using WKCopyRequestWithStorageSession in WebCore.
4208 2011-03-02 Alexey Proskuryakov <ap@apple.com>
4210 Reviewed by Darin Adler.
4212 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
4213 https://bugs.webkit.org/show_bug.cgi?id=55633
4214 <rdar://problem/8963023>
4216 * WebCoreSupport/WebChromeClient.h:
4217 * WebCoreSupport/WebChromeClient.mm:
4218 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
4220 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
4221 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
4222 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
4223 so I've preserved it.
4225 2011-03-02 Jessie Berlin <jberlin@apple.com>
4227 Rubber-stamped by Dan Bernstein.
4229 Fix crashes in private browsing tests in WK1 on Snow Leopard.
4231 * WebCoreSupport/WebSystemInterface.mm:
4232 (InitWebCoreSystemInterface):
4233 Put the INIT call for wkCreatePrivateStorageSession outside of the
4234 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
4237 2011-03-02 Jessie Berlin <jberlin@apple.com>
4239 Reviewed by Adam Roben.
4241 WebKit2: Use CFNetwork Sessions API.
4242 https://bugs.webkit.org/show_bug.cgi?id=55435.
4244 Add the ability to create a Private Browsing Storage Session.
4246 * WebCoreSupport/WebSystemInterface.mm:
4247 (InitWebCoreSystemInterface):
4248 Support calling wkCreatePrivateStorageSession from WebCore.
4250 2011-03-02 Daniel Cheng <dcheng@chromium.org>
4252 Reviewed by David Levin.
4254 Add feature define for data transfer items
4255 https://bugs.webkit.org/show_bug.cgi?id=55510
4257 * Configurations/FeatureDefines.xcconfig:
4259 2011-03-02 Sam Weinig <sam@webkit.org>
4261 Reviewed by Anders Carlsson.
4263 Fix remaining localization issues by piping all localized strings through WebCore's
4264 localization bottleneck.
4265 <rdar://problem/8728860>
4267 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
4268 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
4269 * Misc/WebKitErrors.m:
4270 * Misc/WebLocalizableStringsInternal.h: Added.
4271 * Misc/WebLocalizableStringsInternal.mm: Added.
4272 (WebLocalizedStringInternal):
4273 * Panels/WebAuthenticationPanel.m:
4274 (-[WebAuthenticationPanel setUpForChallenge:]):
4275 * Plugins/Hosted/NetscapePluginHostManager.mm:
4276 (WebKit::NetscapePluginHostManager::spawnPluginHost):
4277 * WebCoreSupport/WebEditorClient.mm:
4278 (undoNameForEditAction):
4279 * WebCoreSupport/WebInspectorClient.mm:
4280 (WebInspectorFrontendClient::updateWindowTitle):
4281 (-[WebInspectorWindowController validateUserInterfaceItem:]):
4282 * WebCoreSupport/WebKeyGenerator.m:
4283 (-[WebKeyGenerator strengthMenuItemTitles]):
4284 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
4285 * WebCoreSupport/WebPlatformStrategies.mm:
4286 * WebView/WebHTMLView.mm:
4287 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
4288 * WebView/WebPDFView.mm:
4289 (-[WebPDFView menuForEvent:]):
4291 2011-03-01 Brian Weinstein <bweinstein@apple.com>
4293 Reviewed by Adam Roben.
4295 Part of WebKit2: Need a way to send notifications to client when cookies change
4296 https://bugs.webkit.org/show_bug.cgi?id=55427
4297 <rdar://problem/9056027>
4299 Add stubs for CookiesStrategy on Mac WebKit1.
4301 * WebCoreSupport/WebPlatformStrategies.h:
4302 * WebCoreSupport/WebPlatformStrategies.mm:
4303 (WebPlatformStrategies::createCookiesStrategy):
4304 (WebPlatformStrategies::notifyCookiesChanged):
4306 2011-03-01 Philippe Normand <pnormand@igalia.com>
4308 Reviewed by Eric Carlson.
4310 [GStreamer] support in mac video fullscreen controller
4311 https://bugs.webkit.org/show_bug.cgi?id=52280
4313 Factored the code to configure the video overlay in a new private
4314 method of the controller and added GStreamer support to it.
4316 * WebView/WebVideoFullscreenController.h:
4317 * WebView/WebVideoFullscreenController.mm:
4318 (-[WebVideoFullscreenController setupVideoOverlay:]):
4319 (-[WebVideoFullscreenController windowDidLoad]):
4320 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
4321 (-[WebVideoFullscreenController windowDidExitFullscreen]):
4323 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
4325 Reviewed by Timothy Hatcher.
4327 All Console Messages should be passed to ChromeClients.
4328 https://bugs.webkit.org/show_bug.cgi?id=54926
4330 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
4331 which supersedes -webView:addMessageToConsole if it exists. The new delegate
4332 does not filter to only JavaScript originated console messages. The old
4333 delegate is left around for clients that expect filtered messages, like
4334 DashCode and older versions of Safari.
4336 The dictionary message passed to the delegate now includes more information
4337 about the message source, type, and level.
4339 * WebCoreSupport/WebChromeClient.mm:
4340 (stringForMessageSource):
4341 (stringForMessageType):
4342 (stringForMessageLevel):
4343 (WebChromeClient::addMessageToConsole):
4344 * WebView/WebUIDelegatePrivate.h:
4346 2011-03-01 Levi Weintraub <leviw@chromium.org>
4348 Reviewed by Ryosuke Niwa.
4350 Stop instantiating legacy editing Positions in VisiblePosition
4351 https://bugs.webkit.org/show_bug.cgi?id=52919
4353 Changing usage of legacy VisiblePosition constructor. Since we were dealing
4354 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
4356 * WebView/WebFrame.mm:
4357 (-[WebFrame _caretRectAtPosition:affinity:]):
4358 * WebView/WebFrameInternal.h:
4359 * WebView/WebTextCompletionController.mm:
4360 (-[WebTextCompletionController doCompletion]):
4362 2011-03-01 Sam Weinig <sam@webkit.org>
4364 Reviewed by Timothy Hatcher.
4366 WebKit2 needs to be made localizable
4367 https://bugs.webkit.org/show_bug.cgi?id=55483
4369 * WebCoreSupport/WebPlatformStrategies.mm:
4370 Use WebCore's localizedString function instead of WebLocalizableStrings
4371 since WebCore is now responsible for localization.
4373 2011-02-25 Steve Block <steveblock@google.com>
4375 Reviewed by Jeremy Orlow.
4377 Bridge.h should not include BridgeJSC.h
4378 https://bugs.webkit.org/show_bug.cgi?id=55212
4380 Include BridgeJSC.h directly instead.
4382 * Plugins/Hosted/ProxyInstance.h:
4383 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
4385 2011-02-28 Chang Shu <cshu@webkit.org>
4387 Reviewed by Ryosuke Niwa.
4389 Remove the support of Frame::isContentEditable and its dependencies.
4390 https://bugs.webkit.org/show_bug.cgi?id=54292
4392 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
4394 * WebCoreSupport/WebEditorClient.h:
4395 * WebCoreSupport/WebEditorClient.mm:
4396 * WebView/WebView.mm:
4397 (-[WebView setEditable:]):
4398 (-[WebView isEditable]):
4399 * WebView/WebViewData.h:
4401 2011-02-28 Oliver Hunt <oliver@apple.com>
4403 Reviewed by Gavin Barraclough.
4405 Make ScopeChainNode GC allocated
4406 https://bugs.webkit.org/show_bug.cgi?id=55283
4408 More updates for the absence of the ScopeChain class
4410 * WebView/WebScriptDebugDelegate.mm:
4411 (-[WebScriptCallFrame scopeChain]):
4413 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
4415 Reviewed by Pavel Feldman.
4417 DumpRenderTree should reset frame opener between tests.
4418 https://bugs.webkit.org/show_bug.cgi?id=54874
4420 Added clearOpener method to WebFramePrivate.
4422 * WebView/WebFrame.mm:
4423 (-[WebFrame _clearOpener]):
4424 * WebView/WebFramePrivate.h:
4426 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
4428 Unreviewed, rolling out r79764.
4429 http://trac.webkit.org/changeset/79764
4430 https://bugs.webkit.org/show_bug.cgi?id=55295
4432 "broke Chromium builds" (Requested by rniwa on #webkit).
4434 * WebView/WebFrame.mm:
4435 * WebView/WebFramePrivate.h:
4437 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
4439 Reviewed by David Kilzer.
4441 https://bugs.webkit.org/show_bug.cgi?id=48781
4443 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
4445 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
4446 should paint the default broken image when an image fails to load or decode. The method also passes the
4447 URL of the failed image.
4449 * WebCoreSupport/WebFrameLoaderClient.h:
4450 * WebCoreSupport/WebFrameLoaderClient.mm:
4451 (WebFrameLoaderClient::shouldPaintBrokenImage):
4452 * WebView/WebDelegateImplementationCaching.h:
4453 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
4454 (CallResourceLoadDelegateReturningBoolean):
4455 * WebView/WebResourceLoadDelegatePrivate.h:
4456 * WebView/WebView.mm:
4457 (-[WebView _cacheResourceLoadDelegateImplementations]):
4459 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
4461 Reviewed by Pavel Feldman.
4463 DumpRenderTree should reset frame opener between tests.
4464 https://bugs.webkit.org/show_bug.cgi?id=54874
4466 Added clearOpener method to WebFramePrivate.
4468 * WebView/WebFrame.mm:
4469 (-[WebFrame _clearOpener]):
4470 * WebView/WebFramePrivate.h:
4472 2011-02-25 Mark Rowe <mrowe@apple.com>
4474 <rdar://problem/8902546> Build fix.
4476 * Misc/QuickDrawCompatibility.h:
4478 2011-02-24 Anders Carlsson <andersca@apple.com>
4482 * WebCoreSupport/WebKeyGenerator.m:
4483 (toWebCertificateParseResult):
4484 (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
4485 * WebView/WebTextCompletionController.mm:
4487 2011-02-24 Peter Kasting <pkasting@google.com>
4489 Reviewed by Eric Seidel.
4491 Drop the "U; " encryption level from the User Agent string.
4492 https://bugs.webkit.org/show_bug.cgi?id=54566
4494 * WebView/WebView.mm:
4495 (+[WebView _standardUserAgentWithApplicationName:]):
4497 2011-02-24 Andrew Wilson <atwilson@chromium.org>
4499 Unreviewed, rolling out r79570.
4500 http://trac.webkit.org/changeset/79570
4501 https://bugs.webkit.org/show_bug.cgi?id=54874
4503 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
4506 * WebView/WebFrame.mm:
4507 * WebView/WebFramePrivate.h:
4509 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
4511 Reviewed by Alexey Proskuryakov.
4513 DumpRenderTree should reset frame opener between tests.
4514 https://bugs.webkit.org/show_bug.cgi?id=54874
4516 Added clearOpener method to WebFramePrivate.
4518 * WebView/WebFrame.mm:
4519 (-[WebFrame _clearOpener]):
4520 * WebView/WebFramePrivate.h:
4522 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
4524 Reviewed by Alexey Proskuryakov.
4526 Drop the language tag part from the User Agent string
4527 https://bugs.webkit.org/show_bug.cgi?id=54560
4529 * WebView/WebView.mm:
4530 (+[WebView _standardUserAgentWithApplicationName:]): Drop the
4533 2011-02-22 Brady Eidson <beidson@apple.com>
4535 Reviewed by Anders Carlsson.
4537 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
4538 API to view and delete Application Cache data by origin.
4540 * WebCoreSupport/WebApplicationCache.mm:
4541 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
4543 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
4545 Reviewed by Kent Tamura.
4547 Rename Position::node() to Position::deprecatedNode()
4548 https://bugs.webkit.org/show_bug.cgi?id=54622
4550 * WebView/WebFrame.mm:
4551 (-[WebFrame _smartDeleteRangeForProposedRange:]):
4553 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
4555 Reviewed by Kent Tamura.
4557 Rename Position::node() to Position::deprecatedNode()
4558 https://bugs.webkit.org/show_bug.cgi?id=54622
4562 * WebView/WebFrame.mm:
4563 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
4564 use containerNode() and offsetInContainerNode() instead of deprecated member functions.
4566 2011-02-18 Gavin Barraclough <barraclough@apple.com>
4568 Reviewed by Sam Weinig.
4570 Bug 54786 - Devirtualize JSCell::classInfo()
4572 Instead of making a virtual function call, add a pointer to the ClassInfo
4575 This removes a virtual function call, and paves the way towards removing all
4576 the createStructure methods, and StructureFlags/AnonymousSlotCount properties
4577 (these should be able to move onto ClassInfo).
4579 Calls to Structure::create must now pass a pointer to the ClassInfo for the
4580 structure. All objects now have a ClassInfo pointer, non-object cell types
4583 Changes are most mechanical, involving three steps:
4584 * Remove virtual classInfo() methods.
4585 * Add &s_info parameter to calls to Structure::create.
4586 * Rename ClassInfo static members on classes from 'info' to 's_info',
4589 * Plugins/Hosted/ProxyInstance.mm:
4590 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
4591 (WebKit::ProxyRuntimeMethod::createStructure):
4592 * Plugins/Hosted/ProxyRuntimeObject.h:
4593 (WebKit::ProxyRuntimeObject::createStructure):
4594 * Plugins/Hosted/ProxyRuntimeObject.mm:
4595 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
4596 * WebView/WebView.mm:
4597 (aeDescFromJSValue):
4599 2011-02-19 Brian Ryner <bryner@chromium.org>
4601 Reviewed by Adam Barth.
4603 Add missing #include of DocumentLoader.h, needed since the transitive
4604 include through Document.h is removed.
4605 https://bugs.webkit.org/show_bug.cgi?id=50489
4607 * WebView/WebFrame.mm:
4609 2011-02-19 Charlie Reis <creis@chromium.org>
4611 Reviewed by Mihai Parparita.
4613 Ensure loading has stopped in HistoryController::goToItem
4614 https://bugs.webkit.org/show_bug.cgi?id=54517
4616 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
4618 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
4620 * WebCoreSupport/WebFrameLoaderClient.mm:
4621 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
4622 * WebCoreSupport/WebFrameLoaderClient.h:
4624 2011-02-16 David Hyatt <hyatt@apple.com>
4626 Reviewed by Dan Bernstein.
4628 https://bugs.webkit.org/show_bug.cgi?id=54244
4630 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
4631 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
4633 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
4634 been changed as well.
4636 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
4638 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
4640 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
4641 still have a precise floating point position.
4643 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
4644 be rounding justification spacing in their font code.
4646 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
4648 * Misc/WebKitNSStringExtras.mm:
4649 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
4650 (-[NSString _web_widthWithFont:]):
4652 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
4654 Reviewed by Adam Roben.
4656 HTML5 <details> and <summary>: localized text
4657 https://bugs.webkit.org/show_bug.cgi?id=54260
4659 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
4660 provide the default label to be used by a <details> tag that has no <summary> child.
4662 * WebCoreSupport/WebPlatformStrategies.h:
4663 * WebCoreSupport/WebPlatformStrategies.mm:
4664 (WebPlatformStrategies::defaultDetailsSummaryText):
4666 2011-02-16 Matthew Delaney <mdelaney@apple.com>
4668 Reviewed by Simon Fraser.
4670 Allow acceleratesDrawing for WebKit2
4671 https://bugs.webkit.org/show_bug.cgi?id=54511
4673 Plumb through preference for accelerated drawing.
4675 * WebView/WebPreferenceKeysPrivate.h:
4676 * WebView/WebPreferences.mm:
4677 (+[WebPreferences initialize]):
4678 (-[WebPreferences acceleratedDrawingEnabled]):
4679 (-[WebPreferences setAcceleratedDrawingEnabled:]):
4680 * WebView/WebPreferencesPrivate.h:
4682 2011-02-15 David Kilzer <ddkilzer@apple.com>
4684 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
4686 Reviewed by Darin Adler.
4688 * WebView/WebDynamicScrollBarsView.h:
4689 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
4691 * WebView/WebDynamicScrollBarsView.mm:
4692 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
4693 implementation into correct category.
4694 * WebView/WebDynamicScrollBarsViewInternal.h:
4695 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
4697 * WebView/WebHTMLView.mm: Included
4698 WebDynamicScrollBarsViewInternal.h instead of
4699 WebDynamicScrollBarsView.h.
4701 2011-02-14 Oliver Hunt <oliver@apple.com>
4703 Reviewed by Gavin Barraclough and Geoff Garen.
4705 Refactor handles and weak pointers to become nicer and more automatic
4706 https://bugs.webkit.org/show_bug.cgi?id=54415
4708 Update to use Global<> instead of ProtectedPtr, and refactored slightly
4709 to get global data to places it's needed for when we're assigning to
4712 * ForwardingHeaders/collector/handles/Global.h: Added.
4713 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
4714 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4715 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
4716 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
4717 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
4718 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
4719 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
4720 (WebKit::NetscapePluginInstanceProxy::evaluate):
4721 (WebKit::NetscapePluginInstanceProxy::invoke):
4722 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4723 (WebKit::NetscapePluginInstanceProxy::construct):
4724 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
4725 * WebView/WebScriptDebugger.h:
4726 * WebView/WebScriptDebugger.mm:
4727 (WebScriptDebugger::WebScriptDebugger):
4729 2011-02-15 Jia Pu <jpu@apple.com>
4731 Reviewed by Darin Adler.
4733 Autocorrection should respect undo.
4734 https://bugs.webkit.org/show_bug.cgi?id=52221
4735 <rdar://problem/8663399>
4737 Please see WebCore/ChangeLog for detailed description.
4739 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
4741 * WebCoreSupport/WebEditorClient.mm:
4742 (WebEditorClient::recordAutocorrectionResponse): Ditto.
4744 * WebView/WebFrame.mm:
4745 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
4746 Adopted new signature of ReplaceSelectionCommand::create().
4748 2011-02-15 David Kilzer <ddkilzer@apple.com>
4750 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
4752 Reviewed by Darin Adler.
4754 * WebView/WebDynamicScrollBarsView.h:
4755 * WebView/WebDynamicScrollBarsView.mm:
4756 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
4757 -inProgramaticScroll.
4758 * WebView/WebHTMLView.mm:
4759 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
4761 2011-02-15 Kenneth Russell <kbr@google.com>
4763 Reviewed by Darin Fisher.
4765 Allow controlling minimum DOMTimer interval on a per-page basis
4766 https://bugs.webkit.org/show_bug.cgi?id=54312
4768 Added needed methods to implement LayoutTestController's new
4769 setMinimumTimerInterval method.
4771 * WebView/WebView.mm:
4772 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
4773 (+[WebView _defaultMinimumTimerInterval]):
4774 (-[WebView _setMinimumTimerInterval:]):
4775 * WebView/WebViewPrivate.h:
4777 2011-02-11 Geoffrey Garen <ggaren@apple.com>
4779 Reviewed by Oliver Hunt.
4781 A little more encapsulation for the heap: Removed CollectorHeapIterator
4782 https://bugs.webkit.org/show_bug.cgi?id=54298
4784 * Misc/WebCoreStatistics.mm:
4785 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
4786 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
4788 2011-02-10 Nate Chapin <japhet@chromium.org>
4790 Reviewed by Adam Barth.
4792 Update calls to DocumentWriter.
4793 https://bugs.webkit.org/show_bug.cgi?id=50489
4795 * WebView/WebFrame.mm:
4796 (-[WebFrame _canProvideDocumentSource]):
4798 2011-02-10 Chris Fleizach <cfleizach@apple.com>
4800 Reviewed by Anders Carlsson.
4802 AX: AX needs to stop using WebCoreViewFactory
4803 https://bugs.webkit.org/show_bug.cgi?id=54153
4805 * WebCoreSupport/WebSystemInterface.mm:
4806 (InitWebCoreSystemInterface):
4808 2011-02-10 Peter Varga <pvarga@webkit.org>
4810 Reviewed by Csaba Osztrogonác.
4812 Remove PCRE source from trunk
4813 https://bugs.webkit.org/show_bug.cgi?id=54188
4815 * ForwardingHeaders/pcre/pcre.h: Removed.
4817 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
4819 Reviewed by Yury Semikhatsky.
4821 Web Inspector: follow up on InspectorAgent split -
4822 removing unnecessary methods from InspectorController.
4823 https://bugs.webkit.org/show_bug.cgi?id=54093
4825 * WebInspector/WebInspector.mm:
4826 (-[WebInspector showConsole:]):
4827 (-[WebInspector stopProfilingJavaScript:]):
4829 2011-02-08 Dan Bernstein <mitz@apple.com>
4831 Reviewed by Jon Honeycutt and Maciej Stachowiak.
4833 <rdar://problem/8959420> Find in Mail no longer cycles around
4835 * WebView/WebHTMLView.mm:
4836 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
4837 the wrap option according to the flag.
4839 2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
4841 Unreviewed, rolling out r77980.
4842 http://trac.webkit.org/changeset/77980
4843 https://bugs.webkit.org/show_bug.cgi?id=54043
4845 "Crashes on Windows and Linux..." (Requested by leviw on
4848 * WebView/WebFrame.mm:
4849 (-[WebFrame _caretRectAtNode:offset:affinity:]):
4850 * WebView/WebFrameInternal.h:
4851 * WebView/WebTextCompletionController.mm:
4852 (-[WebTextCompletionController doCompletion]):
4854 2011-02-08 Levi Weintraub <leviw@chromium.org>
4856 Reviewed by Ryosuke Niwa.
4858 Stop instantiating legacy editing Positions in VisiblePosition
4859 https://bugs.webkit.org/show_bug.cgi?id=52919
4861 Changing usage of legacy VisiblePosition constructor. Since we were dealing
4862 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
4864 * WebView/WebFrame.mm:
4865 (-[WebFrame _caretRectAtPosition:affinity:]):
4866 * WebView/WebFrameInternal.h:
4867 * WebView/WebTextCompletionController.mm:
4868 (-[WebTextCompletionController doCompletion]):
4870 2011-02-08 Adam Barth <abarth@webkit.org>
4872 Reviewed by Eric Seidel.
4874 Remove orphan code from old parser
4875 https://bugs.webkit.org/show_bug.cgi?id=53984
4877 * WebCoreSupport/WebChromeClient.h:
4879 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
4881 Reviewed by Yury Semikhatsky.
4883 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
4885 https://bugs.webkit.org/show_bug.cgi?id=53169
4887 Minor change enforced by major changes in WebCore/inspector/InspectorController.
4889 * WebInspector/WebInspector.mm:
4890 (-[WebInspector isTimelineProfilingEnabled]):
4892 2011-02-07 Enrica Casucci <enrica@apple.com>
4894 Reviewed Adam Roben and Darin Adler.
4896 WebKit2: drag and drop support on Windows.
4897 https://bugs.webkit.org/show_bug.cgi?id=52775
4899 Removed createDragImageForLink from DragClient.
4901 * WebCoreSupport/WebDragClient.h:
4902 * WebCoreSupport/WebDragClient.mm:
4903 (WebDragClient::startDrag):
4905 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
4907 Reviewed by Pavel Feldman.
4909 Web Inspector: remove settings related methods from InspectorClient
4910 https://bugs.webkit.org/show_bug.cgi?id=53686
4912 * WebCoreSupport/WebInspectorClient.h:
4913 * WebCoreSupport/WebInspectorClient.mm:
4914 (WebInspectorClient::openInspectorFrontend):
4915 (WebInspectorFrontendClient::WebInspectorFrontendClient):
4917 2011-02-03 James Kozianski <koz@chromium.org>
4919 Reviewed by Dimitri Glazkov.
4921 Add navigator.registerProtocolHandler behind a flag.
4922 https://bugs.webkit.org/show_bug.cgi?id=52609
4924 * Configurations/FeatureDefines.xcconfig:
4926 2011-02-03 Adam Langley <agl@chromium.org>
4928 Reviewed by Adam Barth.
4930 Plumb mixed script URL to FrameLoaderClient
4931 https://bugs.webkit.org/show_bug.cgi?id=52384
4933 Regressions covered by http/tests/security/mixedContent/*
4935 * WebCoreSupport/WebFrameLoaderClient.h:
4936 * WebCoreSupport/WebFrameLoaderClient.mm:
4937 (WebFrameLoaderClient::didRunInsecureContent):
4939 2011-02-03 Beth Dakin <bdakin@apple.com>
4941 Reviewed by Sam Weinig.
4943 Fix for <rdar://problem/8944544> Ability to animate track
4944 for WKPainter scrollers
4946 * WebCoreSupport/WebSystemInterface.mm:
4947 (InitWebCoreSystemInterface):
4949 2011-02-02 Mark Rowe <mrowe@apple.com>
4951 Reviewed by Beth Dakin.
4953 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
4955 * WebCoreSupport/WebSystemInterface.mm:
4956 (InitWebCoreSystemInterface): Add some missing initializers.
4958 2011-02-02 Steve Lacey <sjl@chromium.org>
4960 Reviewed by Eric Carlson.
4962 Implement basic media statistics on media elements.
4963 https://bugs.webkit.org/show_bug.cgi?id=53322
4965 * Configurations/FeatureDefines.xcconfig:
4967 2011-02-01 Sam Weinig <sam@webkit.org>
4969 Reviewed by Beth Dakin.
4971 Part 2 for <rdar://problem/8492788>
4972 Adopt WKScrollbarPainterController
4974 Use header detection to define scrollbar painting controller #define.
4976 * WebCoreSupport/WebSystemInterface.mm:
4977 (InitWebCoreSystemInterface):
4979 2011-02-01 David Hyatt <hyatt@apple.com>
4981 Reviewed by Oliver Hunt.
4983 https://bugs.webkit.org/show_bug.cgi?id=53520
4985 Remove the physical terminology from IntRect and FloatRect.
4987 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
4988 we need to update our terminology to be more accurate.
4990 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
4991 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
4992 even for flipped rectangles.
4994 * WebView/WebHTMLView.mm:
4995 (setNeedsDisplayInRect):
4997 2011-02-01 Beth Dakin <bdakin@apple.com>
4999 Reviewed by Sam Weinig.
5001 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
5003 * WebCoreSupport/WebSystemInterface.mm:
5004 (InitWebCoreSystemInterface):
5006 2011-02-01 Dave Hyatt <hyatt@apple.com>
5008 Reviewed by Darin Adler.
5010 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
5013 Change printing functions to check writing-mode and properly swap width and height
5016 * WebView/WebDynamicScrollBarsView.mm:
5017 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
5018 * WebView/WebFrame.mm:
5019 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
5020 * WebView/WebFrameInternal.h:
5021 * WebView/WebHTMLView.mm:
5022 (-[WebHTMLView _web_setPrintingModeRecursive]):
5023 (-[WebHTMLView _web_clearPrintingModeRecursive]):
5024 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
5025 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
5026 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
5027 (-[WebHTMLView _endPrintMode]):
5028 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
5029 (-[WebHTMLView _endScreenPaginationMode]):
5030 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
5031 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
5032 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
5033 (-[WebHTMLView _scaleFactorForPrintOperation:]):
5034 (-[WebHTMLView setPageWidthForPrinting:]):
5035 (-[WebHTMLView knowsPageRange:]):
5037 2011-01-31 Oliver Hunt <oliver@apple.com>
5039 Convert markstack to a slot visitor API
5040 https://bugs.webkit.org/show_bug.cgi?id=53219
5042 rolling r77098, r77099, r77100, r77109, and
5043 r77111 back in, along with a few more Qt fix attempts.
5045 * WebView/WebScriptDebugDelegate.mm:
5046 (-[WebScriptCallFrame scopeChain]):
5048 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
5050 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
5052 http://trac.webkit.org/changeset/77098
5053 http://trac.webkit.org/changeset/77099
5054 http://trac.webkit.org/changeset/77100
5055 http://trac.webkit.org/changeset/77109
5056 http://trac.webkit.org/changeset/77111
5057 https://bugs.webkit.org/show_bug.cgi?id=53219
5061 * WebView/WebScriptDebugDelegate.mm:
5062 (-[WebScriptCallFrame scopeChain]):
5064 2011-01-30 Oliver Hunt <oliver@apple.com>
5066 Convert markstack to a slot visitor API
5067 https://bugs.webkit.org/show_bug.cgi?id=53219
5069 rolling r77006 and r77020 back in.
5071 * WebView/WebScriptDebugDelegate.mm:
5072 (-[WebScriptCallFrame scopeChain]):
5074 2011-01-28 Geoffrey Garen <ggaren@apple.com>
5076 Reviewed by Maciej Stachowiak.
5078 Some more Heap cleanup.
5079 https://bugs.webkit.org/show_bug.cgi?id=53357
5081 Updated for JavaScriptCore changes.
5083 * Misc/WebCoreStatistics.mm:
5084 (+[WebCoreStatistics memoryStatistics]):
5086 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
5088 Unreviewed, rolling out r77006 and r77020.
5089 http://trac.webkit.org/changeset/77006
5090 http://trac.webkit.org/changeset/77020
5091 https://bugs.webkit.org/show_bug.cgi?id=53360
5093 "Broke Windows tests" (Requested by rniwa on #webkit).
5095 * WebView/WebScriptDebugDelegate.mm:
5096 (-[WebScriptCallFrame scopeChain]):
5098 2011-01-27 Oliver Hunt <oliver@apple.com>
5100 Reviewed by Geoffrey Garen.
5102 Convert markstack to a slot visitor API
5103 https://bugs.webkit.org/show_bug.cgi?id=53219
5105 Update to new marking api
5107 * WebView/WebScriptDebugDelegate.mm:
5108 (-[WebScriptCallFrame scopeChain]):
5110 2011-01-28 Dan Bernstein <mitz@apple.com>
5112 Reviewed by Sam Weinig.
5114 <select> can't display right-to-left (rtl) languages
5115 https://bugs.webkit.org/show_bug.cgi?id=19785
5117 * WebCoreSupport/WebChromeClient.h:
5118 * WebCoreSupport/WebChromeClient.mm:
5119 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
5120 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
5122 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
5124 Unreviewed, rolling out r76891.
5125 http://trac.webkit.org/changeset/76891
5126 https://bugs.webkit.org/show_bug.cgi?id=53280
5128 Makes every layout test crash (Requested by othermaciej on
5131 * Misc/WebIconDatabase.mm:
5132 (-[ThreadEnabler threadEnablingSelector:]):
5133 (importToWebCoreFormat):
5135 2011-01-27 Nate Chapin <japhet@chromium.org>
5137 Reviewed by Adam Barth.
5139 Use Document::url() instead of FrameLoader::url().
5140 https://bugs.webkit.org/show_bug.cgi?id=41165
5142 * WebView/WebView.mm:
5143 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
5145 2011-01-27 Dan Bernstein <mitz@apple.com>
5147 Rubber-stamped by Anders Carlsson.
5149 Reverted an accidental change in r76561.
5151 * WebView/WebHTMLView.mm:
5153 2011-01-26 David Kilzer <ddkilzer@apple.com>
5155 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
5156 <rdar://problem/8821760>
5158 Reviewed by Antti Koivisto.
5160 * WebCoreSupport/WebSystemInterface.mm:
5161 (InitWebCoreSystemInterface): Added initialization for
5162 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
5164 2011-01-26 Beth Dakin <bdakin@apple.com>
5166 Reviewed by Darin Adler.
5168 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
5169 when using WKScrollbars.
5171 * WebCoreSupport/WebSystemInterface.mm:
5172 (InitWebCoreSystemInterface):
5174 2011-01-25 Darin Adler <darin@apple.com>
5176 Reviewed by Anders Carlsson.
5178 WebKit is using CSBackupSetItemExcluded incorrectly
5179 https://bugs.webkit.org/show_bug.cgi?id=53095
5180 rdar://problem/8790540
5182 * Misc/WebIconDatabase.mm:
5183 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
5184 It was incorrect, and this responsibility has been moved to WebCore.
5186 2011-01-24 Chris Marrin <cmarrin@apple.com>
5188 Reviewed by Eric Seidel.
5190 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
5191 https://bugs.webkit.org/show_bug.cgi?id=53041
5193 * Configurations/FeatureDefines.xcconfig:
5195 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
5197 Reviewed by Pavel Feldman.
5199 Web Inspector: remove "attached" state related methods from InspectorAgent
5200 https://bugs.webkit.org/show_bug.cgi?id=53086
5202 * WebCoreSupport/WebInspectorClient.h:
5203 * WebCoreSupport/WebInspectorClient.mm:
5204 (-[WebInspectorWindowController showWindow:]):
5205 (-[WebInspectorWindowController attach]):
5206 (-[WebInspectorWindowController detach]):
5208 2011-01-23 Dan Bernstein <mitz@apple.com>
5210 Reviewed by John Sullivan.
5212 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
5214 * WebCoreSupport/WebChromeClient.mm:
5215 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
5217 2011-01-22 Alexey Proskuryakov <ap@apple.com>
5219 Reviewed by Darin Adler.
5221 https://bugs.webkit.org/show_bug.cgi?id=52473
5222 Auto-scaling to avoid orphans is broken, remove dysfunctional code
5224 * WebView/WebHTMLView.mm:
5225 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
5226 (-[WebHTMLView _scaleFactorForPrintOperation:]):
5227 (-[WebHTMLView knowsPageRange:]):
5229 2011-01-21 Mark Rowe <mrowe@apple.com>
5231 Rubber-stamped by Jon Honeycutt.
5233 Fix the build when using Clang by removing some unused variables.
5235 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5236 (-[WebHostedNetscapePluginView updateAndSetWindow]):
5237 * WebView/WebFullScreenController.mm:
5238 (-[WebFullScreenController enterFullscreen:]):
5239 (-[WebFullScreenController exitFullscreen]):
5241 2011-01-21 Chris Rogers <crogers@google.com>
5243 Reviewed by Darin Fisher.
5245 Add run-time enable support for the web audio API
5246 https://bugs.webkit.org/show_bug.cgi?id=52741
5248 * WebView/WebPreferenceKeysPrivate.h:
5249 * WebView/WebPreferences.mm:
5250 (-[WebPreferences webAudioEnabled]):
5251 (-[WebPreferences setWebAudioEnabled:]):
5252 * WebView/WebPreferencesPrivate.h:
5253 * WebView/WebView.mm:
5254 (-[WebView _preferencesChangedNotification:]):
5256 2011-01-20 John Sullivan <sullivan@apple.com>
5258 Reviewed by Mark Rowe.
5260 Shift-tab doesn't cycle through fields in http authentication panel
5261 https://bugs.webkit.org/show_bug.cgi?id=52850
5263 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
5264 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
5265 Re-wired the key loop so that there aren't two views with the same nextKeyView.
5267 2011-01-20 Beth Dakin <bdakin@apple.com>
5269 Reviewed by Geoffrey Garen.
5271 Fix for <rdar://problem/8890255>
5273 Allow WebKitSystemInterface to draw scrollbars
5275 * WebCoreSupport/WebSystemInterface.mm:
5276 (InitWebCoreSystemInterface):
5278 2011-01-19 Simon Fraser <simon.fraser@apple.com>
5280 Reviewed by Sam Weinig.
5282 GraphicsLayers in subframes can get sync'd multiple times
5283 https://bugs.webkit.org/show_bug.cgi?id=52489
5285 * WebView/WebView.mm:
5286 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
5287 was renamed to syncCompositingStateIncludingSubframes().
5289 2011-01-19 Darin Adler <darin@apple.com>
5291 Reviewed by Sam Weinig.
5293 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
5294 https://bugs.webkit.org/show_bug.cgi?id=52104
5295 rdar://problem/8704226
5297 * WebView/WebDelegateImplementationCaching.h:
5298 Fix type of second integer in CallScriptDebugDelegate function overload
5299 to be int to match the actual Objective-C method. Added a new overload
5300 that includes a BOOL in the right place. Added a boolean named
5301 exceptionWasRaisedExpectsHasHandlerFlag.
5303 * WebView/WebDelegateImplementationCaching.mm:
5304 (CallDelegate): Added overloads as above.
5305 (CallScriptDebugDelegate): Ditto.
5307 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
5308 boolean argument. Marked the old method informally deprecated.
5310 * WebView/WebScriptDebugger.mm:
5311 (WebScriptDebugger::exception): Added code to call with or without the
5312 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
5314 * WebView/WebView.mm:
5315 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
5316 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
5317 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
5319 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
5321 Reviewed by Mihai Parparita.
5323 Perform some forward declaration
5324 https://bugs.webkit.org/show_bug.cgi?id=52522
5326 * Misc/WebKitNSStringExtras.mm:
5328 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
5330 Reviewed by Yury Semikhatsky.
5332 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
5333 https://bugs.webkit.org/show_bug.cgi?id=52721
5335 * WebView/WebScriptDebugger.h:
5336 * WebView/WebScriptDebugger.mm:
5338 (WebScriptDebugger::sourceParsed):
5340 2011-01-19 Levi Weintraub <leviw@google.com>
5342 Reviewed by Ryosuke Niwa.
5344 Updating to use Position::parentAnchoredEquivalent instead of
5345 the old htmlediting rangeCompliantEquivalent.
5347 remove rangeCompliantEquivalent and replace it with Position methods
5348 https://bugs.webkit.org/show_bug.cgi?id=25057
5350 * WebView/WebFrame.mm:
5351 (-[WebFrame _smartDeleteRangeForProposedRange:]):
5353 2011-01-18 Chris Fleizach <cfleizach@apple.com>
5355 Reviewed by Darin Adler.
5357 REGRESSION: A problem with Voiceover and finding links
5358 https://bugs.webkit.org/show_bug.cgi?id=52324
5360 * WebView/WebDynamicScrollBarsView.mm:
5361 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
5363 2011-01-17 David Kilzer <ddkilzer@apple.com>
5365 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
5367 Reviewed by Dan Bernstein.
5369 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
5370 DOMDocumentPrivate.h to the PrivateHeaders directory.
5372 2011-01-17 Enrica Casucci <enrica@apple.com>
5374 Reviewed by Alexey Proskuryakov.
5376 Drag and drop support: refactoring of image from link and image from selection
5377 https://bugs.webkit.org/show_bug.cgi?id=52496
5379 This work cleans up the Mac code and makes it more similar to the Windows implementation,
5380 avoiding the use of an NSView when the FrameView can be used.
5381 The refactoring is a necessary step towards the complete support of drag and drop
5384 * WebCoreSupport/WebDragClient.mm:
5385 (WebDragClient::createDragImageForLink): Added.
5386 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
5387 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
5389 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
5391 Reviewed by Yury Semikhatsky.
5393 Web Inspector: simplify debugger enabling routine.
5394 https://bugs.webkit.org/show_bug.cgi?id=52472
5396 * WebInspector/WebInspector.mm:
5397 (-[WebInspector startDebuggingJavaScript:]):
5399 2011-01-16 Dan Bernstein <mitz@apple.com>
5401 Reviewed by Simon Fraser.
5403 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
5404 https://bugs.webkit.org/show_bug.cgi?id=52550
5406 * Plugins/WebNetscapePluginView.mm:
5407 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
5408 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
5410 2011-01-16 Simon Fraser <simon.fraser@apple.com>
5412 Reviewed by Dan Bernstein.
5414 Issues with iframes and plugins when the WebView is scaled.
5415 <rdar://problem/6213380>
5417 When _scaleWebView has been called on a WebView, iframes
5418 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
5419 This is caused by AppKit NSViews not playing nicely with the scale
5420 applied through style.
5422 Work around most of these issues by adjusting the bounds size
5423 of widgets to allow iframe contents to paint with the correct scale,
5424 and fix various places in the code where we relied on coordinate
5425 transforms via NSViews (which ignore CSS transforms).
5427 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5428 (-[WebHostedNetscapePluginView updateAndSetWindow]):
5429 * WebView/WebFrameView.mm:
5430 (-[WebFrameView setBoundsSize:]):
5432 2011-01-16 Beth Dakin <bdakin@apple.com>
5434 Reviewed by Kevin Decker.
5436 Fix for <rdar://problem/8871204>
5438 Don't try to save elasticity state. Just rely on
5439 NSScrollElasticityAutomatic to restore the correct state.
5440 * WebCoreSupport/WebFrameLoaderClient.h:
5441 * WebCoreSupport/WebFrameLoaderClient.mm:
5442 (WebFrameLoaderClient::WebFrameLoaderClient):
5443 (WebFrameLoaderClient::dispatchDidFirstLayout):
5444 (WebFrameLoaderClient::provisionalLoadStarted):
5446 2011-01-14 Simon Fraser <simon.fraser@apple.com>
5448 Reviewed by Dan Bernstein.
5450 Plugins render incorrectly with transformed ancestors
5451 https://bugs.webkit.org/show_bug.cgi?id=52507
5453 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
5454 in the ancestor chain of a plugin.
5456 So use of this method with calls to -actualVisibleRectInWindow, which
5457 maps rects through the render tree to compute the correct rect,
5458 clipping via windowClipRect() if necessary.
5460 Not testable, because doing so relies on the behavior of some
5461 plugins, which stop rendering if setWindow passes an empty rect.
5463 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5464 (-[WebHostedNetscapePluginView updateAndSetWindow]):
5465 * Plugins/WebBaseNetscapePluginView.h:
5466 * Plugins/WebBaseNetscapePluginView.mm:
5467 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
5468 * Plugins/WebNetscapePluginView.mm:
5469 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
5471 2011-01-14 Yuzo Fujishima <yuzo@google.com>
5473 Reviewed by Antti Koivisto.
5475 Rename cache() to memoryCache()
5476 https://bugs.webkit.org/show_bug.cgi?id=52433
5479 (+[WebCache statistics]):
5480 (+[WebCache setDisabled:]):
5481 (+[WebCache isDisabled]):
5482 * WebView/WebView.mm:
5483 (+[WebView _setCacheModel:]):
5485 2011-01-13 Geoffrey Garen <ggaren@apple.com>
5487 Reviewed by Oliver Hunt.
5489 Split out a MarkedSpace strategy object from Heap.
5490 https://bugs.webkit.org/show_bug.cgi?id=52421
5492 * Misc/WebCoreStatistics.mm:
5493 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
5495 2011-01-14 Dan Bernstein <mitz@apple.com>
5497 Reviewed by Simon Fraser.
5499 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
5501 * WebView/WebHTMLView.mm:
5502 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
5503 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
5504 that the NSView tree doesn’t change from under AppKit as it traverses it.
5506 2011-01-14 Beth Dakin <bdakin@apple.com>
5508 Reviewed by Mark Rowe.
5510 Fix for <rdar://problem/7793902> Artifacts when scrolling
5511 page in Safari while page is loading
5513 Call setDrawsBackground:YES on the scrollView in
5514 dispatchDidFirstLayout() rather than waiting until
5515 frameLoadCompleted(). Also suspend scrolling elasticity
5516 between provisionalLoadStarted() and dispatchDidFirstLayout()
5517 * WebCoreSupport/WebFrameLoaderClient.h:
5518 * WebCoreSupport/WebFrameLoaderClient.mm:
5519 (WebFrameLoaderClient::WebFrameLoaderClient):
5520 (WebFrameLoaderClient::dispatchDidFirstLayout):
5521 (WebFrameLoaderClient::provisionalLoadStarted):
5523 2011-01-12 Enrica Casucci <enrica@apple.com>
5525 Reviewed by Darin Adler.
5527 WebKit2: Add support for drag and drop
5528 https://bugs.webkit.org/show_bug.cgi?id=52343
5529 <rdar://problem/7660558>
5531 The DragData class has been extended to provide
5532 additional context from the application (keyboard state, modal windows, etc.)
5533 as well as information of the drag pasteboard being used.
5534 These are the changes to align the behavior for WebKit.
5536 * WebView/WebView.mm:
5537 (-[WebView applicationFlags:]): Added.
5538 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
5539 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
5540 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
5541 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
5543 2011-01-12 Beth Dakin <bdakin@apple.com>
5545 Reviewed by Anders Carlsson.
5547 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
5548 Expose fixed layout through WebKit SPI
5550 <rdar://problem/8844464>
5552 And now with getters!
5553 * WebView/WebView.mm:
5554 (-[WebView _useFixedLayout]):
5555 (-[WebView _fixedLayoutSize]):
5556 * WebView/WebViewPrivate.h:
5558 2011-01-12 Beth Dakin <bdakin@apple.com>
5560 Reviewed by Anders Carlsson.
5562 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
5563 fixed layout through WebKit SPI
5565 <rdar://problem/8844464>
5567 * WebView/WebView.mm:
5568 (-[WebView _setUseFixedLayout:]):
5569 (-[WebView _setFixedLayoutSize:]):
5570 * WebView/WebViewPrivate.h:
5572 2011-01-07 Enrica Casucci <enrica@apple.com>
5574 Reviewed by Alexey Proskuryakov.
5576 Paste and drag and drop use different code paths to interact with the pasteboard.
5577 https://bugs.webkit.org/show_bug.cgi?id=52093
5578 The change consists in a refactoring of the code to have only one class that
5579 deals with the pasteboard on Mac.
5581 * WebCoreSupport/WebEditorClient.h:
5582 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
5583 exposed by NSURLExtras.
5584 (WebEditorClient::canonicalizeURL):
5585 (WebEditorClient::canonicalizeURLString):
5586 * WebCoreSupport/WebPasteboardHelper.h: Removed.
5587 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
5588 * WebView/WebHTMLView.mm: Removed comment.
5589 * WebView/WebView.mm: The following methods have been changed to use the new DragData
5590 constructor that doesn't use the WebPasteboardHelper reference.
5591 (-[WebView draggingEntered:]):
5592 (-[WebView draggingUpdated:]):
5593 (-[WebView draggingExited:]):
5594 (-[WebView performDragOperation:]):
5596 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
5598 Reviewed by Alexey Proskuryakov.
5600 Forward declare some headers where possible
5601 https://bugs.webkit.org/show_bug.cgi?id=52133
5603 * WebView/WebFrame.mm:
5605 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
5607 Reviewed by Darin Fisher.
5609 https://bugs.webkit.org/show_bug.cgi?id=41441
5610 createWindow method should only do window-creating without URL navigation
5612 * WebCoreSupport/WebChromeClient.mm:
5613 (WebChromeClient::createWindow):
5615 2011-01-08 Dan Bernstein <mitz@apple.com>
5617 Try to fix the Leopard build.
5619 * WebView/WebFullScreenController.mm:
5621 2011-01-07 Jer Noble <jer.noble@apple.com>
5623 Yet another Leopard build fix: NSRect and CGRect are not inter-
5624 changable in 32-bit.
5626 * WebView/WebFullScreenController.mm:
5627 (-[WebFullScreenController exitFullscreen]):
5629 2011-01-07 Jer Noble <jer.noble@apple.com>
5631 Fix the Leopard build: Replace CoreAnimation SL-only functions
5632 with Leopard equivalents.
5634 * WebView/WebFullScreenController.mm:
5635 (+[CATransaction setDisableActions:]):
5636 (+[CATransaction setAnimationDuration:]):
5637 (-[WebFullScreenController _animationDuration]):
5638 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
5640 2010-12-21 Jer Noble <jer.noble@apple.com>
5642 Reviewed by Simon Fraser.
5644 Implement WebKit Full Screen support.
5645 https://bugs.webkit.org/show_bug.cgi?id=49481
5646 rdar://problem/8247444
5648 Support the new fullscreen Chrome client requests. WebView will pass
5649 through these requests to a WebFullscreenController.
5651 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
5652 * WebView/WebView.mm:
5653 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
5654 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
5655 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
5656 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
5657 * WebView/WebViewData.h: Add ivar newFullscreenController.
5659 2010-12-17 Jer Noble <jer@kokode.apple.com>
5661 Reviewed by Simon Fraser.
5663 Implement WebKit Full Screen support.
5664 https://bugs.webkit.org/show_bug.cgi?id=49481
5665 rdar://problem/8247444
5667 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
5668 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
5669 window, and a custom CAAnimation animates that layer between the initial screen rect of the
5670 full screen element, to its final value. WebFullscreenController will swap the WebView out of
5671 its original window, and into the fullscreen window. The controller will replace the WebView
5672 with a placeholder view, so that if the placeholder moves or resized while the WebView is
5673 absent, the WebView will move back to the correct location when exiting fullscreen.
5675 * WebView/WebFullscreenController.h: Added.
5676 * WebView/WebFullscreenController.mm: Added.
5677 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
5678 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
5679 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
5680 (-[WebFullscreenController applicationDidResignActive:]):
5681 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
5682 the new screen parameters.
5683 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
5684 from its original screen rect into fullscreen.
5685 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
5686 Set up the animation that will take the fullscreen element back into its original screen
5688 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
5689 whether to disable screensaver and sleep.
5690 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
5691 looking for HTMLVideoElements; returns whether any are found to be playing.
5692 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
5694 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
5695 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
5696 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
5697 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
5698 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
5699 (-[WebFullscreenWindow backgroundLayer]): Ditto.
5700 (-[WebFullscreenWindow animationView]): Ditto.
5701 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
5702 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
5704 2011-01-07 James Robinson <jamesr@chromium.org>
5706 Revert "Implement mozilla's animationTime property"
5707 https://bugs.webkit.org/show_bug.cgi?id=51952
5709 This approach isn't quite right.
5711 * WebView/WebHTMLView.mm:
5712 (-[WebHTMLView drawRect:]):
5713 * WebView/WebView.mm:
5714 (layerSyncRunLoopObserverCallBack):
5716 2011-01-06 Gavin Barraclough <barraclough@apple.com>
5718 Reviewed by Geoff Garen.
5720 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
5722 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
5723 destructor early, in order to release wrappers once we know we no longer intend to use them.
5724 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
5725 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
5726 A sequence of events that triggers the bug would look like this:
5728 (1) Create a DOMWrapperWorld.
5729 (2) Register a timer in the world.
5730 (3) Call unregisterWorld() on the world.
5731 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
5732 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
5733 called forgetWorld() none exists.
5734 (6) Attempt to add a wrapper to a NULL map.
5736 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
5738 * WebView/WebScriptWorld.mm:
5739 (-[WebScriptWorld unregisterWorld]):
5741 2011-01-04 Chris Fleizach <cfleizach@apple.com>
5743 Reviewed by Sam Weinig.
5745 WK2: Support Accessibility
5746 https://bugs.webkit.org/show_bug.cgi?id=51859
5748 Use rootObject() method to get top of AX tree.
5750 * WebCoreSupport/WebFrameLoaderClient.h:
5751 (WebFrameLoaderClient::accessibilityRemoteObject):
5752 * WebView/WebFrame.mm:
5753 (-[WebFrame setAccessibleName:]):
5754 (-[WebFrame accessibilityRoot]):
5755 * WebView/WebFrameInternal.h:
5756 * WebView/WebFramePrivate.h:
5757 * WebView/WebHTMLView.mm:
5758 (-[WebHTMLView accessibilityAttributeValue:]):
5759 (-[WebHTMLView accessibilityFocusedUIElement]):
5760 (-[WebHTMLView accessibilityHitTest:]):
5761 (-[WebHTMLView _accessibilityParentForSubview:]):
5763 2011-01-04 David Kilzer <ddkilzer@apple.com>
5765 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
5767 Reviewed by Eric Carlson.
5769 This originally broke in r61581. It is inside an
5770 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
5773 * WebCoreSupport/WebFrameLoaderClient.mm: Call
5774 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
5775 use WebCore::PluginInfo.name instead of
5776 -[WebBasePluginPackage name].
5778 2011-01-02 Dan Bernstein <mitz@apple.com>
5780 Rubber-stamped by Simon Fraser.
5782 <rdar://problem/8812159> Update copyright strings
5786 2010-12-29 Dan Bernstein <mitz@apple.com>
5788 Reviewed by Ada Chan.
5790 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
5791 https://bugs.webkit.org/show_bug.cgi?id=51717
5793 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
5794 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
5796 * WebView/WebDocumentInternal.h:
5797 * WebView/WebHTMLView.mm:
5798 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
5799 (-[WebHTMLView _findString:options:]):
5800 * WebView/WebView.mm:
5803 2010-12-28 Daniel Bates <dbates@rim.com>
5805 Reviewed by Sam Weinig.
5807 Substitute // MARK: for compiler-specific #pragma mark
5808 https://bugs.webkit.org/show_bug.cgi?id=51657
5810 For consistency, we should substitute "// MARK:" for compiler-
5811 specific "#pragma mark" in the source files for the Mac port.
5813 * History/WebHistory.mm:
5814 * Plugins/WebBaseNetscapePluginView.mm:
5815 * Plugins/WebNetscapePluginView.mm:
5816 * WebCoreSupport/WebInspectorClient.mm:
5817 * WebCoreSupport/WebSecurityOrigin.mm:
5818 * WebView/WebPDFView.mm:
5819 * WebView/WebVideoFullscreenController.mm:
5820 * WebView/WebVideoFullscreenHUDWindowController.mm:
5822 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
5824 Reviewed by Darin Adler.
5826 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
5827 https://bugs.webkit.org/show_bug.cgi?id=38535
5829 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
5830 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
5831 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
5832 call frame from this stack when an exception throws because the saved top frame could be invalid.
5834 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
5835 callEvent and returnEvent.
5837 * WebView/WebScriptDebugger.mm:
5838 (WebScriptDebugger::willExecuteProgram):
5839 (WebScriptDebugger::didExecuteProgram):
5841 2010-12-22 Sam Weinig <sam@webkit.org>
5843 Reviewed by Darin Adler.
5845 WebKit2 needs to mirror the frame tree in the UIProcess
5846 https://bugs.webkit.org/show_bug.cgi?id=51546
5848 - Add client functions to notify that a frame has been added or
5849 removed from the page cache.
5851 * WebCoreSupport/WebFrameLoaderClient.h:
5852 * WebCoreSupport/WebFrameLoaderClient.mm:
5853 (WebFrameLoaderClient::didSaveToPageCache):
5854 (WebFrameLoaderClient::didRestoreFromPageCache):
5856 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
5858 Reviewed by Eric Seidel.
5860 Editor.h doesn't need to include SelectionController.h
5861 https://bugs.webkit.org/show_bug.cgi?id=51441
5863 Renamed SelectionController::EDirection to SelectionDirection.
5865 * WebView/WebFrame.mm:
5866 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
5867 Takes SelectionDirection instead of SelectionController::EDirection.
5868 * WebView/WebFrameInternal.h:
5869 * WebView/WebTextCompletionController.mm:
5870 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
5872 2010-12-22 Simon Fraser <simon.fraser@apple.com>
5874 Reviewed by Darin Adler.
5876 Cache snapshots of plug-ins before painting, to avoid script running during painting
5877 https://bugs.webkit.org/show_bug.cgi?id=51493
5879 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
5880 or when printing), plug-ins which otherwise use the CA rendering model
5881 are sent a paint event. Some plug-ins may run script while handling this event,
5882 or out of process plug-ins may process queued requests at this time. Running
5883 script while inside layout or painting can have bad consequences, because it
5884 can result in arbitrary changes to the render tree.
5886 This patch avoids sending plug-ins paint events inside of painting. Instead,
5887 we ask the plug-ins to cache a snapshot before we paint, and then the software
5888 paint simply draws that snapshot.
5890 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5891 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
5892 draw it. Also only send the snapshot message to the plugin proxy if we
5893 know we're snapshotting, since even if creating the snapshot image failed,
5894 we still don't want to call to the plug-in.
5896 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
5897 * Plugins/WebBaseNetscapePluginView.mm:
5898 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
5899 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
5901 * Plugins/WebNetscapePluginView.mm:
5902 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
5903 * WebCoreSupport/WebFrameLoaderClient.mm:
5904 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
5905 to cache and clear the snapshots.
5907 2010-12-21 Cameron Zwarich <zwarich@apple.com>
5909 Reviewed by Darin Adler.
5911 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
5912 https://bugs.webkit.org/show_bug.cgi?id=51431
5913 <rdar://problem/8791757>
5915 * Plugins/WebBasePluginPackage.mm:
5916 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
5917 it doesn't underflow.
5919 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
5921 Reviewed by Cameron Zwarich.
5923 REGRESSION(r74172): 125 java tests fail on Mac
5924 https://bugs.webkit.org/show_bug.cgi?id=51214
5926 The regression was caused by an incorrectly adding sizeof(struct fat_header)
5927 to a pointer for uint32_t as supposed to uint8_t.
5929 Fixed the bug by explicitly casting it to uint8_t* before the addition.
5931 * Plugins/WebBasePluginPackage.mm:
5932 (-[WebBasePluginPackage isNativeLibraryData:]):
5934 2010-12-15 Cameron Zwarich <zwarich@apple.com>
5936 Reviewed by Darin Adler.
5938 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
5939 https://bugs.webkit.org/show_bug.cgi?id=51144
5941 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
5942 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
5943 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
5944 inline storage is at the beginning of the Vector, it is still better to fix this
5945 and silence the warning.
5947 * Plugins/WebBasePluginPackage.mm:
5949 (-[WebBasePluginPackage isNativeLibraryData:]):
5951 2010-12-14 Mark Rowe <mrowe@apple.com>
5953 Reviewed by Sam Weinig.
5955 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
5957 * History/WebHistoryItem.mm:
5958 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
5959 always including the target in the output.
5961 2010-12-13 Alexey Proskuryakov <ap@apple.com>
5963 Reviewed by Adam Barth.
5965 https://bugs.webkit.org/show_bug.cgi?id=50953
5966 DNS Prefetch should be an opt-in feature
5968 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
5970 2010-12-13 Mike Thole <mthole@apple.com>
5972 Rubber-stamped by John Sullivan.
5974 https://bugs.webkit.org/show_bug.cgi?id=50956
5975 WebAuthenticationPanel.nib appears to have a cut-off sentence
5977 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
5978 The contents of this text field are updated dynamically before the sheet is displayed.
5980 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
5981 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
5983 2010-12-13 Antti Koivisto <antti@apple.com>
5985 Reviewed by Alexey Proskuryakov.
5987 https://bugs.webkit.org/show_bug.cgi?id=50758
5988 <rdar://problem/8722094>
5989 Defer loading print stylesheets
5991 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
5993 * WebView/WebView.mm:
5994 (+[WebView _setLoadResourcesSerially:forHost:]):
5995 * WebView/WebViewPrivate.h:
5997 2010-12-09 Matthew Delaney <mdelaney@apple.com>
5999 Reviewed by Simon Fraser.
6001 Adopt new CG API for canvas
6002 https://bugs.webkit.org/show_bug.cgi?id=50591
6004 * WebCoreSupport/WebSystemInterface.mm:
6006 2010-10-28 MORITA Hajime <morrita@google.com>
6008 Reviewed by Ojan Vafai.
6010 spellcheck does not check pasted text
6011 https://bugs.webkit.org/show_bug.cgi?id=40092
6013 Added asynchronous spell checking API to WebEditorClient using
6014 -[NSSpellChecker requestCheckingOfString].
6015 Note that WebEditorSpellCheckResponder is a small class to receive
6016 requested spell-checking result. Note that this feature is
6017 disabled at default.
6019 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
6020 enable the feature from LayoutTestController.
6022 * WebCoreSupport/WebEditorClient.h:
6023 * WebCoreSupport/WebEditorClient.mm:
6024 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
6025 (-[WebEditorSpellCheckResponder perform]):
6026 (toCoreSpellingResult):
6027 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
6028 (WebEditorClient::requestCheckingOfString):
6029 * WebView/WebPreferenceKeysPrivate.h:
6030 * WebView/WebPreferences.mm:
6031 (+[WebPreferences initialize]):
6032 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
6033 (-[WebPreferences asynchronousSpellCheckingEnabled]):
6034 * WebView/WebPreferencesPrivate.h:
6035 * WebView/WebView.mm:
6036 (-[WebView _preferencesChangedNotification:]):
6038 2010-12-09 Anders Carlsson <andersca@apple.com>
6040 Fix a bug uncovered by clang++.
6042 * WebView/WebHTMLView.mm:
6043 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
6045 2010-12-09 Anders Carlsson <andersca@apple.com>
6047 Clang++ build fixes.
6049 Silence a couple of warnings.
6051 * WebView/WebFrame.mm:
6052 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
6053 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
6054 * WebView/WebTextCompletionController.mm:
6055 (-[WebTextCompletionController filterKeyDown:]):
6057 2010-12-09 David Hyatt <hyatt@apple.com>
6059 Reviewed by Dan Bernstein.
6061 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
6062 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
6064 * WebView/WebFrameView.mm:
6065 (-[WebFrameView _isVerticalDocument]):
6066 (-[WebFrameView _isFlippedDocument]):
6067 (-[WebFrameView _scrollToEndOfDocument]):
6068 (-[WebFrameView _pageInBlockProgressionDirection:]):
6069 (-[WebFrameView scrollPageUp:]):
6070 (-[WebFrameView scrollPageDown:]):
6072 2010-12-08 Andy Estes <aestes@apple.com>
6074 Reviewed by Darin Adler.
6076 Enable pre-HTML5 parser quirks for Apple Mail.app
6077 https://bugs.webkit.org/show_bug.cgi?id=50727
6079 * WebView/WebView.mm:
6080 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
6081 application is Mail.app.
6083 2010-12-08 Brian Weinstein <bweinstein@apple.com>
6085 Reviewed by John Sullivan.
6087 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
6088 https://bugs.webkit.org/show_bug.cgi?id=50683
6090 If our context menu item already has an action, don't overwrite the action with the context menu
6093 * WebView/WebHTMLView.mm:
6094 (setMenuItemTarget):
6096 2010-12-08 Anders Carlsson <andersca@apple.com>
6098 Remove an unused variable.
6100 * WebView/WebDynamicScrollBarsView.mm:
6101 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
6103 2010-12-07 Brian Weinstein <bweinstein@apple.com>
6105 Reviewed by John Sullivan.
6107 Layering Violation in ContextMenu - member variable of type HitTestResult
6108 https://bugs.webkit.org/show_bug.cgi?id=50586
6110 Update users of ContextMenu and ContextMenuController to match where the new functions
6113 * WebCoreSupport/WebContextMenuClient.mm:
6114 (WebContextMenuClient::getCustomMenuFromDefaultItems):
6115 (WebContextMenuClient::contextMenuItemSelected):
6116 * WebView/WebHTMLView.mm:
6117 (-[WebMenuTarget validateMenuItem:]):
6119 2010-12-07 Brian Weinstein <bweinstein@apple.com>
6121 Reviewed by John Sullivan.
6123 Part of Layering Violation in ContextMenu
6124 https://bugs.webkit.org/show_bug.cgi?id=50586
6126 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
6127 was a layering violation. Also, make sure we set the menu item targets for all menu
6128 items before showing them, because the ContextMenu constructor doesn't do that anymore.
6130 * WebView/WebHTMLView.mm:
6131 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
6132 (-[WebMenuTarget WebCore::]): Ditto.
6133 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
6134 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
6135 (-[WebMenuTarget validateMenuItem:]): Ditto.
6137 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
6138 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
6139 submenus), and calls setMenuItemTarget on them.
6140 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
6143 2010-12-06 Darin Adler <darin@apple.com>
6145 Reviewed by Sam Weinig.
6147 Pass security origin to make local file decision correctly
6148 https://bugs.webkit.org/show_bug.cgi?id=48603
6150 * WebView/WebPDFView.mm:
6151 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
6153 2010-12-07 Martin Robinson <mrobinson@igalia.com>
6155 Unreviewed, rolling out r73392.
6156 http://trac.webkit.org/changeset/73392
6157 https://bugs.webkit.org/show_bug.cgi?id=50489
6159 This commit caused crashes on the GTK+ bots
6161 * WebView/WebFrame.mm:
6162 (-[WebFrame _canProvideDocumentSource]):
6164 2010-12-07 Kenichi Ishibashi <bashi@google.com>
6166 Reviewed by Kent Tamura.
6168 Let HTMLObjectElement be a form associated element
6169 https://bugs.webkit.org/show_bug.cgi?id=48821
6171 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
6173 * WebView/WebHTMLRepresentation.mm:
6174 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
6175 FormAssociatedElement instead of HTMLFormControlElement.
6176 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
6178 2010-12-06 Nate Chapin <japhet@chromium.org>
6180 Reviewed by Adam Barth.
6182 Update calls to DocumentWriter.
6183 https://bugs.webkit.org/show_bug.cgi?id=50489
6185 * WebView/WebFrame.mm:
6186 (-[WebFrame _canProvideDocumentSource]):
6188 2010-12-06 Chris Marrin <cmarrin@apple.com>
6190 Reviewed by Simon Fraser.
6192 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
6193 https://bugs.webkit.org/show_bug.cgi?id=49388
6195 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
6196 GraphicsLayer::platformLayer().
6198 * WebCoreSupport/WebChromeClient.mm:
6199 (WebChromeClient::attachRootGraphicsLayer):
6201 2010-12-04 Dan Bernstein <mitz@apple.com>
6203 Reviewed by Sam Weinig.
6205 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
6206 https://bugs.webkit.org/show_bug.cgi?id=50530
6208 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
6209 * WebView/WebHTMLView.mm:
6210 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
6211 which is passed through to WebCore.
6212 * WebView/WebPDFView.mm:
6213 (isFrameInRange): Added this helper function.
6214 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
6215 a check if the frame is in the range.
6216 * WebView/WebView.mm:
6217 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
6218 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
6219 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
6220 * WebView/WebViewPrivate.h:
6222 2010-12-03 Sam Weinig <sam@webkit.org>
6224 Reviewed by Maciej Stachowiak.
6226 Enable <a ping> for Mac/Windows/WebKit2 builds
6227 <rdar://problem/8504473>
6228 https://bugs.webkit.org/show_bug.cgi?id=50488
6230 * WebView/WebPreferences.mm:
6231 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
6233 2010-12-03 Jia Pu <jpu@apple.com>
6235 Reviewed by Darin Adler.
6237 Need to move all code that applies correction into correction panel callback.
6238 https://bugs.webkit.org/show_bug.cgi?id=50426
6239 <rdar://problem/8720832>
6241 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
6243 * WebCoreSupport/WebEditorClient.mm:
6244 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
6245 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
6246 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
6248 2010-12-02 Simon Fraser <simon.fraser@apple.com>
6250 Revert r73217 and r73227 because of continued bustage.
6252 * WebCoreSupport/WebChromeClient.mm:
6253 (WebChromeClient::attachRootGraphicsLayer):
6255 2010-12-02 Chris Marrin <cmarrin@apple.com>
6257 Reviewed by Simon Fraser.
6259 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
6260 https://bugs.webkit.org/show_bug.cgi?id=49388
6262 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
6263 GraphicsLayer::platformLayer().
6265 * WebCoreSupport/WebChromeClient.mm:
6266 (WebChromeClient::attachRootGraphicsLayer):
6268 2010-12-02 Mark Rowe <mrowe@apple.com>
6270 Reviewed by Beth Dakin.
6272 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
6274 * Misc/WebNSFileManagerExtras.m:
6275 (setMetaData): Create an autorelease pool for the duration of the thread body.
6277 2010-12-02 John Knottenbelt <jknotten@chromium.org>
6279 Reviewed by Steve Block.
6281 Move requestGeolocationPermissionForFrame to GeolocationClient
6282 https://bugs.webkit.org/show_bug.cgi?id=50061
6284 This change facilitates client-based geolocation implementation by
6285 bringing together permission control into the geolocation client
6288 Move method ChromeClient::requestGeolocationPermissionForFrame to
6289 GeolocationClient::requestPermission, and supporting class
6290 WebGeolocationPolicyListener. The moved code is unchanged except
6291 that requestPermission now takes only one argument (Geolocation*)
6292 and the Frame parameter is retrieved from the Geolocation object.
6294 * WebCoreSupport/WebChromeClient.h:
6295 * WebCoreSupport/WebChromeClient.mm:
6296 * WebCoreSupport/WebGeolocationClient.h:
6297 (WebGeolocationClient::cancelPermissionRequest):
6298 * WebCoreSupport/WebGeolocationClient.mm:
6299 (WebGeolocationClient::requestPermission):
6300 (-[WebGeolocationPolicyListener initWithGeolocation:]):
6301 (-[WebGeolocationPolicyListener allow]):
6302 (-[WebGeolocationPolicyListener deny]):
6304 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
6306 Reviewed by Eric Carlson.
6308 Style Fixes in WebPluginController
6309 https://bugs.webkit.org/show_bug.cgi?id=50397
6311 * Plugins/WebPluginController.mm:
6312 (-[WebPluginController startAllPlugins]):
6313 (-[WebPluginController stopAllPlugins]):
6315 2010-12-02 John Sullivan <sullivan@apple.com>
6317 Reviewed by Adam Roben.
6319 Slightly speculative fix for:
6321 <rdar://problem/8712674>
6322 <https://bugs.webkit.org/show_bug.cgi?id=50393>
6323 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
6325 * Panels/WebAuthenticationPanel.m:
6326 (-[WebAuthenticationPanel setUpForChallenge:]):
6327 If the realm is nil, use @"" instead.
6329 2010-12-01 Jia Pu <jpu@apple.com>
6331 Reviewed by Darin Adler.
6333 Support multiple correction candidates panel for misspelled word on Mac OS X.
6334 https://bugs.webkit.org/show_bug.cgi?id=50137
6335 <rdar://problem/8568059>
6337 This patch is for supporting multiple correction suggestion panel on Mac OS X.
6338 The behavior and implementation is similar to that of reversion candiate panel.
6340 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
6342 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
6343 Added code to handle new multiple suggestion canidate panel type.
6344 (WebEditorClient::showCorrectionPanel):
6345 (WebEditorClient::getGuessesForWord):
6347 2010-12-01 David Hyatt <hyatt@apple.com>
6349 Reviewed by Darin Adler.
6351 https://bugs.webkit.org/show_bug.cgi?id=46645
6353 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
6354 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
6355 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
6357 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
6358 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
6361 * WebView/WebDynamicScrollBarsView.mm:
6362 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
6363 (-[WebDynamicScrollBarsView updateScrollers]):
6364 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
6365 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
6366 (-[WebDynamicScrollBarsView scrollOrigin]):
6367 * WebView/WebFrameView.mm:
6368 (-[WebFrameView _scrollToBeginningOfDocument]):
6369 (-[WebFrameView _scrollToEndOfDocument]):
6371 2010-11-29 Dan Bernstein <mitz@apple.com>
6373 Reviewed by Darin Adler.
6375 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
6376 https://bugs.webkit.org/show_bug.cgi?id=50038
6377 Based on a patch from Darin Adler.
6379 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
6380 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
6381 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
6382 method. Made WebHTMLView conform to the new protocol.
6383 * WebView/WebHTMLView.mm:
6384 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
6385 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
6386 -findString:options:.
6387 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
6388 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
6389 * WebView/WebPDFView.mm:
6390 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
6391 * WebView/WebView.mm:
6392 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
6393 -countMatchesForText:options:highlight:limit:markMatches.
6394 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
6395 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
6396 -findString:options:.
6397 (incrementFrame): Changed to use WebFindOptions.
6398 (findString): Added this helper method that performs the search using the best supported
6399 method for the document view.
6400 (-[WebView findString:options:]): Changed -searchFor::::: into this.
6401 (-[WebView canMarkAllTextMatches]):
6402 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
6404 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
6405 (-[WebView rectsForTextMatches]): Ditto.
6406 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
6407 of countMatchesForText:.
6409 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
6411 Reviewed by David Hyatt.
6413 Right-to-left pages should be scrollable to reveal left overflow.
6414 https://bugs.webkit.org/show_bug.cgi?id=23556
6416 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
6417 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
6418 pages with a left overflow.
6420 * WebView/WebDynamicScrollBarsView.h:
6421 * WebView/WebDynamicScrollBarsView.mm:
6422 (-[WebDynamicScrollBarsView inProgramaticScroll]):
6423 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
6424 (-[WebDynamicScrollBarsView updateScrollers]):
6425 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
6426 (-[WebDynamicScrollBarsView setScrollOriginX:]):
6427 (-[WebDynamicScrollBarsView scrollOriginX]):
6428 * WebView/WebFrameView.mm:
6429 (-[WebFrameView _scrollToBeginningOfDocument]):
6430 (-[WebFrameView _scrollToEndOfDocument]):
6431 * WebView/WebHTMLView.mm:
6432 (-[WebHTMLView _frameOrBoundsChanged]):
6434 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
6436 Reviewed by Tony Chang.
6438 SelectionController::typingStyle() should return EditingStyle*
6439 https://bugs.webkit.org/show_bug.cgi?id=49813
6441 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
6442 Also added SelectionController::copyTypingStyle() to copy the typing style
6443 as an instance of CSSMutableStyleDeclaration.
6445 No tests are added since this is no behavioral change.
6447 * WebView/WebFrame.mm:
6448 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
6450 2010-11-19 Michael Saboff <msaboff@apple.com>
6452 Reviewed by Sam Weinig
6454 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
6456 * MigrateHeaders.make:
6458 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
6460 Reviewed by Dirk Schulze.
6462 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
6463 https://bugs.webkit.org/show_bug.cgi?id=49580
6465 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
6467 2010-11-18 Mark Rowe <mrowe@apple.com>
6469 Rubber-stamped by Adam Roben.
6471 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
6473 * Configurations/WebKit.xcconfig:
6475 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
6477 Unreviewed, rolling out r72288.
6478 http://trac.webkit.org/changeset/72288
6479 https://bugs.webkit.org/show_bug.cgi?id=49730
6481 'krit attempted to do that, but revert got stuck' (Requested
6482 by antonm on #webkit).
6484 * WebView/WebRenderLayer.mm:
6486 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
6488 Reviewed by Dirk Schulze.
6490 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
6491 https://bugs.webkit.org/show_bug.cgi?id=49580
6493 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
6495 2010-11-16 Stephanie Lewis <slewis@apple.com>
6497 Reviewed by Geoff Garen.
6499 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
6501 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
6502 every WebView, and the WebKit API doesn't support that ownership model.
6504 * WebView/WebDeviceOrientationProviderMock.h:
6505 * WebView/WebDeviceOrientationProviderMock.mm:
6506 (+[WebDeviceOrientationProviderMock shared]):
6508 2010-11-16 Dave Hyatt <hyatt@apple.com>
6510 Reviewed by Dan Bernstein.
6512 https://bugs.webkit.org/show_bug.cgi?id=11004
6514 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
6515 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
6516 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
6517 of the constructor rather than using [NSFont pointSize].
6519 https://bugs.webkit.org/show_bug.cgi?id=49582
6521 Negative leading is not handled correctly. There are two bugs here. The first is that
6522 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
6523 set them before so that we can allow them to be < 0.
6525 The second issue is that we should understand where fonts will end up relative to
6526 our baseline (excluding line height), and only allow those boxes to impact ascent and
6527 descent if the actual font box (without factoring in line height) is above or below the
6528 root line box baseline.
6530 Added fast/css/negative-leading.html
6532 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
6534 * Misc/WebKitNSStringExtras.mm:
6535 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
6536 (-[NSString _web_widthWithFont:]):
6537 * Misc/WebStringTruncator.mm:
6539 * WebView/WebPreferences.mm:
6540 (+[WebPreferences initialize]):
6542 2010-11-16 Anders Carlsson <andersca@apple.com>
6546 * WebCoreSupport/WebFrameLoaderClient.mm:
6548 2010-11-14 Kent Tamura <tkent@chromium.org>
6550 Reviewed by Andreas Kling.
6552 KeyboardEvent::keyIdentifier() should return "const String&"
6553 https://bugs.webkit.org/show_bug.cgi?id=49426
6555 * WebCoreSupport/WebEditorClient.mm:
6556 (selectorForKeyEvent):
6557 Change the type of a variable to have keyIdentifier(); String -> const String&
6559 2010-11-12 John Knottenbelt <jknotten@chromium.org>
6561 Reviewed by Steve Block.
6563 Rename GeolocationControllerClient to GeolocationClient.
6564 https://bugs.webkit.org/show_bug.cgi?id=49259
6566 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
6567 (WebGeolocationClient::webView):
6568 (WebGeolocationClient::setEnableHighAccuracy):
6569 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
6570 (WebGeolocationClient::WebGeolocationClient):
6571 (WebGeolocationClient::geolocationDestroyed):
6572 (WebGeolocationClient::startUpdating):
6573 (WebGeolocationClient::stopUpdating):
6574 (WebGeolocationClient::lastPosition):
6576 * WebView/WebView.mm:
6577 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6579 2010-11-10 Beth Dakin <bdakin@apple.com>
6581 Reviewed by Simon Fraser.
6583 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
6584 -[WebView _scaleWebView:] should take and origin and scroll the
6587 <rdar://problem/8643921>
6589 * WebView/WebView.mm:
6590 (-[WebView _scaleWebView:atOrigin:]):
6591 * WebView/WebViewPrivate.h:
6593 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
6595 Reviewed by David Hyatt.
6597 HTML5 Ruby support should be mandatory feature
6598 https://bugs.webkit.org/show_bug.cgi?id=49272
6600 Remove Ruby as optional feature.
6602 * Configurations/FeatureDefines.xcconfig:
6604 2010-11-08 Ned Holbrook <nholbrook@apple.com>
6606 Reviewed by Adam Barth.
6608 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
6609 https://bugs.webkit.org/show_bug.cgi?id=48886
6611 * WebCoreSupport/WebSystemInterface.mm:
6612 (InitWebCoreSystemInterface):
6614 2010-11-08 Nate Chapin <japhet@chromium.org>
6616 Unreviewed, build fix.
6618 Clumsy typo in r71562.
6620 * Plugins/Hosted/HostedNetscapePluginStream.mm:
6621 (WebKit::HostedNetscapePluginStream::start):
6623 2010-11-08 Nate Chapin <japhet@chromium.org>
6625 Reviewed by Alexey Proskuryakov.
6627 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
6629 * Plugins/Hosted/HostedNetscapePluginStream.mm:
6630 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
6631 * Plugins/WebNetscapePluginStream.mm:
6632 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
6633 * WebView/WebView.mm:
6634 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
6636 2010-11-08 Anders Carlsson <andersca@apple.com>
6638 Reviewed by Dan Bernstein.
6640 Plug-in views should not assume that plugins are RenderEmbeddedObjects
6641 https://bugs.webkit.org/show_bug.cgi?id=49196
6642 <rdar://problem/8638467>
6644 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
6645 (-[WebHostedNetscapePluginView pluginHostDied]):
6647 2010-11-08 Alexey Proskuryakov <ap@apple.com>
6649 Reviewed by Darin Adler.
6651 https://bugs.webkit.org/show_bug.cgi?id=48685
6652 Notify UI process about focused frame
6654 Added an empty implementation of the new ChromeClient method.
6656 * WebCoreSupport/WebChromeClient.h:
6657 * WebCoreSupport/WebChromeClient.mm:
6658 (WebChromeClient::focusedFrameChanged):
6660 2010-11-08 Anders Carlsson <andersca@apple.com>
6664 * MigrateHeaders.make:
6666 2010-11-08 Anders Carlsson <andersca@apple.com>
6668 Reviewed by Adam Roben.
6670 Remove use of HIGetScaleFactor
6671 https://bugs.webkit.org/show_bug.cgi?id=49186
6672 <rdar://problem/8618410>
6674 Scale factors can vary on a display-by-display basis and it doesn't make sense
6675 to compute scale factor event coordinates like this.
6677 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
6680 2010-11-08 Simon Fraser <simon.fraser@apple.com>
6682 Reviewed by Sam Weinig.
6684 Allow applets to participate in accelerated compositing
6685 https://bugs.webkit.org/show_bug.cgi?id=49117
6686 <rdar://problem/8625819>
6688 If Java is being loaded via the Netscape Plugin API, create a
6689 NetscapePluginWidget so that it has an implementation of platformLayer().
6691 Also clean up by using early returns.
6693 * WebCoreSupport/WebFrameLoaderClient.mm:
6695 2010-11-07 Adam Barth <abarth@webkit.org>
6697 Reviewed by Eric Seidel.
6699 Rename Cache to MemoryCache
6700 https://bugs.webkit.org/show_bug.cgi?id=49159
6703 (+[WebCache statistics]):
6704 * WebCoreSupport/WebDeviceOrientationClient.mm:
6705 (WebDeviceOrientationClient::setController):
6706 * WebView/WebView.mm:
6708 2010-11-05 Alexey Proskuryakov <ap@apple.com>
6710 Reviewed by Darin Adler.
6712 https://bugs.webkit.org/show_bug.cgi?id=49100
6713 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
6715 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
6716 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
6717 (see bug comments), and there seems to be no harm in executing this function in that case.
6719 2010-11-05 Chris Marrin <cmarrin@apple.com>
6721 Reviewed by Simon Fraser.
6723 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
6724 https://bugs.webkit.org/show_bug.cgi?id=49073
6726 * WebView/WebFrame.mm:
6727 (-[WebFrame _suspendAnimations]):
6728 (-[WebFrame _resumeAnimations]):
6730 2010-11-04 Alexey Proskuryakov <ap@apple.com>
6732 Reviewed by Darin Adler.
6734 https://bugs.webkit.org/show_bug.cgi?id=49008
6735 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
6737 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
6738 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
6739 deleted during wait:
6741 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
6744 We didn't recognize the latter.
6746 * Plugins/Hosted/NetscapePluginHostProxy.mm:
6747 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
6748 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
6749 (WebKit::NetscapePluginInstanceProxy::waitForReply):
6750 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6751 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
6753 2010-11-05 Chris Marrin <cmarrin@apple.com>
6755 Reviewed by Simon Fraser.
6757 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
6758 https://bugs.webkit.org/show_bug.cgi?id=46945
6760 * WebView/WebFrame.mm:
6761 (-[WebFrame _suspendAnimations]):
6762 (-[WebFrame _resumeAnimations]):
6764 2010-11-04 Jia Pu <jpu@apple.com>
6766 Reviewed by Dan Bernstein.
6768 reversion bubble in WebViews
6769 https://bugs.webkit.org/show_bug.cgi?id=47630
6770 <rdar://problem/8530960>
6772 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
6774 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
6775 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
6776 change to use new reversion API in AppKit.
6777 (WebEditorClient::WebEditorClient):
6778 (WebEditorClient::~WebEditorClient):
6779 (WebEditorClient::respondToChangedSelection):
6780 (WebEditorClient::showCorrectionPanel):
6781 (WebEditorClient::dismissCorrectionPanel):
6782 (WebEditorClient::isShowingCorrectionPanel):
6784 2010-11-04 Mike Thole <mthole@apple.com>
6786 Reviewed by Dan Bernstein.
6788 Title for images should use localized numerals
6789 https://bugs.webkit.org/show_bug.cgi?id=49017
6791 * WebCoreSupport/WebPlatformStrategies.mm:
6792 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
6794 2010-11-02 Daniel Bates <dbates@rim.com>
6796 Reviewed by Adam Barth.
6798 For unnamed frames, window.name returns a generated name
6799 https://bugs.webkit.org/show_bug.cgi?id=6751
6803 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
6805 * WebView/WebFrame.mm:
6808 2010-11-01 Brady Eidson <beidson@apple.com>
6810 Reviewed by Anders Carlsson.
6812 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
6813 Context menu support for WebKit 2.
6815 * WebCoreSupport/WebChromeClient.h:
6816 (WebChromeClient::showContextMenu):
6818 2010-10-29 Daniel Bates <dbates@rim.com>
6820 No review, rolling out 70971.
6821 http://trac.webkit.org/changeset/70971
6822 https://bugs.webkit.org/show_bug.cgi?id=6751
6824 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
6825 it caused layout test failures on all bots. In particular, the
6826 child count in a generated frame name differs after this patch. We need
6827 to look into this further.
6829 * WebView/WebFrame.mm:
6832 2010-10-28 Antonio Gomes <agomes@rim.com>
6834 Reviewed by Ojan Vafai.
6836 Needs a "LinuxEditingBehavior", perhaps with a better name
6837 https://bugs.webkit.org/show_bug.cgi?id=36627
6839 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
6841 * WebView/WebFrame.mm:
6843 * WebView/WebPreferencesPrivate.h:
6845 2010-10-29 Daniel Bates <dbates@rim.com>
6847 Reviewed by Adam Barth.
6849 For unnamed frames, window.name returns a generated name
6850 https://bugs.webkit.org/show_bug.cgi?id=6751
6852 Modified Mac-port to use FrameTree::uniqueName().
6854 * WebView/WebFrame.mm:
6857 2010-10-29 Darin Adler <darin@apple.com>
6859 Reviewed by Sam Weinig.
6861 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
6862 https://bugs.webkit.org/show_bug.cgi?id=48574
6864 * History/WebBackForwardList.mm:
6865 Use BackForwardListImpl.
6867 2010-10-29 Alexey Proskuryakov <ap@apple.com>
6869 Rubber-stamped by Sam Weinig.
6871 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
6872 create views for subframes.
6874 * WebView/WebViewData.h: Double negation is better than a lie.
6876 2010-10-27 Jer Noble <jer.noble@apple.com>
6878 Reviewed by Darin Adler.
6880 Full screen video in Safari (still) exits full-screen if you switch to another
6881 app on a multi-display system.
6882 https://bugs.webkit.org/show_bug.cgi?id=47364
6883 <rdar://problem/8382299>
6885 The FullScreen window does not technically close when it deactivates, but the
6886 two NSWindows that make up the FullScreen feature should not hide when deactivated.
6888 * WebView/WebVideoFullscreenController.mm:
6889 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
6890 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
6891 * WebView/WebVideoFullscreenHUDWindowController.mm:
6892 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
6894 2010-10-29 Alexey Proskuryakov <ap@apple.com>
6896 Reviewed by Darin Adler.
6898 https://bugs.webkit.org/show_bug.cgi?id=48576
6899 Let WebKit2 client know when a frame is a frameset
6901 Added a blank implementation of the new FrameLoaderClient method.
6903 * WebCoreSupport/WebFrameLoaderClient.h:
6904 * WebCoreSupport/WebFrameLoaderClient.mm:
6905 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
6907 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
6909 Reviewed by Adam Roben and David Kilzer.
6911 Fix and cleanup of build systems
6912 https://bugs.webkit.org/show_bug.cgi?id=48342
6914 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
6916 2010-10-28 Dan Bernstein <mitz@apple.com>
6918 Reviewed by Mark Rowe.
6920 LLVM compiler build fix
6922 * Misc/WebDownload.mm:
6923 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
6924 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
6926 2010-10-28 Ivan Krstić <ike@apple.com>
6928 Reviewed by Mark Rowe.
6930 Remove unused experimental proxied panel interface.
6931 <rdar://problem/7237059>
6933 * Plugins/Hosted/NetscapePluginHostManager.h:
6934 * Plugins/Hosted/NetscapePluginHostManager.mm:
6935 (WebKit::NetscapePluginHostManager::hostForPlugin):
6936 (WebKit::NetscapePluginHostManager::spawnPluginHost):
6937 (WebKit::NetscapePluginHostManager::instantiatePlugin):
6938 * Plugins/Hosted/NetscapePluginHostProxy.mm:
6939 * Plugins/Hosted/WebKitPluginClient.defs:
6940 * Plugins/Hosted/WebKitPluginHost.defs:
6941 * WebCoreSupport/WebSystemInterface.mm:
6942 (InitWebCoreSystemInterface):
6943 * WebView/WebPreferenceKeysPrivate.h:
6944 * WebView/WebPreferences.mm:
6945 (+[WebPreferences initialize]):
6946 * WebView/WebPreferencesPrivate.h:
6948 2010-10-27 Pratik Solanki <psolanki@apple.com>
6950 Reviewed by Darin Adler.
6952 Improve memSize calculation in [WebView _setCacheModel]
6953 https://bugs.webkit.org/show_bug.cgi?id=48484
6955 * WebView/WebView.mm:
6956 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
6957 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
6958 bigger power of 2. Also update WebCore cache settings.
6960 2010-10-26 Darin Adler <darin@apple.com>
6962 Reviewed by Sam Weinig.
6964 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
6965 https://bugs.webkit.org/show_bug.cgi?id=42322
6966 rdar://problem/8193631
6968 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
6969 https://bugs.webkit.org/show_bug.cgi?id=42333
6970 rdar://problem/8193643
6972 * History/WebBackForwardList.mm:
6973 (core): Return BackForwardListImpl.
6974 (kit): Take BackForwardListImpl.
6975 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
6976 (-[WebBackForwardList dealloc]): Ditto.
6977 (-[WebBackForwardList finalize]): Ditto.
6978 (-[WebBackForwardList description]): Ditto.
6979 (-[WebBackForwardList setPageCacheSize:]): Ditto.
6980 (-[WebBackForwardList pageCacheSize]): Ditto.
6981 * History/WebBackForwardListInternal.h: Ditto.
6982 * WebView/WebFrameView.mm:
6983 (-[WebFrameView keyDown:]): Ditto.
6984 * WebView/WebView.mm:
6985 (-[WebView initWithCoder:]): Ditto.
6986 (-[WebView encodeWithCoder:]): Ditto.
6987 (-[WebView backForwardList]): Ditto.
6988 (-[WebView setMaintainsBackForwardList:]): Ditto.
6990 2010-10-27 Chris Rogers <crogers@google.com>
6992 Reviewed by Chris Marrin.
6994 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
6995 https://bugs.webkit.org/show_bug.cgi?id=48279
6997 * Configurations/FeatureDefines.xcconfig:
6999 2010-10-27 Beth Dakin <bdakin@apple.com>
7001 Reviewed by Darin Adler.
7003 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
7004 SPI to scale a WebView
7006 <rdar://problem/8107667>
7008 This patch adds SPI to Mac WebKit that scales the page by the given
7011 * WebView/WebView.mm:
7012 (-[WebView _scaleWebView:]):
7013 (-[WebView _viewScaleFactor]):
7014 * WebView/WebViewPrivate.h:
7016 2010-10-27 Dan Bernstein <mitz@apple.com>
7018 Reviewed by Darin Adler.
7020 REGRESSION (r70335): Incorrect article layout in Safari Reader
7021 https://bugs.webkit.org/show_bug.cgi?id=48436
7023 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
7024 * WebView/WebView.mm:
7025 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
7026 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
7027 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
7030 2010-10-18 Jer Noble <jer.noble@apple.com>
7032 Reviewed by Eric Carlson.
7034 Safari fullscreen media element tickles when it should not.
7036 https://bugs.webkit.org/show_bug.cgi?id=47861
7038 * WebView/WebVideoFullscreenController.mm:
7039 (-[WebVideoFullscreenController updatePowerAssertions]):
7041 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
7043 Reviewed by Dmitry Titov.
7045 Resource tracking failure when trying to move a frame between documents
7046 https://bugs.webkit.org/show_bug.cgi?id=44713
7048 * WebCoreSupport/WebFrameLoaderClient.h:
7049 * WebCoreSupport/WebFrameLoaderClient.mm:
7050 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
7052 (WebFrameLoaderClient::transferLoadingResourceFromPage):
7053 Update resource tracking for a resource load that has been transferred
7056 2010-10-25 Oliver Hunt <oliver@apple.com>
7058 Reviewed by Gavin Barraclough.
7060 Remove exec and globalData arguments from jsNumber
7061 https://bugs.webkit.org/show_bug.cgi?id=48270
7063 Mechanical removal of exec parameter to jsNumber
7065 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7066 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
7067 * Plugins/Hosted/ProxyInstance.mm:
7068 (WebKit::ProxyInstance::numberValue):
7070 2010-10-24 Dan Bernstein <mitz@apple.com>
7072 Reviewed by Anders Carlsson.
7074 Expose HitTestResult::absoluteMediaURL() via WebKit API
7075 https://bugs.webkit.org/show_bug.cgi?id=48219
7077 * Misc/WebElementDictionary.mm:
7078 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
7080 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
7081 * WebKit.exp: Export WebElementMediaURLKey.
7082 * WebView/WebView.mm: Define WebElementMediaURLKey.
7083 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
7085 2010-10-24 Dan Bernstein <mitz@apple.com>
7087 Reviewed by Simon Fraser.
7089 Removed deprecated methods from the WebHTMLHighlighter private protocol.
7091 * WebCoreSupport/WebChromeClient.mm:
7092 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
7094 (WebChromeClient::paintCustomHighlight): Call
7095 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
7096 * WebView/WebHTMLViewPrivate.h:
7098 2010-10-23 Xan Lopez <xlopez@igalia.com>
7100 Reviewed by Sam Weinig.
7102 Unify globalData APIs
7103 https://bugs.webkit.org/show_bug.cgi?id=47969
7105 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7106 (WebKit::NetscapePluginInstanceProxy::evaluate):
7107 (WebKit::NetscapePluginInstanceProxy::invoke):
7108 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
7109 (WebKit::NetscapePluginInstanceProxy::construct):
7110 * WebView/WebScriptDebugDelegate.mm:
7111 (-[WebScriptCallFrame evaluateWebScript:]):
7113 2010-10-23 David Kilzer <ddkilzer@apple.com>
7115 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
7117 Reviewed by Sam Weinig.
7119 The only method defined in WebHTMLRepresentationInternal.h is
7120 also defined in WebHTMLRepresentation.h, so use that instead.
7122 * WebView/WebHTMLRepresentationInternal.h: Removed.
7124 2010-10-23 Alexey Proskuryakov <ap@apple.com>
7126 Reviewed by Anders Carlsson.
7128 https://bugs.webkit.org/show_bug.cgi?id=48083
7129 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
7131 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
7133 2010-10-22 Sam Weinig <sam@webkit.org>
7135 Reviewed by Anders Carlsson.
7137 WebKit2 needs to pass the current event modifier flags when requesting a new window
7138 https://bugs.webkit.org/show_bug.cgi?id=48140
7140 * WebCoreSupport/WebChromeClient.h:
7141 * WebCoreSupport/WebChromeClient.mm:
7142 (WebChromeClient::createWindow):
7143 * WebCoreSupport/WebFrameLoaderClient.h:
7144 * WebCoreSupport/WebFrameLoaderClient.mm:
7145 (WebFrameLoaderClient::dispatchCreatePage):
7146 Add NavigationAction parameter.
7148 2010-10-21 Andy Estes <aestes@apple.com>
7150 Reviewed by Eric Carlson.
7152 WebKit shouldn't load a plug-in based on file extension if a MIME type
7154 https://bugs.webkit.org/show_bug.cgi?id=48046
7156 If a MIME type is specified in an object or embed element, and that MIME
7157 type isn't supported by an installed plug-in, WebKit shouldn't attempt
7158 to find a plug-in based on the file extension of the url attribute.
7159 Doing so can lead to cases where a plug-in is loaded that can't handle
7160 resources of the MIME type specified by the author.
7162 * WebCoreSupport/WebFrameLoaderClient.mm:
7163 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
7164 extension if MIME type is the empty string.
7166 2010-10-20 Simon Fraser <simon.fraser@apple.com>
7168 Reviewed by Dan Bernstein.
7170 Composited elements drawn twice when WebView is layer-backed
7171 https://bugs.webkit.org/show_bug.cgi?id=48024
7172 <rdar://problem/7916580>
7174 When drawing content in a layer-backed WebView, WebFrame's test
7175 for drawing to a bitmap succeeded, causing us to paint flattened
7176 compositing layers into the view. They would also be rendered
7177 by the normal compositing path, resulting in double rendering.
7179 Fix this by detecting when the WebHTMLView is being drawn into
7180 a layer, and avoiding flattening in that case.
7182 * WebView/WebFrame.mm:
7183 (-[WebFrame _showFlattenedCompositingLayers:]):
7184 (-[WebFrame _drawRect:contentsOnly:]):
7185 * WebView/WebHTMLView.mm:
7186 (-[WebHTMLView drawLayer:inContext:]):
7187 (-[WebHTMLView _web_isDrawingIntoLayer]):
7188 * WebView/WebHTMLViewInternal.h:
7190 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
7192 Reviewed by David Levin.
7194 Repost the DatabaseTracker notifications to the main thread, if needed.
7195 https://bugs.webkit.org/show_bug.cgi?id=40655
7197 * Storage/WebDatabaseTrackerClient.mm:
7198 (DidModifyOriginData::dispatchToMainThread):
7199 (DidModifyOriginData::DidModifyOriginData):
7200 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
7201 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
7202 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
7204 2010-10-20 Simon Fraser <simon.fraser@apple.com>
7206 Reviewed by Darin Adler.
7208 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
7209 https://bugs.webkit.org/show_bug.cgi?id=47369
7211 r46947 added code that limits the size of the layer-backed view on Leopard when
7212 the page height exceeds 4096px (later adjusted to 2048px in r48401).
7214 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
7215 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
7216 to account for layer-backed view size-limiting was not fixed at the same time.
7217 This change corrects that.
7219 * WebView/WebHTMLView.mm:
7220 (-[WebHTMLView _updateLayerHostingViewPosition]):
7222 2010-10-19 Simon Fraser <simon.fraser@apple.com>
7224 Reviewed by Dan Bernstein.
7226 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
7228 AppKit has some special code to prevent it meddling with view's layers
7229 under layer-backed WebViews. When a layer-backed WebView became composited,
7230 this caused our layer to remain zero-sized. Fix this by manually
7231 setting the geometry for our layer, if the WebHTMLView has a layer.
7233 This does not seem to be a problem if the WebView becomes layer-backed, or
7234 stops being layer-backed after the WebView starts using compositing.
7236 * WebView/WebHTMLView.mm:
7237 (-[WebHTMLView attachRootLayer:]):
7239 2010-10-20 Dirk Schulze <krit@webkit.org>
7241 Reviewed by Nikolas Zimmermann.
7243 Merge ColorSpace and ImageColorSpace enums
7244 https://bugs.webkit.org/show_bug.cgi?id=47922
7246 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
7247 to follow webkit style rules.
7249 * Misc/WebKitNSStringExtras.mm:
7250 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
7252 2010-10-19 Alexey Proskuryakov <ap@apple.com>
7254 Reviewed by Anders Carlsson.
7256 https://bugs.webkit.org/show_bug.cgi?id=47933
7257 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
7259 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
7260 We need to keep _webkit_preferredLanguageCode for Safari.
7262 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
7263 Initialize wkCopyCFLocalizationPreferredName.
7265 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
7267 2010-10-18 Alexey Proskuryakov <ap@apple.com>
7269 Reviewed by David Kilzer.
7271 https://bugs.webkit.org/show_bug.cgi?id=47864
7272 Convert WebNSUserDefaultsExtras.m to .mm
7274 Also, fixed some issues in the process:
7275 - removed locking, which was only necessary when this code was in Foundation;
7276 - fixed notification center observer to actually work (previously, it picked up changes
7277 when application preferences changed, not when system language did);
7278 - removed unused NSString category;
7281 * Misc/WebNSUserDefaultsExtras.m: Removed.
7282 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
7283 (createHTTPStyleLanguageCode):
7284 (+[NSUserDefaults _webkit_defaultsDidChange]):
7285 (addLanguageChangeObserver):
7286 (+[NSUserDefaults _webkit_preferredLanguageCode]):
7288 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
7290 Reviewed by Eric Seidel.
7292 Switch to using the new Carbon NPAPI event declarations, and remove
7295 https://bugs.webkit.org/show_bug.cgi?id=40784
7297 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
7298 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
7299 (WebNetscapePluginEventHandlerCarbon::mouseExited):
7300 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
7301 (WebNetscapePluginEventHandlerCarbon::focusChanged):
7303 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
7305 Reviewed by Timothy Hatcher.
7307 Web Inspector: disable private browsing for inspector
7308 https://bugs.webkit.org/show_bug.cgi?id=47827
7310 * WebCoreSupport/WebInspectorClient.mm:
7311 (-[WebInspectorWindowController init]):
7313 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
7315 Reviewed by Pavel Feldman.
7317 Web Inspector: inspector settings/properties/states management
7318 should be extracted into separate class.
7320 We have a lot of flags/values in InspectorController.
7321 Some flags are persisting into profile.
7322 Others are part of inspector state for frontend.
7323 All these flags should keep their values after navigation.
7324 It'd be better to extract these flags/values into separate
7325 class which will care about theirs lifetime.
7327 https://bugs.webkit.org/show_bug.cgi?id=47275
7329 * WebCoreSupport/WebInspectorClient.mm:
7330 (-[WebInspectorWindowController showWindow:]):
7331 (-[WebInspectorWindowController attach]):
7332 (-[WebInspectorWindowController detach]):
7334 2010-10-13 Gavin Barraclough <barraclough@apple.com>
7336 Reviewed by Oliver Hunt.
7338 https://bugs.webkit.org/show_bug.cgi?id=43987
7339 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
7340 to construct their internal result string. Remove ScriptString (this is now
7343 * WebCoreSupport/WebFrameLoaderClient.mm:
7345 2010-10-12 Andy Estes <aestes@apple.com>
7347 Rubber-stamped by Darin Adler.
7349 Check in some cleanup from the previous commit.
7351 * WebView/WebView.mm:
7352 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
7354 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
7355 a separate class method into the only method that used it and removed
7356 the now-unnecessary class method.
7358 2010-10-12 Eric Seidel <eric@webkit.org>
7360 Reviewed by Darin Adler.
7362 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
7363 https://bugs.webkit.org/show_bug.cgi?id=45693
7365 Re-implement this former WebCore parser quirk as a
7366 Mac-only userscript-based quirk. As far as I can tell
7367 from Darin's description this should satisfy Mail's needs.
7369 * Misc/MailQuirksUserScript.js: Added.
7370 * WebView/WebView.mm:
7371 (+[WebView _mailQuirksUserScript]):
7372 (-[WebView _injectMailQuirksScript]):
7373 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
7375 2010-10-12 Simon Fraser <simon.fraser@apple.com>
7377 Reviewed by Sam Weinig.
7379 Add 'didDraw' callback for framerate tracking
7380 https://bugs.webkit.org/show_bug.cgi?id=47478
7382 Add a callback at the end of -[WebHTMLView drawRect:] so
7383 a delegate can get notified when a draw happens.
7385 * WebView/WebHTMLView.mm:
7386 (-[WebHTMLView drawRect:]):
7387 * WebView/WebUIDelegatePrivate.h:
7389 2010-10-11 Anders Carlsson <andersca@apple.com>
7391 Reviewed by Darin Adler.
7393 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
7394 https://bugs.webkit.org/show_bug.cgi?id=47523
7396 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
7398 * Misc/WebIconFetcher.h: Removed.
7399 * Misc/WebIconFetcher.mm: Removed.
7400 * Misc/WebIconFetcherInternal.h: Removed.
7401 * WebView/WebFrame.mm:
7402 * WebView/WebFramePrivate.h:
7404 2010-10-11 Jessie Berlin <jberlin@apple.com>
7406 Reviewed by Darin Adler.
7408 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
7409 representation of a WebKit1 WebSerializedJSValue.
7410 https://bugs.webkit.org/show_bug.cgi?id=47439
7412 * WebView/WebSerializedJSValue.mm:
7413 (-[WebSerializedJSValue internalRepresentation]):
7414 * WebView/WebSerializedJSValuePrivate.h:
7416 2010-10-07 Jessie Berlin <jberlin@apple.com>
7418 Reviewed by Sam Weinig.
7420 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
7421 representation of a WebKit2 WebSerializedScriptValue.
7422 https://bugs.webkit.org/show_bug.cgi?id=47390
7424 * WebView/WebSerializedJSValue.mm:
7425 (-[WebSerializedJSValue initWithInternalRepresentation:]):
7426 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
7427 internal representation.
7428 * WebView/WebSerializedJSValuePrivate.h: Added.
7430 2010-10-07 Antonio Gomes <agomes@rim.com>
7432 Reviewed by Simon Fraser.
7434 [Mac] [DRT] implement setSpatialNavigationEnabled
7435 https://bugs.webkit.org/show_bug.cgi?id=47291
7437 Added the needed bits to make it possible to enabled spatial navigation
7438 for the Mac port. For now it is being only used by DRT.
7440 * WebView/WebPreferenceKeysPrivate.h:
7441 * WebView/WebPreferences.mm:
7442 (+[WebPreferences initialize]):
7443 (-[WebPreferences isSpatialNavigationEnabled]):
7444 (-[WebPreferences setSpatialNavigationEnabled:]):
7445 * WebView/WebPreferencesPrivate.h:
7446 * WebView/WebView.mm:
7447 (-[WebView _preferencesChangedNotification:]):
7449 2010-10-07 Jer Noble <jer.noble@apple.com>
7451 Fix the Leopard 64-bit build.
7453 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
7454 framework search path.
7455 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
7457 2010-10-06 Jer Noble <jer.noble@apple.com>
7459 Reviewed by Darin Adler.
7461 Screensaver starts while watching fullscreen playback.
7462 https://bugs.webkit.org/show_bug.cgi?id=47299
7463 <rdar://problem/8478956>
7465 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
7467 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
7468 * WebView/WebVideoFullscreenController.mm:
7469 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
7470 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
7471 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
7472 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
7473 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
7474 or _disableTickleTimer.
7476 2010-10-05 Philippe Normand <pnormand@igalia.com>
7478 Reviewed by Martin Robinson.
7480 check for ENABLE(GLIB_SUPPORT) in WebView
7481 https://bugs.webkit.org/show_bug.cgi?id=46788
7483 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
7485 * WebView/WebView.mm:
7486 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
7487 (-[WebView _close]):
7488 * WebView/WebViewData.h:
7489 * WebView/WebViewInternal.h:
7491 2010-10-01 Anders Carlsson <andersca@apple.com>
7493 Fix Snow Leopard build.
7495 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7496 (WebKit::NetscapePluginInstanceProxy::getProxy):
7498 2010-10-01 Anders Carlsson <andersca@apple.com>
7500 Reviewed by Dan Bernstein.
7502 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
7503 https://bugs.webkit.org/show_bug.cgi?id=47022
7504 <rdar://problem/8504712>
7506 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7507 (WebKit::NetscapePluginInstanceProxy::getProxy):
7508 * Plugins/WebBaseNetscapePluginView.h:
7509 * Plugins/WebBaseNetscapePluginView.mm:
7510 * Plugins/WebNetscapePluginView.mm:
7511 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
7513 2010-09-30 Darin Adler <darin@apple.com>
7515 Reviewed by Sam Weinig.
7517 Remove remaining calls to deprecatedParseURL
7518 https://bugs.webkit.org/show_bug.cgi?id=26599
7520 * DOM/WebDOMOperations.mm:
7521 (-[DOMDocument URLWithAttributeString:]):
7522 * WebCoreSupport/WebFrameLoaderClient.mm:
7523 (WebFrameLoaderClient::createPlugin):
7524 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
7526 2010-09-30 Anders Carlsson <andersca@apple.com>
7528 Reviewed by Darin Adler.
7530 -[DOMDocument _documentRange] throws an exception if there is no document element
7531 https://bugs.webkit.org/show_bug.cgi?id=46934
7532 <rdar://problem/8169260>
7534 If there is no document element, just return an empty range. Otherwise we'll try to call
7535 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
7537 * DOM/WebDOMOperations.mm:
7538 (-[DOMDocument _documentRange]):
7540 2010-09-30 Chris Marrin <cmarrin@apple.com>
7542 Reviewed by Simon Fraser.
7544 Make 2D accelerated canvas rendering build on Mac
7545 https://bugs.webkit.org/show_bug.cgi?id=46007
7547 Added ACCELERATED_2D_CANVAS to FeatureDefines
7549 * Configurations/FeatureDefines.xcconfig:
7551 2010-09-30 Dan Bernstein <mitz@apple.com>
7553 Reviewed by John Sullivan.
7555 Add printing SPI allowing full control over shrink-to-fit
7556 https://bugs.webkit.org/show_bug.cgi?id=46877
7558 * WebView/WebHTMLView.mm:
7559 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
7560 * WebView/WebHTMLViewPrivate.h:
7562 2010-09-28 Johnny Ding <jnd@chromium.org>
7564 Reviewed by Adam Barth.
7566 https://bugs.webkit.org/show_bug.cgi?id=41292
7567 Some windowed plugins did not handle events through EventHandler, so we
7568 never set right gesture state for those events.
7569 This change is to set right allowPopupsFromPlugin flag to current
7570 execution frame, so WeKit can always get right gesture state on Mac.
7571 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
7572 process, that process passes the allowPopupsFromPlugin flag to
7573 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
7574 NetscapePluginInstanceProxy::evaluate.
7576 * Plugins/WebNetscapePluginView.mm:
7577 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
7579 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
7581 Reviewed by Dmitry Titov.
7583 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
7584 https://bugs.webkit.org/show_bug.cgi?id=46663
7586 * WebCoreSupport/WebFrameLoaderClient.h:
7587 * WebCoreSupport/WebFrameLoaderClient.mm:
7588 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
7590 2010-09-26 Antonio Gomes <agomes@rim.com>
7592 Reviewed by Kenneth Rohde Christiansen.
7594 DRT/Mac nodesFromRect support
7596 [Mac][DRT] Implement LayoutTestController::nodesFromRect
7597 https://bugs.webkit.org/show_bug.cgi?id=46580
7599 Implement nodesFromRect as a private method to access non-exposed Document
7600 methods, similarly to computedStyleIncludingVisitedInfo.
7602 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
7603 These headers makes it possible to:
7604 1) Get a Document off of a JSDocument;
7605 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
7606 gotten from Document::nodesFromRect to JS bindings.
7607 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
7608 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
7609 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
7611 2010-09-24 Jia Pu <jpu@apple.com>
7613 Reviewed by Dan Bernstein.
7615 automaticSpellingCorrectionEnabled isn't updated.
7616 https://bugs.webkit.org/show_bug.cgi?id=46486
7617 <rdar://problem/8475212>
7619 * WebView/WebView.mm:
7620 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
7621 instead of "automaticTextReplacementEnabled".
7623 2010-09-23 Alexey Proskuryakov <ap@apple.com>
7625 Reviewed by Darin Adler.
7627 https://bugs.webkit.org/show_bug.cgi?id=46380
7628 REGRESSION: Crash when downloading a file
7630 Downloading cannot be tested in DRT.
7632 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
7633 Don't copy null strings.
7635 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
7637 Reviewed by Yury Semikhatsky.
7639 Web Inspector: CRASH at node highlight on MAC Safari.
7640 1) run-safari --debug
7642 3) open elements panel
7643 4) hover mouse over elements panel items multiple times
7645 Looks like it is a race condition. WebNodeHighlightView doesn't check
7646 the pointer to WebNodeHighligh object and it can be nil.
7648 https://bugs.webkit.org/show_bug.cgi?id=46261
7650 * WebInspector/WebNodeHighlightView.mm:
7651 (-[WebNodeHighlightView drawRect:]):
7653 2010-09-23 Andy Estes <aestes@apple.com>
7655 Reviewed by Darin Adler.
7657 REGRESSION (r61285): some Dashboard widgets are always invisible due to
7658 HTML parser changes.
7659 https://bugs.webkit.org/show_bug.cgi?id=46435
7661 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
7664 * WebView/WebView.mm:
7665 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
7666 shouldUsePreHTML5ParserQuirks(). Return true if
7667 WebCore::Settings::usesDashboardCompatibilityMode() is true.
7668 (-[WebView _preferencesChangedNotification:]):
7669 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
7670 if Dashboard behavior is set to backward compatibility mode.
7672 2010-09-23 Matthew Delaney <mdelaney@apple.com>
7674 Reviewed by Simon Fraser.
7676 Reduce minimum DOMTimer interval
7677 https://bugs.webkit.org/show_bug.cgi?id=45362
7679 * WebView/WebView.mm:
7680 Updating set interval call to use Settings' static version inside
7681 one time init block.
7683 2010-09-22 Andy Estes <aestes@apple.com>
7685 Reviewed by Darin Adler.
7687 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
7688 https://bugs.webkit.org/show_bug.cgi?id=46334
7690 Microsoft My Day loads scripts using self-closing script tags, markup
7691 which is incompatible with the HTML5 parser. Enable parser quirks for
7694 * WebView/WebView.mm:
7695 (shouldUsePreHTML5ParserQuirks): Return true if the application is
7696 Microsoft My Day and was linked against a version of WebKit prior to the
7697 introduction of the HTML5 parser.
7699 2010-09-23 Nate Chapin <japhet@chromium.org>
7701 Reviewed by Darin Fisher.
7703 Add hyperlink auditing settings (i.e., <a ping>).
7704 https://bugs.webkit.org/show_bug.cgi?id=30458
7706 * WebView/WebPreferenceKeysPrivate.h:
7707 * WebView/WebPreferences.mm:
7708 (+[WebPreferences initialize]):
7709 (-[WebPreferences setMemoryInfoEnabled:]):
7710 (-[WebPreferences hyperlinkAuditingEnabled]):
7711 (-[WebPreferences setHyperlinkAuditingEnabled:]):
7712 * WebView/WebPreferencesPrivate.h:
7713 * WebView/WebView.mm:
7714 (-[WebView _preferencesChangedNotification:]):
7716 2010-09-22 Alexey Proskuryakov <ap@apple.com>
7718 Reviewed by Anders Carlsson.
7720 https://bugs.webkit.org/show_bug.cgi?id=43667
7721 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
7723 Test: plugins/get-javascript-url.html
7725 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7726 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
7729 2010-09-21 Darin Adler <darin@apple.com>
7731 Reviewed by Anders Carlsson.
7733 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
7734 https://bugs.webkit.org/show_bug.cgi?id=46220
7736 * Misc/WebNSFileManagerExtras.m:
7737 (setMetaData): Use CFRelease instead of HardRelease.
7738 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
7739 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
7741 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
7743 Reviewed by Kenneth Rohde Christiansen.
7745 PluginStrategy should satisfy the needs of Qt
7746 https://bugs.webkit.org/show_bug.cgi?id=45857
7747 No new functionality so no new tests.
7749 * WebCoreSupport/WebPlatformStrategies.h:
7750 * WebCoreSupport/WebPlatformStrategies.mm:
7751 (WebPlatformStrategies::getPluginInfo):
7753 2010-09-22 Paul Knight <pknight@apple.com>
7755 Reviewed by Simon Fraser.
7757 -[WebView _scheduleCompositingLayerSync] should wake the run loop
7758 https://bugs.webkit.org/show_bug.cgi?id=46226
7760 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
7762 * WebView/WebView.mm:
7763 (-[WebView _scheduleCompositingLayerSync]):
7765 2010-09-21 Andy Estes <aestes@apple.com>
7767 Reviewed by Darin Adler.
7769 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
7770 https://bugs.webkit.org/show_bug.cgi?id=46134
7772 AIM clients linked against versions of WebKit prior to the introduction
7773 of the HTML5 parser contain markup incompatible with the new parser.
7774 Enable parser quirks in this case to remain compatible with these
7777 * WebView/WebView.mm:
7778 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
7779 application is AIM and was linked against a version of WebKit prior to
7780 the introduction of the HTML5 parser, or if the
7781 WebKitPreHTML5ParserQuirks WebPreference is enabled.
7782 (-[WebView _preferencesChangedNotification:]): Call
7783 WebCore::Settings::setUsePreHTML5ParserQuirks().
7785 2010-09-21 Steve Block <steveblock@google.com>
7787 Reviewed by Jeremy Orlow.
7789 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
7790 https://bugs.webkit.org/show_bug.cgi?id=45891
7792 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
7794 * WebCoreSupport/WebDeviceOrientationClient.h:
7795 * WebCoreSupport/WebDeviceOrientationClient.mm:
7796 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
7798 2010-09-20 Philippe Normand <pnormand@igalia.com>
7800 Reviewed by Eric Carlson.
7802 [GTK] enhanced context menu for media elements
7803 https://bugs.webkit.org/show_bug.cgi?id=45021
7805 New localized strings for the media element context-menu.
7807 * WebCoreSupport/WebPlatformStrategies.h:
7808 * WebCoreSupport/WebPlatformStrategies.mm:
7809 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
7810 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
7811 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
7812 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
7813 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
7814 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
7815 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
7816 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
7817 (WebPlatformStrategies::contextMenuItemTagMediaPause):
7818 (WebPlatformStrategies::contextMenuItemTagMediaMute):
7820 2010-09-20 Andy Estes <aestes@apple.com>
7822 Reviewed by Adam Barth.
7824 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
7825 https://bugs.webkit.org/show_bug.cgi?id=40961
7827 Implement WebKitUsePreHTML5ParserQuirks preference.
7829 * WebView/WebPreferenceKeysPrivate.h:
7830 * WebView/WebPreferences.mm:
7831 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
7833 (-[WebPreferences usePreHTML5ParserQuirks]):
7834 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
7835 * WebView/WebPreferencesPrivate.h:
7836 * WebView/WebView.mm:
7837 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
7838 with the value of WebKitUsePreHTML5ParserQuirks when a preference
7841 2010-09-20 Enrica Casucci <enrica@apple.com>
7843 Reviewed by Sam Weinig.
7845 Pasteboard doesn't work in WebKit2.
7846 https://bugs.webkit.org/show_bug.cgi?id=42317
7847 <rdar://problem/7660537>
7849 Some changes to fix style inconsistencies.
7850 Added OBJC 2.0 style enumeration.
7852 * WebCoreSupport/WebEditorClient.h:
7853 * WebCoreSupport/WebEditorClient.mm:
7854 (WebEditorClient::userVisibleString):
7855 (createExcludedElementsForAttributedStringConversion):
7856 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
7858 (WebEditorClient::setInsertionPasteboard):
7859 (WebEditorClient::pasteboardTypesForSelection):
7861 2010-09-17 David Hyatt <hyatt@apple.com>
7863 Reviewed by Simon Fraser.
7865 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
7867 Make printing store the page height in the RenderView and push that into the layout state to
7868 use the new pagination model. The old pagination model is retained because it is still used
7869 for embedded WebViews.
7871 * WebView/WebHTMLView.mm:
7872 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
7874 2010-09-17 Darin Adler <darin@apple.com>
7876 Reviewed by Sam Weinig.
7878 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
7879 https://bugs.webkit.org/show_bug.cgi?id=42863
7881 * WebView/WebView.mm:
7882 (-[WebView _setZoomMultiplier:isTextOnly:]):
7883 Call functions on Frame instead of FrameView.
7885 2010-09-17 Matthew Delaney <mdelaney@apple.com>
7887 Reviewed by Simon Fraser.
7889 Reduce minimum DOMTimer interval
7890 https://bugs.webkit.org/show_bug.cgi?id=45362
7892 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
7894 2010-09-17 Chris Marrin <cmarrin@apple.com>
7896 Reviewed by Simon Fraser.
7898 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
7899 https://bugs.webkit.org/show_bug.cgi?id=45911
7901 * WebView/WebPreferenceKeysPrivate.h:
7902 * WebView/WebPreferences.mm:
7903 (+[WebPreferences initialize]):
7904 (-[WebPreferences accelerated2dCanvasEnabled]):
7905 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
7906 * WebView/WebPreferencesPrivate.h:
7907 * WebView/WebView.mm:
7908 (-[WebView _preferencesChangedNotification:]):
7910 2010-09-17 Jia Pu <jpu@apple.com>
7912 Reviewed by Dan Bernstein.
7914 WebKit should use system wide spell checking preference when application specific one isn't set.
7915 https://bugs.webkit.org/show_bug.cgi?id=45789
7916 <rdar://problem/8416041>
7918 * WebView/WebView.mm:
7919 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
7920 when the application level preferences are not set.
7922 2010-09-16 John Sullivan <sullivan@apple.com>
7924 Reviewed by Darin Adler.
7926 <rdar://problem/8395558>
7927 https://bugs.webkit.org/show_bug.cgi?id=45938
7928 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
7930 * WebView/WebHTMLView.mm:
7931 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
7932 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
7933 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
7934 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
7935 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
7936 (-[WebHTMLView viewWillMoveToHostWindow:]):
7937 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
7938 (-[WebHTMLView viewDidMoveToHostWindow]):
7941 2010-09-16 Darin Adler <darin@apple.com>
7943 Reviewed by Andreas Kling.
7945 Reduce use of HTMLInputElement::inputType so we can remove it later
7946 https://bugs.webkit.org/show_bug.cgi?id=45903
7948 * WebView/WebHTMLRepresentation.mm:
7949 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
7950 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
7952 2010-09-16 Patrick Gansterer <paroga@paroga.com>
7954 Reviewed by Darin Adler.
7956 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
7957 https://bugs.webkit.org/show_bug.cgi?id=41510
7959 This prevents usage of nil value, which would cause an uncaught exception.
7961 * WebView/WebPreferences.mm:
7962 (-[WebPreferences setUserStyleSheetLocation:]):
7964 2010-09-16 Dan Bernstein <mitz@apple.com>
7966 Reverted the previous change because r67628 has been reverted.
7968 * WebCoreSupport/WebPlatformStrategies.h:
7969 * WebCoreSupport/WebPlatformStrategies.mm:
7971 2010-09-16 Dan Bernstein <mitz@apple.com>
7973 Build fix after r67628. Added context menu item localizable strings for the items
7974 added in r67628, following equivalent menu items in Mac OS X when possible. However,
7975 this set of menu items does not make much sense for Mac OS X, and this should be
7976 addressed separately.
7978 * WebCoreSupport/WebPlatformStrategies.h:
7979 * WebCoreSupport/WebPlatformStrategies.mm:
7980 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
7981 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
7982 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
7983 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
7984 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
7985 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
7986 (WebPlatformStrategies::contextMenuItemTagMediaPause):
7987 (WebPlatformStrategies::contextMenuItemTagMediaMute):
7988 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
7990 2010-09-16 Eric Uhrhane <ericu@chromium.org>
7992 Reviewed by Jian Li.
7994 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
7995 https://bugs.webkit.org/show_bug.cgi?id=45798
7997 * Configurations/FeatureDefines.xcconfig:
7999 2010-09-15 Simon Fraser <simon.fraser@apple.com>
8001 Reviewed by Adam Roben.
8003 https://bugs.webkit.org/show_bug.cgi?id=44715
8004 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
8006 Move geometry flipping to platform-specific code.
8008 * WebView/WebHTMLView.mm:
8009 (-[WebHTMLView attachRootLayer:]):
8011 2010-09-14 Jia Pu <jpu@apple.com>
8013 Reviewed by Dan Bernstein.
8015 Only intercept ESC key press when autocorrection UI is visible.
8016 https://bugs.webkit.org/show_bug.cgi?id=45071
8018 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
8019 which provides an inteface to query whether autocorrection panel is shown.
8021 * WebCoreSupport/WebEditorClient.mm:
8022 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
8023 for invalid correction panel tag. Replaced -1 with this constant.
8024 (WebEditorClient::dismissCorrectionPanel): Ditto
8025 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
8027 2010-09-14 Mark Rowe <mrowe@apple.com>
8029 Reviewed by John Sullivan.
8031 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
8033 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
8034 * Misc/WebKitVersionChecks.m:
8035 (WebKitLinkedOnOrAfter):
8036 (setWebKitLinkTimeVersion): Set the overridden version.
8037 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
8038 * WebView/WebPreferences.mm:
8039 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
8040 * WebView/WebPreferencesPrivate.h:
8042 2010-09-14 Eric Seidel <eric@webkit.org>
8044 Unreviewed, reverting changes r67451 and r67451.
8045 Broke lots of builders.
8047 Only intercept ESC key press when autocorrection UI is visible.
8048 https://bugs.webkit.org/show_bug.cgi?id=45071
8050 * WebCoreSupport/WebEditorClient.h:
8051 * WebCoreSupport/WebEditorClient.mm:
8052 (WebEditorClient::WebEditorClient):
8053 (WebEditorClient::dismissCorrectionPanel):
8055 2010-09-14 Jia Pu <jpu@apple.com>
8057 Reviewed by Dan Bernstein.
8059 Only intercept ESC key press when autocorrection UI is visible.
8060 https://bugs.webkit.org/show_bug.cgi?id=45071
8062 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
8063 which provides an inteface to query whether autocorrection panel is shown.
8065 * WebCoreSupport/WebEditorClient.mm:
8066 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
8067 for invalid correction panel tag. Replaced -1 with this constant.
8068 (WebEditorClient::dismissCorrectionPanel): Ditto
8069 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
8071 2010-09-13 Darin Adler <darin@apple.com>
8073 Reviewed by Adam Barth.
8075 Preparation for eliminating deprecatedParseURL
8076 https://bugs.webkit.org/show_bug.cgi?id=45695
8078 * DOM/WebDOMOperations.mm:
8079 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
8080 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
8082 2010-09-13 Enrica Casucci <enrica@apple.com>
8084 Reviewed by Sam Weinig.
8086 Paste should be implemented in WebCore like Copy and Cut for Mac also.
8087 https://bugs.webkit.org/show_bug.cgi?id=45494
8088 <rdar://problem/7660537>
8090 On the Mac platform, the implementation of the paste operation is all done
8091 at the WebKit level. In order to support it on WebKit2 it is necessary to
8092 refactor the code and move this functionality at the level of WebCore like
8093 we already have on Windows.
8094 The original code relies on some in AppKit functions that call back into
8095 WebKit causing problems in WebKit2. All this functionality has been moved
8096 at the level of the editor client where it can be dealt with appropriately.
8098 * WebCoreSupport/WebEditorClient.h:
8099 * WebCoreSupport/WebEditorClient.mm:
8100 (excludedElementsForAttributedStringConversion):
8101 (WebEditorClient::documentFragmentFromAttributedString): Added.
8102 (WebEditorClient::setInsertionPasteboard):
8103 * WebCoreSupport/WebFrameLoaderClient.h:
8104 * WebCoreSupport/WebFrameLoaderClient.mm:
8105 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
8106 of the editor client.
8107 * WebView/WebHTMLView.mm: Removed paste method.
8109 2010-09-13 John Sullivan <sullivan@apple.com>
8111 Reviewed by Adam Roben.
8113 https://bugs.webkit.org/show_bug.cgi?id=45677
8114 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
8116 <rdar://problem/8404890>
8118 * WebView/WebView.mm:
8119 (-[WebView canMarkAllTextMatches]):
8120 Return NO immediately if the webview has already been closed. This was an overlooked
8121 case from the fix for 45175.
8123 2010-09-10 MORITA Hajime <morrita@google.com>
8125 Reviewed by Tony Chang.
8127 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
8128 https://bugs.webkit.org/show_bug.cgi?id=45441
8130 Moved the actual logic of hasSpellingMarker into WebCore to share
8131 it with other ports.
8133 * WebView/WebFrame.mm:
8134 (-[WebFrame hasSpellingMarker:length:]):
8136 2010-09-11 Adam Barth <abarth@webkit.org>
8138 Reviewed by Sam Weinig.
8140 Make SecurityOrigin::canDisplay an instance function
8141 https://bugs.webkit.org/show_bug.cgi?id=45219
8143 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8144 (WebKit::NetscapePluginInstanceProxy::loadRequest):
8145 * Plugins/WebNetscapePluginStream.mm:
8146 (WebNetscapePluginStream::WebNetscapePluginStream):
8147 * Plugins/WebNetscapePluginView.mm:
8148 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
8149 * Plugins/WebPluginContainerCheck.mm:
8150 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
8151 * WebView/WebFrame.mm:
8152 (-[WebFrame _allowsFollowingLink:]):
8154 2010-09-10 Sam Weinig <sam@webkit.org>
8156 Reviewed by Darin Adler.
8158 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
8159 Precursor to <rdar://problem/7660657>
8160 https://bugs.webkit.org/show_bug.cgi?id=45522
8162 * WebView/WebView.mm:
8163 (-[WebView _preferencesChangedNotification:]):
8164 (-[WebView _setZoomMultiplier:isTextOnly:]):
8165 (-[WebView _realZoomMultiplierIsTextOnly]):
8166 * WebView/WebViewData.h:
8167 * WebView/WebViewData.mm:
8168 (-[WebViewPrivate init]):
8169 Move tracking of text only zoom here from WebCore.
8171 2010-09-10 Stephanie Lewis <slewis@apple.com>
8173 Reviewed by Alexey Proskuryakov.
8175 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
8176 other implementation details of JavaScriptCore. Necessary to fix PPC build.
8178 https://bugs.webkit.org/show_bug.cgi?id=45528
8180 * Misc/WebCoreStatistics.mm:
8181 (+[WebCoreStatistics memoryStatistics]):
8183 2010-09-10 Darin Adler <darin@apple.com>
8185 Reviewed by Sam Weinig.
8187 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
8188 https://bugs.webkit.org/show_bug.cgi?id=45582
8190 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
8192 * WebCoreSupport/WebChromeClient.mm:
8193 (WebChromeClient::dashboardRegionsChanged): Changed this to call
8194 -[WebView _dashboardRegions] so we don't have two copies of that code.
8196 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
8197 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
8199 * WebView/WebView.mm:
8200 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
8202 2010-09-10 Adam Barth <abarth@webkit.org>
8204 Reviewed by Darin Fisher.
8206 Move code from WebKit-layer to DocumentLoader
8207 https://bugs.webkit.org/show_bug.cgi?id=45569
8209 This code is the most confused, but now should be a bit cleaner.
8210 There's still a magical fake-setting for creating renderers that needs
8211 to be cleaned up, but we can do that in a separate patch.
8213 * WebView/WebFrame.mm:
8214 (-[WebFrame _commitData:]):
8215 * WebView/WebFrameInternal.h:
8216 * WebView/WebHTMLRepresentation.mm:
8217 (-[WebHTMLRepresentation receivedData:withDataSource:]):
8218 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
8220 2010-09-09 Darin Adler <darin@apple.com>
8222 Reviewed by Adam Barth.
8224 Move functions from Frame to SelectionController as planned
8225 https://bugs.webkit.org/show_bug.cgi?id=45508
8227 * WebView/WebFrame.mm:
8228 (-[WebFrame _selectionGranularity]):
8229 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
8230 (-[WebFrame _typingStyle]):
8231 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
8232 * WebView/WebHTMLRepresentation.mm:
8233 (-[WebHTMLRepresentation currentForm]):
8234 * WebView/WebHTMLView.mm:
8235 (-[WebHTMLView jumpToSelection:]):
8236 (-[WebHTMLView centerSelectionInVisibleArea:]):
8237 (-[WebHTMLView _canSmartCopyOrDelete]):
8238 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
8239 (-[WebHTMLView selectionRect]):
8240 (-[WebHTMLView selectionTextRects]):
8241 (-[WebHTMLView selectionImageRect]):
8242 * WebView/WebView.mm:
8243 (-[WebView setEditable:]):
8244 Call functions on selection().
8246 2010-09-10 Adam Barth <abarth@webkit.org>
8248 Reviewed by Eric Seidel.
8250 Main resource bytes shouldn't bounce through FrameLoader
8251 https://bugs.webkit.org/show_bug.cgi?id=45496
8253 Now return the bytes to the DocumentLoader.
8255 Previously, we were checking the document for null. However, Frame can
8256 never have a null document, so this check is no longer needed.
8258 * WebView/WebFrame.mm:
8259 (-[WebFrame _addData:]):
8261 2010-09-09 John Therrell <jtherrell@apple.com>
8263 Reviewed by Alexey Proskuryakov.
8265 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
8266 https://bugs.webkit.org/show_bug.cgi?id=45134
8268 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
8269 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
8270 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
8272 * Misc/WebCoreStatistics.mm:
8273 (+[WebCoreStatistics memoryStatistics]):
8274 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
8276 2010-09-09 Jer Noble <jer.noble@apple.com>
8278 Reviewed by Mark Rowe.
8280 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
8281 <rdar://problem/8412657>
8283 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
8285 2010-09-08 Darin Adler <darin@apple.com>
8287 Reviewed by Adam Barth.
8289 Move functions from Frame to Editor as planned
8290 https://bugs.webkit.org/show_bug.cgi?id=45218
8292 * WebView/WebFrame.mm:
8293 (-[WebFrame _selectedString]):
8294 (-[WebFrame _firstRectForDOMRange:]):
8295 (-[WebFrame _markDOMRange]):
8296 (-[WebFrame _setTypingStyle:withUndoAction:]):
8297 * WebView/WebHTMLRepresentation.mm:
8298 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
8299 * WebView/WebHTMLView.mm:
8300 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
8301 (-[WebHTMLView toggleBaseWritingDirection:]):
8302 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
8303 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
8304 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
8305 (-[WebHTMLView markedTextMatchesAreHighlighted]):
8306 * WebView/WebView.mm:
8307 (-[WebView setEditable:]):
8308 Changed call sites to use editor().
8310 2010-09-08 MORITA Hajime <morrita@google.com>
8312 Reviewed by Ojan Vafai.
8314 spellcheck does not check pasted text
8315 https://bugs.webkit.org/show_bug.cgi?id=40092
8317 Implemented async spell-check APIs on WebEditorClient.
8318 The implementations are using [NSSpellChecker requestCheckingOfString]
8319 which is available only on Mac OS 10.6 or later.
8321 Note that [NSSpellChecker requestCheckingOfString] could invoke
8322 the callback block on on of their worker thread, so we need to
8323 return the result to the main thread where WebCore is running.
8324 For that purpose, we made WebEditorSpellCheckResponder class.
8326 Test: editing/spelling/spellcheck-pasted-text-001.html
8328 * WebCoreSupport/WebEditorClient.h:
8329 * WebCoreSupport/WebEditorClient.mm:
8330 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
8331 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
8332 (-[WebEditorSpellCheckResponder perform]): Added.
8333 (WebEditorClient::requestCheckingOfString): Added.
8334 * WebView/WebFramePrivate.h:
8336 2010-09-08 MORITA Hajime <morrita@google.com>
8338 Reviewed by Tony Chang.
8340 spelling underline gets lost on backspace
8341 https://bugs.webkit.org/show_bug.cgi?id=41423
8343 Switched to use a anchorNode of the selection instead of a focused
8344 node for finer control of node selection in spellingNode():
8345 With the focused node, we cannot select other nodes but the first
8346 child of that node. In some case, we need to inspect these.
8348 The API is only for LayoutTests, and the change is compatible for
8349 existing test cases.
8351 * WebView/WebFrame.mm:
8354 2010-09-08 Adam Barth <abarth@webkit.org>
8356 Rubber-stamped by Eric Seidel.
8358 Rename DocLoader to CachedResourceLoader because that's what it does.
8360 * WebView/WebFrame.mm:
8362 2010-09-07 Anders Carlsson <andersca@apple.com>
8364 Reviewed by Oliver Hunt.
8368 * Misc/WebLocalizableStrings.h:
8369 Fix a struct/tag mismatch.
8371 * WebView/WebDeviceOrientationProviderMock.mm:
8372 (-[WebDeviceOrientationProviderMock init]):
8373 Remove stray semicolon.
8375 * WebView/WebViewData.h:
8376 Remove unused class forward declaration.
8378 2010-09-07 Anders Carlsson <andersca@apple.com>
8380 Reviewed by Darin Adler.
8382 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
8384 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
8386 * Configurations/Base.xcconfig:
8388 2010-09-06 Adam Barth <abarth@webkit.org>
8390 Reviewed by Darin Adler.
8392 Rename SecurityOrigin::canLoad to canDisplay
8393 https://bugs.webkit.org/show_bug.cgi?id=45214
8395 Propagate name change.
8397 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8398 (WebKit::NetscapePluginInstanceProxy::loadRequest):
8399 * Plugins/WebNetscapePluginStream.mm:
8400 (WebNetscapePluginStream::WebNetscapePluginStream):
8401 * Plugins/WebNetscapePluginView.mm:
8402 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
8403 * Plugins/WebPluginContainerCheck.mm:
8404 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
8405 * WebView/WebFrame.mm:
8406 (-[WebFrame _allowsFollowingLink:]):
8408 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
8410 Reviewed by Darin Adler.
8412 Add NetworkingContext to avoid layer violations
8413 https://bugs.webkit.org/show_bug.cgi?id=42292
8415 Add Mac's specific implementation of FrameNetworkingContext.
8417 * WebCoreSupport/WebFrameLoaderClient.h:
8418 * WebCoreSupport/WebFrameLoaderClient.mm:
8419 * WebCoreSupport/WebFrameNetworkingContext.mm:
8420 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
8421 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
8422 (WebFrameNetworkingContext::scheduledRunLoopPairs):
8423 (WebFrameNetworkingContext::blockedError):
8425 2010-09-03 John Sullivan <sullivan@apple.com>
8427 Reviewed by Dan Bernstein.
8429 https://bugs.webkit.org/show_bug.cgi?id=45175
8430 [WebView unmarkAllTextMatches] will crash if the webview is already closed
8432 Made this and related methods robust against being called when the WebView is closed.
8434 * WebView/WebView.mm:
8435 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
8436 Bail out if the WebView is closed.
8437 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
8439 (-[WebView unmarkAllTextMatches]):
8441 (-[WebView rectsForTextMatches]):
8444 2010-09-03 Hironori Bono <hbono@chromium.org>
8446 Reviewed by Kent Tamura.
8448 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
8449 and implements it for Mac.
8450 https://bugs.webkit.org/show_bug.cgi?id=41832
8452 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
8454 (-[WebFrame hasSpellingMarker:length:]):
8455 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
8457 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
8459 Reviewed by Pavel Feldman.
8461 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
8462 https://bugs.webkit.org/show_bug.cgi?id=44230
8464 * WebCoreSupport/WebInspectorClient.h:
8465 * WebCoreSupport/WebInspectorClient.mm:
8466 (WebInspectorFrontendClient::closeWindow):
8467 (WebInspectorFrontendClient::disconnectFromBackend):
8468 (-[WebInspectorWindowController windowShouldClose:]):
8469 (-[WebInspectorWindowController destroyInspectorView:]):
8471 2010-09-02 Steve Block <steveblock@google.com>
8473 Reviewed by Adam Barth.
8475 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
8476 https://bugs.webkit.org/show_bug.cgi?id=43181
8478 This patch hooks up the mock device orientation client on Mac for use
8481 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
8482 as a proxy to either a real or mock device orientation provider, both of
8483 which implement a new WebDeviceOrientationProvider interface.
8485 The provider is created by the embedder and passed to the WebView, from
8486 where WebDeviceOrientationClient can access it.
8488 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
8489 the existing WebCore mock.
8491 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
8492 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
8493 (WebDeviceOrientationClient::WebDeviceOrientationClient):
8494 (WebDeviceOrientationClient::setController):
8495 (WebDeviceOrientationClient::startUpdating):
8496 (WebDeviceOrientationClient::stopUpdating):
8497 (WebDeviceOrientationClient::lastOrientation):
8499 * WebView/WebDeviceOrientation.h: Added.
8500 * WebView/WebDeviceOrientation.mm: Added.
8501 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
8503 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
8504 (-[WebDeviceOrientation dealloc]):
8505 * WebView/WebDeviceOrientationInternal.h: Added.
8506 * WebView/WebDeviceOrientationProvider.h: Added.
8507 * WebView/WebDeviceOrientationProviderMock.h: Added.
8508 * WebView/WebDeviceOrientationProviderMock.mm: Added.
8509 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
8510 (-[WebDeviceOrientationProviderMockInternal setController:]):
8511 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
8512 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
8513 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
8514 (-[WebDeviceOrientationProviderMock init]):
8515 (-[WebDeviceOrientationProviderMock dealloc]):
8516 (-[WebDeviceOrientationProviderMock setOrientation:]):
8517 (-[WebDeviceOrientationProviderMock setController:]):
8518 (-[WebDeviceOrientationProviderMock startUpdating]):
8519 (-[WebDeviceOrientationProviderMock stopUpdating]):
8520 (-[WebDeviceOrientationProviderMock lastOrientation]):
8521 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
8522 * WebView/WebView.mm:
8523 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8524 (-[WebView _setDeviceOrientationProvider:]):
8525 (-[WebView _deviceOrientationProvider]):
8526 * WebView/WebViewData.h:
8527 * WebView/WebViewPrivate.h:
8529 2010-09-01 Jia Pu <jpu@apple.com>
8531 Reviewed by Dan Bernstein.
8533 Add support for autocorrection UI on Mac OS X.
8534 https://bugs.webkit.org/show_bug.cgi?id=44958
8535 <rdar://problem/7326847>
8537 See detailed high level description in WebCore/ChangeLog.
8539 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
8540 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
8542 * WebCoreSupport/WebEditorClient.mm:
8543 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
8544 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
8545 dismissed before destroying the object.
8546 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
8547 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
8548 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
8550 2010-09-01 Mark Rowe <mrowe@apple.com>
8552 Reviewed by Adam Roben.
8554 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
8556 * Carbon/HIViewAdapter.m:
8557 * Carbon/HIWebView.mm:
8558 * Misc/QuickDrawCompatibility.h: Added.
8559 * Plugins/WebNetscapePluginView.mm:
8561 2010-08-31 Dave Hyatt <hyatt@apple.com>
8563 Reviewed by Sam Weinig.
8565 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
8566 the former can occur in more places without having to do the latter.
8568 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
8569 favor of the cross-platform code that all the other ports use.
8571 * Carbon/HIWebView.mm:
8573 * WebCoreSupport/WebFrameLoaderClient.mm:
8574 (WebFrameLoaderClient::forceLayout):
8575 * WebView/WebHTMLView.mm:
8576 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
8577 (-[WebHTMLView viewWillDraw]):
8578 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
8579 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
8580 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
8581 (-[WebHTMLView reapplyStyles]):
8582 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
8583 (-[WebHTMLView setNeedsToApplyStyles:]):
8584 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
8585 (-[WebHTMLView _layoutIfNeeded]):
8586 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
8587 * WebView/WebHTMLViewInternal.h:
8588 * WebView/WebView.mm:
8589 (-[WebView _viewWillDrawInternal]):
8591 2010-08-31 Sam Weinig <sam@webkit.org>
8593 Reviewed by Darin Adler.
8595 Add ability to count text matches without marking
8596 https://bugs.webkit.org/show_bug.cgi?id=43996
8598 Safari needs to be able to count text matches without triggering lots of repainting.
8599 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
8600 parameter. For backwards compatibility markAllMatchesForText: calls
8601 countMatchesForText: and passes YES for markMatches:.
8603 * WebView/WebDocumentInternal.h:
8604 * WebView/WebHTMLView.mm:
8605 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
8606 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
8607 * WebView/WebPDFView.mm:
8608 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
8609 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
8610 * WebView/WebView.mm:
8611 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
8612 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
8613 * WebView/WebViewPrivate.h:
8615 2010-08-31 Darin Adler <darin@apple.com>
8617 Reviewed by Anders Carlsson.
8619 * WebInspector/WebInspectorFrontend.mm:
8620 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
8622 2010-08-30 Mark Rowe <mrowe@apple.com>
8624 Reviewed by Darin Adler.
8626 <rdar://problem/8369736> WebKit build fails.
8628 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
8630 * Carbon/HIViewAdapter.m:
8631 * Carbon/HIWebView.mm:
8632 * Plugins/WebNetscapePluginView.mm:
8634 2010-08-30 Andy Estes <aestes@apple.com>
8636 Reviewed by Darin Adler.
8638 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
8639 https://bugs.webkit.org/show_bug.cgi?id=44865
8641 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
8642 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
8643 exposed, but since this will have a significant impact on users of WebKit nightly
8644 builds, a plugin-specific hack should be added while the underlying issue is being
8647 * WebCoreSupport/WebFrameLoaderClient.mm:
8648 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
8649 if the plugin is of type 'application/x-snkp'.
8651 2010-08-27 Jer Noble <jer.noble@apple.com>
8653 Reviewed by Eric Carlson.
8655 text/plain non-video files cause <video> to hang (while reading them?)
8656 https://bugs.webkit.org/show_bug.cgi?id=44212
8658 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
8659 the initialization routine.
8661 * WebCoreSupport/WebSystemInterface.mm:
8662 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
8664 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
8666 Unreviewed, rolling out r66198.
8667 http://trac.webkit.org/changeset/66198
8668 https://bugs.webkit.org/show_bug.cgi?id=44856
8670 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
8672 * WebCoreSupport/WebInspectorClient.h:
8673 * WebCoreSupport/WebInspectorClient.mm:
8674 (WebInspectorFrontendClient::closeWindow):
8675 (-[WebInspectorWindowController windowShouldClose:]):
8676 (-[WebInspectorWindowController destroyInspectorView]):
8678 2010-08-28 Darin Adler <darin@apple.com>
8680 Reviewed by Sam Weinig.
8682 Make an internal method used by Apple Mail into SPI
8683 https://bugs.webkit.org/show_bug.cgi?id=44832
8684 rdar://problem/5748951
8686 * WebView/WebFrame.mm:
8687 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
8688 from the internal section to the private section.
8689 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
8690 * WebView/WebFramePrivate.h: Moved the method declaration in here.
8692 2010-08-27 Jer Noble <jer.noble@apple.com>
8694 Reviewed by Eric Carlson.
8696 Add JavaScript API to allow a page to go fullscreen.
8697 rdar://problem/6867795
8699 Added chrome client overrides which support entering and exiting full screen. A new preference has
8700 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
8701 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
8702 when the chrome has started/finished its full screen animation.
8704 * Configurations/FeatureDefines.xcconfig:
8705 * WebCoreSupport/WebChromeClient.h:
8706 * WebCoreSupport/WebChromeClient.mm:
8707 (WebChromeClient::supportsFullscreenForElement):
8708 (WebChromeClient::enterFullscreenForElement):
8709 (WebChromeClient::exitFullscreenForElement):
8710 (-[WebKitFullScreenListener initWithElement:]):
8711 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
8712 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
8713 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
8714 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
8715 * WebView/WebPreferenceKeysPrivate.h:
8716 * WebView/WebPreferences.h:
8717 * WebView/WebPreferences.mm:
8718 (+[WebPreferences initialize]):
8719 (-[WebPreferences setFullScreenEnabled:]):
8720 (-[WebPreferences fullScreenEnabled]):
8721 * WebView/WebUIDelegatePrivate.h:
8722 * WebView/WebView.mm:
8723 (-[WebView _preferencesChangedNotification:]):
8725 2010-08-27 David Hyatt <hyatt@apple.com>
8727 Reviewed by Simon Fraser.
8729 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
8731 Rename the various modes to match the HTML5 specification:
8732 ParseMode -> CompatibilityMode
8733 CompatMode -> QuirksMode
8734 AlmostStrictMode -> LimitedQuirksMode
8735 StrictMode -> NoQuirksMode
8737 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
8738 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
8740 Clean up user stylesheets to minimize style recalculation when the mode is switched.
8742 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
8743 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
8744 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
8747 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
8750 * WebView/WebView.mm:
8751 (-[WebView _preferencesChangedNotification:]):
8753 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
8755 Reviewed by Pavel Feldman.
8757 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
8758 https://bugs.webkit.org/show_bug.cgi?id=44230
8760 * WebCoreSupport/WebInspectorClient.h:
8761 * WebCoreSupport/WebInspectorClient.mm:
8762 (WebInspectorFrontendClient::closeWindow):
8763 (WebInspectorFrontendClient::disconnectFromBackend):
8764 (-[WebInspectorWindowController windowShouldClose:]):
8765 (-[WebInspectorWindowController destroyInspectorView:]):
8767 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
8769 Unreviewed. Revert r66103 since Qt tests are failing.
8771 * WebCoreSupport/WebInspectorClient.h:
8772 * WebCoreSupport/WebInspectorClient.mm:
8773 (WebInspectorFrontendClient::closeWindow):
8774 (-[WebInspectorWindowController windowShouldClose:]):
8775 (-[WebInspectorWindowController destroyInspectorView]):
8777 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
8779 Reviewed by Pavel Feldman.
8781 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
8782 https://bugs.webkit.org/show_bug.cgi?id=44230
8784 * WebCoreSupport/WebInspectorClient.h:
8785 * WebCoreSupport/WebInspectorClient.mm:
8786 (WebInspectorFrontendClient::closeWindow):
8787 (WebInspectorFrontendClient::disconnectFromBackend):
8788 (-[WebInspectorWindowController windowShouldClose:]):
8789 (-[WebInspectorWindowController destroyInspectorView:]):
8791 2010-08-24 Eric Seidel <eric@webkit.org>
8793 Reviewed by Adam Barth.
8795 Remove HTML5 parser testing infrastructure now that we don't need it
8796 https://bugs.webkit.org/show_bug.cgi?id=44581
8798 * WebView/WebPreferenceKeysPrivate.h:
8799 * WebView/WebPreferences.mm:
8800 (+[WebPreferences initialize]):
8801 * WebView/WebPreferencesPrivate.h:
8802 * WebView/WebView.mm:
8803 (-[WebView _preferencesChangedNotification:]):
8805 2010-08-24 Sam Weinig <sam@webkit.org>
8807 Reviewed by Oliver Hunt.
8809 Paste event fires twice for mac WebKit
8810 <rdar://problem/8094611>
8811 https://bugs.webkit.org/show_bug.cgi?id=44535
8813 The mac implementation of paste in WebKit was accidentally calling
8814 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
8815 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
8816 Use the new pasteAsPlainTextBypassingDHTML function to bypass the
8819 * WebView/WebHTMLView.mm:
8820 (-[WebHTMLView paste:]):
8822 2010-08-24 Daniel Cheng <dcheng@chromium.org>
8824 Reviewed by Eric Seidel.
8826 [chromium] Generate drag images for HTML elements and selections.
8827 https://bugs.webkit.org/show_bug.cgi?id=43449
8829 Fix up calls to Frame::nodeImage, which has a new signature.
8831 * Plugins/WebBaseNetscapePluginView.mm:
8832 (-[WebBaseNetscapePluginView halt]):
8834 2010-08-23 Mike Thole <mthole@apple.com>
8836 Reviewed by Dan Bernstein.
8838 WebPDFView should remove itself as the delegate of its PDFView before being dealloced
8839 https://bugs.webkit.org/show_bug.cgi?id=44441
8841 * WebView/WebPDFView.mm:
8842 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
8844 2010-08-22 Daniel Bates <dbates@rim.com>
8846 Reviewed by Eric Seidel.
8848 Encapsulate document marker management into DocumentMarkerController
8849 https://bugs.webkit.org/show_bug.cgi?id=44383
8851 Modify call sites in the Apple Mac port to use DocumentMarkerController.
8853 No functionality was changed, so no new tests.
8855 * WebView/WebFrame.mm:
8856 (-[WebFrame _unmarkAllBadGrammar]):
8857 (-[WebFrame _unmarkAllMisspellings]):
8858 * WebView/WebHTMLView.mm:
8859 (-[WebHTMLView unmarkAllTextMatches]):
8860 (-[WebHTMLView rectsForTextMatches]):
8862 2010-08-19 David Kilzer <ddkilzer@apple.com>
8864 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
8866 Reviewed by Joseph Pecoraro.
8868 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
8869 USE(PLUGIN_HOST_PROCESS) to
8870 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
8871 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
8872 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
8873 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
8874 * Plugins/Hosted/ProxyInstance.mm: Ditto.
8875 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
8876 * WebCoreSupport/WebChromeClient.mm: Ditto.
8877 (WebChromeClient::createWindow):
8878 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
8879 (WebFrameLoaderClient::dispatchCreatePage):
8880 * WebView/WebHTMLView.mm:
8881 (needsCursorRectsSupportAtPoint): Added #if
8882 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
8883 * WebView/WebView.mm:
8884 (+[WebView _isNodeHaltedPlugin:]): Ditto.
8885 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
8886 (+[WebView _restartHaltedPluginForNode:]): Ditto.
8888 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
8890 Reviewed by Darin Adler.
8892 Add NetworkingContext to avoid layer violations
8893 https://bugs.webkit.org/show_bug.cgi?id=42292
8895 Preparation: Just add the files to the build system.
8897 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
8898 Placeholder with tentative code that might be changed when landing
8900 * WebCoreSupport/WebFrameNetworkingContext.mm: Added.
8901 Empty placeholder for now.
8903 2010-08-17 Brady Eidson <beidson@apple.com>
8905 Reviewed by Sam Weinig.
8907 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
8908 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
8910 * WebView/WebView.mm:
8911 (-[WebView canGoBack]): Return false if loads are deferred.
8912 (-[WebView canGoForward]): Ditto.
8914 2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
8916 Reviewed by Pavel Feldman.
8918 Web Inspector: -[WebInspector attach] and detach should work
8919 https://bugs.webkit.org/show_bug.cgi?id=43924
8921 For actions that relate only to the Web Inspector's Frontend
8922 window (actions on the InspectorFrontendClient) the new Obj-C
8923 wrapper class WebInspectorFrontend can be used. For now, this
8924 is just attach and detach.
8926 * WebCoreSupport/WebInspectorClient.mm:
8927 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
8928 * WebInspector/WebInspector.h:
8929 * WebInspector/WebInspector.mm:
8930 (-[WebInspector dealloc]):
8931 (-[WebInspector attach:]): delegate to the frontend.
8932 (-[WebInspector detach:]): delegate to the frontend.
8933 (-[WebInspector setFrontend:]):
8934 * WebInspector/WebInspectorFrontend.h: Added.
8935 * WebInspector/WebInspectorFrontend.mm: Added.
8936 (-[WebInspectorFrontend initWithFrontendClient:]):
8937 (-[WebInspectorFrontend attach]):
8938 (-[WebInspectorFrontend detach]):
8939 * WebInspector/WebInspectorPrivate.h:
8941 2010-08-13 Gavin Barraclough <barraclough@apple.com>
8943 Rubber stamped by Sam Weinig.
8944 Switch String::/UString::ascii() to return a CString.
8946 * Plugins/Hosted/ProxyInstance.mm:
8947 (WebKit::ProxyInstance::methodsNamed):
8948 (WebKit::ProxyInstance::fieldNamed):
8950 2010-08-13 Gavin Barraclough <barraclough@apple.com>
8952 Reviewed by Sam Weinig
8954 Unify UString::UTF8String() & String::utf8() methods,
8955 remove UString::cost() & make atArrayIndex a free function.
8957 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8958 (WebKit::NetscapePluginInstanceProxy::enumerate):
8960 2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
8962 Unreviewed, rolling out r65295.
8963 http://trac.webkit.org/changeset/65295
8964 https://bugs.webkit.org/show_bug.cgi?id=43950
8966 It broke 4 sputnik tests (Requested by Ossy on #webkit).
8968 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8969 (WebKit::NetscapePluginInstanceProxy::enumerate):
8971 2010-08-12 Gavin Barraclough <barraclough@apple.com>
8973 Reviewed by Sam Weinig
8975 Unify UString::UTF8String() & String::utf8() methods,
8976 remove UString::cost() & make atArrayIndex a free function.
8978 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8979 (WebKit::NetscapePluginInstanceProxy::enumerate):
8981 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
8984 https://bugs.webkit.org/show_bug.cgi?id=43794
8986 * WebView/WebView.mm:
8987 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8988 (-[WebView _preferencesChangedNotification:]):
8990 2010-08-10 Jeremy Orlow <jorlow@chromium.org>
8992 Reviewed by Adam Barth.
8994 Some settings are linked to the PageGroup not the Page. Create a new class for those.
8995 https://bugs.webkit.org/show_bug.cgi?id=43794
8997 Change WebView to use the new GroupSettings class rather than Settings for the
8998 settings that moved. This is sub-optimal since the settings aren't really
8999 per-view, but we can't really change the API at this point.
9001 * WebView/WebView.mm:
9002 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9003 (-[WebView _preferencesChangedNotification:]):
9005 2010-08-11 Gavin Barraclough <barraclough@apple.com>
9007 Rubber stamps by Darin Adler & Sam Weinig.
9009 Bug 43867 - Some UString cleanup
9011 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
9012 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
9014 * WebView/WebScriptDebugger.mm:
9017 2010-08-10 David Hyatt <hyatt@apple.com>
9019 Reviewed by Dan Bernstein.
9021 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
9023 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
9026 * WebView/WebHTMLView.mm:
9027 (-[WebHTMLView _web_setPrintingModeRecursive]):
9028 (-[WebHTMLView _web_clearPrintingModeRecursive]):
9029 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
9030 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
9031 (-[WebHTMLView _endPrintMode]):
9032 (-[WebHTMLView _isInScreenPaginationMode]):
9033 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
9034 (-[WebHTMLView _endScreenPaginationMode]):
9035 (-[WebHTMLView reapplyStyles]):
9036 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
9037 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
9038 (-[WebHTMLView setPageWidthForPrinting:]):
9039 * WebView/WebHTMLViewPrivate.h:
9041 2010-08-10 Gavin Barraclough <barraclough@apple.com>
9043 Build fix (update more includes)
9045 * Plugins/Hosted/NetscapePluginHostManager.h:
9047 2010-08-10 Chris Marrin <cmarrin@apple.com>
9049 Reviewed by Oliver Hunt.
9051 Add suspendAnimations/resumeAnimation API to DRT
9052 https://bugs.webkit.org/show_bug.cgi?id=43733
9054 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
9056 * WebView/WebFrame.mm:
9057 (-[WebFrame _suspendAnimations]):
9058 (-[WebFrame _resumeAnimations]):
9059 * WebView/WebFramePrivate.h:
9061 2010-08-10 Gavin Barraclough <barraclough@apple.com>
9063 Rubber stamped by Sam Weinig
9065 Bug 43817 - Remove UString::Rep
9066 UString::Rep has for a long time been replaced by UStringImpl (Rep
9067 remaining as a typedef). UStringImpl has since been removed too
9068 (unified with StringImpl). Remove Rep, rename rep() to impl() and
9069 m_rep to m_impl. Also add impl() method to Identifier, and rename
9070 its UString member from _ustring to m_string.
9072 * Plugins/Hosted/ProxyInstance.mm:
9073 (WebKit::ProxyInstance::methodsNamed):
9074 (WebKit::ProxyInstance::fieldNamed):
9076 2010-08-06 Gavin Barraclough <barraclough@apple.com>
9078 Rubber stamped by Sam Weinig
9080 Bug 43594 - Add string forwards to Forward.h
9081 This allows us to remove forward declarations for these classes from
9082 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
9084 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
9085 * Plugins/WebBaseNetscapePluginView.h:
9086 * WebCoreSupport/WebFrameLoaderClient.h:
9087 * WebCoreSupport/WebIconDatabaseClient.h:
9088 * WebCoreSupport/WebPluginHalterClient.h:
9089 * WebView/WebViewInternal.h:
9091 2010-08-04 MORITA Hajime <morrita@google.com>
9093 Reviewed by Tony Chang.
9095 Pasting should fire textInput event.
9096 https://bugs.webkit.org/show_bug.cgi?id=42958
9098 On paste, invoke Editor instead of direct command invocation,
9099 which allows dispatching events before actual paste.
9101 * WebView/WebHTMLView.mm:
9102 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
9104 2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
9106 Reviewed by Eric Seidel.
9108 add "const" to WebChromeClient::webView().
9109 https://bugs.webkit.org/show_bug.cgi?id=43631
9111 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
9112 is const method now, and calling webView() inside port-specific didReceiveViewportArguments
9113 implementation fails compiling if webView() is not const.
9115 * WebCoreSupport/WebChromeClient.h:
9116 (WebChromeClient::webView):
9118 2010-08-06 Jessie Berlin <jberlin@apple.com>
9120 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
9123 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
9124 * Plugins/WebBaseNetscapePluginView.h:
9125 * WebCoreSupport/WebFrameLoaderClient.h:
9126 * WebCoreSupport/WebIconDatabaseClient.h:
9127 * WebCoreSupport/WebPluginHalterClient.h:
9128 * WebView/WebViewInternal.h:
9130 2010-08-05 Joseph Pecoraro <joepeck@webkit.org>
9132 Reviewed by David Kilzer.
9134 Remove Invalid Asserts for Application Cache Quotas
9135 https://bugs.webkit.org/show_bug.cgi?id=43585
9137 Removed Invalid ASSERTs that would always happen for quotas
9138 that were not noQuota().
9140 * WebView/WebPreferences.mm:
9141 (-[WebPreferences applicationCacheTotalQuota]):
9142 (-[WebPreferences applicationCacheDefaultOriginQuota]):
9144 2010-08-05 Gavin Barraclough <barraclough@apple.com>
9146 Rubber stamped by Sam Weinig
9148 Bug 43594 - Add string forwards to Forward.h
9149 This allows us to remove forward declarations for these classes from
9150 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
9152 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
9153 * Plugins/WebBaseNetscapePluginView.h:
9154 * WebCoreSupport/WebFrameLoaderClient.h:
9155 * WebCoreSupport/WebIconDatabaseClient.h:
9156 * WebCoreSupport/WebPluginHalterClient.h:
9157 * WebView/WebViewInternal.h:
9159 2010-08-05 Jian Li <jianli@chromium.org>
9161 Reviewed by David Levin.
9163 Unify blob related feature defines to ENABLE(BLOB).
9164 https://bugs.webkit.org/show_bug.cgi?id=43081
9166 * Configurations/FeatureDefines.xcconfig:
9168 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
9170 Reviewed by David Kilzer.
9172 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
9173 https://bugs.webkit.org/show_bug.cgi?id=40627
9175 Part 6 - LayoutTest and Cleanup
9177 * WebCoreSupport/WebApplicationCache.h:
9178 * WebCoreSupport/WebApplicationCache.mm:
9179 (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches.
9180 (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.
9182 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
9184 Reviewed by David Kilzer.
9186 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
9187 https://bugs.webkit.org/show_bug.cgi?id=40627
9189 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
9191 Per-Origin quotas exist for Databases and Application Caches. Clients
9192 given a WebSecurityOrigin have the ability to set the quota for any
9193 per-origin quota type. This puts quota management into an interface
9194 and WebSecurityOrigin allows access to quota managers for the
9195 different types of quotas.
9197 This also deprecates the old methods on WebSecurityOrigin. They are
9198 left in for now to prevent breaking older clients.
9200 The WebQuotaManager interface allows querying and modifying a
9201 per-origin quota. This is implemented for both Databases and
9204 * Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
9205 * Storage/WebDatabaseQuotaManager.h: Added.
9206 * Storage/WebDatabaseQuotaManager.mm: Added.
9207 (-[WebDatabaseQuotaManager origin]):
9208 (-[WebDatabaseQuotaManager usage]):
9209 (-[WebDatabaseQuotaManager quota]):
9210 (-[WebDatabaseQuotaManager setQuota:]):
9211 * Storage/WebDatabaseSecurityOrigin.h: Removed.
9212 * Storage/WebDatabaseSecurityOrigin.mm: Removed.
9213 * WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
9214 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added.
9215 (-[WebApplicationCacheQuotaManager origin]):
9216 (-[WebApplicationCacheQuotaManager usage]):
9217 (-[WebApplicationCacheQuotaManager quota]):
9218 (-[WebApplicationCacheQuotaManager setQuota:]):
9219 * WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.
9221 Remove the WebSecurityOrigin sub-classes. Managers are better.
9223 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
9224 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.
9226 Create the managers lazily. Change old style calls to make use
9229 * WebCoreSupport/WebChromeClient.mm:
9230 (WebChromeClient::exceededDatabaseQuota):
9231 (WebChromeClient::reachedApplicationCacheOriginQuota):
9232 * WebCoreSupport/WebSecurityOrigin.mm:
9233 (-[WebSecurityOrigin applicationCacheQuotaManager]):
9234 (-[WebSecurityOrigin databaseQuotaManager]):
9235 (-[WebSecurityOrigin dealloc]): release the managers if they exist.
9237 2010-08-03 Alex Milowski <alex@milowski.com>
9239 Reviewed by Beth Dakin.
9241 Changed the ENABLE_MATHML value to enable MathML by default.
9243 * Configurations/FeatureDefines.xcconfig:
9245 2010-08-02 Brady Eidson <beidson@apple.com>
9247 Reviewed by Anders Carlsson.
9249 Add VisitedLinkStrategy for each platform to implement
9250 https://bugs.webkit.org/show_bug.cgi?id=43393
9252 * WebCoreSupport/WebPlatformStrategies.h:
9253 * WebCoreSupport/WebPlatformStrategies.mm:
9254 (WebPlatformStrategies::createVisitedLinkStrategy):
9255 (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links.
9256 (WebPlatformStrategies::addVisitedLink): Ditto.
9258 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
9260 Reviewed by Darin Fisher.
9262 PopupMenu refactoring in preparation to WebKit2
9263 https://bugs.webkit.org/show_bug.cgi?id=42592
9265 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
9266 instances, concrete classes that inherit from ChromeClient needed to be changed to
9267 implement the new methods.
9269 * WebCoreSupport/WebChromeClient.h:
9270 * WebCoreSupport/WebChromeClient.mm:
9271 (WebChromeClient::selectItemWritingDirectionIsNatural):
9272 (WebChromeClient::createPopupMenu):
9273 (WebChromeClient::createSearchPopupMenu):
9275 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
9277 Speculative revert of 64425 due to Chromium instability
9278 https://bugs.webkit.org/show_bug.cgi?id=43347
9280 * WebCoreSupport/WebChromeClient.h:
9281 * WebCoreSupport/WebChromeClient.mm:
9283 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
9285 Reviewed by Darin Fisher.
9287 PopupMenu refactoring in preparation to WebKit2
9288 https://bugs.webkit.org/show_bug.cgi?id=42592
9290 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
9291 instances, concrete classes that inherit from ChromeClient needed to be changed to
9292 implement the new methods.
9294 * WebCoreSupport/WebChromeClient.h:
9295 * WebCoreSupport/WebChromeClient.mm:
9296 (WebChromeClient::selectItemWritingDirectionIsNatural):
9297 (WebChromeClient::createPopupMenu):
9298 (WebChromeClient::createSearchPopupMenu):
9300 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
9302 Unreviewed, rolling out r64422.
9303 http://trac.webkit.org/changeset/64422
9304 https://bugs.webkit.org/show_bug.cgi?id=43304
9306 Build fixes are needed for Snow Leopard and Windows.
9307 (Requested by lca on #webkit).
9309 * WebCoreSupport/WebChromeClient.h:
9310 * WebCoreSupport/WebChromeClient.mm:
9312 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
9314 Reviewed by Darin Fisher.
9316 PopupMenu refactoring in preparation to WebKit2
9317 https://bugs.webkit.org/show_bug.cgi?id=42592
9319 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
9320 instances, concrete classes that inherit from ChromeClient needed to be changed to
9321 implement the new methods.
9323 * WebCoreSupport/WebChromeClient.h:
9324 * WebCoreSupport/WebChromeClient.mm:
9325 (WebChromeClient::selectItemWritingDirectionIsNatural):
9326 (WebChromeClient::createPopupMenu):
9327 (WebChromeClient::createSearchPopupMenu):
9329 2010-07-31 David Kilzer <ddkilzer@apple.com>
9331 <http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
9333 Reviewed by Darin Adler.
9335 * Configurations/WebKit.xcconfig: Extracted
9336 PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables.
9338 2010-07-30 Dan Bernstein <mitz@apple.com>
9340 Reviewed by Darin Adler.
9342 <rdar://problem/8257783> Short documents may print a second blank page
9343 https://bugs.webkit.org/show_bug.cgi?id=43271
9345 * WebView/WebHTMLView.mm:
9346 (-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter
9347 to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
9348 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
9349 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
9350 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter,
9351 which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
9352 (-[WebHTMLView _endPrintMode]): Updated for additional height parameter to
9353 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
9354 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added
9355 height parameter, which is passed on to FrameView::forceLayoutForPagination().
9356 (-[WebHTMLView layout]): Updated for additional height parameter.
9357 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height
9358 parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:.
9359 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height
9361 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
9362 (-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to
9363 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize.
9364 * WebView/WebHTMLViewPrivate.h:
9366 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
9368 Fix for tests that broke after r64400. Tracking a more
9369 ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627
9371 Switch the interface back to (unsigned long long), and move
9372 the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin.
9373 The subclasses' implementations were not getting called.
9375 * Storage/WebDatabaseSecurityOrigin.mm:
9376 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:
9377 (-[WebApplicationCacheSecurityOrigin quota]):
9378 (-[WebApplicationCacheSecurityOrigin setQuota:]):
9379 * WebCoreSupport/WebSecurityOrigin.mm:
9380 (-[WebSecurityOrigin usage]):
9381 (-[WebSecurityOrigin quota]):
9382 (-[WebSecurityOrigin setQuota:]):
9383 * WebCoreSupport/WebSecurityOriginPrivate.h:
9385 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
9387 Reviewed by David Kilzer.
9389 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
9390 https://bugs.webkit.org/show_bug.cgi?id=40627
9392 Part 4 - Client Notification when the Quota is Reached
9394 Notify the WebKit client when the per-origin quota is reached
9395 via a delegate method reachedApplicationCacheOriginQuota.
9397 Refactor the WebSecurityOrigin class to be generic enough to
9398 allow quota management of both Databases or Application Caches
9401 * Storage/WebDatabaseSecurityOrigin.h: Added.
9402 * Storage/WebDatabaseSecurityOrigin.mm: Added.
9403 (-[WebDatabaseSecurityOrigin quota]):
9404 (-[WebDatabaseSecurityOrigin setQuota:]):
9405 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
9406 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added.
9407 (-[WebApplicationCacheSecurityOrigin quota]):
9408 (-[WebApplicationCacheSecurityOrigin setQuota:]):
9409 * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
9410 * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
9411 * WebCoreSupport/WebSecurityOrigin.mm: Added.
9412 (-[WebSecurityOrigin usage]): to be implemented by subclasses.
9413 (-[WebSecurityOrigin quota]): to be implemented by subclasses.
9414 (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
9415 * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
9416 * WebCoreSupport/WebSecurityOriginPrivate.h: Added.
9418 Turn the notification into a WebUI Delegate to call. Following
9419 the example of Databases.
9421 * DefaultDelegates/WebDefaultUIDelegate.m:
9422 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
9423 * WebCoreSupport/WebChromeClient.h:
9424 * WebCoreSupport/WebChromeClient.mm:
9425 (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass.
9426 (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
9427 * WebView/WebUIDelegatePrivate.h:
9429 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
9431 Reviewed by David Kilzer.
9433 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
9434 https://bugs.webkit.org/show_bug.cgi?id=40627
9436 Part 1 - Add Total and Per-Origin Quota Preferences.
9438 Allow the application cache total size to be a preference, and
9439 add a new preference for the default per-origin quota.
9441 Storage quotas were int64_t (long long). Boilerplate for
9442 these types added for consistency.
9444 * Misc/WebNSDictionaryExtras.h:
9445 * Misc/WebNSDictionaryExtras.m:
9446 (-[NSMutableDictionary _webkit_setLongLong:forKey:]):
9447 * WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage.
9448 * WebCoreSupport/WebApplicationCache.mm:
9449 (+[WebApplicationCache maximumSize:]):
9450 (+[WebApplicationCache setMaximumSize:]):
9451 (+[WebApplicationCache defaultOriginQuota]):
9452 (+[WebApplicationCache setDefaultOriginQuota:]):
9453 * WebView/WebPreferenceKeysPrivate.h:
9454 * WebView/WebPreferences.mm:
9455 (+[WebPreferences initialize]): defaults to noQuota for both preferences.
9456 (-[WebPreferences _longLongValueForKey:]):
9457 (-[WebPreferences _setLongLongValue:forKey:]):
9458 (-[WebPreferences applicationCacheTotalQuota]):
9459 (-[WebPreferences setApplicationCacheTotalQuota:]):
9460 (-[WebPreferences applicationCacheDefaultOriginQuota]):
9461 (-[WebPreferences setApplicationCacheDefaultOriginQuota:]):
9462 * WebView/WebPreferencesPrivate.h:
9463 * WebView/WebView.mm:
9464 (-[WebView _preferencesChangedNotification:]): respect updates to the preferences.
9466 2010-07-30 Andy Estes <aestes@apple.com>
9468 Reviewed by David Kilzer.
9470 Add Xcode support for compiling WebKit against iOS SDKs.
9471 https://bugs.webkit.org/show_bug.cgi?id=42796
9473 * Configurations/Base.xcconfig:
9474 * Configurations/DebugRelease.xcconfig:
9475 * Configurations/FeatureDefines.xcconfig:
9476 * Configurations/Version.xcconfig:
9477 * Configurations/WebKit.xcconfig:
9479 2010-07-26 Steve Block <steveblock@google.com>
9481 Reviewed by Jeremy Orlow.
9483 Page clients should be passed to Page constructor via structure of pointers
9484 https://bugs.webkit.org/show_bug.cgi?id=42834
9486 * WebView/WebView.mm:
9487 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9489 2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
9491 Reviewed by Ojan Vafai.
9493 Add FILE_SYSTEM build flag for FileSystem API
9494 https://bugs.webkit.org/show_bug.cgi?id=42915
9496 * Configurations/FeatureDefines.xcconfig:
9498 2010-07-27 Steve Block <steveblock@google.com>
9500 Reviewed by Jeremy Orlow.
9502 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
9503 https://bugs.webkit.org/show_bug.cgi?id=40374
9505 Stub out setEnableHighAccuracy method for the Mac port.
9507 * WebCoreSupport/WebGeolocationControllerClient.h:
9508 (WebGeolocationControllerClient::setEnableHighAccuracy):
9510 2010-07-22 Sam Weinig <sam@webkit.org>
9512 Reviewed by Maciej Stachowiak.
9514 Fix for <rdar://problem/8222626>
9515 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
9517 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
9518 should migrate to a new function name eventually
9520 * WebCoreSupport/WebEditorClient.mm:
9521 (WebEditorClient::textDidChangeInTextField):
9523 2010-07-22 Sam Weinig <sam@webkit.org>
9525 Reviewed by Anders Carlsson.
9527 Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
9528 Add localized strings stubs for WebKit2.
9530 - Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
9531 for localized strings.
9533 Gets us below 200 tests failing in WebKitTestRunner.
9535 * WebCoreSupport/WebContextMenuClient.mm:
9536 (fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
9537 * WebCoreSupport/WebPlatformStrategies.h:
9538 * WebCoreSupport/WebPlatformStrategies.mm:
9539 * WebCoreSupport/WebViewFactory.mm:
9541 2010-07-21 Brady Eidson <beidson@apple.com>
9543 Reviewed by Geoffrey Garen.
9545 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
9546 https://bugs.webkit.org/show_bug.cgi?id=42783
9548 * WebView/WebView.mm:
9549 (+[WebView _registerURLSchemeAsSecure:]):
9550 (+[WebView registerURLSchemeAsLocal:]):
9552 2010-07-21 Simon Fraser <simon.fraser@apple.com>
9554 Reviewed by Anders Carlsson.
9556 Composited layers don't scroll in WebKit2
9557 https://bugs.webkit.org/show_bug.cgi?id=42771
9559 Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
9560 but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
9561 scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
9563 * WebView/WebHTMLView.mm:
9564 (-[WebHTMLView _frameOrBoundsChanged]):
9566 2010-07-21 Eric Carlson <eric.carlson@apple.com>
9568 Reviewed by Simon Fraser.
9570 Update plug-in proxy backed <video> and <audio> elements.
9571 https://bugs.webkit.org/show_bug.cgi?id=42770
9572 <rdar://problem/7963467>
9574 * Plugins/WebPluginController.h:
9575 * Plugins/WebPluginController.mm:
9576 (-[WebPluginController dealloc]): Release _viewsNotInDocument.
9577 (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document.
9578 (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument.
9579 (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews.
9580 (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
9582 * WebCoreSupport/WebFrameLoaderClient.h:
9583 * WebCoreSupport/WebFrameLoaderClient.mm:
9584 (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media
9585 player proxy plug-in should never be allocated by this method.
9586 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
9588 * WebView/WebView.mm:
9589 (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't
9590 consider the arePlugInsEnabled preference.
9591 * WebView/WebViewInternal.h:
9594 2010-07-19 Chris Marrin <cmarrin@apple.com>
9596 Reviewed by Darin Adler.
9598 https://bugs.webkit.org/show_bug.cgi?id=42118
9599 Disable WebGL on Leopard for now.
9601 LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
9602 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
9603 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
9604 software OpenGL driver on machines without this support.
9606 * Configurations/FeatureDefines.xcconfig:
9608 2010-07-18 Anders Carlsson <andersca@apple.com>
9610 Reviewed by Sam Weinig.
9612 Move PluginWidget to WebKit
9613 https://bugs.webkit.org/show_bug.cgi?id=42530
9615 * Plugins/WebBaseNetscapePluginView.h:
9616 * Plugins/WebBaseNetscapePluginView.mm:
9617 (-[WebBaseNetscapePluginView pluginLayer]):
9618 Add default pluginLayer implementation.
9620 * WebCoreSupport/WebFrameLoaderClient.mm:
9621 (PluginWidget::PluginWidget):
9622 (PluginWidget::invalidateRect):
9623 Move the guts of PluginWidget here from WebCore.
9625 (NetscapePluginWidget::platformLayer):
9626 Get the layer from the plug-in view.
9628 2010-07-18 David Kilzer <ddkilzer@apple.com>
9630 <http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
9632 Reviewed by Dan Bernstein.
9634 * Carbon/CarbonWindowAdapter.mm:
9635 (-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
9636 (-[CarbonWindowAdapter _destroyRealWindow:]):
9637 (-[CarbonWindowAdapter _clearModalWindowLevel]):
9638 * Misc/WebIconDatabase.mm:
9639 (-[WebIconDatabase init]):
9640 * Misc/WebNSPasteboardExtras.mm:
9641 (-[NSFilePromiseDragSource initWithSource:]):
9642 * WebView/WebHTMLRepresentation.mm:
9643 (-[WebHTMLRepresentation init]):
9644 * WebView/WebPreferences.mm:
9645 (-[WebPreferences init]):
9646 * WebView/WebView.mm:
9647 (-[WebView UIDelegate]):
9648 (-[WebView resourceLoadDelegate]):
9649 (-[WebView downloadDelegate]):
9650 (-[WebView policyDelegate]):
9651 (-[WebView frameLoadDelegate]):
9653 2010-07-16 Zhe Su <suzhe@chromium.org>
9655 Reviewed by Darin Adler.
9657 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
9658 https://bugs.webkit.org/show_bug.cgi?id=42253
9660 Dummy implementation of EditorClient::willSetInputMethodState.
9662 * WebCoreSupport/WebEditorClient.h:
9663 * WebCoreSupport/WebEditorClient.mm:
9664 (WebEditorClient::willSetInputMethodState):
9666 2010-07-16 Dan Bernstein <mitz@apple.com>
9668 Reviewed by Sam Weinig.
9670 Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
9671 https://bugs.webkit.org/show_bug.cgi?id=29355
9673 * Misc/WebKitNSStringExtras.h:
9674 * Misc/WebKitNSStringExtras.mm:
9675 (-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
9676 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
9678 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
9679 allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
9680 mode to antialiased. Otherwise, sets it to auto.
9681 (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
9682 changing the font smoothing setting in the graphics context, call
9683 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
9686 2010-07-16 Anders Carlsson <andersca@apple.com>
9688 Reviewed by Sam Weinig.
9690 Remove semicolons from Objective-C method declarations.
9692 * WebView/WebRenderLayer.mm:
9693 (+[WebRenderLayer nameForLayer:]):
9694 (+[WebRenderLayer compositingInfoForLayer:]):
9696 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
9698 Reviewed by Pavel Feldman.
9700 Make JS memory stats available via 'Performance' object (Web Timing).
9701 This statistics is populated only if 'WebKitMemoryInfoEnabled'
9704 'console.memory' is kept until Web Timing object becomes visible by
9705 default (currently it is hidden under compile-time flag). These stats
9706 are guarded with the same preference.
9708 https://bugs.webkit.org/show_bug.cgi?id=41617
9711 * WebView/WebPreferenceKeysPrivate.h:
9712 * WebView/WebPreferences.mm:
9713 (+[WebPreferences initialize]):
9714 (-[WebPreferences memoryInfoEnabled]):
9715 (-[WebPreferences setMemoryInfoEnabled:]):
9716 * WebView/WebPreferencesPrivate.h:
9717 * WebView/WebView.mm:
9718 (-[WebView _preferencesChangedNotification:]):
9720 2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
9722 Reviewed by Darin Adler.
9724 Printing test results differ between machines, we should use ImageDiff instead
9725 https://bugs.webkit.org/show_bug.cgi?id=20011
9727 * Misc/WebCoreStatistics.h:
9728 * Misc/WebCoreStatistics.mm:
9729 (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):
9731 2010-07-15 Daniel Bates <dbates@rim.com>
9733 Reviewed by Darin Adler.
9735 [Mac] Implement LayoutTestController::markerTextForListItem()
9736 https://bugs.webkit.org/show_bug.cgi?id=37929
9738 Implements support for markerTextForListItem in the Mac port.
9740 * DOM/WebDOMOperations.mm:
9741 (+[DOMElement _DOMElementFromJSContext]): Added.
9742 (-[DOMElement _markerTextForListItem]): Added.
9743 * DOM/WebDOMOperationsPrivate.h:
9745 2010-07-14 Simon Fraser <simon.fraser@apple.com>
9747 Fix non-ACCELERATED_COMPOSITING build.
9749 * WebView/WebRenderLayer.mm:
9750 (+[WebRenderLayer compositingInfoForLayer:]):
9752 2010-07-14 Simon Fraser <simon.fraser@apple.com>
9754 Reviewed by John Sullivan.
9756 <rdar://problem/8186963> Expose information about compositing layers.
9758 Use RenderLayerBacking::compositingLayerType() to add more information about compositing to
9759 WebRenderLayer, via a compositingInfo property. Also show element classnames.
9761 Also add separator items between the various z-order lists.
9763 * WebView/WebRenderLayer.h:
9764 * WebView/WebRenderLayer.mm:
9765 (+[WebRenderLayer nameForLayer:]):
9766 (+[WebRenderLayer compositingInfoForLayer:]):
9767 (-[WebRenderLayer initWithRenderLayer:]):
9768 (-[WebRenderLayer initWithName:]):
9769 (-[WebRenderLayer initWithWebFrame:]):
9770 (-[WebRenderLayer dealloc]):
9771 (-[WebRenderLayer buildDescendantLayers:]):
9772 (-[WebRenderLayer compositingInfo]):
9773 (-[WebRenderLayer isComposited]):
9774 (-[WebRenderLayer isSeparator]):
9776 2010-07-14 Darin Adler <darin@apple.com>
9778 Another try at fixing the Tiger build.
9780 Avoid non-ASCII in source files to keep Tiger compiler happy.
9782 * WebView/WebRenderLayer.mm:
9783 (+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters.
9785 2010-07-14 Sam Weinig <sam@webkit.org>
9787 Reviewed by Darin Adler.
9789 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
9790 Make changing Cursors work in WebKit2.
9792 * WebCoreSupport/WebChromeClient.h:
9793 * WebCoreSupport/WebChromeClient.mm:
9794 (WebChromeClient::setCursor):
9795 * WebView/WebView.mm:
9796 Implement cursor changing at the WebKit level for the sake of WebKit2.
9797 This functionality is being moved from WidgetMac.mm.
9798 (+[WebView _pointingHandCursor]):
9799 Update to use platformCursor() instead of impl().
9801 2010-07-13 Simon Fraser <simon.fraser@apple.com>
9805 Avoid non-ASCII in souce files to keep Tiger compiler happy.
9807 * WebView/WebRenderLayer.mm:
9808 (+[WebRenderLayer nameForLayer:]):
9810 2010-07-13 Simon Fraser <simon.fraser@apple.com>
9812 Reviewed by Dan Bernstein.
9814 <rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging.
9816 Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy
9817 of Objective-C objects suitable for display in an outline view.
9819 * WebKit.exp: Export the WebRenderLayer Objective-C class.
9820 * WebView/WebRenderLayer.h: Added.
9821 * WebView/WebRenderLayer.mm: Added.
9823 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
9825 Reviewed by Darin Adler.
9827 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
9829 https://bugs.webkit.org/show_bug.cgi?id=30879
9831 MainResourceLoader uses the member m_initialRequest to store requests for future
9832 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
9833 have to clear this request so that subsequent entries into the loader will not
9834 start yet another load.
9836 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
9837 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
9838 but only in the case of using both substitute-data and non-deferred main resource
9839 load together. That's why two new DRT functions were added:
9841 * queueLoadHTMLString()
9842 * setDeferMainResourceLoad()
9844 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
9845 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
9846 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
9848 * WebView/WebDataSource.mm:
9849 (-[WebDataSource _setDeferMainResourceDataLoad:]):
9850 * WebView/WebDataSourcePrivate.h:
9852 2010-07-13 Philippe Normand <pnormand@igalia.com>
9854 Rubber-stamped by Xan Lopez.
9856 Updated the copyright headers of the files modified in r62476.
9858 * WebView/WebView.mm:
9859 * WebView/WebViewData.h:
9860 * WebView/WebViewInternal.h:
9862 2010-07-09 Alexey Proskuryakov <ap@apple.com>
9864 Reviewed by Darin Adler.
9866 https://bugs.webkit.org/show_bug.cgi?id=13075
9867 XMLHttpRequest with failed authentication should set status to 401
9869 https://bugs.webkit.org/show_bug.cgi?id=6871
9870 <rdar://problem/3363403> 401 error page is never shown
9872 * Panels/WebPanelAuthenticationHandler.m:
9873 (-[WebPanelAuthenticationHandler startAuthentication:window:]): Updated a comment - this
9874 code cancels loading, not authentication (canceling authentication means telling to
9875 continue without credentials).
9876 (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): If there were
9877 no credentials provided, tell to continue without any. There may be alternative content
9880 2010-07-09 Leon Clarke <leonclarke@google.com>
9882 Reviewed by Adam Barth.
9884 add support for link prefetching
9885 https://bugs.webkit.org/show_bug.cgi?id=3652
9887 * Configurations/FeatureDefines.xcconfig:
9889 2010-07-08 Aaron Boodman <aa@chromium.org>
9891 Reviewed by Timothy Hatcher.
9893 Add the ability for user scripts and user styles to affect just the top frame.
9895 https://bugs.webkit.org/show_bug.cgi?id=41529
9897 * WebView/WebView.mm:
9898 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
9899 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
9900 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
9901 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
9902 * WebView/WebViewPrivate.h:
9904 2010-07-08 Adele Peterson <adele@apple.com>
9906 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
9908 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
9909 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
9911 Implement shouldMissingPluginMessageBeButton.
9913 * WebCoreSupport/WebChromeClient.h:
9914 * WebCoreSupport/WebChromeClient.mm:
9915 (WebChromeClient::shouldMissingPluginMessageBeButton):
9917 2010-07-08 Brady Eidson <beidson@apple.com>
9919 Reviewed by Tim Hatcher.
9921 <rdar://problem/8136327> - Crash in Entourage calling WebCache method from background thread
9924 (+[WebCache setDisabled:]): Forward the call to the main thread if called from a background thread.
9926 * Misc/WebNSObjectExtras.h:
9927 * Misc/WebNSObjectExtras.mm:
9928 (+[NSObject _webkit_invokeOnMainThread]): Add a class version of the main thread invoker.
9930 2010-07-08 Mike Thole <mthole@apple.com>
9932 Reviewed by Darin Adler.
9934 Patch for https://bugs.webkit.org/show_bug.cgi?id=41896
9935 Crash under allScriptsInPDFDocument() in WebPDFDocumentExtras.mm for certain PDFs
9937 * WebView/WebPDFDocumentExtras.mm:
9938 (allScriptsInPDFDocument): Null-check 'data', as CGPDFStreamCopyData() may have returned 0.
9940 2010-07-08 Sam Weinig <sam@webkit.org>
9942 Reviewed by Anders Carlsson.
9944 Patch for https://bugs.webkit.org/show_bug.cgi?id=41826
9945 Convert BackForwardList to an abstract base class and add BackForwardListImpl
9946 as the concrete implementation of it.
9948 * History/WebBackForwardList.mm:
9949 (-[WebBackForwardList init]):
9950 (-[WebBackForwardList setPageCacheSize:]):
9951 (-[WebBackForwardList pageCacheSize]):
9953 2010-07-07 Sam Weinig <sam@webkit.org>
9955 Reviewed by Anders Carlsson.
9957 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
9958 Add basic piping for BackForwardControllerClient.
9960 * WebView/WebView.mm:
9961 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9963 2010-07-07 Anders Carlsson <andersca@apple.com>
9965 Reviewed by Sam Weinig.
9967 Change requestURL to a KURL.
9968 https://bugs.webkit.org/show_bug.cgi?id=41775
9970 * Plugins/WebNetscapePluginStream.h:
9971 (WebNetscapePluginStream::setRequestURL):
9972 * Plugins/WebNetscapePluginStream.mm:
9973 (WebNetscapePluginStream::pluginCancelledConnectionError):
9974 (WebNetscapePluginStream::errorForReason):
9975 (WebNetscapePluginStream::startStream):
9976 (WebNetscapePluginStream::didReceiveResponse):
9977 (WebNetscapePluginStream::destroyStream):
9979 2010-07-07 Anders Carlsson <andersca@apple.com>
9981 Reviewed by Sam Weinig.
9983 Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name.
9985 * Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h.
9986 * Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm.
9988 2010-07-06 Steve Falkenburg <sfalken@apple.com>
9990 Reviewed by Simon Fraser.
9992 Expose URL matching from WebUserContentURLPattern
9993 https://bugs.webkit.org/show_bug.cgi?id=41726
9994 <rdar://problem/7910144>
9996 We previously had a way to construct WebUserContentURLPattern
9997 instances via WebKit, but no way for callers to perform matching.
9998 This patch adds the matchesURL functionality to allow for this.
10000 * Misc/WebUserContentURLPattern.h: Added matchesURL.
10001 * Misc/WebUserContentURLPattern.mm:
10002 (-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches.
10004 2010-06-23 Philippe Normand <pnormand@igalia.com>
10006 Reviewed by Eric Carlson.
10008 [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
10009 https://bugs.webkit.org/show_bug.cgi?id=35747
10011 If VIDEO and GSTREAMER are enabled, make the WebView start a
10012 runloop observer that will trigger the glib main context
10013 iterations. Those are needed by the GStreamer player only at the
10014 moment but could later be used for other GLib-dependant components
10017 * WebView/WebView.mm:
10018 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10019 (-[WebView _close]):
10020 (-[WebView _clearGlibLoopObserver]):
10021 (glibContextIterationCallback):
10022 (-[WebView _scheduleGlibContextIterations]):
10023 * WebView/WebViewData.h:
10024 * WebView/WebViewInternal.h:
10026 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
10028 The missing plug-in indicator should be clickable
10030 https://bugs.webkit.org/show_bug.cgi?id=41550
10031 <rdar://problem/8132162>
10033 From an original patch by Kevin Decker.
10035 Reviewed by Darin Adler.
10037 * WebCoreSupport/WebChromeClient.h:
10038 Declare an override of missingPluginButtonClicked().
10040 * WebCoreSupport/WebChromeClient.mm:
10041 (WebChromeClient::missingPluginButtonClicked):
10042 Call the UIDelegate's method.
10044 * WebView/WebUIDelegatePrivate.h:
10045 Declare didPressMissingPluginButton.
10047 2010-07-01 Timothy Hatcher <timothy@apple.com>
10049 Provide a WebView preference to disable DNS prefetching.
10051 https://bugs.webkit.org/show_bug.cgi?id=28825
10052 rdar://problem/7181249
10054 Reviewed by Darin Adler.
10056 * WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
10057 * WebView/WebPreferences.mm:
10058 (+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
10059 (-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
10060 (-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.
10061 * WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
10062 * WebView/WebView.mm:
10063 (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.
10065 2010-07-01 Alexey Proskuryakov <ap@apple.com>
10067 Reviewed by Anders Carlsson.
10069 <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
10070 REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction
10072 Strengthen m_inDestroy "swipe under the carpet" fix.
10074 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and
10075 changed it to static.
10077 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10078 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now
10079 static, so we don't initialize it in constructor.
10080 (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying
10082 (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an
10083 m_inDestroy check in r42789.
10085 2010-06-29 Zoltan Herczeg <zherczeg@webkit.org>
10087 Reviewed by Nikolas Zimmermann.
10089 Add ConvolveMatrixElement to MigrateHeaders.make
10090 https://bugs.webkit.org/show_bug.cgi?id=5861
10092 * MigrateHeaders.make:
10094 2010-06-23 John Gregg <johnnyg@google.com>
10096 Reviewed by Kent Tamura.
10098 add ENABLE_DIRECTORY_UPLOAD build support
10099 https://bugs.webkit.org/show_bug.cgi?id=41100
10101 * Configurations/FeatureDefines.xcconfig:
10103 2010-06-28 Eric Seidel <eric@webkit.org>
10105 Reviewed by Adam Barth.
10107 Make it possible to test the new HTML5 TreeBuilder
10108 https://bugs.webkit.org/show_bug.cgi?id=41276
10110 Adam was concerned that someone might make their port
10111 depend on this setting (I guess we had some trouble with that
10112 with the HTML5Parser setting), so I littered the code with warnings.
10114 test-html5-parser now tests this code path.
10116 * WebView/WebPreferenceKeysPrivate.h:
10117 * WebView/WebPreferences.mm:
10118 (+[WebPreferences initialize]):
10119 (-[WebPreferences html5TreeBuilderEnabled]):
10120 (-[WebPreferences setHTML5TreeBuilderEnabled:]):
10121 * WebView/WebPreferencesPrivate.h:
10122 * WebView/WebView.mm:
10123 (-[WebView _preferencesChangedNotification:]):
10125 2010-06-25 Yuzo Fujishima <yuzo@google.com>
10127 Reviewed by Shinichiro Hamaji.
10129 Improve default value handling for page format properties.
10130 https://bugs.webkit.org/show_bug.cgi?id=41150
10132 * Misc/WebCoreStatistics.h:
10133 * Misc/WebCoreStatistics.mm:
10134 (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):
10136 2010-06-26 Tony Gentilcore <tonyg@chromium.org>
10138 Reviewed by Dimitri Glazkov.
10140 Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
10141 https://bugs.webkit.org/show_bug.cgi?id=38924
10143 * Configurations/FeatureDefines.xcconfig:
10145 2010-06-24 Jer Noble <jer.noble@apple.com>
10147 Reviewed by Eric Carlson.
10149 Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
10150 https://bugs.webkit.org/show_bug.cgi?id=40939
10151 rdar://problem/7996172
10153 Take a IOKit power assertion when playing video in fullscreen mode. Release the
10154 assertion when paused in fullscreen mode, and when exiting fullscreen mode.
10156 * WebView/WebVideoFullscreenController.h:
10157 * WebView/WebVideoFullscreenController.mm:
10158 (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions.
10159 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions.
10160 (-[WebVideoFullscreenController _disableIdleDisplaySleep]):
10161 (-[WebVideoFullscreenController _enableIdleDisplaySleep]):
10162 (-[WebVideoFullscreenController _disableIdleSystemSleep]):
10163 (-[WebVideoFullscreenController _enableIdleSystemSleep]):
10164 (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status.
10165 (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.
10167 2010-06-24 Jer Noble <jer.noble@apple.com>
10169 Reviewed by Darin Adler.
10171 Playing movie full screen on second monitor hides menu bar and title bar on main monitor
10172 https://bugs.webkit.org/show_bug.cgi?id=40933
10173 rdar://problem/7858452
10175 Remove all references to GetSystemUIMode and SetSystemUIMode. Replace these calls with
10176 [NSApplication setPresentationOptions:]. Do not auto-hide the menu bar if the fullscreen
10177 screen is does not contain the menu-bar. Do not auto-hide the dock if the fullscreen screen
10178 is both not the menu-bar screen and not the dock screen.
10180 * WebView/WebVideoFullscreenController.mm:
10181 (-[WebVideoFullscreenController windowDidLoad]): Register the applicationDidChangeScreenParameters: listener.
10182 (-[WebVideoFullscreenController windowDidExitFullscreen]): Calls updateMenuAndDockForFullscreen.
10183 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Calls updateMenuAndDockForFullscreen.
10184 (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]): New notification handler; catches NSApplicationDidChangeScreenParameters.
10185 (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Hide/show the menu-bar and dock according to the fullscreen window's screen.
10187 2010-06-24 Jer Noble <jer.noble@apple.com>
10189 Reviewed by Eric Carlson.
10191 Full screen video in Safari exits full-screen if you switch to another app
10192 https://bugs.webkit.org/show_bug.cgi?id=40635
10193 rdar://problem/7885101
10195 Implement the following rules for exiting full screen when switching apps:
10196 1. If the system has a single screen, switching apps will cause Safari to exit full-screen.
10197 2. Otherwise, if the full-screen screen is the "main screen" (the one with the title bar),
10198 switching apps will cause Safari to exit full-screen.
10199 3. Overriding rules 1 & 2, if the full-screen screen is not on the "current space",
10200 switching apps will NOT cause Safari to exit full-screen.
10202 * WebView/WebVideoFullscreenController.mm:
10203 (-[WebVideoFullscreenController windowDidLoad]):
10204 (-[WebVideoFullscreenController applicationDidResignActive:]):
10206 2010-06-24 Adele Peterson <adele@apple.com>
10208 Reviewed by Sam Weinig.
10210 Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
10211 https://bugs.webkit.org/show_bug.cgi?id=41085
10213 * WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.
10214 Also remove internal methods that no one is using.
10216 2010-06-24 Damian Kaleta <dkaleta@apple.com>
10218 Reviewed by Sam Weinig.
10220 Added an ObjC wrapper to Node::renderRect(bool&).
10222 * DOM/WebDOMOperations.mm:
10223 (-[DOMNode _renderRect:]):
10224 * DOM/WebDOMOperationsPrivate.h:
10226 2010-06-24 Adele Peterson <adele@apple.com>
10228 Reviewed by Eric Carlson.
10230 Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
10231 https://bugs.webkit.org/show_bug.cgi?id=41085
10233 * WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore
10234 which does everything done here and also fires paste events.
10236 2010-06-23 Yuzo Fujishima <yuzo@google.com>
10238 Reviewed by Shinichiro Hamaji.
10240 Implement page format data programming interface.
10241 Add methods for testing.
10242 https://bugs.webkit.org/show_bug.cgi?id=37538
10244 * Misc/WebCoreStatistics.h:
10245 * Misc/WebCoreStatistics.mm:
10246 (-[WebFrame isPageBoxVisible:]):
10247 (-[WebFrame pageAreaRectInPixels:]):
10248 (-[WebFrame preferredPageSizeInPixels:]):
10250 2010-06-22 Anders Carlsson <andersca@apple.com>
10252 Reviewed by Sam Weinig.
10254 Get rid of more USE_LIBDISPATCH code.
10256 * Plugins/Hosted/NetscapePluginHostProxy.h:
10258 2010-06-22 Anders Carlsson <andersca@apple.com>
10260 Reviewed by Sam Weinig.
10262 Get rid of the USE_LIBDISPATCH code.
10264 * Plugins/Hosted/NetscapePluginHostProxy.mm:
10265 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
10266 (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
10268 2010-06-22 Anders Carlsson <andersca@apple.com>
10270 Reviewed by Sam Weinig.
10272 Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
10273 https://bugs.webkit.org/show_bug.cgi?id=41006
10275 * Plugins/Hosted/NetscapePluginHostManager.h:
10276 * Plugins/Hosted/NetscapePluginHostManager.mm:
10277 (WebKit::NetscapePluginHostManager::hostForPlugin):
10278 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10279 (WebKit::NetscapePluginHostManager::instantiatePlugin):
10280 (WebKit::NetscapePluginHostManager::createPropertyListFile):
10281 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
10282 (-[WebHostedNetscapePluginView createPlugin]):
10283 * Plugins/WebNetscapePluginPackage.mm:
10284 (-[WebNetscapePluginPackage createPropertyListFile]):
10286 2010-06-21 Anders Carlsson <andersca@apple.com>
10288 Reviewed by Sam Weinig.
10290 Fix an off-by-one bug I introduced.
10292 * Plugins/WebNetscapePluginPackage.mm:
10293 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10295 2010-06-21 Nate Chapin <japhet@chromium.org>
10297 Reviewed by Adam Barth.
10299 FrameLoader cleanup: Split high level subframe and plugin
10300 loading functions into a separate class.
10301 https://bugs.webkit.org/show_bug.cgi?id=40453
10303 * WebView/WebFrame.mm:
10304 (-[WebFrame _cacheabilityDictionary]):
10306 2010-06-21 Anders Carlsson <andersca@apple.com>
10308 Another Tiger build fix.
10310 * Plugins/WebNetscapePluginPackage.mm:
10311 (-[WebNetscapePluginPackage _tryLoad]):
10313 2010-06-21 Anders Carlsson <andersca@apple.com>
10315 Reviewed by Sam Weinig.
10317 More WebBasePluginPackage cleanup
10318 https://bugs.webkit.org/show_bug.cgi?id=40944
10320 * Plugins/Hosted/HostedNetscapePluginStream.mm:
10321 (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
10322 * Plugins/Hosted/NetscapePluginHostManager.mm:
10323 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10324 * Plugins/WebBaseNetscapePluginStream.mm:
10325 (WebNetscapePluginStream::pluginCancelledConnectionError):
10326 * Plugins/WebBaseNetscapePluginView.mm:
10327 (WebHaltablePlugin::pluginName):
10328 * Plugins/WebBasePluginPackage.h:
10329 * Plugins/WebBasePluginPackage.mm:
10330 (-[WebBasePluginPackage initWithPath:]):
10331 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
10332 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10333 (-[WebBasePluginPackage load]):
10334 (-[WebBasePluginPackage dealloc]):
10335 (-[WebBasePluginPackage finalize]):
10336 (-[WebBasePluginPackage pluginInfo]):
10337 (-[WebBasePluginPackage supportsExtension:]):
10338 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
10339 (-[WebBasePluginPackage MIMETypeForExtension:]):
10340 (-[WebBasePluginPackage isJavaPlugIn]):
10341 (-[WebBasePluginPackage versionNumber]):
10342 (-[WebBasePluginPackage WebCore::]):
10343 * Plugins/WebNetscapePluginPackage.mm:
10344 (-[WebNetscapePluginPackage openResourceFile]):
10345 (-[WebNetscapePluginPackage closeResourceFile:]):
10346 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10347 (-[WebNetscapePluginPackage _initWithPath:]):
10348 (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
10349 (-[WebNetscapePluginPackage _tryLoad]):
10350 (-[WebNetscapePluginPackage supportsSnapshotting]):
10351 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
10352 * Plugins/WebPluginDatabase.mm:
10353 (-[WebPluginDatabase refresh]):
10354 (-[WebPluginDatabase _removePlugin:]):
10355 * Plugins/WebPluginPackage.mm:
10356 (-[WebPluginPackage initWithPath:]):
10357 (-[WebPluginPackage load]):
10358 * WebCoreSupport/WebFrameLoaderClient.mm:
10359 (WebFrameLoaderClient::createPlugin):
10360 * WebCoreSupport/WebPlatformStrategies.mm:
10361 (WebPlatformStrategies::getPluginInfo):
10363 2010-06-21 Anders Carlsson <andersca@apple.com>
10365 Another PowerPC build fix.
10367 * Plugins/WebNetscapePluginPackage.mm:
10368 (-[WebNetscapePluginPackage openResourceFile]):
10369 (-[WebNetscapePluginPackage _tryLoad]):
10371 2010-06-21 Anders Carlsson <andersca@apple.com>
10373 Try to fix the PowerPC build.
10375 * Plugins/WebNetscapePluginPackage.mm:
10376 (-[WebNetscapePluginPackage _tryLoad]):
10378 2010-06-21 Nate Chapin <japhet@chromium.org>
10380 Reviewed by Adam Barth.
10382 Update relevant calls into FrameLoader to make use of
10383 FrameLoaderStateMachine.
10384 https://bugs.webkit.org/show_bug.cgi?id=39695
10386 * WebCoreSupport/WebFrameLoaderClient.mm:
10387 (WebFrameLoaderClient::transitionToCommittedForNewPage):
10388 * WebView/WebFrame.mm:
10389 (-[WebFrame _firstLayoutDone]):
10391 2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>
10393 Reviewed by Dan Bernstein.
10395 Chromium/Mac build fix.
10397 * WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other
10400 2010-06-21 Anders Carlsson <andersca@apple.com>
10402 Reviewed by Dan Bernstein.
10404 Make all of WebKit build with clang++
10406 * DefaultDelegates/WebDefaultPolicyDelegate.m:
10407 (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
10408 * Plugins/Hosted/NetscapePluginHostManager.mm:
10409 * Plugins/WebBaseNetscapePluginView.mm:
10410 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
10411 * WebView/WebDynamicScrollBarsView.mm:
10412 (-[WebDynamicScrollBarsView setSuppressLayout:]):
10413 * WebView/WebHTMLRepresentation.mm:
10414 * WebView/WebNavigationData.mm:
10415 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
10416 * WebView/WebPDFRepresentation.mm:
10417 (-[WebPDFRepresentation setDataSource:]):
10418 (-[WebPDFRepresentation receivedData:withDataSource:]):
10419 (-[WebPDFRepresentation receivedError:withDataSource:]):
10420 * WebView/WebResource.mm:
10421 (-[WebResource description]):
10422 * WebView/WebSerializedJSValue.mm:
10423 (-[WebSerializedJSValue initWithValue:context:exception:]):
10424 * WebView/WebVideoFullscreenController.mm:
10425 (-[WebVideoFullscreenController WebCore::]):
10426 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
10427 (-[WebVideoFullscreenController setDelegate:]):
10428 (-[WebVideoFullscreenController enterFullscreen:]):
10429 * WebView/WebView.mm:
10430 (-[WebView _openFrameInNewWindowFromMenu:]):
10431 (-[WebView _geolocationDidChangePosition:]):
10433 2010-06-21 Anders Carlsson <andersca@apple.com>
10435 Reviewed by Sam Weinig.
10437 Remove unused dictionary ivars from WebBasePluginPackage
10438 https://bugs.webkit.org/show_bug.cgi?id=40928
10440 * Plugins/WebBasePluginPackage.h:
10441 * Plugins/WebBasePluginPackage.mm:
10442 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10443 (-[WebBasePluginPackage dealloc]):
10444 * Plugins/WebNetscapePluginPackage.mm:
10445 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10447 2010-06-21 Dan Bernstein <mitz@apple.com>
10451 * WebCoreSupport/WebSystemInterface.mm:
10452 (InitWebCoreSystemInterface):
10454 2010-06-21 Dan Bernstein <mitz@apple.com>
10456 Reviewed by Darin Adler.
10458 WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
10459 https://bugs.webkit.org/show_bug.cgi?id=10228
10461 * WebCoreSupport/WebSystemInterface.mm:
10462 (InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.
10464 2010-06-21 Satish Sampath <satish@chromium.org>
10466 Reviewed by Steve Block.
10468 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
10469 https://bugs.webkit.org/show_bug.cgi?id=40878
10471 * Configurations/FeatureDefines.xcconfig:
10473 2010-06-20 Anders Carlsson <andersca@apple.com>
10477 * Plugins/WebNetscapePluginPackage.mm:
10479 2010-06-20 Anders Carlsson <andersca@apple.com>
10481 Reviewed by Dan Bernstein.
10483 Get rid of the old MIMETypes getter method
10484 https://bugs.webkit.org/show_bug.cgi?id=40898
10486 * Plugins/WebBasePluginPackage.h:
10487 * Plugins/WebBasePluginPackage.mm:
10488 (-[WebBasePluginPackage supportsExtension:]):
10489 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
10490 (-[WebBasePluginPackage MIMETypeForExtension:]):
10491 * Plugins/WebPluginDatabase.mm:
10492 (-[WebPluginDatabase refresh]):
10493 (-[WebPluginDatabase _removePlugin:]):
10495 2010-06-20 Anders Carlsson <andersca@apple.com>
10497 Reviewed by Dan Bernstein.
10499 Remove bogus const qualifiers.
10501 * WebCoreSupport/WebPasteboardHelper.h:
10502 * WebCoreSupport/WebPasteboardHelper.mm:
10503 (WebPasteboardHelper::urlFromPasteboard):
10504 (WebPasteboardHelper::plainTextFromPasteboard):
10505 (WebPasteboardHelper::fragmentFromPasteboard):
10507 2010-06-20 Anders Carlsson <andersca@apple.com>
10509 Reviewed by Dan Bernstein.
10511 Get rid of the extensionToMIME mapping in WebBasePluginPackage
10512 https://bugs.webkit.org/show_bug.cgi?id=40897
10514 Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
10515 While this makes lookup of MIME types based on extensions linear instead of constant,
10516 the number of extensions per plug-in is too small for it to matter.
10518 * Plugins/WebBasePluginPackage.h:
10519 * Plugins/WebBasePluginPackage.mm:
10520 (-[WebBasePluginPackage initWithPath:]):
10521 (-[WebBasePluginPackage dealloc]):
10522 (-[WebBasePluginPackage supportsExtension:]):
10523 (-[WebBasePluginPackage MIMETypeForExtension:]):
10524 (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
10526 2010-06-20 Anders Carlsson <andersca@apple.com>
10528 Reviewed by Dan Bernstein.
10530 Add a MimeClassInfo Vector to WebBasePluginPackage
10531 https://bugs.webkit.org/show_bug.cgi?id=40896
10533 * Plugins/WebBasePluginPackage.h:
10534 * Plugins/WebBasePluginPackage.mm:
10535 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10536 (-[WebBasePluginPackage WebCore::]):
10537 * Plugins/WebNetscapePluginPackage.mm:
10538 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10539 * WebCoreSupport/WebPlatformStrategies.mm:
10540 (WebPlatformStrategies::getPluginInfo):
10542 2010-06-20 Anders Carlsson <andersca@apple.com>
10544 Reviewed by Dan Bernstein.
10546 Move the NSBundle ivar to WebPluginPackage
10547 https://bugs.webkit.org/show_bug.cgi?id=40894
10549 * Plugins/WebBasePluginPackage.h:
10550 * Plugins/WebBasePluginPackage.mm:
10551 (-[WebBasePluginPackage initWithPath:]):
10552 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
10553 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10554 (-[WebBasePluginPackage load]):
10555 (-[WebBasePluginPackage dealloc]):
10556 * Plugins/WebNetscapePluginPackage.mm:
10557 (-[WebNetscapePluginPackage _initWithPath:]):
10558 * Plugins/WebPluginPackage.h:
10559 * Plugins/WebPluginPackage.mm:
10560 (-[WebPluginPackage initWithPath:]):
10561 (-[WebPluginPackage dealloc]):
10562 (-[WebPluginPackage viewFactory]):
10563 (-[WebPluginPackage load]):
10565 2010-06-20 Anders Carlsson <andersca@apple.com>
10567 Reviewed by Sam Weinig.
10569 Remove -[WebBasePluginPackage bundle]
10570 https://bugs.webkit.org/show_bug.cgi?id=40892
10572 Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.
10574 Move the supportsSnapshotting method over to the plug-in package.
10576 * Plugins/Hosted/NetscapePluginHostManager.mm:
10577 (WebKit::NetscapePluginHostManager::hostForPackage):
10578 * Plugins/WebBaseNetscapePluginView.mm:
10579 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
10580 (-[WebBaseNetscapePluginView supportsSnapshotting]):
10581 * Plugins/WebBasePluginPackage.h:
10582 * Plugins/WebBasePluginPackage.mm:
10583 (-[WebBasePluginPackage isQuickTimePlugIn]):
10584 (-[WebBasePluginPackage isJavaPlugIn]):
10585 (-[WebBasePluginPackage WebCore::]):
10586 Call bundleIdentifier directly instead of asking the bundle
10587 * Plugins/WebNetscapePluginPackage.h:
10588 * Plugins/WebNetscapePluginPackage.mm:
10589 (-[WebNetscapePluginPackage supportsSnapshotting]):
10590 * Plugins/WebNetscapePluginView.mm:
10591 (-[WebNetscapePluginView setAttributeKeys:andValues:]):
10592 (-[WebNetscapePluginView _createPlugin]):
10593 * Plugins/WebPluginDatabase.mm:
10596 2010-06-20 Anders Carlsson <andersca@apple.com>
10598 Reviewed by Dan Bernstein.
10600 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
10601 https://bugs.webkit.org/show_bug.cgi?id=40869
10603 Re-land r61459, with extra null-checks in WebFrameLoaderClient.
10605 * Plugins/Hosted/NetscapePluginHostManager.mm:
10606 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10607 * Plugins/WebBasePluginPackage.h:
10608 * Plugins/WebBasePluginPackage.mm:
10609 (-[WebBasePluginPackage initWithPath:]):
10610 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10611 (-[WebBasePluginPackage dealloc]):
10612 (-[WebBasePluginPackage name]):
10613 (-[WebBasePluginPackage path]):
10614 (-[WebBasePluginPackage filename]):
10615 (-[WebBasePluginPackage pluginDescription]):
10616 (-[WebBasePluginPackage description]):
10617 (-[WebBasePluginPackage isJavaPlugIn]):
10618 * Plugins/WebNetscapePluginPackage.mm:
10619 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10620 (-[WebNetscapePluginPackage _tryLoad]):
10621 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
10622 * Plugins/WebPluginPackage.mm:
10623 (-[WebPluginPackage load]):
10624 * WebCoreSupport/WebFrameLoaderClient.mm:
10625 (WebFrameLoaderClient::createPlugin):
10627 2010-06-18 Adam Barth <abarth@webkit.org>
10629 Unreviewed, rolling out r61459.
10630 http://trac.webkit.org/changeset/61459
10631 https://bugs.webkit.org/show_bug.cgi?id=40869
10633 Seems to have broken two tests on the Tiger buildbot:
10635 dom/html/level2/html/AppletsCollection.html
10636 plugins/qt-qwidget-plugin.html
10638 Anders wasn't on #webkit...
10640 * Plugins/Hosted/NetscapePluginHostManager.mm:
10641 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10642 * Plugins/WebBasePluginPackage.h:
10643 * Plugins/WebBasePluginPackage.mm:
10644 (-[WebBasePluginPackage initWithPath:]):
10645 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10646 (-[WebBasePluginPackage dealloc]):
10647 (-[WebBasePluginPackage name]):
10648 (-[WebBasePluginPackage path]):
10649 (-[WebBasePluginPackage filename]):
10650 (-[WebBasePluginPackage pluginDescription]):
10651 (-[WebBasePluginPackage setName:]):
10652 (-[WebBasePluginPackage setPath:]):
10653 (-[WebBasePluginPackage setPluginDescription:]):
10654 (-[WebBasePluginPackage description]):
10655 (-[WebBasePluginPackage isJavaPlugIn]):
10656 * Plugins/WebNetscapePluginPackage.mm:
10657 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10658 (-[WebNetscapePluginPackage _tryLoad]):
10659 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
10660 * Plugins/WebPluginPackage.mm:
10661 (-[WebPluginPackage load]):
10663 2010-06-18 Anders Carlsson <andersca@apple.com>
10667 * Plugins/WebBasePluginPackage.mm:
10668 (-[WebBasePluginPackage isJavaPlugIn]):
10670 2010-06-18 Anders Carlsson <andersca@apple.com>
10672 Reviewed by Sam Weinig.
10674 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
10675 https://bugs.webkit.org/show_bug.cgi?id=40869
10677 * Plugins/Hosted/NetscapePluginHostManager.mm:
10678 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10679 * Plugins/WebBasePluginPackage.h:
10680 * Plugins/WebBasePluginPackage.mm:
10681 (-[WebBasePluginPackage initWithPath:]):
10682 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10683 (-[WebBasePluginPackage dealloc]):
10684 (-[WebBasePluginPackage name]):
10685 (-[WebBasePluginPackage path]):
10686 (-[WebBasePluginPackage filename]):
10687 (-[WebBasePluginPackage pluginDescription]):
10688 (-[WebBasePluginPackage description]):
10689 (-[WebBasePluginPackage isJavaPlugIn]):
10690 * Plugins/WebNetscapePluginPackage.mm:
10691 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10692 (-[WebNetscapePluginPackage _tryLoad]):
10693 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
10694 * Plugins/WebPluginPackage.mm:
10695 (-[WebPluginPackage load]):
10697 2010-06-18 Anders Carlsson <andersca@apple.com>
10699 Reviewed by Sam Weinig.
10701 Rename WebPluginPackage.m to make it an Objective-C++ file.
10703 * Plugins/WebPluginPackage.m: Removed.
10704 * Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
10706 2010-06-18 Anders Carlsson <andersca@apple.com>
10708 Reviewed by Sam Weinig.
10710 Get rid of the NSEnumerators from WebBasePluginPackage
10711 https://bugs.webkit.org/show_bug.cgi?id=40868
10713 * Plugins/WebBasePluginPackage.h:
10714 * Plugins/WebBasePluginPackage.mm:
10715 (-[WebBasePluginPackage MIMETypes]):
10716 (-[WebBasePluginPackage supportsExtension:]):
10717 (-[WebBasePluginPackage supportsMIMEType:]):
10718 * Plugins/WebPluginDatabase.mm:
10719 (-[WebPluginDatabase pluginForMIMEType:]):
10720 (-[WebPluginDatabase pluginForExtension:]):
10721 (-[WebPluginDatabase refresh]):
10722 (-[WebPluginDatabase _removePlugin:]):
10723 * WebCoreSupport/WebPlatformStrategies.mm:
10724 (WebPlatformStrategies::getPluginInfo):
10726 2010-06-18 Anders Carlsson <andersca@apple.com>
10728 Reviewed by Sam Weinig.
10730 Make WebCoreSystemInterface.h a C++ only header
10731 https://bugs.webkit.org/show_bug.cgi?id=40867
10733 * WebCoreSupport/WebSystemInterface.h:
10734 * WebCoreSupport/WebSystemInterface.m: Removed.
10735 * WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.
10737 2010-06-18 Anders Carlsson <andersca@apple.com>
10739 Reviewed by Sam Weinig.
10741 Clean up WebPluginDatabase.mm
10742 https://bugs.webkit.org/show_bug.cgi?id=40866
10744 * Plugins/WebBasePluginPackage.h:
10745 * Plugins/WebBasePluginPackage.mm:
10746 (pathByResolvingSymlinksAndAliases):
10747 (-[WebBasePluginPackage initWithPath:]):
10748 Change an instance method into a static function.
10750 * Plugins/WebPluginDatabase.mm:
10751 (PluginPackageCandidates::PluginPackageCandidates):
10752 (PluginPackageCandidates::update):
10753 (PluginPackageCandidates::bestCandidate):
10754 Add a new PluginPackageCandidates class.
10756 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
10757 Use PluginPackageCandidates here.
10759 2010-06-18 Anders Carlsson <andersca@apple.com>
10763 * WebCoreSupport/WebPlatformStrategies.mm:
10765 2010-06-18 Anders Carlsson <andersca@apple.com>
10767 Reviewed by Darin Adler.
10769 Get rid of PluginDataMac.mm and use the plug-in strategy instead
10770 https://bugs.webkit.org/show_bug.cgi?id=40860
10772 * Plugins/WebBasePluginPackage.h:
10773 * WebCoreSupport/WebPlatformStrategies.h:
10774 * WebCoreSupport/WebPlatformStrategies.mm:
10775 (WebPlatformStrategies::createPluginStrategy):
10776 (WebPlatformStrategies::refreshPlugins):
10777 (WebPlatformStrategies::getPluginInfo):
10778 * WebCoreSupport/WebViewFactory.mm:
10780 2010-06-18 Anders Carlsson <andersca@apple.com>
10782 Reviewed by Dan Bernstein.
10784 Add stubbed out WebPlatformStrategies class to WebKit.
10785 https://bugs.webkit.org/show_bug.cgi?id=40851
10787 * WebCoreSupport/WebPlatformStrategies.h: Added.
10788 * WebCoreSupport/WebPlatformStrategies.mm: Added.
10789 (WebPlatformStrategies::initialize):
10790 (WebPlatformStrategies::WebPlatformStrategies):
10791 (WebPlatformStrategies::createPluginStrategy):
10792 * WebView/WebView.mm:
10793 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10795 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
10797 Reviewed by Adam Barth.
10799 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
10800 https://bugs.webkit.org/show_bug.cgi?id=39041
10802 * WebView/WebView.mm:
10803 (-[WebView _preferencesChangedNotification:]):
10805 2010-06-17 Darin Adler <darin@apple.com>
10807 Reviewed by Sam Weinig.
10809 Use adoptRef and create functions in more code paths
10810 https://bugs.webkit.org/show_bug.cgi?id=40760
10812 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
10813 be an inline function.
10815 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10816 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
10817 Moved the call to addPluginInstance out of here.
10818 (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
10819 This makes sure we call adoptRef on the new proxy before any caller
10822 2010-06-16 Eric Seidel <eric@webkit.org>
10824 Reviewed by Adam Barth.
10826 Enable HTML5 Parser in Safari on Mac
10827 https://bugs.webkit.org/show_bug.cgi?id=40739
10829 The HTML5 parser is probably off on all webkit ports.
10830 We should either flip the meaning of the default so that
10831 "false" means HTML5 on all ports, or we'll have to write
10832 more code like this for all the other ports.
10834 * WebView/WebPreferences.mm:
10835 (+[WebPreferences initialize]):
10837 2010-06-15 Mark Rowe <mrowe@apple.com>
10839 Reviewed by Sam Weinig.
10841 Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.
10843 * WebView/WebGeolocationPosition.mm:
10844 (-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.
10846 2010-06-10 Yuzo Fujishima <yuzo@google.com>
10848 Reviewed by Shinichiro Hamaji.
10850 Implement render style selection for pages to support CSS3 Paged Media.
10851 https://bugs.webkit.org/show_bug.cgi?id=35961
10853 * Misc/WebCoreStatistics.h:
10854 * Misc/WebCoreStatistics.mm:
10855 (-[WebFrame pageProperty:propertyName:]):
10857 2010-06-15 Darin Adler <darin@apple.com>
10859 Reviewed by Adam Barth.
10861 Move functions out of Frame class that were marked "move to Chrome"
10862 https://bugs.webkit.org/show_bug.cgi?id=39636
10864 * WebView/WebView.mm:
10865 (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of
10866 going through Frame.
10868 2010-06-15 Anders Carlsson <andersca@apple.com>
10870 Reviewed by Dan Bernstein.
10872 Remove getPluginInfoFromBundleAndMIMEDictionary:
10874 * Plugins/WebBasePluginPackage.mm:
10876 2010-06-15 Anders Carlsson <andersca@apple.com>
10878 Reviewed by Dan Bernstein.
10880 Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.
10882 * Plugins/WebBasePluginPackage.mm:
10883 (-[WebBasePluginPackage getPluginInfoFromPLists]):
10885 2010-06-11 Simon Fraser <simon.fraser@apple.com>
10887 Reviewed by Darin Adler.
10889 <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps
10891 The run loop observer used to commit compositing layer changes does not do
10892 updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
10893 update is pending (added in r58623).
10895 However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
10896 This caused us to never sync compositing layers.
10898 So detect if the current window is wrapping a carbon window, and in that case consult the root
10899 HIView to detect if display is pending.
10901 * WebView/WebView.mm:
10902 (layerSyncRunLoopObserverCallBack):
10904 2010-06-15 Dan Bernstein <mitz@apple.com>
10906 Reviewed by John Sullivan.
10908 <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email
10910 Test: platform/mac/editing/input/NSBackgroundColor-transparent.html
10912 r50796 changed the initial background color from invalid to transparent. As a result,
10913 NSAttributedStrings returned from +_web_attributedStringFromRange started including the
10914 NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
10915 components in the system that ignore the alpha component, turning the color into opaque black.
10917 * Misc/WebNSAttributedStringExtras.mm:
10918 (+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
10919 and foreground color attributes if the color are transparent.
10921 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
10923 Reviewed by Pavel Feldman.
10925 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
10926 data from inspected page to WebInspector as JSON string via http. The native
10927 serialization to JSON string is supported by InspectorValue's classes. This patch
10928 has the implementation of sendMessageToFrontend function. WebKit version of it still
10929 uses ScriptFunctionCall and will be switched to another transport a little bit later.
10930 https://bugs.webkit.org/show_bug.cgi?id=40134
10932 * WebCoreSupport/WebInspectorClient.h:
10933 * WebCoreSupport/WebInspectorClient.mm:
10934 (WebInspectorClient::WebInspectorClient):
10935 (WebInspectorClient::openInspectorFrontend):
10937 2010-06-10 David Hyatt <hyatt@apple.com>
10939 Reviewed by John Sullivan.
10941 https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
10942 wheel delta values.
10944 * WebView/WebDynamicScrollBarsView.mm:
10945 (-[WebDynamicScrollBarsView scrollWheel:]):
10947 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
10949 Unreviewed, rolling out r60889.
10950 http://trac.webkit.org/changeset/60889
10951 https://bugs.webkit.org/show_bug.cgi?id=40365
10953 gtk bot has some kind of memory corruption (Requested by
10954 loislo on #webkit).
10956 * WebCoreSupport/WebInspectorClient.h:
10957 * WebCoreSupport/WebInspectorClient.mm:
10958 (WebInspectorClient::WebInspectorClient):
10959 (WebInspectorClient::openInspectorFrontend):
10960 (-[WebInspectorWindowController destroyInspectorView]):
10962 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
10964 Reviewed by Pavel Feldman.
10966 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
10967 data from inspected page to WebInspector as JSON string via http. The native
10968 serialization to JSON string is supported by InspectorValue's classes. This patch
10969 has the implementation of sendMessageToFrontend function. WebKit version of it still
10970 uses ScriptFunctionCall and will be switched to another transport a little bit later.
10971 https://bugs.webkit.org/show_bug.cgi?id=40134
10973 * WebCoreSupport/WebInspectorClient.h:
10974 * WebCoreSupport/WebInspectorClient.mm:
10975 (WebInspectorClient::WebInspectorClient):
10976 (WebInspectorClient::openInspectorFrontend):
10978 2010-06-08 Mark Rowe <mrowe@apple.com>
10980 Reviewed by Adele Peterson.
10982 <rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK
10984 * WebCoreSupport/WebContextMenuClient.mm:
10985 (fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the
10986 context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector.
10988 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
10990 Reviewed by Ojan Vafai and Darin Adler.
10992 Refactor platform dependent editing behavior code out of Settings
10993 https://bugs.webkit.org/show_bug.cgi?id=39854
10995 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
10996 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
10998 * WebView/WebFrame.mm:
11000 * WebView/WebFrameInternal.h:
11001 * WebView/WebView.mm:
11002 (-[WebView _preferencesChangedNotification:]):
11004 2010-06-06 MORITA Hajime <morrita@google.com>
11006 Unreviewd, follow up to r60820
11008 https://bugs.webkit.org/show_bug.cgi?id=40219
11009 [Mac] ENABLE_METER_TAG should be enabled
11011 Added ENABLE_METER_TAG.
11013 * Configurations/FeatureDefines.xcconfig:
11015 2010-06-06 Gavin Barraclough <barraclough@apple.com>
11017 Reviewed by Sam Weinig.
11019 Bug 40214 - Clean up error construction / throwing in JSC.
11021 The one egregious insanity here is that creating an error requires
11022 a VM-entry-esqe-host call (the string argument is wrapped as a JS
11023 object & pushed on the RegisterFile, then unwrapped back to a
11024 UString). Changing this also means you only require a global
11025 object, not an ExecState, to create an error.
11027 The methods to create error objects are also parameterized
11028 requiring a switch on the type, which can be made cleaner and
11029 faster by moving to a separate method per error type. Code to add
11030 divot information to error had been duplicated, and is coalesced
11031 back into a single function.
11033 Convenience methods added to create & throw type & syntax error
11034 with a default error message, since this is a common case.
11036 Also, errors are currently thrown either using
11037 "throwError(exec, error)" or "exec->setException(error)" - unify
11038 on the former, since this is more commonly used. Add
11039 "throwVMError(exec, error)" equivalents, as a convenience for
11040 cases where the result was being wrapped in "JSValue::encode(...)".
11042 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
11043 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
11044 * Plugins/Hosted/ProxyInstance.mm:
11045 (WebKit::ProxyInstance::invokeMethod):
11047 2010-06-02 Gavin Barraclough <barraclough@apple.com>
11049 Reviewed by Oliver Hunt.
11051 Bug 40094 - The return type of NativeFunction should be EncodedJSValue
11052 On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
11054 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
11055 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
11056 (WebKit::NetscapePluginInstanceProxy::invoke):
11058 2010-06-02 Sterling Swigart <sswigart@google.com>
11060 Reviewed by David Levin.
11062 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
11063 https://bugs.webkit.org/show_bug.cgi?id=39906
11065 * Configurations/FeatureDefines.xcconfig:
11067 2010-06-01 David Hyatt <hyatt@apple.com>
11069 Reviewed by Anders Carlsson.
11071 Add a preference for paginating during layout (the new model for computing page breaks).
11073 * WebView/WebPreferenceKeysPrivate.h:
11074 * WebView/WebPreferences.mm:
11075 (-[WebPreferences paginateDuringLayoutEnabled]):
11076 (-[WebPreferences setPaginateDuringLayoutEnabled:]):
11077 * WebView/WebPreferencesPrivate.h:
11078 * WebView/WebView.mm:
11079 (-[WebView _preferencesChangedNotification:]):
11081 2010-06-01 Kevin Decker <kdecker@apple.com>
11083 Reviewed by Simon Fraser.
11085 https://bugs.webkit.org/show_bug.cgi?id=40025
11086 <rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.
11088 * Plugins/WebBaseNetscapePluginView.mm:
11089 (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if
11090 the version is less than 10.1.53.60.
11092 2010-06-01 Alexey Proskuryakov <ap@apple.com>
11094 Reviewed by Sam Weinig.
11096 https://bugs.webkit.org/show_bug.cgi?id=39434
11097 REGRESSION (r59811): Geolocation callbacks cannot be created
11099 Removing unused WebGeolocationMock.
11101 * WebCoreSupport/WebGeolocationMock.mm: Removed.
11102 * WebCoreSupport/WebGeolocationMockPrivate.h: Removed.
11105 2010-05-30 Darin Adler <darin@apple.com>
11107 Reviewed by Sam Weinig.
11109 Make more HTML DOM members private, especially constructors, third and final batch
11110 https://bugs.webkit.org/show_bug.cgi?id=39916
11112 * WebView/WebHTMLRepresentation.mm:
11113 (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement
11114 function, associatedElements, rather than getting directly at a data member
11115 named formElements.
11116 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
11118 2010-05-28 Geoffrey Garen <ggaren@apple.com>
11120 Reviewed by Sam Weinig, Gavin Barraclough, Oliver Hunt.
11122 Simplified the host calling convention.
11124 PART ONE: Functional code changes.
11128 PART TWO: Global search and replace.
11130 In the areas below, I used global search-and-replace to change
11131 (ExecState*, JSObject*, JSValue, const ArgList&) => (ExecState*)
11132 args.size() => exec->argumentCount()
11133 args.at(i) => exec->argument(i)
11135 * Plugins/Hosted/ProxyInstance.h:
11136 * Plugins/Hosted/ProxyInstance.mm:
11137 (WebKit::ProxyInstance::invoke):
11138 (WebKit::ProxyInstance::invokeMethod):
11139 (WebKit::ProxyInstance::invokeDefaultMethod):
11141 2010-05-27 Beth Dakin <bdakin@apple.com>
11143 Reviewed by Simon Fraser.
11145 Change z-component to 1.
11147 * WebView/WebHTMLView.mm:
11148 (-[WebHTMLView viewDidMoveToWindow]):
11149 (-[WebHTMLView attachRootLayer:]):
11151 2010-05-26 Simon Fraser <simon.fraser@apple.com>
11153 Reviewed by Beth Dakin and Darin Adler.
11155 Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers
11156 do not scale properly when running with a resolution independent
11159 Apply the userSpaceScaleFactor as a scale on the layerHostingView.
11161 * WebView/WebHTMLView.mm:
11162 (-[WebHTMLView viewDidMoveToWindow]):
11163 (-[WebHTMLView attachRootLayer:]):
11165 2010-05-25 Alexey Proskuryakov <ap@apple.com>
11167 Reviewed by Darin Adler.
11169 https://bugs.webkit.org/show_bug.cgi?id=39621
11170 <rdar://problem/8009738> Extreme memory growth on DOM Hanoi test
11172 Removed formStateDidChange support, which is not needed by any client.
11174 * WebCoreSupport/WebChromeClient.h:
11175 (WebChromeClient::formStateDidChange):
11176 * WebCoreSupport/WebChromeClient.mm:
11177 * WebView/WebUIDelegatePrivate.h:
11179 2010-05-25 Brady Eidson <beidson@apple.com>
11181 Reviewed by Darin Adler.
11183 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
11184 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
11186 * Storage/WebDatabaseManager.mm:
11187 (WebKitInitializeDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
11188 an already created tracker that already has its origins populated.
11190 2010-05-24 Darin Adler <darin@apple.com>
11192 Reviewed by Eric Seidel.
11194 Move view-related functions from Frame to FrameView
11195 https://bugs.webkit.org/show_bug.cgi?id=39366
11197 * WebView/WebView.mm:
11198 (-[WebView _setZoomMultiplier:isTextOnly:]): Call function on FrameView.
11199 (-[WebView setEditable:]): Get rid of call to empty function,
11200 removeEditingStyleFromBodyElement.
11202 2010-05-21 David Hyatt <hyatt@apple.com>
11204 Reviewed by Dan Bernstein.
11206 https://bugs.webkit.org/show_bug.cgi?id=39420
11208 Make sure everyone who needs to is using visitedDependentColor rather than accessing styles
11211 * Misc/WebNSAttributedStringExtras.mm:
11212 (+[NSAttributedString _web_attributedStringFromRange:]):
11213 * WebView/WebFrame.mm:
11214 (-[WebFrame _bodyBackgroundColor]):
11216 2010-05-21 Oliver Hunt <oliver@apple.com>
11218 Reviewed by Geoffrey Garen.
11220 All callable objects should have a global object reference
11221 https://bugs.webkit.org/show_bug.cgi?id=39495
11223 Update the plugin proxy to handle the need for global object.
11225 * Plugins/Hosted/ProxyInstance.mm:
11226 (WebKit::ProxyInstance::newRuntimeObject):
11227 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
11228 (WebKit::ProxyInstance::getMethod):
11229 * Plugins/Hosted/ProxyRuntimeObject.h:
11230 * Plugins/Hosted/ProxyRuntimeObject.mm:
11231 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
11233 2010-05-21 Steve Block <steveblock@google.com>
11235 Reviewed by Jeremy Orlow.
11237 Add DeviceOrientation and DeviceOrientationClient
11238 https://bugs.webkit.org/show_bug.cgi?id=39479
11240 * WebView/WebView.mm:
11241 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11243 2010-05-20 Mike Thole <mthole@apple.com>
11245 Reviewed by Dave Hyatt.
11247 When using a scale factor > 1, scrollbars sometimes appear when not necessary
11248 https://bugs.webkit.org/show_bug.cgi?id=39458
11250 * WebView/WebDynamicScrollBarsView.mm:
11251 (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
11252 so that they can be compared against the integral document size.
11254 2010-05-20 Kevin Decker <kdecker@apple.com>
11256 Reviewed by Anders Carlsson.
11258 https://bugs.webkit.org/show_bug.cgi?id=39441
11259 <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
11260 <rdar://problem/7986109> Youtube video controller UI entirely missing
11261 <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
11263 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11264 (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
11265 it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
11266 factors this assumption is false. Accordingly we now convert to the window contentView
11267 coordinate system when computing bounds in "window" and the visible rect.
11268 * Plugins/WebNetscapePluginView.mm:
11269 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
11271 2010-05-20 Steve Block <steveblock@google.com>
11273 Reviewed by Jeremy Orlow.
11275 Provide bindings for DeviceOrientation
11276 https://bugs.webkit.org/show_bug.cgi?id=39210
11278 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
11280 * Configurations/FeatureDefines.xcconfig:
11282 2010-05-20 Martin Robinson <mrobinson@webkit.org>
11284 Reviewed by Ojan Vafai.
11286 Expose the editing behavior setting in DRT to test all editing code paths
11287 https://bugs.webkit.org/show_bug.cgi?id=38603
11289 * WebView/WebFrame.mm:
11291 * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
11292 * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
11293 * WebView/WebPreferences.mm:
11294 (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
11295 (-[WebPreferences editingBehavior]): Added.
11296 (-[WebPreferences setEditingBehavior:]): Added.
11297 * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
11298 * WebView/WebView.mm:
11299 (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
11301 2010-05-19 Anders Carlsson <andersca@apple.com>
11303 Reviewed by Kevin Decker and Simon Fraser.
11305 <rdar://problem/8004528>
11306 REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on
11308 When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return
11309 the newly created layer.
11311 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11312 (-[WebHostedNetscapePluginView createPlugin]):
11313 * Plugins/WebNetscapePluginView.mm:
11314 (-[WebNetscapePluginView createPlugin]):
11316 2010-05-18 Tony Chang <tony@chromium.org>
11318 Reviewed by Darin Adler.
11320 https://bugs.webkit.org/show_bug.cgi?id=24943
11321 Command-B and Command-I do not generate keydown events in contentEditable regions.
11323 Manual test because performKeyEquivalent is not called by DRT.
11325 Test: manual-tests/style-keypress-events.html
11327 * WebView/WebHTMLView.mm:
11328 (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
11330 2010-05-18 Daniel Cheng <dcheng@chromium.org>
11332 Reviewed by Darin Adler, Jian Li.
11334 DragData::asURL() shouldn't do file validity checks
11335 https://bugs.webkit.org/show_bug.cgi?id=38711
11337 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
11338 that don't exist. Callers who care about the existence of the file or
11339 whether or not it is a directory should check themselves when they
11340 want to use the file. The directory check has been left in for now,
11341 since the Mac implementation of ResourceHandle, which uses this function
11342 indirectly via DragController::performDrag) handles directories somewhat
11343 non-intuitively: it opens the parent directory in the Finder, rather
11344 than opening the directory itself.
11346 * Misc/WebNSPasteboardExtras.mm:
11347 (-[NSPasteboard _web_bestURL]):
11349 2010-05-18 Eric Seidel <eric@webkit.org>
11351 Reviewed by Adam Barth (and Maciej Stachowiak).
11353 Make it possible to enable the new HTML5Tokenizer for testing
11354 https://bugs.webkit.org/show_bug.cgi?id=39275
11356 Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.
11358 * WebView/WebPreferenceKeysPrivate.h:
11359 * WebView/WebPreferences.mm:
11360 (-[WebPreferences html5ParserEnabled]):
11361 (-[WebPreferences setHTML5ParserEnabled:]):
11362 * WebView/WebPreferencesPrivate.h:
11363 * WebView/WebView.mm:
11364 (-[WebView _preferencesChangedNotification:]):
11366 2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
11368 Unreviewed, rolling out r59652.
11369 http://trac.webkit.org/changeset/59652
11370 https://bugs.webkit.org/show_bug.cgi?id=39268
11372 file-input-files-access test is broken on Mac (Requested by
11373 dcheng on #webkit).
11375 * Misc/WebNSPasteboardExtras.mm:
11376 (-[NSPasteboard _web_bestURL]):
11378 2010-05-17 Daniel Cheng <dcheng@chromium.org>
11380 Reviewed by Darin Adler.
11382 DragData::asURL() shouldn't do file validity checks
11383 https://bugs.webkit.org/show_bug.cgi?id=38711
11385 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
11386 that don't exist. Callers who care about the existence of the file or
11387 whether or not it is a directory should check themselves when they
11388 want to use the file. The directory check has been left in for now,
11389 since the Mac implementation of ResourceHandle, which uses this function
11390 indirectly via DragController::performDrag) handles directories somewhat
11391 non-intuitively: it opens the parent directory in the Finder, rather
11392 than opening the directory itself.
11394 * Misc/WebNSPasteboardExtras.mm:
11395 (-[NSPasteboard _web_bestURL]):
11397 2010-05-14 Stephanie Lewis <slewis@apple.com>
11399 Rubber-stamped by Mark Rowe.
11401 Update order files.
11405 2010-05-13 Timothy Hatcher <timothy@apple.com>
11407 Allow reporting exceptions that occur when using JavaScriptCore APIs
11408 to the Web Inspector.
11410 <rdar://problem/7975410>
11412 Reviewed by Sam Weinig.
11414 * WebView/WebView.mm:
11415 (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
11416 that the global object is a DOMWindow.
11417 * WebView/WebViewPrivate.h: Added _reportException:inContext:.
11419 2010-05-13 Alexey Proskuryakov <ap@apple.com>
11421 Reviewed by Darin Adler.
11423 https://bugs.webkit.org/show_bug.cgi?id=39089
11424 <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
11426 Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
11427 investigate a more extensible solution when there are more, and we know what the
11428 typical restictions are.
11430 * Misc/WebNSURLExtras.mm:
11431 (allCharactersAllowedByTLDRules):
11432 (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
11434 2010-05-12 Simon Fraser <simon.fraser@apple.com>
11436 Reviewed by David Hyatt.
11438 Composited plug-ins can cause missed painting
11439 https://bugs.webkit.org/show_bug.cgi?id=39033
11440 <rdar://problem/7972478>
11442 Eagerly enable compositing mode via the enclosing FrameView when the plug-in tells us it wants
11445 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11446 (-[WebHostedNetscapePluginView createPlugin]):
11447 * Plugins/WebNetscapePluginView.mm:
11448 (-[WebNetscapePluginView createPlugin]):
11450 2010-05-12 Jer Noble <jer.noble@apple.com>
11452 Reviewed by Darin Adler.
11454 Bug 38689: #34005 will break fullscreen video playback
11455 https://bugs.webkit.org/show_bug.cgi?id=38689
11457 Use the new definition of PlatformMedia to check the actual type
11458 returned by MediaPlayer.
11460 * WebView/WebVideoFullscreenController.mm:
11461 (-[WebVideoFullscreenController windowDidLoad]):
11463 2010-05-11 Mark Rowe <mrowe@apple.com>
11467 In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
11468 The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
11469 that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
11470 in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
11471 and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
11472 function in WebCore being called.
11474 We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
11475 other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
11478 * Configurations/FeatureDefines.xcconfig:
11480 2010-05-10 Simon Fraser <simon.fraser@apple.com>
11482 Reviewed by Anders Carlsson.
11484 Allow compositing layers to be connected across iframe boundaries on Mac
11485 https://bugs.webkit.org/show_bug.cgi?id=38856
11487 When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
11488 flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
11489 content to show up in both compositing layers, and the painted background inside the iframe.
11491 Fix by taking the flattening state from the parent frame, if there is one. For the root
11492 frame, we continue to look to see if we're painting into a bitmap.
11494 * WebView/WebFrame.mm:
11495 (-[WebFrame _drawRect:contentsOnly:]):
11497 2010-05-10 Timothy Hatcher <timothy@apple.com>
11499 Fix a crash when closing a WebView while the Web Inspector is open.
11501 <rdar://problem/7966830>
11503 Reviewed by Mark Rowe.
11505 * WebCoreSupport/WebInspectorClient.mm:
11506 (-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
11507 * WebView/WebView.mm:
11508 (-[WebView _close]): Null out _private->page before deleting the page, so code called
11509 during destruction don't access a half deleted Page object.
11511 2010-05-10 Anders Carlsson <andersca@apple.com>
11513 Unbreak the world. (Fix Mac builds).
11515 * Plugins/Hosted/WebKitPluginHostTypes.h:
11517 2010-05-10 Anders Carlsson <andersca@apple.com>
11519 Reviewed by Simon Fraser.
11521 Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
11522 use accelerated compositing and not layer backed views.
11524 * Plugins/Hosted/WebKitPluginHostTypes.h:
11526 2010-05-07 Anders Carlsson <andersca@apple.com>
11528 Reviewed by Sam Weinig and Simon Fraser.
11530 <rdar://problem/7947356>
11531 QT Plug-in in hardware-accelerated WebKit is missing the controller
11533 Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
11534 backed NSView instead of inserting the layer into the WebCore layer hierarchy.
11536 * Plugins/Hosted/NetscapePluginHostManager.mm:
11537 (WebKit::NetscapePluginHostManager::instantiatePlugin):
11538 * Plugins/Hosted/NetscapePluginHostProxy.mm:
11539 (WKPCInstantiatePluginReply):
11540 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
11541 (WebKit::NetscapePluginInstanceProxy::rendererType):
11542 (WebKit::NetscapePluginInstanceProxy::setRendererType):
11543 (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
11544 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
11545 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
11546 Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.
11548 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11549 (-[WebHostedNetscapePluginView createPlugin]):
11550 Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
11551 Otherwise, use a layer backed NSView.
11553 * Plugins/Hosted/WebKitPluginHostTypes.h:
11554 Add a RendererType enum.
11556 2010-05-06 Anders Carlsson <andersca@apple.com>
11558 Reviewed by Darin Adler and Dan Bernstein..
11560 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
11561 https://bugs.webkit.org/show_bug.cgi?id=38698
11562 <rdar://problem/7942075>
11564 When the plug-in database is initialized, we will register all the MIME types it supports with the global
11565 WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
11566 in the global mapping (because other web views might still have plug-ins enabled).
11568 Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
11569 plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
11571 In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
11572 +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
11573 we check if the MIME type is a known plug-in MIME type and return false in that case.
11575 * Plugins/WebPluginDatabase.mm:
11576 (-[WebPluginDatabase refresh]):
11577 (-[WebPluginDatabase _removePlugin:]):
11578 * WebView/WebView.mm:
11579 (knownPluginMIMETypes):
11580 (+[WebView _registerPluginMIMEType:]):
11581 (+[WebView _unregisterPluginMIMEType:]):
11582 (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
11583 * WebView/WebViewInternal.h:
11585 2010-05-06 Dan Bernstein <mitz@apple.com>
11587 Reviewed by Simon Fraser.
11589 <rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
11591 Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
11592 return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
11593 of the surface for the child WebFrameView. The fix is to restrict the special behavior of
11594 -[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
11595 areas while scrolling.
11597 * WebView/WebClipView.h:
11598 * WebView/WebClipView.mm:
11599 (-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
11600 [super visibleRect].
11601 (-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
11602 to set a flag telling -visibleRect that the view is scrolling.
11603 * WebView/WebView.mm:
11604 (layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
11605 when it thinks an upcoming window flush will re-enable them, are enabled here in
11606 case the -setNeedsDisplayInRect: override has prevented the window from needing to be
11609 2010-05-06 Steve Block <steveblock@google.com>
11611 Reviewed by Eric Seidel.
11613 MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
11614 https://bugs.webkit.org/show_bug.cgi?id=38544
11616 * WebCoreSupport/WebFrameLoaderClient.h:
11617 * WebCoreSupport/WebFrameLoaderClient.mm:
11619 2010-05-05 Dan Bernstein <mitz@apple.com>
11621 Reviewed by Mark Rowe.
11623 Fixed a crash when closing Top Sites after r58847.
11625 * WebView/WebFrameView.mm:
11626 (-[WebFrameView webFrame]): Null-check _private.
11628 2010-05-05 Dan Bernstein <mitz@apple.com>
11630 Rubber-stamped by Mark Rowe.
11632 Fixed test crashes after r58847.
11634 * WebView/WebHTMLView.mm:
11635 (setNeedsDisplayInRect): Null-check the frame.
11637 2010-05-05 Dan Bernstein <mitz@apple.com>
11639 Reviewed by Simon Fraser.
11641 <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
11642 https://bugs.webkit.org/show_bug.cgi?id=38427
11644 * WebView/WebClipView.m: Renamed to WebClipView.mm.
11645 * WebView/WebClipView.mm:
11646 (-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
11647 composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
11648 AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
11649 Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
11650 * WebView/WebHTMLView.mm:
11651 (setCursor): Style tweak.
11652 (setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
11653 so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
11654 is routed back through the WebCore FrameView, which propagates it to the layer.
11655 (+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
11656 (-[WebHTMLView visibleRect]): Removed whitespace.
11657 * WebView/WebView.mm:
11658 (layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
11659 in preparation for the displaying of compositing layers.
11661 2010-05-05 John Sullivan <sullivan@apple.com>
11663 <rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
11665 Reviewed by Mark Rowe.
11667 * WebView/WebView.mm:
11668 (+[WebView closeAllWebViews]):
11669 Make copy of allWebViewsSet to avoid mutating it while iterating through it.
11671 2010-05-04 Simon Fraser <simon.fraser@apple.com>
11673 Reviewed by Dan Bernstein.
11675 Improve check for drawing into the window that was added in r58623
11676 https://bugs.webkit.org/show_bug.cgi?id=38562
11678 Rather than assuming that any non-bitmap context is the window's context,
11679 compare the current graphics context with -[NSWindow graphicsContext] to
11680 determine that we're drawing into the window.
11682 * WebView/WebHTMLView.mm:
11683 (-[WebHTMLView drawRect:]):
11685 2010-05-04 Ada Chan <adachan@apple.com>
11687 Reviewed by David Kilzer.
11689 https://bugs.webkit.org/show_bug.cgi?id=38555
11691 Small code refactoring: move the logic to figure out the path to the
11692 databases directory to another method.
11694 * Storage/WebDatabaseManager.mm:
11695 (databasesDirectoryPath):
11696 (WebKitInitializeDatabasesIfNecessary):
11698 2010-05-04 Beth Dakin <bdakin@apple.com>
11700 Reviewed by Mike Thole.
11702 Fix for <rdar://problem/7818509> Crash occurs when exiting Safari
11704 We can avoid this crash if we call [self _removeFromAllWebViewsSet]
11705 even in the case when we are doing a fastDocumentTeardown. This is
11706 a much safer approach.
11707 * WebView/WebView.mm:
11708 (-[WebView _close]):
11710 2010-05-03 Abhishek Arya <inferno@chromium.org>
11712 Reviewed by Adam Barth.
11714 Add support for controlling clipboard access from javascript.
11715 Clipboard access from javascript is disabled by default.
11716 https://bugs.webkit.org/show_bug.cgi?id=27751
11718 * WebView/WebPreferenceKeysPrivate.h:
11719 * WebView/WebPreferences.mm:
11720 (+[WebPreferences initialize]):
11721 (-[WebPreferences javaScriptCanAccessClipboard]):
11722 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
11723 * WebView/WebPreferencesPrivate.h:
11724 * WebView/WebView.mm:
11725 (-[WebView _preferencesChangedNotification:]):
11727 2010-05-03 Jens Alfke <snej@chromium.org>
11729 Reviewed by Darin Fisher.
11731 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
11732 https://bugs.webkit.org/show_bug.cgi?id=38397
11734 No tests (functionality is exposed only through native WebKit API.)
11736 * WebCoreSupport/WebFrameLoaderClient.h:
11737 (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
11739 2010-04-30 Simon Fraser <simon.fraser@apple.com>
11741 Reviewed by Dan Bernstein.
11743 <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites
11745 Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
11746 can cause flickering because of unsychronized compositing layer and view-based updates. There were two
11749 1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
11750 NSView drawing will happen on the runloop cycle after a repaint. This provided a window
11751 for the layerSyncRunLoopObserver to fire and commit layer changes too early.
11753 Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
11754 and not commit layer changes in that case. We'll commit layer changes later when we
11757 2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
11758 by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
11759 synchronization and update disabling code in WebHTMLView for draws that are not to the screen.
11761 * WebView/WebHTMLView.mm:
11762 (-[WebHTMLView drawRect:]):
11763 * WebView/WebView.mm:
11764 (layerSyncRunLoopObserverCallBack):
11765 (-[WebView _scheduleCompositingLayerSync]):
11767 2010-04-30 Anders Carlsson <andersca@apple.com>
11769 Part of the previous part (forgot to save).
11771 * Plugins/WebNetscapePluginView.mm:
11772 (-[WebNetscapePluginView stopTimers]):
11773 (-[WebNetscapePluginView startTimers]):
11774 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
11775 (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
11776 (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
11777 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
11778 (-[WebNetscapePluginView unscheduleTimer:]):
11779 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
11780 (-[WebNetscapePluginView setVariable:forURL:value:length:]):
11782 2010-04-30 Anders Carlsson <andersca@apple.com>
11784 Reviewed by Darin Adler.
11786 Use C99 integer types in more places.
11788 * Plugins/WebNetscapePluginView.mm:
11791 2010-04-30 Anders Carlsson <andersca@apple.com>
11795 * Plugins/WebBaseNetscapePluginStream.h:
11796 * Plugins/WebBaseNetscapePluginStream.mm:
11797 (WebNetscapePluginStream::startStream):
11799 2010-04-30 Anders Carlsson <andersca@apple.com>
11801 Another 32-bit build fix.
11803 * Plugins/WebNetscapePluginView.mm:
11804 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
11806 2010-04-30 Anders Carlsson <andersca@apple.com>
11808 Fix 32-bit build (again).
11810 * Plugins/WebNetscapeContainerCheckContextInfo.h:
11811 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
11812 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
11813 (-[WebNetscapeContainerCheckContextInfo checkRequestID]):
11814 (-[WebNetscapeContainerCheckContextInfo callback]):
11815 * Plugins/WebNetscapePluginPackage.h:
11817 2010-04-30 Anders Carlsson <andersca@apple.com>
11821 * Plugins/WebNetscapeContainerCheckContextInfo.h:
11822 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
11823 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
11824 * Plugins/WebNetscapeContainerCheckPrivate.h:
11825 * Plugins/WebNetscapePluginPackage.mm:
11826 (functionPointerForTVector):
11827 * Plugins/WebNetscapePluginView.mm:
11828 (PluginTimer::PluginTimer):
11829 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
11830 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
11832 2010-04-30 Anders Carlsson <andersca@apple.com>
11834 Reviewed by Timothy Hatcher.
11836 Next step towards fixing
11838 https://bugs.webkit.org/show_bug.cgi?id=20784
11839 move npapi.h to C99 integer types
11841 Use the C99 types everywhere. The "old" types are still around but will be removed
11842 in a subsequent commit.
11844 * Plugins/WebBaseNetscapePluginStream.h:
11845 * Plugins/WebBaseNetscapePluginStream.mm:
11846 (WebNetscapePluginStream::deliverData):
11847 * Plugins/WebNetscapePluginView.h:
11848 * Plugins/WebNetscapePluginView.mm:
11849 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
11850 (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
11851 * Plugins/npapi.mm:
11854 (NPN_PostURLNotify):
11857 (NPN_ScheduleTimer):
11858 (NPN_UnscheduleTimer):
11859 (NPN_GetValueForURL):
11860 (NPN_SetValueForURL):
11861 (NPN_GetAuthenticationInfo):
11862 (WKN_CheckIfAllowedToLoadURL):
11863 (WKN_CancelCheckIfAllowedToLoadURL):
11865 2010-04-29 Anders Carlsson <andersca@apple.com>
11867 Reviewed by Dan Bernstein.
11870 https://bugs.webkit.org/show_bug.cgi?id=20784
11871 move npapi.h to C99 integer types.
11873 * MigrateHeaders.make:
11875 2010-04-28 Mike Thole <mthole@apple.com>
11877 Reviewed by David Kilzer.
11879 Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
11880 can be inspected before attempting to authenticate against it
11881 https://bugs.webkit.org/show_bug.cgi?id=38271
11883 * WebCoreSupport/WebFrameLoaderClient.h:
11884 * WebCoreSupport/WebFrameLoaderClient.mm:
11885 (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
11886 Added. If the resource load delegate implements the callback, use its answer. If it does
11887 not, then only send authentication challenges for pre-10.6 protection spaces, which matches
11888 CFNetwork's default behavior.
11889 * WebView/WebDelegateImplementationCaching.h:
11890 * WebView/WebDelegateImplementationCaching.mm:
11891 (CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
11892 * WebView/WebResourceLoadDelegatePrivate.h:
11893 Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
11894 * WebView/WebView.mm:
11895 (-[WebView _cacheResourceLoadDelegateImplementations]):
11897 2010-04-28 Simon Fraser <simon.fraser@apple.com>
11899 Reviewed by Sam Weinig.
11901 <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()
11903 Ensure that the WebView +initialize method initializes threading, so that things are correctly
11904 initialized when the first call into the WebKit framework is via a WebView class method.
11906 * WebView/WebView.mm:
11907 (+[WebView initialize]):
11909 2010-04-28 Darin Adler <darin@apple.com>
11911 Reviewed by Adele Peterson.
11913 REGRESSION: Autoscroll does not work in Mail messages
11914 https://bugs.webkit.org/show_bug.cgi?id=38267
11915 rdar://problem/7559799
11917 The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
11918 view had gotten broken in multiple ways. For some reason, a combination of bugs made it
11919 partly work until around r48064. This brings it back.
11921 * WebCoreSupport/WebChromeClient.mm:
11922 (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
11923 rather than the WebView itself. This logic may not be correct for the case where
11924 usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
11926 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
11928 Reviewed by Darin Adler and Eric Seidel.
11930 Add layoutTestController.setPrinting()
11931 https://bugs.webkit.org/show_bug.cgi?id=37203
11933 * Misc/WebCoreStatistics.h:
11934 * Misc/WebCoreStatistics.mm:
11935 (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
11937 2010-04-25 Sam Weinig <sam@webkit.org>
11939 Reviewed by Maciej Stachowiak.
11941 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
11942 Disentangle initializing the main thread from initializing threading
11944 Calls initializeMainThreadToProcessMainThread since there is no way to ensure
11945 that the initialize method will be called on the main thread.
11947 * Carbon/CarbonWindowAdapter.mm:
11948 (+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.
11949 * History/WebBackForwardList.mm:
11950 (+[WebBackForwardList initialize]): Ditto.
11951 * History/WebHistoryItem.mm:
11952 (+[WebHistoryItem initialize]): Ditto.
11953 * Misc/WebElementDictionary.mm:
11954 (+[WebElementDictionary initialize]): Ditto.
11955 * Misc/WebIconDatabase.mm:
11956 (+[WebIconDatabase initialize]): Ditto.
11957 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11958 (+[WebHostedNetscapePluginView initialize]): Ditto.
11959 * Plugins/WebBaseNetscapePluginView.mm:
11960 (+[WebBaseNetscapePluginView initialize]): Ditto.
11961 * Plugins/WebBasePluginPackage.mm:
11962 (+[WebBasePluginPackage initialize]): Ditto.
11963 * Plugins/WebNetscapePluginView.mm:
11964 (+[WebNetscapePluginView initialize]): Ditto.
11965 * WebCoreSupport/WebEditorClient.mm:
11966 (+[WebEditCommand initialize]): Ditto.
11967 * WebCoreSupport/WebFrameLoaderClient.mm:
11968 (+[WebFramePolicyListener initialize]): Ditto.
11969 * WebView/WebArchive.mm:
11970 (+[WebArchivePrivate initialize]): Ditto.
11971 * WebView/WebDataSource.mm:
11972 (+[WebDataSourcePrivate initialize]): Ditto.
11973 * WebView/WebHTMLView.mm:
11974 (+[WebHTMLViewPrivate initialize]): Ditto.
11975 (+[WebHTMLView initialize]): Ditto.
11976 * WebView/WebResource.mm:
11977 (+[WebResourcePrivate initialize]): Ditto.
11978 * WebView/WebTextIterator.mm:
11979 (+[WebTextIteratorPrivate initialize]): Ditto.
11980 * WebView/WebView.mm:
11981 * WebView/WebViewData.mm: Ditto.
11982 (+[WebViewPrivate initialize]): Ditto.
11984 2010-04-24 Dan Bernstein <mitz@apple.com>
11986 Reviewed by Darin Adler.
11988 <rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
11989 https://bugs.webkit.org/show_bug.cgi?id=38085
11991 WebView was calling -_webView in a few places where it should have just used itself. It never
11992 makes sense for WebView to call -_webView on itself, and these calls look like they were copied
11993 from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
11996 * WebView/WebView.mm:
11997 (-[WebView drawSingleRect:]): Replaced [self _webView] with self.
11998 (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
11999 with _private->preferences.
12000 (-[WebView _canShowMIMEType:]): Ditto.
12002 2010-04-23 Simon Fraser <simon.fraser@apple.com>
12004 Reviewed by Anders Carlsson.
12006 <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint
12008 When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
12009 NPPrint with a GWorldPtr, since Flash prefers the CGContext path.
12011 * Plugins/WebNetscapePluginView.mm:
12012 (-[WebNetscapePluginView drawRect:]):
12014 2010-04-22 David Kilzer <ddkilzer@apple.com>
12016 <http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()
12018 Reviewed by Timothy Hatcher.
12020 Every other Objective-C class that calls
12021 WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
12022 JSC::initializeThreading(). The WebTextIteratorPrivate class
12023 was the only one missing this call.
12025 * WebView/WebTextIterator.mm:
12026 (+[WebTextIteratorPrivate initialize]): Added call to
12027 JSC::initializeThreading().
12029 2010-04-22 Alexey Proskuryakov <ap@apple.com>
12031 Rubber-stamped by Mark Rowe.
12033 <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
12035 Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
12036 for now. Clients rely on the old behavior, so a fix that changes it will need to account for
12039 * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
12040 instead of baseURL again.
12042 2010-04-22 Dave Moore <davemoore@chromium.org>
12044 Reviewed by Dimitri Glazkov.
12046 Added notification when the favicons for a page are changed
12048 The Document object will notify the frame loader, which will
12049 notify the client. Implementations of FrameLoaderClient will
12050 have to add one method; dispatchDidChangeIcons().
12052 https://bugs.webkit.org/show_bug.cgi?id=33812
12054 * WebCoreSupport/WebFrameLoaderClient.h:
12055 * WebCoreSupport/WebFrameLoaderClient.mm:
12056 (WebFrameLoaderClient::dispatchDidChangeIcons):
12058 2010-04-22 Adam Barth <abarth@webkit.org>
12060 Unreviewed, rolling out r58069.
12061 http://trac.webkit.org/changeset/58069
12062 https://bugs.webkit.org/show_bug.cgi?id=27751
12064 Broke compile on Windows.
12066 * WebView/WebPreferenceKeysPrivate.h:
12067 * WebView/WebPreferences.mm:
12068 (+[WebPreferences initialize]):
12069 * WebView/WebPreferencesPrivate.h:
12070 * WebView/WebView.mm:
12071 (-[WebView _preferencesChangedNotification:]):
12073 2010-04-22 Abhishek Arya <inferno@chromium.org>
12075 Reviewed by Adam Barth.
12077 Add support for controlling clipboard access from javascript.
12078 Clipboard access from javascript is disabled by default.
12079 https://bugs.webkit.org/show_bug.cgi?id=27751
12081 * WebView/WebPreferenceKeysPrivate.h:
12082 * WebView/WebPreferences.mm:
12083 (+[WebPreferences initialize]):
12084 (-[WebPreferences javaScriptCanAccessClipboard]):
12085 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
12086 * WebView/WebPreferencesPrivate.h:
12087 * WebView/WebView.mm:
12088 (-[WebView _preferencesChangedNotification:]):
12090 2010-04-21 Alexey Proskuryakov <ap@apple.com>
12092 Reviewed by Shinichiro Hamaji.
12094 https://bugs.webkit.org/show_bug.cgi?id=37964
12095 Fix a typo in comments - Korean encoding name is windows-949, not windows-939
12097 * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
12099 2010-04-21 Mark Rowe <mrowe@apple.com>
12103 * Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
12105 2010-04-21 Mark Rowe <mrowe@apple.com>
12107 Reviewed by Eric Carlson.
12109 <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
12111 Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
12112 used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
12113 containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).
12115 The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
12116 NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
12117 instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
12118 is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
12119 instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
12120 pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
12121 while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
12122 no other references to keep the object alive.
12124 We work around this bug by patching the following two messages:
12126 1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
12127 2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]
12129 Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
12130 modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.
12132 Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).
12134 These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
12135 instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.
12137 * Plugins/WebPluginController.mm:
12138 (-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
12139 install our workaround if it is.
12140 (isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
12141 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
12142 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
12143 delegate if this NSAlert belongs to the Flip4Mac plug-in.
12144 (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
12145 first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
12146 the method we're interested in. In that case we want to bail out before patching any methods.
12148 2010-04-20 Mark Rowe <mrowe@apple.com>
12150 Reviewed by Maciej Stachowiak.
12152 <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
12154 An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
12155 NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
12156 in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
12157 could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.
12159 * Plugins/Hosted/NetscapePluginHostProxy.mm:
12160 (WKPCInvalidateRect):
12161 (WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
12162 is already processing requests. This ensures that there will be no plug-in code on the stack when
12163 the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
12164 a modal dialog is displayed.
12166 2010-04-20 Adam Barth <abarth@webkit.org>
12168 Reviewed by Eric Seidel.
12170 Factor DocumentWriter out of FrameLoader
12171 https://bugs.webkit.org/show_bug.cgi?id=37175
12173 Update these callsites because the method moved to DocumentWriter.
12175 * WebView/WebFrame.mm:
12176 (-[WebFrame _canProvideDocumentSource]):
12177 (-[WebFrame _receivedData:textEncodingName:]):
12179 2010-04-20 Kent Tamura <tkent@chromium.org>
12181 Reviewed by Darin Adler.
12183 Change a parameter type of chooseIconForFiles()
12184 https://bugs.webkit.org/show_bug.cgi?id=37504
12186 * WebCoreSupport/WebChromeClient.h:
12187 * WebCoreSupport/WebChromeClient.mm:
12188 (WebChromeClient::chooseIconForFiles):
12190 2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
12192 Unreviewed, rolling out r57892.
12193 http://trac.webkit.org/changeset/57892
12194 https://bugs.webkit.org/show_bug.cgi?id=37864
12196 Caused an assertion in Mac builds (Requested by smfr on
12199 * WebView/WebFrame.mm:
12200 (-[WebFrame _getVisibleRect:]):
12201 * WebView/WebFrameView.mm:
12202 (-[WebFrameView _install]):
12204 2010-04-20 Simon Fraser <simon.fraser@apple.com>
12206 Reviewed by Dan Bernstein.
12208 Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
12209 https://bugs.webkit.org/show_bug.cgi?id=37741
12211 Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
12212 RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
12214 * WebView/WebFrame.mm:
12215 (-[WebFrame _getVisibleRect:]):
12216 * WebView/WebFrameView.mm:
12217 (-[WebFrameView _install]):
12219 2010-04-19 Dan Bernstein <mitz@apple.com>
12221 Reviewed by Sam Weinig.
12223 Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
12224 printing width as SPI.
12226 * WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
12228 2010-04-15 Gavin Barraclough <barraclough@apple.com>
12230 Reviewed by Sam Weinig & Oliver Hunt.
12232 https://bugs.webkit.org/show_bug.cgi?id=37675
12233 Remove casts/constructors to/from JSC::UString type from WebCore::String
12235 WebCore's strings should not know about JSC::UString, this should be abstracted
12236 away in the bindings. Add explicit conversion methods rather than relying on
12237 overloaded cast operators / constructors being implicitly called.
12239 This patch only changes the class String, once this has landed StringImpl, and
12240 hopefully AtomicString too, should follow suit.
12242 * Plugins/Hosted/NetscapePluginHostProxy.mm:
12243 (identifierFromIdentifierRep):
12244 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12245 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
12246 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
12247 * Plugins/Hosted/ProxyInstance.mm:
12248 (WebKit::ProxyInstance::getPropertyNames):
12249 * WebView/WebFrame.mm:
12250 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
12251 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
12252 * WebView/WebScriptDebugDelegate.mm:
12253 (-[WebScriptCallFrame evaluateWebScript:]):
12254 * WebView/WebScriptDebugger.mm:
12256 * WebView/WebView.mm:
12257 (aeDescFromJSValue):
12259 2010-04-16 Dan Bernstein <mitz@apple.com>
12261 Reviewed by John Sullivan.
12263 Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
12264 printing width as SPI.
12266 * WebView/WebHTMLView.mm:
12267 Replaced two macros with constants.
12268 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
12269 (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
12270 * WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and
12271 _WebHTMLViewPrintingMaximumShrinkFactor.
12273 2010-04-15 Mark Rowe <mrowe@apple.com>
12275 Reviewed by Sam Weinig.
12277 <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.
12279 * WebView/WebDynamicScrollBarsView.h:
12281 2010-04-15 Adam Roben <aroben@apple.com>
12283 Export WebUserContentURLPattern from WebKit
12285 Rubber-stamped by Mark Rowe.
12289 2010-04-15 Dan Bernstein <mitz@apple.com>
12291 Reviewed by Simon Fraser.
12293 Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
12294 without intermediate calls -[WebHTMLView _endPrintMode].
12296 * WebView/WebHTMLView.mm:
12297 (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
12299 2010-04-15 Adam Roben <aroben@apple.com>
12301 Expose UserContentURLPattern as WebKit SPI
12303 Fixes <http://webkit.org/b/37354>.
12305 Reviewed by Tim Hatcher.
12307 * Misc/WebUserContentURLPattern.h: Added.
12309 * Misc/WebUserContentURLPattern.mm: Added.
12310 (-[WebUserContentURLPattern initWithPatternString:]): Initialize
12311 _private and then parse the passed-in string into a
12312 UserContentURLPattern.
12313 (-[WebUserContentURLPattern dealloc]): Release _private.
12315 (-[WebUserContentURLPattern isValid]):
12316 (-[WebUserContentURLPattern scheme]):
12317 (-[WebUserContentURLPattern host]):
12318 (-[WebUserContentURLPattern matchesSubdomains]):
12319 Call through to UserContentURLPattern.
12321 2010-04-13 Geoffrey Garen <ggaren@apple.com>
12323 Reviewed by Oliver Hunt.
12325 Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
12326 its own lifetime, so a DOMWrapperWorld's controller can throw away
12327 its wrappers even before its refcount reaches 0.
12329 * WebView/WebScriptWorld.h:
12330 * WebView/WebScriptWorld.mm:
12331 (-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.
12333 2010-04-12 Timothy Hatcher <timothy@apple.com>
12335 SecurityOrigin needs a way to remove individual OriginAccessEntries
12336 https://bugs.webkit.org/show_bug.cgi?id=37449
12338 Reviewed by Dave Hyatt.
12340 * WebView/WebView.mm:
12341 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
12342 Call SecurityOrigin::removeOriginAccessWhitelistEntry.
12343 * WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.
12345 2010-04-13 Timothy Hatcher <timothy@apple.com>
12347 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
12348 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
12350 SecurityOrigin needs a way to remove individual OriginAccessEntries
12351 https://bugs.webkit.org/show_bug.cgi?id=37449
12353 Reviewed by Dave Hyatt.
12355 * WebView/WebView.mm:
12356 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
12357 (+[WebView _resetOriginAccessWhitelists]):
12358 * WebView/WebViewPrivate.h:
12360 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
12362 Unreviewed, rolling out r57468.
12363 http://trac.webkit.org/changeset/57468
12364 https://bugs.webkit.org/show_bug.cgi?id=37433
12366 Broke the world... Must have applied the patch wrong
12367 (Requested by abarth on #webkit).
12369 * WebView/WebFrame.mm:
12370 (-[WebFrame _canProvideDocumentSource]):
12371 (-[WebFrame _receivedData:textEncodingName:]):
12373 2010-04-11 Adam Barth <abarth@webkit.org>
12375 Reviewed by Eric Seidel.
12377 Factor DocumentWriter out of FrameLoader
12378 https://bugs.webkit.org/show_bug.cgi?id=37175
12380 Update these callsites because the method moved to DocumentWriter.
12382 * WebView/WebFrame.mm:
12383 (-[WebFrame _canProvideDocumentSource]):
12384 (-[WebFrame _receivedData:textEncodingName:]):
12386 2010-04-10 Mark Rowe <mrowe@apple.com>
12388 Reviewed by Dan Bernstein.
12390 <rdar://problem/7845305> Further adoption of formal protocols for delegates.
12392 Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.
12394 * Misc/EmptyProtocolDefinitions.h: Removed.
12395 * Misc/WebDownload.mm:
12398 2010-04-09 Jer Noble <jer.noble@apple.com>
12400 Reviewed by Darin Adler.
12402 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
12403 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
12405 * WebView/WebVideoFullscreenController.mm:
12406 (-[WebVideoFullscreenController windowDidLoad]):
12407 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
12409 2010-04-09 Alexey Proskuryakov <ap@apple.com>
12411 Reviewed by Maciej Stachowiak.
12413 https://bugs.webkit.org/show_bug.cgi?id=24572
12414 XMLHttpRequest.statusText returns always "OK" on Mac
12416 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
12418 2010-04-09 Eric Seidel <eric@webkit.org>
12420 Unreviewed, rolling out r57343.
12421 http://trac.webkit.org/changeset/57343
12422 https://bugs.webkit.org/show_bug.cgi?id=37311
12424 Broke Tiger compile.
12426 * WebView/WebVideoFullscreenController.mm:
12427 (-[WebVideoFullscreenController windowDidLoad]):
12428 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
12430 2010-04-09 Dan Bernstein <mitz@apple.com>
12432 Reviewed by Darin Adler.
12434 <rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window
12436 * WebView/WebDynamicScrollBarsView.mm:
12437 (-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.
12439 2010-04-09 Jer Noble <jer.noble@apple.com>
12441 Reviewed by Darin Adler.
12443 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
12444 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
12446 * WebView/WebVideoFullscreenController.mm:
12447 (-[WebVideoFullscreenController windowDidLoad]):
12448 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
12450 2010-04-08 Mark Rowe <mrowe@apple.com>
12452 Reviewed by John Sullivan.
12454 <rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
12456 In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
12457 This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
12458 size and layout of their subclasses is baked in at compile time. This results in instances
12459 being allocated that are smaller than the new code expects, and may result in the new instance
12460 variables sharing the same memory space as any instance variables that the subclass defines.
12462 We can avoid this problem by having the class contain only a single member that acts as a pointer
12463 to a heap-allocated structure that acts as storage for the real instance variables. This makes
12464 us free to add instance variables in the future without risk of changing the size of the class.
12465 To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
12466 are able to run against older versions of WebKit we pad the class out to its previous size. This
12467 results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
12468 with both versions of the code.
12470 This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
12471 instance variables of its superclass. However, this is a private header and no known subclasses
12472 of WebDynamicScrollBarsView access superclass instance variables in this fashion.
12474 * WebView/WebDynamicScrollBarsView.h:
12475 * WebView/WebDynamicScrollBarsView.mm:
12476 (-[WebDynamicScrollBarsView initWithFrame:]):
12477 (-[WebDynamicScrollBarsView dealloc]):
12478 (-[WebDynamicScrollBarsView finalize]):
12479 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
12480 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
12481 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
12482 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
12483 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
12484 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
12485 (-[WebDynamicScrollBarsView contentViewFrame]):
12486 (-[WebDynamicScrollBarsView tile]):
12487 (-[WebDynamicScrollBarsView setSuppressLayout:]):
12488 (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
12489 (-[WebDynamicScrollBarsView updateScrollers]):
12490 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
12491 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
12492 (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
12493 (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
12494 (-[WebDynamicScrollBarsView horizontalScrollingMode]):
12495 (-[WebDynamicScrollBarsView verticalScrollingMode]):
12496 (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
12497 (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
12498 (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
12499 (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
12500 (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
12501 (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
12502 (-[WebDynamicScrollBarsView scrollWheel:]):
12504 2010-04-07 David Hyatt <hyatt@apple.com>
12506 Reviewed by Oliver Hunt.
12508 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
12510 Add SPI so that layout tests can access computed style including :visited information.
12512 * WebView/WebRenderNode.mm:
12514 * WebView/WebView.mm:
12515 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
12516 * WebView/WebViewInternal.h:
12517 * WebView/WebViewPrivate.h:
12519 2010-04-07 Dan Bernstein <mitz@apple.com>
12521 Reviewed by Adele Peterson.
12523 Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
12524 https://bugs.webkit.org/show_bug.cgi?id=37246
12526 * Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
12527 * Misc/WebNSPrintOperationExtras.m:
12528 (-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
12530 (-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
12532 * WebView/WebHTMLView.mm:
12533 (-[WebHTMLView _isInPrintMode]): Added this accessor.
12534 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
12535 computes the layout widths and enters printing mode into this private method.
12536 (-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
12537 (-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
12538 (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
12540 (-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
12541 (-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
12542 -[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
12544 (-[WebHTMLView beginDocument]): Updated for rename.
12545 (-[WebHTMLView endDocument]): Ditto.
12546 * WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
12547 -_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
12549 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
12551 Reviewed by Yury Semikhatsky.
12553 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
12554 https://bugs.webkit.org/show_bug.cgi?id=36949
12556 * WebCoreSupport/WebFrameLoaderClient.h:
12557 * WebCoreSupport/WebFrameLoaderClient.mm:
12559 2010-04-06 Dan Bernstein <mitz@apple.com>
12561 Tiger build fix after r57184.
12563 * WebView/WebHTMLViewPrivate.h:
12565 2010-04-06 Dan Bernstein <mitz@apple.com>
12567 Tiger build fix after r57184.
12569 * WebView/WebHTMLViewPrivate.h:
12571 2010-04-06 Adam Barth <abarth@webkit.org>
12575 Speculative build fix for Tiger.
12577 * WebView/WebHTMLViewPrivate.h:
12579 2010-04-06 Dan Bernstein <mitz@apple.com>
12581 Reviewed by Sam Weinig and Anders Carlsson.
12583 Expose WebHTMLView’s page breaking logic as SPI.
12585 * WebView/WebHTMLView.mm:
12586 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
12587 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
12588 * WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
12590 2010-04-06 Mark Rowe <mrowe@apple.com>
12592 Add an #if in order to make Tiger happy.
12594 * WebView/WebViewData.mm:
12595 (-[WebViewPrivate init]):
12597 2010-04-06 Mark Rowe <mrowe@apple.com>
12601 * WebView/WebViewData.mm:
12602 (-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
12604 2010-04-05 Mark Rowe <mrowe@apple.com>
12606 Reviewed by Adele Peterson.
12608 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
12609 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
12611 * WebView/WebHTMLView.mm:
12612 (-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
12613 manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
12615 2010-04-05 Alexey Proskuryakov <ap@apple.com>
12617 Reviewed by Darin Adler.
12619 https://bugs.webkit.org/show_bug.cgi?id=37111
12620 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
12622 * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed _pluginDied - it was only used
12623 for drawing replacement icon, and this information is now in WebCore.
12624 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12625 (-[WebHostedNetscapePluginView pluginHostDied]): Tell RenderEmbeddedObject that the plug-in
12627 (-[WebHostedNetscapePluginView drawRect:]): Removed the case for crashed plug-in host. It is
12628 handled by WebCore now.
12630 * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory crashedPluginText]): Added a string
12631 for plug-in failure.
12633 2010-04-03 yael aharon <yael.aharon@nokia.com>
12635 Reviewed by Darin Adler.
12637 Enable HTMLProgressElement for Safari on OSX
12638 https://bugs.webkit.org/show_bug.cgi?id=36961
12640 * Configurations/FeatureDefines.xcconfig:
12642 2010-04-02 Jer Noble <jer.noble@apple.com>
12644 Reviewed by Eric Carlson.
12646 https://bugs.webkit.org/show_bug.cgi?id=36624
12647 Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.
12649 * WebCoreSupport/WebSystemInterface.m:
12650 (InitWebCoreSystemInterface):
12652 2010-04-02 Alexey Proskuryakov <ap@apple.com>
12654 Reviewed by Darin Adler.
12656 https://bugs.webkit.org/show_bug.cgi?id=37043
12657 Java regression tests spam stderr about being unable to set status message
12659 With this change, there is still spam about "Attempt to access JavaScript from destroyed
12660 applet, type 9." I haven't investigated if that indicates a problem or not.
12662 * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
12663 Removed check for _documentView. We don't seem to care.
12665 2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
12667 Reviewed by Dmitry Titov.
12669 Add FileThread for async file operation support in FileReader and FileWriter
12670 https://bugs.webkit.org/show_bug.cgi?id=36896
12672 Add FILE_READER or FILE_WRITER feature defines.
12674 * Configurations/FeatureDefines.xcconfig:
12676 2010-04-01 Ada Chan <adachan@apple.com>
12678 Reviewed by Darin Adler.
12680 Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
12681 Ditto for WebDatabaseManager::deleteDatabase().
12683 https://bugs.webkit.org/show_bug.cgi?id=36988
12685 * Storage/WebDatabaseManager.mm:
12686 (-[WebDatabaseManager deleteOrigin:]):
12687 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
12688 * Storage/WebDatabaseManagerPrivate.h:
12690 2010-04-01 Alexey Proskuryakov <ap@apple.com>
12692 Reviewed by Darin Adler.
12694 https://bugs.webkit.org/show_bug.cgi?id=36976
12695 <rdar://problem/7817498>
12696 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
12698 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12699 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't
12700 there to catch potential future attempts to store empty/deleted values before these happen -
12701 it's actually wrong to try to look up these values. Added an early return.
12702 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
12704 2010-04-01 Chris Marrin <cmarrin@apple.com>
12706 Reviewed by Simon Fraser.
12708 Added layerTreeAsText function to DRT (for Mac)
12709 https://bugs.webkit.org/show_bug.cgi?id=36782
12711 This is the WebKit side for Mac. It plumbs the
12712 call from WebCore to DRT.
12714 * WebView/WebFrame.mm:WebKit (Mac) side of plumbing
12715 (-[WebFrame _layerTreeAsText]):
12716 * WebView/WebFramePrivate.h:
12718 2010-04-01 Alexey Proskuryakov <ap@apple.com>
12720 Reviewed by Oliver Hunt.
12722 https://bugs.webkit.org/show_bug.cgi?id=36976
12723 <rdar://problem/7817498>
12724 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
12726 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12727 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(),
12728 because the latter fails with an assertion when looking up 0 or -1.
12729 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected
12730 object IDs coming from plug-in host.
12732 2010-03-31 Chris Fleizach <cfleizach@apple.com>
12734 Reviewed by Darin Adler.
12736 Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
12737 https://bugs.webkit.org/show_bug.cgi?id=36845
12739 Provide a way through WebKit to set an accessible label that describes the web area.
12741 * WebView/WebFrame.mm:
12742 (-[WebFrame setAccessibleName:]):
12743 * WebView/WebFramePrivate.h:
12745 2010-03-31 Marcus Bulach <bulach@chromium.org>
12747 Reviewed by Jeremy Orlow.
12749 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
12750 https://bugs.webkit.org/show_bug.cgi?id=35031
12752 * WebCoreSupport/WebChromeClient.h:
12753 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
12755 2010-03-30 Gavin Barraclough <barraclough@apple.com>
12757 Rubber stamped by Sam Weinig.
12759 https://bugs.webkit.org/show_bug.cgi?id=36866
12760 Move CString to WTF
12762 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12763 (WebKit::NetscapePluginInstanceProxy::getCookies):
12764 (WebKit::NetscapePluginInstanceProxy::getProxy):
12765 (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
12766 (WebKit::NetscapePluginInstanceProxy::resolveURL):
12767 * Plugins/WebBaseNetscapePluginView.h:
12768 * Plugins/WebBaseNetscapePluginView.mm:
12769 * Plugins/WebNetscapePluginView.mm:
12770 (-[WebNetscapePluginView resolveURL:forTarget:]):
12772 2010-03-30 John Sullivan <sullivan@apple.com>
12774 Reviewed by Dan Bernstein.
12776 https://bugs.webkit.org/show_bug.cgi?id=36848
12777 <rdar://problem/7362913>
12778 Menu items appropriate only for rich-content editing can appear in plain-text contexts
12780 * WebView/WebHTMLView.mm:
12781 (-[WebHTMLView validRequestorForSendType:returnType:]):
12782 Don't return self for non-string content if _canEditRichly is false.
12784 2010-03-29 Alexey Proskuryakov <ap@apple.com>
12786 Reviewed by Darin Adler.
12788 https://bugs.webkit.org/show_bug.cgi?id=36791
12789 Add assertions for instance proxy validity
12791 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
12792 pointer to one across complicated function calls, relying on the caller to protect the
12795 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
12796 (WebKit::NetscapePluginInstanceProxy::renderContextID):
12797 (WebKit::NetscapePluginInstanceProxy::pluginView):
12798 (WebKit::NetscapePluginInstanceProxy::hostProxy):
12800 2010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
12802 Reviewed by David Kilzer.
12804 Explicit guards for ENABLE_GEOLOCATION
12805 https://bugs.webkit.org/show_bug.cgi?id=25756
12807 * WebCoreSupport/WebGeolocationMock.mm:
12808 (-[WebGeolocationMock setError:code:]): Make the body conditional on
12809 ENABLE(GEOLOCATION)
12810 (-[WebGeolocationMock setPosition:]): Ditto.
12812 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
12814 Reviewed by Antti Koivisto.
12816 Change method name due to it dealing with both flattening
12817 of frame sets and inner frames.
12819 * WebView/WebPreferenceKeysPrivate.h:
12820 * WebView/WebPreferences.mm:
12821 (+[WebPreferences initialize]):
12822 (-[WebPreferences isFrameFlatteningEnabled]):
12823 (-[WebPreferences setFrameFlatteningEnabled:]):
12824 * WebView/WebPreferencesPrivate.h:
12825 * WebView/WebView.mm:
12826 (-[WebView _preferencesChangedNotification:]):
12828 2010-03-27 Darin Adler <darin@apple.com>
12830 * Misc/WebNSFileManagerExtras.m:
12831 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
12832 Removed stray "!". How did that get in there?
12834 2010-03-27 Darin Adler <darin@apple.com>
12836 Reviewed by Mark Rowe.
12838 WebKit NSFileManager methods don't handle broken symlinks correctly.
12839 Part of <rdar://problem/7574046>.
12841 * Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
12842 * Misc/WebNSFileManagerExtras.m: Removed unused methods.
12843 (fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
12844 to treat a broken symlink as a file that does indeed exist.
12845 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.
12847 2010-03-25 Alexey Proskuryakov <ap@apple.com>
12849 Reviewed by Mark Rowe.
12851 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in
12852 a way that works in a function that doesn't have a pluginID argument for some reason.
12854 2010-03-25 Simon Fraser <simon.fraser@apple.com>
12856 Build fix: no review.
12858 Another c_str() -> data().
12860 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12861 (WebKit::NetscapePluginInstanceProxy::enumerate):
12863 2010-03-25 Alexey Proskuryakov <ap@apple.com>
12865 Reviewed by Mark Rowe.
12867 Correctness fix after r56493.
12869 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update
12870 our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees
12871 that the host proxy won't go away while the open panel is up.
12873 2010-03-24 Mark Rowe <mrowe@apple.com>
12875 Build fix after r56474.
12877 * Plugins/Hosted/NetscapePluginHostProxy.mm:
12878 (WKPCRunSyncOpenPanel):
12880 2010-03-24 Alexey Proskuryakov <ap@apple.com>
12882 Reviewed by Anders Carlsson.
12884 https://bugs.webkit.org/show_bug.cgi?id=36563
12885 A plug-in makes Safari crash on http://www.itscodingtime.com/
12887 * Plugins/Hosted/NetscapePluginHostProxy.h:
12888 (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
12889 beautifully systemic, but helped catch a bug, and may help catch more.
12890 (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
12891 (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
12892 static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
12894 * Plugins/Hosted/NetscapePluginHostProxy.mm:
12895 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
12897 (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
12898 after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
12899 wasn't much time for some other object to be allocated at this address.
12900 (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
12901 (WKPCInvoke): Ditto.
12902 (WKPCInvokeDefault): Ditto.
12903 (WKPCGetProperty): Ditto.
12904 (WKPCSetProperty): Ditto.
12905 (WKPCRemoveProperty): Ditto.
12906 (WKPCHasProperty): Ditto.
12907 (WKPCHasMethod): Ditto.
12908 (WKPCEnumerate): Ditto.
12909 (WKPCRunSyncOpenPanel): Ditto.
12911 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12912 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the
12913 "event loop" if host proxy went away while processing a request.
12915 2010-03-24 Hayato Ito <hayato@chromium.org>
12917 Reviewed by Shinichiro Hamaji.
12919 Refactor computePageRects so that Mac can make use of it.
12920 https://bugs.webkit.org/show_bug.cgi?id=36159
12922 Refactoring only, so no new tests.
12924 * WebView/WebFrame.mm:
12925 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
12927 2010-03-24 Kent Tamura <tkent@chromium.org>
12929 Reviewed by Darin Adler.
12931 Make Icon::createIconForFiles() optional.
12932 https://bugs.webkit.org/show_bug.cgi?id=35072
12934 - Rename iconForFiles() to chooseIconForFiles().
12935 - Call Icon::createIconForFiles() from chooseIconForFiles().
12937 * WebCoreSupport/WebChromeClient.h:
12938 * WebCoreSupport/WebChromeClient.mm:
12939 (WebChromeClient::chooseIconForFiles):
12941 2010-03-23 Dan Bernstein <mitz@apple.com>
12943 Reverted accidental change from r56429.
12945 * WebCoreSupport/WebContextMenuClient.mm:
12946 (WebContextMenuClient::getCustomMenuFromDefaultItems):
12948 2010-03-23 Dan Bernstein <mitz@apple.com>
12950 Reviewed by John Sullivan.
12953 <rdar://problem/7197736> Plug-in clip rect does not update when overflow
12955 https://bugs.webkit.org/show_bug.cgi?id=36479.
12957 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12958 (-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
12959 WKSyncSurfaceToView().
12960 * Plugins/WebBaseNetscapePluginView.h:
12961 * Plugins/WebBaseNetscapePluginView.mm:
12962 (-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
12963 (-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
12965 2010-03-22 Kevin Decker <kdecker@apple.com>
12967 Reviewed by Simon Fraser.
12969 https://bugs.webkit.org/show_bug.cgi?id=36328
12971 This patch entirely WebNullPluginView.
12973 * Plugins/WebNetscapePluginView.mm:
12974 * Plugins/WebNullPluginView.h: Removed.
12975 * Plugins/WebNullPluginView.mm: Removed.
12976 * Resources/nullplugin.tiff: Removed.
12977 * WebCoreSupport/WebFrameLoaderClient.mm:
12978 (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
12980 2010-03-22 Alexey Proskuryakov <ap@apple.com>
12982 Reviewed by John Sullivan.
12984 https://bugs.webkit.org/show_bug.cgi?id=36455
12985 Make WebKit more resistant against plug-in crashes
12987 No tests, because crashing on build bots isn't good, even if it's only helper processes
12990 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
12991 (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function
12992 needs it after waiting for reply. Some callers used to do this, but not all, and we really
12993 shouldn't depend on callers here.
12995 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12996 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy,
12997 because this function doesn't use it after waiting for reply.
12998 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
13000 * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy
13001 null check for another code path.
13003 2010-03-22 Kevin Decker <kdecker@apple.com>
13005 Reviewed by John Sullivan.
13007 https://bugs.webkit.org/show_bug.cgi?id=36328
13009 * WebCoreSupport/WebViewFactory.mm:
13010 (-[WebViewFactory missingPluginText]): Added.
13012 2010-03-18 Alexey Proskuryakov <ap@apple.com>
13014 Reviewed by Darin Adler.
13016 https://bugs.webkit.org/show_bug.cgi?id=36337
13017 Log an error when an OOP plug-in sends an unknown object id
13019 Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
13020 temporary or redundant.
13022 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13023 (WebKit::NetscapePluginInstanceProxy::evaluate):
13024 (WebKit::NetscapePluginInstanceProxy::invoke):
13025 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
13026 (WebKit::NetscapePluginInstanceProxy::construct):
13027 (WebKit::NetscapePluginInstanceProxy::getProperty):
13028 (WebKit::NetscapePluginInstanceProxy::setProperty):
13029 (WebKit::NetscapePluginInstanceProxy::removeProperty):
13030 (WebKit::NetscapePluginInstanceProxy::hasProperty):
13031 (WebKit::NetscapePluginInstanceProxy::hasMethod):
13032 (WebKit::NetscapePluginInstanceProxy::enumerate):
13034 2010-03-16 Alexey Proskuryakov <ap@apple.com>
13036 Reviewed by Darin Adler.
13038 https://bugs.webkit.org/show_bug.cgi?id=36184
13039 YouTube video resizing doesn't work with OOP plug-ins
13041 Test: plugins/resize-from-plugin.html
13043 We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
13044 whether the size has changed. But sync and async messages are not necessarily delivered in
13045 order - plug-in host listens only to the former while waiting for a response to a message it
13046 sent (a call to invoke() in this case).
13048 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
13049 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13050 (WebKit::NetscapePluginInstanceProxy::resize):
13051 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13052 (-[WebHostedNetscapePluginView updateAndSetWindow]):
13054 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
13056 Reviewed by Pavel Feldman.
13058 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
13060 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
13061 https://bugs.webkit.org/show_bug.cgi?id=35036
13063 * WebCoreSupport/WebInspectorClient.h:
13064 * WebCoreSupport/WebInspectorClient.mm:
13065 (WebInspectorClient::WebInspectorClient):
13066 (WebInspectorClient::inspectorDestroyed):
13067 (WebInspectorClient::openInspectorFrontend):
13068 (WebInspectorClient::highlight):
13069 (WebInspectorClient::hideHighlight):
13070 (WebInspectorFrontendClient::WebInspectorFrontendClient):
13071 (WebInspectorFrontendClient::frontendLoaded):
13072 (WebInspectorFrontendClient::localizedStringsURL):
13073 (WebInspectorFrontendClient::hiddenPanels):
13074 (WebInspectorFrontendClient::bringToFront):
13075 (WebInspectorFrontendClient::closeWindow):
13076 (WebInspectorFrontendClient::attachWindow):
13077 (WebInspectorFrontendClient::detachWindow):
13078 (WebInspectorFrontendClient::setAttachedWindowHeight):
13079 (WebInspectorFrontendClient::inspectedURLChanged):
13080 (WebInspectorFrontendClient::updateWindowTitle):
13081 (-[WebInspectorWindowController dealloc]):
13082 (-[WebInspectorWindowController windowShouldClose:]):
13083 (-[WebInspectorWindowController close]):
13084 (-[WebInspectorWindowController showWindow:]):
13085 (-[WebInspectorWindowController attach]):
13086 (-[WebInspectorWindowController detach]):
13087 (-[WebInspectorWindowController attached]):
13088 (-[WebInspectorWindowController setFrontendClient:]):
13089 (-[WebInspectorWindowController destroyInspectorView]):
13090 (-[WebNodeHighlighter initWithInspectedWebView:]):
13091 (-[WebNodeHighlighter dealloc]):
13092 (-[WebNodeHighlighter highlightNode:]):
13093 (-[WebNodeHighlighter hideHighlight]):
13094 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
13095 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
13096 * WebInspector/WebInspector.mm:
13097 (-[WebInspector attach:]):
13098 (-[WebInspector detach:]):
13100 2010-03-15 Andy Estes <aestes@apple.com>
13102 Reviewed by John Sullivan.
13104 Updated call to WKGetWheelEventDeltas() to match new method signature.
13106 https://bugs.webkit.org/show_bug.cgi?id=29601
13107 <rdar://problem/7453254>
13109 * WebView/WebDynamicScrollBarsView.mm:
13110 (-[WebDynamicScrollBarsView scrollWheel:]):
13112 2010-03-15 John Sullivan <sullivan@apple.com>
13114 Reviewed by Adam Roben.
13116 -[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
13117 <https://bugs.webkit.org/show_bug.cgi?id=36125>
13119 * WebView/WebDynamicScrollBarsView.h:
13120 Added instance variables horizontalScrollingAllowedButScrollerHidden and
13121 verticalScrollingAllowedButScrollerHidden. Renamed instance variables
13122 hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
13123 Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
13126 * WebView/WebDynamicScrollBarsView.mm:
13127 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
13128 Updated for instance variable renaming.
13129 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
13131 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
13132 New method, returns YES if the scroller is showing or the only reason that the scroller
13133 is not showing is that setAlwaysHideHorizontalScrolling has been called.
13134 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
13135 New method, returns YES if the scroller is showing or the only reason that the scroller
13136 is not showing is that setAlwaysHideVerticalScrolling has been called.
13137 (-[WebDynamicScrollBarsView updateScrollers]):
13138 Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
13139 and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
13140 in the early-return code path, to avoid taking it into account twice in the regular code path.
13142 * WebView/WebFrameView.mm:
13143 (-[WebFrameView _scrollToBeginningOfDocument]):
13144 Use _isScrollable instead of _hasScrollBars.
13145 (-[WebFrameView _scrollToEndOfDocument]):
13147 (-[WebFrameView scrollToBeginningOfDocument:]):
13148 Use _largestScrollableChild instead of _largestChildWithScrollBars.
13149 (-[WebFrameView scrollToEndOfDocument:]):
13151 (-[WebFrameView _pageVertically:]):
13152 Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
13153 and _largestChildWithScrollBars.
13154 (-[WebFrameView _pageHorizontally:]):
13156 (-[WebFrameView _scrollLineVertically:]):
13158 (-[WebFrameView _scrollLineHorizontally:]):
13160 (-[WebFrameView keyDown:]):
13161 Use _largestScrollableChild instead of _largestChildWithScrollBars.
13162 (-[WebFrameView _isScrollable]):
13163 New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
13164 -[WebDynamicScrollBarsView verticalScrollingAllowed]
13165 (-[WebFrameView _largestScrollableChild]):
13166 New method, like _largestChildWithScrollBars but uses _isScrollable.
13167 (-[WebFrameView _hasScrollBars]):
13168 Added a comment that this is no longer used by Safari, and can thus probably be
13169 deleted once we no longer want to support it for nightly build compatibility with
13170 old versions of Safari.
13171 (-[WebFrameView _largestChildWithScrollBars]):
13174 * WebView/WebFrameViewPrivate.h:
13175 Declared -_isScrollable and -_largestScrollableChild. Added comments to
13176 _hasScrollBars and _largestChildWithScrollBars saying that they are no longer
13177 used by Safari, and can thus probably be deleted once we no longer want to
13178 support them for nightly build compatibility with old versions of Safari.
13180 2010-03-15 John Sullivan <sullivan@apple.com>
13182 Method name and parameter name mistakes from recent SPI addition
13183 <https://bugs.webkit.org/show_bug.cgi?id=36119>
13185 Reviewed by Dan Bernstein.
13187 * WebView/WebDynamicScrollBarsView.h:
13188 Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
13190 * WebView/WebDynamicScrollBarsView.mm:
13191 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
13192 Updated for renamed instance variable and method.
13193 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
13194 Changed parameter name from shouldBeVisible to shouldBeHidden.
13195 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
13197 (-[WebDynamicScrollBarsView contentViewFrame]):
13198 Updated for renamed instance variable.
13199 (-[WebDynamicScrollBarsView tile]):
13201 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
13204 * WebView/WebFrame.mm:
13205 (-[WebFrame setAllowsScrollersToOverlapContent:]):
13206 Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
13208 * WebView/WebFramePrivate.h:
13209 Renamed method name from "setAllowXXX" to "setAllowsXXX".
13211 2010-03-14 Darin Adler <darin@apple.com>
13213 Reviewed by Mark Rowe.
13215 Remove unneeded dependency on non-string identifier for an NSTableColumn
13216 https://bugs.webkit.org/show_bug.cgi?id=36106
13218 * WebView/WebTextCompletionController.mm:
13219 (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
13220 because the table has only one column and that column does not need an identifier.
13222 2010-03-12 Beth Dakin <bdakin@apple.com>
13224 Reviewed by Simon Fraser.
13226 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
13227 API naming is inconsistent
13228 -and corresponding-
13229 <rdar://problem/7729165>
13231 This patch changes all occurrences of "fullScreen" to the more
13232 popular "fullscreen."
13234 * Plugins/Hosted/NetscapePluginHostProxy.h:
13235 (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
13236 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13237 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
13238 (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
13239 (WebKit::NetscapePluginHostProxy::didExitFullscreen):
13240 (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
13241 (WKPCSetFullscreenWindowIsShowing):
13242 * Plugins/Hosted/WebKitPluginClient.defs:
13243 * Plugins/WebNetscapePluginView.mm:
13244 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
13245 (-[WebNetscapePluginView _createPlugin]):
13246 (-[WebNetscapePluginView _destroyPlugin]):
13247 * WebView/WebVideoFullscreenHUDWindowController.mm:
13248 (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
13250 2010-03-12 Andy Estes <aestes@apple.com>
13252 Reviewed by Brady Eidson.
13254 Expose WebPDFView's underlying PDFDocument.
13256 https://bugs.webkit.org/show_bug.cgi?id=36045
13258 * WebView/WebDocumentPrivate.h: Create a new protocol called
13260 * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
13261 * WebView/WebPDFView.mm:
13262 (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
13263 PDFDocument by implementing -(PDFDocument*)PDFDocument from
13266 2010-03-12 Andy Estes <aestes@apple.com>
13268 Reviewed by Brady Eidson.
13270 Remove an unused method.
13272 https://bugs.webkit.org/show_bug.cgi?id=35940
13274 * Plugins/WebPluginController.mm:
13275 removed - (void)showURL:(NSURL *) inFrame:(NSString *)
13277 2010-03-11 Mark Rowe <mrowe@apple.com>
13279 Reviewed by David Kilzer.
13281 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
13283 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
13285 * Configurations/Base.xcconfig:
13287 2010-03-11 Mark Rowe <mrowe@apple.com>
13289 Reviewed by Tim Hatcher.
13291 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
13293 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
13294 current Mac OS X version unless otherwise specified.
13296 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
13298 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
13299 may not be usable when targetting a different Mac OS X version.
13301 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
13302 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
13304 * Configurations/Base.xcconfig:
13305 * Configurations/DebugRelease.xcconfig:
13306 * Configurations/FeatureDefines.xcconfig:
13307 * Configurations/Version.xcconfig:
13309 2010-03-11 Anders Carlsson <andersca@apple.com>
13311 Reviewed by David Hyatt.
13313 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
13315 * WebCoreSupport/WebChromeClient.h:
13316 * WebCoreSupport/WebChromeClient.mm:
13318 2010-03-11 Alexey Proskuryakov <ap@apple.com>
13320 Reviewed by Geoff Garen.
13322 https://bugs.webkit.org/show_bug.cgi?id=35965
13323 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
13325 Test: plugins/round-trip-npobject.html
13327 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13328 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is
13329 now a separate ProxyRuntimeObject class for proxy pbjects.
13330 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
13332 * Plugins/Hosted/ProxyInstance.mm:
13333 (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in
13334 could have crashed while we were waiting for response.
13335 (WebKit::ProxyInstance::setFieldValue): Ditto.
13337 2010-03-10 Simon Fraser <simon.fraser@apple.com>
13339 Reviewed by Darin Adler.
13341 https://bugs.webkit.org/show_bug.cgi?id=35975
13342 <rdar://problem/7739922> Flash 10.1b crashes when generating snapshots
13344 Do a version check before sending a drawRect event to a Flash plugin,
13345 since 10.1.d51 has a bug that crashes when called this way.
13347 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13348 (-[WebHostedNetscapePluginView drawRect:]):
13349 * Plugins/WebBaseNetscapePluginView.h:
13350 * Plugins/WebBaseNetscapePluginView.mm:
13351 (-[WebBaseNetscapePluginView supportsSnapshotting]):
13352 * Plugins/WebNetscapePluginView.mm:
13353 (-[WebNetscapePluginView drawRect:]):
13355 2010-03-10 John Sullivan <sullivan@apple.com>
13357 Reviewed by Tim Hatcher.
13359 <rdar://problem/7735387> input type other than text won't work with autofill
13360 <https://bugs.webkit.org/show_bug.cgi?id=35963>
13362 * WebView/WebHTMLRepresentation.mm:
13363 (-[WebHTMLRepresentation elementDoesAutoComplete:]):
13364 Return true for any text field that's not a password, rather than only
13367 2010-03-09 Brady Eidson <beidson@apple.com>
13369 Reviewed by Tim Hatcher.
13371 REGRESSION: WebInspector docking busted on Windows
13372 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
13374 * WebCoreSupport/WebInspectorClient.mm:
13375 (-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
13376 (-[WebInspectorWindowController attach]): Ditto.
13377 (-[WebInspectorWindowController detach]): Ditto.
13379 2010-03-09 Geoffrey Garen <ggaren@apple.com>
13381 Reviewed by Darin Adler.
13383 Updated for FastMalloc reporting changes.
13385 * Misc/WebCoreStatistics.mm:
13386 (+[WebCoreStatistics memoryStatistics]):
13388 2010-03-08 Simon Fraser <simon.fraser@apple.com>
13390 Reviewed by Mark Rowe.
13392 Move the new method to the end of the MIG definitions file, to avoid breaking
13393 compatibility between WebKit and older versions of WebKitPluginHost.
13395 * Plugins/Hosted/WebKitPluginHost.defs:
13397 2010-03-08 Simon Fraser <simon.fraser@apple.com>
13399 Reviewed by Kevin Decker.
13401 <rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins
13403 Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
13404 by sending them a drawRect event as if they were software-painting.
13406 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
13407 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13408 (WebKit::NetscapePluginInstanceProxy::snapshot):
13409 New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
13411 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13412 (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing
13413 a flattening paint, then call the snapshot method.
13415 * Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
13417 * Plugins/WebBaseNetscapePluginView.h:
13418 * Plugins/WebBaseNetscapePluginView.mm:
13419 (-[WebBaseNetscapePluginView inFlatteningPaint]):
13420 New utility method that asks the FrameView whether the current paint behavior is
13423 * Plugins/WebNetscapePluginView.mm:
13424 (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening
13425 paint, go ahead and send a drawRect event to the plug-in.
13427 2010-03-08 Darin Adler <darin@apple.com>
13429 Reviewed by Dan Bernstein.
13431 Fix crash when you quit inside an unload handler.
13432 rdar://problem/6958347
13434 Test: manual-tests/quit-inside-unload.html
13436 * WebView/WebView.mm:
13437 (-[WebView _closeWithFastTeardown]): Removed code to set
13438 _private->closed since _close now does this earlier, before
13439 calling this method.
13440 (-[WebView _close]): Moved code to set _private->closed to the
13441 top of this method.
13442 (-[WebView setHostWindow:]): Rewrote the code that forbade
13443 setting the host window after closing so that it only forbids
13444 non-nil host windows. That way, the code to clear away the host
13445 window can run safely after setting _private->closed, yet client
13446 code cannot set a new host window after closing.
13448 2010-03-08 Darin Adler <darin@apple.com>
13450 Roll out a file I checked in by accident.
13452 * WebView/WebView.mm: Back to previous version.
13454 2010-03-08 Chris Marrin <cmarrin@apple.com>
13456 Reviewed by Darin Adler.
13458 Turn on HW accel on Leopard even if coreVideoHas7228836Fix() is false, when WebGL is enabled
13459 https://bugs.webkit.org/show_bug.cgi?id=35759
13461 This allows WebGL to work on Leopard without the fix. It exposes these users to the crash
13462 that happens because of the CoreVideo bug, but it limits the exposure to those who have
13463 chosen to enable WebGL.
13465 * WebView/WebView.mm:
13466 (-[WebView _preferencesChangedNotification:]):
13468 2010-03-02 Adam Treat <atreat@rim.com>
13470 Reviewed by Dave Hyatt.
13472 Adapt the mac port to the refactoring of repaint methods.
13474 https://bugs.webkit.org/show_bug.cgi?id=34214
13476 * WebCoreSupport/WebChromeClient.h:
13477 * WebCoreSupport/WebChromeClient.mm:
13478 (WebChromeClient::invalidateContents):
13479 (WebChromeClient::invalidateWindow):
13480 (WebChromeClient::invalidateContentsAndWindow):
13481 (WebChromeClient::invalidateContentsForSlowScroll):
13483 2010-03-08 Jian Li <jianli@chromium.org>
13485 Reviewed by Dmitry Titov.
13487 Blob.slice support.
13488 https://bugs.webkit.org/show_bug.cgi?id=32993
13490 Add ENABLE_BLOB_SLICE feature define.
13492 * Configurations/FeatureDefines.xcconfig:
13494 2010-03-08 Eric Uhrhane <ericu@chromium.org>
13496 Reviewed by David Levin.
13498 Remove the now-redundant Settings fields for the Database
13499 https://bugs.webkit.org/show_bug.cgi?id=35763
13501 No new tests; this code isn't called.
13503 * WebView/WebView.mm: Remove the call into Settings.
13504 (-[WebView _preferencesChangedNotification:]):
13506 2010-03-07 Mark Rowe <mrowe@apple.com>
13508 Rubber-stamped by Cameron Zwarich.
13510 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
13512 * Misc/WebIconDatabase.mm:
13514 2010-03-07 Mark Rowe <mrowe@apple.com>
13516 Rubber-stamped by Cameron Zwarich.
13518 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
13520 * Misc/WebNSPasteboardExtras.mm:
13522 2010-03-04 Mark Rowe <mrowe@apple.com>
13524 Reviewed by Sam Weinig.
13526 <rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
13528 * MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
13530 2010-03-04 Mark Rowe <mrowe@apple.com>
13532 Reviewed by Sam Weinig.
13534 Use a framework-style include to pull in WebInspector.h for consistency
13535 with other parts of WebKit.
13537 * WebInspector/WebInspectorPrivate.h:
13539 2010-03-04 Brady Eidson <beidson@apple.com>
13541 Reviewed by Geoff Garen.
13543 REGRESSION (31281): -[WebArchive initWithCoder:] leaks
13544 <rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
13546 * WebView/WebArchive.mm:
13547 (-[WebArchive initWithCoder:]): Don't retain objects we don't own.
13549 2010-03-03 Alexey Proskuryakov <ap@apple.com>
13551 Reviewed by Timothy Hatcher.
13553 https://bugs.webkit.org/show_bug.cgi?id=35692
13554 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
13556 * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
13557 Retain the challenge, just like it's done for sheet.
13559 2010-03-02 Eric Uhrhane <ericu@chromium.org>
13561 Reviewed by David Levin.
13563 Move database enable bit fully out of settings
13564 This is stage one of a three-stage commit [webkit, then chromium, then
13565 webkit again]. In this change I'm adding calls to
13566 Database::setIsAvailable inside Settings::setDatabaseEnabled and
13567 anywhere else that called it, and switching webkit fully over to using
13568 that flag [added in a previous checkin]. Phase two will remove
13569 Chromium's use of Settings for the Database, and phase three will remove
13570 the Setting for the Database enable entirely, leaving only
13571 Database::isAvailable/setIsAvailable.
13573 No new tests; tested by existing storage tests.
13575 https://bugs.webkit.org/show_bug.cgi?id=35310
13577 * WebView/WebView.mm: Added a call to Database::setIsAvailable.
13578 (-[WebView _preferencesChangedNotification:]):
13580 2010-03-02 Adam Roben <aroben@apple.com>
13582 Add -[WebView _registerURLSchemeAsSecure:]
13584 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
13585 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
13587 Reviewed by Tim Hatcher.
13589 * WebView/WebView.mm:
13590 (+[WebView _registerURLSchemeAsSecure:]):
13591 * WebView/WebViewPrivate.h:
13592 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
13594 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
13596 Reviewed by Adam Barth.
13598 Adapt to the new ZoomMode enum.
13599 https://bugs.webkit.org/show_bug.cgi?id=35347
13601 * WebView/WebView.mm:
13602 (-[WebView _preferencesChangedNotification:]):
13603 (-[WebView _setZoomMultiplier:isTextOnly:]):
13604 (-[WebView _realZoomMultiplierIsTextOnly]):
13606 2010-02-27 Jing Jin <jjin@apple.com>
13608 Reviewed by Timothy Hatcher.
13610 Move implementation of Bug 35449 into WebFramePrivate.
13612 * WebView/WebFrame.h:
13613 * WebView/WebFrame.mm:
13614 (-[WebFrame setAllowScrollersToOverlapContent:]):
13615 (-[WebFrame setAlwaysHideHorizontalScroller:]):
13616 (-[WebFrame setAlwaysHideVerticalScroller:]):
13617 * WebView/WebFramePrivate.h:
13619 2010-02-26 Jing Jin <jjin@apple.com>
13621 Reviewed by Timothy Hatcher.
13623 https://bugs.webkit.org/show_bug.cgi?id=35449
13624 Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
13626 * WebView/WebDynamicScrollBarsView.h:
13627 * WebView/WebDynamicScrollBarsView.mm:
13628 (-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
13629 overlap with the document and re-layouts the document.
13630 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
13631 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
13632 (-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
13633 on allowScrollersToOverlapContent.
13634 (-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
13635 contentView's frame so it overlaps with the scrollbar.
13636 (-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
13637 and hideVerticalScroller.
13638 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
13639 scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
13640 * WebView/WebDynamicScrollBarsViewInternal.h:
13641 * WebView/WebFrame.h:
13642 * WebView/WebFrame.mm:
13643 (-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
13644 (-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
13645 (-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
13647 2010-02-26 Gavin Barraclough <barraclough@apple.com>
13649 Reviewed by Alexey Proskuryakov.
13651 Bug 35401 - Fix handling of errors in handling calls over bridge,
13652 where base object bridge-type does not match method bridge-type.
13654 The code assumes users will only attempt to invoke a Java method
13655 on a Java base object, etc.
13656 Add language specific subclasses of RuntimeMethod, and pass the
13657 RuntimeMethod into invokeMethod, so we can typecheck before
13658 casting. Throw an exception on type mismatch.
13660 * Plugins/Hosted/ProxyInstance.h:
13661 * Plugins/Hosted/ProxyInstance.mm:
13662 (WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
13663 (WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
13664 (WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
13666 2010-02-25 Alexey Proskuryakov <ap@apple.com>
13668 Reviewed by Geoffrey Garen.
13670 https://bugs.webkit.org/show_bug.cgi?id=35394
13671 <rdar://problem/7685262> Make passing objects between Java and plug-ins work
13673 Added a ProxyInstance implementation of RuntimeObject.
13675 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13676 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
13677 * Plugins/Hosted/ProxyInstance.h:
13678 * Plugins/Hosted/ProxyInstance.mm:
13679 (WebKit::ProxyInstance::newRuntimeObject):
13680 (WebKit::ProxyInstance::getClass):
13681 * Plugins/Hosted/ProxyRuntimeObject.h: Added.
13682 (WebKit::ProxyRuntimeObject::classInfo):
13683 * Plugins/Hosted/ProxyRuntimeObject.mm: Added.
13684 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
13685 (WebKit::ProxyRuntimeObject::~ProxyRuntimeObject):
13686 (WebKit::ProxyRuntimeObject::getInternalProxyInstance):
13688 2010-02-24 Adam Barth <abarth@webkit.org>
13690 Reviewed by Darin Fisher.
13692 [Chromium API] Disambiguate allowJavaScript from didNotAllowScript
13693 https://bugs.webkit.org/show_bug.cgi?id=35205
13695 Make these two callsites explicit about not running script immediately.
13697 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13698 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
13699 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
13701 2010-02-23 Brady Eidson <beidson@apple.com>
13703 Reviewed by Tim Hatcher and Pavel Feldman.
13705 Regression (r55107) - WebInspector docking is busted.
13706 https://bugs.webkit.org/show_bug.cgi?id=35274
13708 * WebCoreSupport/WebInspectorClient.mm:
13709 (-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
13710 to get the expected behavior.
13712 2010-02-23 Dan Bernstein <mitz@apple.com>
13714 Reviewed by Simon Fraser.
13716 <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
13717 https://bugs.webkit.org/show_bug.cgi?id=34381
13719 Test: fast/repaint/repaint-during-scroll.html
13721 NSClipView offsets any rects marked as needing display during scrolling
13722 by the scroll offset. Compensate for this when -setNeedsDisplay: is called
13725 * WebView/WebHTMLView.mm:
13726 (-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
13727 around to call to FrameView::scrollPositionChanged().
13728 (-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
13729 scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
13731 2010-02-23 Steve Block <steveblock@google.com>
13733 Reviewed by Darin Adler.
13735 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
13736 https://bugs.webkit.org/show_bug.cgi?id=34962
13738 This method is required so that a Geolocation object can cancel an
13739 asynchronous permission request. This allows the chrome client to cancel
13740 any UI it is showing for the permission request.
13742 * WebCoreSupport/WebChromeClient.h:
13743 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
13745 2010-02-22 Alexey Proskuryakov <ap@apple.com>
13747 Rubber-stamped by Geoff Garen.
13749 Rename RuntimeObjectImp to RuntimeObject.
13751 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13752 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
13753 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
13754 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
13756 2010-02-22 Brady Eidson <beidson@apple.com>
13758 Reviewed by Tim Hatcher.
13760 Disable WebView docking to views that are too small.
13761 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
13763 * WebCoreSupport/WebInspectorClient.mm:
13764 (-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
13765 window attached if WebCore says it shouldn't be attached.
13767 2010-02-22 Simon Fraser <simon.fraser@apple.com>
13769 Reviewed by John Sullivan.
13771 <rdar://problem/7285392>
13772 On Leopard, we have to disable hardware acceleration if we detect that the
13773 installed Core Video framework has bug <rdar://problem/7228836>.
13775 * WebView/WebView.mm:
13776 (coreVideoHas7228836Fix):
13777 (-[WebView _preferencesChangedNotification:]):
13779 2010-02-21 Dan Bernstein <mitz@apple.com>
13781 Reviewed by Darin Adler.
13783 False warnings about needing layout in
13784 -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
13785 https://bugs.webkit.org/show_bug.cgi?id=35218
13787 * WebView/WebHTMLView.mm:
13788 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
13789 Suppress the warning and the forced layout if the view is not being drawn
13790 in this display operation.
13792 2010-02-21 Kevin Decker <kdecker@apple.com>
13794 Reviewed by Sam Weinig.
13796 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey
13797 https://bugs.webkit.org/show_bug.cgi?id=35215
13798 <rdar://problem/7673157>
13800 The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
13801 is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
13802 the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
13803 would incorrectly pass the source URL of the plug-in resource.
13805 * WebCoreSupport/WebFrameLoaderClient.mm:
13806 (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the
13807 real base URL for the WebPlugInBaseURLKey key.
13809 2010-02-19 Maciej Stachowiak <mjs@apple.com>
13811 Reviewed by David Levin.
13813 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
13814 https://bugs.webkit.org/show_bug.cgi?id=35147
13816 * Configurations/FeatureDefines.xcconfig:
13818 2010-02-19 Alexey Proskuryakov <ap@apple.com>
13820 Reviewed by Maciej Stachowiak.
13822 https://bugs.webkit.org/show_bug.cgi?id=35132
13823 <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
13825 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
13826 (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse
13827 move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout
13828 resorting to techniques such as fast firing timers.
13830 * Plugins/WebNetscapePluginView.mm:
13831 (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally,
13832 but those that don't just need to get an arrow cursor (matching Firefox). This means that
13833 e.g. a plugin inside <A> won't get a finger mouse pointer.
13835 * Plugins/WebHostedNetscapePluginView.mm:
13836 (-[WebNetscapePluginView handleMouseEntered:]):
13837 (-[WebNetscapePluginView handleMouseExited:]):
13838 Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on
13839 mouse exit, which it needed to do.
13841 * WebView/WebHTMLView.mm:
13842 (needsCursorRectsSupportAtPoint):
13844 (resetCursorRects):
13845 Make sure that the same workaround we have for Web content also applies to Netscape plug-ins,
13846 as AppKit would reset the mouse pointer to arrow if given a chance.
13847 (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent
13848 confusion - the method we override is completely different.
13849 (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
13851 2010-02-19 Simon Fraser <simon.fraser@apple.com>
13853 Reviewed by Dan Bernstein.
13855 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
13857 Followup to avoid capturing compositing layers twice in snapshots. Add private
13858 methods to WebView to specify whether drawing the WebView into an image will
13859 include flattened compositing layers (the default behavior) or not.
13861 * WebView/WebFrame.mm:
13862 (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we
13865 * WebView/WebViewPrivate.h: New methods.
13866 * WebView/WebView.mm: Ditto.
13867 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
13868 (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]):
13869 (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
13871 * WebView/WebViewData.h: New member variable.
13873 2010-02-19 Alexey Proskuryakov <ap@apple.com>
13875 Reviewed by Dan Bernstein.
13877 https://bugs.webkit.org/show_bug.cgi?id=35165
13878 plugins/set-status.html fails on Windows bot
13880 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13881 (WebKit::NetscapePluginInstanceProxy::status):
13882 * Plugins/WebNetscapePluginView.mm:
13883 (-[WebNetscapePluginView status:]):
13884 Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
13885 empty ones to chrome.
13887 2010-02-18 Simon Fraser <simon.fraser@apple.com>
13889 Reviewed by Dan Bernstein.
13891 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
13893 Add logic to determine when painting via the software rendering path will give an equivalent
13894 result to the accelerated compositing presentation. This tests for the presence of 3D transforms.
13896 Also have -[WebFrame _drawRect:contentsOnly:] set the PaintBehaviorFlattenCompositingLayers
13897 paint behavior when painting into a bitmap context, so that snapshots contain composited layers.
13899 * WebView/WebFrame.mm:
13900 (-[WebFrame _drawRect:contentsOnly:]): Set the PaintBehaviorFlattenCompositingLayers flag
13901 when painting into a bitmap context.
13902 * WebView/WebView.mm:
13903 (-[WebView _isSoftwareRenderable]): Returns YES if all frames can be software-rendered.
13904 * WebView/WebViewPrivate.h: New _isSoftwareRenderable method.
13906 2010-02-18 Alexey Proskuryakov <ap@apple.com>
13908 Reviewed by Dan Bernstein.
13910 https://bugs.webkit.org/show_bug.cgi?id=35134
13911 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
13913 Test: plugins/set-status.html
13915 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13916 (WebKit::NetscapePluginInstanceProxy::status):
13917 (WebKit::NetscapePluginInstanceProxy::loadURL):
13918 Added null checks for CFStringCreateWithCString arguments.
13920 2010-02-17 Dmitry Titov <dimich@chromium.org>
13922 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
13924 When a live iframe element is moved between pages, it still depends on the old page.
13925 https://bugs.webkit.org/show_bug.cgi?id=34382
13927 * WebCoreSupport/WebFrameLoaderClient.h:
13928 * WebCoreSupport/WebFrameLoaderClient.mm:
13929 Added empty implementation of a new virtual method.
13931 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
13933 2010-02-17 Kent Tamura <tkent@chromium.org>
13935 Reviewed by Eric Seidel.
13937 Introduces new Icon loading interface in order to support
13938 asynchronous loading.
13939 https://bugs.webkit.org/show_bug.cgi?id=32054
13941 Add an empty implementation of ChromeClient::iconForFiles().
13943 * WebCoreSupport/WebChromeClient.h:
13944 * WebCoreSupport/WebChromeClient.mm:
13945 (WebChromeClient::iconForFiles):
13947 2010-02-17 Timothy Hatcher <timothy@apple.com>
13949 Add a way for WebView and its dependancies to be selectively included
13950 in WebKitStatistics leak tracking. By default WebView is not included and
13951 you need to subclass WebView and implement +isIncludedInWebKitStatistics
13954 rdar://problem/7567677&7572900
13955 https://webkit.org/b/35045
13957 Reviewed by Adam Roben.
13959 * WebView/WebDataSource.mm:
13960 (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
13961 (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
13962 (-[WebDataSource finalize]): Ditto.
13963 * WebView/WebFrame.mm:
13964 (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
13965 (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
13966 (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
13967 (-[WebFrame finalize]): Ditto.
13968 * WebView/WebFrameInternal.h:
13969 * WebView/WebFrameView.mm:
13970 (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
13971 (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
13972 know what WebFrame we belong to yet.
13973 (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
13974 (-[WebFrameView finalize]): Ditto.
13975 * WebView/WebHTMLRepresentation.mm:
13976 (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
13977 know what WebFrame we belong to yet.
13978 (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
13979 (-[WebHTMLRepresentation finalize]): Ditto.
13980 (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
13981 included in statistics.
13982 * WebView/WebView.mm:
13983 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
13984 (-[WebView dealloc]):
13985 (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
13986 Subclasses that care can return YES to be included.
13987 * WebView/WebViewInternal.h:
13989 2010-02-16 Darin Adler <darin@apple.com>
13991 Reviewed by Sam Weinig.
13993 Generalize delayed plug-in start for background tabs for use for other media
13994 https://bugs.webkit.org/show_bug.cgi?id=34981
13996 * WebView/WebHTMLView.mm:
13997 (-[WebHTMLView viewWillMoveToWindow:]): Added comment.
13998 (-[WebHTMLView viewDidMoveToWindow]): Ditto.
14000 * WebView/WebView.mm:
14001 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
14002 Call setCanStartMedia right away so that if this view is not in a window, it
14003 will not start any media.
14004 (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving
14005 to a window of nil.
14006 (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to
14007 a window that is non-nil.
14009 2010-02-16 Eric Carlson <eric.carlson@apple.com>
14011 Reviewed by Simon Fraser.
14013 https://bugs.webkit.org/show_bug.cgi?id=34988
14014 WebHTMLView.mm has two -willRemoveSubview: methods
14016 * WebView/WebHTMLView.mm:
14017 (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
14019 2010-02-16 Alexey Proskuryakov <ap@apple.com>
14021 Reviewed by Geoffrey Garen and Kevin Decker.
14023 https://bugs.webkit.org/show_bug.cgi?id=34989
14024 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
14026 This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
14027 in the former case, and adjustCursor in the latter).
14029 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
14030 (-[WebHostedNetscapePluginView handleMouseEntered:]):
14031 (-[WebHostedNetscapePluginView handleMouseExited:]):
14032 * Plugins/WebBaseNetscapePluginView.h:
14033 * Plugins/WebBaseNetscapePluginView.mm:
14034 (-[WebBaseNetscapePluginView handleMouseEntered:]):
14035 (-[WebBaseNetscapePluginView handleMouseExited:]):
14036 * Plugins/WebNetscapePluginView.h:
14037 * Plugins/WebNetscapePluginView.mm:
14038 (-[WebNetscapePluginView handleMouseEntered:]):
14039 (-[WebNetscapePluginView handleMouseExited:]):
14040 AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to
14041 notify plug-in views of mouse entered/exited as part of DOM event dispatch.
14043 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides
14044 mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event
14045 handler. Other mouse events are passed down by EventHandler.
14047 2010-02-15 Alexey Proskuryakov <ap@apple.com>
14049 More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
14050 headers that aren't included in 64-bit).
14052 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14053 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14054 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains):
14055 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
14056 Move inline functions to .cpp; also made the class Noncopyable.
14058 2010-02-15 Alexey Proskuryakov <ap@apple.com>
14060 Mac release build fix attempt.
14062 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14063 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14064 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap):
14065 Implement destructor in .cpp file, where necessary headers are already included.
14067 2010-02-12 Alexey Proskuryakov <ap@apple.com>
14069 Reviewed by Kevin Decker.
14071 <rdar://problem/7130641> Browser objects identity is not preserved by Safari
14073 Out of process part.
14075 To avoid excessive IPC, plugin process doesn't send each NPObject release/retain call to
14076 Safari. It only sends one when the last one is removed, and it can destroy the proxy
14079 However, the browser may be sending the same object out to plug-in as a function call
14080 argument at the same time - neither side can know what the other one is up to. The solution
14081 is to make the "destroying object" call return a boolean result, making it possible for
14082 the browser to make plugin host keep the proxy with zero refcount for a little longer.
14084 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14085 (WKPCForgetBrowserObject): This function (that used to be named ReleaseObject) is only
14086 called when plug-in releases all of its references, so renamed it. Its boolean result
14087 is returned as call success or failure.
14089 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14090 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap): Made the numeric ID to JSObject map
14093 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14094 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): This method is tricky
14095 in that it creates objects with refcount of 1, but doesn't increase refcount when returning
14096 found objects. This extra count accounts for the "reference" kept by plugin process.
14097 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): Only retaining for the
14098 duration of calls out to plug-in, which means that refcount is almost always equal to 1.
14099 Note that we can't use "++" here, due to how std::pair works!
14100 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): Ditto.
14101 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::clear): Clear all references when
14103 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Like release(), but only
14104 functional when recount is 1 (meaning that the object is not being sent out to plug-in at
14106 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Updated for other changes.
14107 (WebKit::NetscapePluginInstanceProxy::cleanup): Ditto.
14108 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): Ditto.
14109 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): Ditto.
14110 (WebKit::NetscapePluginInstanceProxy::forgetBrowserObjectID): Ditto.
14111 (WebKit::NetscapePluginInstanceProxy::evaluate): Ditto.
14112 (WebKit::NetscapePluginInstanceProxy::invoke): Ditto.
14113 (WebKit::NetscapePluginInstanceProxy::invokeDefault): Ditto.
14114 (WebKit::NetscapePluginInstanceProxy::construct): Ditto.
14115 (WebKit::NetscapePluginInstanceProxy::getProperty): Ditto.
14116 (WebKit::NetscapePluginInstanceProxy::setProperty): Ditto.
14117 (WebKit::NetscapePluginInstanceProxy::removeProperty): Ditto.
14118 (WebKit::NetscapePluginInstanceProxy::hasProperty): Ditto.
14119 (WebKit::NetscapePluginInstanceProxy::hasMethod): Ditto.
14120 (WebKit::NetscapePluginInstanceProxy::enumerate): Ditto.
14121 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Ditto.
14122 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
14123 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Helper for calling retain when
14124 making calls out to plug-in. No-op for objects that aren't wrapped to be sent (i.e. for
14125 objects wrapping ProxyInstance wrappers for plug-in objects being sent bak).
14126 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
14128 * Plugins/Hosted/ProxyInstance.mm:
14129 (WebKit::ProxyInstance::invoke): Retain/release arguments during call.
14130 (WebKit::ProxyInstance::setFieldValue): Ditto.
14132 * Plugins/Hosted/WebKitPluginClient.defs: Renamed PCReleaseObject to PCForgetBrowserObject.
14134 2010-02-12 Darin Adler <darin@apple.com>
14136 Reviewed by Sam Weinig.
14138 Removed unneeded custom implementation of isDescendantOf.
14140 * Plugins/WebBaseNetscapePluginView.mm:
14141 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
14142 -[NSView isDescendantOf:] method instead of our own method
14143 named superviewsHaveSuperviews.
14145 2010-02-12 Dan Bernstein <mitz@apple.com>
14147 Reviewed by Darin Adler.
14149 <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
14150 PDFKit to be loaded
14152 * WebView/WebPDFDocumentExtras.h: Removed the category declaration and
14153 addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
14154 * WebView/WebPDFDocumentExtras.mm:
14155 (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
14156 * WebView/WebPDFRepresentation.mm: Removed +initialize.
14157 (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
14158 allScriptsInPDFDocument() instead of -_web_allScripts.
14160 2010-02-10 Geoffrey Garen <ggaren@apple.com>
14162 Reviewed by Oliver Hunt.
14164 Exported some new JavaScript heap introspection.
14166 * Misc/WebCoreStatistics.h:
14167 * Misc/WebCoreStatistics.mm:
14168 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
14169 javaScriptProtectedObjectTypeCounts, except this function enumerates all
14170 live objects, not just protected objects.
14172 2010-02-08 Maciej Stachowiak <mjs@apple.com>
14174 Reviewed by Cameron Zwarich.
14176 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
14177 https://bugs.webkit.org/show_bug.cgi?id=34698
14179 * Configurations/FeatureDefines.xcconfig:
14181 2010-02-09 Alexey Proskuryakov <ap@apple.com>
14183 Reviewed by Geoffrey Garen.
14185 https://bugs.webkit.org/show_bug.cgi?id=34490
14186 WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
14188 * ForwardingHeaders/wtf/ValueCheck.h: Added.
14190 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
14192 Reviewed by Kenneth Rohde Christiansen.
14194 Support frameset flattening
14195 https://bugs.webkit.org/show_bug.cgi?id=32717
14197 Add support for enabling/disabling FrameSet Flattening on the Mac port.
14199 * WebView/WebPreferenceKeysPrivate.h:
14200 * WebView/WebPreferences.mm:
14201 (+[WebPreferences initialize]):
14202 (-[WebPreferences isFrameSetFlatteningEnabled]):
14203 (-[WebPreferences setFrameSetFlatteningEnabled:]):
14204 * WebView/WebPreferencesPrivate.h:
14205 * WebView/WebView.mm:
14206 (-[WebView _preferencesChangedNotification:]):
14208 2010-02-09 Alexey Proskuryakov <ap@apple.com>
14210 Reviewed by Anders Carlsson.
14212 https://bugs.webkit.org/show_bug.cgi?id=34771
14213 A stray mouse moved event is sent to plug-ins after mouse exit
14215 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout
14216 DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a
14217 mouse moved event to plug-ins at this point.
14219 2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
14221 Reviewed by Darin Adler.
14223 Provide a way to get total number of pages to be printed
14224 https://bugs.webkit.org/show_bug.cgi?id=34699
14226 * Misc/WebCoreStatistics.h:
14227 * Misc/WebCoreStatistics.mm:
14228 (-[WebFrame numberOfPages:pageWidthInPixels:]):
14230 2010-02-08 Alexey Proskuryakov <ap@apple.com>
14232 Reviewed by Darin Adler.
14234 https://bugs.webkit.org/show_bug.cgi?id=34727
14235 Assertion crashes and freezes when plug-in property access results in an exception
14237 * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async.
14238 A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need
14239 to listen for messages while waiting for reply.
14241 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14242 (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency
14243 between method implementations, and leaves us with one less IPC call to make in failure case
14244 (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin
14246 (WKPCInvoke): Ditto.
14247 (WKPCInvokeDefault): Ditto.
14248 (WKPCGetProperty): Ditto.
14249 (WKPCSetProperty): Send a reply once done.
14250 (WKPCRemoveProperty): Ditto.
14251 (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE.
14252 (WKPCHasMethod): Ditto.
14253 (WKPCEnumerate): Ditto.
14255 2010-02-08 Alexey Proskuryakov <ap@apple.com>
14257 Reviewed by Anders Carlsson.
14259 <rdar://problem/6530010> OOP: Support NPN_SetException
14261 Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
14263 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14264 (WKPCSetException):
14265 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14266 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14267 (WebKit::globalExceptionString):
14268 (WebKit::NetscapePluginInstanceProxy::setGlobalException):
14269 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
14270 * Plugins/Hosted/ProxyInstance.mm:
14271 (WebKit::ProxyInstance::invoke):
14272 (WebKit::ProxyInstance::getPropertyNames):
14273 (WebKit::ProxyInstance::fieldValue):
14274 (WebKit::ProxyInstance::setFieldValue):
14275 * Plugins/Hosted/WebKitPluginClient.defs:
14276 Route exception string to a global that's checked after calling into plug-in (just like in
14279 2010-02-05 Kevin Decker <kdecker@apple.com>
14281 Reviewed by Mark Rowe.
14283 https://bugs.webkit.org/show_bug.cgi?id=34661
14284 <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
14286 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
14287 (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
14288 * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
14289 * Plugins/WebBaseNetscapePluginView.mm:
14290 (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
14291 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
14292 * Plugins/WebNetscapePluginView.mm:
14293 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
14295 2010-02-04 Mark Rowe <mrowe@apple.com>
14297 Rubber-stamped by Dan Bernstein.
14299 Fix the ability to #include <WebKit/DOMFile.h>.
14301 * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
14303 2010-02-04 John Sullivan <sullivan@apple.com>
14305 https://bugs.webkit.org/show_bug.cgi?id=34611
14306 WebLocalizedString() could use an assertion that it is being called on the main thread
14308 Reviewed by Tim Hatcher.
14310 * Misc/WebLocalizableStrings.m: Removed.
14311 * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
14312 Renamed to use .mm extension so it can include a C++ header.
14313 (WebLocalizedString):
14314 Added an assertion that this is being called on the main thread.
14316 2010-02-04 Dan Bernstein <mitz@apple.com>
14318 Reviewed by Simon Fraser.
14320 REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
14321 https://bugs.webkit.org/show_bug.cgi?id=34371
14323 * WebView/WebFrameView.mm:
14324 (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
14325 constants, and cap the scroll distance.
14326 (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
14327 cScrollbarPixelsPerLineStep.
14328 (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
14329 constants, and cap the scroll distance.
14331 2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
14333 Reviewed by Eric Seidel.
14335 Provide a way to get page number with layoutTestController
14336 https://bugs.webkit.org/show_bug.cgi?id=33840
14338 * Misc/WebCoreStatistics.h:
14339 * Misc/WebCoreStatistics.mm:
14340 (-[WebFrame pageNumberForElement:element:pageWidth:]):
14342 2010-01-29 Gavin Barraclough <barraclough@apple.com>
14344 Reviewed by Sam Weinig + Oliver Hunt.
14346 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
14348 Pass processeing user gensture flag to media play/pause methods.
14350 * WebView/WebVideoFullscreenHUDWindowController.mm:
14351 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
14353 2010-02-01 Dan Bernstein <mitz@apple.com>
14355 Reviewed by Anders Carlsson.
14357 <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
14359 The crash was caused by having two streams with a streamID of 1.
14361 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14362 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
14363 correctly increments m_currentURLRequestID to account for the manual stream.
14364 (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
14365 null it out instead of trying to remove it from the map. Added an assertion.
14366 (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
14368 == Rolled over to ChangeLog-2010-01-29 ==